D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes added a comment.


  This is how it looks now @ngraham :
  
  F6822188: suspendThenHibernate.png 

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes updated this revision to Diff 58044.
avaldes added a comment.


  Improved messages for suspend session

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16425?vs=56024=58044

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

AFFECTED FILES
  daemon/actions/bundled/suspendsessionconfig.cpp

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Siddhartha Sahu]

siddharthasahu added a comment.


  Hi David!
  
  Hmm, it seems the behavior is already different. I don't use sddm, but I 
tried it just now and found that the input field is already *not* disabled, 
plus, the notification that the login failed comes after the timeout. Looking 
at the qml code, the "Login Failed" message is displayed on the `onLoginFailed` 
signal, so it'd mean that this signal is delivered only after the grace period, 
which is different from the lock screen where (it appears) that the `onFailed` 
is delivered as soon as the password check fails.
  
  I don't know where the `onLoginFailed` signal is coming from in sddm (or 
where the `authenticator` in lockscreen is defined for that matter). This will 
need help with a deeper investigation from someone who knows the components 
well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Nathaniel Graham]

ngraham added a comment.


  Oh, duh, right. Yes, please change the login screen version too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  In D20186#464906 , @romangg wrote:
  
  > For the next release some pointers where still work could be done:
  >
  > - Touchpads do never feature acceleration profiles I believe.
  
  
  That's true for the moment, but this is planned for a future Libinput 
release. So maybe keep support in the backend just in case it ever materializes.
  
  > But for now let's celebrate finally shipping a fitting libinput KCM on X as 
well! Great job Atul! Thank you for your hard work and for being patient in the 
review process.
  
  Indeed. Party time for sure!!! Also @atulbi if you don't already have commit 
access you should seriously consider applying--especially given that you're now 
the maintainer of the touchpad KCM. See 
https://techbase.kde.org/Contribute/Get_a_Contributor_Account
  
  For now I can land this for you once you've adderssed the last of Roman's 
inline comments.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  I tested it now. I think it's working robustly and should still go in the 
upcoming release. We have the beta phase to further test then.
  
  For the next release some pointers where still work could be done:
  
  - Touchpads do never feature acceleration profiles I believe. Just never show 
the all the time disabled controls. Same holds for scroll button. The 
respective backend interfaces can then be cleaned out as well.
  - There is some weirdness going on if no touchpad is connected and one opens 
the touchpad KCM. Normally all controls should be greyed out. But at least on 
Wayland they are not but instead some of them are not shown.
  
  But for now let's celebrate finally shipping a fitting libinput KCM on X as 
well! Great job Atul! Thank you for your hard work and for being patient in the 
review process.

INLINE COMMENTS

> libinputcommon.h:2
>  /*
> - * Copyright 2017 Roman Gilg 
> + * Copyright 2019 Atul Bisht 
>   *

Most of the code in this file was written by me and is now copy-pasted. Please 
keep in my copyright and add your own above/below.

> libinputcommon.h:54
>  // general
> -Q_PROPERTY(QString name READ name CONSTANT)
> -Q_PROPERTY(bool supportsDisableEvents READ supportsDisableEvents 
> CONSTANT)
> -Q_PROPERTY(bool enabled READ isEnabled WRITE setEnabled NOTIFY 
> enabledChanged)
> +Q_PROPERTY(QString name READ name CONSTANT)//
> +Q_PROPERTY(bool supportsDisableEvents READ supportsDisableEvents 
> CONSTANT)//

rm these comment markers

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[David Edmundson]

davidedmundson added a comment.


  I don't want SDDM and the lockscreen to have subtly different behaviours.
  
  If one is changing, the other should too.
  
  See similar files in sddm-theme

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Siddhartha Sahu]

siddharthasahu added a comment.


  This one was easy enough. I definitely liked the fact that I could edit the 
qml files directly and test it live without going through a compilation step. I 
especially enjoyed it after I managed to crash the lock screen with a typo but 
was able to fix the stuck lock screen by editing the qml file in a tty and 
killing the lockscreen process to make it reload. On the other hand, a 
compilation step here would've prevented this in the first place!
  
  The rest of the code is still arcane magic to me though :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Nathaniel Graham]

ngraham added a comment.


  Yeah, isn't QML just so nice to work with!?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Siddhartha Sahu]

siddharthasahu added a comment.


  Cool! Thank you for the pointers to the correct place. It was much easier 
than I thought once I looked at the code.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Nathaniel Graham]

ngraham added a comment.


  In D16425#464725 , @avaldes wrote:
  
  > In D16425#464381 , @ngraham 
wrote:
  >
  > > This thing's UI really needs to be rewritten in QML. Once we do that and 
give it a proper FormLayout style, the string can be shorter, but for now, 
seeing it in context, I feel like  the string should be "Hibernate after 3 
hours of sleep".
  > >
  > > Also I wouldn't mind making the period configurable. If you don't want to 
do that in this patch though, that's fine.
  >
  >
  > The period configuration can only be done by adding a .conf file to any of 
these locations with the parameter HibernateDelaySec, current dbus API doesn't 
have anything to pass or modify this value, so user intervention is required to 
change the default timeout of 3 hours.
  >
  >   /etc/systemd/sleep.conf
  >   /etc/systemd/sleep.conf.d/*.conf
  >   /run/systemd/sleep.conf.d/*.conf
  >   /usr/lib/systemd/sleep.conf.d/*.conf
  >
  >
  > @ngraham there is currently a limitation with my current patch, as a user 
you will always have to enable the suspend after a period of time (Suspend 
Session > After) to enable the Suspend-then-hibernate option. I think this is 
not a good default, I can also move this option to a new group similar to 
"Buttons event handling", which also modifies the suspend behaviour.
  
  
  Maybe something like this?
  
[ ] Automatically sleep [after 30 minutes | v]
[ ] While asleep, hibernate after 3 hours
``

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah I see what you mean. It does look like the text field needs to become 
defocused for a brief moment to work around that bug. And it re-focused itself 
quickly while the button is still disabled. So I think this is good, thanks! 
Let's see what the #plasma  folks have 
to say before we land the patch though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Siddhartha Sahu]

siddharthasahu added a comment.


  That's correct. 2 points however:
  
  - I think the detection of a wrong password is very fast and at least on my 
system I immediately get the highlighted focus. When you say muted, is it slow 
to do this for you?
  - We probably can't do the immediate focus because of the bug mentioned on 
line 49: 
https://cgit.kde.org/plasma-workspace.git/tree/lookandfeel/contents/lockscreen/MainBlock.qml#n47.
 It seems if the password was entered correctly and the textbox has focus, the 
app would crash.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Nathaniel Graham]

ngraham added a comment.


  Thanks! In testing this out, I find that the impact is quite muted since the 
text field de-focuses itself after you press the return key. So in practice, if 
you realize that you typed the wrong password, you can't actually start typing 
immediately because the text field has lost its focus. I think it would keep to 
keep its focus while the button is disabled in order for this to work like 
you're intending.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Siddhartha Sahu]

siddharthasahu updated this revision to Diff 58025.
siddharthasahu added a comment.


  Update diff to master.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21192?vs=58019=58025

REVISION DETAIL
  https://phabricator.kde.org/D21192

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MainBlock.qml

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Nathaniel Graham]

ngraham added a comment.


  I'm afraid your patch does not apply for me:
  
$ arc patch D21192
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D21192.
Checking patch lookandfeel/contents/lockscreen/MainBlock.qml...
error: while searching for:
focus: true
echoMode: TextInput.Password
inputMethodHints: Qt.ImhHiddenText | Qt.ImhSensitiveData | 
Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText
enabled: !authenticator.graceLocked
revealPasswordButtonShown: true

onAccepted: {

error: patch failed: lookandfeel/contents/lockscreen/MainBlock.qml:59
error: while searching for:
PlasmaComponents.Button {
id: loginButton
Layout.fillWidth: true

text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Unlock")
onClicked: startLogin()

error: patch failed: lookandfeel/contents/lockscreen/MainBlock.qml:93
Checking patch lookandfeel/contents/lockscreen/LockScreenUi.qml...
Hunk #1 succeeded at 40 (offset 4 lines).
Applying patch lookandfeel/contents/lockscreen/MainBlock.qml with 2 
rejects...
Rejected hunk #1.
Rejected hunk #2.
Applied patch lookandfeel/contents/lockscreen/LockScreenUi.qml cleanly.

 Patch Failed! 
Usage Exception: Unable to apply patch!
  
  Did you work against git master, or the version that was on your machine? If 
the latter, you need to work on git master if you're going to submit a patch 
that will be applied against git master. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21194: [Holidays plugin] Port partially to QQC2

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port mostly to QQC2 (Don't touch the TableView since there's no QQC2 
version yet)
  - Use standard import names

TEST PLAN
  F6821868: Holidays plugin.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-holidays-plugin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21194

AFFECTED FILES
  plasmacalendarintegration/HolidaysConfig.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21193: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port to QQC2+Kirigami FormLayout style
  - Use standard import names
  - Adjust strings to fit in the FormLayout style

TEST PLAN
  F6821853: Astronomical plugins.png 

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-astronomical-calendar-plugin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21193

AFFECTED FILES
  plasmacalendarplugins/astronomical/config/qml/AstronomicalEventsConfig.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

[Siddhartha Sahu]

siddharthasahu created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
siddharthasahu requested review of this revision.

REVISION SUMMARY
  This is a patch to fix: https://bugs.kde.org/show_bug.cgi?id=407473

TEST PLAN
  I applied the diff on my system by directly modifying the files in 
/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/. 
With the patch, the input field does not get blocked anymore and I can edit the 
password while waiting for the graceLocked period to expire.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21192

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MainBlock.qml

To: siddharthasahu
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port to QQC2
  - Use Kirigami `BasicListItem` for the paths view
  - Use standard import names
  - Put the buttons below the lists to follow the general style

TEST PLAN
  F6821837: Paths category.png 

REPOSITORY
  R114 Plasma Addons

BRANCH
  mediaframe-modernize-paths-category (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21191

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigPaths.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes added a comment.


  In D16425#464381 , @ngraham wrote:
  
  > This thing's UI really needs to be rewritten in QML. Once we do that and 
give it a proper FormLayout style, the string can be shorter, but for now, 
seeing it in context, I feel like  the string should be "Hibernate after 3 
hours of sleep".
  >
  > Also I wouldn't mind making the period configurable. If you don't want to 
do that in this patch though, that's fine.
  
  
  The period configuration can only be done by adding a .conf file to any of 
these locations with the parameter HibernateDelaySec, current dbus API doesn't 
have anything to pass or modify this value, so user intervention is required to 
change the default timeout of 3 hours.
  
/etc/systemd/sleep.conf
/etc/systemd/sleep.conf.d/*.conf
/run/systemd/sleep.conf.d/*.conf
/usr/lib/systemd/sleep.conf.d/*.conf
  
  @ngraham there is currently a limitation with my current patch, as a user you 
will always have to enable the suspend after a period of time (Suspend Session 
> After) to enable the Suspend-then-hibernate option. I think this is not a 
good default, I can also move this option to a new group similar to "Buttons 
event handling", which also modifies the suspend behaviour.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21128: Improve keyboard navigation

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> mart wrote in delegaterecycler.cpp:373
> https://doc.qt.io/qt-5/qquickitem.html#Flag-enum
> 
> you can set the focusscope flag on top of any qquickitem, FocusScope is just 
> an empty item that doesn't do anything that setting thjat flag in its ctor
> 
> QQuickFocusScope::QQuickFocusScope(QQuickItem *parent)
> : QQuickItem(parent)
> {
> 
>   setFlag(ItemIsFocusScope);
> 
> }

I tried it, but it doesn't really make a difference, since the event was 
already being delivered to the item, the recycler, the problem was that the key 
stroke never reached the actual delegate.

I've changed it to use the declarative API, I think it looks more elegant.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D21128

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D21128: Improve keyboard navigation

[Aleix Pol Gonzalez]

apol updated this revision to Diff 58012.
apol added a comment.


  Go for a more elegant approach: use Keys.forwardsTo and expose the item

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21128?vs=57870=58012

BRANCH
  arcpatch-D21128

REVISION DETAIL
  https://phabricator.kde.org/D21128

AFFECTED FILES
  src/controls/private/CardsListViewPrivate.qml
  src/delegaterecycler.cpp
  src/delegaterecycler.h

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/33/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 13 May 2019 15:59:44 +
 Build duration:
31 sec and counting
   CONSOLE OUTPUT
  [...truncated 372 lines...][2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[ru]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[sk]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[sl]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[sr]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[sv]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[tr]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[uk]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[x-test]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to string[2019-05-13T16:00:09.676Z] Unknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to string[2019-05-13T16:00:09.676Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-pa/kf5-qt5 FreeBSDQt5.12/build/src/kcm/kcm_pulseaudio.json" [2019-05-13T16:00:09.676Z] [2019-05-13T16:00:09.676Z] About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-API" with type "QString"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-RootPath" with type "QString"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-MainScript" with type "QString"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-NotificationArea" with type "QString"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-DBusActivationService" with type "QString"[2019-05-13T16:00:09.676Z] Found property definition "X-KDE-ParentApp" with type "QString"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-Provides" with type "QStringList"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-PreloadWeight" with type "int"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-StandAloneApp" with type "bool"[2019-05-13T16:00:09.676Z] Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"[2019-05-13T16:00:09.676Z] Found property definition "NoDisplay" with type "bool"[2019-05-13T16:00:09.676Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-pa/kf5-qt5 FreeBSDQt5.12/build/applet/org.kde.plasma.volume-plasmoids-metadata.json" [2019-05-13T16:00:09.676Z] [2019-05-13T16:00:09.676Z] [ 13%] Automatic MOC for target kcm_pulseaudio[2019-05-13T16:00:09.676Z] [ 13%] Built target kcm_pulseaudio-kcms-metadata-json[2019-05-13T16:00:09.676Z] [ 13%] Built target org.kde.plasma.volume-plasmoids-metadata-json[2019-05-13T16:00:09.676Z] Scanning dependencies of target org.kde.plasma.volume-plasmoids-qrc[2019-05-13T16:00:09.676Z] [ 13%] Built target org.kde.plasma.volume-plasmoids-qrc[2019-05-13T16:00:09.676Z] Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc[2019-05-13T16:00:09.676Z] [ 16%] Generating org.kde.plasma.volume-contents.rcc[2019-05-13T16:00:09.932Z] [ 16%] Built target org.kde.plasma.volume-plasmoids-contents-rcc[2019-05-13T16:00:10.863Z] [ 16%] Built target doc-kcontrol-plasma-pa-index-cache-bz2[2019-05-13T16:00:10.863Z] [ 16%] Built target kcm_pulseaudio_autogen[2019-05-13T16:00:11.122Z] Scanning dependencies of target kcm_pulseaudio[2019-05-13T16:00:11.122Z] [ 18%] Building CXX object src/kcm/CMakeFiles/kcm_pulseaudio.dir/kcm_pulseaudio_autogen/mocs_compilation.cpp.o[2019-05-13T16:00:11.122Z] [ 20%] Building CXX object 

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:9c3d0f2dffc2: Port widget settings window to 
QQC2+Kirigami FormLayout and modernize UI (authored by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21105?vs=57818=58011

REVISION DETAIL
  https://phabricator.kde.org/D21105

AFFECTED FILES
  applet/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma, drosca
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D21189: [System tray] Modernize "Entries" category

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port to QQC2+Kirigami FormLayout style
  - Use standard import names
  
  Don't touch the TableView since there's no QQC2 version yet

TEST PLAN
  F6821757: Entries category.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-entries-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  modernize-widget-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21105

To: ngraham, #vdg, #plasma, drosca
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D21188: Improve keyboard-only usage of the toolbar

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
apol added a project: Kirigami.
apol requested review of this revision.

REVISION SUMMARY
  Have PrivateActionToolButton trigger its action if the mnemonic is activated.
  
  BUG: 403711

TEST PLAN
  I can call the actions on the toolbar now (e.g. on Discover application page)

REPOSITORY
  R169 Kirigami

BRANCH
  mnemonic-patb

REVISION DETAIL
  https://phabricator.kde.org/D21188

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  Hi @ngraham  - any update on this one? Should we move forward with this 
approach or should we do something else?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D21105

To: ngraham, #vdg, #plasma, drosca
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

[Nathaniel Graham]

ngraham added a comment.


  Ping. I'd like to get this in before the string freeze so it can be a part of 
Plasma 5.16 so we can complete T10586  in 
that release.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D21105

To: ngraham, #vdg, #plasma, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

[Nathaniel Graham]

ngraham added a comment.


  F6821636: Screenshot_20190513_081240.png 

  
  This fixes the issue for me, but it feels like we should make the fix in 
plasma-framework to the button itself so everyone gets the benefit of the fix 
automatically, no?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21181

To: broulik, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21164: Replace QUrl::fromUserInput by lighter heuristic

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d38d7df3e170: Replace QUrl::fromUserInput by lighter 
heuristic (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21164?vs=57988=58004#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21164?vs=57988=58004

REVISION DETAIL
  https://phabricator.kde.org/D21164

AFFECTED FILES
  libnotificationmanager/job_p.cpp
  libnotificationmanager/job_p.h

To: broulik, #plasma, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21164: Replace QUrl::fromUserInput by lighter heuristic

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Oh right, it's the other way around.
  
  Well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21164

To: broulik, #plasma, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21186: extends keywords of device info module

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:0dda3bf3b438: extends keywords of device info module 
(authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21186?vs=58002=58003

REVISION DETAIL
  https://phabricator.kde.org/D21186

AFFECTED FILES
  Modules/devinfo/devinfo.desktop

To: sitter, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21186: extends keywords of device info module

[Harald Sitter]

sitter added a comment.


  My PC has no batteries so I couldn't actually say. I agree that the energy 
info module is the better fit anyway.

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21186

To: sitter, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21186: extends keywords of device info module

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Doesn't this thing also have batteries? But for that we have the energy info 
module I guess

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21186

To: sitter, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21186: extends keywords of device info module

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  now includes more keywords of the available information

TEST PLAN
  can search for disks

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21186

AFFECTED FILES
  Modules/devinfo/devinfo.desktop

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21153: [Notifications KCM] Hack scroll bar not crashing

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Actual bug was addressed :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21153

To: broulik, #plasma
Cc: ngraham, odeda, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21184: Take the screen geometry into account when positioning popup notifications

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.


  It needs D21152  applied as well to work 
properly in my scenario.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21184

To: dvratil, broulik, davidedmundson, lbeltrame
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21184: Take the screen geometry into account when positioning popup notifications

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1e175254dd8c: [Notifications] Take the screen geometry 
into account when positioning popup… (authored by dvratil).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21184?vs=57994=57999

REVISION DETAIL
  https://phabricator.kde.org/D21184

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: dvratil, broulik, davidedmundson, lbeltrame
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21152: [Notifications] Fix oversight of not taking into account screen X when placing notifications on the right side of the screen

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b220dcbbdf8b: [Notifications] Fix oversight of not taking 
into account screen X when placing… (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21152?vs=57922=57998

REVISION DETAIL
  https://phabricator.kde.org/D21152

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, hein, lbeltrame
Cc: lbeltrame, hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21184: Take the screen geometry into account when positioning popup notifications

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Thanks

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21184

To: dvratil, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21184: Take the screen geometry into account when positioning popup notifications

[Luca Beltrame]

lbeltrame added a comment.


  Doesn't seem to work with screens that have a rotation. 
  Setup:
  
  F6821443: Screenshot_20190513_134034.png 

  
  Actual display of a notification:
  
  (note where it is, when it's set to "bottom right":
  
  F6821445: Screenshot_20190513_134120.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21184

To: dvratil, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21184: Take the screen geometry into account when positioning popup notifications

[Luca Beltrame]

lbeltrame added a comment.


  I'll test and report if it works in my case, too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21184

To: dvratil, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21184: Take the screen geometry into account when positioning popup notifications

[Daniel Vrátil]

dvratil created this revision.
dvratil added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  The availableScreenRect is relative to the current screen, so if the 
notification
  applet is not on the top-left screen, the notification popup will not appear 
next
  to where the applet is but on the top-left screen instead. Adding the absolute
  screen geometry to the availableScreenRect ensures that the popup is 
positioned
  on the right screen.

TEST PLAN
  Position two screens above each other, place the panel on the bottom screen, 
the
  notification now correctly appears on the bottom screen next to the applet.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21184

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: dvratil, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21164: Replace QUrl::fromUserInput by lighter heuristic

[Kai Uwe Broulik]

broulik updated this revision to Diff 57988.
broulik edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21164?vs=57941=57988

REVISION DETAIL
  https://phabricator.kde.org/D21164

AFFECTED FILES
  libnotificationmanager/job_p.cpp

To: broulik, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

Monday meeting notes for 13/5/2019

[Marco Martin]

Kai Uwe:
Work done:
 Notifications:
 - Merged notifications rewrite \o/
 -- People love it except for some complaints about lack of padding or 
alignment which I don't agree with
 -- Blog post: 
https://blog.broulik.de/2019/05/next-generation-plasma-notifications/
 -- Some minor fixes for issues found after merge
 plasma-browser-integration:
 - Worked on implementing WebShare API https://wicg.github.io/web-share/ 
connecting to libpurpose
 -- Did some minor refactorings in the way we communicate with the different 
parts and made some fixes for Purpose
 - Some tweaks to media controls
 -- Improved volume handling
 -- Better support iframes: D21038
 Diff 21038 "Also store the player's frame ID" [Needs Review] https://
phabricator.kde.org/D21038
 -- Other patches: D21112 D21113 D20830
Diff 21112 "Support message response and reply callbacks" [Needs Review] 
https://phabricator.kde.org/D21112
Diff 21113 "Allow hiding option items depending on available extension and 
version in the host" [Needs Review] https://phabricator.kde.org/D21113
Diff 20830 "Add hack to unbreak audio playback through pure JS via new 
Audio()" [Needs Review] https://phabricator.kde.org/D20830
 Plasma:
 - Fixed some bugs in the microphone indicator
 Work todo:
 - Please review some of the open patches for notifications and other stuff 
since 5.16 Beta tagging is due Thursday
 -- Especially: D21152 D21153 D21164 D21181 D21115
Diff 21152 "[Notifications] Fix oversight of not taking into account 
screen X when placing notifications on the right side of the screen" [Needs 
Review] https://phabricator.kde.org/D21152
Diff 21153 "[Notifications KCM] Hack scroll bar not crashing" [Needs 
Review] https://phabricator.kde.org/D21153
Diff 21164 "Replace QUrl::fromUserInput by lighter heuristic" [Needs 
Review] https://phabricator.kde.org/D21164
Diff 21181 "[Notifications] Ensure "Open" and "More Options" button have 
the same height" [Needs Revision] https://phabricator.kde.org/D21181
Diff 21115 "[KCModuleQML] Fix typo breaking implicitWidth for modules" 
[Needs Review] https://phabricator.kde.org/D21115
 Other:
 - We have a serious regression in qqc2-desktop-style / kirigami

David:
* I merged a patch that gives correct colours to breeze-gtk \o/
* I'd like to get D20890 in, which will allow you to lock a screen on X with a 
kwin effect active
Diff 20890 "Close screen grabbing effect when screensaver starts" [Needs 
Review] https://phabricator.kde.org/D20890
* I'll be deferring my libkworkspace2 till the next Plasma but will try to 
upload everything ready to review this week, all the code is there

Vlad:
Plan to do:
* Merge my axis discrete patches this week.
Ready for review:
* The first patch fixes unexpected roaming of internal clients between layers, 
see https://phabricator.kde.org/D21116 "Keep internal clients in the unmanaged 
layer" 
* The second patch fixes unexpected shrinkage of clients that have been moved 
between screens, see https://phabricator.kde.org/D20987 "Compute correct 
boundaries in checkWorkspacePosition"
TODO:
* Go through some bug reports, see what I can fix.

Roman:
* As a headsup after beta tagging I want to merge D13284 and series at D21110 
into master.
Diff 13284 "[decorations] Let KDecoration plugins recommend a border size 
per default" [Accepted] https://phabricator.kde.org/D13284
Diff 21110 "On config read adjust outputs positions to global value 
changes" [Needs Review] https://phabricator.kde.org/D21110
* there is D20186 which I'm not sure should go into upcoming release since 
beta release is imminent
Diff 20186 "[libinput-touchpad-kcm] Use wayland specific touchpad KCM UI 
when libinput is used on X11" [Needs Review] https://phabricator.kde.org/
D20186
* Besides I'm currently working on some ftrace capability in KWin (and X) for 
profiling and to use with something like https://github.com/mikesart/gpuvis 
This should make debussing performance issues in kwin much easier

Marco:
Kirigami:
* Started a branch for "pinning" pages in the PageRow: so that one page can 
become a left or right sidebar if needed
Plasma:
* Containment Applets layout c++ rewrite
** finished the layouting code: seems to work slightly better than the current 
desktop/folderview containment
** resizeing applets now respects the layouting as well (current desktop 
applets layouting code doesn't)
** done the event handling to move via long press
** added resize handles: they know if they were invoked via a press or a 
touch, so they can adjust their size/look accordingly
Todo:
* investigate some lnf packages not installing correctly from ghns (knsrc 
files moved)
* investigate the recent kirigami crash


-- 
Marco Martin

D21128: Improve keyboard navigation

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> apol wrote in delegaterecycler.cpp:373
> DelegateRecycler can't be a FocusScope itself because QQuickFocusScope is 
> private API.
> 
> We could put it in a FocusScope but then this opens a can of worms WRT sizes.

https://doc.qt.io/qt-5/qquickitem.html#Flag-enum

you can set the focusscope flag on top of any qquickitem, FocusScope is just an 
empty item that doesn't do anything that setting thjat flag in its ctor

QQuickFocusScope::QQuickFocusScope(QQuickItem *parent)
: QQuickItem(parent)
{

  setFlag(ItemIsFocusScope);

}

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D21128

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Good work!!

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  See my last comment on the bug. Sorry.
  
  If you can explain why it's needed I'll happily click ship it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21181

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21180: Check if service is still registered before showing progress

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:01333913374e: Check if service is still registered before 
showing progress (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21180?vs=57978=57984

REVISION DETAIL
  https://phabricator.kde.org/D21180

AFFECTED FILES
  libnotificationmanager/jobsmodel_p.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce added a comment.


  The changes to the key passwordfield menus was made to remove the AlwaysAsk 
option. This is the last change I am aware of necessary to release this.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce updated this revision to Diff 57983.
andersonbruce added a comment.


  - Disable "AlwaysAsk" option in key password fields
  
  Caution: will not compile without changes to passwordfield.cpp and
  
passwordfield.h made in the current master branch.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57972=57983

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerwidget.ui
  libs/editor/settings/ui/wireguardtabwidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/settings/wireguardpeerwidget.h
  libs/editor/settings/wireguardtabwidget.cpp
  libs/editor/settings/wireguardtabwidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Kai Uwe Broulik]

broulik added a comment.


  > I tried to set  icon.width and icon.height but it doesn't do anything.
  
  In desktop style that should work since D20418 


REPOSITORY
  R114 Plasma Addons

BRANCH
  background-appropriate-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21027

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Jan Grulich]

jgrulich added a comment.


  I think it doesn't matter in this case, you can just change it in your code, 
you don't need to have that change in your local copy, if this is merged than 
it's applied on top of that so it will be ok.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

[Kai Uwe Broulik]

broulik updated this revision to Diff 57982.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21181?vs=57981=57982

REVISION DETAIL
  https://phabricator.kde.org/D21181

AFFECTED FILES
  applets/notifications/package/contents/ui/JobItem.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

[Kai Uwe Broulik]

broulik created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21181

AFFECTED FILES
  applets/notifications/package/contents/ui/JobItem.qml

To: broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21180: Check if service is still registered before showing progress

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Should Plasma be too busy to process a request and the app that requested it 
quit before Plasma processed it, we will get a defunct job view that cannot be 
canceled because the app that owned it isn't listening anymore.

TEST PLAN
  - sigstop'd plasmashell, started a copy in Dolphin, waited a bit, killed 
Dolphin, sigcont'd plasmashell: no longer got a lingering job view

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21180

AFFECTED FILES
  libnotificationmanager/jobsmodel_p.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/32/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 13 May 2019 06:46:38 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 374 lines...][2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[el]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[es]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[et]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[eu]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[fi]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[fr]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[gl]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[he]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[hu]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[id]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[it]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[ko]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[lt]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[nl]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[nn]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[pa]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[pl]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[pt]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[ru]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[sk]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[sl]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[sr]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[sv]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[tr]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[uk]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[x-test]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to string[2019-05-13T07:10:00.981Z] Unknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to string[2019-05-13T07:10:00.981Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-pa/kf5-qt5 FreeBSDQt5.12/build/src/kcm/kcm_pulseaudio.json" [2019-05-13T07:10:00.981Z] [2019-05-13T07:10:00.981Z] [ 11%] Built target org.kde.plasma.volume-plasmoids-metadata-json[2019-05-13T07:10:00.981Z] [ 11%] Built target kcm_pulseaudio-kcms-metadata-json[2019-05-13T07:10:00.981Z] [ 13%] Automatic MOC for target kcm_pulseaudio[2019-05-13T07:10:00.981Z] Scanning dependencies of target org.kde.plasma.volume-plasmoids-qrc[2019-05-13T07:10:00.981Z] [ 13%] Built target org.kde.plasma.volume-plasmoids-qrc[2019-05-13T07:10:00.981Z] Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc[2019-05-13T07:10:00.981Z] [ 16%] Generating org.kde.plasma.volume-contents.rcc[2019-05-13T07:10:00.981Z] [ 16%] Built target org.kde.plasma.volume-plasmoids-contents-rcc[2019-05-13T07:10:02.355Z] [ 16%] Built target kcm_pulseaudio_autogen[2019-05-13T07:10:02.355Z] Scanning dependencies of target kcm_pulseaudio[2019-05-13T07:10:02.355Z] [ 18%] Building CXX object src/kcm/CMakeFiles/kcm_pulseaudio.dir/kcm_pulseaudio_autogen/mocs_compilation.cpp.o[2019-05-13T07:10:02.355Z] [ 20%] Building CXX object 

D21114: [Microphone Indicator] Avoid duplicate application names

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:2a3313b749e5: [Microphone Indicator] Avoid duplicate 
application names (authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21114?vs=57842=57979

REVISION DETAIL
  https://phabricator.kde.org/D21114

AFFECTED FILES
  src/qml/microphoneindicator.cpp

To: broulik, #plasma, drosca, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce marked an inline comment as done.
andersonbruce added a comment.


  In D20930#464412 , @jgrulich wrote:
  
  > In D20930#464403 , 
@andersonbruce wrote:
  >
  > > In D20930#464387 , @jgrulich 
wrote:
  > >
  > > > In D20930#464384 , @jgrulich 
wrote:
  > > >
  > > > > In D20930#464377 , 
@andersonbruce wrote:
  > > > >
  > > > > > Updated SecretAgent class to always try to get the secrets from 
kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses 
are 43 random characters long and we don't expect the user to enter these 
manually when trying to make a connection. If data is not available in kwallet 
then trying to make a connection will fail. Also updated the configuration 
screens to not allow a configuration with "AlwaysAsk" flags on either key.
  > > > >
  > > > >
  > > > > You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).
  > > >
  > > >
  > > > Sorry, that's not it, I added a new option to do that, you can now use 
PasswordField::setPasswordNotSavedEnabled(false).
  > >
  > >
  > > Great!  Should I make the change in this review? If so, what is the 
correct procedure (with git, arc, ...) to merge that change into this review?
  >
  >
  > Should be enough just to merge current master into your branch I guess.
  
  
  Isn't  'arc diff' going to try to include the differences between the master 
I originally checked out and the merged current master as changes in the 
WireGuard review then?  Sorry if these are stupid questions, I'm not a git 
expert and I just don't want to mess things up.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Jan Grulich]

jgrulich added a comment.


  In D20930#464403 , @andersonbruce 
wrote:
  
  > In D20930#464387 , @jgrulich 
wrote:
  >
  > > In D20930#464384 , @jgrulich 
wrote:
  > >
  > > > In D20930#464377 , 
@andersonbruce wrote:
  > > >
  > > > > Updated SecretAgent class to always try to get the secrets from 
kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses 
are 43 random characters long and we don't expect the user to enter these 
manually when trying to make a connection. If data is not available in kwallet 
then trying to make a connection will fail. Also updated the configuration 
screens to not allow a configuration with "AlwaysAsk" flags on either key.
  > > >
  > > >
  > > > You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).
  > >
  > >
  > > Sorry, that's not it, I added a new option to do that, you can now use 
PasswordField::setPasswordNotSavedEnabled(false).
  >
  >
  > Great!  Should I make the change in this review? If so, what is the correct 
procedure (with git, arc, ...) to merge that change into this review?
  
  
  Should be enough just to merge current master into your branch I guess.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21167: Add Messages.sh

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:71dbe70d2c15: Add Messages.sh (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21167?vs=57945=57977

REVISION DETAIL
  https://phabricator.kde.org/D21167

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/Messages.sh

To: broulik, #plasma, kde-i18n-doc, aacid, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21165: [Notifications] When un-dismissing job hide plasmoid popup

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7d0a0a007746: [Notifications] When un-dismissing job hide 
plasmoid popup (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21165?vs=57943=57976

REVISION DETAIL
  https://phabricator.kde.org/D21165

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21137: [Notifications] Rename device name to origin name

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9d0f3b37fcb8: [Notifications] Rename device name to 
origin name (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21137?vs=57891=57975

REVISION DETAIL
  https://phabricator.kde.org/D21137

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/server_p.cpp

To: broulik, #plasma, nicolasfella, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce marked an inline comment as done.
andersonbruce added a comment.


  
  
  In D20930#464387 , @jgrulich wrote:
  
  > In D20930#464384 , @jgrulich 
wrote:
  >
  > > In D20930#464377 , 
@andersonbruce wrote:
  > >
  > > > Updated SecretAgent class to always try to get the secrets from kwallet 
even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 
random characters long and we don't expect the user to enter these manually 
when trying to make a connection. If data is not available in kwallet then 
trying to make a connection will fail. Also updated the configuration screens 
to not allow a configuration with "AlwaysAsk" flags on either key.
  > >
  > >
  > > You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).
  >
  >
  > Sorry, that's not it, I added a new option to do that, you can now use 
PasswordField::setPasswordNotSavedEnabled(false).
  
  
  Great!  Should I make the change in this review? If so, what is the correct 
procedure (with git, arc, ...) to merge that change into this review?

INLINE COMMENTS

> jgrulich wrote in secretagent.cpp:432
> Shouldn't it be
> 
>   (isVpn && !isWireguard) && allowInteraction
> 
> You don't want to display password dialog in case it's a WG connection.
> 
> Or maybe it should stay and instead we should return true and send error 
> (like we do when a dialog has an error) if it's a WG connection, to let 
> NetworkManager know we cannot handle that.

Actually what I did is move the WireGuard handling above this 'else if' so it 
shouldn't get to this point if it is WireGuard so I simply returned the logic 
to what it was originally.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21176: PanelView: update mask on window on change of panelMask property

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 57974.
kossebau added a comment.


  keep old code for KF 5.58 compat

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21176?vs=57965=57974

BRANCH
  updatepanelmaskonchange

REVISION DETAIL
  https://phabricator.kde.org/D21176

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce updated this revision to Diff 57972.
andersonbruce added a comment.


  - Return non-WireGuard logic to original state

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57970=57972

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerwidget.ui
  libs/editor/settings/ui/wireguardtabwidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/settings/wireguardpeerwidget.h
  libs/editor/settings/wireguardtabwidget.cpp
  libs/editor/settings/wireguardtabwidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Jan Grulich]

jgrulich added a comment.


  In D20930#464384 , @jgrulich wrote:
  
  > In D20930#464377 , 
@andersonbruce wrote:
  >
  > > Updated SecretAgent class to always try to get the secrets from kwallet 
even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 
random characters long and we don't expect the user to enter these manually 
when trying to make a connection. If data is not available in kwallet then 
trying to make a connection will fail. Also updated the configuration screens 
to not allow a configuration with "AlwaysAsk" flags on either key.
  >
  >
  > You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).
  
  
  Sorry, that's not it, I added a new option to do that, you can now use 
PasswordField::setPasswordNotSavedEnabled(false).

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> secretagent.cpp:432
> +return true;
> +} else if (requestNew || (allowInteraction && 
> !setting->needSecrets(requestNew).isEmpty()) || (allowInteraction && 
> userRequested) || ((isVpn || isWireGuard) && allowInteraction)) {
> +

Shouldn't it be

  (isVpn && !isWireguard) && allowInteraction

You don't want to display password dialog in case it's a WG connection.

Or maybe it should stay and instead we should return true and send error (like 
we do when a dialog has an error) if it's a WG connection, to let 
NetworkManager know we cannot handle that.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart