D21436: Use onClicked for Home button

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  My bad!

REPOSITORY
  R134 Discover Software Store

BRANCH
  use-onclicked-for-home-button (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21436

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21435: [ActionTextField] Make QML tooltip consistent

[Nathaniel Graham]

ngraham added a comment.


  Argh, I explicitly did NOT accept as Kirigami but Phab did it anyway. :(

REPOSITORY
  R169 Kirigami

BRANCH
  actiontextfield-make-qml-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21435

To: GB_2, #plasma, #vdg, #kirigami, ngraham
Cc: ngraham, mart, ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, 
apol, davidedmundson, hein

D21435: [ActionTextField] Make QML tooltip consistent

[Nathaniel Graham]

ngraham added subscribers: mart, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  @mart?

REPOSITORY
  R169 Kirigami

BRANCH
  actiontextfield-make-qml-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21435

To: GB_2, #plasma, #vdg, #kirigami, ngraham
Cc: ngraham, mart, ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, 
apol, davidedmundson, hein

D21408: RFC: [Notifications] Better notification number alignment

[Noah Davis]

ndavis added a comment.


  In D21408#470827 , @cfeck wrote:
  
  > Just an idea: run "kcharselect", type "circled digit" resp. "circled 
number". For values <= 20, unicode has pre-rendered glyphs.
  
  
  Unfortunately, there is a jump in size from 10 to 11:
  F6855537: Screenshot_20190527_221327.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Christoph Feck]

cfeck added a comment.


  Just an idea: run "kcharselect", type "circled digit" resp. "circled number". 
For values <= 20, unicode has pre-rendered glyphs.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21434: [Notifications KCM] Try both model indices

[Nicolas Fella]

nicolasfella added a comment.


  Works for me
  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21434

To: broulik, #plasma, nicolasfella
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21435: [ActionTextField] Make QML tooltip consistent

[Carl Schwan]

ognarb added a reviewer: Kirigami.
ognarb added a comment.


  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D21435

To: GB_2, #plasma, #vdg, #kirigami
Cc: ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D21436: Use onClicked for Home button

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 407636
  FIXED-IN: 5.16.0
  
  Buttons should use onClicked instead of onPressed.

TEST PLAN
  Click on the Home button. It now behaves correctly.

REPOSITORY
  R134 Discover Software Store

BRANCH
  use-onclicked-for-home-button (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21436

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21435: [ActionTextField] Make QML tooltip consistent

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  T10873 

TEST PLAN
  Hover over for example the Discover search bar. The tooltip now behaves 
correctly.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontextfield-make-qml-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21435

AFFECTED FILES
  src/controls/ActionTextField.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D21434: [Notifications KCM] Try both model indices

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We prefer applicatons over services, however, when configuring a KDE 
application we get passed both an application and a service. That application 
might be `NoDisplay` and then we end up not finding an index and event 
configuration files.

TEST PLAN
  5.16 branch
  
  I can now configure KDE Connect notifications by clicking the configure icon 
on the notification.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21434

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: broulik, #plasma, nicolasfella
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21433: [kdecoration] Unset resize borders for maximized clients

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  So far this decoration theme was setting resize borders unconditionally,
  without actually taking into account whether decorated client is maximized.
  
  On a single monitor setup, this doesn't cause any significant issues, but
  on a multiple monitor setup, this is a bit serious issue because the
  user may accidentally resize a maximized client on a neighboring screen.
  
  BUG: 407989

REPOSITORY
  R113 Oxygen Theme

BRANCH
  unset-resize-only-borders

REVISION DETAIL
  https://phabricator.kde.org/D21433

AFFECTED FILES
  kdecoration/oxygendecoration.cpp

To: zzag, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21432: [kdecoration] Unset resize borders for maximized clients

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  So far this decoration theme was setting resize borders unconditionally,
  without actually taking into account whether decorated client is maximized.
  
  On a single monitor setup, this doesn't cause any significant issues, but
  on a multiple monitor setup, this is a bit serious issue because the
  user may accidentally resize a maximized client on a neighboring screen.
  
  Similar patch needs to be done against the Oxygen decoration theme.
  
  CCBUG: 407989

REPOSITORY
  R31 Breeze

BRANCH
  unset-resize-only-borders

REVISION DETAIL
  https://phabricator.kde.org/D21432

AFFECTED FILES
  kdecoration/breezedecoration.cpp

To: zzag, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 updated this revision to Diff 58733.
GB_2 added a comment.


  Clean indentation

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21417?vs=58721=58733

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg, apol
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:7b778dbe90fe: [ActionListItem] Make QML imports and 
tooltip consistent (authored by GB_2).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21417?vs=58733=58735

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg, apol
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Otherwise it's good to go.

INLINE COMMENTS

> ActionListItem.qml:44
>  
> -ToolTip.visible: hovered
> -ToolTip.text: action.shortcut ? action.shortcut : p0.nativeText
> +readonly property var tooltip: QQC2.ToolTip {
> +text: action.shortcut ? action.shortcut : p0.nativeText

It has an indentation too much.

REPOSITORY
  R134 Discover Software Store

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

To: GB_2, #plasma, #vdg, apol
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

[Eike Hein]

hein added a comment.


  I'm not sold on this. "Display" fonts typically have spacing and metrics 
optimized for large sizes and use cases like signage. The FAQ entry quoted in 
the task you linked talks about Noto Sans UI. I'd like some more solid 
documentation on how Display relates to this "UI" cut or something from 
upstream.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21429

To: GB_2, #plasma, #vdg, bshah
Cc: hein, bshah, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

[Björn Feber]

GB_2 added a comment.


  In D21429#470715 , @hein wrote:
  
  > Why?
  
  
  Read the task mentioned in the description...
  
  > See T10980  for more info.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21429

To: GB_2, #plasma, #vdg, bshah
Cc: hein, bshah, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

[Eike Hein]

hein added a comment.


  Why?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21429

To: GB_2, #plasma, #vdg, bshah
Cc: hein, bshah, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Nathaniel Graham]

ngraham added a comment.


  Great! I think a bit of padding between the checkbox and the label would help 
too. Then this'll be a great UI upgrade!

INLINE COMMENTS

> configwidget.ui:60
> +   
> + Do not search in these locations
> +   

Now this string needs to end with a colon

`Do not search in these locations:`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

[Björn Feber]

GB_2 updated this revision to Diff 58730.
GB_2 added a comment.


  Also update KRDB

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21429?vs=58727=58730

BRANCH
  switch-default-ui-font-to-noto-sans-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21429

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/krdb/krdb.cpp

To: GB_2, #plasma, #vdg, bshah
Cc: bshah, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

[Bhushan Shah]

bshah requested changes to this revision.
bshah added a comment.
This revision now requires changes to proceed.


  Please make sure you also update kcms/krdb/krdb.cpp as well ^^

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21429

To: GB_2, #plasma, #vdg, bshah
Cc: bshah, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21431: [kaccess] Don't talk to ksmserver

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We don't need any of its session restoration capabilities but it still talks 
to ksmserver just to then have us discard all the info anyway.

TEST PLAN
  Part of T10958 
  
  - Sent sigstop to ksmserver, started kaccess, started fine now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21431

AFFECTED FILES
  kaccess/main.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21430: [Plasma Integration] Switch default UI font to Noto Sans Display

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  See T10980  for more info.

TEST PLAN
  Noto Sans Display should now be the default font.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  switch-default-ui-font-to-noto-sans-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21430

AFFECTED FILES
  src/platformtheme/kfontsettingsdata.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  See T10980  for more info.

TEST PLAN
  Noto Sans Display should now be the default font.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-default-ui-font-to-noto-sans-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21429

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 58723.
kishoreg edited the summary of this revision.
kishoreg added a comment.


  This patch incorporates Nate's suggestion to remove the box around the 
'exclude folders' area. I've added screenshots of all three cases (with spacer, 
with box, and without box) to a previous comment.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58684=58723

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg added a comment.


  Before change: F6854280: Screenshot_20190519_105621.png 

  Initial patch: F6854282: Screenshot_20190527_181359.png 

  With box removed: F6854285: Screenshot_20190527_190128.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21422: [Notifications] Fix translations in popup

[Victor Ryzhykh]

victorr added a comment.


  In D21422#470541 , @victorr wrote:
  
  > > We also need this patch.F6854024: plasma-workspace-fix.patch 

  >
  > It is possible that I am mistaken.
  >  Need to check again.
  >  Today, a little later, check it out.
  
  
  I was wrong.
  Patch is not needed.
  Everything is working.
  I'm sorry.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21422

To: broulik, #plasma, aacid, yurchor
Cc: victorr, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21038: Also store the player's frame ID

[Fabian Vogt]

fvogt added a comment.


  Couldn't find anything wrong, but I'm currently missing the overview of all 
MPRIS stuff in here to actually review properly...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21038

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Noah Davis]

ndavis added a comment.


  In D21408#470480 , @broulik wrote:
  
  > - Use `QtRendering` as I originally intended
  >
  >   Does this make it any better?
  
  
  The numbers seem to be slightly smaller and fit in the circle slightly 
better, but they're still off to the left a bit, just as much as in the video I 
posted above.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21423: [Notifications] Don't show blue icon when a notification is active

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21423

To: broulik, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21112: Support message response and reply callbacks

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  `browser.runtime.sendMessage` does not seem to have a callback parameter.
  
  See 
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/sendMessage:
  
  > if two arguments are given:
  >  the arguments are interpreted as (message, options), and the message is 
sent internally, if the second argument is any of the following:
  >  a valid options object (meaning, it is an object which contains only the 
properties of options that the browser supports)
  > null
  > undefined
  >  otherwise, the arguments are interpreted as (extensionId, message). The 
message will be sent to the extension identified by extensionId.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21112

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 updated this revision to Diff 58721.
GB_2 added a comment.


  Remove unneeded parent property

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21417?vs=58720=58721

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 updated this revision to Diff 58720.
GB_2 added a comment.


  Remove workaround and put tooltip into property

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21417?vs=58689=58720

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21113: Allow hiding option items depending on available extension and version in the host

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> options.js:82
>  
> +function subsystemStatus() {
> +return new Promise((resolve, reject) => {

AFAICT it doesn't conflict, but IMO it's a bit confusing if there's both a 
global array `subsystemStatus` in extension.js and a function 
`subsystemStatus()` in options.js.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21113

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Aleix Pol Gonzalez]

apol added a comment.


  > Ok, weird. If I do it without the Control it shows this error: 
`qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property 
"_basicDefault"`
  
  Try putting it into a property so that it's not assigned as the parent's 
default item.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21417

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21422: [Notifications] Fix translations in popup

[Victor Ryzhykh]

victorr added a comment.


  In D21422#470534 , @victorr wrote:
  
  > In D21422#470522 , @broulik 
wrote:
  >
  > > Which files are you missing? `main.qml` and `FullRepresentation.qml` 
aren't changed on purpose as it's not neccessary there.
  >
  >
  > We also need this patch.F6854024: plasma-workspace-fix.patch 

  
  
  It is possible that I am mistaken.
  Need to check again.
  Today, a little later, check it out.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21422

To: broulik, #plasma, aacid, yurchor
Cc: victorr, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21426: Remove unrelated code to make sure oxygen font is installed

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:707fbb4c4537: Remove unrelated code to make sure oxygen 
font is installed (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21426?vs=58717=58718

REVISION DETAIL
  https://phabricator.kde.org/D21426

AFFECTED FILES
  startkde/startplasmacompositor.cmake

To: bshah, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21422: [Notifications] Fix translations in popup

[Victor Ryzhykh]

victorr added a comment.


  In D21422#470522 , @broulik wrote:
  
  > Which files are you missing? `main.qml` and `FullRepresentation.qml` aren't 
changed on purpose as it's not neccessary there.
  
  
  We also need this patch.F6854024: plasma-workspace-fix.patch 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21422

To: broulik, #plasma, aacid, yurchor
Cc: victorr, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21426: Remove unrelated code to make sure oxygen font is installed

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  eww
  
  We need to do something to make sure startkde  and 
startplasma/startplasmacompositor don't keep going out of sync.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bshah/no-oxygen

REVISION DETAIL
  https://phabricator.kde.org/D21426

To: bshah, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21426: Remove unrelated code to make sure oxygen font is installed

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  Relevant code is already removed from startkde, remove it from plasma
  wayland session as well

TEST PLAN
  none

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bshah/no-oxygen

REVISION DETAIL
  https://phabricator.kde.org/D21426

AFFECTED FILES
  startkde/startplasmacompositor.cmake

To: bshah, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21422: [Notifications] Fix translations in popup

[Kai Uwe Broulik]

broulik added a comment.


  Which files are you missing? `main.qml` and `FullRepresentation.qml` aren't 
changed on purpose as it's not neccessary there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21422

To: broulik, #plasma, aacid, yurchor
Cc: victorr, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21422: [Notifications] Fix translations in popup

[Victor Ryzhykh]

victorr added a comment.


  This does not fix all files.
  I made such a patch two days ago.F6854006: 
plasma-workspace-5.15.90-fix_locales.patch 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21422

To: broulik, #plasma, aacid, yurchor
Cc: victorr, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

[Bhushan Shah]

bshah closed this revision.
bshah added a comment.


  This was merged in https://phabricator.kde.org/D21362 , thanks for your patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12925

To: progwolff, #plasma, mart
Cc: bshah, rkflx, ngraham, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21362: Fixes for fonts kcm

[Bhushan Shah]

bshah closed this revision.
bshah added a comment.


  Merged manually.
  
  1958f1ca1e4fcfacade554e4b196daaa0d7425f0 
 ,  
873cbc1da8f3f2b589f9f2722a4e15a8fcbfe4e5 
 , 
and 39c6facc51a807acc418a2e0dad6fda37d53071f 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21362

To: bshah, #plasma, mart, ngraham
Cc: ngraham, mart, progwolff, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21335: Don't write a anti-aliasing settings from startkde

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1af4680ea846: Dont write a anti-aliasing settings 
from startkde (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21335?vs=58544=58715

REVISION DETAIL
  https://phabricator.kde.org/D21335

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasmacompositor.cmake

To: bshah, #plasma, ngraham, apol, davidedmundson
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik updated this revision to Diff 58711.
broulik added a comment.


  - Use `QtRendering` as I originally intended
  
  Does this make it any better?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21408?vs=58658=58711

REVISION DETAIL
  https://phabricator.kde.org/D21408

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in CompactRepresentation.qml:116
> This doesn't match your description

Ha, no wonder nothing changed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> CompactRepresentation.qml:116
> +text: compactRoot.unreadCount || ""
> +renderType: Text.NativeRendering
>  }

This doesn't match your description

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added inline comments.

INLINE COMMENTS

> broulik wrote in AbstractItem.qml:22
> You sure this high version number is neccessary?

Not exactly. But old layouts used to have a load of restrictions, for sure.

> broulik wrote in AbstractItem.qml:30
> Avoid doing negated disjunctions for clarity: `!labelVisible && !vertical`

Oh, give it a rest.  These two lines looking good together, this way it is 
clear that they are an opposite of each other.

> broulik wrote in AbstractItem.qml:74
> For some reason the icons are now smaller than they were before, observed on 
> two separate computers, they used to be the same as the panel icon here:
> F6849506: Screenshot_20190525_191014.png 
> 

Not even sure, is it directly my mistake, or rebase on that later master 
branch. Could you provide more specific numbers, please?

> broulik wrote in AbstractItem.qml:130
> Can you just make the `iconItem` have a `anchors.fill: parent`?

maaayyybe...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21038: Also store the player's frame ID

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21038

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21423: [Notifications] Don't show blue icon when a notification is active

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Also consider a notification as unread only when it isn't active anymore.

TEST PLAN
  `notify-send foo bar`, waited for popup to close, got a "1" in my panel
  `notify-send foo bar`, closed the popup, didn't get anything in my panel
  As suggested by VDG
  
  I originally had the notification plasmoid show up alongside the popup to 
kinda indicate "this is where this thing is coming from/going to". With this 
change the notification plasmoid will not be shown in the panel unless there is 
an unread notification.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21423

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  libnotificationmanager/notifications.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21422: [Notifications] Fix translations in popup

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:41e41b194c1f: [Notifications] Fix translations in popup 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21422?vs=58703=58704

REVISION DETAIL
  https://phabricator.kde.org/D21422

AFFECTED FILES
  applets/notifications/package/contents/ui/EditContextMenu.qml
  applets/notifications/package/contents/ui/JobDetails.qml
  applets/notifications/package/contents/ui/JobItem.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml

To: broulik, #plasma, aacid, yurchor
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21422: [Notifications] Fix translations in popup

[Yuri Chornoivan]

yurchor accepted this revision.
yurchor added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21422

To: broulik, #plasma, aacid, yurchor
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21422: [Notifications] Fix translations in popup

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, aacid, yurchor.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The popup is a pure QML singleton and as such doesn't inherit the i18n 
context from the applet. Use `i18nd` explicitly.
  
  BUG: 407927

TEST PLAN
  - Stuff in popup is translated properly now
  
  `main.qml` and `FullRepresentation.qml` aren't changed as they are items that 
are used in the applet like normal.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21422

AFFECTED FILES
  applets/notifications/package/contents/ui/EditContextMenu.qml
  applets/notifications/package/contents/ui/JobDetails.qml
  applets/notifications/package/contents/ui/JobItem.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml

To: broulik, #plasma, aacid, yurchor
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Proposal: passing user idle time to systemd-logind

[Martin Flöser]

Am 2019-05-24 21:51, schrieb Aleix Pol:

On Wed, May 22, 2019 at 6:13 PM Germano Massullo
 wrote:


Hello, I am writing to you to propose the following reasoning, hoping
that it can help making easier (just a bit) third parties development
work on Linux.
I am currently developing BOINC client user idle time detection on
Linux systems (both graphical or tty sessions)
After some studies I started writing a little piece of code that that
is able to print on standard output the user idle time by retrieving
it from systemd-logind IdleSinceHint property (that is exposed on
DBus). By the way I found out that this value was always 0 [1], so I
asked why [2]. I have been told that logind relies on the desktop
environment to pass this information.
Many d.e. expose user idle time to their own DBus path, (i.e.
org.gnome.Mutter.IdleMonitor), so I will be forced to write code that
depends on the specific desktop environment. Since:
1) systemd-logind is just ready for exposing user idle time;
2) for a developer writing code for Linux it would be much easier to
retrieve user idle time from a unique place rather than having to deal
with all various desktop environments;
I would like to ask you what do you think about passing the user idle
time to logind [3] [4] ?

Best regards

[1]: you can try with system console command
$ sleep 2 && gdbus introspect --system --dest org.freedesktop.login1
--object-path /org/freedesktop/login1 | grep IdleSinceHint
[2]: 
https://lists.freedesktop.org/archives/systemd-devel/2019-May/042726.html
[3]: 
https://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
[4]: 
https://www.freedesktop.org/wiki/Software/systemd/writing-display-managers/


We are using the kidletime framework to do that on our applications:
https://api.kde.org/frameworks/kidletime/html/index.html

IIRC, In X11 it happens through mere X11 observation, in wayland
there's a protocol for that,
It could make sense to expose this data to logind and even consume it
like that from applications. Why not.


When implementing kidletime support for Wayland I also looked at the 
logind property and came to the conclusion that it's totally useless. 
The property provides the idle time. But that is not what anybody is 
interested in. What one needs are notifications (to the application) 
like idle for five minutes. That's exactly what kidletime provides.


The problem with the idle time in logind is that it keeps 3 applications 
busy:
* the Wayland compositor needs to update the time, although it's 
currently sleeping
* applications need to actively poll the logind property to check how 
much has passed
* logind is kept busy due to the polling of the applications and due to 
the compositor updating the property.


I'm all for having something standardized, ideally working on both X11 
and Wayland, but the logind interface is unfortunately not the solution.


We can add support for logind but it would be very cross. E.g. only 
providing idle for one minute, idle for five minutes, 10 minutes, 15 
minutes, 30 minutes, one hour. Everything else just causes too much 
stress on the sleeping KWin (I like KWin best when it's sleeping ;-) ).


Cheers
Martin

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 added a comment.


  In D21417#470381 , @apol wrote:
  
  > But BasicListItem already is a Control.
  >  https://doc.qt.io/qt-5/qml-qtquick-controls2-itemdelegate.html
  
  
  Ok, weird. If I do it without the Control it shows this error: 
`qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property 
"_basicDefault"`

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21417

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart