D21785: Don't track subsystem status

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:37f48b7e4fde: Don't track subsystem status (authored 
by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21785?vs=59740&id=59776

REVISION DETAIL
  https://phabricator.kde.org/D21785

AFFECTED FILES
  extension/extension.js
  host/abstractbrowserplugin.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21785: Don't track subsystem status

[Kai Uwe Broulik]

broulik added a comment.


  I think in the options page we don't really have a choice since it's a 
separate page opened by the user when the extension is already running. 
  If we ever do breaking changes in the extension script and need to check it, 
we can still reintroduce something.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21785

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21794: Style the session selector to be more Breeze

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> SessionButton.qml:51
> +itemDelegate.label: QQC.Label {
> +height: contentHeight * 1.2
> +verticalAlignment: Text.AlignVCenter

Also, do we need this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Filip Fila]

filipf added a comment.


  Awesome, the look of that menu has been a thorn in my side! Code needs some 
modifications, but it looks great.
  
  Can you also apply this patch to KeyboardButton.qml as we've got another QQC 
menu there?

INLINE COMMENTS

> SessionButton.qml:48
> +frame: Rectangle {
> +color: "#fcfcfc"
> +}

No need to hardcode here, instead set:

`color: PlasmaCore.ColorScope.backgroundColor`

> SessionButton.qml:53
> +verticalAlignment: Text.AlignVCenter
> +color: styleData.selected ? "#fcfcfc" : "#232627"
> +text: styleData.text

Same, you can set:

`color: styleData.selected ? PlasmaCore.ColorScope.highlightedTextColor : 
PlasmaCore.ColorScope.textColor`

> SessionButton.qml:55
> +text: styleData.text
> +}
> +itemDelegate.background: Rectangle {

For this label we should also add:

`font.pointSize: config.fontSize`

This will make sure the size of the labels is the same as the one used for the 
button label.

> SessionButton.qml:58
> +visible: styleData.selected
> +color: "#3daee9"
> +//border.color: "#3daee9"

PlasmaCore.ColorScope.highlightColor

> SessionButton.qml:59
> +color: "#3daee9"
> +//border.color: "#3daee9"
> +//border.width: 1

Just remove this, you would be trying to mimic the PlasmaComponents.Highlight 
with it, but that's not what we use in menus in the desktop.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Aleix Pol Gonzalez]

apol added a comment.


  It would be useful if you provide a screenshot of the result so people can 
assess the change properly.

INLINE COMMENTS

> SessionButton.qml:48
> +frame: Rectangle {
> +color: "#fcfcfc"
> +}

You're hard-coding colors, this will break as soon as the style is changed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21794: Style the session selector to be more Breeze

[Carson Black]

cblack created this revision.
cblack added reviewers: VDG, filipf.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The session selector's menu is now styled to resemble the Breeze theme rather 
than the default QML style.

TEST PLAN
  Ensure the styling looks good regardless of various conditions. (resolution, 
dpi, distro, amount of sessions, etc.)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  better-session-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21794

AFFECTED FILES
  sddm-theme/SessionButton.qml

To: cblack, #vdg, filipf
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens

[Roman Gilg]

romangg added a comment.


  I added your diff to a task I created for tracking some improvements to 
KScreen.
  
  Please test out how lid open/closed configs behave with the new code on 
master branch. Also rebase on current master.
  
  Put the additional two fixes you did in separate diffs if they are 
independent of open/closed configs question. It sounds like that.
  
  Thank you!

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D21082

To: hoffmannrobert, #plasma, romangg
Cc: ngraham, romangg, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21110: On config read adjust outputs positions to global value changes

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:2f26bf7fd758: On config read adjust outputs positions to 
global value changes (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21110?vs=59723&id=59764

REVISION DETAIL
  https://phabricator.kde.org/D21110

AFFECTED FILES
  kded/output.cpp
  kded/output.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16997: [kcm] Expose interface to control output property retention

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:62837af06b2b: [kcm] Expose interface to control output 
property retention (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16997?vs=59722&id=59763

REVISION DETAIL
  https://phabricator.kde.org/D16997

AFFECTED FILES
  common/control.cpp
  common/control.h
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/widget.cpp
  kcm/src/widget.h

To: romangg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D16996: Add method to write retention to configuration control files

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:06b90b31068e: Add method to write retention to 
configuration control files (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16996?vs=59721&id=59762

REVISION DETAIL
  https://phabricator.kde.org/D16996

AFFECTED FILES
  common/control.cpp
  common/control.h

To: romangg, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16995: Consider identical display models in ControlConfig

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:153e6e5fbafa: Consider identical display models in 
ControlConfig (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16995?vs=59718&id=59760

REVISION DETAIL
  https://phabricator.kde.org/D16995

AFFECTED FILES
  common/control.cpp
  common/control.h
  kded/config.cpp
  kded/output.cpp
  kded/output.h
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma
Cc: mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16994: Split Control class into configurations and outputs control classes

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:18bc53a34016: Split Control class into configurations and 
outputs control classes (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16994?vs=59717&id=59758

REVISION DETAIL
  https://phabricator.kde.org/D16994

AFFECTED FILES
  common/control.cpp
  common/control.h
  kded/config.cpp

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16993: Add a common directory for functionality being used by kcm and daemon

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:ba9681bfd757: Add a common directory for functionality 
being used by kcm and daemon (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16993?vs=59716&id=59757

REVISION DETAIL
  https://phabricator.kde.org/D16993

AFFECTED FILES
  common/control.cpp
  common/control.h
  common/globals.cpp
  common/globals.h
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16992: Introduce secondary control channel of the KScreen daemon

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:466c278f9bef: Introduce secondary control channel of the 
KScreen daemon (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16992?vs=59715&id=59756

REVISION DETAIL
  https://phabricator.kde.org/D16992

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/229fa9e8a378cb151d7302df42666774
  tests/kded/serializerdata/control/configs/8684e883209d7644eb76feea2081c431
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16991: Introduce concept of global and individual output data retention

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:979e43f99be4: Introduce concept of global and individual 
output data retention (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16991?vs=59662&id=59755

REVISION DETAIL
  https://phabricator.kde.org/D16991

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16990: [kded] Separate configuration storage path

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:a17ccc22c886: [kded] Separate configuration storage path 
(authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16990?vs=59661&id=59754

REVISION DETAIL
  https://phabricator.kde.org/D16990

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  tests/kded/configtest.cpp

To: romangg, #plasma
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16989: [kded] Introduce Config wrapper class

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:9e34fd814f90: [kded] Introduce Config wrapper class 
(authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16989?vs=59653&id=59753

REVISION DETAIL
  https://phabricator.kde.org/D16989

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp
  tests/kded/serializertest.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21785: Don't track subsystem status

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Indeed unused, but I wonder whether doing it explicitly in D21113 
 is prettier...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21785

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21725: Use a native application for starting plasma

[Aleix Pol Gonzalez]

apol updated this revision to Diff 59752.
apol marked an inline comment as done.
apol added a comment.


  Address xrdb call as suggested by David

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21725?vs=59693&id=59752

BRANCH
  apol/startkde

REVISION DETAIL
  https://phabricator.kde.org/D21725

AFFECTED FILES
  plasma.desktop.cmake
  plasmawayland.desktop.cmake
  startkde/CMakeLists.txt
  startkde/config-startplasma.h.cmake
  startkde/kcheckrunning/CMakeLists.txt
  startkde/kcheckrunning/kcheckrunning.cpp
  startkde/kcheckrunning/kcheckrunning.h
  startkde/kstartupconfig/CMakeLists.txt
  startkde/kstartupconfig/kdostartupconfig.cpp
  startkde/kstartupconfig/kstartupconfig.cpp
  startkde/plasma-sourceenv.sh
  startkde/startkde.cmake
  startkde/startplasma-wayland.cpp
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cmake
  startkde/startplasma.cpp
  startkde/startplasma.h
  startkde/startplasmacompositor.cmake

To: apol, #plasma, fvogt
Cc: broulik, fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21725: Use a native application for starting plasma

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in startplasma.cpp:34
> old code killed ksplash when we showed a message

Now we will return, which will get KSplash out of scope and kill the process 
upon destruction. See KillBeforeDeleter.

> davidedmundson wrote in startplasma.cpp:123
> Not a blocker, but why not use KConfig here?

Because this is clearly faster and not complex at all to read. I can change it 
if you like.
This way we don't worry about reading global files and such.

> davidedmundson wrote in startplasma.cpp:284
> This is wrong.
> 
> forceFontDPI is a number
> we need to read that from the config file and send that to xrdb.
> 
> you can verify it works with
> 
> xrdb -q | grep Xft
> 
> in your session afterwards

Good catch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21725

To: apol, #plasma, fvogt
Cc: broulik, fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham added a comment.


  So um, any chance we can move forward with this in some capacity?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, LeGast00n, 
ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D21134: [Notifications] Tweak paddings

[Nathaniel Graham]

ngraham updated this revision to Diff 59743.
ngraham marked an inline comment as done.
ngraham added a comment.


  Fix RTL paddings

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21134?vs=59741&id=59743

BRANCH
  arcpatch-D21134

REVISION DETAIL
  https://phabricator.kde.org/D21134

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: ngraham, #vdg, broulik
Cc: GB_2, alex-l, filipf, prettyvanilla, cfeck, dos, apol, plasma-devel, 
LeGast00n, ericadams, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21134: [Notifications] Tweak paddings

[Nathaniel Graham]

ngraham marked 2 inline comments as done.
ngraham added a comment.


  All right, I *think* I've addressed the review comments and implemented 
something as close to @alex-l's design as I can get it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: GB_2, alex-l, filipf, prettyvanilla, cfeck, dos, apol, plasma-devel, 
LeGast00n, ericadams, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21725: Use a native application for starting plasma

[David Edmundson]

davidedmundson added a comment.


  Two minor things and then this is good to go.

INLINE COMMENTS

> startplasma.cpp:34
> +
> +void messageBox(const QString &text)
> +{

old code killed ksplash when we showed a message

> startplasma.cpp:123
> +const QString localerc(configDir + QLatin1String("/plasma-localerc"));
> +if (!QFile::exists(localerc)) {
> +QFile f(localerc);

Not a blocker, but why not use KConfig here?

> startplasma.cpp:284
> +//TODO port to c++?
> +const QByteArray input = "Xft.dpi: kcmfonts_general_forcefontdpi";
> +QProcess p;

This is wrong.

forceFontDPI is a number
we need to read that from the config file and send that to xrdb.

you can verify it works with

xrdb -q | grep Xft

in your session afterwards

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21725

To: apol, #plasma, fvogt
Cc: broulik, fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21134: [Notifications] Tweak paddings

[Nathaniel Graham]

ngraham updated this revision to Diff 59741.
ngraham added a comment.


  Address review comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21134?vs=59731&id=59741

BRANCH
  arcpatch-D21134

REVISION DETAIL
  https://phabricator.kde.org/D21134

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: ngraham, #vdg, broulik
Cc: GB_2, alex-l, filipf, prettyvanilla, cfeck, dos, apol, plasma-devel, 
LeGast00n, ericadams, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21785: Don't track subsystem status

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  So far it was unused and we typically just read the user's preferences rather 
than checking what modules have been loaded.
  For hiding unsupported settings (D21113 ) 
I am going to query for the status explicitly anyway since at the point the 
options page comes up the extension is most likely already running.

TEST PLAN
  - Played a video, disabled media controls, reloaded page, media controls were 
gone, re-enabled them, reloaded page, media controls are there again

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21785

AFFECTED FILES
  extension/extension.js
  host/abstractbrowserplugin.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21112: Support message response and reply callbacks

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Ok, I have an idea.
  `browser.runtime.sendMessage` (Firefox) returns a promise that is fulfilled 
when a reply is sent. Chrome instead uses a callback function in 
`chrome.runtime.sendMessage`
  I'm gonna rework the `sendMessage()` to always return a Promise (makes for 
nicer code) by either forwarding the promise from Firefox or creating one 
forwarding the callback in Chrome

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21112

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21784: Remove accidentally slipped back traces of cmake code for Plasma style

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Removed in e914e6323277f7963334897410bd9b7f8341f2ed 
,
  accidentally added back in 8c34dde112e7166dd0ba116022a70586a7c5ade6 


REPOSITORY
  R169 Kirigami

BRANCH
  removedeadcmakecode

REVISION DETAIL
  https://phabricator.kde.org/D21784

AFFECTED FILES
  src/CMakeLists.txt

To: kossebau, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D21134: [Notifications] Tweak paddings

[Nathaniel Graham]

ngraham updated this revision to Diff 59731.
ngraham added a comment.


  Rebase in preparation for resuming work on this

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21134?vs=57885&id=59731

BRANCH
  arcpatch-D21134

REVISION DETAIL
  https://phabricator.kde.org/D21134

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: ngraham, #vdg, broulik
Cc: GB_2, alex-l, filipf, prettyvanilla, cfeck, dos, apol, plasma-devel, 
LeGast00n, ericadams, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21134: [Notifications] Tweak paddings

[Björn Feber]

GB_2 added a comment.


  In D21134#478796 , @alex-l wrote:
  
  > Just a mockup but is this middle ground solution good enough?
  
  
  I absolutely love it!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: GB_2, alex-l, filipf, prettyvanilla, cfeck, dos, apol, plasma-devel, 
LeGast00n, ericadams, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21134: [Notifications] Tweak paddings

[Sebastian Krzyszkowiak]

dos added a comment.


  In D21134#478796 , @alex-l wrote:
  
  > Just a mockup but is this middle ground solution good enough?
  
  
  Yeah, it looks much better than what's currently in 5.16.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: alex-l, filipf, prettyvanilla, cfeck, dos, apol, plasma-devel, LeGast00n, 
ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21743: Prefer document.title over sender.tab.title

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:01a8fa605459: Prefer document.title over sender.tab.title 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21743?vs=59580&id=59728

REVISION DETAIL
  https://phabricator.kde.org/D21743

AFFECTED FILES
  extension/content-script.js
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21779: Resolve X-Flatpak-RenamedFrom

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9258ef586324: [Notifications] Resolve 
X-Flatpak-RenamedFrom (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21779?vs=59725&id=59726

REVISION DETAIL
  https://phabricator.kde.org/D21779

AFFECTED FILES
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification_p.h

To: broulik, #plasma, sitter, davidedmundson
Cc: zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21779: Resolve X-Flatpak-RenamedFrom

[Kai Uwe Broulik]

broulik updated this revision to Diff 59725.
broulik added a comment.


  - Do it manually, thanks @sitter

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21779?vs=59713&id=59725

REVISION DETAIL
  https://phabricator.kde.org/D21779

AFFECTED FILES
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification_p.h

To: broulik, #plasma, sitter, davidedmundson
Cc: zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21110: On config read adjust outputs positions to global value changes

[Roman Gilg]

romangg updated this revision to Diff 59723.
romangg added a comment.


  Rebase on series changes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21110?vs=59671&id=59723

BRANCH
  1controlAdjustPositions

REVISION DETAIL
  https://phabricator.kde.org/D21110

AFFECTED FILES
  kded/output.cpp
  kded/output.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16997: [kcm] Expose interface to control output property retention

[Roman Gilg]

romangg updated this revision to Diff 59722.
romangg added a comment.


  Rebase on series changes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16997?vs=59670&id=59722

BRANCH
  1controlKcm

REVISION DETAIL
  https://phabricator.kde.org/D16997

AFFECTED FILES
  common/control.cpp
  common/control.h
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/widget.cpp
  kcm/src/widget.h

To: romangg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D16996: Add method to write retention to configuration control files

[Roman Gilg]

romangg updated this revision to Diff 59721.
romangg added a comment.


  Fix newline

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16996?vs=59719&id=59721

BRANCH
  1controlWrite

REVISION DETAIL
  https://phabricator.kde.org/D16996

AFFECTED FILES
  common/control.cpp
  common/control.h

To: romangg, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16996: Add method to write retention to configuration control files

[Roman Gilg]

romangg updated this revision to Diff 59719.
romangg added a comment.


  Rebase on series changes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16996?vs=59669&id=59719

BRANCH
  1controlWrite

REVISION DETAIL
  https://phabricator.kde.org/D16996

AFFECTED FILES
  common/control.cpp
  common/control.h
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16995: Consider identical display models in ControlConfig

[Roman Gilg]

romangg updated this revision to Diff 59718.
romangg added a comment.


  Rebase on series changes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16995?vs=59667&id=59718

BRANCH
  1controlNameSpecific

REVISION DETAIL
  https://phabricator.kde.org/D16995

AFFECTED FILES
  common/control.cpp
  common/control.h
  kded/config.cpp
  kded/output.cpp
  kded/output.h
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma
Cc: mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16994: Split Control class into configurations and outputs control classes

[Roman Gilg]

romangg updated this revision to Diff 59717.
romangg added a comment.


  Rebase on series changes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16994?vs=59665&id=59717

BRANCH
  1controlClass

REVISION DETAIL
  https://phabricator.kde.org/D16994

AFFECTED FILES
  common/control.cpp
  common/control.h
  kded/config.cpp

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16993: Add a common directory for functionality being used by kcm and daemon

[Roman Gilg]

romangg updated this revision to Diff 59716.
romangg added a comment.


  Rebase on series changes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16993?vs=59664&id=59716

BRANCH
  1commonInterfacesWithClass

REVISION DETAIL
  https://phabricator.kde.org/D16993

AFFECTED FILES
  common/control.cpp
  common/control.h
  common/globals.cpp
  common/globals.h
  kded/CMakeLists.txt
  kded/config.cpp
  kded/config.h
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21779: Resolve X-Flatpak-RenamedFrom

[Harald Sitter]

sitter added a comment.


if (!service) {
const QString desktopId = desktopEntry + QLatin1String(".desktop");
const auto services = 
KServiceTypeTrader::self()->query(QStringLiteral("Application"),

QStringLiteral("exist Exec and exist [X-Flatpak-RenamedFrom]"));
for (auto it = services.constBegin(); it != services.constEnd() && 
!service; ++it) {
const QVariant renamedFrom = 
(*it)->property(QStringLiteral("X-Flatpak-RenamedFrom"), QVariant::String);
const auto names = renamedFrom.toString().split(QChar(';'));
for (const QString &name : names) {
if (name == desktopId) {
service = *it;
break;
}
}
}
}
  
  Please try with this.
  
  KService doesn't know how to properly deserialize X-* stringlists because we 
have some desktop files which still use comma lists and others which use 
semicolon lists. Because of this a trader query for semicolon separated lists 
won't work unless `KService::property()` gets special hardcoded handling to 
read the list as an XDG type rather than a KConfig type. From a speed POV the 
above code and a complete query are just about the same as a query too would 
simply go into property() to read the property and then check against 
constraints in the query.
  
  The obvious alternative of course is to extend KService. IMHO putting X-* 
keys into KService is fairly awkward though. Another option would be to 
introduce `::xdgProperty()` and then extend the query language to specify a 
type expectation (e.g. `('%1' in XDG[X-Flatpak-RenamedFrom]`).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21779

To: broulik, #plasma, sitter, davidedmundson
Cc: zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16992: Introduce secondary control channel of the KScreen daemon

[Roman Gilg]

romangg updated this revision to Diff 59715.
romangg added a comment.


  - Fix newline at end of files

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16992?vs=59714&id=59715

BRANCH
  1controlRetention

REVISION DETAIL
  https://phabricator.kde.org/D16992

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/229fa9e8a378cb151d7302df42666774
  tests/kded/serializerdata/control/configs/8684e883209d7644eb76feea2081c431
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16992: Introduce secondary control channel of the KScreen daemon

[Roman Gilg]

romangg updated this revision to Diff 59714.
romangg added a comment.


  - Root dictionary in control files

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16992?vs=59663&id=59714

BRANCH
  1controlRetention

REVISION DETAIL
  https://phabricator.kde.org/D16992

AFFECTED FILES
  kded/CMakeLists.txt
  kded/config.cpp
  kded/control.cpp
  kded/control.h
  kded/output.cpp
  kded/output.h
  tests/kded/CMakeLists.txt
  tests/kded/configtest.cpp
  tests/kded/serializerdata/control/configs/229fa9e8a378cb151d7302df42666774
  tests/kded/serializerdata/control/configs/8684e883209d7644eb76feea2081c431
  tests/kded/serializerdata/control/configs/e919cc0dd7aea8d8f519bdf8b93a6f69

To: romangg, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D16997: [kcm] Expose interface to control output property retention

[Roman Gilg]

romangg added a comment.


  I leave the text as is for now. Let's discuss next week at Plasma Sprint.
  
  I would like to see that the last bits of QWidgets get removed in the KCM as 
well. This could be done together then.
  
  Also as I said earlier having retention control per output is too complicated 
imo. But I leave it as is for now as well, since doing it per config simplifies 
stuff and should be easy. This way we then have a comparison.

REVISION DETAIL
  https://phabricator.kde.org/D16997

To: romangg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21779: Resolve X-Flatpak-RenamedFrom

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> notification_p.h:53
>  
> +static KService::Ptr serviceForDesktopEntry(const QString &desktopEntry);
> +

A bit off topic: is there any point for making this method static? You could 
get away with making serviceForDesktopEntry function static in the cpp file.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21779

To: broulik, #plasma, sitter, davidedmundson
Cc: zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21779: Resolve X-Flatpak-RenamedFrom

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When an application got renamed by flatpak-builder without knowing it, it 
will still send its original value as `desktop-entry` breaking the mapping and 
settings.

TEST PLAN
  Telegram sent `telegramdesktop` as `desktop-entry`, now resolves to the 
actual desktop file `org.telegram.desktop`
  
  This likely needs an addition to the `application.desktop` KService 
definition and there's also a bug in the service trader/parser not handling 
desktop file lists properly (they are separted by semi-colon `;` and have a 
trailing one, vs KConfig which is just a simple comma `,`)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21779

AFFECTED FILES
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification_p.h

To: broulik, #plasma, sitter
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D17007: Do hash and hex name based output hashes

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:5e1934de3bbb: Do hash and hex name based output hashes 
(authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17007?vs=59625&id=59710

REVISION DETAIL
  https://phabricator.kde.org/D17007

AFFECTED FILES
  src/output.cpp
  src/output.h

To: romangg, #plasma, lbeltrame
Cc: lbeltrame, mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10750: wayland: Add support for zwp_linux_dmabuf

[Méven Car]

meven added a comment.


  In D10750#327333 , @zzag wrote:
  
  > Any update on this?
  
  
  I am wondering as well.
  This seems like good progress was already done and what is left is some test 
fixes and polish.
  I can only encourage @fredrik and good #kwin 
  folks in their endeavor.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
ericadams, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, 
bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart