D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This is just a speculative fix for the cited bug. BUG: 401861 REPOSITORY R119 Plasma Desktop BRANCH

D19389: Rewrite kworkspace logout, shutdown and suspend API

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in sessionmanagement.cpp:95 > The old one also checked KDM or whatever for "free ttys", is that still a > thing? I don't see where it did > broulik wrote in sessionmanagement.h:93 > Didn't we have a "don't ask" thing that

D19389: Rewrite kworkspace logout, shutdown and suspend API

davidedmundson updated this revision to Diff 60269. davidedmundson marked 6 inline comments as done. davidedmundson added a comment. Review comments. Also now doesn't break old API so we don't have to merge all at once. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21829: Improved Touch support for Kickoff

hein added a subscriber: mart. hein added a comment. I'm in principle quite OK with this minus that other patch I need to be written first to move DragHelper out into the lib (see other comment). Pitch: If you do that, it'll make it much easier to make the other menus (and other things) act

D21763: [kcms/ksmserver] Port to new kworkspace API

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcmsmserver.cpp:86 > +auto sm = new SessionManagement(this); > +auto doShutdown=[sm]() { > +sm->requestReboot(); Coding style. >

D21764: Port all plasma workspace to new libkworkspace API

broulik added inline comments. INLINE COMMENTS > menu.cpp:103 > +connect(m_session, ::canLockChanged, this, > [this]() { > +m_lockScreenAction->setEnabled(m_session->canLock()); > +}); Indentation > powermanagementjob.cpp:62 > +setResult(true); > +

D19389: Rewrite kworkspace logout, shutdown and suspend API

broulik added inline comments. INLINE COMMENTS > loginddbustypes.h:103 > + > +class NamedUserPath > +{ You're using `struct` and `class` with all public inconsistently > loginddbustypes.h:135 > +QString mode; > +int userId; > +uint processId; `userId` is unsigned >

D21969: Remove qtquickcontrols dir

ndavis created this revision. ndavis added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REPOSITORY R31 Breeze BRANCH remove-qtquickcontrols-dir (branched from master) REVISION DETAIL

D21926: Have more contrast in circle-style user avatars

This revision was automatically updated to reflect the committed changes. Closed by commit R128:2d1514b4de0e: Have more contrast in circle-style user avatars (authored by filipf). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21926?vs=60225=60252

D21968: Set desktopFileName

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures potential future windows spawned are identified as part of the

D21829: Improved Touch support for Kickoff

ngraham accepted this revision. ngraham added a comment. Works great for me. Does a #plasma person approve? REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL https://phabricator.kde.org/D21829 To: steffenh, #plasma, hein,

D21958: [quota] Use new breeze icons

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7b0f7c507683: [quota] Use new breeze icons (authored by nicolasfella). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21958?vs=60240=60244 REVISION DETAIL

D21958: [quota] Use new breeze icons

nicolasfella updated this revision to Diff 60240. nicolasfella added a comment. - Change default name REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21958?vs=60228=60240 BRANCH icon REVISION DETAIL https://phabricator.kde.org/D21958 AFFECTED

Re: Vision on web page

It's now live! https://kde.org/plasma-desktop Jonathan On Thu, 20 Jun 2019 at 22:37, David Edmundson wrote: > At the bottom, not as a faux window. > > David >

D21877: Hide tooltip when PrivateActionToolButton is pressed

This revision was automatically updated to reflect the committed changes. Closed by commit R169:66418f55db9b: Hide tooltip when PrivateActionToolButton is pressed (authored by cblack, committed by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D21877: Hide tooltip when PrivateActionToolButton is pressed

ngraham added a comment. @mart told me in person that this is good to go. Thanks very much for your contribution @cblack! May it be the first of many more. :) REPOSITORY R169 Kirigami BRANCH hide-tooltip-on-card-action-trigger (branched from master) REVISION DETAIL

D21961: Port fileindexmonitor kcm to QQC2 and use KCM.SimpleKCM

This revision was automatically updated to reflect the committed changes. Closed by commit R102:2451f2be74d7: Port fileindexmonitor kcm to QQC2 and use KCM.SimpleKCM (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21961?vs=60220=60236

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a4e231e7b6c0: Display a shortcut to the kcm Energy Information from the battery applet… (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20598: Port kcm energy info to kirigami 2, fix colors issues

This revision was automatically updated to reflect the committed changes. Closed by commit R102:bd3341235582: Port kcm energy info to kirigami 2, fix colors issues (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60231=60232

D20598: Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60231. meven added a comment. import QtQuick.Controls 2.5 as QQC2 REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60206=60231 BRANCH arcpatch-D20598_1 REVISION DETAIL https://phabricator.kde.org/D20598

D21958: [quota] Use new breeze icons

nicolasfella updated this revision to Diff 60228. nicolasfella added a comment. - Don't install icon REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21958?vs=60212=60228 BRANCH icon REVISION DETAIL https://phabricator.kde.org/D21958 AFFECTED

D21926: Have more contrast in circle-style user avatars

filipf updated this revision to Diff 60225. filipf added a comment. This revision is now accepted and ready to land. also edit the svg change the style a bit REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21926?vs=60122=60225 BRANCH master

D21963: Keep Klipper notifications out of notification history

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This makes Klipper identify as `org.kde.klipper` to the notification service even when running

D21961: Port fileindexmonitor kcm to QQC2 and use KCM.SimpleKCM

meven created this revision. meven added reviewers: filipf, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D21961 AFFECTED

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY If your filter list has two matching filters for an extension, KFileWidget will return the name of the first filter

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 60216. steffenh added a comment. change variable name from tapandhold to tapAndHold REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21829?vs=60018=60216 BRANCH kickoff REVISION DETAIL

D20598: Port kcm energy info to kirigami 2, fix colors issues

ngraham accepted this revision. ngraham added a comment. Re-add explicit "QQC2" name in the import, per T10862 , then shipit! REPOSITORY R102 KInfoCenter BRANCH arcpatch-D20598_1 REVISION DETAIL https://phabricator.kde.org/D20598 To: meven,

D21954: Handle Gimp 2.10

hein added a comment. In D21954#483133 , @ngraham wrote: > Could this go to the stable branch? Aye, backported. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21954 To: hein, ngraham Cc: ngraham,

D21951: [keyboardindicator] Set Plasmoid to hidden if no lock is active

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. As @broulik says, this wasn't done because then it's impossible to configure without pressing the key. I don't think it should go in without an alternative. REPOSITORY R114

D21958: [quota] Use new breeze icons

nicolasfella created this revision. nicolasfella added reviewers: Plasma, ngraham, ndavis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Shipping an icon ourself is causing trouble. Use the new Breeze

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

meven updated this revision to Diff 60208. meven added a comment. Fix text REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56903=60208 BRANCH arcpatch-D20533_2 REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60206. meven added a comment. Add some padding around the inline message when history is not available REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60205=60206 BRANCH arcpatch-D20598_1 REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60205. meven added a comment. Use KCM.SimpleKCM as root item, fix padding issues, increment kcm version, clean up old now unnecssary workaround REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60193=60205

D21954: Handle Gimp 2.10

ngraham added a comment. Could this go to the stable branch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21954 To: hein, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21954: Handle Gimp 2.10

hein added a comment. In D21954#483114 , @ngraham wrote: > Can we also pre-emptively add 2.12 as well? :) Done. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21954 To: hein, ngraham Cc: ngraham,

D21954: Handle Gimp 2.10

This revision was automatically updated to reflect the committed changes. Closed by commit R120:96655354961d: Handle Gimp 2.10 (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21954?vs=60200=60203#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21954: Handle Gimp 2.10

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can we also pre-emptively add 2.12 as well? :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21954 To: hein, ngraham Cc: ngraham,

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > meven wrote in batterymonitor.qml:142 > Thanks for pointing it out. Not fixed yet. The text needs to be "Show Energy Information..." REPOSITORY R120

D21954: Handle Gimp 2.10

hein created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY GIMP 2.10 is still being a bad desktop citizen and requires a workaround of this sort as well. A nicer fix to do at a later time

D21947: Set translation domain

This revision was automatically updated to reflect the committed changes. Closed by commit R120:588aa6be2984: Set translation domain (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21947?vs=60180=60199 REVISION DETAIL

D21027: [Notes] Fix icons being almost invisible with light backgrounds when using dark themes

This revision was automatically updated to reflect the committed changes. Closed by commit R114:84742d8965bd: [Notes] Fix icons being almost invisible with light backgrounds when using dark… (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D21026: Fix ToolButton remaining in a pressed state after press

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:33a13d11fc55: Fix ToolButton remaining in a pressed state after press (authored by filipf). REPOSITORY R858 Qt

D21951: [keyboardindicator] Set Plasmoid to hidden if no lock is active

broulik added a comment. Again the problem that you can configure the plasmoid to work on different modifier keys potentially locking you out of the applet settings. REPOSITORY R114 Plasma Addons BRANCH hide REVISION DETAIL https://phabricator.kde.org/D21951 To: nicolasfella,

D21951: [keyboardindicator] Set Plasmoid to hidden if no lock is active

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. https://www.youtube.com/watch?v=a6P40wLThbc REPOSITORY R114 Plasma Addons BRANCH hide REVISION DETAIL https://phabricator.kde.org/D21951 To: nicolasfella, #plasma, ngraham Cc:

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60193. meven added a comment. Rebase code, apply Filip's patch, fix right padding of graph REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56376=60193 BRANCH arcpatch-D20598_1 REVISION DETAIL

D21951: [keyboardindicator] Set Plasmoid to hidden if no lock is active

nicolasfella created this revision. nicolasfella added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's not useful. Let's hide it REPOSITORY R114 Plasma Addons BRANCH

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

This revision was automatically updated to reflect the committed changes. Closed by commit R128:8be2414e1012: Add new Konqi avatars remove classic, bluestyle, old konqi avatars (authored by ndavis). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D21949: [libcolorcorrect] Add "Constant" mode

zzag created this revision. zzag added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH native-redshift REVISION DETAIL https://phabricator.kde.org/D21949

D21950: [Night Color KCM] Add "Constant" mode

zzag created this revision. zzag added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH native-redshift REVISION DETAIL https://phabricator.kde.org/D21950

D21915: Fix crash in the touchpad kded

atulbi added a comment. In D21915#482877 , @aacid wrote: > In D21915#482182 , @knambiar wrote: > > > In D21915#482145 , @aacid wrote: > > > > > The

D21927: Use window.postMessage instead of creating a wrapper item

broulik updated this revision to Diff 60186. broulik edited the summary of this revision. broulik added a comment. - Cleanup REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21927?vs=60121=60186 REVISION DETAIL

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

ndavis updated this revision to Diff 60185. ndavis added a comment. Add Musician Konqi REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21939?vs=60165=60185 BRANCH user-pictures (branched from master) REVISION DETAIL

D21925: Update joystick kcm documentation for game controllers

This revision was automatically updated to reflect the committed changes. Closed by commit R119:750343bd0263: Update joystick kcm documentation for game controllers (authored by ndavis). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21925: Update joystick kcm documentation for game controllers

ndavis updated this revision to Diff 60183. ndavis added a comment. Add suggested change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21925?vs=60116=60183 BRANCH joystick-settings (branched from master) REVISION DETAIL

D21934: Ensure no one but us writes to stdout

broulik updated this revision to Diff 60182. broulik added a comment. - dup2 REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21934?vs=60145=60182 REVISION DETAIL https://phabricator.kde.org/D21934 AFFECTED FILES host/connection.cpp

Fwd: XDC 2019: Less than three weeks to go to submit your talks, workshops or demos!

Forwarded Message Subject: XDC 2019: Less than three weeks to go to submit your talks, workshops or demos! Date: Thu, 20 Jun 2019 11:55:39 -0400 From: Mark Filion Organization: Collabora Ltd. To: eve...@lists.x.org Hello! Less than three weeks to go to submit your

D21947: Set translation domain

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Look and feel stuff is loaded into various other places so it needs to set a domain explicitly

D21942: Add gitignore

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a5eed51727f0: Add gitignore (authored by nicolasfella). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21942?vs=60157=60178 REVISION DETAIL