D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

msdobrescu created this revision. msdobrescu added reviewers: ngraham, davidre. msdobrescu added a project: Plasma. Herald added a subscriber: plasma-devel. msdobrescu requested review of this revision. REVISION SUMMARY Another take of bug 186181, as POC. The idea is to use filesystem sorting

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf marked an inline comment as done. filipf added a comment. In D22191#490399 , @cfeck wrote: > See also bug 403953 and bug 408863. That should also be done this summer and before 5.17. REPOSITORY R123 SDDM Configuration Panel

D21815: [sddm-theme] Start moving from QQC1 to QQC2

filipf added a comment. If keeping the new menu style we have to wait until all those patches get merged in Plasma. Might be better to just follow current style; updating it to the new one would be a quick review. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf marked 8 inline comments as done. filipf added inline comments. INLINE COMMENTS > filipf wrote in advanceconfig.cpp:179 > Should I just bring back the code that only does the copy operation if the > entry is not empty or would it also be good to not even add the entry to the > map if

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 61109. filipf added a comment. kcm_sddm.actions - "sync" to "synchronize" sddmauthhelper.cpp - don't needlesslydefine SDDM user twice - revert to copying files only if entry is not empty src/ui/advanceconfig.ui - add icon

D22191: Implement syncing of theme preferences between SDDM and Plasma

davidedmundson added a comment. > I think it could be done with a systemd service I don't think I follow what part of the puzzle that solves. We can already run something as root on demand. I don't think there's any requirement to have something permanently running? Yes,

D22252: [KDEPlatformSystemTrayIcon] Set KStatusNotifierItem to Active

cfeck created this revision. cfeck added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cfeck requested review of this revision. REVISION SUMMARY Qt applications expect that QSystemTrayIcon's default behavior is to show the icon. BUG: 407963

D22223: Seek to end as mpris next action

seijikun planned changes to this revision. seijikun added a comment. Oh, I'm sorry. I had a look in this list here and thought, that all methods without a warning triangle are good to go. I guess this one

D22191: Implement syncing of theme preferences between SDDM and Plasma

cfeck added a comment. See also bug 403953 and bug 408863. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D22191 To: filipf, #plasma, ngraham, davidedmundson, #vdg Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22237: kconf_update: Also migrate from BreezyGTK

This revision was automatically updated to reflect the committed changes. Closed by commit R98:a581f3231e02: kconf_update: Also migrate from BreezyGTK (authored by fvogt). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22237?vs=61063=61093 REVISION

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

ngraham added a comment. Now Plasma crashes when I click Apply no matter which mode is selected: 0x74ac682f in raise () from /usr/lib/libc.so.6 (gdb) bt #0 0x74ac682f in raise () at /usr/lib/libc.so.6 #1 0x74ab1672 in abort () at /usr/lib/libc.so.6

D22191: Implement syncing of theme preferences between SDDM and Plasma

ndavis added a comment. In D22191#489958 , @filipf wrote: > In D22191#489925 , @ndavis wrote: > > > In D22191#489915 , @GB_2 wrote: > > > > > I think

Re: Tipping the apple cart?

On 7/2/19 3:53 PM, Valorie Zimmerman wrote: Please lets keep in mind that this is not a thread to complain about Gitlab. No platform is perfect, and we're not yet on production machines. This thread is about how to make our review process great for both newbies and experienced developers,

D22242: Fix some tests in release mode

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Fix warnigns and tests in non debug mode REPOSITORY R871 DrKonqi BRANCH gitlab/fix_testcases REVISION DETAIL

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 61081. davidre added a comment. - Bool is now other way around REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=61078=61081 BRANCH slideshow (branched from master) REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 50 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/50/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 03 Jul 2019 15:18:21 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT

D22212: change username labels to e-mail address instead

This revision was automatically updated to reflect the committed changes. Closed by commit R871:83c98bd28c4a: change username labels to e-mail address instead (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22212?vs=61002=61080 REVISION

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 61078. davidre added a comment. - Don't invalidate if we are in the config view and the mode is set to random REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=60826=61078 BRANCH slideshow (branched

D22236: [startplamsa-x11] Fix GTK scaling

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1337ae5e0dbb: [startplamsa-x11] Fix GTK scaling (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22236?vs=61061=61077 REVISION

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 49 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/49/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 03 Jul 2019 13:33:31 + Build duration: 1 min 52 sec and counting CONSOLE OUTPUT

D22233: Code Simplification / Readability Changes

This revision was automatically updated to reflect the committed changes. Closed by commit R871:6fd8a05b4da5: Code Simplification / Readability Changes (authored by tcanabrava). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22233?vs=61068=61070 REVISION

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

fvogt updated this revision to Diff 61069. fvogt added a comment. Do it differently. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22238?vs=61064=61069 BRANCH colorfix REVISION DETAIL https://phabricator.kde.org/D22238 AFFECTED FILES

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

sitter added a comment. Not as far as QSP is concerned and that's all that matters here I think. `QStandardPaths::locate` can return any of XDG_CONFIG_{DIRS,HOME} `QStandardPaths::writableLocation` only returns _HOME. So as far as QSP and KConfig are concerned there is only one writable

D22233: Code Simplification / Readability Changes

tcanabrava updated this revision to Diff 61068. tcanabrava added a comment. - Store the number of stars instead of the Enum - Check enums with switch REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22233?vs=61056=61068 BRANCH

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

fvogt added a comment. Basically doing `!m_colorScheme.startsWith(QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation))` instead might work, but maybe there are cases with more than once writable location? The failure mode would be better though, writing to

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

broulik added a comment. Yeah I would suggest taking into account `QStandardPaths::writableLocation` REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22238 To: fvogt, #plasma Cc: broulik, rikmills, kwin, plasma-devel, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2,

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

rikmills added a comment. So if XDG_CONFIG_DIRS contains additional locations, this will not work? e.g. in Kubuntu we set up: XDG_CONFIG_DIRS="$XDG_CONFIG_DIRS:/usr/share/kubuntu-default-settings/kf5-settings" REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22238

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: KWin. Herald added a subscriber: kwin. fvogt requested review of this revision. REVISION SUMMARY If /etc/xdg/kdeglobals exists but ~/.config/kdeglobals does not (like on the first start of kwin_wayland), it

D22233: Code Simplification / Readability Changes

sitter added a comment. I continue to want a switch on the usefulness. If another usefulness gets introduced only a switch will ensure that we get a compiler warning if that new value isn't handled. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D22233 To:

D22237: kconf_update: Also migrate from BreezyGTK

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Also recognize BreezyGTK as theme name to migrate from. TEST PLAN Was applied downstream for years. Apparently nobody sent that upstream,

D22230: [TaskManager] Follow KDE title & subtitle style

filipf updated this revision to Diff 61062. filipf added a comment. use DescriptiveLabel for subtitle/artist info REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22230?vs=61051=61062 BRANCH tooltip-media-titlesubtitle-style (branched from master)

D22230: [TaskManager] Follow KDE title & subtitle style

hein added a comment. @filipf: Yep, sounds sensible :) REPOSITORY R119 Plasma Desktop BRANCH tooltip-media-titlesubtitle-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D22230 To: filipf, #plasma, #vdg, ngraham, hein Cc: plasma-devel, LeGast00n, jraleigh,

D22236: [startplamsa-x11] Fix GTK scaling

broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `ScreenScaleFactors` is a list of scales per output. We want to read the `ScaleFactor`

D22230: [TaskManager] Follow KDE title & subtitle style

filipf added a comment. @hein would you want me to use PlasmaExtras.DescriptiveLabel for the subtitle, same as in D22231 ? Makes us not have to specify opacity. REPOSITORY R119 Plasma Desktop BRANCH tooltip-media-titlesubtitle-style (branched from

D22231: [Lock screen] Follow KDE title & subtitle style

filipf updated this revision to Diff 61060. filipf added a comment. use DescriptiveLabel for subtitle REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22231?vs=61052=61060 BRANCH lockscreen-titlesubtitle-style (branched from master) REVISION

D22233: Code Simplification / Readability Changes

tcanabrava updated this revision to Diff 61056. tcanabrava added a comment. - Store the number of stars instead of the Enum REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22233?vs=61054=61056 BRANCH gitlab/drkonqi_simplifications REVISION DETAIL

D22233: Code Simplification / Readability Changes

tcanabrava marked an inline comment as done. tcanabrava added inline comments. INLINE COMMENTS > broulik wrote in debugger.cpp:91 > I find early returns to be more readable. Maybe just remove the explicit `} > else {` statement @broulik those changes where made to keep the rest of the file in

D22231: [Lock screen] Follow KDE title & subtitle style

broulik added inline comments. INLINE COMMENTS > MediaControls.qml:132 > +font.pointSize: theme.smallestFont.pointSize + 1 > +opacity: 0.6 > } Use `PlasmaExtras.DescriptiveLabel` instead REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22233: Code Simplification / Readability Changes

broulik added inline comments. INLINE COMMENTS > backtraceratingwidget.h:50 > > -boolm_star1; > -boolm_star2; > -boolm_star3; > - > +BacktraceParser::Usefulness m_usefullness; > QPixmap

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 48 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/48/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 03 Jul 2019 09:29:25 + Build duration: 2 min 55 sec and counting CONSOLE OUTPUT

D22232: assert qt and kf5 versions against their actual underlying class

This revision was automatically updated to reflect the committed changes. Closed by commit R871:d51962c416aa: assert qt and kf5 versions against their actual underlying value (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D22233: Code Simplification / Readability Changes

sitter added inline comments. INLINE COMMENTS > backtraceratingwidget.cpp:48 > > -p.drawPixmap(QPoint(30, 1) , m_star1 ? m_starPixmap : > m_disabledStarPixmap); > -p.drawPixmap(QPoint(55, 1) , m_star2 ? m_starPixmap : > m_disabledStarPixmap); > -p.drawPixmap(QPoint(80, 1) ,

D22233: Simplify algorithm to draw the stars.

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Small changes thru the codebase to improve readability. One potential crash fixed, and an old file removed. REPOSITORY

D22232: assert qt and kf5 versions against their actual underlying class

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this isn't super useful to compare other than the calls don't explode, doesn't have a downside either though... TEST PLAN test

D22231: [Lock screen] Follow KDE title & subtitle style

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We're currently using a custom tyle for song titles and artist info in the lock screen's media controls. This patch applies

D22230: [TaskManager] Follow KDE title & subtitle style

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We're currently using a custom style for song titles and artist info in tooltips. This patch applies the common KDE title &

D21815: [sddm-theme] Start moving from QQC1 to QQC2

GB_2 added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf,

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf added a comment. In D22191#489925 , @ndavis wrote: > In D22191#489915 , @GB_2 wrote: > > > I think then you would have to type in your password every time you change a setting. > > >

D22229: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false

fvogt added a comment. IMO this should be up to the content script, which seems to handle this properly already REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D9 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22229: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Spec says "If is false, attempting to call this method should have no effect." TEST PLAN

D22223: Seek to end as mpris next action

broulik added a comment. Thanks for your patch. `fastSeek` doesn't seem to be part of the HTML audio/video DOM API and also isn't supported by Chrome. A website should provide a `nexttrack` callback if it supports changing tracks, which YouTube does while watching playlists. Your patch

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. > This patch only helps with the case where SDDM is updated first, No, it solves all cases. Patched SDDM and therefore also GDM and LightDM show "Plasma (X11)" and "Plasma", while unpatched SDDM shows "Plasma (X11)" and "Plasma (Wayland)". REPOSITORY R120

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 61 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/61/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Jul 2019 06:59:20 + Build duration: 2 min 57 sec and counting

D22191: Implement syncing of theme preferences between SDDM and Plasma

ndavis added a comment. In D22191#489915 , @GB_2 wrote: > In D22191#489838 , @ndavis wrote: > > > > Settings UI: > > > F6953661: Screenshot_20190701_234413.png