D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-06 Thread David Redondo
davidre added inline comments.

INLINE COMMENTS

> image.cpp:600
> +m_slideshowModel->addBackground(path);
> +m_currentSlide = m_slideFilterModel->indexOf(path) - 1;
>  nextSlide();

Currently the slideshow would restart. I guess we could check here if the index 
is -1. Or alternatively don't trigger this from the qml side if the image is 
unchecked. In my mind this even better because then we enable the apply button, 
too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

2019-07-06 Thread Stefan Brüns
bruns added a comment.


  After having looked into the callchain again, I am not sure what the best 
action here is:
  
  The old code did a DBus call of org.freedesktop.PowerManagement.Inhibit, 
which is implemented by powerdevil. Powerdevil only "schedules" the inhibition, 
but delays it for 5 seconds:
  
https://github.com/KDE/powerdevil/blob/master/daemon/powerdevilpolicyagent.cpp#L521
  
  ... but closing the session triggers a shutdown of powerdevil, i.e. the 
inhibition was not enforced at all (we only did a pointless synchronous DBus 
call to powerdevil).
  
  What about just removing the code?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22296

To: bruns, #plasma, broulik, davidedmundson
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart


D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

2019-07-06 Thread Aleix Pol Gonzalez
apol added a comment.


  Solid::InhibitionJob isn't installed by default, is it?
  Is the plan to make it the public API now?
  
  Not disagreeing with the change, just would need changes in Solid first.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22296

To: bruns, #plasma, broulik, davidedmundson
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart


D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

2019-07-06 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Plasma, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  As KDELibs4Support pulled in a number of Frameworks, we have to
  explicitly add these now.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ksmserver_no_kdelibs4support

REVISION DETAIL
  https://phabricator.kde.org/D22296

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/logout.cpp
  ksmserver/server.h

To: bruns, #plasma, broulik, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22252: [KDEPlatformSystemTrayIcon] Set KStatusNotifierItem to Active

2019-07-06 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:d2a1d1ca9e9e: [KDEPlatformSystemTrayIcon] Set 
KStatusNotifierItem to Active (authored by cfeck).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22252?vs=61102=61246

REVISION DETAIL
  https://phabricator.kde.org/D22252

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp

To: cfeck, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22231: [Lock screen] Follow KDE title & subtitle style

2019-07-06 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b414ac1c7a09: [Lock screen] Follow KDE title  
subtitle style (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22231?vs=61060=61245

REVISION DETAIL
  https://phabricator.kde.org/D22231

AFFECTED FILES
  lookandfeel/contents/lockscreen/MediaControls.qml

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart