D22457: Make it possible to show the QR of a network connection

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> ConnectionItem.qml:171
> +text: i18n("Show network's QR code")
> +visible: ConnectionState !== PlasmaNM.Enums.Deactivated
> +onClicked: {

I think this should be limited to wireless connections only (Type == 
PlasmaNM.Enums.Wireless).

> handler.cpp:188
> +
> +const NetworkManager::WirelessSecurityType securityType = 
> NetworkManager::findBestWirelessSecurity(wifiDev->wirelessCapabilities(), 
> true, (ap->mode() == NetworkManager::AccessPoint::Adhoc), ap->capabilities(), 
> ap->wpaFlags(), ap->rsnFlags());
> +QString ret = QStringLiteral("WIFI:");

Each item in the model already exposes **SecurityType** so you don't need to 
search for the AP and find security type it uses.

> handler.cpp:212
> +NetworkManager::Connection::Ptr connection = 
> NetworkManager::findConnection(connectionPath);
> +const auto key = QStringLiteral("802-11-wireless-security");
> +auto reply = connection->secrets(key);

Networks using WPA2-EAP or DynamicWEP don't have secrets stored as 
**802-11-wireless-security**, these are under **802-1-x**. Anyway, I think we 
should maybe filter these out, you will most likely won't be sharing them 
anyway. You can do that in the applet already, check 
**predictableWirelessPassword** property.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg created this revision.
romangg added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The KScreen KCM was still partly Qt Widgets based. Also it did not use a
  model for the outputs but instead created objects in C++ for visual
  representation of the outputs.
  
  This patch bases the KScreen KCM on ConfigModule removing any dependency
  on Qt Widgets. The former widgets based settings form is rewritten as
  Kirigami form layout.
  
  The already existing QML part has been also rewritten with a model as
  data provider for the outputs and input handlers for interacting with the
  outputs in the overview.
  
  On hotplug events the settings dialog is reset and the user is informed.
  
  Output retention now is set for the whole config instead of individual
  outputs what simplifies it.
  
  On Wayland output scaling is now fractional via a slider. This has not yet
  been tested though and there might be some more work necessary in KWin.
  
  The output unification has been removed for now. It was broken in certain
  ways and we should try instead to improve the libkscreen backend to make
  unficiation more easy to use. For now as a workaround the outputs can be
  placed on top of each other to create a clone effect.
  
  The KScreen maintainership is changed to me.

TEST PLAN
  Manually on X and Wayland.

REPOSITORY
  R104 KScreen

BRANCH
  qmlize

REVISION DETAIL
  https://phabricator.kde.org/D22468

AFFECTED FILES
  CMakeLists.txt
  common/utils.cpp
  common/utils.h
  kcm/CMakeLists.txt
  kcm/Messages.sh
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm_kscreen.desktop
  kcm/kcm_kscreen.desktop.cmake
  kcm/output_identifier.cpp
  kcm/output_identifier.h
  kcm/output_model.cpp
  kcm/output_model.h
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/RotationButton.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml
  kcm/package/metadata.desktop
  kcm/qml/CMakeLists.txt
  kcm/qml/Output.qml
  kcm/qml/OutputIdentifier.qml
  kcm/qml/Tip.qml
  kcm/qml/main.qml
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/declarative/qmloutput.cpp
  kcm/src/declarative/qmloutput.h
  kcm/src/declarative/qmloutputcomponent.cpp
  kcm/src/declarative/qmloutputcomponent.h
  kcm/src/declarative/qmlscreen.cpp
  kcm/src/declarative/qmlscreen.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h
  kcm/src/kcm_testapp.cpp
  kcm/src/kscreen_widget.ui
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/previewwidget.cpp
  kcm/src/previewwidget.h
  kcm/src/resolutionslider.cpp
  kcm/src/resolutionslider.h
  kcm/src/scaling.ui
  kcm/src/scalingconfig.cpp
  kcm/src/scalingconfig.h
  kcm/src/stylepreview.ui
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/utils.cpp
  kcm/src/utils.h
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/CMakeLists.txt
  kded/osd.cpp
  tests/osd/CMakeLists.txt

To: romangg, #plasma, #kwin
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22457: Make it possible to show the QR of a network connection

[Nathaniel Graham]

ngraham added a comment.


  Yeah maybe. Here's what happens on X11:
  
  F7024605: Screenshot_20190714_215130.png 


REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol added a comment.


  In D22457#495614 , @ngraham wrote:
  
  > One thing I noticed when trying this out is that when the full-screen 
window showing the QR code appears, plasma-nm's system tray popup doesn't 
close, and the QR code window is drawn underneath it. On my 16x9 screen, the 
system tray popup just barely doesn't overlap the QR code, but I bet it would 
on a 4:3 screen, or a screen in portrait orientation.
  
  
  Weird, for me the window stays on top. Maybe it's a X11 vs Wayland thing?
  
  > Also maybe the menu item could have the icon `view-barcode`. It's not idea 
but maybe it's better than nothing?
  
  Added the icon.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61774.
cblack added a comment.


  Use units.longDuration

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61761=61774

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Nathaniel Graham]

ngraham added a comment.


  One thing I noticed when trying this out is that when the full-screen window 
showing the QR code appears, plasma-nm's system tray popup doesn't close, and 
the QR code window is drawn underneath it. On my 16x9 screen, the system tray 
popup just barely doesn't overlap the QR code, but I bet it would on a 4:3 
screen, or a screen in portrait orientation.
  
  Also maybe the menu item could have the icon `view-barcode`. It's not idea 
but maybe it's better than nothing?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> Main.qml:424
> +NumberAnimation {
> +duration: 500
> +easing.type: Easing.InOutQuad

Match the duration for other opacity animation effects (i.e. use 
`units.longDuration`)

> Main.qml:444
> +NumberAnimation {
> +duration: 500
> +easing.type: Easing.InOutQuad

ditto

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22467: Make captive portal notification persistent but low priority

[Aleix Pol Gonzalez]

apol added a comment.


  +1
  
  Makes sense to me. I added a similar feature to work around the disappearing 
notification few weeks ago.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22467

To: ngraham, #plasma, jgrulich
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61773.
apol added a comment.


  Removed unnecessary things

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22457?vs=61767=61773

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/ShowQR.qml
  kded/networkmanagement.notifyrc
  libs/handler.cpp
  libs/handler.h

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21905: [Digital Clock] Open KOrganizer with event details on click

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CalendarView.qml:196
> +onClicked: {
> +monthView.daysModel.showEventDetails(modelData.uid)
> +}

Maybe it should only be enabled if there's events to show?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21905

To: dvratil, #plasma
Cc: apol, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22467: Make captive portal notification persistent but low priority

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
ngraham requested review of this revision.

REVISION SUMMARY
  The captive portal notification is something that shouldn't time out; when it
  becomes visible, it's something the user needs to interact with. I had a
  frustrating experience just now trying and failing to click on it before it 
timed
  out.
  
  At the same time, once it's interacted with (either by closing it or clicking 
the
  "Log in" button, there's no need for it to appear in the history, as its 
history
  item is both non-informative and non-interactive.
  
  Accordingly, this patch makes the captive portal notification both persistent 
and
  low urgency (so it doesn't appear in the history).
  
  A similar thing has already been done for Discover in D22429 
.

TEST PLAN
  Connected to the in-flight wifi network  on the plane I'm on right now
  Captive Portal notification was persistent and didn't show up in the history
  after dismissed or logged into via the button on the notification pop-up

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  persistent-captive-portal-notification (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22467

AFFECTED FILES
  kded/networkmanagement.notifyrc
  kded/portalmonitor.cpp

To: ngraham, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22457: Make it possible to show the QR of a network connection

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ShowQR.qml:53
> +Layout.fillWidth: true
> +Layout.fillHeight: true
> +content: "don't look at my wifi"

These won't do anything because it's not in a Layout anymore

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22426: Add Unsplash POTD Provider

[Filip Fila]

filipf added a comment.


  In D22426#495465 , @ognarb wrote:
  
  > In D22426#494745 , @guoyunhe 
wrote:
  >
  > > Photos on Unsplash are under CC0 (public domain) now. So here shouldn't 
be copyright issues.
  > >
  > > I do think it is good to show photographers' credits. But that will 
require changes to POTD class and wallpaper widget.
  >
  >
  > Where did you read that Unsplash images were CC0? The license 
 is not CC0 and is in fact non-free. Or are the 
pictures fetched at https://unsplash.com/wallpaper/1065396/desktop-wallpapers 
licensed explicitly under CC0?
  
  
  It's free. It's CC0 with the addition of "This license does not include the 
right to compile photos from Unsplash to replicate a similar or competing 
service.".

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22426

To: guoyunhe, #plasma, ngraham
Cc: ognarb, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22463: data/kde32b1.khotkeys: Write in US English: anticlockwise -> counterclockwise

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R101:e498b3aaa70d: data/kde32b1.khotkeys: Write in US English: 
anticlockwise - counterclockwise (authored by aspotashev).

REPOSITORY
  R101 KHotKeys

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22463?vs=61764=61770

REVISION DETAIL
  https://phabricator.kde.org/D22463

AFFECTED FILES
  data/kde32b1.khotkeys

To: aspotashev, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol added a comment.


  In D22457#495406 , @ngraham wrote:
  
  > The more things we put into the context menu, the more important I think it 
becomes to port the delegates to use a Krigami basiclistitem and make the items 
in the context menu show up on hover, with some of the more esoteric ones being 
in an overflow menu. We should probably also first extend it to support actions 
that show their text, so the connext/disconnect action has the most visual 
prominence.
  
  
  I agree, this view could be improved.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61767.
apol marked an inline comment as done.
apol added a comment.


  Address Nate's comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22457?vs=61752=61767

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/ShowQR.qml
  kded/networkmanagement.notifyrc
  libs/handler.cpp
  libs/handler.h

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol marked 3 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> ngraham wrote in ShowQR.qml:45
> I don't think you need to use a ColumnLayout if it'll have only one item in 
> it. You can just add margins to the Prison item itself.

Yes, good catch. I had something there and ended up removing it.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22464: kcms/phonon: Remove trailing space from an i18n string

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2f21504c080f: kcms/phonon: Remove trailing space from an 
i18n string (authored by aspotashev).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22464?vs=61765=61766

REVISION DETAIL
  https://phabricator.kde.org/D22464

AFFECTED FILES
  kcms/phonon/devicepreference.cpp

To: aspotashev, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22464: kcms/phonon: Remove trailing space from an i18n string

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R119 Plasma Desktop

BRANCH
  i18n-space

REVISION DETAIL
  https://phabricator.kde.org/D22464

AFFECTED FILES
  kcms/phonon/devicepreference.cpp

To: aspotashev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22463: data/kde32b1.khotkeys: Write in US English: anticlockwise -> counterclockwise

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R101 KHotKeys

BRANCH
  ccw

REVISION DETAIL
  https://phabricator.kde.org/D22463

AFFECTED FILES
  data/kde32b1.khotkeys

To: aspotashev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61761.
cblack added a comment.


  Logo has text now

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61756=61761

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: RFC: Running clang-format across all Plasma (and more?) repos

[Albert Astals Cid]

El dijous, 11 de juliol de 2019, a les 16:18:08 CEST, David Edmundson va 
escriure:
> One topic discussed at the recent Plasma sprint was that we should run
> a code formatting tool (clang-format) over all our repos to ease all
> future review comments about whitespace.
> 
> All new contributions simply have to run the same tool and we get
> consistent code without having to comment on every minor thing in a
> review individually.
> 
> I've written up a wall of text outlining steps, challenges etc.
> https://phabricator.kde.org/T11214
> 
> Does anyone have any thoughts / objections?

If we don't get some sort of precommit hook or "Merge Request" stage support 
it'll be somewhat useless.

"No one" will run the tool manually before doing a commit, this means that 
you'll need to run the tool every N months because commits go ignoring the 
format. I don't think that'd be sustainable in the long runo

I know "automation" is in your plan, but AFAICS only as optional, i don't 
really think that's optional.

Cheers,
  Albert

> 
> David
> 

D22460: DrKonqi: improved lldb integration

[René J . V . Bertin]

rjvbb created this revision.
rjvbb added reviewers: kde-frameworks-devel, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rjvbb requested review of this revision.

REVISION SUMMARY
  Since a few versions lldb has had a tendency to remain stuck after the 
initial connection to the crashed application (on Mac). On Linux it would often 
exit cleanly and quickly in a way not foreseen by my previous code, causing 
DrKonqi to report an unexpected debugger termination.
  
  This patch addresses both issues:
  
  - recent lldb versions have no more problems with reading commands from a 
batchfile
  - this make it possible to add an explicit exit command
  - `slotProcessExited()` is called explicitly when lldb has confirmed the exit 
command
  - errors caused by terminating or killing the debugger process are now 
ignored.

TEST PLAN
  Getting a crash backtrace now works as expected on Mac and Linux. No 
regressions are introduced when using the gdb backend on Linux.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22460

AFFECTED FILES
  src/backtracegenerator.cpp
  src/backtracegenerator.h
  src/data/debuggers/internal/lldbrc

To: rjvbb, kde-frameworks-devel, #plasma
Cc: plasma-devel, kde-mac, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22426: Add Unsplash POTD Provider

[Carl Schwan]

ognarb added a comment.


  In D22426#494745 , @guoyunhe wrote:
  
  > Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be 
copyright issues.
  >
  > I do think it is good to show photographers' credits. But that will require 
changes to POTD class and wallpaper widget.
  
  
  Where did you read that Unsplash images were CC0? The license 
 is not CC0 and is in fact non-free. Or are the 
pictures fetched at https://unsplash.com/wallpaper/1065396/desktop-wallpapers 
licensed explicitly under CC0?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22426

To: guoyunhe, #plasma, ngraham
Cc: ognarb, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack added a comment.


  In D22458#495455 , @ngraham wrote:
  
  > An interesting idea. Are you in contact with any distros that have 
requested this or would make use of it?
  
  
  This was created directly because an LCP (artwork dude) at openSUSE requested 
it (see VDG chat).
  
  In D22458#495455 , @ngraham wrote:
  
  > I wouldn't mind adding some text to the default logo so for any distros 
that opt to turn it on and not override the defaults, people learn what it 
actually is (Plasma's logo recognition is low right now). Then again that means 
unlocalized text, unless you do something clever to allow the logo component to 
pull text from a localizable file.
  
  
  Names in logos tend not to be localized from roman characters -> other 
character sets, so this really isn't a large concern for me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Nathaniel Graham]

ngraham added a reviewer: Plasma.
ngraham added a comment.


  An interesting idea. Are you in contact with any distros that have requested 
this or would make use of it?
  
  I wouldn't mind adding some text to the default logo so for any distros that 
opt to turn it on and not override the defaults, people learn what it actually 
is (Plasma's logo recognition is low right now). Then again that means 
unlocalized text, unless you do something clever to allow the logo component to 
pull text from a localizable file.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61756.
cblack added a comment.


  This is why you shouldn't forget to test - default logo is now no longer 
pitifully small

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61755=61756

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack created this revision.
cblack added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The Breeze SDDM theme now shows a logo that can be configured by distro 
vendors or curious users.

TEST PLAN
  Test configuration and defaults.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22457: Make it possible to show the QR of a network connection

[Nathaniel Graham]

ngraham added a comment.


  The more things we put into the context menu, the more important I think it 
becomes to port the delegates to use a Krigami basiclistitem and make the items 
in the context menu show up on hover, with some of the more esoteric ones being 
in an overflow menu. We should probably also first extend it to support actions 
that show their text, so the connext/disconnect action has the most visual 
prominence.
  
  Anyway, enough rambling, that would be material for another patch anyway, I 
just wanted to mention it.

INLINE COMMENTS

> ConnectionItem.qml:170
> +PlasmaComponents.MenuItem {
> +text: i18n("Show Network QR")
> +visible: ConnectionState !== PlasmaNM.Enums.Deactivated

"Show network's QR code"

> ShowQR.qml:45
> +
> +ColumnLayout {
> +anchors {

I don't think you need to use a ColumnLayout if it'll have only one item in it. 
You can just add margins to the Prison item itself.

> networkmanagement.notifyrc:817
> +[Event/WifiQR]
> +Name=Show Wifi netwerk QR
> +Action=Popup

"Show network's QR code"

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol added a comment.


  F7022898: Screenshot_20190714_213236.png 

  
  F7022913: Screenshot_20190714_213624.png 


REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
apol requested review of this revision.

REVISION SUMMARY
  It's useful to be able to share a network connection by showing its QR
  on the device so others can take a picture of it.
  It shows a maximised window that will disappear when we click on it.

TEST PLAN
  Looked at my wifi's QR

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/ShowQR.qml
  kded/networkmanagement.notifyrc
  libs/handler.cpp
  libs/handler.h

To: apol, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Vlad Zagorodniy]

zzag added a comment.


  We should not style server-side decorated Firefox windows. They are fine.
  
  The problem you're trying to solve only affects client-side decorated Firefox 
windows
  
  F7022851: Screenshot_20190714_221415.png 

  
  F7022853: Screenshot_20190714_221444.png 

  
  :backdrop selector currently doesn't have any effect, see 
https://bugzilla.mozilla.org/show_bug.cgi?id=1562507.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

[Andrew]

https://bugs.kde.org/show_bug.cgi?id=357288

Andrew  changed:

   What|Removed |Added

 CC||andrewdba...@gmail.com

--- Comment #12 from Andrew  ---
Disappointed to see this problem is still around after so long.  I had worked
around this by modifying my xorg.conf to disable DPMS, but some recent update
broke this again.  After about 15 minutes, my monitors will blank, shut off, or
whatever it is that's happening, sometimes in the middle of games if it's not
looking at controller input to see if I'm actively using the computer.  DPMS is
still disabled from the last time I tweaked this setting, and it's not working
anymore; even still, KDE should be able to set this itself as per the system
settings anyway.  Current software versions are:

Kubuntu 18.04 64-bit
Plasma 5.12.7
Frameworks 5.44.0
Qt 5.9.5
Kernel 4.18.16-041816-generic

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 66 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/66/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 14 Jul 2019 14:35:16 +
 Build duration:
2 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-14T14:37:28.918Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-14T14:37:28.918Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-14T14:37:28.918Z] PROCESSOR_LEVEL   = '6'[2019-07-14T14:37:28.918Z] PROCESSOR_REVISION= '5e03'[2019-07-14T14:37:28.918Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-14T14:37:28.918Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-14T14:37:28.918Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-14T14:37:28.918Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-14T14:37:28.918Z] PROMPT= '$P$G'[2019-07-14T14:37:28.918Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-14T14:37:28.918Z] PUBLIC= 'C:\Users\Public'[2019-07-14T14:37:28.918Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/66/display/redirect?page=changes'[2019-07-14T14:37:28.918Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/66/display/redirect'[2019-07-14T14:37:28.918Z] STAGE_NAME= 'Configuring Build'[2019-07-14T14:37:28.918Z] SYSTEMDRIVE   = 'C:'[2019-07-14T14:37:28.918Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-14T14:37:28.918Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-14T14:37:28.918Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-14T14:37:28.918Z] UCRTVERSION   = '10.0.17763.0'[2019-07-14T14:37:28.918Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-14T14:37:28.918Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-14T14:37:28.918Z] USERNAME  = 'Jenkins'[2019-07-14T14:37:28.918Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-14T14:37:28.918Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-14T14:37:28.918Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-14T14:37:28.918Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-14T14:37:28.918Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-14T14:37:28.918Z] VCTOOLSVERSION= '14.16.27023'[2019-07-14T14:37:28.918Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-14T14:37:28.918Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-14T14:37:28.918Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-14T14:37:28.918Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-14T14:37:28.918Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-14T14:37:28.918Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-14T14:37:28.918Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-14T14:37:28.918Z] VSCMD_VER = '16.0.3'[2019-07-14T14:37:28.918Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-14T14:37:28.918Z] WINDIR= 'C:\WINDOWS'[2019-07-14T14:37:28.919Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-14T14:37:28.919Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-14T14:37:28.919Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-14T14:37:28.919Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-14T14:37:28.919Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-14T14:37:28.919Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-14T14:37:28.919Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-14T14:37:28.919Z] __DOTNET_ADD_64BIT= '1'[2019-07-14T14:37:28.919Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-14T14:37:28.919Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-14T14:37:28.919Z] 

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw updated this revision to Diff 61740.
mthw added a comment.


  Replace hardcoding

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22452?vs=61733=61740

BRANCH
  fix-firefox-tab-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22452

AFFECTED FILES
  src/gtk320/apps/_firefox.scss
  src/gtk320/gtk.scss

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Carson Black]

cblack added a comment.


  I would probably replace 
  `color: #eff0f1;` -> `color: t_color(text);`
  `background-color: #475057;` -> `background-color: t_color(background);`
   in `_firefox.scss` to not hardcode the colors

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Nathaniel Graham]

ngraham added a comment.


  Whether or not it's better is not relevant for this patch, which right now is 
only about fixing the text color. It's best not to mix multiple changes like 
this, unless you want to expand the patch in scope, in which case it should be 
re-titled accordingly.
  
  Still, I would recommend doing one change per patch, because it makes each 
one more likely to get in compared to patches with multiple changes (especially 
when any one of those individual changes may be controversial or require 
discussion).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw added a comment.


  Yes, I see it is different, but isn't it better now (after the patch)? 
https://imgur.com/a/aauVgPp

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:4352cf848d30: Unsplash POTD: filter out banner image and 
pick random photo from latest (authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22451?vs=61727=61736

REVISION DETAIL
  https://phabricator.kde.org/D22451

AFFECTED FILES
  dataengines/potd/unsplashprovider.cpp
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right, let's not poke the bear too much then. :)

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22451

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  "Capture Devices" sounds like some kind of kidnapping tool to people who 
aren't
  audio experts. Changing "Capture" to "Recording" both makes the text less 
scary,
  and also improves clarity ("Capture" only implies that it's for audio capture;
  "Recording" makes it explicit)

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  capture-to-recording (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22453

AFFECTED FILES
  applet/contents/ui/main.qml

To: ngraham, #plasma, #vdg, drosca
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw added a comment.


  In D22452#495286 , @ndavis wrote:
  
  > This causes a problem with Breeze and Breeze Dark when the titlebar is 
enabled.
  >
  > With Patch
  >  ==
  >  Breeze: F7021382: Screenshot_20190714_080027.png 

  >  Breeze Dark: F7021377: Screenshot_20190714_075941.png 

  >
  > Without Patch
  >  =
  >  Breeze: F7021388: Screenshot_20190714_080147.png 

  >  Breeze Dark: F7021392: Screenshot_20190714_080229.png 

  
  
  Could you be more specific please? In your screenshot I can see a difference 
in Breeze Dark. But, do you use old Breeze theme, because your Breeze "before" 
screenshot doesn't look like current Breeze theme.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  This causes a problem with Breeze and Breeze Dark when the titlebar is 
enabled.
  
  With Patch
  ==
  
  Breeze: F7021382: Screenshot_20190714_080027.png 

  Breeze Dark: F7021377: Screenshot_20190714_075941.png 

  
  Without Patch
  =
  
  Breeze: F7021388: Screenshot_20190714_080147.png 

  Breeze Dark: F7021392: Screenshot_20190714_080229.png 


REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

[Yunhe Guo]

guoyunhe added a comment.


  In D22451#495279 , @ngraham wrote:
  
  > Ah right, that's a property of `Image`, not `QImageItem`.
  >
  > https://doc.qt.io/qt-5/qml-qtquick-image.html#sourceSize-prop
  >
  > Can you use `Image` instead?
  
  
  I got a blocker: `engine.data[provider]["Image"]` is QImage not string. So I 
cannot assign it as `source` of `Image`. I don't know if it is possible.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22451

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw added a comment.


  
  
  > ... it seems to do nothing ...
  
  The problem was that I tried to use a color name instead of a hex code and 
put a wrong name there (still don't know the correct one).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw updated this revision to Diff 61733.
mthw added a comment.


  Fixed wrong color name.

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22452?vs=61731=61733

BRANCH
  fix-firefox-tab-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22452

AFFECTED FILES
  src/gtk320/apps/_firefox.scss
  src/gtk320/gtk.scss

To: mthw, #vdg, #breeze, ndavis
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

[Nathaniel Graham]

ngraham added a comment.


  Ah right, that's a property of `Image`, not `QImageItem`.
  
  https://doc.qt.io/qt-5/qml-qtquick-image.html#sourceSize-prop
  
  Can you use `Image` instead?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22451

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

[Yunhe Guo]

guoyunhe added a comment.


  In D22451#495272 , @ngraham wrote:
  
  > Instead of `smooth: true` doing this may achieve the same result with less 
memory usage:
  >
  >   sourceSize.width: parent.width
  >   sourceSize.height: parent.height
  >
  
  
  I tried it but got black screen...
  
QImageItem {
anchors.fill: parent
image: engine.data[provider]["Image"]
fillMode: wallpaper.configuration.FillMode
// Render image smoothly
sourceSize.width: parent.width
sourceSize.height: parent.height
}

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22451

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

[Nathaniel Graham]

ngraham added a comment.


  Instead of `smooth: true` doing this may achieve the same result with less 
memory usage:
  
sourceSize.width: parent.width
sourceSize.height: parent.height

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22451

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Noah Davis]

ndavis added a comment.


  In D22452#495224 , @zzag wrote:
  
  > I'm not a Breeze GTK maintainer or developer
  
  
  There is currently no maintainer of breeze-gtk
  
  In D22452#495265 , @mthw wrote:
  
  > I seem to have some problems building this, I guess I need to change 
something in build files. Could you help me find it, I am new at this?
  
  
  How did you get it working in the first place? It builds fine for me, but it 
seems to do nothing, even when I add `@import "apps/firefox";` to 
`src/gtk320/gtk.scss`

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw planned changes to this revision.
mthw added a comment.


  I seem to have some problems building this, I guess I need to change 
something in build files. Could you help me find it, I am new at this?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  fix-firefox-tab-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw marked an inline comment as done.
mthw added a comment.


  Yes I have tried with Breeze Dark, it works correctly.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw added a comment.


  In D22452#495240 , @ndavis wrote:
  
  > Can you post a picture of what this change is supposed to do?
  
  
  Before: https://imgur.com/a/MqqgUQm
  After: https://imgur.com/a/gu5RV6M

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> _firefox.scss:4
> +color: theme_bg_color; 
> +background-color: #475057;
> +} 

I see that you are hardcoding a color here. Have you tested the change with 
Breeze Dark?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Noah Davis]

ndavis added a comment.


  Can you post a picture of what this change is supposed to do? I see that you 
are hardcoding a color here. Have you tested the change with Breeze Dark?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze
Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw updated this revision to Diff 61731.
mthw added a comment.


  Formatting

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22452?vs=61730=61731

BRANCH
  fix-firefox-tab-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22452

AFFECTED FILES
  src/gtk320/apps/_firefox.scss

To: mthw, #vdg, #breeze
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw updated this revision to Diff 61730.
mthw added a comment.


  Fixed duplicate.

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22452?vs=61729=61730

BRANCH
  fix-firefox-tab-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22452

AFFECTED FILES
  src/gtk320/apps/_firefox.scss

To: mthw, #vdg, #breeze
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw updated this revision to Diff 61729.
mthw added a comment.


  Separate file and avoid hard-conding color.

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22452?vs=61728=61729

BRANCH
  fix-firefox-tab-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22452

AFFECTED FILES
  src/gtk320/apps/_firefox.scss
  src/gtk320/widgets/_menus.scss

To: mthw, #vdg, #breeze
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Vlad Zagorodniy]

zzag added a comment.


  I'm not a Breeze GTK maintainer or developer, but perhaps you need to create 
separate folder for application specific styles, e.g.
  
src/XXX/apps
  
  and put Firefox styles in a corresponding file, e.g.
  
src/XXX/apps/_firefox.scss

INLINE COMMENTS

> _menus.scss:258
> +#MozillaGtkWidget .menubar {
> +color: #eff0f1;
> +background-color: #475057; }

It'd be better not to hard code the color.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mthw requested review of this revision.

REVISION SUMMARY
  Currently labels on tabs in firefox that are not selected are hard to read 
(black text on dark background). This fixes it.

TEST PLAN
  Labels in Firefox are easy to read on all tabs. No other visual changes.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  fix-firefox-tab-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22452

AFFECTED FILES
  src/gtk320/widgets/_menus.scss

To: mthw
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

[Yunhe Guo]

guoyunhe updated this revision to Diff 61727.
guoyunhe added a comment.


  Enable smoothing for POTD wallpaper

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22451?vs=61726=61727

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22451

AFFECTED FILES
  dataengines/potd/unsplashprovider.cpp
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22451

AFFECTED FILES
  dataengines/potd/unsplashprovider.cpp

To: guoyunhe
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart