D18860: Add comment / description to the translations kcm

bshah added a comment. bump REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D22457: Make it possible to show the QR of a network connection

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Much simple! Thanks. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D22457 To: apol, #plasma, jgrulich Cc: broulik,

D22457: Make it possible to show the QR of a network connection

apol updated this revision to Diff 61885. apol added a comment. Pass different data as function arguments as suggested REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22457?vs=61836=61885 BRANCH master REVISION DETAIL

D22333: Move Solid::Device::listFromQuery calls to a separate thread

apol added a comment. Things we could do right now, without a super big refactoring: On a solid level: - Maybe a useful intermediate change would be to add API in Solid to move devices between threads. - Alternatively we could consider making sure backends stick to one specific

D22333: Move Solid::Device::listFromQuery calls to a separate thread

davidedmundson added a comment. Kinda, you're summary missing a key part. (the commit description is a bit poor) This patch does the following: - It does the search in the other thread. That creates and iterates every possible device. This is expensive as there are lots of

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 61877. guoyunhe added a comment. Better naming REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=61876=61877 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED FILES

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 61876. guoyunhe added a comment. Use constructor parameter to pass collection ID REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=61873=61876 BRANCH master REVISION DETAIL

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 61873. guoyunhe added a comment. Remove KIO linking REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=61872=61873 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED FILES

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 61872. guoyunhe added a comment. Solve linking issue REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=61868=61872 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED FILES

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

davidedmundson added a comment. Off. A login manager does not know what session you will be using. REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack, #vdg, #plasma, filipf, ngraham Cc:

D22494: Attempt to support different collections of Unsplash

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Here are some linking issues beyond my knowledge of C++ and CMake. Any suggestions? REPOSITORY R114 Plasma Addons BRANCH

D12916: Panel should not stop auto-hiding if a window wants attention

ngraham accepted this revision. ngraham added a subscriber: hein. ngraham added a comment. This revision is now accepted and ready to land. @hein? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12916 To: michaelmoon, ngraham Cc: hein, ngraham,

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

ngraham accepted this revision. ngraham added a comment. All right, let's try having it on by default for now and see if we hate it during the time before 5.17 branches. If so, we can always turn it off before then. #Plasma folks? REPOSITORY

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

cblack added a comment. Doesn't really matter to me ¯\_(ツ)_/¯ If other people want it off by default, I'll update the default theme.conf REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack,

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

ngraham added inline comments. INLINE COMMENTS > theme.conf.cmake:2 > [General] > +showlogo=shown > +logo=${KDE_INSTALL_FULL_DATADIR}/sddm/themes/breeze/default-logo.svg I thought this was going to be off by default for now? REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot

D22493: [Notifications] Move history items' icons over to the left a bit

ngraham created this revision. ngraham added reviewers: broulik, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Move the expired history items' icons over a bit so there isn't such an icon soup

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 67 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/67/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 16 Jul 2019 15:28:16 + Build duration: 2 min 34 sec and counting CONSOLE OUTPUT

D22491: implement parts of the bug field api endpoint

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY excessively unnecessary properties are not mapped currently as the only use we have for this

D22492: pull platforms/distributions dynamically out of the bugzilla api

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this ensures that all known platforms are actually in the comobox and reduces the amount of string

D22429: Make "Updates Available" notification persistent but low priority

felixernst added a comment. How about only making security update notifications persistent? There is no real harm in missing non-security updates in my opinion. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D22429 To: ngraham, apol,

Re: how about a developer KCM

On 7/16/19 8:32 AM, David Edmundson wrote: However, I fear it will end up becoming some sort of hidden plasma-tweaks, where we dump general aesthetic/behaviour settings in here which we think are too niche for the main UI. I don't want that to happen. Strongly agreed. Nate

Re: how about a developer KCM

I have one hidden KCM already. It was requested I make the super awesome qtquicksettings module hidden. It uses a little hack to make it findable in krunner, but not listed in system settings by parenting to a group, then hiding that group. I have no objections to things that are only useful to

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#494852 , @anthonyfieroni wrote: > https://phabricator.kde.org/source/solid/browse/master/src/solid/devices/frontend/devicemanager.cpp$301 > @bruns, It's backend per thread Yes, you are correct, so

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61859. cblack added a comment. Remove sourceSize.width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61825=61859 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

Re: how about a developer KCM

No objections, sounds like a good idea to me. I would even say it should be something that gets built when you compile Plasma from source, and in this case, you just automatically get it. That way regular users will never see it, and developers always will, with no configuration or secret

how about a developer KCM

Kai keeps asking where to expose some of the "hidden" config options in Drkonqi and I keep not having a good answer. How about we make a developer-only KCM where we can have any amount of silly configuration options that we would generally not know how to expose to the user or don't want the user

D22429: Make "Updates Available" notification persistent but low priority

ngraham added a comment. In D22429#496180 , @broulik wrote: > > That's kind of the point though. The user should be seeing these notifications and having to explicitly acknowledge them in some way; > > It wasn't nearly as annoying if a kded

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

davidedmundson added inline comments. INLINE COMMENTS > filipf wrote in Main.qml:421 > try implicitWidth to avoid binding loop Just remove sourceSize.width We dont define a width. REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22485: wrap the details example label+spacer in a container widget

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this way we can control both their visibility in a single call. with the previous code we'd only set the label as hidden and leave

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

filipf accepted this revision as: filipf. filipf added a comment. This revision is now accepted and ready to land. As far as I'm concerned the patch is landable; I really like that it's developed into a more generic placeholder rather than one just for distro logos. Nice work @cblack, make

D12916: Panel should not stop auto-hiding if a window wants attention

davidedmundson resigned from this revision. davidedmundson added a comment. No objection from me. I'll wait a few days in case Eike has comments, but from my POV, ship it REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12916 To: michaelmoon Cc: ngraham,

[frameworks-knotifications] [Bug 409854] Remove progress bar on each note, which indicates time left for fade out

https://bugs.kde.org/show_bug.cgi?id=409854 Postix changed: What|Removed |Added Assignee|plasma-devel@kde.org|kdelibs-b...@kde.org CC|

[kwrited] [Bug 409854] New: Remove progress bar on each note, which indicates time left for fade out

https://bugs.kde.org/show_bug.cgi?id=409854 Bug ID: 409854 Summary: Remove progress bar on each note, which indicates time left for fade out Product: kwrited Version: 5.16.2 Platform: Other OS: Linux

D22429: Make "Updates Available" notification persistent but low priority

broulik added a comment. > That's kind of the point though. The user should be seeing these notifications and having to explicitly acknowledge them in some way; It wasn't nearly as annoying if a kded module was responsible for it and not the applet, so it wouldn't show up every single

D22482: WIP: Show file dialog in directory mode when only directory is requested

jgrulich added a comment. If this is meant to be used by Firefox, then it won't work either, even when you use GTK_USE_PORTAL=1. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D22482 To: volkov, apol, jgrulich Cc: plasma-devel,

D22482: WIP: Show file dialog in directory mode when only directory is requested

volkov added a comment. This is for non-sandboxed applications that want to use KDE file dialog. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D22482 To: volkov, apol, jgrulich Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D12916: Panel should not stop auto-hiding if a window wants attention

michaelmoon updated this revision to Diff 61838. michaelmoon added a comment. Altered patch to apply against plasma-desktop:b2ce4bd (current git master) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22457: Make it possible to show the QR of a network connection

jgrulich added inline comments. INLINE COMMENTS > handler.cpp:170 > +{ > +NetworkManager::AccessPoint::Ptr ap; > +NetworkManager::WirelessDevice::Ptr wifiDev; I actually thought that instead of all this logic, where you search for wireless device, AP and then to get the security type,