[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

2019-07-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=377357 --- Comment #5 from Nate Graham --- ^^ Yes, why? If this is for energy savings, can you quantify the actual savings? My sense is that keyboard backlights are very small users of energy--but I could be wrong! However I'd like to see some data if energy

D22363: Remove cursor theme option

2019-07-19 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:119 > +ActionReply reply = ActionReply::HelperErrorReply(); > +QSharedPointer sddmConfig = > openConfig(args[QStringLiteral("kde_settings.conf")].toString()); > +QSharedPointer sddmOldConfig = >

D22572: Remove scaling of iconsize unit for isMobile

2019-07-19 Thread Camilo Higuita
camiloh created this revision. camiloh added a reviewer: VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY On Android icons using the iconSizes units look to big for the intended size, this changed has

D22176: Rework system tray settings

2019-07-19 Thread Nathaniel Graham
ngraham added a comment. In D22176#489327 , @ngraham wrote: > The generally accepted way to do this is to use alternating background colors. The old table view got this automatically, however this patch ports away from it since it's QQC1 only.

D22363: Remove cursor theme option

2019-07-19 Thread Filip Fila
filipf updated this revision to Diff 62075. filipf added a comment. fix one things overlooked when manually fixing up the rebase REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22363?vs=62074=62075 BRANCH remove-cursor-theme-option

D22191: Implement syncing of theme preferences between SDDM and Plasma

2019-07-19 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R123:f9e753551cdd: Implement syncing of theme preferences between SDDM and Plasma (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D22363: Remove cursor theme option

2019-07-19 Thread Filip Fila
filipf updated this revision to Diff 62074. filipf added a comment. rebase on master REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22363?vs=61940=62074 BRANCH remove-cursor-theme-option (branched from master) REVISION DETAIL

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

2019-07-19 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=377357 --- Comment #4 from Kai Uwe Broulik --- But why? -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

2019-07-19 Thread Jan Przybylak
https://bugs.kde.org/show_bug.cgi?id=377357 --- Comment #3 from Jan Przybylak --- Yes, that does work. However, I think this request if about the keyboard backlight turning off independently of the screen after a much shorter time. -- You are receiving this mail because: You are the assignee

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

2019-07-19 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=377357 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #2 from

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

2019-07-19 Thread Jan Przybylak
https://bugs.kde.org/show_bug.cgi?id=377357 Jan Przybylak changed: What|Removed |Added Platform|Mint (Ubuntu based) |unspecified -- You are receiving this mail

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

2019-07-19 Thread Jan Przybylak
https://bugs.kde.org/show_bug.cgi?id=377357 Jan Przybylak changed: What|Removed |Added CC||jplx...@gmail.com --- Comment #1 from Jan

D21667: Optionally display threads as if they were processes

2019-07-19 Thread Anthony Fieroni
anthonyfieroni added a comment. Use spaces instead of tabs. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D21667 To: topimiettinen Cc: anthonyfieroni, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D21667: Optionally display threads as if they were processes

2019-07-19 Thread Topi Miettinen
topimiettinen added a comment. @davidedmundson If you are OK with the idea, could you please review this? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D21667 To: topimiettinen Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

2019-07-19 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: mart, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, `SwipeListItem` isn't as convergent as it could be. It always uses a very

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-19 Thread David Redondo
davidre added a comment. How can we move this forward? Are there things I overlooked? Is it sill crashing sometimes? Code comments? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma, davidedmundson Cc: davidedmundson, msdobrescu,

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-19 Thread Gleb Popov
arrowd added a comment. In D22525#497556 , @cfeck wrote: > Oh, if the latter syntax also works, then you are right. Not sure what you mean by "also works". Current code checks if the URL ends with `:x:y` and turns it into `?line=x=y`.

D22543: [LNF KCM] make it possible to close the preview

2019-07-19 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d88f6c0c89e2: [LNF KCM] make it possible to close the preview (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22543?vs=62012=62059

qt4 integration

2019-07-19 Thread Harald Sitter
Hola, Way back when we wanted to have sni-qt and breeze-qt4 installed by default alongside Plasma 5.x so that Qt4 applications would neatly integrate. Do we still want this given the advanced legacy of Qt4? Or can we tell distros to no longer include these by default and have the user get a

Re: how about a developer KCM

2019-07-19 Thread Harald Sitter
On Tue, Jul 16, 2019 at 4:32 PM David Edmundson wrote: > > I have one hidden KCM already. > > It was requested I make the super awesome qtquicksettings module hidden. > It uses a little hack to make it findable in krunner, but not listed > in system settings by parenting to a group, then hiding

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-07-19 Thread Björn Feber
GB_2 updated this revision to Diff 62050. GB_2 added a comment. Make sure Apply button gets enabled when selecting a theme for the first time REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=62043=62050 BRANCH arcpatch-D20549 REVISION

D22553: guard against plasmashell being properly dead and not showing the SNI

2019-07-19 Thread Harald Sitter
sitter added a comment. I suspect we'll also want `bool StatusNotifier::notificationServiceRegistered` further down changed? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D22553 To: sitter, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh,

D22553: guard against plasmashell being properly dead and not showing the SNI

2019-07-19 Thread David Edmundson
davidedmundson added a comment. Concept is fine, but you probably want to watch whether the SNI Watcher has an available host. INLINE COMMENTS > statusnotifier.cpp:100 > + > +auto watcher = new > QDBusServiceWatcher(QStringLiteral("org.freedesktop.Notifications"), > +

D22553: guard against plasmashell being properly dead and not showing the SNI

2019-07-19 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY when plasmashell is particularly dead and not even able to restart, the SNI host may still be

D22552: Avoid attempting to auto-mount a device when it is alread mounted

2019-07-19 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a46bff297524: Avoid attempting to auto-mount a device when it is alread mounted (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-07-19 Thread Björn Feber
GB_2 updated this revision to Diff 62043. GB_2 added a comment. Move progress bar above GHNS button REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=61991=62043 BRANCH arcpatch-D20549 REVISION DETAIL https://phabricator.kde.org/D20549

D22552: Avoid attempting to auto-mount a device when it is alread mounted

2019-07-19 Thread Méven Car
meven created this revision. meven added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 409915 FIXED-IN: 5.17 REPOSITORY R119 Plasma Desktop BRANCH master REVISION

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 68 - Still Failing!

2019-07-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/68/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 19 Jul 2019 09:26:40 + Build duration: 3 min 46 sec and counting CONSOLE OUTPUT

D22492: pull platforms/distributions dynamically out of the bugzilla api

2019-07-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R871:bc83d5ba953b: pull platforms/distributions dynamically out of the bugzilla api (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D22491: implement parts of the bug field api endpoint

2019-07-19 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R871:a8f050c6fc5a: implement parts of the bug field api endpoint (authored by sitter). CHANGED PRIOR TO COMMIT

D22485: wrap the details example label+spacer in a container widget

2019-07-19 Thread Harald Sitter
sitter updated this revision to Diff 62037. sitter added a comment. reduce noise I think REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22485?vs=61845=62037 BRANCH spacer REVISION DETAIL https://phabricator.kde.org/D22485 AFFECTED FILES

D22485: wrap the details example label+spacer in a container widget

2019-07-19 Thread Harald Sitter
sitter updated this revision to Diff 62038. sitter added a comment. reduce noise no2 REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22485?vs=62037=62038 BRANCH spacer REVISION DETAIL https://phabricator.kde.org/D22485 AFFECTED FILES

D22549: Add Prison as RUNTIME dependency

2019-07-19 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R116:920a530e1a86: Add Prison as RUNTIME dependency (authored by broulik). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22549?vs=62030=62034

D22550: Make Prison optional

2019-07-19 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R116:00c78ced6c03: Make Prison optional (authored by broulik). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22550?vs=62032=62035 REVISION

D22035: Port FolderView to ContainmentLayoutManager plugin

2019-07-19 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ConfigOverlay.qml:171 > why do we do it explicitly here, but backed by a timer for movement? This is after being rotated, when changing rotation of an item the same doesn't get invoked automatically REPOSITORY R119 Plasma

D22535: Make kimpanel a system tray applet

2019-07-19 Thread Yunhe Guo
guoyunhe added a comment. In D22535#497694 , @apol wrote: > There's already several things in the system tray with a keyboard icon (all different keyboards! xD) > Maybe we could make something a bit more recognizable? 1.

D22550: Make Prison optional

2019-07-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, jgrulich, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. broulik requested review of this revision. REVISION SUMMARY Don't break the entire network

D22540: Port ResultDelegate to use PlasmaComponents 3.0

2019-07-19 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in ResultDelegate.qml:231 > QQC2 tooltip stuff doesn't really work for KRunner because they're not > separate windows :( > > Also, don't use `ToolTip` attached property as it cannot respect the theme's > delay settings >

D22549: Add Prison as RUNTIME dependency

2019-07-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. broulik requested review of this revision. TEST PLAN Ran `cmake`, had it tell me it's a runtime dep

D22540: Port ResultDelegate to use PlasmaComponents 3.0

2019-07-19 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ResultDelegate.qml:138 > > -width: resultDelegate.categoryWidth - units.largeSpacing > +// fake pressed look > +highlighted: ListView.isCurrentItem Move that comment to where it belongs > ResultDelegate.qml:142 > + > +