D22738: Remove some uses on QDesktopWidget

apol updated this revision to Diff 62582. apol added a comment. addressed comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22738?vs=62534=62582 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22738 AFFECTED FILES

D22738: Remove some uses on QDesktopWidget

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in foldermodel.cpp:1640 > KNewFileMenu.cpp in the constructor > 1148 d->m_parentWidget = qobject_cast(parent); > > without a transient parent we probably have focus issues? It doesn't

D22480: Don't use KPluginInfo if we can use KPluginMetaData

This revision was automatically updated to reflect the committed changes. Closed by commit R120:44114500acd3: Dont use KPluginInfo if we can use KPluginMetaData (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22480?vs=61820=62581

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

filipf added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:46 > Do we need a Layout.fillWidth here? This happens without` Layout.fillWidth` F7097863: image.png REPOSITORY R119 Plasma Desktop BRANCH no-more-warning-message

D22757: Guard against missing xrandr extension

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Found from a user doing something wrong with their wayland session, but it

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:46 > > -FontWidget { > -id: generalFontWidget > -label: i18n("General:") > -category:

D22753: [taskmanager] Simplifiy one of the two PID lookups

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KwindowInfo already has the PID, which we use in another case where PID is

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

filipf added a subscriber: broulik. filipf added a comment. Something @broulik proposed is to have the inline message spawn right below the separator that precedes the antialiasing settings instead of at the very top. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

filipf updated this revision to Diff 62575. filipf added a comment. rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22752?vs=62574=62575 BRANCH no-more-warning-message (branched from master) REVISION DETAIL

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch gets rid of the popup message spawned when applying changes in the Fonts KCM and instead places the very same information

D22738: Remove some uses on QDesktopWidget

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. concept ++ INLINE COMMENTS > pagermodel.cpp:120 > +QObject::connect(qGuiApp, ::screenAdded, q, [q](QScreen* > screen) { > +QObject::connect(screen,

D22494: Attempt to support different collections of Unsplash

ngraham added a comment. Tried it out. My reaction is: "Wow, this is really nice." One UI improvement I could see is to allow multi-selection of categories, so for example you could see images from all the nature-related categories but not Car or Sports. The way I'd envision this

D22748: whitelist the "turn off screen" shortcut on the lock screen

mblumenstingl added a comment. In D22748#502337 , @mblumenstingl wrote: > I did some more digging and I now believe that I'm facing a problem that's related to me running wayland. > >

D22748: whitelist the "turn off screen" shortcut on the lock screen

mblumenstingl added a comment. I did some more digging and I now believe that I'm facing a problem that's related to me running wayland. https://github.com/KDE/kwindowsystem/blob/05f5379c24a59e1ded2f12a6fd09946617abd0ac/src/kkeyserver.h#L29 KKeyServer has a compile-time switch for

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added a comment. In D22261#502044 , @broulik wrote: > Just checking, are you still up for making this kscreenlocker change? Given the heatwave right now I would have loved to be able to turn off my screens on the lock screen

D22748: whitelist the "turn off screen" shortcut on the lock screen

mblumenstingl created this revision. mblumenstingl added a reviewer: broulik. mblumenstingl added a project: Plasma. mblumenstingl requested review of this revision. REVISION SUMMARY This is a follow-up to D22261 unfortunately the test plan is not

D22494: Attempt to support different collections of Unsplash

ngraham added a comment. Oh sweet! I guess I should actually test it out. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22494 To: guoyunhe, #plasma Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22494: Attempt to support different collections of Unsplash

guoyunhe added a comment. In D22494#502187 , @ngraham wrote: > Nice! > > How about adding an "All" entry for the combo box which would show you wallpapers from any category? Is that possible? I already added "All" option. REPOSITORY

D22691: Remove the share dataengine.

aacid closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22691 To: aacid, davidedmundson Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D19676: Fix out of bounds access error in SystemLoadViewer.qml

aacid added a comment. This is unlandable in KDE at this point because (say our sysadmins) "the nameservers for the domain estada.ch are highly unreliable and fail fairly often." and our git is very picky and doesn't like that. I don't particularly care about this piece of code, but if

D20908: Redesign QML applet configuration windows

This revision was automatically updated to reflect the committed changes. Closed by commit R119:34ea1e73680f: Redesign QML applet configuration windows (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=62558=62562 REVISION

D22728: Provide a link to KInfoCenter

ngraham added a comment. And here's the patch for the alternative approach: https://phabricator.kde.org/D22742 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22728 To: ngraham, #plasma, #vdg Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n,

D22742: Show about distro KCM in System Settings' System Administration category

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is an alternative to D22728 . It makes the System

D20908: Redesign QML applet configuration windows

filipf updated this revision to Diff 62558. filipf added a comment. don't remove the other file :) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=62557=62558 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECTED

D20908: Redesign QML applet configuration windows

filipf updated this revision to Diff 62557. filipf added a comment. do not update the highlight effect (yet) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60584=62557 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. The companion patches have landed; this can go in now! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham, abetts Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh,

D22494: Attempt to support different collections of Unsplash

ngraham added a comment. Nice! How about adding an "All" entry for the combo box which would show you wallpapers from any category? Is that possible? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22494 To: guoyunhe, #plasma Cc: ngraham, filipf,

D22494: Attempt to support different collections of Unsplash

guoyunhe added a comment. Now it is working again! You will have a Category combobox to choose photo collections from Unsplash F7096418: image.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22494 To: guoyunhe,

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62551. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62550=62551 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62550. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62549=62550 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62549. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62547=62549 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62547. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62546=62547 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62546. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62541=62546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

marten created this revision. marten added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. marten requested review of this revision. REVISION SUMMARY Bug https://bugs.kde.org/show_bug.cgi?id=410190 describes the inconsistent virtual desktop

D22728: Provide a link to KInfoCenter

cfeck added a comment. +1 for putting it in the Help menu. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22728 To: ngraham, #plasma, #vdg Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22535: Make kimpanel a system tray applet

ngraham added a comment. +1,000 for having you guys become the KDE "Input Method dream team". FWIW I am super supportive of T11054 and sincerely hope it gets chosen. It's critically important. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22480: Don't use KPluginInfo if we can use KPluginMetaData

apol added a comment. ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22480 To: apol, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D22735: Introduce ResultsModel with better data processing and filtering

apol added a comment. LGTM overall INLINE COMMENTS > ResultsView.qml:94 > > -if (runAutomatically) { > -runCurrentIndex(); > +function reset() { > +listView.currentIndex = 0; Call it `resetView()`? Otherwise it seems like you're resetting the model

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62541. guoyunhe added a comment. Fix crashing REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62539=62541 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED FILES

D22735: Introduce ResultsModel with better data processing and filtering

broulik updated this revision to Diff 62540. broulik edited the summary of this revision. broulik added a comment. - Emit dataChanged before inserting and only update the to be signalled range - Add some docs to make future me happy - Fix current index behavior with mouse and keyboard

D22494: Attempt to support different collections of Unsplash

guoyunhe added a comment. The new change try to add a new ComboBox "Category" and pass the value to PODT data engine. This also introduced a new configuration option. But now it makes plasmashell crash without useful error output. REPOSITORY R114 Plasma Addons REVISION DETAIL

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62539. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62538=62539 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62538. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=61901=62538 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED

D22648: make handle follow arbitrary height of the drawer

This revision was automatically updated to reflect the committed changes. Closed by commit R169:518444e4191a: make handle follow arbitrary height of the drawer (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22648?vs=62345=62535

D22738: Remove some uses on QDesktopWidget

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Adds an unnecessary dependency to QtWidgets and forces some round-trips to the X server that we don't

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 93 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/93/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 25 Jul 2019 12:11:31 + Build duration: 7 min 37 sec and counting JUnit Tests Name: (root) Failed:

D22514: Show if KRunner is still searching for more things

apol planned changes to this revision. apol added a comment. In D22514#502042 , @aspotashev wrote: > This would fix https://bugs.kde.org/show_bug.cgi?id=409959 , right? Yes, please review D22540 so I

D22535: Make kimpanel a system tray applet

gpark added a comment. Here's a video demonstrating the GSoC project's results: F7095313: vokoscreen-2019-07-25_20-29-54.mkv REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22535 To: guoyunhe, ngraham, #vdg,

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 92 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/92/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 25 Jul 2019 11:29:11 + Build duration: 1 min 33 sec and counting CONSOLE OUTPUT [...truncated 465

D22734: Support displaying emoticons in connection name and SSID

jgrulich abandoned this revision. jgrulich added a comment. In D22734#502034 , @broulik wrote: > -1 to dragging in KEmoticons for that. > Aren't they just unicode Emojis which we can render just fine elsewhere. You are right, I can

D22261: Add a global shortcut action to turn off the screen

broulik added a comment. Just checking, are you still up for making this kscreenlocker change? Given the heatwave right now I would have loved to be able to turn off my screens on the lock screen explicitly :D REPOSITORY R122 Powerdevil REVISION DETAIL

D22514: Show if KRunner is still searching for more things

aspotashev added a comment. This would fix https://bugs.kde.org/show_bug.cgi?id=409959 , right? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22514 To: apol Cc: aspotashev, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D22735: Introduce ResultsModel with better data processing and filtering

davidedmundson added inline comments. INLINE COMMENTS > resultsmodel.cpp:154 > + > +class HideRootLevelProxyModel : public QSortFilterProxyModel > +{ Future Kai is going to appreciate some docs on what each class does. > runnerresultsmodel.cpp:146-148 > +// Now that the source data has

D22734: Support displaying emoticons in connection name and SSID

broulik added a comment. -1 to dragging in KEmoticons for that. Aren't they just unicode Emojis which we can render just fine elsewhere. INLINE COMMENTS > DetailsText.qml:84 > text: "" + details[index*2] + ": " > +textFormat: Text.StyledText >

D18860: Add comment / description to the translations kcm

bshah accepted this revision as: bshah. bshah added a comment. This revision is now accepted and ready to land. I'd say if no-one else objects, feel free to submit this revision now. :-) We can always revise it since this is not going in stable branch. REPOSITORY R120 Plasma Workspace

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea32a7611227: [Image Wallpaper Slideshow] Allow setting of different sorting orders (authored by davidre). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22121?vs=62529=62530#toc REPOSITORY

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 62529. davidre added a comment. Last touches - remove QDebug - don't restore image if we are in random mode - if we have seen all images generate a new random order REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22514: Show if KRunner is still searching for more things

broulik added a comment. Can you delay showing the busy indicator a bit? e.g. only show if there haven't been any new results for 500ms or so, to avoid that thing constantly flashing up. Perhaps easiest would be something like Timer { id: delayBusyIndicatorTimer

D22735: Introduce ResultsModel with better data processing and filtering

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a new `Milou.ResultsModel` for runner results which tries very hard to avoid model

D22734: Support displaying emoticons in connection name and SSIDBUG: 408550

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D22734 AFFECTED FILES

D22535: Make kimpanel a system tray applet

guoyunhe added a subscriber: xuetianweng. guoyunhe added a comment. Thanks @hein ! I will check the GSoC project and see if I can continue with that. I see the original author of Kimpanel is @xuetianweng . Let's listen to his opinion. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

This revision was automatically updated to reflect the committed changes. Closed by commit R134:29fb6ce9e369: Add icons to Categories, Installed, and Sources globaldrawer entries (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D22535: Make kimpanel a system tray applet

hein added a subscriber: gpark. hein added a comment. To catch this up to the GSoC status: https://medium.com/@mujjingun_23509/google-summer-of-code-porting-keyboard-kcm-to-qt-quick-part-2-30c115771722

D22535: Make kimpanel a system tray applet

hein added subscribers: mart, hein. hein added a comment. The configuration should be in System Settings, not in this applet, as they're system-global and override keyboard layout settings. The 2018 GSoC work started to implement this and got far, and also made kimpanel replace the

D22728: Provide a link to KInfoCenter

mthw added a comment. I personally like the alternative aproach, as it is what I had in mind when submitting the bug report. > - There isn't really a 100% appropriate parent category to put it in It could be the last item in the Hardware section. Also, IIRC Gnome does it like this

D22728: Provide a link to KInfoCenter

mmustac added a comment. In D22728#501819 , @ngraham wrote: > An alternative approach would be to simply show KCM itself in System Settings by adding `X-KDE-System-Settings-Parent-Category=` to the `about-dostro.desktop` file that KInfoCenter

D22728: Provide a link to KInfoCenter

broulik added a comment. +1 to the idea INLINE COMMENTS > SettingsBase.cpp:151 > +systemInformationAction = actionCollection()->addAction( > QStringLiteral("help_about_system"), this, [] () { > +KRun::runCommand( QStringLiteral("kinfocenter"), nullptr ); > +} ); Can you do