D23018: [notifications] Remove unread counter, use icons instead

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Text inside a small circle has a lot of problems with fitting in there and being properly

D22960: Add handle icons

This revision was automatically updated to reflect the committed changes. Closed by commit R169:29dffaf4cd72: Add handle icons (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22960?vs=63155=63327 REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 72 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/72/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 08 Aug 2019 03:05:26 + Build duration: 3 min 5 sec and counting CONSOLE OUTPUT

D22866: [Kickoff] Always select previous category in Applications View when navigating backwards

hein accepted this revision. hein added a comment. Good idea! REPOSITORY R119 Plasma Desktop BRANCH kickoff-appview-remember-previous-category (branched from master) REVISION DETAIL https://phabricator.kde.org/D22866 To: akozlovskiy, #plasma, ngraham, hein Cc: plasma-devel,

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

hein added a comment. ... I'm not the author or maintainer of this code, but I had a look anyway :). @lisin, I agree with you that the sizing bug should be fixed in TabBar instead, in plasma-frameworks.git. It's very unorthodox to call a property change handler as a function, and it's

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham resigned from this revision. ngraham added a comment. Okay, sure. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin, #vdg Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. In D22468#508314 , @ngraham wrote: > In D22468#508290 , @romangg wrote: > > > I currently concentrate on libkscreen backend work and output duplication and have based other

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham added a comment. In D22468#508290 , @romangg wrote: > I currently concentrate on libkscreen backend work and output duplication and have based other patches on this rewrite here. So I only want to touch this diff again in case of

D22925: Fix POTD doesn't update

guoyunhe updated this revision to Diff 63301. guoyunhe added a comment. Add import REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22925?vs=63300=63301 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22925 AFFECTED FILES

D22925: Fix POTD doesn't update

guoyunhe updated this revision to Diff 63300. guoyunhe edited the summary of this revision. guoyunhe added a comment. Fix CacheProvider's cache validation function REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22925?vs=63061=63300 BRANCH master

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. In D22468#507819 , @ngraham wrote: > Thanks Roman! This is really excellent overall. A big improvement over the current one . Nevertheless I think we can make it even better and I have some UI review comments: > >

D22992: [KRDB] Fix wrong names in GTK colordef exports

This revision was automatically updated to reflect the committed changes. Closed by commit R119:87d9610e206f: [KRDB] Fix wrong names in GTK colordef exports (authored by cblack, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

kossebau added a comment. Only current user known is plasma-desktop, from R119:737b114c2fa5bf0b01951eeb2eef22ce7fcdcfa1 No other hits seen on internet No idea what is the most simple approach here, given KF

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

kossebau created this revision. kossebau added reviewers: mart, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fixcmakeconfigname REVISION DETAIL

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks very much for the patch! This fixes both issues for me and looks conceptually like an appropriate fix to me, but I'm not the original author or maintainer of this code as @hein

D23004: Wayland: manage outputs without id mapping

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Instead of having a separate mapping from KWayland ids to KScreen ids for output removal

D22992: [KRDB] Fix wrong names in GTK colordef exports

ngraham added a comment. Could you attach before-and-after pictures showing what was broken and how it's fixed now? That's very helpful with this kind of patch where you may be more of a subject matter expert than your reviewers. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22992: [KRDB] Fix wrong names in GTK colordef exports

cblack updated this revision to Diff 63277. cblack added a comment. Fix foreground color names REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22992?vs=63276=63277 BRANCH fix-colordef-names (branched from master) REVISION DETAIL

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 144 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/144/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 07 Aug 2019 12:19:17 + Build duration: 2 hr 15 min and counting CONSOLE OUTPUT

D22992: [KRDB] Fix wrong names in GTK colordef exports

cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The background color states of the button color variants were exporting to the wrong name.

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. good direction, unfortunately we can't remove the custom toolbutton contentitem yet, so for now let's keep the custom icon group INLINE COMMENTS > camiloh wrote in Action.qml:76 >

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 143 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/143/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 07 Aug 2019 09:44:23 + Build duration: 2 hr 34 min and counting CONSOLE OUTPUT

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

lisin added a comment. I also couldn't reproduce the gray overlay (which is caused by `tabBarSeparator` having a wrong size and taking the whole view - yesterday I could reproduce it but no more) that is shown in the comment 16 here: https://bugs.kde.org/show_bug.cgi?id=395390#c16 So it

D22925: Fix POTD doesn't update

guoyunhe added a comment. This is not working. Unsplash wallpapers still don't update daily. I need further debugging. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22925 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

lisin created this revision. lisin added reviewers: Plasma, hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lisin requested review of this revision. REVISION SUMMARY This fixes the incorrect initial positioning of the tab bar (first tab is placed out of

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

lisin added a comment. Line `onHeightChanged: onWidthChanged()` fixes BUG: 395390 I'm not sure if this is the best solution. For some reason, `plasmacomponents/qml/TabBar.qml` lacks an `onHeightChanged()` function but it has `onWidthChanged()` that seems to do what needs to happen here.

Issues with Jenkins Builds

Hi all, Recently we were affected by a regression within Jenkins, the effect of which meant that in some circumstances builds would not be triggered when new commits were introduced. In addition, the views showing the list of all builds would also not show the last successfully completed build

D22596: [MPRIS Data Engine] Ignore non-standards compliant players

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8eec2cfd36c4: [MPRIS Data Engine] Ignore non-standards compliant players (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22596: [MPRIS Data Engine] Ignore non-standards compliant players

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Code looks good, if you tested successfully with vlc this can IMO go in REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22596 To: broulik, #plasma, fvogt

D22814: Remove colon (:) prefix when looking up dictionary word

wbauer added a comment. Thank you! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22814 To: broulik, #plasma, mart, kossebau, davidedmundson Cc: wbauer, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22970: Wayland: config update code cleanup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:f99858504d93: Wayland: config update code cleanup (authored by romangg). REPOSITORY R110 KScreen Library CHANGES

D22966: Wayland: backend code cleanup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:479d07200861: Wayland: backend code cleanup (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE

D22814: Remove colon (:) prefix when looking up dictionary word

broulik added a comment. @wbauer done: https://cgit.kde.org/kdeplasma-addons.git/commit/?h=Plasma/5.12=eac0dbd5f1c0f1ba54bd9c9682da096d9c78db2a REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22814 To: broulik, #plasma, mart, kossebau, davidedmundson Cc:

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

broulik added a comment. The vertical text alignment is quite off. F7174857: Screenshot_20190807_085002.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22977 To: GB_2, #plasma, #vdg, ngraham Cc: broulik, ngraham,