D22976: Fix compilation

usta added a comment. ben mentioned that this also needs to be cherrypicked to stable branch too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22976 To: ngraham, #plasma, aacid Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

D23063: [lockscreen] Fit album art to defined geometry

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D23063#509587 , @ndavis wrote: > +1, seems like a good idea. > > The small image looks weird too, but I suppose it's better to

D23060: [Notifications] Hide popups when expanded

ngraham added a comment. This isn't necessary when you have the pop-ups' position customized so they wouldn't actually overlap with the system tray. I wouldn't fade them out in that case. For the default case, this works, but it would definitely be nice if the pop-ups could hide (or

D23063: [lockscreen] Fit album art to defined geometry

ndavis added a comment. +1, seems like a good idea. The small image looks weird too, but I suppose it's better to present weird images in their true form than to make them look even weirder by stretching them. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23063: [lockscreen] Fit album art to defined geometry

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY No one likes stretched images. REPOSITORY R120 Plasma Workspace BRANCH dont-stretch-my-album-art (branched from master)

D14764: Simplify XRandR::outputChanged

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:cc8f88d93821: Simplify XRandR::outputChanged (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE

D23056: RFC: Don't auto-restart KRunner when crashed

gladhorn added a comment. I like the idea, I have krunner crashing every so often, but usually it manages to restart, so I never look into that. Getting a backtrace would make fixing it much more likely. REPOSITORY R120 Plasma Workspace REVISION DETAIL

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Still Failing!

Hi folks, Could someone please look into the below QMutex include problem within plasma-workspace? Thanks, Ben -- Forwarded message - From: CI System Date: Sat, Aug 10, 2019 at 8:18 AM Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build #

D23060: [Notifications] Hide popups when expanded

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Unfortunately there is no real way for us to tell when the System Tray popup is open but we can

D23049: Add Kirigami ListSectionHeader component

ngraham added a comment.  REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart, ngraham Cc: ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23057: Use new Kirigami ListSectionHeader component on Updates page

ngraham updated this revision to Diff 63445. ngraham added a comment. Also port the Sources page headers REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23057?vs=63439=63445 BRANCH use-new-kirigami-section-header (branched from master)

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 148 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/148/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 09 Aug 2019 18:39:35 + Build duration: 11 min and counting CONSOLE OUTPUT

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63444. GB_2 added a comment. Add example code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63443=63444 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63443. GB_2 added a comment. Update `customItems` description REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63442=63443 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. In D23049#509439 , @ngraham wrote: > Idea: add a `RowLayout` inside the `contentItem` and put the `Heading` in there, then expose a property called like "CustomItems" that allows the implementation to add additional items

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63442. GB_2 added a comment. Add `customItems` list REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63432=63442 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D22535: Make kimpanel a system tray applet

guoyunhe added a comment. @gpark I am trying to pull all your changes into this patch. If I understand correctly, your work is in `new_keyboard_kcm` branch of repo https://cgit.kde.org/clones/plasma-desktop/gpark/gsoc-kcm-keyboard-revamp.git ? REPOSITORY R119 Plasma Desktop REVISION

D23058: Reduce visual strength of version numbers on Updates page

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch improves the visual hierarchy and scannability of the

D23057: Use new Kirigami ListSectionHeader component on Updates page

ngraham created this revision. ngraham added reviewers: Discover Software Store, VDG, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This allows all the section headers to always have the same look and

D23049: Add Kirigami ListSectionHeader component

ngraham added a comment. Idea: add a `RowLayout` inside the `contentItem` and put the `Heading` in there, then expose a property called like "CustomItems" that allows the implementation to add additional items to that `RowLayout`. This would let us port Discover's sources page headers,

D23056: RFC: Don't auto-restart KRunner when crashed

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is automatically started when invoked. TEST PLAN I don't remember anymore but David had

D23054: [Notifications] Use new Kirigami ListSectionHeader component in KCM's sources page

ngraham added a reviewer: broulik. ngraham added a subscriber: broulik. ngraham added a comment. (@broulik, I know you're not the biggest fan of this style, but once this gets in and makes it a Kirigami component, we can adjust it there as needed) REPOSITORY R119 Plasma Desktop BRANCH

D23054: [Notifications] Use new Kirigami ListSectionHeader component in KCM's sources page

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This allows all the section headers to always have the same look and feel and be adjusted

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This allows all the section headers to always have the same look and feel and be adjusted

D23049: Add Kirigami ListSectionHeader component

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. This revision is now accepted and ready to land. Thanks! We definitely need @mart's input on the right implementation of these details. But visually it looks great to me in System Settings (working on patches for the

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63432. GB_2 added a comment. Use Kirigami 2.10 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63430=63432 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

ngraham added a comment. The numbers need to match. I think you want 2.10 (the current version appears to be 2.9, but this QML versioning stuff is pretty confusing to me). REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart Cc:

D23049: Add Kirigami ListSectionHeader component

ognarb added a comment. It's a new version so probably 2.9 everywhere REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart Cc: ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol,

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. In D23049#509339 , @ognarb wrote: > Something is probably wrong with the version numbers. Yeah, I don't know which I should choose and why, I just copied it from the other list items. REPOSITORY R169 Kirigami

D23049: Add Kirigami ListSectionHeader component

ognarb added a comment. Something is probably wrong with the version numbers. INLINE COMMENTS > kirigamiplugin.cpp:131 > qmlRegisterType(componentUrl(QStringLiteral("BasicListItem.qml")), uri, > 2, 0, "BasicListItem"); > +

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63430. GB_2 added a comment. Rename to ListSectionHeader REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63429=63430 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

ngraham added a comment. In D23049#509309 , @GB_2 wrote: > In D23049#509301 , @ngraham wrote: > > > Maybe call it a `ListSectionHeader` or just `SectionHeader`? > > > I think just the word

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63429. GB_2 added a comment. Use correct background color REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63428=63429 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63428. GB_2 added a comment. Set `sectionDelegate` to `true` REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63426=63428 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

davidre added a comment. Should this set ` sectionDelegate: true` and not expose this to the outside? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart Cc: davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson,

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63426. GB_2 added a comment. Update copyright REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63425=63426 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

GB_2 added a comment. In D23049#509301 , @ngraham wrote: > Maybe call it a `ListSectionHeader` or just `SectionHeader`? I think just the word section is more accurate, because that's what the property that it will be used in is called

D23049: Add Kirigami ListSection component

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ListSection.qml:28 > coherent -> consistent I just copied it from the other list items :-) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg Cc: ngraham, #vdg, plasma-devel,

D23049: Add Kirigami ListSection component

ngraham added a comment. Maybe call it a `ListSectionHeader` or just `SectionHeader`? INLINE COMMENTS > ListSection.qml:2 > +/* > + * Copyright 2010 Marco Martin > + * You made this, so it's your copyright > ListSection.qml:28 > + * > + * It's intended to make all listviews look

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63425. GB_2 added a comment. Remove duplicate AbstractListItem REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63424=63425 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

GB_2 created this revision. GB_2 added reviewers: Kirigami, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds a standard ListSection component to make ListView sections look consistent. F7181620:

D22925: Fix Unsplash POTD not updating

This revision was automatically updated to reflect the committed changes. Closed by commit R114:2e0ddd4cb3d1: Fix Unsplash POTD not updating (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22925?vs=63301=63420

D22879: Rename "Look and Feel" KCM to "Global Theme"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5809c0384c02: Rename Look and Feel KCM to Global Theme (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22879?vs=63413=63414 REVISION

D22879: Rename "Look and Feel" KCM to "Global Theme"

ngraham added a comment. Thanks @mart! Since this will land in Plasma 5.17, there's plenty of time to change it on store.kde.org. I'll coordinate. REPOSITORY R119 Plasma Desktop BRANCH lnf-to-global (branched from master) REVISION DETAIL https://phabricator.kde.org/D22879 To:

D22879: Rename "Look and Feel" KCM to "Global Theme"

ngraham updated this revision to Diff 63413. ngraham marked an inline comment as done. ngraham added a comment. Lowercase it in a Comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22879?vs=62943=63413 BRANCH lnf-to-global (branched from

D22879: Rename "Look and Feel" KCM to "Global Theme"

GB_2 added inline comments. INLINE COMMENTS > metadata.desktop:2 > [Desktop Entry] > -Comment=Test Look and Feel package > +Comment=Test Global Theme package > Comment[ast]=Paquete d'aspeutu y sentir de prueba Lowercase "global theme". REPOSITORY R119 Plasma Desktop BRANCH lnf-to-global

D22879: Rename "Look and Feel" KCM to "Global Theme"

mart accepted this revision. mart added a comment. fine for me if this and the store are changed simultaneously, and *no* internal name is changed anywhere (folder names, plugin names and so on) REPOSITORY R119 Plasma Desktop BRANCH lnf-to-global (branched from master) REVISION DETAIL

D23044: [Notifications] Swing the bell when there is a new notification

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6e067d12d246: [Notifications] Swing the bell when there is a new notification (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23044: [Notifications] Swing the bell when there is a new notification

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OMG that's so cute!!! I kind of love it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23044 To: broulik, #plasma, #vdg, ngraham Cc: ngraham,

D23044: [Notifications] Swing the bell when there is a new notification

shubham added a comment. Personally I do not like info button to be swung like a bell, however VDG are the right people to decide this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23044 To: broulik, #plasma, #vdg Cc: shubham, plasma-devel, LeGast00n,

D23044: [Notifications] Swing the bell when there is a new notification

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When switching to "unread" state, animate the bell icon. It only animates for the

D23039: Make Kickoff restore favorites order when dragging an item to desktop

lisin updated this revision to Diff 63407. lisin added a comment. Sure, I've added the comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23039?vs=63398=63407 REVISION DETAIL https://phabricator.kde.org/D23039 AFFECTED FILES

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63404. GB_2 added a comment. Rebase REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63403=63404 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master)

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63403. GB_2 added a comment. Use Qt Labs Platform menu (need to wait until https://bugreports.qt.io/browse/QTBUG-77404 is fixed) REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63338=63403 BRANCH

D23043: Include xkb.h

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY I don't see why the header cannot be included. I guess this is some old legacy, this change

D23042: When implementing assignment, also implement copy ctor

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY /plasma-desktop/kcms/keyboard/xkb_rules.cpp: In static member function ‘static

D23039: Make Kickoff restore favorites order when dragging an item to desktop

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, nice. #plasma folks? INLINE COMMENTS > FavoritesView.qml:94 > + > +onDragLeave: { > +var source = kickoff.dragSource;

D22925: Fix Unsplash POTD not updating

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Got a new image now. LGTM. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22925 To: guoyunhe, #plasma, ngraham Cc: ngraham,

D22856: [Notifications] Enable do not disturb mode when screens are mirrored

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22856 To: broulik, #plasma, #vdg, dfaure, ngraham Cc: ngraham, plasma-devel,

D23039: Make Kickoff restore favorites order when dragging an item to desktop

lisin updated this revision to Diff 63398. lisin added a comment. Added `isChildOf(source, favoritesView)` which is probably needed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23039?vs=63397=63398 REVISION DETAIL

D23039: Make Kickoff restore favorites order when dragging an item to desktop

lisin added a comment. I was reluctant to introduce a new variable with such a broad scope (`kickoff.dragStartRow`) but using the `startRow` from `DropArea` would sometimes still mess up the order - the item would get the new value of `startRow` if the user moved the cursor back inside

D23039: Make Kickoff restore favorites order when dragging an item to desktop

lisin created this revision. lisin added reviewers: Plasma, ngraham, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lisin requested review of this revision. REVISION SUMMARY This fixes the undesired reordering of the favorites which could happen when dragging an