D12916: Panel should not stop auto-hiding if a window wants attention

2019-08-11 Thread Michael Moon
michaelmoon added a comment. I'd love to know as well.. While I've got my patches in my local patch set, others in the linked bug are just fighting with their panel every day. If there's a tracking bug for 5.16 or 5.17 release, perhaps we could add this to its dependencies? REPOSITORY

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Still Failing!

2019-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/2/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 12 Aug 2019 01:16:01 + Build duration: 14 sec and counting CONSOLE OUTPUT

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R115:faef1e8f152e: Allow to set maximum volume 100% (authored by kishoreg, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. Thanks for the vid. Also I feel betrayed now by my system. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23082 To: kishoreg, #plasma, drosca, ngraham, romangg Cc: romangg, ngraham,

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Nathaniel Graham
ngraham added a comment. In D23082#510628 , @romangg wrote: > When you're at it could you take a look at why hardware keys are not working above 100%? Shouldn't be handled with a separate patch though. Works for me FWIW: F7205124: Works

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Roman Gilg
romangg added a comment. When you're at it could you take a look at why hardware keys are not working above 100%? Shouldn't be handled with a separate patch though. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23082 To: kishoreg, #plasma,

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. I could see this being useful if your hardware had super loud speakers, or if you were deliberately trying to reduce the noisiness of your environment. REPOSITORY R115 Plasma

Unified git commit message guideline

2019-08-11 Thread Roman Gilg
For KWin we think about a message guideline because our current best practice that we got used to over time is just sometimes putting tags in square brackets at the beginning of the subject line for indicating the location of the change in code but somebody noted having a square bracket in the

D23097: [Task Manager] Add icon to the grouping menu entry

2019-08-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6bf630cce15a: [Task Manager] Add icon to the grouping menu entry (authored by simonkr, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23097: [Task Manager] Add icon to the grouping menu entry

2019-08-11 Thread Björn Feber
GB_2 updated this revision to Diff 63585. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63584=63585 BRANCH arcpatch-D23097 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES

D23097: [Task Manager] Add icon to the grouping menu entry

2019-08-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. LGTM! REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D23097 REVISION DETAIL https://phabricator.kde.org/D23097 To: simonkr, #plasma, #vdg, hein, GB_2, ngraham Cc: ngraham, GB_2, #vdg, plasma-devel, #plasma, LeGast00n, cblack,

D23097: [Task Manager] Add icon to the grouping menu entry

2019-08-11 Thread Björn Feber
GB_2 updated this revision to Diff 63584. GB_2 added a comment. Fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63580=63584 BRANCH arcpatch-D23097 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-11 Thread Nathaniel Graham
ngraham added a comment. Now it's is literally impossible to tell which tab is active when the window is inactive with the default Breeze color scheme: F7205056: Screenshot_20190811_150843.png This doesn't happen with all color schemes I tested

D23097: [Task Manager] Add icon to the grouping menu entry

2019-08-11 Thread Simon Krull
simonkr updated this revision to Diff 63580. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63578=63580 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml To: simonkr, #plasma, #vdg, hein Cc: GB_2,

D22535: Make kimpanel a system tray applet

2019-08-11 Thread Yunhe Guo
guoyunhe updated this revision to Diff 63579. guoyunhe added a comment. - avoid state jumping. lock state when opening kimpanel. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22535?vs=63561=63579 BRANCH master REVISION DETAIL

D23097: [Task Manager] Add icon to the grouping menu entry

2019-08-11 Thread Simon Krull
simonkr updated this revision to Diff 63578. simonkr added a comment. Add a Space CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63568=63578 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml To:

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 1 - Failure!

2019-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/1/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 11 Aug 2019 11:06:00 + Build duration: 9 hr 39 min and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 1 - Failure!

2019-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/1/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 11 Aug 2019 11:04:00 + Build duration: 9 hr 36 min and counting CONSOLE OUTPUT

D23097: [Task Manager] Add icon to the grouping menu entry

2019-08-11 Thread Björn Feber
GB_2 added a comment. Don't forget the inline comment ;-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23097 To: simonkr, #plasma, #vdg, hein Cc: GB_2, #vdg, plasma-devel, #plasma, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh,

D23097: Add icon to the taskmanager grouping menu entry

2019-08-11 Thread Simon Krull
simonkr updated this revision to Diff 63568. simonkr added a comment. Update icon to "view-group" CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63548=63568 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES

D23100: Let settings work with arbitrary input controls

2019-08-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Don't limit it to just check boxes. Check boxes will by default write into the `enabled`

D22535: Make kimpanel a system tray applet

2019-08-11 Thread Yunhe Guo
guoyunhe added a comment. Uploaded latest code. It is unfinished. Just for anyone who may accidentally be interested. What works: 1. Make the widget a system tray icon. 2. The system tray icon can show current input method. 3. Right click the system tray icon, context menu allow

D22535: Make kimpanel a system tray applet

2019-08-11 Thread Yunhe Guo
guoyunhe updated this revision to Diff 63561. guoyunhe added a comment. - UNFINISHED: show icon of current input method in system tray REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22535?vs=61998=63561 BRANCH master REVISION DETAIL

D23099: Allow sending a port message and receive a reply

2019-08-11 Thread Kai Uwe Broulik
broulik updated this revision to Diff 63560. broulik added a comment. - Fix if condition REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23099?vs=63555=63560 REVISION DETAIL https://phabricator.kde.org/D23099 AFFECTED FILES

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-11 Thread Carson Black
cblack updated this revision to Diff 63559. cblack added a comment. Add some extra colors + backdrop colors REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63516=63559 BRANCH chromium-tweaks (branched from master) REVISION DETAIL

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-11 Thread Kai Uwe Broulik
broulik added a comment. +10 to the original contrasted version The other variant with dark toolbar just looks weird. If I use Breeze light I want light controls, light address bar and favorites. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23080 To:

D23097: Add icon to the taskmanager grouping menu entry

2019-08-11 Thread Björn Feber
GB_2 added a comment. I think the icon `view-group` fits better. INLINE COMMENTS > ContextMenu.qml:577 > text: i18n("Allow this program to be grouped") > - > +icon: "object-group" > onClicked: tasksModel.requestToggleGrouping(menu.modelIndex)

D23099: Allow sending a port message and receive a reply

2019-08-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of manually matching a sent message to a port message, allow adding

D22535: Make kimpanel a system tray applet

2019-08-11 Thread Xuetian Weng
xuetianweng requested changes to this revision. xuetianweng added a comment. This change doesn't serve any real functionality of kimpanel. It doesn't show the current input method in tray, doesn't hide or show up. And kimpanel usually consist multiple icons. While it's doubt whether we need

D22535: Make kimpanel a system tray applet

2019-08-11 Thread Yunhe Guo
guoyunhe added a comment. Added context menu actions to configure keyboard and fcitx. @ngraham do we KCM of ibus or scim? F7204543: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22535 To: guoyunhe,

D23097: Add icon to the taskmanager grouping menu entry

2019-08-11 Thread Simon Krull
simonkr created this revision. simonkr added reviewers: Plasma, VDG. simonkr added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. simonkr requested review of this revision. REVISION SUMMARY F7204491: menu.png REPOSITORY R119 Plasma

D23095: Wayland: Rename output member variable

2019-08-11 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. TEST PLAN Compiles. REPOSITORY R110 KScreen Library BRANCH renameOutputDevice REVISION DETAIL

D23094: Wayland: Improve screen code style

2019-08-11 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. TEST PLAN Compiles. REPOSITORY R110 KScreen Library BRANCH waylandScreenStyle REVISION DETAIL

D23091: Call media session callback with details

2019-08-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The spec says it must be called with a details callback [1] [1]

D23090: Handle media session callbacks even when the requested one isn't supported by the browser

2019-08-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The Media Session API standard evolves quite fast, so there's new actions that we might be

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-11 Thread Kai Uwe Broulik
broulik added a comment. +1 to making tabs easier to see. I had to stop using Chome in GTK theme mode but use Chrome's default theme as with Breeze GTK I just couldn't tell them apart. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23080 To: cblack,

D22452: Fix text color in non-selected tabs in Firefox

2019-08-11 Thread Matej Mrenica
mthw abandoned this revision. mthw added a comment. Someone else is working on this issue now, here: https://phabricator.kde.org/D23079 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: rikshaw, cblack, ndavis,

KDE CI: Plasma » plymouth-kcm » stable-kf5-qt5 SUSEQt5.12 - Build # 21 - Failure!

2019-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plymouth-kcm/job/stable-kf5-qt5%20SUSEQt5.12/21/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 11 Aug 2019 06:16:41 + Build duration: 5 min 44 sec and counting CONSOLE OUTPUT