D23117: kcmlookandfeel - Fixed Splash Screen applying

The-Feren-OS-Dev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. The-Feren-OS-Dev requested review of this revision. REVISION SUMMARY This is a small change to the Look & Feel KCM Code to fix https://bugs.kde.org/show_bug.cgi?id=409015 by

D23100: Let settings work with arbitrary input controls

broulik updated this revision to Diff 63629. broulik edited the summary of this revision. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23100?vs=63567=63629 REVISION DETAIL https://phabricator.kde.org/D23100 AFFECTED FILES

D23090: Handle media session callbacks before passing it on to the browser

This revision was automatically updated to reflect the committed changes. Closed by commit R856:a181a9e5b3e8: Handle media session callbacks before passing it on to the browser (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D23099: Allow sending a port message and receive a reply

broulik added inline comments. INLINE COMMENTS > content-script.js:693 > > -return ret; > +// Call the original native implementation > +// "call()" is needed as the real setActionHandler is a > class member Don't mind this screwup

D23099: Allow sending a port message and receive a reply

broulik updated this revision to Diff 63624. broulik added a comment. - address review comments there's now a `handleData` overload which takes a `serial` and returns a `QJsonObject`. You can just return a `QJsonObject` to reply immediately or store the `serial` and call `sendReply`

D23100: Let settings work with arbitrary input controls

fvogt added inline comments. INLINE COMMENTS > broulik wrote in options.js:119 > What do you mean? `` -> `` and then just error out if there's no key defined. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23100 To: broulik, #plasma, fvogt Cc:

D23100: Let settings work with arbitrary input controls

broulik added inline comments. INLINE COMMENTS > fvogt wrote in options.js:119 > AFAIK we control everything on the settings page already, so why not just > convert all of them? What do you mean? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D23090: Handle media session callbacks before passing it on to the browser

broulik updated this revision to Diff 63618. broulik retitled this revision from "Handle media session callbacks even when the requested one isn't supported by the browser" to "Handle media session callbacks before passing it on to the browser". broulik edited the summary of this revision.

D23091: Call media session callback with details

This revision was automatically updated to reflect the committed changes. Closed by commit R856:2a6557e41e2a: Call media session callback with details (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23091?vs=63533=63616#toc REPOSITORY R856 Plasma Browser

D23107: Slightly prettier debug

This revision was automatically updated to reflect the committed changes. Closed by commit R856:77128e353466: Slightly prettier debug (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23107?vs=63596=63615 REVISION

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63614. GB_2 marked 7 inline comments as done. GB_2 added a comment. Address comments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63611=63614 BRANCH arcpatch-D22896 REVISION DETAIL

D23099: Allow sending a port message and receive a reply

fvogt added a comment. IMHO the member variable is really ugly. Messages with and without serial number have to be handled differently anyway, so why not introuce a new `handleMessage(event, json, serial)` method? INLINE COMMENTS > extension-utils.js:65 > +message.event = event; >

D23100: Let settings work with arbitrary input controls

fvogt added inline comments. INLINE COMMENTS > options.js:37 > > function extensionCheckboxes() { > return document.querySelectorAll("#extensions-selection > input[type=checkbox][data-extension]"); Can be removed? > options.js:114 > + > +if (!settings[extension]) { > +

D23107: Slightly prettier debug

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. TIL that exists REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23107 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, LeGast00n,

D23091: Call media session callback with details

fvogt accepted this revision. fvogt added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > content-script.js:673 > +action: action > +// for seeking there's additional information one > would need to add > +

D23090: Handle media session callbacks even when the requested one isn't supported by the browser

fvogt added inline comments. INLINE COMMENTS > content-script.js:687 > +// still be able to handle it > +if (!["play", "pause", "seekbackward", "seekforward", > "previoustrack", "nexttrack", "skipad", "stop"].includes(name)) { > +

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

davidre added a comment. In D23080#510815 , @ngraham wrote: > IMO the ideal state of affairs would be to somehow emulate the colors of the standard Qt tab widget: > > F7205923: Screenshot_20190812_073407.png

D22896: Port System Settings sidebar to QQC2

broulik added inline comments. INLINE COMMENTS > SidebarMode.cpp:402 > +{ > +QMenu *menu = new QMenu(); > +QStringList actionList { QStringLiteral("configure"), > QStringLiteral("help_contents"), QStringLiteral("help_about_app"), > QStringLiteral("help_about_kde") }; This leaks.

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 updated this revision to Diff 63611. GB_2 added a comment. Use a QMenu REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63460=63611 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED FILES

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

ngraham added a comment. IMO the ideal state of affairs would be to somehow emulate the colors of the standard Qt tab widget: F7205923: Screenshot_20190812_073407.png Not too contrasty, but not too subtle either. REPOSITORY R98 Breeze for

D23095: Wayland: Rename output member variable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:989df1eec1f4: Wayland: Rename output member variable (authored by romangg). REPOSITORY R110 KScreen Library

D23094: Wayland: Improve screen code style

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:c80a7ab40abc: Wayland: Improve screen code style (authored by romangg). CHANGED PRIOR TO COMMIT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/2/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 12 Aug 2019 12:37:09 + Build duration: 7 min 16 sec and counting CONSOLE OUTPUT

D23112: Add a event Spy for GtkFileChooser recent files

broulik added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:125 > + > +app.name = attributes.value("exec"); > +// remove "'" caracters wrapping the command and any character after > a space It stores the full `Exec` line of the desktop file, including the `%u`. What you

D23112: Add a event Spy for GtkFileChooser recent files

broulik added a comment. Can you check out the `KBookmarks` framework which has classes for processing xbel files REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: broulik, plasma-devel, LeGast00n, jraleigh,

D23112: Add a event Spy for GtkFileChooser recent files

meven created this revision. meven added reviewers: Frameworks, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY GtkFileChooser/GtkRecentManager follows

D23020: Use QQuickWidget instead of a QQuickView placed into QWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R116:ccce9e3cd247: Use QQuickWidget instead of a QQuickView placed into QWidget (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D23109: Rework the visibleActions logic in SwipeListItem

leinir created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY visibleActions is really only used to check whether there are any actions visible at all, the number is irrelevant. For some

D23107: Slightly prettier debug

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Print the extension name without quotes and spaces. Before: `"plugin" :

D23099: Allow sending a port message and receive a reply

broulik updated this revision to Diff 63595. broulik added a comment. - Let plugin access the serial so it can store it and send a reply asynchronously later REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23099?vs=63560=63595 REVISION

Re: Unified git commit message guideline

Hello Roman, On dimanche 11 août 2019 23:52:55 CEST Roman Gilg wrote: > [1] https://www.conventionalcommits.org I like the idea very much, the changelog does look a bit messy indeed. It would allow me to filter out all style, ci, and test changes, which are not interesting to the user of the

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

broulik added a comment. In D23080#510593 , @ngraham wrote: > It results in a look we have anywhere else and with the default Breeze color scheme I think it looks super heavy: > F7205054: Screenshot_20190811_150818.png