D21815: [sddm-theme] Start moving from QQC1 to QQC2

GB_2 added a comment. In D21815#490482 , @filipf wrote: > If keeping the new menu style we have to wait until all those patches get merged in Plasma. > > Might be better to just follow current style; updating it to the new one would be a

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 added a comment. In D19822#442630 , @filipf wrote: > Just throwing out another possible solution: the PlasmaComponents Highlight thingy: > > F6747233: Screenshot_20190403_005556.png > >

D23079: [GTK3] Fix Firefox's CSD colors, kinda

cblack updated this revision to Diff 63676. cblack added a comment. Tweak colors some more REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23079?vs=63515=63676 BRANCH firefox-csd-fix (branched from master) REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Thanks for geting involved this much! INLINE COMMENTS > GtkEventSpy.cpp:129 > +// remove "'" caracters wrapping the command > +exec = exec.mid(1, exec.size() -2 ); >

D23130: [energy kcm] Remove bogus Has power supply property from UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good catch! REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D23130 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n,

D12103: Support snap permissions in Discover

juanasensiosanchez added a comment. That makes sense: $ dpkg -l | grep discover ii avahi-utils 0.7-3.1ubuntu1.2 amd64Avahi browsing, publishing and discovery utilities ii plasma-discover

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY In a laptop when the ac line is un plugged, kinfocenter wrongly display that the ac power

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63669. meven added a comment. Add a logging category REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63654=63669 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED

plasma* akademy bofs

halo when shall we do plasma bofs? last year we had 4 slots on Monday. do we want more? or less? a different day perhaps? 9:30, 10:30, 11:30, 15:30 are the times we had last year, for reference HS

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added inline comments. INLINE COMMENTS > GB_2 wrote in menu.cpp:117 > I'd change it to "Manage Displays..." to make the differentiate the name even > more from the "Configure Desktop..." menu entry. *to differentiate REPOSITORY R120 Plasma Workspace REVISION DETAIL

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added inline comments. INLINE COMMENTS > menu.cpp:117 > > +m_displaySettingsAction = new > QAction(i18nc("plasma_containmentactions_contextmenu", "Configure > Displays..."), this); > + >

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added a comment. I think we should definitely add this shortcut, because it is very useful for the people mentioned and for other situations. I agree that it should be on by default, then it's already there when you need it. In D14830#472177

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

ngraham added a comment. Might be worth beating the dead horse and revisiting it though. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23127 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

GB_2 abandoned this revision. GB_2 added a comment. Oh, didn't know that existed, it wasn't mentioned anywhere in the bug report. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23127 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma,

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

ngraham added a comment. I recall that this was controversial. See D14830 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23127 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n,

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/72/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 13 Aug 2019 14:54:07 + Build duration: 5 min 27 sec and counting JUnit Tests Name:

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 355679 F7237121: Displays KCM Desktop Context Menu Entry.png

D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7237121: Displays KCM Desktop Context Menu Entry.png TEST

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

This revision was automatically updated to reflect the committed changes. Closed by commit R98:80bcaaf483da: [GTK3 - Chrome/ium] Tweak tab stylings (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63661=63663 REVISION

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Perfect. I agree, we can fix the windeco buttons in another patch. REPOSITORY R98 Breeze for Gtk BRANCH chromium-tweaks (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63662. GB_2 added a comment. Improve example REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63653=63662 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

cblack added a comment. I'm aware of the visibility issues of the window buttons on Breeze light CSD, however fixing those would require changes outside of the scope of this patch. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23080 To: cblack, #breeze,

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

cblack updated this revision to Diff 63661. cblack added a comment. Change around the colors a bit REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63559=63661 BRANCH chromium-tweaks (branched from master) REVISION DETAIL

D23126: Add browser action for status reporting

broulik created this revision. broulik added reviewers: Plasma, VDG, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a tool bar icon for reporting extension status in lieu of the error

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. In D23049#511210 , @ngraham wrote: > Hmm, if software making use of this needs to manually add a label, that seems to defeat part of the point of using a standard component. The label in the example was just

D23109: Rework the visibleActions logic in SwipeListItem

leinir updated this revision to Diff 63658. leinir added a comment. - Only check for other visible actions if this one is not visible REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23109?vs=63598=63658 BRANCH rework-swipelistitem-visible-actions-logic

D23099: Allow sending a port message and receive a reply

This revision was automatically updated to reflect the committed changes. Closed by commit R856:32a4fce2aa74: Allow sending a port message and receive a reply (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D23125: fix bridge master:slave mapping by-name

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. sitter requested review of this revision. REVISION SUMMARY a slave may be mapped to a master by either the uuid of the master OR the connection name of the

D23049: Add Kirigami ListSectionHeader component

ngraham added a comment. Hmm, if software making use of this needs to manually add a label, that seems to defeat part of the point of using a standard component. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart, ngraham Cc:

D12103: Support snap permissions in Discover

ngraham added a comment. Kubuntu 18.04 uses Plasma 5.12 which includes Discover 5.12. This code was added in a later version (likely 5.13). REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12103 To: apol Cc: juanasensiosanchez, ngraham, plasma-devel,

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/71/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 13 Aug 2019 13:03:15 + Build duration: 2 min 59 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 331 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/331/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 13:03:14 + Build duration: 2 min 59 sec and counting CONSOLE OUTPUT

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63654. meven added a comment. Readd include QDebug used by qWarning REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63647=63654 BRANCH master REVISION DETAIL

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 330 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/330/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 10:58:17 + Build duration: 1 min 49 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 70 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/70/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 13 Aug 2019 10:58:17 + Build duration: 53 sec and counting CONSOLE OUTPUT

D12103: Support snap permissions in Discover

juanasensiosanchez added a comment. New in Phabricator. Is this code already merged? Using Kubuntu 18.04 with Backports PPA but I can't see these options. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12103 To: apol Cc: juanasensiosanchez,

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63653. GB_2 added a comment. Ditch the extra property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63444=63653 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES

D23099: Allow sending a port message and receive a reply

fvogt added inline comments. INLINE COMMENTS > extension.js:109 > > -if (!subsystem || !action) { > +if (replyToSerial < 0 && (!subsystem || !action)) { > return; Would need to be `"replyToSerial" in message` now, `undefined` is not smaller than 0 >

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63647. meven marked an inline comment as done. meven added a comment. Remove unused include REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63641=63647 BRANCH master REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

mart added inline comments. INLINE COMMENTS > ListSectionHeader.qml:92 > + > +Component.onCompleted: { > +for (var i = 0; i < customItems.length; i++) { This is a no-go hack: those customItems shouldn't be reparented, but rather the property should be an alias to the data

D23099: Allow sending a port message and receive a reply

broulik updated this revision to Diff 63646. broulik added a comment. - We're signed int :) REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23099?vs=63645=63646 REVISION DETAIL https://phabricator.kde.org/D23099 AFFECTED FILES

D23099: Allow sending a port message and receive a reply

broulik updated this revision to Diff 63645. broulik added a comment. - Properly support zero as serial - Wrap int max properly REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23099?vs=63644=63645 REVISION DETAIL

D23099: Allow sending a port message and receive a reply

broulik added a comment. Didn't add it to `settings` as I have some follow-up patches that will actually use the other overload, too REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23099 To: broulik, #plasma, davidedmundson, fvogt Cc:

D23099: Allow sending a port message and receive a reply

broulik updated this revision to Diff 63644. broulik added a comment. - Silence method hidden warning REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23099?vs=63624=63644 REVISION DETAIL https://phabricator.kde.org/D23099 AFFECTED

D23099: Allow sending a port message and receive a reply

fvogt added inline comments. INLINE COMMENTS > broulik wrote in abstractbrowserplugin.h:56 > Why does it say "got hidden" when those two clearly have a different > signature? Because only the overridden overload is visible in the child classes. You can fix this by adding `using

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3417dd1620c7: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22856: [Notifications] Enable do not disturb mode when screens are mirrored

This revision was automatically updated to reflect the committed changes. Closed by commit R120:523ef16369cc: [Notifications] Enable do not disturb mode when screens are mirrored (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 284 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/284/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 07:30:56 + Build duration: 39 min and counting CONSOLE OUTPUT [...truncated 5325

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63641. meven added a comment. Use KServiceTypeTrader to look for apps being used REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63603=63641 BRANCH master REVISION DETAIL

D23099: Allow sending a port message and receive a reply

broulik added inline comments. INLINE COMMENTS > abstractbrowserplugin.h:56 > virtual void handleData(const QString , const QJsonObject ); > +virtual QJsonObject handleData(int serial, const QString , const > QJsonObject ); > Why does it say "got hidden" when those two clearly have

D23122: Enable enhanced media controls by default

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Media Sessions API usage becomes more and more common, so it is quite nice

D23100: Let settings work with arbitrary input controls

This revision was automatically updated to reflect the committed changes. Closed by commit R856:c8572d6cbed5: Let settings work with arbitrary input controls (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D23100: Let settings work with arbitrary input controls

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Didn't test, but looks good REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23100 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n,

D23112: Add a event Spy for GtkFileChooser recent files

meven added a comment. In D23112#510798 , @broulik wrote: > Can you check out the `KBookmarks` framework which has classes for processing xbel files Thanks for pointing it out. I just did, and It does not seem to cover my use case here

D23100: Let settings work with arbitrary input controls

broulik updated this revision to Diff 63638. broulik added a comment. - Don't write config keys for which we don't have a default REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23100?vs=63629=63638 REVISION DETAIL