KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 16 Aug 2019 03:17:07 + Build duration: 2 hr 1 min and counting CONSOLE OUTPUT [...truncated 121

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/4/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 16 Aug 2019 03:17:27 + Build duration: 12 min and counting CONSOLE OUTPUT

D22885: Add global animation speed slider to workspace options KCM

davidedmundson updated this revision to Diff 63844. davidedmundson added a comment. rename config option and variable and property names REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22885?vs=62956=63844 BRANCH master REVISION DETAIL

D22818: Avoid crash if kicker plugin is used outside plasma context

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c423eb7f959c: Avoid crash if kicker plugin is used outside plasma context (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 15 Aug 2019 19:31:12 + Build duration: 2 hr 0 min and counting CONSOLE OUTPUT [...truncated 142

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ngraham added a comment. All right. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23170 To: ndavis, #vdg, #breeze Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ndavis added a comment. In D23170#512753 , @ngraham wrote: > Sounds like you know more than me. Still, the top one is inside a no-KDE4 ifdef, if I'm reading the code right. Ah, that's true. However, unless someone who knows more than me

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ngraham added a comment. Sounds like you know more than me. Still, the top one is inside a no-KDE4 ifdef, if I'm reading the code right. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23170 To: ndavis, #vdg, #breeze Cc: mglb, ngraham, plasma-devel, LeGast00n,

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

This revision was automatically updated to reflect the committed changes. Closed by commit R31:b43e19e3e13c: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ndavis added a comment. I thought the hex values were used because it's also supposed to be possible to compile Breeze for Qt 4? I remember reading that Qt 4 needs hex numbers for some reason. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23170 To: ndavis, #vdg,

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ngraham added inline comments. INLINE COMMENTS > breezestyle.cpp:198 > +#if !BREEZE_USE_KDE4 > +#if QT_VERSION < 0x050D00 // Check if Qt version < 5.13 > +this->addEventFilter(qApp); You can make it more readable like this: `#if QT_VERSION < QT_VERSION_CHECK(5,13,0)`

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ndavis updated this revision to Diff 63839. ndavis edited the test plan for this revision. ndavis added a comment. Add event filter for Qt < 5.13 REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23170?vs=63785=63839 BRANCH fix-application-colorschemes

D23170: Fix colors from KStatefulBrushes not using application colorschemes

mglb added a comment. Please add the workaround for a bug fixed in qt 5.13 (eventfilter and stuff). Some people would like to compile it on current systems. In such case non-system Qt is not an option, as the style plugin won't load in older Qt. Also, the code is already written with nice

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ngraham added a comment. As long as Breeze itself doesn't have a hard dependency on ≥ Qt 5.13, you'll need to handle that case, and make sure the added code either still works for 5.13 or gets# ifdef'd out. ...Or you could bump the dep to Qt 5.13, but that's probably not feasible given the

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ndavis added a comment. In D23170#512391 , @ngraham wrote: > In D23170#512292 , @ndavis wrote: > > > How likely is it for distros using Qt < 5.13 to receive an update to Breeze that isn't a

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63830. meven added a comment. run uncrustify-kf5 REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63786=63830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63827. GB_2 added a comment. Use standard shortcut for "Configure System Settings..." action REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63799=63827 BRANCH arcpatch-D22896 REVISION DETAIL

D22804: [System Tray] Do not send ContextMenu signal twice

This revision was automatically updated to reflect the committed changes. Closed by commit R120:67c1117fa52d: [System Tray] Do not send ContextMenu signal twice (authored by kmaterka, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22896: Port System Settings sidebar to QQC2

ngraham added inline comments. INLINE COMMENTS > SettingsBase.cpp:143 > configureAction = actionCollection()->addAction( > KStandardAction::Preferences, QStringLiteral("configure"), this, > SLOT(configShow()) ); > actionCollection()->setDefaultShortcut(configureAction, >

D23174: Improve the look of the Activities KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic. REPOSITORY R119 Plasma Desktop BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23174 To: GB_2, #plasma, #vdg,

D23188: Fix supported OS attributes for api.kde.org

vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Move the "maintainer needed" to a note, so it's not showing up globally for all modules. Also, change "macOS" back to "MacOSX"

D23184: [KCM] Draw full QTabWidget frame

This revision was automatically updated to reflect the committed changes. Closed by commit R133:82f198916da1: [KCM] Draw full QTabWidget frame (authored by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23184?vs=63813=63819 REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63818. GB_2 added a comment. Fix "blocked" emblem icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63817=63818 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

ngraham added a comment. So does this fully fix 410190, or only partially? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22740 To: marten, #plasma Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63817. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63800=63817 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for fixing this annoying issue. REPOSITORY R31 Breeze BRANCH fix-ToolButtonComplexControl (branched from master) REVISION DETAIL https://phabricator.kde.org/D23169 To:

D23174: Improve the look of the Activities KCM UI

ngraham added a comment. Very nice work. This is close to a "shipit" already IMO from my perspective. I just have a few more comments: INLINE COMMENTS > GeneralTab.qml:26 > +import org.kde.kquickcontrols 2.0 as KQuickControls > +import org.kde.kquickcontrolsaddons 2.0 as KQuickControls >

D23185: [libtaskmanager] Port to lighter KProcessList

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Only fetches the properties name and command. Avoids bringing a

D23184: [KCM] Draw full QTabWidget frame

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now we're not drawing the full frame in the Screen Locking KCM to work around

D22327: [libnotificationmanager] Port to lighter KProcessList

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d14aca8cd861: [libnotificationmanager] Port to lighter KProcessList (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22327?vs=61345=63810#toc REPOSITORY R120

D23151: Implement Web Share API through Purpose

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > purposeplugin.cpp:122 > +urls.append(text); > +showShareMenu(shareJson, QStringLiteral("text/plain")); > +return {};

D23151: Implement Web Share API through Purpose

broulik updated this revision to Diff 63809. broulik added a comment. - Reset to -1 - Use urls again REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23151?vs=63808=63809 REVISION DETAIL https://phabricator.kde.org/D23151 AFFECTED

D23174: Improve the look of the Activities KCM UI

ngraham added a comment. As a further improvement, I might even merge the contents of the "Switching" tab into the main "Activities" tab. There's room below the Activities list because typically people are going to have 1-4 activities at most; it's not generally going to be a huge tall list

D23151: Implement Web Share API through Purpose

broulik updated this revision to Diff 63808. broulik added a comment. - Address comments REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23151?vs=63716=63808 REVISION DETAIL https://phabricator.kde.org/D23151 AFFECTED FILES

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63800. GB_2 added a comment. "Only for specific applications" -> "Only for specific applications:" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63793=63800 BRANCH improved-activities-kcm-ui (branched

D23174: Improve the look of the Activities KCM UI

ngraham added a comment. UI is super better now, wow. INLINE COMMENTS > PrivacyTabBase.ui:60 > + > +Only for specific applications > + I'd add a colon after this (`Only for specific applications:`) because the grid of specific applications is right after it.

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63799. GB_2 added a comment. Bind checked property directly REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63614=63799 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896

D23151: Implement Web Share API through Purpose

broulik added inline comments. INLINE COMMENTS > fvogt wrote in purposeplugin.cpp:144 > No response. IMO this should be handled in the plugin manager though, as > discussed on that diff. Yeah, I will clean that up everywhere separate of this patch as to not entangle it even further.

D23151: Implement Web Share API through Purpose

broulik added inline comments. INLINE COMMENTS > fvogt wrote in content-script.js:837 > Where is that documented? https://w3c.github.io/web-share/#security-and-privacy-considerations > 4. Security and privacy considerations > > […] > > *Due to the capabilities of the API surface,

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

cfeck added a comment. Could someone test this on Wayland? The fix itself looks trivial, but if it breaks Wayland session, it obviously needs to be changed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22740 To: marten, #plasma Cc: cfeck, plasma-devel,

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ngraham added a comment. In D23170#512292 , @ndavis wrote: > How likely is it for distros using Qt < 5.13 to receive an update to Breeze that isn't a backport? Do you mean to say that this is fixed already in Qt 5.13? REPOSITORY R31

D23175: Clean up old bug workaround

This revision was automatically updated to reflect the committed changes. Closed by commit R119:352f6e835359: Clean up old bug workaround (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23175?vs=63795=63797 REVISION DETAIL

D23175: Clean up old bug workaround

meven updated this revision to Diff 63795. meven added a comment. Clean up patch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23175?vs=63794=63795 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23175 AFFECTED FILES

D23175: Clean up old bug workaround

meven created this revision. meven added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The workaround is not necessary anymore. See https://bugreports.qt.io/browse/QTBUG-40765

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63793. GB_2 added a comment. Remove unneeded import REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63792=63793 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, port to QQC2 and Kirigami, make the KCM look better and make the KCM show up in

D22012: Clean up old bug workaround in KCMFileIndexer

meven added a comment. In D22012#512025 , @davidedmundson wrote: > It was first added in 2d5f289767ee7b7c54f8b55e8032d20ef7f092f4 with some pretty sparse docs, then

D22012: Clean up old bug workaround in KCMFileIndexer

This revision was automatically updated to reflect the committed changes. Closed by commit R102:31b9b402f077: Clean up old bug workaround in KCMFileIndexer (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22012?vs=60397=63791 REVISION

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63786. meven marked 9 inline comments as done. meven added a comment. Remove unnecessary pointer use, code formatting REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63724=63786 BRANCH master

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ndavis added a comment. How likely is it for distros using Qt < 5.13 to receive an update to Breeze? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23170 To: ndavis, #vdg, #breeze Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This includes things like context menus and application menus REPOSITORY R31 Breeze BRANCH

D23169: Fix width of ToolButtonComplexControl outline w/ dropdown menu

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Apparently, the code to adjust the outline when a menu is present is what was causing the

D23151: Implement Web Share API through Purpose

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. AFAICT this won't work on wayland and will also break the browser's native implementation once that actually exists. INLINE COMMENTS > content-script.js:22 > +// from >

D23112: Add a event Spy for GtkFileChooser recent files

ivan added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:68 > +QDateTime visited; > +QList *applications; > + No need for this to be a pointer to a list. Make it just `QList applications`. > GtkEventSpy.cpp:70 > + > +Bookmark(){ > +applications = new QList(); The

D23151: Implement Web Share API through Purpose

broulik added inline comments. INLINE COMMENTS > apol wrote in purposeplugin.cpp:127 > shouldn't this be a data: url or something like that? urls should only have > urls I was wondering the same but the email plugin does something very strange: if (url.isLocalFile()) {