KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.13/9/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 16 Aug 2019 03:17:07 +
 Build duration:
2 hr 1 min and counting
   CONSOLE OUTPUT
  [...truncated 121 lines...]remote: Compressing objects:  49% (4896/9935)   remote: Compressing objects:  49% (4899/9935)   remote: Compressing objects:  49% (4902/9935)   remote: Compressing objects:  49% (4903/9935)   remote: Compressing objects:  49% (4905/9935)   remote: Compressing objects:  49% (4908/9935)   remote: Compressing objects:  50% (4968/9935)   remote: Compressing objects:  51% (5067/9935)   remote: Compressing objects:  52% (5167/9935)   remote: Compressing objects:  53% (5266/9935)   remote: Compressing objects:  54% (5365/9935)   remote: Compressing objects:  55% (5465/9935)   remote: Compressing objects:  56% (5564/9935)   remote: Compressing objects:  57% (5663/9935)   remote: Compressing objects:  58% (5763/9935)   remote: Compressing objects:  59% (5862/9935)   remote: Compressing objects:  60% (5961/9935)   remote: Compressing objects:  61% (6061/9935)   remote: Compressing objects:  62% (6160/9935)   remote: Compressing objects:  63% (6260/9935)   remote: Compressing objects:  64% (6359/9935)   remote: Compressing objects:  65% (6458/9935)   remote: Compressing objects:  66% (6558/9935)   remote: Compressing objects:  67% (6657/9935)   remote: Compressing objects:  68% (6756/9935)   remote: Compressing objects:  69% (6856/9935)   remote: Compressing objects:  70% (6955/9935)   remote: Compressing objects:  71% (7054/9935)   remote: Compressing objects:  72% (7154/9935)   remote: Compressing objects:  73% (7253/9935)   remote: Compressing objects:  74% (7352/9935)   remote: Compressing objects:  75% (7452/9935)   remote: Compressing objects:  76% (7551/9935)   remote: Compressing objects:  77% (7650/9935)   remote: Compressing objects:  78% (7750/9935)   remote: Compressing objects:  79% (7849/9935)   remote: Compressing objects:  80% (7948/9935)   remote: Compressing objects:  81% (8048/9935)   remote: Compressing objects:  82% (8147/9935)   remote: Compressing objects:  83% (8247/9935)   remote: Compressing objects:  84% (8346/9935)   remote: Compressing objects:  85% (8445/9935)   remote: Compressing objects:  86% (8545/9935)   remote: Compressing objects:  87% (8644/9935)   remote: Compressing objects:  88% (8743/9935)   remote: Compressing objects:  89% (8843/9935)   remote: Compressing objects:  90% (8942/9935)   remote: Compressing objects:  91% (9041/9935)   remote: Compressing objects:  92% (9141/9935)   remote: Compressing objects:  93% (9240/9935)   remote: Compressing objects:  94% (9339/9935)   remote: Compressing objects:  95% (9439/9935)   remote: Compressing objects:  96% (9538/9935)   remote: Compressing objects:  97% (9637/9935)   remote: Compressing objects:  98% (9737/9935)   remote: Compressing objects:  99% (9836/9935)   remote: Compressing objects: 100% (9935/9935)   remote: Compressing objects: 100% (9935/9935), done.[2019-08-16T05:18:48.941Z] [2019-08-16T05:18:48.941Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2318)[2019-08-16T05:18:48.941Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1905)[2019-08-16T05:18:48.941Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:81)[2019-08-16T05:18:48.941Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:488)[2019-08-16T05:18:48.941Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:712)[2019-08-16T05:18:48.941Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2019-08-16T05:18:48.941Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2019-08-16T05:18:48.941Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)[2019-08-16T05:18:48.941Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2019-08-16T05:18:48.941Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2019-08-16T05:18:48.941Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2019-08-16T05:18:48.941Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-08-16T05:18:48.941Z] 	at 

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/4/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 16 Aug 2019 03:17:27 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 402 lines...][2019-08-16T03:30:07.102Z] mocs_compilation.cpp[2019-08-16T03:30:07.102Z] [  6%] Linking CXX executable ..\..\bin\lsb_release.exe[2019-08-16T03:30:07.102Z] Scanning dependencies of target crashtest[2019-08-16T03:30:07.102Z] Scanning dependencies of target drkonqi_backtrace_parser[2019-08-16T03:30:07.102Z] LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\HostX64\x64\link.exe /nologo @CMakeFiles\lsb_release.dir\objects1.rsp /out:..\..\bin\lsb_release.exe /implib:..\..\lib\lsb_release.lib /pdb:C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\bin\lsb_release.pdb /version:0.0 /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL /subsystem:windows kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\lsb_release.dir/intermediate.manifest CMakeFiles\lsb_release.dir/manifest.res" failed (exit code 1120) with the following output:[2019-08-16T03:30:07.102Z] msvcrtd.lib(exe_winmain.obj) : error LNK2019: unresolved external symbol WinMain referenced in function "int __cdecl invoke_main(void)" (?invoke_main@@YAHXZ)[2019-08-16T03:30:07.102Z] ..\..\bin\lsb_release.exe : fatal error LNK1120: 1 unresolved externals[2019-08-16T03:30:07.102Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\src\tests\CMakeFiles\lsb_release.dir\build.make [bin\lsb_release.exe] Error 2[2019-08-16T03:30:07.102Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\CMakeFiles\Makefile2 [src\tests\CMakeFiles\lsb_release.dir\all] Error 2[2019-08-16T03:30:07.102Z] Scanning dependencies of target kdbgwin[2019-08-16T03:30:07.102Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.obj[2019-08-16T03:30:07.102Z] [ 10%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.obj[2019-08-16T03:30:07.613Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.obj[2019-08-16T03:30:07.613Z] [ 10%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.obj[2019-08-16T03:30:07.613Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.obj[2019-08-16T03:30:07.613Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.obj[2019-08-16T03:30:07.613Z] crashtest.cpp[2019-08-16T03:30:07.613Z] backtraceparser.cpp[2019-08-16T03:30:07.613Z] [ 12%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/main.cpp.obj[2019-08-16T03:30:07.613Z] main.cpp[2019-08-16T03:30:07.613Z] mocs_compilation.cpp[2019-08-16T03:30:07.613Z] [ 13%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserlldb.cpp.obj[2019-08-16T03:30:08.127Z] Scanning dependencies of target qbugzilla[2019-08-16T03:30:08.652Z] [ 13%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/apijob.cpp.obj[2019-08-16T03:30:08.652Z] apijob.cpp[2019-08-16T03:30:10.361Z] backtraceparsernull.cpp[2019-08-16T03:30:10.361Z] [ 13%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_process.cpp.obj[2019-08-16T03:30:10.361Z] backtraceparserlldb.cpp[2019-08-16T03:30:10.361Z] [ 13%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsercdb.cpp.obj[2019-08-16T03:30:10.881Z] backtraceparserkdbgwin.cpp[2019-08-16T03:30:10.881Z] backtraceparsergdb.cpp[2019-08-16T03:30:10.881Z] [ 14%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/bugzilla.cpp.obj[2019-08-16T03:30:10.881Z] [ 15%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/abstract_generator.cpp.obj[2019-08-16T03:30:10.881Z] backtraceparsercdb.cpp[2019-08-16T03:30:11.415Z] [ 16%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.obj[2019-08-16T03:30:12.535Z] [ 16%] Linking CXX executable ..\..\..\bin\crashtest.exe[2019-08-16T03:30:13.055Z] bugzilla.cpp[2019-08-16T03:30:13.055Z] [ 17%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/connection.cpp.obj[2019-08-16T03:30:13.562Z] drkonqi_parser_debug.cpp[2019-08-16T03:30:13.562Z] [ 18%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/callbacks.cpp.obj[2019-08-16T03:30:13.562Z] connection.cpp[2019-08-16T03:30:13.562Z] [ 19%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.obj[2019-08-16T03:30:14.675Z] mocs_compilation.cpp[2019-08-16T03:30:14.675Z] [ 19%] Building 

D22885: Add global animation speed slider to workspace options KCM

[David Edmundson]

davidedmundson updated this revision to Diff 63844.
davidedmundson added a comment.


  rename config option and variable and property names

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22885?vs=62956=63844

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22885

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: davidedmundson, #plasma
Cc: GB_2, broulik, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22818: Avoid crash if kicker plugin is used outside plasma context

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c423eb7f959c: Avoid crash if kicker plugin is used 
outside plasma context (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22818?vs=62773=63843

REVISION DETAIL
  https://phabricator.kde.org/D22818

AFFECTED FILES
  applets/kicker/plugin/appsmodel.cpp

To: davidedmundson, #plasma, apol, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.13/8/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 15 Aug 2019 19:31:12 +
 Build duration:
2 hr 0 min and counting
   CONSOLE OUTPUT
  [...truncated 142 lines...]remote: Compressing objects:  49% (4902/9928)   remote: Compressing objects:  49% (4903/9928)   remote: Compressing objects:  49% (4904/9928)   remote: Compressing objects:  49% (4905/9928)   remote: Compressing objects:  49% (4907/9928)   remote: Compressing objects:  50% (4964/9928)   remote: Compressing objects:  51% (5064/9928)   remote: Compressing objects:  51% (5156/9928)   remote: Compressing objects:  52% (5163/9928)   remote: Compressing objects:  53% (5262/9928)   remote: Compressing objects:  54% (5362/9928)   remote: Compressing objects:  55% (5461/9928)   remote: Compressing objects:  56% (5560/9928)   remote: Compressing objects:  57% (5659/9928)   remote: Compressing objects:  58% (5759/9928)   remote: Compressing objects:  59% (5858/9928)   remote: Compressing objects:  60% (5957/9928)   remote: Compressing objects:  61% (6057/9928)   remote: Compressing objects:  62% (6156/9928)   remote: Compressing objects:  63% (6255/9928)   remote: Compressing objects:  64% (6354/9928)   remote: Compressing objects:  65% (6454/9928)   remote: Compressing objects:  66% (6553/9928)   remote: Compressing objects:  67% (6652/9928)   remote: Compressing objects:  68% (6752/9928)   remote: Compressing objects:  69% (6851/9928)   remote: Compressing objects:  70% (6950/9928)   remote: Compressing objects:  71% (7049/9928)   remote: Compressing objects:  72% (7149/9928)   remote: Compressing objects:  73% (7248/9928)   remote: Compressing objects:  74% (7347/9928)   remote: Compressing objects:  75% (7446/9928)   remote: Compressing objects:  76% (7546/9928)   remote: Compressing objects:  77% (7645/9928)   remote: Compressing objects:  78% (7744/9928)   remote: Compressing objects:  79% (7844/9928)   remote: Compressing objects:  80% (7943/9928)   remote: Compressing objects:  81% (8042/9928)   remote: Compressing objects:  82% (8141/9928)   remote: Compressing objects:  83% (8241/9928)   remote: Compressing objects:  84% (8340/9928)   remote: Compressing objects:  85% (8439/9928)   remote: Compressing objects:  86% (8539/9928)   remote: Compressing objects:  87% (8638/9928)   remote: Compressing objects:  88% (8737/9928)   remote: Compressing objects:  89% (8836/9928)   remote: Compressing objects:  90% (8936/9928)   remote: Compressing objects:  91% (9035/9928)   remote: Compressing objects:  92% (9134/9928)   remote: Compressing objects:  93% (9234/9928)   remote: Compressing objects:  94% (9333/9928)   remote: Compressing objects:  95% (9432/9928)   remote: Compressing objects:  96% (9531/9928)   remote: Compressing objects:  97% (9631/9928)   remote: Compressing objects:  98% (9730/9928)   remote: Compressing objects:  99% (9829/9928)   remote: Compressing objects: 100% (9928/9928)   remote: Compressing objects: 100% (9928/9928), done.[2019-08-15T21:31:16.923Z] [2019-08-15T21:31:16.923Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2318)[2019-08-15T21:31:16.923Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1905)[2019-08-15T21:31:16.923Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:81)[2019-08-15T21:31:16.923Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:488)[2019-08-15T21:31:16.923Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:712)[2019-08-15T21:31:16.923Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2019-08-15T21:31:16.923Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2019-08-15T21:31:16.923Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)[2019-08-15T21:31:16.923Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2019-08-15T21:31:16.923Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2019-08-15T21:31:16.923Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2019-08-15T21:31:16.923Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-08-15T21:31:16.924Z] 	at 

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Nathaniel Graham]

ngraham added a comment.


  All right.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

ndavis added a comment.


  In D23170#512753 , @ngraham wrote:
  
  > Sounds like you know more than me. Still, the top one is inside a no-KDE4 
ifdef, if I'm reading the code right.
  
  
  Ah, that's true. However, unless someone who knows more than me says it's OK, 
I think I'd like to keep the hex value with a comment to make it more readable.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Nathaniel Graham]

ngraham added a comment.


  Sounds like you know more than me. Still, the top one is inside a no-KDE4 
ifdef, if I'm reading the code right.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:b43e19e3e13c: Fix width and separator of 
ToolButtonComplexControl outline w/ dropdown menu (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23169?vs=63783=63840

REVISION DETAIL
  https://phabricator.kde.org/D23169

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

ndavis added a comment.


  I thought the hex values were used because it's also supposed to be possible 
to compile Breeze for Qt 4? I remember reading that Qt 4 needs hex numbers for 
some reason.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> breezestyle.cpp:198
> +#if !BREEZE_USE_KDE4
> +#if QT_VERSION < 0x050D00 // Check if Qt version < 5.13
> +this->addEventFilter(qApp);

You can make it more readable like this:

`#if QT_VERSION < QT_VERSION_CHECK(5,13,0)`

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

ndavis updated this revision to Diff 63839.
ndavis edited the test plan for this revision.
ndavis added a comment.


  Add event filter for Qt < 5.13

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23170?vs=63785=63839

BRANCH
  fix-application-colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23170

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Mariusz Glebocki]

mglb added a comment.


  Please add the workaround for a bug fixed in qt 5.13 (eventfilter and stuff). 
Some people would like to compile it on current systems. In such case 
non-system Qt is not an option, as the style plugin won't load in older Qt. 
Also, the code is already written with nice ifdefs and works, so why not.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Nathaniel Graham]

ngraham added a comment.


  As long as Breeze itself doesn't have a hard dependency on ≥ Qt 5.13, you'll 
need to handle that case, and make sure the added code either still works for 
5.13 or gets# ifdef'd out. ...Or you could bump the dep to Qt 5.13, but that's 
probably not feasible given the relative recency of its release and the fact 
that it's distributed with Plasma, which is not bumping the Qt dep that high.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

ndavis added a comment.


  In D23170#512391 , @ngraham wrote:
  
  > In D23170#512292 , @ndavis wrote:
  >
  > > How likely is it for distros using Qt < 5.13 to receive an update to 
Breeze that isn't a backport?
  >
  >
  > Do you mean to say that this is fixed already in Qt 5.13?
  
  
  No, more code is needed for older versions. See the comment I linked in the 
task.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63830.
meven added a comment.


  run uncrustify-kf5

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63786=63830

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63827.
GB_2 added a comment.


  Use standard shortcut for "Configure System Settings..." action

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63799=63827

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22804: [System Tray] Do not send ContextMenu signal twice

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:67c1117fa52d: [System Tray] Do not send ContextMenu 
signal twice (authored by kmaterka, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22804?vs=62738=63825

REVISION DETAIL
  https://phabricator.kde.org/D22804

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

To: kmaterka, #plasma, broulik, davidedmundson
Cc: broulik, apol, plasma-devel, #plasma_workspaces, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D22896: Port System Settings sidebar to QQC2

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> SettingsBase.cpp:143
>  configureAction = actionCollection()->addAction( 
> KStandardAction::Preferences, QStringLiteral("configure"), this, 
> SLOT(configShow()) );
>  actionCollection()->setDefaultShortcut(configureAction, 
> QKeySequence(Qt::CTRL + Qt::Key_M));
> +configureAction->setText( i18n("Configure...") );

lolwut

The default shortcut for "Configure" is [Ctrl] + [⇧] + [comma] these days!

I never even new this had a shortcut because only with your patch does it 
become visible. :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23174: Improve the look of the Activities KCM UI

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fantastic.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improved-activities-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23174

To: GB_2, #plasma, #vdg, ivan, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23188: Fix supported OS attributes for api.kde.org

[Volker Krause]

vkrause created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Move the "maintainer needed" to a note, so it's not showing up globally
  for all modules. Also, change "macOS" back to "MacOSX" (despite technically
  being the right name), as every other module still uses MacOSX and thus
  using anything else essentially adds a new OS on api.kde.org, globally.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23188

AFFECTED FILES
  metainfo.yaml

To: vkrause
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D23184: [KCM] Draw full QTabWidget frame

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:82f198916da1: [KCM] Draw full QTabWidget frame (authored 
by ngraham).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23184?vs=63813=63819

REVISION DETAIL
  https://phabricator.kde.org/D23184

AFFECTED FILES
  kcm/kcm.ui

To: ngraham, #vdg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 63818.
GB_2 added a comment.


  Fix "blocked" emblem icon

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23174?vs=63817=63818

BRANCH
  improved-activities-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23174

AFFECTED FILES
  kcms/activities/PrivacyTab.cpp
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/qml/activityDialog/GeneralTab.qml
  kcms/activities/imports/qml/activityDialog/OtherTab.qml
  kcms/activities/imports/qml/activityDialog/components/DialogButtons.qml
  kcms/activities/imports/qml/activityDialog/components/IconChooser.qml
  kcms/activities/imports/qml/activityDialog/components/LabeledTextField.qml
  kcms/activities/imports/qml/activityDialog/components/ShortcutChooser.qml
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
  kcms/activities/ui/MainConfigurationWidgetBase.ui
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: GB_2, #plasma, #vdg, ivan
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Nathaniel Graham]

ngraham added a comment.


  So does this fully fix 410190, or only partially?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 63817.
GB_2 added a comment.


  Address comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23174?vs=63800=63817

BRANCH
  improved-activities-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23174

AFFECTED FILES
  kcms/activities/PrivacyTab.cpp
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/qml/activityDialog/GeneralTab.qml
  kcms/activities/imports/qml/activityDialog/OtherTab.qml
  kcms/activities/imports/qml/activityDialog/components/DialogButtons.qml
  kcms/activities/imports/qml/activityDialog/components/IconChooser.qml
  kcms/activities/imports/qml/activityDialog/components/LabeledTextField.qml
  kcms/activities/imports/qml/activityDialog/components/ShortcutChooser.qml
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
  kcms/activities/ui/MainConfigurationWidgetBase.ui
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: GB_2, #plasma, #vdg, ivan
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks for fixing this annoying issue.

REPOSITORY
  R31 Breeze

BRANCH
  fix-ToolButtonComplexControl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Nathaniel Graham]

ngraham added a comment.


  Very nice work. This is close to a "shipit" already IMO from my perspective. 
I just have a few more comments:

INLINE COMMENTS

> GeneralTab.qml:26
> +import org.kde.kquickcontrols 2.0 as KQuickControls
> +import org.kde.kquickcontrolsaddons 2.0 as KQuickControls
>  

You're importing two different things with the same name

> ActivitiesView.qml:66
> +icon.name: "configure"
> +tooltip: i18nc("@info:tooltip", "Configure...")
> +onTriggered: 
> ActivitySettings.configureActivity(model.id);

Maybe "Configure  activity..."?

> ActivitiesView.qml:73
> +icon.name: "edit-delete"
> +tooltip: i18nc("@info:tooltip", "Delete")
> +onTriggered: 
> ActivitySettings.deleteActivity(model.id);

Maybe "Delete  activity"?

> ActivitiesView.qml:84
> +visible: ActivitySettings.newActivityAuthorized
> +text: i18nd("kcm_activities5", "Create...")
> +icon.name: "list-add"

How about "Create New..." just to emphasize that a new one is being made

> BlacklistApplicationView.qml:61
> +width: parent.width
> +source: "dialog-cancel"
> +opacity: (1 - icon.opacity) * 2

`emblem-unavailable` looks nicer and seems more semantically correct. If we use 
it, it should be located in the bottom-right corner of the icon to be 
consistent with other emblem placement.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23174

To: GB_2, #plasma, #vdg, ivan
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23185: [libtaskmanager] Port to lighter KProcessList

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Only fetches the properties name and command.
  Avoids bringing a libksysguard dependency into libtaskmanager.
  
  I also checked that we don't have a space at the end of the command.
  That appears to be a relic from an older time.

TEST PLAN
  Unit tests exist on KProcessList.
  
  Task manager applications appear fine, I don't know any good edge cases
  that go through this code to test.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23185

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/tasktools.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23184: [KCM] Draw full QTabWidget frame

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now we're not drawing the full frame in the Screen Locking KCM to work 
around
  . But this only exchanges one aesthetic problem for another, and as 
such, is
  not an appropriate workaround.
  
  This patch draws the full frame to fix 
https://bugs.kde.org/show_bug.cgi?id=410923,
  and then we can concentrate on fixing XXX so it works for everyone with 
no hacks
  or workarounds required.
  
  BUG: 410923
  FIXED-IN: 5.17.0

TEST PLAN
  F7248765: Activation tab.png 
  F7248766: Appearance tab.png 

REPOSITORY
  R133 KScreenLocker

BRANCH
  draw-tabwidget-frame (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23184

AFFECTED FILES
  kcm/kcm.ui

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22327: [libnotificationmanager] Port to lighter KProcessList

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d14aca8cd861: [libnotificationmanager] Port to lighter 
KProcessList (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22327?vs=61345=63810#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22327?vs=61345=63810

REVISION DETAIL
  https://phabricator.kde.org/D22327

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/utils.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> purposeplugin.cpp:122
> +urls.append(text);
> +showShareMenu(shareJson, QStringLiteral("text/plain"));
> +return {};

Doesn't use `urls` now?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Kai Uwe Broulik]

broulik updated this revision to Diff 63809.
broulik added a comment.


  - Reset to -1
  - Use urls again

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23151?vs=63808=63809

REVISION DETAIL
  https://phabricator.kde.org/D23151

AFFECTED FILES
  CMakeLists.txt
  extension/_locales/en/messages.json
  extension/constants.js
  extension/content-script.js
  extension/extension-purpose.js
  extension/manifest.json
  extension/options.html
  host/CMakeLists.txt
  host/main.cpp
  host/purposeplugin.cpp
  host/purposeplugin.h

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Nathaniel Graham]

ngraham added a comment.


  As a further improvement, I might even merge the contents of the "Switching" 
tab into the main "Activities" tab. There's room below the Activities list 
because typically people are going to have 1-4 activities at most; it's not 
generally going to be a huge tall list of dozens of items.
  
  I can understand if that presents tech problems because one is QML and the 
other is QWidgets though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23174

To: GB_2, #plasma, #vdg, ivan
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Kai Uwe Broulik]

broulik updated this revision to Diff 63808.
broulik added a comment.


  - Address comments

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23151?vs=63716=63808

REVISION DETAIL
  https://phabricator.kde.org/D23151

AFFECTED FILES
  CMakeLists.txt
  extension/_locales/en/messages.json
  extension/constants.js
  extension/content-script.js
  extension/extension-purpose.js
  extension/manifest.json
  extension/options.html
  host/CMakeLists.txt
  host/main.cpp
  host/purposeplugin.cpp
  host/purposeplugin.h

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 63800.
GB_2 added a comment.


  "Only for specific applications" -> "Only for specific applications:"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23174?vs=63793=63800

BRANCH
  improved-activities-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23174

AFFECTED FILES
  kcms/activities/PrivacyTab.cpp
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/qml/activityDialog/GeneralTab.qml
  kcms/activities/imports/qml/activityDialog/OtherTab.qml
  kcms/activities/imports/qml/activityDialog/components/DialogButtons.qml
  kcms/activities/imports/qml/activityDialog/components/IconChooser.qml
  kcms/activities/imports/qml/activityDialog/components/LabeledTextField.qml
  kcms/activities/imports/qml/activityDialog/components/ShortcutChooser.qml
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
  kcms/activities/ui/MainConfigurationWidgetBase.ui
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Nathaniel Graham]

ngraham added a comment.


  UI is super better now, wow.

INLINE COMMENTS

> PrivacyTabBase.ui:60
> +   
> +Only for specific applications
> +   

I'd add a colon after this (`Only for specific applications:`) because the grid 
of specific applications is right after it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23174

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63799.
GB_2 added a comment.


  Bind checked property directly

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63614=63799

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23151: Implement Web Share API through Purpose

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fvogt wrote in purposeplugin.cpp:144
> No response. IMO this should be handled in the plugin manager though, as 
> discussed on that diff.

Yeah, I will clean that up everywhere separate of this patch as to not entangle 
it even further.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fvogt wrote in content-script.js:837
> Where is that documented?

https://w3c.github.io/web-share/#security-and-privacy-considerations

> 4. Security and privacy considerations
> 
>   […]
> 
>   *Due to the capabilities of the API surface, navigator.share() is available 
> only in secure contexts (such as https:// schemes).

> fvogt wrote in purposeplugin.cpp:86
> Now we have `error`, `errorCode` and `errorMessage`?

`errorCode` and `errorMessage` are forwarded from the Purpose plugin, `error` 
is our own. I could change `errorCode` to return a string from us then I guess. 
Or I hardcode a magic 1 here which is `ERR_USER_CANCELED` which Purpose uses 
when canceled but that won't help for the busy case?

> fvogt wrote in purposeplugin.cpp:153
> 0 is a valid serial...

:)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Christoph Feck]

cfeck added a comment.


  Could someone test this on Wayland? The fix itself looks trivial, but if it 
breaks Wayland session, it obviously needs to be changed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Nathaniel Graham]

ngraham added a comment.


  In D23170#512292 , @ndavis wrote:
  
  > How likely is it for distros using Qt < 5.13 to receive an update to Breeze 
that isn't a backport?
  
  
  Do you mean to say that this is fixed already in Qt 5.13?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23175: Clean up old bug workaround

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:352f6e835359: Clean up old bug workaround (authored by 
meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23175?vs=63795=63797

REVISION DETAIL
  https://phabricator.kde.org/D23175

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/fonts/fonts.cpp
  kcms/lookandfeel/kcm.cpp

To: meven, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23175: Clean up old bug workaround

[Méven Car]

meven updated this revision to Diff 63795.
meven added a comment.


  Clean up patch

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23175?vs=63794=63795

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23175

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/fonts/fonts.cpp
  kcms/lookandfeel/kcm.cpp

To: meven, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23175: Clean up old bug workaround

[Méven Car]

meven created this revision.
meven added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  The workaround is not necessary anymore.
  See https://bugreports.qt.io/browse/QTBUG-40765
  See also D22012 

TEST PLAN
  Manually tested

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23175

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/kastatsfavoritesmodel.cpp
  applets/taskmanager/plugin/backend.cpp
  kcms/desktoptheme/kcm.cpp
  kcms/fonts/fonts.cpp
  kcms/lookandfeel/kcm.cpp

To: meven, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 63793.
GB_2 added a comment.


  Remove unneeded import

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23174?vs=63792=63793

BRANCH
  improved-activities-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23174

AFFECTED FILES
  kcms/activities/PrivacyTab.cpp
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/qml/activityDialog/GeneralTab.qml
  kcms/activities/imports/qml/activityDialog/OtherTab.qml
  kcms/activities/imports/qml/activityDialog/components/DialogButtons.qml
  kcms/activities/imports/qml/activityDialog/components/IconChooser.qml
  kcms/activities/imports/qml/activityDialog/components/LabeledTextField.qml
  kcms/activities/imports/qml/activityDialog/components/ShortcutChooser.qml
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
  kcms/activities/ui/MainConfigurationWidgetBase.ui
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Apply the KDE HIG, port to QQC2 and Kirigami, make the KCM look better and 
make the KCM show up in search results.
  F7248461: Improved Activities KCM UI Acitivities Tab.png 

  F7248462: Improved Activities KCM UI Switching Tab.png 

  F7248463: Improved Activities KCM UI Privacy Tab.png 


TEST PLAN
  Open the Activities KCM and change some settings. Everything that was working 
before should still work.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improved-activities-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23174

AFFECTED FILES
  kcms/activities/PrivacyTab.cpp
  kcms/activities/PrivacyTab.h
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/qml/activityDialog/GeneralTab.qml
  kcms/activities/imports/qml/activityDialog/OtherTab.qml
  kcms/activities/imports/qml/activityDialog/components/DialogButtons.qml
  kcms/activities/imports/qml/activityDialog/components/IconChooser.qml
  kcms/activities/imports/qml/activityDialog/components/LabeledTextField.qml
  kcms/activities/imports/qml/activityDialog/components/ShortcutChooser.qml
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
  kcms/activities/ui/MainConfigurationWidgetBase.ui
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22012: Clean up old bug workaround in KCMFileIndexer

[Méven Car]

meven added a comment.


  In D22012#512025 , @davidedmundson 
wrote:
  
  > It was first added in 2d5f289767ee7b7c54f8b55e8032d20ef7f092f4 
 
with some pretty sparse docs, then copy pasted all over the place.
  >
  > It does appear to be no longer needed.
  >
  > I suspect https://codereview.qt-project.org/c/qt/qtbase/+/139775 fixes it 
which was back in 5.6
  >
  > If we remove here, please can we also do
  >
  > kcms/desktoptheme/kcm.cpp:
qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  >  kcms/fonts/fonts.cpp:
qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  >  kcms/lookandfeel/kcm.cpp:
qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  >
  > in p-d
  
  
  Will do.
  
  It is also present in other apps than kcms :
  
  $ rg AA_DontCreateNativeWidgetSiblings
  systemsettings/sidebar/SidebarMode.cpp
  258:qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  
  spectacle/src/Main.cpp
  37:app.setAttribute(Qt::AA_DontCreateNativeWidgetSiblings, true);
  
  kdevelop/app/main.cpp
  348:QCoreApplication::setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  
  discover/discover/main.cpp
  97:app.setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  
  I wonder if this can be removed there as well.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22012

To: meven, mart, #plasma, davidedmundson
Cc: davidedmundson, ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D22012: Clean up old bug workaround in KCMFileIndexer

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:31b9b402f077: Clean up old bug workaround in 
KCMFileIndexer (authored by meven).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22012?vs=60397=63791

REVISION DETAIL
  https://phabricator.kde.org/D22012

AFFECTED FILES
  Modules/fileindexermonitor/kcm.cpp

To: meven, mart, #plasma, davidedmundson
Cc: davidedmundson, ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63786.
meven marked 9 inline comments as done.
meven added a comment.


  Remove unnecessary pointer use, code formatting

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63724=63786

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

ndavis added a comment.


  How likely is it for distros using Qt < 5.13 to receive an update to Breeze?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This includes things like context menus and application menus

REPOSITORY
  R31 Breeze

BRANCH
  fix-application-colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23170

AFFECTED FILES
  kstyle/breezehelper.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23169: Fix width of ToolButtonComplexControl outline w/ dropdown menu

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Apparently, the code to adjust the outline when a menu is present is what was 
causing the problem.

REPOSITORY
  R31 Breeze

BRANCH
  fix-ToolButtonComplexControl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23169

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  AFAICT this won't work on wayland and will also break the browser's native 
implementation once that actually exists.

INLINE COMMENTS

> content-script.js:22
> +// from 
> https://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript
> +function guid() {
> +return '--4xxx-yxxx-'.replace(/[xy]/g, 
> function(c) {

`generateGuid`, otherwise it looks like a getter

> content-script.js:837
> +
> +// navigator.share must only be defined in secure (https) context
> +if (!window.isSecureContext) {

Where is that documented?

> purposeplugin.cpp:43
> +{
> +delete m_menu;
> +m_menu = nullptr;

Just call `onUnload()`?

> purposeplugin.cpp:47
> +
> +bool PurposePlugin::onLoad()
> +{

Can remove this, parent class does that already.

> purposeplugin.cpp:86
> +sendPendingReply(false, {
> +{QStringLiteral("error"), QStringLiteral("CANCELED")}
> +});

Now we have `error`, `errorCode` and `errorMessage`?

> purposeplugin.cpp:131
> +
> +if (!text.isEmpty()) { // share text only
> +showShareMenu(shareJson, QStringLiteral("text/plain"));

Merge this with the same if above and put the `KIO::mimetype` query into the 
other if. Currently it would break if both `url` and `text` are empty.

> purposeplugin.cpp:144
> +
> +return {};
> +}

No response. IMO this should be handled in the plugin manager though, as 
discussed on that diff.

> purposeplugin.cpp:153
> +sendReply(m_pendingReplySerial, reply);
> +m_pendingReplySerial = 0;
> +}

0 is a valid serial...

> purposeplugin.h:57
> +
> +Purpose::Menu *m_menu = nullptr;
> +QNetworkAccessManager *m_manager = nullptr;

`std::unique_ptr`?

> purposeplugin.h:58
> +Purpose::Menu *m_menu = nullptr;
> +QNetworkAccessManager *m_manager = nullptr;
> +QPointer m_mimeReply;

Unused?

> purposeplugin.h:59
> +QNetworkAccessManager *m_manager = nullptr;
> +QPointer m_mimeReply;
> +

Unused?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> GtkEventSpy.cpp:68
> +QDateTime visited;
> +QList *applications;
> +

No need for this to be a pointer to a list. Make it just `QList 
applications`.

> GtkEventSpy.cpp:70
> +
> +Bookmark(){
> +applications = new QList();

The constructor will not be needed once `applications` stops being a pointer.

> GtkEventSpy.cpp:76
> +
> +QString Bookmark::latestApplication() const {
> +Application current = applications->first();

`{` which starts a function should be on a new line (I don't care much about 
this, but let's follow the KF5 style)

> GtkEventSpy.cpp:77-78
> +QString Bookmark::latestApplication() const {
> +Application current = applications->first();
> +for (const Application  : qAsConst(*applications)) {
> +if (app.modified > current.modified) {

When you make `applications` not to be a pointer `qAsConst` will not be needed 
as this is a `const` member function.

> GtkEventSpy.cpp:89
> +public:
> +BookmarkHandler(){
> +current = nullptr;

Replace with:

  BookmarkHandler()
  : current(nullptr)
  {
  }

> GtkEventSpy.cpp:91
> +current = nullptr;
> +marks = QList();
> +}

No need for this - marks are already default-constructed.

> GtkEventSpy.cpp:113
> +if (qName == QStringLiteral("bookmark")) {
> +current = new Bookmark();
> +current->href = QUrl(attributes.value("href"));

No need for dynamic allocation. Make it a normal variable instead of a pointer.

> GtkEventSpy.cpp:185
> +reader.setErrorHandler();
> +QXmlInputSource *source = new QXmlInputSource();
> +

No need for dynamic allocation. Make it a normal variable instead of a pointer.

> meven wrote in GtkEventSpy.cpp:143
> It is to just extract the executable name, we don't want to have an exploding 
> number of initiatingAgent for every argument and parameter that might come 
> through here.

I meant it will be a problem if someone decides to have a space in the 
executable like `my\ aweomse\ binary`. But this should not be an issue at the 
moment.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> apol wrote in purposeplugin.cpp:127
> shouldn't this be a data: url or something like that? urls should only have 
> urls

I was wondering the same but the email plugin does something very strange:

  if (url.isLocalFile()) {
  query.addQueryItem(QStringLiteral("attachment"), att.toString());
  } else {
  query.addQueryItem(QStringLiteral("body"), att.toString());
  }

> apol wrote in purposeplugin.cpp:161
> Passing application/octet-stream should work, maybe it's a bug in Purpose.

I don't see any special-casing for default mimetype in Purpose.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart