D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Also drop checking if the suffix exists, the code is only reached
  because this condition has been checked before
  
  Seen while browsing code, no app known to me which would set a non-absolute
  desktop file.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixsuffixchopping

REVISION DETAIL
  https://phabricator.kde.org/D23417

AFFECTED FILES
  libtaskmanager/startuptasksmodel.cpp

To: kossebau, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  Good question. Let me check it out.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Noah Davis]

ndavis added a comment.


  I think this looks pretty good, but why are the margins on the first item 
different from the second item?
  
  F7277492: Screenshot_20190824_194152.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham updated this revision to Diff 64527.
ngraham added a comment.


  - Fix margins and alignment
  - Put the button on a new row in the applet
  - Use the button to also show which device is currently the default, rather 
than implying it

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23389?vs=64506=64527

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23389

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/DefaultDeviceButton.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/MuteButton.qml

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  No, the margins are messed up. I can fix them in this patch since it becomes 
more obvious.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Noah Davis]

ndavis added a comment.


  In D23389#518275 , @ngraham wrote:
  
  > In D23389#518269 , @ndavis wrote:
  >
  > > Maybe we can add another line to the device item for the button to go on? 
Seems like it might just add visual bloat, but I can't actually think of a 
concrete reason why it would be bad. It could contain some small amount of 
useful info too, or maybe more controls from the hamburger menu.
  >
  >
  > Like this?
  >  F7276812: Screenshot_20190824_130825.png 

  
  
  Yes, although it feels a bit cramped. Does it have the correct margins?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22176: Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  @nicolasfella Correct me if I'm wrong. EntryModel is created on the first use 
and it is populated in the constructor. If user runs application that uses 
StatusNotifier (for example Skype, Dropbox, Electron apps, any Windows app via 
Wine, etc) later, it won't be added to configuration list.
  
  I was working on very similar feature:
  https://phabricator.kde.org/D23413 
  It is used for rendering so it already has dynamic update implemented. Right 
now it is not suitable for configuration because it contains only items to be 
rendered (active). It should be very easy to add disabled items. Then one model 
can be used for both configuration and rendering!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23414: Remove font configuration from GTK KCM

[Mikhail Zolotukhin]

gikari updated this revision to Diff 64524.
gikari added a comment.


  Fix

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23414?vs=64522=64524

BRANCH
  remove-font-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23414

AFFECTED FILES
  CMakeLists.txt
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk3.cpp
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/fontshelpers.cpp
  src/fontshelpers.h
  src/gtkconfigkcmodule.cpp
  src/ui/gui.ui
  tests/configsavetest.cpp

To: gikari, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23414: Remove font configuration from GTK KCM

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> ngraham wrote in gui.ui:460
> Looks unrelated

Hm strange, I only deleted font widgets from Qt Creator. I will fix that 
manually.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D23414

To: gikari, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23413: [System Tray] Unified data model for System Tray items

[Konrad Materka]

kmaterka added a comment.


  I spent some time testing it and I hope it is now bug free. I understand it 
is a big change that brings little value (now), but I'm working on further 
improvements and wanted to slip work into smaller patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23413

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23414: Remove font configuration from GTK KCM

[Nathaniel Graham]

ngraham added reviewers: apol, Plasma.
ngraham added inline comments.

INLINE COMMENTS

> gui.ui:460
> +
> + ..
> 

Looks unrelated

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D23414

To: gikari, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23413: [System Tray] Unified data model for System Tray items

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Currently there are two different sources of SystemTray items:
  
  - Plasmoids
  - Status Notifier
  
  Both are implemented independently, which makes hard to implement features 
that should cover both types.
  
  This is a first step in bigger rework that should allow easy ordering, 
filtering etc.

TEST PLAN
  Almost all features can be affected, so everything needs to be tested.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23413

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23414: Remove font configuration from GTK KCM

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Since gtk font settings is now set from Fonts KCM,
  there is no need to configure font separately in
  GTK Configuration KCM.
  
  Depends on D21860 

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  remove-font-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23414

AFFECTED FILES
  CMakeLists.txt
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk3.cpp
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/fontshelpers.cpp
  src/fontshelpers.h
  src/gtkconfigkcmodule.cpp
  src/ui/gui.ui
  tests/configsavetest.cpp

To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari updated this revision to Diff 64517.
gikari added a comment.


  Create a Gtk Config kded module
  
  To actually apply settings to gtk applications DBus call
  should have a reciever. This creates it as kded module.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21860?vs=64342=64517

BRANCH
  set-gtk-font-in-fonts-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21860

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGSettingSchemas.cmake
  cmake/modules/FindGTK2.cmake
  cmake/modules/FindGTK3.cmake
  gtkconfig/CMakeLists.txt
  gtkconfig/gtk2apps_reloader/CMakeLists.txt
  gtkconfig/gtk2apps_reloader/gtk2reloader.c
  gtkconfig/kded/CMakeLists.txt
  gtkconfig/kded/configeditor.cpp
  gtkconfig/kded/configeditor.h
  gtkconfig/kded/gtkconfig.cpp
  gtkconfig/kded/gtkconfig.h
  gtkconfig/kded/gtkconfig.json
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D23241: Show application window icon on AboutPage

[Casper Meijn]

caspermeijn marked an inline comment as done.
caspermeijn added inline comments.

INLINE COMMENTS

> apol wrote in settings.h:81
> It could make sense to include the REVISION part:
> https://doc.qt.io/qt-5/properties.html

I have no idea what the value would be for that and Kirigami doesn't have any 
example.

REPOSITORY
  R169 Kirigami

BRANCH
  about_icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23241

To: caspermeijn, mart, apol, #kirigami, hein
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23241: Show application window icon on AboutPage

[Casper Meijn]

caspermeijn updated this revision to Diff 64512.
caspermeijn added a comment.


  Fixed since version number

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23241?vs=63975=64512

BRANCH
  about_icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23241

AFFECTED FILES
  src/controls/AboutPage.qml
  src/settings.cpp
  src/settings.h

To: caspermeijn, mart, apol, #kirigami, hein
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

[Nathaniel Graham]

ngraham added a comment.


  @davidedmundson ping. I fixed one issue but may need a bit of help for the 
one about the weird sizing for the button grid component.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson, GB_2
Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  In D23389#518269 , @ndavis wrote:
  
  > Maybe we can add another line to the device item for the button to go on? 
Seems like it might just add visual bloat, but I can't actually think of a 
concrete reason why it would be bad. It could contain some small amount of 
useful info too, or maybe more controls from the hamburger menu.
  
  
  Like this?
  F7276812: Screenshot_20190824_130825.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  In D23389#518270 , @alexde wrote:
  
  > > for various technical reasons that are not yet fixable
  >
  > Can you please point me to those? Is there ongoing work? I'm curious.
  
  
  Basically, we need to delete the Phonon KCM first, because the Phonon and 
PulseAudio KCMs each set conflicting PulseAudio modules. In order to have 
switch-on-connect be the default, plasma-pa needs to be in control, which means 
deleting the Phonon KCM. It's in progress. See T9091 
 and D22616 
. For background information that led to my 
understanding of this issue, see the discussion in 
https://bugs.kde.org/show_bug.cgi?id=392103 and 
https://bugs.kde.org/show_bug.cgi?id=392117.
  
  Also, even after we do have the ability, I anticipate that doing 
switch-on-connect by default may be controversial, so it's not a done deal 
either.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Alex Debus]

alexde added a comment.


  > for various technical reasons that are not yet fixable
  
  Can you please point me to those? Is there ongoing work? I'm curious.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Noah Davis]

ndavis added a comment.


  Maybe we can add another line to the device item for the button to go on? 
Seems like it might just add visual bloat, but I can't actually think of a 
concrete reason why it would be bad. It could contain some small amount of 
useful info too.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  In D23389#518259 , @ndavis wrote:
  
  > Maybe we should just keep the "Make Default" button in the hamburger menu? 
It's less visible, but we don't have much space and it's usually not as 
important as the device name and volume slider.
  
  
  It's very important the moment you plug in a second device because we don't 
have "switch on connect" as the default behavior (for various technical reasons 
that are not yet fixable). Again, users aren't finding it in the hamburger menu.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Noah Davis]

ndavis added a comment.


  Maybe we should just keep the "Make Default" button in the hamburger menu? 
It's less visible, but we don't have much space and it's usually not as 
important as the device name and volume slider. We can keep the "Make Default" 
button in the audio KCM.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Alex Debus]

alexde added a comment.


  > DnD is not very intuitive for things that don't look inherently draggable
  
  That's why I draw a frame around the entries and also the mouse pointer could 
change to a hand. Otherwise I neither really like 1) or 2). How do other 
systems handle this?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  We already have a drag-and-drop UI for determining the default and nobody has 
ever figured it out. :) DnD is not very intuitive for things that don't look 
inherently draggable, or that people have become accustomed to dragging (like 
files and folders in a file manager).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Alex Debus]

alexde added a comment.


  Just brainstorming: What about two sections, 1) "default" with a single entry 
and 2) "others". 
  The user could drag and drop the speaker to default place and the current 
default one would move downwards with an animation.F7276701: 
Screenshot_20190824_201127.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  Well, we're at an impasse then.
  
  1. When the button is on the top row, if it's really long, it intrudes on and 
elides the device name
  2. When the button is on the bottom row, it shortens the volume slider
  3. If the button has no text, it's not clear what it does, and there's no 
real point to doing this in the first place
  
  Does anyone have any alternative ideas, or should we live with 1 or 2?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  I'm not using an icons-only button here. It wouldn't be clear; we need text. 
I understand with with certain languages, the text could be long. But without 
text there's no point to this feature, because it no longer solves the problem.
  
  If the UI becomes too crammed as a result, we could consider resizing the 
pop-up.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Noah Davis]

ndavis added a comment.


  In D23389#518211 , @ngraham wrote:
  
  > I'm also not a fan of icons-only buttons, because their meaning is 
ambiguous unless the icon is //perfect//. And we don't have a perfect icon 
here. We could try moving the button down to the next row: F7276552: 
Screenshot_20190824_112852.png 
  >
  > Even then, in Russian (from Google Translate at least), the text is quite 
long: F7276554: Screenshot_20190824_113117.png 

  >
  > I can add a note for translators that this string should be kept as short 
as possible.
  >
  > Would moving the button to the second row work better? What do people think?
  
  
  Even in English, I don't think that's a good button placement. The volume 
slider should definitely not be shortened. My headphones are usually only 
comfortable around 40% volume or less, so that significantly shortens the 
usable area of the slider. From the look of your settings, it looks like it's 
the same for you.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham updated this revision to Diff 64506.
ngraham added a comment.


  Move button to second row where it won't be so obtrusive for languages where 
the text is really long

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23389?vs=64490=64506

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23389

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/DefaultDeviceButton.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/MuteButton.qml

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 105 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/105/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 24 Aug 2019 18:09:25 +
 Build duration:
2 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report11%
(2/19)5%
(7/134)5%
(7/134)4%
(464/12799)2%
(178/8605)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskcm0%
(0/1)0%
(0/1)0%
(0/305)0%
(0/210)kded0%
(0/12)0%
(0/12)0%
(0/1280)0%
(0/946)libs0%
(0/4)0%
(0/4)0%
(0/897)0%
(0/491)libs.declarative0%
(0/7)0%
(0/7)0%
(0/600)0%
(0/459)libs.editor36%
(4/11)36%
(4/11)27%
(212/797)22%
(163/752)libs.editor.settings0%
(0/21)0%
(0/21)0%
(0/2997)0%
(0/1948)libs.editor.widgets0%
(0/17)0%
(0/17)0%
(0/981)0%
(0/426)libs.models0%
(0/9)0%
(0/9)0%
(0/1420)0%
(0/1199)tests100%
(3/3)100%
(3/3)100%
(252/252)63%
(15/24)vpn.fortisslvpn0%
(0/5)0%
(0/5)0%
(0/150)0%
(0/70)vpn.iodine0%
(0/4)0%
(0/4)0%
(0/96)0%
(0/38)vpn.l2tp0%
(0/6)0%
(0/6)0%
(0/341)0%
(0/181)vpn.openswan0%
(0/4)0%
(0/4)0%
(0/159)0%
(0/102)vpn.openvpn0%
(0/5)0%
(0/5)0%
(0/1224)0%
(0/1047)vpn.pptp0%
(0/5)0%
(0/5)0%
(0/207)0%
(0/89)vpn.ssh0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/131)vpn.sstp0%
(0/5)0%
(0/5)0%
(0/244)0%
(0/117)vpn.strongswan0%
(0/5)0%
(0/5)0%
(0/140)0%
(0/71)vpn.vpnc0%
(0/5)0%
  

D23389: Use "Make default" buttons to switch the default device

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D23389#518211 , @ngraham wrote:
  
  > I can add a note for translators that this string should be kept as short 
as possible.
  
  
  Furthermore in bulgarian is even longer, there is no short word that fits 
"default" which can lead to stupid word cuts. What I can say, from my 
experience in other projects, you shouldn't add more than a word in button 
unless you want to became a fat, long, ugly, etc. That's way Android, many 
projects adds icons to every action to keep text out of the buttons.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22832: Fix build with pango 1.44

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:cf8db4ebe5ef: Fix build with pango 1.44 (authored by 
arojas).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22832?vs=62800=64505

REVISION DETAIL
  https://phabricator.kde.org/D22832

AFFECTED FILES
  cmake/modules/FindGTK3.cmake

To: arojas, #plasma, ngraham
Cc: ngraham, apol, sitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  In D23198#518001 , @dfaure wrote:
  
  > What I mean is:
  >
  > 1. improve KFileItem::isSlow to use this Solid code
  > 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if 
isSlow is true
  
  
  Sorry I misread you.
  
  > However maybe we don't want that in dolphin? Not sure. (In that case a new 
enum value can be added, to disable some features "if slow".)
  
  That could be a good idea, allowing users to prevent freezes.
  
  > In any case I see no reason for this code to be in recentusagemodel, it's 
just one out of many KFileItem users, with similar needs as most others.
  
  Yes I thought so, https://phabricator.kde.org/D23198#516506
  
  I really don't like the "isSlow" naming, it hides its meaning, 
"isNetworkMounted" or similar would be more descriptive IMHO.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham added a comment.


  I'm also not a fan of icons-only buttons, because their meaning is ambiguous 
unless the icon is //perfect//. And we don't have a perfect icon here. We could 
try moving the button down to the next row: F7276552: 
Screenshot_20190824_112852.png 
  
  Even then, in Russian (from Google Translate at least), the text is quite 
long: F7276554: Screenshot_20190824_113117.png 

  
  I can add a note for translators that this string should be kept as short as 
possible.
  
  Would moving the button to the second row work better? What do people think?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  In D23198#518001 , @dfaure wrote:
  
  > What I mean is:
  >
  > 1. improve KFileItem::isSlow to use this Solid code
  > 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if 
isSlow is true
  
  
  Sorry I misread you.
  
  > However maybe we don't want that in dolphin? Not sure. (In that case a new 
enum value can be added, to disable some features "if slow".)
  
  That could be a good idea, allowing users to prevent freezes.
  
  > In any case I see no reason for this code to be in recentusagemodel, it's 
just one out of many KFileItem users, with similar needs as most others.
  
  Yes I thought so, https://phabricator.kde.org/D23198#516506
  
  I really don't like the "isSlow" naming, it hides its meaning, network 
filesystem aren't necessarly slow, "isNetworkMounted" or similar would be more 
descriptive IMHO.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22832: Fix build with pango 1.44

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Just ran into the same issue today and prepared a similar patch right before 
getting a notification email about this! Let's do it for the stable branch for 
sure.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma, ngraham
Cc: ngraham, apol, sitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23389: Use "Make default" buttons to switch the default device

[Noah Davis]

ndavis added a comment.


  Not a fan of icon only buttons for uncommon tasks, but if saving space ever 
becomes absolutely necessary, we could use the star icon for "Make Default" 
instead of having text.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22832: Fix build with pango 1.44

[Antonio Rojas]

arojas added a comment.


  Ping, can this go in for 5.16.5?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma
Cc: apol, sitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23389: Use "Make default" buttons to switch the default device

[Anthony Fieroni]

anthonyfieroni added a comment.


  My big concern is that translated text is mainly not too big in English but 
in other lang. Even we change it to "Default Out" (since it has a label 
"Outputs").

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Nathaniel Graham]

ngraham updated this revision to Diff 64490.
ngraham added a comment.


  Make one more ToolButton into a button, just like in the Applet

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23389?vs=64489=64490

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23389

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/DefaultDeviceButton.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/MuteButton.qml

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Nathaniel Graham]

ngraham updated this revision to Diff 64489.
ngraham added a comment.


  Do the same thing for the KCM

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23389?vs=64478=64489

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23389

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/DefaultDeviceButton.qml
  src/kcm/package/contents/ui/DeviceListItem.qml

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Nathaniel Graham]

ngraham added a comment.


  Should be changed there too; that's an inappropriate use of radio buttons. 
One doesn't even have a label so you have no idea what it does.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Anthony Fieroni]

anthonyfieroni added a comment.


  But in settings is radio button
  F7276400: Screenshot_20190824_185610.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23401: Fix scroll control (add -P option)

[Nathaniel Graham]

ngraham added a comment.


  There's an already-submitted patch to fix that includes backwards 
compatibility: D23330 

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23401

To: srenaud, martinkostolny
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23401: Fix scroll control (add -P option)

[Sylvain Renaud]

srenaud created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
srenaud requested review of this revision.

REVISION SUMMARY
  I find out that the screen gets darker every time I'm using the scroll 
control, no matter the direction. It has been mentionned here [[ 
https://github.com/kotelnik/plasma-applet-redshift-control/issues/55 | 
https://github.com/kotelnik/plasma-applet-redshift-control/issues/55
  
  I fixed that by using the `-P` option to the `redshiftOneTimeCommand`.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23401

AFFECTED FILES
  package/contents/ui/main.qml

To: srenaud
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21524: Keep existing configurations' strings

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:a9f3a3ddcb0b: Keep existing configurations strings   
 (authored by gikari, committed by ngraham).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21524?vs=63142=64479

REVISION DETAIL
  https://phabricator.kde.org/D21524

AFFECTED FILES
  src/appearancegtk2.cpp
  src/appearancegtk2.h

To: gikari, apol, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21470: Properly read stderr when data is ready from the daemon.

[Luca Carlon]

luc4 added a comment.


  Ping.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21470

To: luc4, davidedmundson, mlaurent, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Nathaniel Graham]

ngraham added a comment.


  FWIW we implemented the same UI in Discover to solve the same problem (people 
didn't know how to set/change the default backend when multiple were present) 
and since then, we haven't had any user complaints at all.
  
  F7276043: Screenshot_20190824_065332.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Nathaniel Graham]

ngraham updated this revision to Diff 64478.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use Title Case for button text

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23389?vs=64450=64478

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23389

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[David Faure]

dfaure added a comment.


  What I mean is:
  
  1. improve KFileItem::isSlow to use this Solid code
  2. improve KFileItem to enable SkipMimeTypeFromContent automatically if 
isSlow is true
  
  However maybe we don't want that in dolphin? Not sure. (In that case a new 
enum value can be added, to disable some features "if slow".)
  
  In any case I see no reason for this code to be in recentusagemodel, it's 
just one out of many KFileItem users, with similar needs as most others.
  
  (And all this is the reason I hate network mounts, and the much-requested 
fuse-kio integration... what looks like a local path ends up being unusable as 
a local path and needs special treatment anyway...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  In D23198#517980 , @dfaure wrote:
  
  > Why not do this in KFileItem::isSlow() itself?
  >  (and enable SkipMimeTypeFromContent when isSlow is true)
  
  
  First because KFileItem::isSlow is a member function of KFileItem and this 
code is used to select the correct constructor of KFileItem in the first 
place...
  Second I already tried using KFileItem::isSlow method i.e 
KFileSystemType::fileSystemType and statvfs syscall in a previous attempt in 
this diff and it was not usable for this context :
  statvfs block the thread in case of a stale network mount until the network 
is back up (case of a nfs mounted when network is cut).
  Meaning it would freeze plasmashell when the case occurred, and shows that 
KFileItem::isSlow/KFileSystemType::fileSystemType cause freezes whenever they 
are used for a file on a network stale mount.
  
  This new method is actually implementing what I suggested in 
https://phabricator.kde.org/D19784#502503

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> ListItemBase.qml:120
> +PlasmaComponents.Button {
> +text: i18n("Make default")
> +onClicked: PulseObject.default = true;

According to the HIG, this should have title style capitalization.
https://hig.kde.org/style/writing/capitalization.html

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Noah Davis]

ndavis added a comment.


  In D23389#517826 , @anthonyfieroni 
wrote:
  
  > Why not it's a checkbox ? Make default looks big.
  
  
  You can only have 1 default, but there are multiple devices, so the check box 
would have to be a radio button instead. However, a radio button would look 
strange in a list like that. You'd still need a label to show what radio button 
does, so you'd be better off with a button.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[David Faure]

dfaure added a comment.


  Why not do this in KFileItem::isSlow() itself?
  (and enable SkipMimeTypeFromContent when isSlow is true)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-nm » stable-kf5-qt5 SUSEQt5.12 - Build # 52 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/stable-kf5-qt5%20SUSEQt5.12/52/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 24 Aug 2019 08:51:25 +
 Build duration:
3 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report11%
(2/19)5%
(7/132)5%
(7/132)4%
(464/12647)2%
(178/8532)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskcm0%
(0/1)0%
(0/1)0%
(0/310)0%
(0/212)kded0%
(0/12)0%
(0/12)0%
(0/1279)0%
(0/946)libs0%
(0/4)0%
(0/4)0%
(0/864)0%
(0/474)libs.declarative0%
(0/6)0%
(0/6)0%
(0/585)0%
(0/449)libs.editor36%
(4/11)36%
(4/11)27%
(212/797)22%
(163/752)libs.editor.settings0%
(0/21)0%
(0/21)0%
(0/2946)0%
(0/1942)libs.editor.widgets0%
(0/17)0%
(0/17)0%
(0/981)0%
(0/426)libs.models0%
(0/8)0%
(0/8)0%
(0/1370)0%
(0/1161)tests100%
(3/3)100%
(3/3)100%
(252/252)63%
(15/24)vpn.fortisslvpn0%
(0/5)0%
(0/5)0%
(0/143)0%
(0/66)vpn.iodine0%
(0/4)0%
(0/4)0%
(0/96)0%
(0/38)vpn.l2tp0%
(0/6)0%
(0/6)0%
(0/341)0%
(0/181)vpn.openswan0%
(0/4)0%
(0/4)0%
(0/159)0%
(0/102)vpn.openvpn0%
(0/5)0%
(0/5)0%
(0/1224)0%
(0/1047)vpn.pptp0%
(0/5)0%
(0/5)0%
(0/207)0%
(0/89)vpn.ssh0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/131)vpn.sstp0%
(0/5)0%
(0/5)0%
(0/244)0%
(0/117)vpn.strongswan0%
(0/5)0%
(0/5)0%
(0/140)0%
(0/71)vpn.vpnc0%
(0/5)0%
  

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 added a comment.


  Anyone?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21524: Keep existing configurations' strings

[Mikhail Zolotukhin]

gikari added a comment.


  In D21524#517780 , @apol wrote:
  
  > Do you have push powers?
  
  
  No, I don't have.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  arcpatch-D21524

REVISION DETAIL
  https://phabricator.kde.org/D21524

To: gikari, apol, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Méven Car]

meven created this revision.
meven added reviewers: broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Depends on D23157 

TEST PLAN
  Compiles
  Need to be tested on kde neon

REPOSITORY
  R102 KInfoCenter

BRANCH
  add-technology

REVISION DETAIL
  https://phabricator.kde.org/D23392

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23391: Clean up not needed Q_INVOKABLE

[Méven Car]

meven created this revision.
meven added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  As suggested by https://phabricator.kde.org/D23152#inline-132069

TEST PLAN
  It runs fine

REPOSITORY
  R102 KInfoCenter

BRANCH
  clean-up

REVISION DETAIL
  https://phabricator.kde.org/D23391

AFFECTED FILES
  Modules/energy/batterymodel.cpp
  Modules/energy/batterymodel.h
  Modules/energy/kcm.cpp
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Anthony Fieroni]

anthonyfieroni added a comment.


  Why not it's a checkbox ? Make default looks big.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart