D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar

apol added inline comments. INLINE COMMENTS > ActionToolBar.qml:183 > +} > +return result; > } it could be `children: [].concat(root.actions).concat(hiddenActions);` no? > ActionToolBar.qml:207 > > -onObjectAdded:

D23509: [shell/panelconfigview] Port old-style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23508: [dataengines/apps] Port old style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles. Not sure anything uses it REPOSITORY R120 Plasma Workspace REVISION

D23506: [dataengines/favicons] Port old-style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles. Not sure what uses it? REPOSITORY R120 Plasma Workspace BRANCH

D23499: Fix context menu button for pages not showing up

This revision was automatically updated to reflect the committed changes. Closed by commit R169:75652ff0f9af: Fix context menu button for pages not showing up (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23499?vs=64750=64763

D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar

ahiemstra created this revision. ahiemstra added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY With the fixes done to PrivateActionToolBar it now behaves a lot nicer and we

D23501: If a submenu action has an icon set, make sure to also display it

ahiemstra created this revision. ahiemstra added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY QQC2's Menu does not support icons, but the MenuItem that gets created when it

D23499: Fix context menu button for pages not showing up

ahiemstra created this revision. ahiemstra added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY fd8fec5b

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#520185 , @GB_2 wrote: > In D23274#520127 , @mart wrote: > > > SidebarMode::setActiveCategory may need to be modified to make it like it tough > > > Looks like

D23463: Fix PrivateActionToolButton with menu not clearing checked state properly

This revision was automatically updated to reflect the committed changes. Closed by commit R169:7fe5a47ec705: Fix PrivateActionToolButton with menu not clearing checked state properly (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D23382: Add vmPSS to Process and display it as "total memory" column

This revision was automatically updated to reflect the committed changes. Closed by commit R111:3a28505384fb: Add vmPSS to Process and display it as total memory column (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D23413: [System Tray] Unified data model for System Tray items

nicolasfella added a comment. Seems to work fine for me, but someone else should comment on the code REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23413 To: kmaterka, #plasma, broulik Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23494: Replicate Shift+Enter for action invocation for history as well

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This was missing from the `ResultsList`, just copied it over. BUG: 411350 FIXED-IN: 5.16.5

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. In D23274#520127 , @mart wrote: > SidebarMode::setActiveCategory may need to be modified to make it like it tough Looks like it. INLINE COMMENTS > SidebarMode.cpp:498 > +if (introPageVisible) { > +

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham added a comment. I'm quite interested getting the rewritten UI and Wayland fractional scaling in ASAP (VDG can always tweak and polish the UI once it's landed). However according to https://community.kde.org/Schedules/Plasma_5, the Frameworks dependency version for Plasma 5.17

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. I just looked at the release schedule of frameworks and it will be difficult to get the required output duplication changes in KWayland 5.62 (tagging date 7th September), which Plasma 5.17 will depend on. Question is if we want to merge even without output

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. FYI: I'm currently working on output duplication (and some preparations for that in KWin/KWayland) and will wait until this works fine before pushing this rewrite. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham accepted this revision as: VDG. ngraham added a comment. (provided the UI tweaks can be made later) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin, #vdg Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. SidebarMode::setActiveCategory may need to be modified to make it like it tough REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#519661 , @GB_2 wrote: > This is what happens when you set the current index to -1: F7282553: System Settings Sidebar Show Intro Page Button Bug.png did you also try

D13849: WIP: Add fractional scaling to wayland scaling GUI

ngraham added a comment. In D13849#520033 , @fufud wrote: > Could this be merged, please? Fractional scaling is one of few things holding people back from using Wayland (including me). > Also, could it be a slider, like in X11? I prefer 1.8

D23488: Explicitly initialize KCrash

This revision was automatically updated to reflect the committed changes. Closed by commit R856:a47188f68ccb: Explicitly initialize KCrash (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23488?vs=64732=64734 REVISION

D23488: Explicitly initialize KCrash

broulik created this revision. broulik added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Compiles REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D23487: kcrash must be used else it will not be linked and crashes will crash instead of kcrashing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cc9b2f2b6552: kcrash must be used else it will not be linked and crashes will crash instead… (authored by jriddell). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23487: kcrash must be used else it will not be linked and crashes will crash instead of kcrashing

jriddell added a comment. kcrash use was removed in https://phabricator.kde.org/D17011 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23487 To: jriddell Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23487: kcrash must be used else it will not be linked and crashes will crash instead of kcrashing

jriddell created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jriddell requested review of this revision. REVISION SUMMARY kcrash must be used else it will not be linked and crashes will crash instead of kcrashing REPOSITORY R120 Plasma Workspace

D13849: WIP: Add fractional scaling to wayland scaling GUI

fufud added a comment. Could this be merged, please? Fractional scaling is one of few things holding people back from using Wayland (including me). Also, could it be a slider, like in X11? I prefer 1.8 scaling, but this PR only adds the options to set 1.0, 1.25, 1.5, 1.75 and 2.0 scaling.

Plasma BoF at Akademy

Hi all, for everybody that plans being present at the plasma Bof at Akademy, I made an etherpad https://notes.kde.org/p/Akademy2019PlasmaBof if (and only if) you plan to be there, please add topics you would like being discussed (with your name near the point) -- Marco Martin

D23288: Move XResources out of the central model into a plugin

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xres.h:1 > I've used #pragma once all over the place already, hasn't seemed to cause an > issue. I use it quite a lot as well. If it has problems better to know it before it spreads too much ;) is not standard but appears

D22176: Rework system tray settings

kmaterka added a comment. In D22176#519600 , @nicolasfella wrote: > I think QQC1 TableView and the new TableView are quite different things. I had some issues with the QQC1 TableView and my new Model, so I decided to use something else, but I