D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R98 Breeze for Gtk BRANCH checks-and-radios (branched from master) REVISION DETAIL https://phabricator.kde.org/D23547 To: cblack, #breeze, ndavis Cc: ndavis,

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

cblack updated this revision to Diff 64909. cblack added a comment. Fix the rest of those SVGs REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64906=64909 BRANCH checks-and-radios (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

ndavis added a comment. In D23547#521618 , @cblack wrote: > In D23547#521615 , @ndavis wrote: > > > I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

cblack added a comment. In D23547#521615 , @ndavis wrote: > I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

ndavis added a comment. I should have been more clear, but I meant all of the SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other versions. The Window buttons should go back to being 18px. REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. Here are some more UI possibilities I've been thinking of: - Instead of using pushbuttons, make them checkable toggle buttons, with the checked one being default - Go even farther and make the device icons into checkable buttons and badge the checked/default

D23389: Use "Make default" buttons to switch the default device

ngraham updated this revision to Diff 64908. ngraham added a comment. Use Correct Capitalization REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23389?vs=64527=64908 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23389

D23389: Use "Make default" buttons to switch the default device

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in ListItemBase.qml:231 > What about always showing the icon? I tried that, but it looked sort of weird. I kind of like how the presence of the icon helps to show what's the default device.

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

cblack updated this revision to Diff 64906. cblack added a comment. Use provided SVGs REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64900=64906 BRANCH checks-and-radios (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

ndavis added a comment. F7290223: breeze-radio-indeterminate-symbolic.svg REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23547 To: cblack, #breeze, ndavis Cc: ndavis, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

ndavis added a comment. Here, this is a pixel perfect version. F7290158: breeze-check-indeterminate-symbolic.svg REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23547 To: cblack, #breeze, ndavis Cc: ndavis, ngraham,

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

ndavis added a comment. These SVGs don't quite line up with the grid, which causes the inner part to have slightly blurry edges. F7290120: Screenshot_20190828_182238.png REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D23520: Add time line to X axis

ngraham added a reviewer: Plasma. ngraham added a comment. Wuh-oh, there's something wrong with the date display now: F7290108: Screenshot_20190828_161810.png REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23520 To:

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

cblack updated this revision to Diff 64900. cblack added a comment. Update based off of feedback REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64894=64900 BRANCH checks-and-radios (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I've already said this to you in the VDG chat, but just to prevent confusion for other people, I'll repeat it here. These buttons are 18x18, but they are 16x16 with the Qt

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

ngraham added inline comments. INLINE COMMENTS > _checkboxes.scss:10 > +// background-color: transparent; > +// } > Commented-out code should be deleted entirely REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23547 To: cblack, #breeze Cc: ngraham,

D23520: Add time line to X axis

alexde updated this revision to Diff 64896. alexde added a comment. Improve the formatting's consistancy REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64892=64896 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

cblack updated this revision to Diff 64894. cblack added a comment. Change from hover color to focus color REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64893=64894 BRANCH checks-and-radios (branched from master) REVISION DETAIL

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Checkboxes and radiobuttons are now recolored according to the user's colour tastes. REPOSITORY

D23520: Add time line to X axis

alexde updated this revision to Diff 64892. alexde added a comment. Update comment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64890=64892 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 64890. alexde added a comment. Omit the date if date equals today and the graph does not range over 24 hours. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64889=64890 BRANCH energy-timeline (branched

D23520: Add time line to X axis

alexde updated this revision to Diff 64889. alexde added a comment. Resolve formatting issues - remove semicolons - replace tab indention by 4 spaces - add space between operator and arguments REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D23520: Add time line to X axis

alexde added a comment. > As you can see, it's kind of funny that only one of the labels has a date under it. This is fine for the multi-day graphs, but for the graphs that are entirely within the current day, I would recommend omitting the date. There's actually not such thing as a

D21860: Set a font for gtk applications in the fonts kcm

gikari added inline comments. INLINE COMMENTS > davidedmundson wrote in fonts.cpp:607 > There are two designs which are both sensible: > > 1. we have a daemon that runs all the time so that it can listen for changes. > When that happens it syncs things > > 2. something that the fonts module

D23542: Promote KCM to top level and rename accordingly

ngraham added inline comments. INLINE COMMENTS > ndavis wrote in module.cpp:39 > Why are we changing the title to just "Audio"? Weren't we supposed to use > descriptions for the page titles to make them useful? Am I mistaken? Our conclusion before was to make the page title match the title

D23542: Promote KCM to top level and rename accordingly

ndavis added a comment. +1 INLINE COMMENTS > module.cpp:39 > KAboutData *aboutData = new KAboutData("kcm_pulseaudio", > - i18nc("@title", "Configure the > Audio Volume"), > + i18nc("@title", "Audio"), >

D23389: Use "Make default" buttons to switch the default device

GB_2 added inline comments. INLINE COMMENTS > ListItemBase.qml:230 > +PlasmaComponents.Button { > +text: PulseObject.default ? i18n("Default device") : > i18n("Make Default") > +iconName: PulseObject.default ? "favorite" : ""

D23389: Use "Make default" buttons to switch the default device

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D23389#521086 , @ngraham wrote: > Haven't had luck figuring out where this extra margin is coming from. given that it's already there,

D23520: Add time line to X axis

ngraham added a comment. Nice! Only showing the date once per day is clever, but it can be even more clever: when all of the times in the graph correspond to the current day, there's no need to show it at all. You can see this issue in this screenshot: F7289397:

D23509: [shell/panelconfigview] Port old-style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:756b141a431f: [shell/panelconfigview] Port old-style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23508: [dataengines/apps] Port old style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:51d5801fe02e: [dataengines/apps] Port old style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23508?vs=64768=64874

D23506: [dataengines/favicons] Port old-style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:07d0ed7e0703: [dataengines/favicons] Port old-style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23542: Promote KCM to top level and rename accordingly

ngraham updated this revision to Diff 64871. ngraham added a comment. Be less redundant REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23542?vs=64870=64871 BRANCH promote-audio-kcm (branched from master) REVISION DETAIL

D23542: Promote KCM to top level and rename accordingly

nicolasfella added inline comments. INLINE COMMENTS > kcm_pulseaudio.desktop:14 > > -Name=Audio Volume > +Name=Audio & Sound > Name[ar]=مستوى الصّوت Is there a (significant) difference between Audio and Sound? Otherwise I'd go with just 'Audio' REPOSITORY R115 Plasma Audio Volume Applet

D23542: Promote KCM to top level and rename accordingly

ngraham added a comment. Hmm, maybe that one should go to the top level too. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23542 To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23542: Promote KCM to top level and rename accordingly

nicolasfella added a comment. +1 in general. Please note that k3b ships the 'CDDB retrieval' KCM, which is in the Multimedia section as well REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23542 To: ngraham, #vdg, #plasma, drosca,

D23542: Promote KCM to top level and rename accordingly

ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now that the Phonon KCM has been removed, there's no longer a need to put the

D23345: Fix mpris plugin in Firefox when Content-Security-Policy is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R856:a14c58b1d5f2: Fix mpris plugin in Firefox when Content-Security-Policy is enabled (authored by ognarb). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D22767: Calculate first clickable point, from the top-left

This revision was automatically updated to reflect the committed changes. Closed by commit R120:989a7759a969: Calculate first clickable point, from the top-left (authored by kmaterka, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23461: Remove 'magic' filtering of recent apps

tcanabrava added a comment. @ngraham I agree with you completely. it's basically removing a bit of code, smaller patch and the code behaves without surprises. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc:

D23461: Remove 'magic' filtering of recent apps

ngraham added a comment. In general I'm not a big fan of this kind of pseudo-smart behavior. Unless it's **perfect,** the smartness winds up looking buggy in various cases. I'm in favor of removing the behavior entirely. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham added a comment. Never mind, that was apparently a just-corrected typo (https://community.kde.org/index.php?title=Schedules%2FPlasma_5=revision=85944=85406), and the dependency will be 5.62. Given that, if there's not enough time to get the frameworks changes in, I would be in

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. Haven't had luck figuring out where this extra margin is coming from. given that it's already there, could we tackle that in a follow-up patch? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca,

D23520: Add time line to X axis

alexde updated this revision to Diff 64840. alexde added a comment. Set more sane left/right margins REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64805=64840 BRANCH energy-timeline (branched from master) REVISION DETAIL

D21619: Wallpaper: delay calling UIReady until the image is actually loaded

davidedmundson abandoned this revision. davidedmundson added a comment. Kai pushed an identical patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21619 To: davidedmundson, #plasma, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23461: Remove 'magic' filtering of recent apps

davidedmundson added inline comments. INLINE COMMENTS > recentusagemodel.cpp:522 > +if (auto model = > qobject_cast(sourceModel())) { > +model->setShowAllRecents(m_showAllRecents); > +m_showAllRecents = recents; If this is called before refresh model will be

D23469: Move the notifier logic into a separate process

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:dd07d9c774f4: Move the notifier logic into a separate process (authored by apol). REPOSITORY R134 Discover Software

D23461: Remove 'magic' filtering of recent apps

tcanabrava updated this revision to Diff 64818. tcanabrava added a comment. - Revert "Remove filtering of recent apps that are in the favorites" - Add a new Q_PROPERTY to the Recents Model to filter out or not favorites REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Plasma 5.17 Qt and KF5 version

Plasma 5.17 is due for a beta on September 19th. We decided to support Qt 5.12 and Qt 5.13 with this version. The KDE Frameworks version we will support is 5.62 due for tars/tags on Sat September 7, 2019 (10 days away). Jonathan

D22616: Remove phonon KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:973306c7bb7d: Remove phonon KCM (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22616?vs=64811=64813 REVISION DETAIL

D22616: Remove phonon KCM

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Good to land. Phonon 4.11 replaces this KCM with a new phononsettings application, which is a simple port of the KCM to a standalone application. REPOSITORY R119 Plasma Desktop BRANCH

D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar

ahiemstra marked 2 inline comments as done. ahiemstra added inline comments. INLINE COMMENTS > ahiemstra wrote in ActionToolBar.qml:183 > Ah, I didn't know about `concat()`. I actually looked for something like that > but seem to have missed it. Of course, things weren't as simple as that

D22616: Remove phonon KCM

nicolasfella updated this revision to Diff 64811. nicolasfella added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Remove unused stuff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar

ahiemstra updated this revision to Diff 64810. ahiemstra added a comment. - Address review comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23502?vs=64755=64810 BRANCH actionbutton_overflow REVISION DETAIL https://phabricator.kde.org/D23502

D22616: Remove phonon KCM

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. Also needs removal of `doc/kcontrol/phonon/` and also the qdebugcategory `plasma-desktop.categories:org.kde.kcm.phonon kcm module phonon IDENTIFIER [KCM_PHONON_LOG]` REPOSITORY

D23518: Disable media controls and tabsrunner in Firefox again

This revision was automatically updated to reflect the committed changes. Closed by commit R856:de877a1580ae: Disable media controls and tabsrunner in Firefox again (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar

ahiemstra added inline comments. INLINE COMMENTS > apol wrote in ActionToolBar.qml:183 > it could be `children: [].concat(root.actions).concat(hiddenActions);` no? Ah, I didn't know about `concat()`. I actually looked for something like that but seem to have missed it. REPOSITORY R169

D23461: Remove 'magic' filtering of recent apps

mart added a comment. but good to split the patch and push #1 first and discuss separatedly #2 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc: mart, ngraham, davidedmundson, plasma-devel, LeGast00n,

D23461: Remove 'magic' filtering of recent apps

mart added a comment. It does introduce a bahavior change in kicker, tough we tought that ux-wise it was a really bad behavior that ought to be "fixed" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc: mart,

D23520: Add time line to X axis

alexde updated this revision to Diff 64805. alexde added a comment. Set correct default value for a tick position REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64803=64805 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23518: Disable media controls and tabsrunner in Firefox again

davidedmundson accepted this revision. davidedmundson added a comment. Yeah, but I /really really really/ don't like surprise upgrade behaviour that you get this patch and suddenly your incognito windows are being publicly broadcast everywhere. It could lead to something quite bad. The

D23520: Add time line to X axis

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The current energy plot does not display any time line. This patch adds a grid and time stamps to the

D23518: Disable media controls and tabsrunner in Firefox again

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Accepting, but I REALLY don't like this as it makes the behaviour on firefox quite different compared to other browsers for no good reason. REPOSITORY R856 Plasma Browser Integration

D23517: [Image Wallpaper] Delay KSplash until loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8634cd55fe40: [Image Wallpaper] Delay KSplash until loaded (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23517?vs=64790=64802

D23461: Remove 'magic' filtering of recent apps

tcanabrava added subscribers: ngraham, mart. tcanabrava added a comment. In D23461#520710 , @davidedmundson wrote: > > Is there a reason to change kicker? If not, it needs to be a property. There was a discussion a week ago with @mart

D23461: Remove 'magic' filtering of recent apps

davidedmundson added a comment. > Is there a reason to change kicker? If not, it needs to be a property. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23518: Disable media controls and tabsrunner in Firefox again

broulik updated this revision to Diff 64800. broulik added a comment. - Add back comment REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23518?vs=64797=64800 REVISION DETAIL https://phabricator.kde.org/D23518 AFFECTED FILES

D23518: Disable media controls and tabsrunner in Firefox again

broulik created this revision. broulik added reviewers: Plasma, fvogt, davidbekham, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Effectively reverts e7c353c7f43766ea04dcb894b4ecd0b1dc659bee

D23461: Remove 'magic' filtering of recent apps

tcanabrava updated this revision to Diff 64798. tcanabrava added a comment. - Revert "Remove 'magic' filtering of recent apps" - Remove filtering of recent apps that are in the favorites REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23517: [Image Wallpaper] Delay KSplash until loaded

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Uses the infrastructure introduced in d62e99460ad99468f6c42081060c6229497a9afa

D23494: Replicate Shift+Enter for action invocation for history as well

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f0d0a22366b: Replicate Shift+Enter for action invocation for history as well (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE