D23308: Add a warning message about needing globally installed theme files

This revision was automatically updated to reflect the committed changes. Closed by commit R123:4b2171bb3db3: Add a warning message about needing globally installed theme files (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D23686: Allow a setting to declaratively depend on another one

broulik updated this revision to Diff 65273. broulik added a comment. - Simplify... REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23686?vs=65272=65273 REVISION DETAIL https://phabricator.kde.org/D23686 AFFECTED FILES

D23686: Allow a setting to declaratively depend on another one

broulik updated this revision to Diff 65272. broulik added a comment. - Be explicit about the value, so you can also have something on when something else is *un*checked - Initially check dependencies, too, not just when changing setting REPOSITORY R856 Plasma Browser Integration

D23686: Allow a setting to declaratively depend on another one

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Also indent dependant settings. TEST PLAN - Enhanced media

D23683: [libnotificatonmanager] Initialise member variable

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY 1408== Conditional jump or move depends on uninitialised value(s)

D23392: [energy KCM] Add battery Technology

meven planned changes to this revision. meven added a comment. Waiting for KF 5.62 release REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23392 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D23651: WIP: Add support for a theming in Kicker Dashboard

davidre added a comment. The reason it's transparent is because the clear color of the buffer is set to the background color when it's changed [1][2]. This worked before probably because the Color was (0, 0, 0). For transparent windows we need to set it to `Qt::transparent`[3] and enable

D23392: [energy KCM] Add battery Technology

ngraham added a comment. In D23392#524021 , @meven wrote: > Please note that the feature needs solid 5.62 installed on system as qml looks in `/usr/include/solid/battery.h` for the battery model header. > By chance iIf you know how to set the

D23678: Change Installed list icon to view-list-details

This revision was automatically updated to reflect the committed changes. Closed by commit R134:bd12770b2b1c: Change Installed list icon to view-list-details (authored by ndavis). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D23678: Change Installed list icon to view-list-details

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yup. REPOSITORY R134 Discover Software Store BRANCH installed-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23678 To: ndavis, #vdg,

D23678: Change Installed list icon to view-list-details

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The previous icon was the same, but it was blurry because it was only 16px REPOSITORY R134 Discover

D23330: Make manual control compatible with redshift >= 1.12

vermeeren added a comment. Is there any news regarding this? The updated diff has been tested (both version paths) and works properly. It should be ready for merge as is, and will close a bug over a year old. Urgency is rather high in my opinion, as both Debian >= buster and Ubuntu >=

D23651: WIP: Add support for a theming in Kicker Dashboard

felixernst added a comment. Current (?) one for comparison (from Kubuntu 18.04 since the one from Neon Unstable crashes for me) F7308896: Screenshot_20190902_143551.png I feel like there was a lot of thought put into the current design of the

D23677: [Folder View] Load icon only for isPopup case

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's no point in loading the icon when it cannot be seen. TEST PLAN No longer have

D23676: [Folder View] Only install watch on .directory file if actually used

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Installing a `KDirWatch` checks file system type to determine which backend to use (e.g.

D23675: [Folder View] Don't query file information if tooltips are disabled

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Especially the `TypeRole` can be quite heavy. TEST PLAN 5.16? Disabled tooltips (the

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. My suggestion is (still) "improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true" [possibly with another flag if you think there are actually use cases for mime-magic over network mounts] Then all this code isn't needed. REPOSITORY

Monday meeting notes for 2/9/2019

Nicofee: * Killed the phonon KCM * Patched Pulseaudio to not load module-device-manager for us * This means we should be able to use switch-on-connect by default * Debugged an issue in PA. Profiles that weren't actually useful were still marked as available. Apparently this is already fixed in

D23342: Add a per-process network information plugin

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me ! I am using this now, and it is great. But my review does not weight much as I am not a ksysguard maintainer/developer. It makes me want to add a network graph

D23566: Move code to send signals and set priority of processes to a dedicated object

This revision was automatically updated to reflect the committed changes. Closed by commit R111:cb3ccfc6b3db: Move code to send signals and set priority of processes to a dedicated object (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D23342: Add a per-process network information plugin

ahiemstra added a comment. The readme already mentions it needs cap_net_raw. But I've now added a line on how to ensure that it has that. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D23342 To: ahiemstra, #plasma, meven Cc: meven, davidedmundson, plasma-devel,

D23342: Add a per-process network information plugin

ahiemstra updated this revision to Diff 65214. ahiemstra added a comment. - Add a line that explains using setcap for cap_net_raw REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=64310=65214 BRANCH network_plugin REVISION DETAIL

D23662: Wayland: Support output replication

nicolasfella added inline comments. INLINE COMMENTS > waylandoutput.cpp:102 > +const auto uuid = m_device->replicationSource(); > +if (!uuid.isEmpty()) { > +for (auto waylandOutput : m_config->outputMap()) { if (uuid.isEmpty()) return REPOSITORY R110 KScreen Library

D23663: RandR: Replicate outputs with XRender extension

romangg created this revision. romangg added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This provides means to set replicas and queries them on X11 by transforming crtcs with the

D23662: Wayland: Support output replication

romangg created this revision. romangg added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Uses new functionality in KWayland to allow queriying and setting the current replication

D23647: XRandR: Generic code cleanup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:5ed9a35e3e27: XRandR: Generic code cleanup (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#523708 , @broulik wrote: > So I guess we can use the `KFileItem::isSlow()` here now, too? No because isSlow is a member function but the purpose here is to choose a constructor for KFileItem in the first

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

https://bugs.kde.org/show_bug.cgi?id=304696 Kai Uwe Broulik changed: What|Removed |Added CC||certainlya...@gmail.com --- Comment #16 from