date:20190905

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 36 - Still unstable!

2019-09-05 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/36/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 06 Sep 2019 05:34:29 +
 Build duration:
2 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2582)14%
(212/1503)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/258)0%
(0/136)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/219)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still unstable!

2019-09-05 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/11/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 06 Sep 2019 05:34:30 +
 Build duration:
1 min 59 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D22106: [Separator] Match Breeze borders' color

2019-09-05 Thread Ben Cooksley

bcooksley added a comment.


  Please note that depending on the repository. Phabricator can take anywhere 
from a minute or two, to update to an hour to pick up changes to a repository 
(it polls repositories unfortunately, and those with more frequent changes are 
polled more often by Phabricator)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22106

To: filipf, #kirigami, #vdg, ngraham
Cc: bcooksley, ndavis, mglb, apol, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, davidedmundson, mart, hein

D23728: [kicker/kickoff] Use icon from appstream handler

2019-09-05 Thread Eike Hein

hein added a comment.


  Thanks!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D23728

To: nicolasfella, hein
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Nathaniel Graham

ngraham added a comment.


  In D22468#526448 , @romangg wrote:
  
  > In D22468#526447 , @victorr 
wrote:
  >
  > > I collected another package with a new patch.F7322491: qml.patch 

  > >
  > > F7322492: Screenshot_20190906_002723.jpeg 

  >
  >
  > The string was composited so the 100 characters line limit is not broken. 
Is there a way to break it up such that it still can be translated easily?
  
  
  Like so:
  `xi18n("@info", "the first 100 charactersthe next 100 charactersand 
so on");`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh

victorr added a comment.


  I don’t understand what package is missing in CMakeLists.txt
  I get an error during assembly
  
DEBUG: Warning: Could not locate service type file 
kservicetypes5/kcmodule.desktop, tried ("/builddir/.local/share", 
"/usr/local/share", "/usr/share") and ":/kservicetypes5/kcmodule.desktop" 
((null):0, (null))
DEBUG: About to parse service type file "kcmodule.desktop"
DEBUG: make[2]: *** [kcm/CMakeFiles/kcm_kscreen_autogen.dir/build.make:65: 
kcm/kcm_kscreen.json] Error 1
  
  Then install all the packages needed to build plasma-desktop.
  After installing them, the kscreen package is built without errors.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg

romangg added a comment.


  In D22468#526447 , @victorr wrote:
  
  > I collected another package with a new patch.F7322491: qml.patch 

  >
  > F7322492: Screenshot_20190906_002723.jpeg 

  
  
  The string was composited so the 100 characters line limit is not broken. Is 
there a way to break it up such that it still can be translated easily?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh

victorr added a comment.


  I collected another package with a new patch.F7322491: qml.patch 

  
  F7322492: Screenshot_20190906_002723.jpeg 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg

romangg added a comment.


  In D22468#526445 , @victorr wrote:
  
  > The CMakeLists.txt file lacks the packages needed for the build. 
  >  Installed many additional kf5 and plasa packages for assembly,
  >  since I was too lazy to figure out which package is missing.
  
  
  It builds but the KCM does fail to show anything with error:
  
"file:///usr/share/kpackage/kcms/kcm_kscreen/contents/ui/main.qml" 
 "Error loading QML file.\n80: Unexpected token `string literal'\n100: 
Unexpected token `string literal'\n103: Unexpected token `string literal'\n"

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh

victorr added a comment.


  The CMakeLists.txt file lacks the packages needed for the build. 
  Installed many additional kf5 and plasa packages for assembly,
  since I was too lazy to figure out which package is missing.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22106: [Separator] Match Breeze borders' color

2019-09-05 Thread Filip Fila

filipf closed this revision.
filipf added a comment.


  Phab hasn't picked up on the commit: 
https://cgit.kde.org/kirigami.git/commit/?id=9af92cc8b750b59629eeb3446108b2f8086629f7

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22106

To: filipf, #kirigami, #vdg, ngraham
Cc: ndavis, mglb, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
davidedmundson, mart, hein

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> view.cpp:41
> +setMinimumHeight(800);
> +setMinimumWidth(800);
> +

Probably makes sense to reduce this to 600 if we can get the layout to adjust 
adequately.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Nathaniel Graham

ngraham added a comment.


  Better, thanks. The only remaining issue I can see is the problem with the 
slider values. I also noticed that the first value does nothing to change the 
view and spits out the following errors on the console:
  

file:///home/nate/kde/usr/share/plasma/packages/org.kde.plasma.cuttlefish/contents/ui/Tools.qml:84:
 Error: Cannot assign [undefined] to int

file:///home/nate/kde/usr/share/plasma/packages/org.kde.plasma.cuttlefish/contents/ui/Tools.qml:76:
 Error: Cannot assign [undefined] to QString

INLINE COMMENTS

> SvgGrid.qml:23
>  import QtQuick 2.2
> -// import QtQuick.Controls 1.0
> +import QtQuick.Controls 2.0
>  import QtQuick.Layouts 1.0

same: `import QtQuick.Controls 2.5 as QQC2`

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Carson Black

cblack updated this revision to Diff 65483.
cblack added a comment.


  Update based off of feedback

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=65417&id=65483

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23746: Set a minimum window size to reasonable 800x600 px

2019-09-05 Thread Noah Davis

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:dd9bc6a3cb01: Set a minimum window size to reasonable 
800x600 px (authored by alexde, committed by ndavis).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23746?vs=65478&id=65480

REVISION DETAIL
  https://phabricator.kde.org/D23746

AFFECTED FILES
  infocenter.cpp

To: alexde, #vdg, ngraham, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23746: Set a minimum window size to reasonable 800x600 px

2019-09-05 Thread Noah Davis

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Never mind, a KWin rule I had was messing things up. You're good to go.

REPOSITORY
  R102 KInfoCenter

BRANCH
  minimum-window-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23746

To: alexde, #vdg, ngraham, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23746: Set a minimum window size to reasonable 800x600 px

2019-09-05 Thread Nathaniel Graham

ngraham added a comment.


  Works for me. Are you sure you're opening the built-from-source version of 
KInfoCenter rather than the system-provided one?

REPOSITORY
  R102 KInfoCenter

BRANCH
  minimum-window-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23746

To: alexde, #vdg, ngraham, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23746: Set a minimum window size to reasonable 800x600 px

2019-09-05 Thread Noah Davis

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  This doesn't seem to do anything, unless I'm testing the wrong thing.
  KInfocenter with main page selected: F7322186: Screenshot_20190905_155743.png 


REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23746

To: alexde, #vdg, ngraham, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22106: [Separator] Match Breeze borders' color

2019-09-05 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Long term, we should make this more programmatic.
  
  But since there's already a magic number in there, I think it makes sense to 
use a better one for the time being.

REPOSITORY
  R169 Kirigami

BRANCH
  tweak-separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22106

To: filipf, #kirigami, #vdg, ngraham
Cc: ndavis, mglb, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
davidedmundson, mart, hein

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg

romangg added a comment.


  In D22468#526341 , @victorr wrote:
  
  > If you apply the attached file, the lines are added to the localization 
file, and the translation works.F7322054: messages2.patch 

  >
  > F7322055: skreen3.jpeg 
  >  Attached a picture
  
  
  Applying this patch makes the kcm not start anymore

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23746: Set a minimum window size to reasonable 800x600 px.

2019-09-05 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems like a reasonable minimum size to me. This way none of the KCMs can get 
cut off (except for the Energy KCM when using a laptop).

REPOSITORY
  R102 KInfoCenter

BRANCH
  minimum-window-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23746

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23746: Set a minimum window size to reasonable 800x600 px.

2019-09-05 Thread Alex Debus

alexde created this revision.
alexde added reviewers: VDG, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexde requested review of this revision.

REPOSITORY
  R102 KInfoCenter

BRANCH
  minimum-window-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23746

AFFECTED FILES
  infocenter.cpp

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh

victorr added a comment.


  If you apply the attached file, the lines are added to the localization file, 
and the translation works.F7322054: messages2.patch 

  
  F7322055: skreen3.jpeg 
  Attached a picture

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg

romangg added a comment.


  In D22468#526323 , @victorr wrote:
  
  > Are you talking about this?F7321902: messages.patch 

  
  
  I thought there was also markup missing in the QML files.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh

victorr added a comment.


  Are you talking about this?F7321902: messages.patch 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg

romangg added a comment.


  Since you found already the root issue want to write a quick patch to fix it?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23737: Extract mimetype from recentlyused.xbel

2019-09-05 Thread Méven Car

This revision was automatically updated to reflect the committed changes.
Closed by commit R161:3cd9e64d359b: Extract mimetype from recentlyused.xbel 
(authored by meven).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23737?vs=65466&id=65469

REVISION DETAIL
  https://phabricator.kde.org/D23737

AFFECTED FILES
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h

To: meven, ivan
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh

victorr added a comment.


  File /kscreen-5.16.4/kcm/kcm.cpp contains name 
  «KAboutData *about = new KAboutData(QStringLiteral("kcm_kscreen"),»
  After renaming, the translation is displayed.
  Attached a picture 2.F7321822: skreen2.jpeg 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh

victorr added a comment.


  Incorrect filename "kcm_displayconfiguration" in the /kscreen/kcm/Messages.sh 
file.
  Translation is not displayed.
  Attached a picture 1.
  F7321805: screen1.jpeg 

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Jason Franklin

jfranklin added a comment.


  In D23734#526285 , @zzag wrote:
  
  > Hmm, "Unlocking failed" doesn't show up immediately if I type wrong 
password.
  
  
  "Unlocking failed" shows up immediately when I type in the wrong password 
with the change in place.  What PAM module is authenticating you?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

To: jfranklin, #plasma, #kwin, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23737: Extract mimetype from recentlyused.xbel

2019-09-05 Thread Méven Car

meven updated this revision to Diff 65466.
meven added a comment.


  const QString &mimetype

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23737?vs=65436&id=65466

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23737

AFFECTED FILES
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h

To: meven, ivan
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Vlad Zagorodniy

zzag requested changes to this revision.
zzag added a comment.
This revision now requires changes to proceed.


  Hmm, "Unlocking failed" doesn't show up immediately if I type wrong password.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

To: jfranklin, #plasma, #kwin, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh

victorr added a comment.


  Not all lines entered the localization file.
  Text in patch
  
  +text: i18n("New global scale applied. " +
  +   "Change will come into effect after restart.")
  
  Line «Change will come into effect after restart.» is ignored

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Jason Franklin

jfranklin added a comment.


  In D23734#526274 , @zzag wrote:
  
  > We want to notify the user as soon as possible about authentication failure.
  
  
  This makes complete sense!  You definitely want the user to be notified 
immediately.  However, the same effect happens with the call 
`pam_set_item(pamh, PAM_FAIL_DELAY, NULL)`.  The Linux-PAM library 
documentation makes it clear that, when this is set to `NULL`, no delay will 
happen.
  
  See this link: 
http://www.linux-pam.org/Linux-PAM-html/adg-interface-by-app-expected.html#adg-pam_fail_delay

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

To: jfranklin, #plasma, #kwin
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Vlad Zagorodniy

zzag added a comment.


  > I'd be very curious to know if there is a reason for having a fail_delay() 
function that performs no action. Just let me know!
  
  We want to notify the user as soon as possible about authentication failure.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

To: jfranklin, #plasma, #kwin
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

2019-09-05 Thread Nathaniel Graham

ngraham added a comment.


  Thanks for the review, @gb_2. Have you tested it out? I did a lot of testing, 
but even more testing would be appreciated since I know this has the potential 
to introduce some regressions.
  
  I suspect all the #plasma  people 
are going to be busy with Akademy for the next week or two so I'll stop pinging 
for a while.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  revamp-session-switching-ux

REVISION DETAIL
  https://phabricator.kde.org/D23283

To: ngraham, #plasma, #vdg, GB_2
Cc: GB_2, gregormi, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

2019-09-05 Thread Nathaniel Graham

ngraham updated this revision to Diff 65458.
ngraham marked an inline comment as done.
ngraham added a comment.


  Fix string capitalization

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23283?vs=64229&id=65458

BRANCH
  revamp-session-switching-ux

REVISION DETAIL
  https://phabricator.kde.org/D23283

AFFECTED FILES
  components/sessionsprivate/sessionsmodel.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: ngraham, #plasma, #vdg, GB_2
Cc: GB_2, gregormi, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde updated this revision to Diff 65457.
alexde added a comment.


  Set correct right border for the grid lines and ticks.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65428&id=65457

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

2019-09-05 Thread Nathaniel Graham

ngraham added a comment.


  I'm going to land all these patches after Frameworks 5.62 has branched (in 
two days) to prevent the builds from failing until then due to new stricter ECM 
frameworks-version-finding behavior.

REPOSITORY
  R124 System Settings

BRANCH
  use-new-kirigami-section-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23052

To: ngraham, #plasma, #vdg, GB_2
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23733: [kded] Save replication source hash to config file

2019-09-05 Thread Roman Gilg

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:1ee9b20b2559: [kded] Save replication source hash to 
config file (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23733?vs=65430&id=65456

REVISION DETAIL
  https://phabricator.kde.org/D23733

AFFECTED FILES
  kded/config.cpp
  kded/output.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

2019-09-05 Thread Björn Feber

GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Makes sense to me UI- and behavior-wise.

INLINE COMMENTS

> LockScreenUi.qml:443
> +font.pointSize: theme.defaultFont.pointSize + 1
> +text: 
> i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Switch to this Session")
> +onClicked: initSwitchSession()

"Switch to Session" or "Switch to This Session"

REPOSITORY
  R120 Plasma Workspace

BRANCH
  revamp-session-switching-ux

REVISION DETAIL
  https://phabricator.kde.org/D23283

To: ngraham, #plasma, #vdg, GB_2
Cc: GB_2, gregormi, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

2019-09-05 Thread Björn Feber

GB_2 added a comment.


  Ping.

REPOSITORY
  R124 System Settings

BRANCH
  use-new-kirigami-section-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23052

To: ngraham, #plasma, #vdg, GB_2
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23663: RandR: Replicate outputs with XRender extension

2019-09-05 Thread Roman Gilg

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:31d71564874d: RandR: Replicate outputs with XRender 
extension (authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23663?vs=65384&id=65455#toc

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23663?vs=65384&id=65455

REVISION DETAIL
  https://phabricator.kde.org/D23663

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp
  backends/xrandr/xrandrconfig.h
  backends/xrandr/xrandroutput.cpp
  backends/xrandr/xrandroutput.h

To: romangg, #kwin, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23666: [kcm] Provide graphical interface to replicate outputs

2019-09-05 Thread Roman Gilg

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:6e7fd472b111: [kcm] Provide graphical interface to 
replicate outputs (authored by romangg).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23666?vs=65427&id=65454

REVISION DETAIL
  https://phabricator.kde.org/D23666

AFFECTED FILES
  kcm/config_handler.cpp
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/output_model.cpp
  kcm/output_model.h
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/OutputPanel.qml

To: romangg, #kwin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23710: Introduce output replication API

2019-09-05 Thread Roman Gilg

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:c8ef5444ee02: Introduce output replication API (authored 
by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23710?vs=65339&id=65453

REVISION DETAIL
  https://phabricator.kde.org/D23710

AFFECTED FILES
  src/config.h
  src/configserializer.cpp
  src/output.cpp
  src/output.h
  src/setconfigoperation.cpp

To: romangg, #kwin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23737: Extract mimetype from recentlyused.xbel

2019-09-05 Thread Ivan Čukić

ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> GtkEventSpy.cpp:207
>  
> -void GtkEventSpyPlugin::addDocument(const QUrl &url, const QString 
> &application)
> +void GtkEventSpyPlugin::addDocument(const QUrl &url, const QString 
> &application, const QString mimetype)
>  {

const-ref not const val - `const QString& mimetype`

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23737

To: meven, ivan
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:6309d33f092e: Rewrite KScreen KCM as ConfigModule with 
outputs model and Kirigami (authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22468?vs=65426&id=65451#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22468?vs=65426&id=65451

REVISION DETAIL
  https://phabricator.kde.org/D22468

AFFECTED FILES
  CMakeLists.txt
  common/control.h
  common/utils.cpp
  common/utils.h
  icons/48-actions-kdocumentinfo.png
  icons/CMakeLists.txt
  icons/sc-actions-kdocumentinfo.svgz
  kcm/CMakeLists.txt
  kcm/Messages.sh
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm_kscreen.desktop
  kcm/kcm_kscreen.desktop.cmake
  kcm/output_identifier.cpp
  kcm/output_identifier.h
  kcm/output_model.cpp
  kcm/output_model.h
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/RotationButton.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml
  kcm/package/metadata.desktop
  kcm/qml/CMakeLists.txt
  kcm/qml/Output.qml
  kcm/qml/OutputIdentifier.qml
  kcm/qml/Tip.qml
  kcm/qml/main.qml
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/declarative/qmloutput.cpp
  kcm/src/declarative/qmloutput.h
  kcm/src/declarative/qmloutputcomponent.cpp
  kcm/src/declarative/qmloutputcomponent.h
  kcm/src/declarative/qmlscreen.cpp
  kcm/src/declarative/qmlscreen.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h
  kcm/src/kcm_testapp.cpp
  kcm/src/kscreen_widget.ui
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/previewwidget.cpp
  kcm/src/previewwidget.h
  kcm/src/resolutionslider.cpp
  kcm/src/resolutionslider.h
  kcm/src/scaling.ui
  kcm/src/scalingconfig.cpp
  kcm/src/scalingconfig.h
  kcm/src/stylepreview.ui
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/utils.cpp
  kcm/src/utils.h
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/CMakeLists.txt
  kded/osd.cpp
  tests/osd/CMakeLists.txt

To: romangg, #plasma, #kwin, #vdg
Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, 
broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23731: Wayland: Set fractional output scale

2019-09-05 Thread Roman Gilg

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:802b0c838213: Wayland: Set fractional output scale 
(authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23731?vs=65418&id=65448

REVISION DETAIL
  https://phabricator.kde.org/D23731

AFFECTED FILES
  backends/kwayland/waylandoutput.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23732: [kded] Support fractional output scale

2019-09-05 Thread Roman Gilg

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:305078f0258c: [kded] Support fractional output scale 
(authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23732?vs=65419&id=65447

REVISION DETAIL
  https://phabricator.kde.org/D23732

AFFECTED FILES
  kded/output.cpp

To: romangg, #plasma
Cc: broulik, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23727: Provide a simple test tool to see what autostart will look like

2019-09-05 Thread Aleix Pol Gonzalez

apol updated this revision to Diff 65441.
apol added a comment.


  add missing files

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23727?vs=65399&id=65441

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23727

AFFECTED FILES
  shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/plasma-autostart/CMakeLists.txt
  startkde/plasma-session/plasma-autostart/main.cpp

To: apol, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Remote desktop on Plasma Wayland session

2019-09-05 Thread Aleix Pol

On Thu, Feb 14, 2019 at 12:29 PM Jan Grulich  wrote:
>
> Hi,
>
> I've spent quite a bit time on remote desktop support for Plasma Wayland
> sessions. I have full mouse support in xdg-desktop-portal-kde and also in Krfb
> so it can be easily tested and used. Problem is that I'm currently blocked by
> my additions to the FakeInput protocol on KWayland and KWin side and I'm
> unable to get this reviewed. The addition is basically just about allowing to
> move with mouse cursor using absolute coordinates, because current API allows
> only relative coordinates. Therefore I would like to kindly ask if someone
> from Plasma/KWin maintainers can look into this so I can get this off my
> plate.
>
> The reviews are here:
> KWayland: https://phabricator.kde.org/D18114
> KWin: https://phabricator.kde.org/D18115
>
> Also, while mouse support might be enough for someone, we still need keyboard
> support, which I tried to add into the FakeInput protocol as well, but it was
> rejected by Martin as he would like to have a different and more secure way.
> I currently don't have that much time to investigate this further and
> implement myself, but it might be a good idea for a GSoC task, it would just
> need someone from KWin maintainers to help on this front, while I can help on
> the portal side of thing. Are there any volunteers for this? Any idea how all
> of this can be done?
>
> If you want to see a demo of the remote desktop, see the link below, on one
> laptop I used Krfb (server) running on Wayland session and on the other one I
> used Krdc (client).
>
> Link: https://jgrulich.fedorapeople.org/wayland_remote_desktop.mkv

Would it make sense to review keyboard now that we have the kwin
privileges and org_kde_kwin_fake_input needs to be requested?

Aleix

D23737: Extract mimetype from recentlyused.xbel

2019-09-05 Thread Méven Car

meven created this revision.
meven added a reviewer: ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  Locally tested

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23737

AFFECTED FILES
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h

To: meven, ivan
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread David Redondo

davidre added a comment.


  In D23712#525974 , @ngraham wrote:
  
  > There are some inline comments that aren't done yet. Also, the slider's 
text label still says 81 and 162 instead of 64 and 128 for the last two slider 
values.
  
  
  I also noticed that the first two values are both say 16

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> cuttlefish.qml:32
>  
> -width: units.gridUnit * 60
> -height: Math.round(width / 3 * 2)
> -
>  property int iconSize: units.iconSizes.large
>  property bool darkScheme: false

Why not Kirigami units here?

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Plasma 5.17 repo freeze

2019-09-05 Thread Jonathan Riddell

Repo freeze is today so no new git repos can be added

The list I have for 5.17 is
+ wdiff git-repositories-for-release-old git-repositories-for-release
bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi
kactivitymanagerd kde-cli-tools kdecoration kde-gtk-config kdeplasma-addons
kgamma5 khotkeys kinfocenter kmenuedit kscreen kscreenlocker ksshaskpass
ksysguard kwallet-pam kwayland-integration kwin kwrited libkscreen
libksysguard milou oxygen plasma-browser-integration plasma-desktop
plasma-integration plasma-nm plasma-pa plasma-sdk plasma-tests
{+plasma-thunderbolt+} plasma-vault plasma-workspace
plasma-workspace-wallpapers plymouth-kcm polkit-kde-agent-1 powerdevil
sddm-kcm systemsettings user-manager xdg-desktop-portal-kde

Where the addition is {+plasma-thunderbolt+}

Any new build deps should also be run by this list.

Beta and feature freeze is in two weeks time on Sep 19th

Jonathan

D23732: [kded] Support fractional output scale

2019-09-05 Thread Roman Gilg

romangg added a comment.


  In D23732#526007 , @cfeck wrote:
  
  > I believe 1.25 is a common scale factor. Is something else in the stack 
limited to one digit?
  
  
  Current ui only supports one digit. But we can make it two here, so people 
really needing .25 can set it in the config file. Although I can't believe 
somebody really needs it when he can also select .2 and .3.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23732

To: romangg, #plasma
Cc: broulik, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23732: [kded] Support fractional output scale

2019-09-05 Thread Kai Uwe Broulik

broulik added a comment.


  I'm pretty sure the startplasma that sets the Qt scaling variables for X also 
rounds to one digit

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23732

To: romangg, #plasma
Cc: broulik, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23727: Provide a simple test tool to see what autostart will look like

2019-09-05 Thread Kai Uwe Broulik

broulik added a comment.


  Are you sure you added all files to this patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23727

To: apol, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23732: [kded] Support fractional output scale

2019-09-05 Thread Christoph Feck

cfeck added a comment.


  I believe 1.25 is a common scale factor. Is something else in the stack 
limited to one digit?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23732

To: romangg, #plasma
Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23728: [kicker/kickoff] Use icon from appstream handler

2019-09-05 Thread Nathaniel Graham

ngraham added a comment.


  Wow, that was easy.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23728

To: nicolasfella, hein
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Jason Franklin

jfranklin created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jfranklin requested review of this revision.

REVISION SUMMARY
  I'm a new contributor to kscreenlocker, so I thought I'd start with something 
very simple to see how the process goes.  I hope I'm in line with standard 
procedures for proposing a change.
  
  I've been spending a lot of time working with the kscreenlocker code in an 
attempt to debug its conversation with Poldi, which is a PAM module for 
allowing authentication with GnuPG smart cards.  In this time, I've built up 
some familiarity with the code, and I'd like to submit a few patches over the 
next couple of weeks to improve things.
  
  This change is pretty simple, and it makes a great deal of sense to me.  I'd 
be very curious to know if there is a reason for having a `fail_delay()` 
function that performs no action.  Just let me know!
  
  Otherwise, the relevant explanation is in the commit message itself.

TEST PLAN
  The current tests don't seem to cover the delay from a failure to 
`pam_authenticate()`.  If one needs to be added, I'd like to help!  I've spent 
a lot of time learning how this project works, and I'd be happy if one of the 
maintainers here could help me get the test suite up and running.
  
  This patch should change no functionality and, thus, will need no changes in 
the test code.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

AFFECTED FILES
  kcheckpass/checkpass_pam.c

To: jfranklin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23733: [kded] Save replication source hash to config file

2019-09-05 Thread Roman Gilg

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  When a replication source is set write its output hash to the config file and
  load the value again on next startup. If no replication source is set the
  value written is an empty string.

TEST PLAN
  Tested on X11.

REPOSITORY
  R104 KScreen

BRANCH
  cloneSave

REVISION DETAIL
  https://phabricator.kde.org/D23733

AFFECTED FILES
  kded/config.cpp
  kded/output.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Nathaniel Graham

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  There are some inline comments that aren't done yet. Also, the slider's text 
label still says 81 and 162 instead of 64 and 128 for the last two slider 
values.

INLINE COMMENTS

> Tools.qml:102
> +color: Kirigami.Theme.textColor
> +height: 1
> +anchors {

Is any of this custom styling actually necessary given `Kirigami.Separator`'s 
default appearance?

> ngraham wrote in Tools.qml:30
> The fake toolbar created here feels too short. I would make it taller by a 
> few pixels so there's more room above and below the controls.

Now it's a bit too tall, and the margins above and below the search field still 
don't match the left margins: F7320966: Screenshot_20190905_071959.png 


> ngraham wrote in Tools.qml:42
> Don't need to override the default placeholder text when using 
> `Kirigami.SearchField`

Not done yet.

> ngraham wrote in cuttlefish.qml:24
> ditto

Not done

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde updated this revision to Diff 65428.
alexde added a comment.


  Move stroke() out of the loop.
  Reduce line with by pixel.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65423&id=65428

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg

romangg updated this revision to Diff 65426.
romangg added a comment.


  - Add scale debug output

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22468?vs=65421&id=65426

BRANCH
  qmlize

REVISION DETAIL
  https://phabricator.kde.org/D22468

AFFECTED FILES
  CMakeLists.txt
  common/control.h
  common/utils.cpp
  common/utils.h
  icons/48-actions-kdocumentinfo.png
  icons/CMakeLists.txt
  icons/sc-actions-kdocumentinfo.svgz
  kcm/CMakeLists.txt
  kcm/Messages.sh
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm_kscreen.desktop
  kcm/kcm_kscreen.desktop.cmake
  kcm/output_identifier.cpp
  kcm/output_identifier.h
  kcm/output_model.cpp
  kcm/output_model.h
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/RotationButton.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml
  kcm/package/metadata.desktop
  kcm/qml/CMakeLists.txt
  kcm/qml/Output.qml
  kcm/qml/OutputIdentifier.qml
  kcm/qml/Tip.qml
  kcm/qml/main.qml
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/declarative/qmloutput.cpp
  kcm/src/declarative/qmloutput.h
  kcm/src/declarative/qmloutputcomponent.cpp
  kcm/src/declarative/qmloutputcomponent.h
  kcm/src/declarative/qmlscreen.cpp
  kcm/src/declarative/qmlscreen.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h
  kcm/src/kcm_testapp.cpp
  kcm/src/kscreen_widget.ui
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/previewwidget.cpp
  kcm/src/previewwidget.h
  kcm/src/resolutionslider.cpp
  kcm/src/resolutionslider.h
  kcm/src/scaling.ui
  kcm/src/scalingconfig.cpp
  kcm/src/scalingconfig.h
  kcm/src/stylepreview.ui
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/utils.cpp
  kcm/src/utils.h
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/CMakeLists.txt
  kded/osd.cpp
  tests/osd/CMakeLists.txt

To: romangg, #plasma, #kwin, #vdg
Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, 
broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde updated this revision to Diff 65423.
alexde added a comment.


  Shrink plotWidth a little bit so the earliest date on the right side may fit.
  Change the way the division widths are defined to hopefully make the code 
easier to understand
  and to maintain.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65413&id=65423

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg

romangg updated this revision to Diff 65421.
romangg added a comment.


  Rebase on D23732 .

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22468?vs=65370&id=65421

BRANCH
  qmlize

REVISION DETAIL
  https://phabricator.kde.org/D22468

AFFECTED FILES
  CMakeLists.txt
  common/control.h
  common/utils.cpp
  common/utils.h
  icons/48-actions-kdocumentinfo.png
  icons/CMakeLists.txt
  icons/sc-actions-kdocumentinfo.svgz
  kcm/CMakeLists.txt
  kcm/Messages.sh
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm_kscreen.desktop
  kcm/kcm_kscreen.desktop.cmake
  kcm/output_identifier.cpp
  kcm/output_identifier.h
  kcm/output_model.cpp
  kcm/output_model.h
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/OutputIdentifier.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/RotationButton.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml
  kcm/package/metadata.desktop
  kcm/qml/CMakeLists.txt
  kcm/qml/Output.qml
  kcm/qml/OutputIdentifier.qml
  kcm/qml/Tip.qml
  kcm/qml/main.qml
  kcm/src/CMakeLists.txt
  kcm/src/controlpanel.cpp
  kcm/src/controlpanel.h
  kcm/src/declarative/qmloutput.cpp
  kcm/src/declarative/qmloutput.h
  kcm/src/declarative/qmloutputcomponent.cpp
  kcm/src/declarative/qmloutputcomponent.h
  kcm/src/declarative/qmlscreen.cpp
  kcm/src/declarative/qmlscreen.h
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h
  kcm/src/kcm_testapp.cpp
  kcm/src/kscreen_widget.ui
  kcm/src/outputconfig.cpp
  kcm/src/outputconfig.h
  kcm/src/previewwidget.cpp
  kcm/src/previewwidget.h
  kcm/src/resolutionslider.cpp
  kcm/src/resolutionslider.h
  kcm/src/scaling.ui
  kcm/src/scalingconfig.cpp
  kcm/src/scalingconfig.h
  kcm/src/stylepreview.ui
  kcm/src/unifiedoutputconfig.cpp
  kcm/src/unifiedoutputconfig.h
  kcm/src/utils.cpp
  kcm/src/utils.h
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/CMakeLists.txt
  kded/osd.cpp
  tests/osd/CMakeLists.txt

To: romangg, #plasma, #kwin, #vdg
Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, 
broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23732: [kded] Support fractional output scale

2019-09-05 Thread Roman Gilg

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Read and write fractional output scale values to conifg. We currently round to
  one digit.

REPOSITORY
  R104 KScreen

BRANCH
  fractionalOutputScaleWrite

REVISION DETAIL
  https://phabricator.kde.org/D23732

AFFECTED FILES
  kded/output.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23731: Wayland: Set fractional output scale

2019-09-05 Thread Roman Gilg

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  In order to use fractional scaling on Wayland the KScreen internal output 
scale
  must be set with the fractional scale getter of the OutputDevice interface.

REPOSITORY
  R110 KScreen Library

BRANCH
  outputFractionalScale

REVISION DETAIL
  https://phabricator.kde.org/D23731

AFFECTED FILES
  backends/kwayland/waylandoutput.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Carson Black

cblack updated this revision to Diff 65417.
cblack added a comment.


  Give screenie button some text

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=65401&id=65417

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp

To: cblack, #vdg
Cc: ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23729: Add "freebsd" as supported platform key

2019-09-05 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:f8bb4695829b: Add "freebsd" as supported 
platform key (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23729?vs=65414&id=65415

REVISION DETAIL
  https://phabricator.kde.org/D23729

AFFECTED FILES
  extension/constants.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde added a comment.


  For some reason the xGridOffset seems sometimes to be wrong, and I have no 
explanation why. It especially happens for 1 hour graphs. F7320671: 
Screenshot_20190905_132313.png 

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23729: Add "freebsd" as supported platform key

2019-09-05 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Chrome documentation only mentions "openbsd" and so does Firefox's because it 
is just derived from chrome's docs in this case.
  
  BUG: 411582

TEST PLAN
  None

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23729

AFFECTED FILES
  extension/constants.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde requested review of this revision.
alexde added a comment.


  I have changed some stuff, can you please review it again.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde updated this revision to Diff 65413.
alexde added a comment.


  Rename variables to make their function clearer.
  Decrease the lower loop border by 1 to make sure that all
  possible grid lines are drawn.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65410&id=65413

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde updated this revision to Diff 65410.
alexde added a comment.


  Fix issue that a date may be displayed unintentionally.
  Shrink right margin for grid lines and try to add an additional grid line
  on the right side if reasonable.
  Add more divisions for 2h and 24h graphs.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65409&id=65410

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde updated this revision to Diff 65409.
alexde added a comment.


  Use dashed grid lines instead of solid lines. Grid lines with tick labels are 
less faint.
  Rename variable to make its function clearer.
  Show grid lines at all five minutes for the 1 hour graph.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65407&id=65409

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23728: [kicker/kickoff] Use icon from appstream handler

2019-09-05 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  appstream

REVISION DETAIL
  https://phabricator.kde.org/D23728

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: nicolasfella, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus

alexde updated this revision to Diff 65407.
alexde added a comment.


  Align grid to 10 minutes for the 1h graph.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65321&id=65407

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

79 matches

Mail list logo