D22168: [plasma-desktop] Use new activities icon

[Björn Feber]

GB_2 updated this revision to Diff 65531.
GB_2 added a comment.


  Rebase on master

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22168?vs=60866=65531

BRANCH
  arcpatch-D22168

REVISION DETAIL
  https://phabricator.kde.org/D22168

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml
  applets/showActivityManager/package/contents/ui/main.qml
  applets/showActivityManager/package/metadata.desktop
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/qml/activityDialog/GeneralTab.qml

To: GB_2, #plasma, #vdg, ndavis
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 65530.
cblack added a comment.


  Add 22 size to preview, and hardcode sizes since they shouldn't need to 
respect any settings.

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=65505=65530

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp

To: cblack, #vdg, ngraham
Cc: trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack added a comment.


  In D23712#526852 , @ndavis wrote:
  
  > In D23712#526826 , 
@trickyricky26 wrote:
  >
  > > I love this patch, however I am curious as to why you moved the sidebar 
to the bottom.
  > >  Judging from your screenshot, it results in quite a bit of empty 
horizontal space.
  > >  Conceptually I think it is nicer to have the scrollable view go to the 
bottom of the window and have the details of the selected item be shown in a 
sidebar.
  >
  >
  > I agree. I also have a much easier time reading lists vertically rather 
than horizontally, so I prefer more vertical space at the cost of horizontal 
space.
  
  
  I preferred the sidebar as well, but a sidebar with the necessary width to 
fit the label + the largest icon name in Breeze without layout issues would be 
obscenely large, and would take over half the width of smaller monitors. That's 
why it was moved to the bottom - for extra horizontal space.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Noah Davis]

ndavis added a comment.


  In D23712#526826 , @trickyricky26 
wrote:
  
  > I love this patch, however I am curious as to why you moved the sidebar to 
the bottom.
  >  Judging from your screenshot, it results in quite a bit of empty 
horizontal space.
  >  Conceptually I think it is nicer to have the scrollable view go to the 
bottom of the window and have the details of the selected item be shown in a 
sidebar.
  
  
  I agree. I also have a much easier time reading lists vertically rather than 
horizontally, so I prefer more vertical space at the cost of horizontal space.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[TrickyRicky]

trickyricky26 added a comment.


  I love this patch, however I am curious as to why you moved the sidebar to 
the bottom.
  Judging from your screenshot, it results in quite a bit of empty horizontal 
space.
  Conceptually I think it is nicer to have the scrollable view go to the bottom 
of the window and have the details of the selected item be shown in a sidebar.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra added a comment.


  That's correct. The reason for that is that a non-root process is not allowed 
to read which inodes root process has open, thus there is no way for the helper 
to map from incoming port to process ID. The only way I know of solving that is 
by having the helper run as root, which I would prefer to avoid.

INLINE COMMENTS

> meven wrote in main.cpp:97
> Could the refresh rate be a parameter or at least a constant instead of an 
> hardcoded value.

The helper reports a download/upload rate per second. This is done by capturing 
the amount of incoming/outgoing bytes and each second reporting that value, 
then resetting the counter. Changing this value would thus result in changing 
the reported unit, so I'd rather keep it a hardcoded constant here.

REPOSITORY
  R106 KSysguard

BRANCH
  network_plugin

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma, meven
Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23734: Remove the "fail_delay()" function

[Jason Franklin]

jfranklin abandoned this revision.
jfranklin added a comment.


  Problem exists in linux-pam.  I will fix the issue there.  Abandoning 
revision.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

To: jfranklin, #plasma, #kwin, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23734: Remove the "fail_delay()" function

[Vlad Zagorodniy]

zzag added a comment.


  Thank you for looking further into this issue. Just abandon the revision.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

To: jfranklin, #plasma, #kwin, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23734: Remove the "fail_delay()" function

[Jason Franklin]

jfranklin added a comment.


  I investigated this further in the linux-pam repository, and I ended up 
creating this issue .  The 
developers there acknowledged that the documentation was not correct and have 
asked for a PR to fix it.
  
  Thus, please close/resolve this issue at your convenience.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

To: jfranklin, #plasma, #kwin, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Just noticed something odd: the multi-size view shows an 8px version, but not 
the 22px version. Only one type of icon uses the 8px version (emblems) but 22px 
is more common. We should add that too.
  
  Also the last two slider values are still displayed incorrectly in the label.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Björn Feber]

GB_2 updated this revision to Diff 65509.
GB_2 added a comment.


  Use Plasma highlight effect

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19822?vs=55003=65509

BRANCH
  arcpatch-D19822

REVISION DETAIL
  https://phabricator.kde.org/D19822

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: faridb, #plasma, #vdg, ngraham, hein
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23728: [kicker/kickoff] Use icon from appstream handler

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:26c1ea64c636: [kicker/kickoff] Use icon from appstream 
handler (authored by nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23728?vs=65408=65508

REVISION DETAIL
  https://phabricator.kde.org/D23728

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp

To: nicolasfella, hein
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack marked 18 inline comments as done.
cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in view.cpp:41
> Probably makes sense to reduce this to 600 if we can get the layout to adjust 
> adequately.

There's already icon names that are too long for the minimum 800 width window, 
so I wouldn't decrease it even further.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 65505.
cblack added a comment.


  Updates based off of feedback

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=65483=65505

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23732: [kded] Support fractional output scale

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> output.cpp:357
> +// Round scale to one digit.
> +info[QStringLiteral("scale")] = int(output->scale() * 10 + 0.5) / 10.;
> +

i don't understand why we need/want this.

KConfig won't corrupt a double through a save/restore.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23732

To: romangg, #plasma
Cc: davidedmundson, broulik, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23734: Remove the "fail_delay()" function

[Vlad Zagorodniy]

zzag added a comment.


  Um, pam_unix I suppose...

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23734

To: jfranklin, #plasma, #kwin, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Victor Ryzhykh]

victorr added a comment.


  F7323570: now_qml.patch 
  
  F7323571: Screenshot_20190906_111728.jpeg 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added a comment.


  In D22468#526465 , @ngraham wrote:
  
  > Like so:
  >  `xi18n("@info", "the first 100 charactersthe next 100 
charactersand so on");`
  
  
  I meant the 100 chars line limit of the code source file.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, 
knambiar, broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart