D23910: startplasma: Respect KDEWM again

2019-09-15 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:0fcd29399b9d: startplasma: Respect KDEWM again (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23910?vs=65932=66181 REVISION

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Carson Black
cblack updated this revision to Diff 66180. cblack added a comment. Alphabetical sort and more telling Qt's garbage SVG renderer to shut up REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66179=66180 BRANCH modernization (branched from

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. Awesome. Didn't the main icon grid used to have a white background? I kind of liked that. Speaking of the icon grid, I'm somehow only not noticing that it's not sorted in any appreciable way. Maybe it should be alphabetical. REPOSITORY R118 Plasma SDK BRANCH

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Carson Black
cblack updated this revision to Diff 66179. cblack added a comment. Shrink sidebar REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66178=66179 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. Lovely stuff. The addition of a 256px icon in the sidebar makes it absurdly wide though. I'd recommend removing it. REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack,

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Carson Black
cblack updated this revision to Diff 66178. cblack added a comment. Spacing fixes REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66177=66178 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Carson Black
cblack updated this revision to Diff 66177. cblack added a comment. Whole buncha stuff REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66093=66177 BRANCH modernization (branched from master) REVISION DETAIL

D23977: [Notifications] Introduce dedicated "read" state for notification

2019-09-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely, this is much nicer behavior! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23977 To: broulik, #plasma, #vdg, ngraham Cc: ngraham,

D23977: [Notifications] Introduce dedicated "read" state for notification

2019-09-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Currently, a notification is considered "unread" when it was created or updated after the

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Noah Davis
ndavis added a comment. There seems to be a blank entry at the bottom of the category list: F7357648: Screenshot_20190915_171648.png REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Noah Davis
ndavis added a comment. The clickable area is significantly smaller than the highlight. REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26, davidre, ndavis,

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Noah Davis
ndavis added a comment. Text still gets cut off on the left side: F7357632: Screenshot_20190915_171434.png REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack,

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Noah Davis
ndavis added a comment. The sidebar seems a bit wide. Maybe remove the 128px view? As a Breeze icon designer, I don't really need it. REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham

D23952: Remove panel toolbox and clean up editing options

2019-09-15 Thread Björn Feber
GB_2 updated this revision to Diff 66159. GB_2 added a comment. - Add back "Show Alternatives..." item and remove reference to panel toolbox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23952?vs=66105=66159 BRANCH arcpatch-D23952 REVISION

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-15 Thread Noah Davis
ndavis added a comment. The colorscheme selector does not work REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson,

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

2019-09-15 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Uh-oh, moving the button down to the lower row now causes the layout to get so wide with English that it overflows the default System Settings window size: F7357577:

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R124:e649d5a706b6: Improve keyboard navigation (authored by ognarb). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23975?vs=66154=66158 REVISION DETAIL

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
ognarb added a comment. Thanks, I will try to send a kirigami patch, if I don't send anything before the next weekend consider that I forgot ;p REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23975 To: ognarb, #plasma,

D23975: Improve keyboard navigation

2019-09-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, let's land this then, and fix it in Kirigami. Do you fancy sending a patch for that? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
ognarb added a comment. Looking at the behavior more in details. The 'bug' with a smaller screen should be fixed in kirigami instead. The focus is correct and I can move back the main category and select anoter subcategory. The problem is that Kirigami pageStack should display the page

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

2019-09-15 Thread Yunhe Guo
guoyunhe updated this revision to Diff 66157. guoyunhe added a comment. Similar filter layout as Colors KCM. Move "Scan Duplicates..." button to the bottom button group. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66101=66157 BRANCH

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. In D23868#532065 , @guoyunhe wrote: > Now I can get something like this (the QLineEdit and QPushButton still have different height): > > F7357403: image.png That's

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
ognarb planned changes to this revision. ognarb added a comment. In D23975#532059 , @ngraham wrote: > Definitely better than before! > > One use case still doesn't work though: Returning to the first column of the sidebar when you're in the

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

2019-09-15 Thread Yunhe Guo
guoyunhe added a comment. Now I can get something like this (the QLineEdit and QPushButton still have different height): F7357403: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe,

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. In D23868#532046 , @guoyunhe wrote: > In D23868#532016 , @ngraham wrote: > > > Maybe in the interests of #consistency , let's

D23975: Improve keyboard navigation

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. Definitely better than before! One use case still doesn't work though: Returning to the first column of the sidebar when you're in the second column and only a single column is visible (i.e. because the window is unmaximized). REPOSITORY R124 System Settings

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Since the tab view is dead, we should improve the keyboard navigation of the sidebar view TEST PLAN Played a bit with it, it

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

2019-09-15 Thread Yunhe Guo
guoyunhe added a comment. In D23868#532016 , @ngraham wrote: > Maybe in the interests of #consistency , let's make the filter feature look the same way that it does in the Colors KCM: F7357040:

D23952: Remove panel toolbox and clean up editing options

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. Oh, of course. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23952 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D23952: Remove panel toolbox and clean up editing options

2019-09-15 Thread Björn Feber
GB_2 added a comment. In D23952#532034 , @ngraham wrote: > Hmm, after applying and compiling all three patches and then restarting plasmashell, I still see the panel toolbox. That's because you still have the files and manually compiling

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-09-15 Thread Vlad Zahorodnii
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. In D22740#513873 , @marten wrote: > @GB_2 thanks for testing; a desktop UUID is obviously not friendly to show to the user, so there needs to be

D23952: Remove panel toolbox and clean up editing options

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. Hmm, after applying and compiling all three patches and then restarting plasmashell, I still see the panel toolbox. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23952 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel,

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. Maybe in the interests of #consistency , let's make the filter feature look the same way that it does in the Colors KCM: F7357040: Screenshot_20190915_131425.png REPOSITORY R119

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-09-15 Thread Jonathan Marten
marten updated this revision to Diff 66138. marten added a comment. Ignore the desktop ID and simply use the loop index, adjusted so that the desktop numbers start at 1. This is the same formatting as used by KWin (kwin/useractions.cpp) and the Task Manager applet

Re: Plasma 5.18 as LTS

2019-09-15 Thread Nate Graham
Presumably the next LTS Plasma version (5.18), which is slated for release in February of 2020[1]; plenty of time to get ready for the April 2020 release of Kubuntu 20.04 Nate [1] https://community.kde.org/Schedules/Plasma_5 On 9/15/19 5:31 AM, Elvis Stansvik wrote: Den fre 13 sep. 2019

Re: Plasma 5.18 as LTS

2019-09-15 Thread Elvis Stansvik
Den fre 13 sep. 2019 kl 18:13 skrev David Edmundson : > > Yes. Great thanks. Was just curious which Plasma we can look forward to in Kubuntu 20.04 (we use Kubuntu LTS versions at work). Elvis

KF6 Sprint

2019-09-15 Thread Volker Krause
Hi, as you might have seen in David's summary of the KF6 BoF at Akademy (https:// mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html), there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we had in Randa a few years back, to determine what we actually

D23952: Remove panel toolbox clean up editing options

2019-09-15 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY With D23951 we greatly improve the discoverability of the panel

D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode

2019-09-15 Thread Björn Feber
GB_2 updated this revision to Diff 66102. GB_2 added a comment. Don't hide "Lock Widgets" for panels REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23950?vs=66094=66102 BRANCH

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

2019-09-15 Thread Yunhe Guo
guoyunhe updated this revision to Diff 66101. guoyunhe added a comment. Unify button look REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66074=66101 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868 AFFECTED FILES