D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. In D24321#540056 , @davidedmundson wrote: > > it would go into Plasma 5.17. :) > > There's still a feature freeze. At least moving away from 0.1 increases is actually a bugfix. Look at my konsole

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Hi, I thought about this a bit more ;) I really think we shall limit the minimal increase to 0.25, without any advanced field. Perhaps the range should be larger, like 1-4, if some people get "really" high DPI screens. Rational: 1. For small 0.1

D24080: Fix copying urls to the clipboard

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:296fa55e21c0: Fix copying urls to the clipboard (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST

D24325: [runners/calculator] Port old style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D24324: [GTK2] Add program to libexec for GTK2 recoloration

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY There is now a Python program installed to a distro's libexec dir which will generate assets based

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

ngraham planned changes to this revision. ngraham added a comment. Anyway I'm going to see if the textfield-next-to-the-slider approach works better (in conjunction with a warning message). REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg,

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

davidedmundson added a comment. > it would go into Plasma 5.17. :) There's still a feature freeze. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel,

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ouwerkerk added a comment. Also side note, as a non-native English speaker I find "grossly" to be a bit of an odd adjective to use here -- "coarsely" would be more familiar: as in fine/coarse grained. Perhaps something to keep in mind when this lands and you start blogging about it :)

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ouwerkerk added a comment. Ideally you would also warn if the reciprocal times the horizontal, vertical resolution yields a non-integer output, not just if some value is chosen which cannot be represented in floating point exactly. E.g. on a 4K (3840 × 2160) a scaling factor of 1.5 is

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Btw., I think GNOME is more clever than us, too, they allow just sane scalings in the UI: https://www.omgubuntu.co.uk/2019/06/enable-fractional-scaling-ubuntu-19-04 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham,

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ngraham added a comment. In D24321#540026 , @GB_2 wrote: > The KDE HIG suggests something like this: https://hig.kde.org/_images/Slider.Speed.qml.png I kind of like this idea. Then if you set a weird value, an InlineMessage at the top

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ndavis added a comment. In D24321#540034 , @cullmann wrote: > And the custom scale factor dialog really should have some warning text like on Windows ;=) > > see e.g. > >

Re: ddcutil in Plasma Powerdevil

Rah that's dicky me trying to add the WITH_DDCUTIL symbol and propagate it to be used in a #ifdef in the actual code (ddcutilbrightness.{c, h}) I spent a lot of time trying to get it to work although it's probably basic cmake stuff... Hmm after a bit of research, is it possible that the

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. And the custom scale factor dialog really should have some warning text like on Windows ;=) see e.g. https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html (custom scale factor not

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ndavis added a comment. In D24321#540029 , @KonqiDragon wrote: > How about breeze icon of SimpleScreenRecorder #VDG ? > Maybe repaint digiKam icon to make SSR icon? > F7477107:

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

KonqiDragon added a comment. How about breeze icon of SimpleScreenRecorder #VDG ? Maybe repaint digiKam icon to make SSR icon? F7477107: Breezeicons-apps-48-digikam.svg.png REPOSITORY R104 KScreen REVISION

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. In D24321#540014 , @ngraham wrote: > In D24321#540011 , @cullmann wrote: > > > 0.05 is no good idea either ;) > > Just like 0.1 that is no 1/2, 1/4, 1/8, ... > > If

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

GB_2 added a comment. The KDE HIG suggests something like this: https://hig.kde.org/_images/Slider.Speed.qml.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n,

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ngraham added a comment. In D24321#540015 , @ndavis wrote: > what would be wrong with replacing the label with the spinbox? For normal control, use the slider. For fine control, use the spinbox. Then we wouldn't need an extra dialog.

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ndavis added a comment. what would be wrong with replacing the label with the spinbox? For normal control, use the slider. For fine control, use the spinbox. Then we wouldn't need an extra dialog. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham,

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ngraham added a comment. In D24321#540011 , @cullmann wrote: > 0.05 is no good idea either ;) > Just like 0.1 that is no 1/2, 1/4, 1/8, ... > If we really need something finer than 0.25, could we stick with 1/8 or 1/16? I don't

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. 0.05 is no good idea either ;) Just like 0.1 that is no 1/2, 1/4, 1/8, ... If we really need something finer than 0.25, could we stick with 1/8 or 1/16? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma,

Re: ddcutil in Plasma Powerdevil

https://build.neon.kde.org/job/bionic_unstable_kde_powerdevil_bin_amd64/127/console *17:40:13* CMake Error at CMakeLists.txt:56 (add_compile_definitions):*17:40:13* Unknown CMake command "add_compile_definitions". Is the cmake error I get for Powerdevil https://cgit.kde.org/powerdevil.git/

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

ngraham created this revision. ngraham added reviewers: VDG, Plasma, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now we have a problem in that the important scale factors of 1.25 and 1.75

D24289: Fix wrong KCM device icon for specific form factors

ngraham added a comment. I notice that the Bluetooth applet has the same icon issues. I wonder if we should put this function in plasma-framework so it can be used by lots of other things without having to duplicate it multiple times. REPOSITORY R115 Plasma Audio Volume Applet REVISION

D24289: Fix wrong KCM device icon for specific form factors

This revision was automatically updated to reflect the committed changes. Closed by commit R115:5f6b290728a8: Fix wrong KCM device icon for specific form factors (authored by sefaeyeoglu, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24305: [Cuttlefish] Compare an icon in different themes

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R118 Plasma SDK BRANCH comparison (branched from master) REVISION DETAIL https://phabricator.kde.org/D24305 To: davidre, #plasma, #vdg, ngraham Cc: ngraham,

D24264: edit mode action and dbus

ngraham added a comment. In D24264#539730 , @mart wrote: > I thought about it too, tough maybe if everything is visible (right now the resize handles and the bigger applet handle are linked in visibility) wouldn't look very messy and cluttered?

D24299: Fix "Show intro page" button not resetting titlebar title

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. this doesn't work for the case of clicking on one of the categories shown on the home page and then clicking on the home button. REPOSITORY R124 System Settings REVISION

D24194: Add per-origin media controls blacklist

broulik added inline comments. INLINE COMMENTS > fvogt wrote in action_popup.js:217 > Does this also hit all the frames inside? Effectively, yes. It asks the extension.js whether it knows any players on the given tab, which will include all frames, see the actual implementation of

D24194: Add per-origin media controls blacklist

fvogt added inline comments. INLINE COMMENTS > action_popup.js:217 > +TabUtils.getCurrentTab().then((tab) => { > +return sendMessage("mpris", "hasTabPlayer", { > +tabId: tab.id Does this also hit all the frames inside? REPOSITORY R856 Plasma

D24264: edit mode action and dbus

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in appletslayout.cpp:100 > But we only evaluate this when this window changes - doesn't that mean we > could when any other plasma window had focus and then loses it? different approach in

D24264: edit mode action and dbus

mart updated this revision to Diff 67071. mart added a comment. - move logic of out of editmode in shellcorona REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=66954=67071 BRANCH mart/editMode REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. In D22210#498933 , @fvogt wrote: > In D22210#498929 , @asturmlechner wrote: > > > drop

D24305: [Cuttlefish] Compare an icon in different themes

davidre updated this revision to Diff 67070. davidre added a comment. Show a symbol when a theme doesn't have the icon REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24305?vs=67053=67070 BRANCH comparison (branched from master) REVISION DETAIL

D24265: support global edit mode

mart updated this revision to Diff 67069. mart added a comment. - state machine for right order of opacity and visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=66955=67069 BRANCH mart/editMode REVISION DETAIL

Re: ddcutil in Plasma Powerdevil

I put ddcutils package in Neon unstable to be able to test it, using Sanford's packaging from Debian but with the libraries turned on. However powerdevil doesn't compile with DDCUtils turned on, it fails on a cmake error. Jonathan On Fri, 27 Sep 2019 at 07:14, Dorian Vogel wrote: > Hey

D24305: [Cuttlefish] Compare an icon in different themes

davidre added a comment. In D24305#539727 , @filipf wrote: > LGTM. Can the overlay be spawned in the vertical center of the window as well or is that defined in Kirigami itself? Also what happens when there are a lot of themes, does the overlay

D24264: edit mode action and dbus

mart added a comment. In D24264#538820 , @ngraham wrote: > I wonder if the widget resize handles should become visible all the time when in edit mode. Otherwise nothing visually changes with the widgets on the desktop, and it might not be

monday meeting notes for 30/9/2019

Nico Fe: * Ported Koko to Android * Needs more work to be useful For review: * Diff 24173 "Fix build against exiv for real" [Needs Review] https://phabricator.kde.org/D24173 * Diff 24175 "Don't use KDBusService on Android" [Needs Review] https://phabricator.kde.org/D24175 * Diff 24186 "Request

D24305: [Cuttlefish] Compare an icon in different themes

filipf added a comment. LGTM. Can the overlay be spawned in the vertical center of the window as well or is that defined in Kirigami itself? Also what happens when there are a lot of themes, does the overlay remain the same size and just get a scrollbar? REPOSITORY R118 Plasma SDK

D24305: [Cuttlefish] Compare an icon in different themes

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY The icon in different installed themes is shown in an overlay sheet. REPOSITORY R118 Plasma SDK BRANCH comparison (branched

D24304: [Cuttlefish] Add 48 to the sizeslider

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY The initial icon size Cuttlefish starts with is 48 (Kirigami.Unis.iconSizes.large). However this size cannot be selected using

D24265: support global edit mode

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > mart wrote in ToolBoxButton.qml:286 > latest revision should fix that actually, revision of D24263 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24265: support global edit mode

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > ngraham wrote in ToolBoxButton.qml:286 > Locking the widgets while in edit mode doesn't update the menu item, so it's > possible to end up in this state: > > F7448695: Screenshot_20190927_111420.png >