D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

dhaumann added a comment. Thanks Nate for the update, I think this is very transparent to users and makes using bad values by default a bit hardet. +1 for the patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

ndavis accepted this revision. ndavis added a comment. Visually, this looks fine. I'll leave the technical review to those who know more about that. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg, ndavis Cc: dhaumann,

D24351: [Cuttlefish] Synchronize sliders

This revision was automatically updated to reflect the committed changes. Closed by commit R118:28b1d5e2969d: [Cuttlefish] Synchronize sliders (authored by cblack). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24351?vs=67154=67157 REVISION DETAIL

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

ngraham updated this revision to Diff 67156. ngraham added a comment. Take two on the UI REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24321?vs=67087=67156 BRANCH advanced-scaling-control (branched from master) REVISION DETAIL

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Even with my hacks for https://bugreports.qt.io/browse/QTBUG-66036 in current KTextEditor master (see https://bugs.kde.org/show_bug.cgi?id=390451) you will still get after every xx lines some stray artifact in some cases during selection if you have some 1.1

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

dhaumann added a comment. As far as I understand, the reasoning of @cullmann is that 0.1 cannot be accurately be represented by a computer. Following this discussion , the

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Ok, I wasted one evening on the rendering artifacts stuff. https://bugreports.qt.io/browse/QTBUG-66036 I have now ugly workarounds in KTextEditor: 1. no anti-aliasing, else fillRect misses to fill 1 pixel at the borders by rounding errors 2. adjust

D24351: [Cuttlefish] Synchronize sliders

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 5.17 branch please REPOSITORY R118 Plasma SDK BRANCH sync-responsive-slider (branched from master) REVISION DETAIL https://phabricator.kde.org/D24351 To: cblack, #plasma, ngraham

D24351: [Cuttlefish] Synchronize sliders

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The two sliders (toolbar and responsive toolbar) now match eachother's values. The responsive

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. I got some more insight into https://bugreports.qt.io/browse/QTBUG-66036 If one turns off anti-aliasing, in KTextEditor most of the evil artifacts disappear, but not all. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. I will investigate the https://bugreports.qt.io/browse/QTBUG-66036 bug again, too :/ Even with the rounding issues one gets over larger multiplications, it shouldn't be that buggy for short ones. REPOSITORY R104 KScreen REVISION DETAIL

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Ok, tried Wayland now on my HiDPI setup. In Plasma's KCM I only have Scale 1x or 2x and that works ok, as one would think. But I see no way to set any more fine-grained scale to check if the scaling is nice for other values. The slider is for me only there for

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. In D24321#540437 , @romangg wrote: > In D24321#540433 , @cullmann wrote: > > > ;=) I talked only about the Qt HiDPI scaling code paths. > > > In this case I recommend

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

romangg added a comment. In D24321#540433 , @cullmann wrote: > ;=) I talked only about the Qt HiDPI scaling code paths. In this case I recommend studying the bug report I linked. There is also a patch attempt in Qt but it got closed for

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Hmm, I just tried here a Wayland session, and yes, the KCM has there just some 1x/2x combobox and my fonts are maximal ugly compared to some export QT_SCALE_FACTOR=2 + starting a Qt application (on Wayland). But I must try that at home on real HiDPI screens,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. ;=) I talked only about the Qt HiDPI scaling code paths. For any other scaling I don't care, as that should be application transparent, like you say. But if Wayland really just scales up the stuff via GL fonts will look terrible. And no, its non-trivial

D24264: edit mode action and dbus

mart added a comment. In D24264#540254 , @ngraham wrote: > In D24264#540228 , @GB_2 wrote: > > > Just showing the handles when you hover over a widget (or tap on one on touch) is fine IMO. > >

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

romangg requested changes to this revision. romangg added a comment. First the situation is different on X11 and Wayland: - On X11 KScreen sets Qt scale factors and some fonts dpi value through Xft. You can read it up here what was taken pretty much as it was from the old code:

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 67130. apol added a comment. move panelsourcecount into a separate file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66475=67130 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011

D24305: [Cuttlefish] Compare an icon in different themes

This revision was automatically updated to reflect the committed changes. Closed by commit R118:66d7bc83fc1e: [Cuttlefish] Compare an icon in different themes (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24305?vs=67120=67124

D24242: Port away from foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R122:e60894f87268: Port away from foreach (authored by nicolasfella). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24242?vs=66891=67123 REVISION DETAIL

D24305: [Cuttlefish] Compare an icon in different themes

ngraham accepted this revision. ngraham added a comment. You're right! Shipit. REPOSITORY R118 Plasma SDK BRANCH comparison (branched from master) REVISION DETAIL https://phabricator.kde.org/D24305 To: davidre, #plasma, #vdg, ngraham Cc: ngraham, filipf, plasma-devel, LeGast00n,

D24305: [Cuttlefish] Compare an icon in different themes

davidre added inline comments. INLINE COMMENTS > Comparison.qml:66 > +Item { > +id: wrapper > +Layout.preferredWidth: 128 https://doc.qt.io/qt-5/qt.html#AlignmentFlag-enum REPOSITORY R118 Plasma SDK BRANCH comparison (branched from

D24305: [Cuttlefish] Compare an icon in different themes

ngraham added inline comments. INLINE COMMENTS > davidre wrote in Comparison.qml:66 > I use it for centering the icon in the middle of the 128x128 free space for > the icon. `Qt.AlignCenter` is not enough for that. In the first version of > the diff I tried make up for that with setting of top

D24305: [Cuttlefish] Compare an icon in different themes

davidre added inline comments. INLINE COMMENTS > Comparison.qml:66 > +Item { > +id: wrapper > +Layout.preferredWidth: 128 I use it for centering the icon in the middle of the 128x128 free space for the icon. `Qt.AlignCenter` is not enough

D24305: [Cuttlefish] Compare an icon in different themes

ngraham added inline comments. INLINE COMMENTS > Comparison.qml:66 > +Item { > +id: wrapper > +Layout.preferredWidth: 128 Now you don't need this wrapper anymore; just use `Kirigami.Icon` directly and set `Layout.preferredWidth` and

D24304: [Cuttlefish] Add 48 to the sizeslider

This revision was automatically updated to reflect the committed changes. Closed by commit R118:37763ba7b84d: [Cuttlefish] Add 48 to the sizeslider (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24304?vs=67052=67121 REVISION DETAIL

D24305: [Cuttlefish] Compare an icon in different themes

davidre updated this revision to Diff 67120. davidre marked 3 inline comments as done. davidre added a comment. Use paint-none directly REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24305?vs=67118=67120 BRANCH comparison (branched from master)

D24305: [Cuttlefish] Compare an icon in different themes

ngraham added inline comments. INLINE COMMENTS > davidre wrote in Comparison.qml:70 > That's what I did first acutally but I didn't like that for two reasons. > First it would scale with the other icons and when you are looking at > paint-none you couldn't distinguish it anymore. In that case

D24305: [Cuttlefish] Compare an icon in different themes

davidre updated this revision to Diff 67118. davidre marked 4 inline comments as done. davidre added a comment. nitpicks REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24305?vs=67070=67118 BRANCH comparison (branched from master) REVISION DETAIL

D24305: [Cuttlefish] Compare an icon in different themes

davidre added inline comments. INLINE COMMENTS > Comparison.qml:70 > +height: comparisonSize > +source: modelData.iconPath > +} That's what I did first acutally but I didn't like that for two reasons. First it would

D24267: [soliduiserver] Port deprecated KPasswordDialog::setPixmap method

This revision was automatically updated to reflect the committed changes. Closed by commit R120:87b4c574108d: [soliduiserver] Port deprecated KPasswordDialog::setPixmap method (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24269: [krunner] Port old style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bbe4db6c9160: [krunner] Port old style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24269?vs=66964=67117 REVISION

D24305: [Cuttlefish] Compare an icon in different themes

ngraham added a comment. The QML is generally fine! Since you specifically requested it, I added nitpicky minor comments below. :) I don't consider them blockers, but feel free to take a look anyway! INLINE COMMENTS > Comparison.qml:1 > +import QtQuick 2.0 > +import QtQuick.Controls 2.5 as

D24264: edit mode action and dbus

ngraham added a comment. In D24264#540228 , @GB_2 wrote: > Just showing the handles when you hover over a widget (or tap on one on touch) is fine IMO. Yeah that's probably a reasonable compromise. REPOSITORY R120 Plasma Workspace

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

ngraham added a comment. In D24321#540218 , @davidedmundson wrote: > > For small 0.1 changes: Just change your font size, we did that always for the old non-hidpi world were displays did differ a bit in the DPI, that works without any

D24156: Don't require QtGui for the PaginateModel test

This revision was automatically updated to reflect the committed changes. Closed by commit R134:120ee5cbb571: Dont require QtGui for the PaginateModel test (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24156: Don't require QtGui for the PaginateModel test

leinir added a comment. In D24156#540238 , @apol wrote: > I'm not sure what we're winning, but sure. It allows the tests to be run on e.g. postmarketOS' CI - https://gitlab.com/postmarketOS/pmaports/merge_requests/639#note_220402081

D24156: Don't require QtGui for the PaginateModel test

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'm not sure what we're winning, but sure. REPOSITORY R134 Discover Software Store BRANCH dont-require-qtgui-for-paginatemodel-test (branched from master) REVISION DETAIL

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. In D24321#540218 , @davidedmundson wrote: > > For small 0.1 changes: Just change your font size, we did that always for the old non-hidpi world were displays did differ a bit in the DPI, that works without any

D24264: edit mode action and dbus

GB_2 added a comment. Just showing the handles when you hover over a widget (or tap on one on touch) is fine IMO. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24264 To: mart, #plasma Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n,

D24264: edit mode action and dbus

mart added a comment. As it can be seen there, we can have situations like applets going over the handle of another one or resize handles perfectly overlapping one another, and that can't be avoied technically, it looks simply broken (and no, i don't want to move everything inside the

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

davidedmundson added a comment. > For small 0.1 changes: Just change your font size, we did that always for the old non-hidpi world were displays did differ a bit in the DPI, that works without any glitches I even used to do this in the new high DPI world. Before Qt had fractional

D24333: sddm-theme: Set needsFullUserModel=false

fvogt updated this revision to Diff 67112. fvogt added a comment. Maybe now? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24333?vs=67111=67112 BRANCH arcpatch-D24333 REVISION DETAIL https://phabricator.kde.org/D24333 AFFECTED FILES

D24333: sddm-theme: Set needsFullUserModel=false

fvogt updated this revision to Diff 67111. fvogt added a comment. Maybe get rid of the unrelated change? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24333?vs=67110=67111 BRANCH lazymodel REVISION DETAIL https://phabricator.kde.org/D24333

D24333: sddm-theme: Set needsFullUserModel=false

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Otherwise SDDM has to load all users even if they're not shown. See https://github.com/sddm/sddm/pull/1017 TEST PLAN Using this for several

D24305: [Cuttlefish] Compare an icon in different themes

davidre added a comment. Thanks for accepting this so quickly! Does anyone have any comments on the code? I would like to improve my qml and any suggestion/best practice is welcome. REPOSITORY R118 Plasma SDK BRANCH comparison (branched from master) REVISION DETAIL