D24370: [KCM] Display scale factor as a percentage, not a decimal

ngraham added a comment. @romangg, are you good with this? REPOSITORY R104 KScreen BRANCH express-scale-factor-as-percentage (branched from master) REVISION DETAIL https://phabricator.kde.org/D24370 To: ngraham, #vdg, #plasma, romangg, ndavis Cc: ndavis, dhaumann, plasma-devel,

D24407: Increase UI commonality between KCM and applet

ngraham added a comment. Ping. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To: ngraham, #vdg, #plasma, drosca, broulik, sitter, sefaeyeoglu Cc: ndavis, GB_2, mmustac, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 438 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/438/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 09 Oct 2019 03:44:19 + Build duration: 2 min 58 sec and counting CONSOLE OUTPUT

D24486: [Notifications] Report effective Inhibited state on DBus

davidedmundson added inline comments. INLINE COMMENTS > server.h:49 > + */ > +Q_PROPERTY(bool inhibited READ inhibited WRITE setInhibited NOTIFY > inhibitedChanged) > + Having a property which doesn't read what you last wrote leads to very confusing QML. Sure you can make it work, but

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 437 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/437/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 08 Oct 2019 18:30:01 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT

D24503: Integrate the normal keyboard layout switcher

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in layout.js:38 > Do we also need a plasma upgrade script if we remove the SNI from kded/kwin I'd say so. We can do it when we deprecate the SNI though, unless you really want it now. I've never done it so I'll have to research

D24265: support global edit mode

ngraham added a comment. I would tend to agree. If we feel that it's too difficult to exit this mode, maybe we should make it more obvious, like changing the X button in the toolbox to a toolbutton with the "finish editing" text. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24265: support global edit mode

GB_2 added a comment. In D24265#543873 , @ngraham wrote: > I would tend to agree. If we feel that it's too difficult to exit this mode, maybe we should make it more obvious, like changing the X button in the toolbox to a toolbutton with the

D24265: support global edit mode

GB_2 added a comment. In D24265#543173 , @mart wrote: > hmm, not sure it's a bad thing, it all makes this mode to automatically exit.. which makes it almost a "quasimode", countering a bit the evils of being a modal ui When you are done

D24265: support global edit mode

mart added a comment. In D24265#541411 , @GB_2 wrote: > - when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click) with latest version of D24264

D24264: edit mode action and dbus

mart updated this revision to Diff 67518. mart added a comment. - don't trigger edit mode with right button REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=67185=67518 BRANCH mart/editMode REVISION DETAIL

D24503: Integrate the normal keyboard layout switcher

broulik added a comment. Do we need an update script to add this plasmoid to all existing setups? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24503 To: apol, #plasma Cc: broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24503: Integrate the normal keyboard layout switcher

davidedmundson added a comment. Makes sense, there's a lot of red and it's about to lead to more. I like that. INLINE COMMENTS > main.qml:45-47 > width: parent.width > height: parent.height > +anchors.centerIn: parent anchors.fill > layout.js:38 > - > -/*

D24503: Integrate the normal keyboard layout switcher

apol updated this revision to Diff 67514. apol added a comment. Send a sensible font size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24503?vs=67513=67514 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24503 AFFECTED FILES

D24503: Integrate the normal keyboard layout switcher

apol updated this revision to Diff 67513. apol added a comment. Remove unused function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24503?vs=67512=67513 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24503 AFFECTED FILES

D24503: Integrate the normal keyboard layout switcher

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This deprecates the SNI from KWin in favour of this plasmoid that will allow doing the same as well as

D24454: Include an emoji picker

apol updated this revision to Diff 67511. apol added a comment. Forgot to add these files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67486=67511 BRANCH arcpatch-D24454 REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED

D24479: [KCM] Make multi-screen draggability more obvious

ngraham updated this revision to Diff 67509. ngraham added a comment. Use Qt.SizeAllCursor REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24479?vs=67464=67509 BRANCH make-draggability-more-obvious (branched from master) REVISION DETAIL

D24479: [KCM] Make multi-screen draggability more obvious

GB_2 added a comment. What about using a SizeAllCursor, like the screen edge button in the Plasma panel edit mode? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24479 To: ngraham, romangg, #plasma, #vdg Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n,

D24501: Use MenuItem's action property directly in ActionMenuItem

apol added a comment. +1 INLINE COMMENTS > ActionMenuItem.qml:26 > > -property QtObject ourAction > - > -text: ourAction.text > -visible: ourAction.visible !== undefined ? ourAction.visible : true > -enabled: ourAction.enabled > -checkable: ourAction.checkable > -

D24501: Use MenuItem's action property directly in ActionMenuItem

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Now that Kirigami's Action is a QQC2 Action subclass we can use MenuItem's action

D24500: Be more explicit about action property types

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Now that Kirigami.Action is a Controls.Action, we can be more explicit about using

D24498: Properly check enabled state of Action for ActionToolBar buttons

apol added a comment. +1 otherwise INLINE COMMENTS > ActionToolBar.qml:126 > opacity: x + width <= parent.width > -enabled: opacity > +enabled: opacity && modelData.enabled > I'd do the enabled && opacity, it feels very wrong

D24499: Do not warn about LayoutDirection in SearchField

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Can you also fix the icon name? :) The "rtl" in the icon name refers to the direction of the icon (pointing from right to left), not for RTL languages. It must be "ltr" for

D24499: Do not warn about LayoutDirection in SearchField

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY LayoutDirection can only be used on visual items, Action is not one of those. So we

D24498: Properly check enabled state of Action for ActionToolBar buttons

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY The opacity binding overrides PrivateActionToolButton's enabled binding, which means

D24488: [kcm] Don't transform button to show rotated icon

ngraham added a comment. Hmm, the "no rotation" and "upside down" icons aren't accurate anymore (especially "no rotation"). REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24488 To: davidedmundson, #plasma Cc: ngraham, broulik, plasma-devel, LeGast00n,

D24471: [KRDB] Remove Oxygen-era colour exporting code

cblack added a comment. Some examples of exporting colours causing graphical artifacts: F7547873: image.png (Adapta) F7547889: image.png (Adwaita) F7547899: image.png

D24469: Allow the global drawer to become a menu if desired

mart added inline comments. INLINE COMMENTS > PageRowGlobalToolBarUI.qml:60 > > +Controls.ToolButton { > +id: menuButton try using PrivateActiontoolbutton, it should give the complete correct behavior for free REPOSITORY R169 Kirigami REVISION DETAIL

D24469: Allow the global drawer to become a menu if desired

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. conceptually i like it. I would like positioning the menu right under the button and having the button looking pressed as long as the menu is open (like the ... button does) INLINE COMMENTS

D24471: [KRDB] Remove Oxygen-era colour exporting code

cblack added a comment. In D24471#543487 , @broulik wrote: > > it seems to have defaulted to always on > > Yes, I did that because it makes sense. > > > (which is pretty rare) > > So, you're saying GTK2 themes are likely to follow

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 213 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/213/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 08 Oct 2019 13:03:33 + Build duration: 3 min 1 sec and counting CONSOLE OUTPUT [...truncated 113

D24470: feedback kcm: Use a horizontal slider like GammaRay does

broulik added inline comments. INLINE COMMENTS > main.qml:79 > +Component.onCompleted: { > +var found = false; > +var idx = modeOptions.findIndex(kcm.plasmaFeedbackLevel) Unused REPOSITORY R120 Plasma Workspace BRANCH master

D24194: Add per-origin media controls blacklist

broulik updated this revision to Diff 67492. broulik added a comment. - i18n for popup REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24194?vs=66924=67492 REVISION DETAIL https://phabricator.kde.org/D24194 AFFECTED FILES

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 212 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/212/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 08 Oct 2019 11:26:47 + Build duration: 2 min 59 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 08 Oct 2019 11:26:48 + Build duration: 1 min 55 sec and counting JUnit Tests Name:

D24488: [kcm] Don't transform button to show rotated icon

broulik added a comment. An alternative approach could have been to set a custom content item and rotate only that. But I actually quite like the the "arrow" in the new icons. (Also, why is this a switch in `Component.onCompleted` and not just bindings...) REPOSITORY R104 KScreen

D24488: [kcm] Don't transform button to show rotated icon

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Rotating a button leads to tooltips being broken, it will lead to shadows

D24194: Add per-origin media controls blacklist

broulik added a comment. Ping REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24194 To: broulik, #plasma, #vdg, fvogt, ognarb Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D5961: Adoption of KUserFeedback for Discover

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f1f1597f4f2e: Adoption of KUserFeedback for Discover (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5961?vs=67448=67487#toc REPOSITORY R134 Discover Software Store

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 211 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/211/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 08 Oct 2019 10:57:22 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT [...truncated 538

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/65/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 08 Oct 2019 10:57:22 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT

D24454: Include an emoji picker

apol marked an inline comment as done. apol added a comment. In D24454#543560 , @davidedmundson wrote: > From my POV, +1, though it would be worth outlining your longer term plans after this initial step. > > Right now it doesn't really use

D24454: Include an emoji picker

apol updated this revision to Diff 67486. apol added a comment. Add window title REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67485=67486 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24454: Include an emoji picker

davidedmundson added a comment. From my POV, +1, though it would be worth outlining your longer term plans after this initial step. Right now it doesn't really use the applet nor really do anything useful with IBUS, but I assume that's due to change. INLINE COMMENTS > emojier.qml:29 >

D24454: Include an emoji picker

apol updated this revision to Diff 67485. apol added a comment. Icon for recent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67484=67485 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24454: Include an emoji picker

apol updated this revision to Diff 67484. apol added a comment. Include a recent category, other comments addressed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67413=67484 BRANCH master REVISION DETAIL

D24223: [RFC] Add global themes that mimic other platforms' workflows

davidre added a comment. > Make it possible to have an auto-hiding panel that only appears when clicking on a button somewhere else: https://bugs.kde.org/show_bug.cgi?id=412483 I don't think the point matches the bug report entirely but maybe one could hack something like this together

D24479: [KCM] Make multi-screen draggability more obvious

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in Output.qml:273 > This is against the laws of Physics. > I suspect it just erroring out (possibly `rowCount` requiring a `QModelIndex` > argument) and just always staying visible. Or the KCM re-creating the > `outputModel`

D24486: [Notifications] Report effective Inhibited state on DBus

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The inhibition handling (e.g. combining time-based, screen mirrored, etc) is done inside

D24479: [KCM] Make multi-screen draggability more obvious

broulik added inline comments. INLINE COMMENTS > ngraham wrote in Output.qml:273 > Nah it totally works! :) This is against the laws of Physics. I suspect it just erroring out (possibly `rowCount` requiring a `QModelIndex` argument) and just always staying visible. Or the KCM re-creating the

D24471: [KRDB] Remove Oxygen-era colour exporting code

broulik added a comment. > it seems to have defaulted to always on Yes, I did that because it makes sense. > (which is pretty rare) So, you're saying GTK2 themes are likely to follow color schemes but GTK3 are not? > (including Breeze GTK) primarily use pixmaps

D24471: [KRDB] Remove Oxygen-era colour exporting code

cblack added a comment. In D24471#543156 , @broulik wrote: > I don't understand what this is solving. Did this work before, if so, what broke it, that suddenly requires this patch? Well, since the checkbox to toggle this code was removed