D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Nathaniel Graham]

ngraham added a comment.


  In D24483#544500 , @spstarr wrote:
  
  > 'breez' or breeze' just curious here
  
  
  That's to match both "breeze" and "breezy".
  
  I'll wait to land this until we get a real `weather-wind` icon.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  windy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma, spstarr
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting updated this revision to Diff 67585.
whiting added a comment.


  - Add speech synthesis engine selection combobox to general klipper settings 
page.
  
  Rebased on master.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24276?vs=66980&id=67585

BRANCH
  speech

REVISION DETAIL
  https://phabricator.kde.org/D24276

AFFECTED FILES
  CMakeLists.txt
  klipper/CMakeLists.txt
  klipper/configdialog.cpp
  klipper/generalconfig.ui
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/klipper.kcfg
  klipper/tts.cpp
  klipper/tts.h

To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24471: [KRDB] Remove Oxygen-era colour exporting code

[Carson Black]

cblack planned changes to this revision.
cblack added a comment.


  So it turns out I ran into an unrelated bug that at first glance appeared to 
be the linked bug with my setup, but in reality, it's actually unrelated.
  
  Regarding that, I'm not sure how useful this patch actually is in terms of 
fixing the bug that was linked here.
  
  Looks like I'll be going back to the drawing board for this bug.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24471

To: cblack, #plasma, ngraham
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Shawn Starr]

spstarr added a comment.


  We do need another icon, Wind would be generic for Dust storm, or Blowing 
smoke, Blowing snow in this case.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  windy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma, spstarr
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Shawn Starr]

spstarr added a comment.


  'breez' or breeze' just curious here

REPOSITORY
  R120 Plasma Workspace

BRANCH
  windy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma, spstarr
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Shawn Starr]

spstarr added a comment.


  No degree, but I have been following weather for years and on some mailing 
lists with meteorologists. 'Wind' can be a weather condition especially if its 
a dust storm. If NOAA lists it as a weather condition.
  
  I think this is fine.
  
  In Canada we do have Wind as an weather condition though usually its specific 
to winter, such as 'Blowing snow' as a condition.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24474: Show menu items tooltip text

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0993c1c70678: Show menu items tooltip text (authored by 
apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24474?vs=67449&id=67583#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24474?vs=67449&id=67583

REVISION DETAIL
  https://phabricator.kde.org/D24474

AFFECTED FILES
  src/controls/private/ActionMenuItem.qml

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Overall this doesn't look like the proper fix to me. A setter should not do 
anything if we pass the current value to it. From your description it seems to 
indicate that a call to setTheme is missing in some situations, I think it'd 
lead to a better fix if the exact condition when this happens is determined and 
then the extra setTheme call inserted just then. Changing a setter semantic to 
get a side-effect looks wrong to me.

INLINE COMMENTS

> previewwidget.h:34
>  Q_PROPERTY(int currentIndex READ currentIndex WRITE setCurrentIndex 
> NOTIFY currentIndexChanged)
> -Q_PROPERTY(int currentSize READ currentSize WRITE setCurrentSize NOTIFY 
> currentSizeChanged)
> +Q_PROPERTY(int currentSize WRITE setCurrentSize)
>  

I'd keep it as is for the reasons I mentioned in another patch: avoid write 
only properties, it's really annoying on the QML side.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24520

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24519: Delegate KCM cursor theme config management to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmcursortheme.cpp:335
>  
> +int CursorThemeConfig::cursorSizeIndex(const int cursorSize) const
> +{

int, not const inst

> kcmcursortheme.cpp:349
>  
> -void CursorThemeConfig::save()
> +int CursorThemeConfig::cursorSizeFromIndex(int row)
>  {

s/row/index/

> kcmcursortheme.h:50
>  Q_PROPERTY(bool downloadingFile READ downloadingFile NOTIFY 
> downloadingFileChanged)
> +Q_PROPERTY(int preferredSize WRITE setPreferredSize)
>  

This is rather unusual, could we have a full fledged property here despite the 
boilerplate? I'm thinking of the future developer who might get bitten when 
changing the QML code and having a half working property.

> kcmcursortheme.h:79
>  
> +Q_INVOKABLE int cursorSizeIndex(const int cursorSize) const;
> +Q_INVOKABLE int cursorSizeFromIndex(int row);

int, not const int

> kcmcursortheme.h:80
> +Q_INVOKABLE int cursorSizeIndex(const int cursorSize) const;
> +Q_INVOKABLE int cursorSizeFromIndex(int row);
> +Q_INVOKABLE int cursorThemeIndex(const QString &cursorTheme) const;

s/row/index/ I'd say.

> kcmcursortheme.h:82
> +Q_INVOKABLE int cursorThemeIndex(const QString &cursorTheme) const;
> +Q_INVOKABLE QString cursorThemeFromIndex(int index) const;
>  Q_SIGNALS:

nitpick: Please add an empty line after that one.

> bport wrote in main.qml:99
> After testing seems to be not broken.
> the binding is set to a method that transorm current size value to index 
> (kcm.cursorSizeIndex do that)

David has a point, the binding of currentIndex will be broken as soon as the 
user changes the entry in the combo box.

That being said, IIRC this shouldn't matter much in that context though, 
because we seem to be just after pre-selecting the right entry in the combo box 
when the module is displayed and not always enforcing a currentIndex value 
(which we can't in the context of combo box as David pointed out).

What matters is that the settings get properly updated when the user select a 
new entry in the combo box which is handled with onActivated just fine.

> sortproxymodel.h:25
>  #include 
> +#include 
>  

Why is that include added? This doesn't seem necessary to me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24519

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24518: On KCM cursor theme update attribute name

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmcursortheme.cpp:383
>  {
> +m_settings->load();
>  // Get the name of the theme KDE is configured to use

This seems unrelated to that change. Did you mean to have that in the previous 
commit?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24518

To: bport, #plasma, mart, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24517: Port kcm cursor to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davidedmundson wrote in CMakeLists.txt:22
> Can you also  add
> 
>   install(FILES kded/touchpaddaemon.kcfg
>   DESTINATION ${KDE_INSTALL_KCFGDIR})
> 
> This doesn't explicitly do anything useful, but it allows future metadata 
> extraction for documentation purposes.

Interestingly you didn't request that on my desktoptheme work.

> cursorthemesettings.kcfg:9
> +  QX11Info
> +  X11/Xcursor/Xcursor.h
> +  

Why those includes? They seem unused now since you're not having code in 
defaults.

> davidedmundson wrote in kcmcursortheme.cpp:72
> I assume Kevin's patch set fixes this?

Yes, giving a bit more time to people to review the latest revisions of my 
KConfig patches. They changed quite a bit and I didn't get further comment yet.

> kcmcursortheme.h:127
>  QPersistentModelIndex m_appliedIndex;
> -
>  /** Holds the last size that was chosen by the user. Example: The user 
> chooses

Why the empty line removal? The previous line is now stuck with the comment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24517

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Some might consider it a nitpick, but I like a history as clean as possible. 
;-)

INLINE COMMENTS

> kcmcursortheme.cpp:51
>  
> +//#include "cursorthemesettings.h"
>  #include 

Shouldn't be in that patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24516

To: bport, #plasma, mart, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM! Would be nice to fix some of these bugs in follow-up patches too: 
https://bugs.kde.org/buglist.cgi?component=kcm_baloo&list_id=1669138&product=systemsettings&resolution=---

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24523: Disable dragging global drawer when in menu mode

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When the drawer is in menu mode it is still possible to drag the drawer open 
from the edge of the window. Disable the drawer to prevent that

TEST PLAN
  Tested with and without menumode on desktop and mobile

REPOSITORY
  R169 Kirigami

BRANCH
  drag

REVISION DETAIL
  https://phabricator.kde.org/D24523

AFFECTED FILES
  src/controls/GlobalDrawer.qml

To: nicolasfella, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24224: Start of the accessibility KCM

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Why is `kcms/colors/CMakeLists.txt` being changed? Looks unrelated.
  
  As a general UI principle, whenever you have a group of controls that's 
mostly checkboxes, don't use formal section headers; instead, give the first 
checkbox a label by moving your `Kirigami.FormData.label` into it rather than 
putting it inside a separate `Item` or `Separator`.
  
  Also often it's better to use whitespace instead of formal separator lines. 
It looks cleaner. Not always, but often.
  
  So you would wind up with something that looks more like this: F7558383: 
Screenshot_20191009_123431.png .
  (those labels are way too long, which is another matter)
  
  In terms of a general UI design, I don't think tabs work here. There are too 
many tabs and they get cut off and look terrible with the default window size: 
F7558396: Screenshot_20191009_123558.png 
  I imagine this is even worse with wordier languages like German or Brazilian 
Portuguese.
  
  Instead, I think a better UI would be to have the tab chooser be a vertical 
list, like in the Notifications KCM: F7558412: Screenshot_20191009_123654.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham
Cc: mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24519: Delegate KCM cursor theme config management to KConfigXT

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:99
> I think this will be broken if you change this combo box, then change theme.
> 
> When a user explicitly changes this combo box this binding gets broken with 
> currentIndex now reflecting an explicit number.
> 
> On theme change cursorThemeSettings.cursorSize changes correctly but our 
> binding is gone.
> 
> This might have to be a connection again

After testing seems to be not broken.
the binding is set to a method that transorm current size value to index 
(kcm.cursorSizeIndex do that)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24519

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67572.
tcanabrava added a comment.


  - Fix Strings
  - Fix margins

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67568&id=67572

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  this now depends on https://phabricator.kde.org/D23835 - There's an issue 
with saving (the save is not activated for some reason, I need to investigate.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67571.
tcanabrava added a comment.


  - Use Plasma KCM
  - Adapt to FormLayout
  - Fix label
  - Space every tab equally
  - Form layout port
  - FormLayout
  - Simplify Qml
  - Port to Form Layout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=66834&id=67571

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:e358aa840a34: Fix a number of issues found by the 
OpenSuse security team in networkhelper (authored by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24359?vs=67179&id=67570

REVISION DETAIL
  https://phabricator.kde.org/D24359

AFFECTED FILES
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/Accumulator.h
  plugins/process/network/helper/Capture.cpp
  plugins/process/network/helper/Capture.h
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/Packet.cpp
  plugins/process/network/helper/Packet.h

To: ahiemstra, #plasma, maltek
Cc: maltek, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24514: [XembedSNIProxy] Do not crash on null pointer

[Nathaniel Graham]

ngraham added a comment.


  Does this really fix 356937? That seems to be about something other than a 
crash. Did you mean 409652 instead?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24514

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added a comment.


  Almost done, just a tiny bit of polish is needed! See inline comments:

INLINE COMMENTS

> kcm.cpp:61
>  KAboutData* about = new KAboutData(
>  QStringLiteral("kcm_baloofile"), i18n("Configure File Search"),
>  QStringLiteral("0.1"), QString(), KAboutLicense::GPL,

Make this match the name shown in the list ("File Search")

> main.qml:32
> +
> +KCM.ConfigModule.quickHelp: i18n("This module lets you configure the 
> search in the system.")
> +ColumnLayout {

"This module lets you configure the file indexer and search functionality."

> main.qml:36
> +Layout.leftMargin:  Kirigami.Units.smallSpacing * 2
> +Layout.rightMargin: Kirigami.Units.smallSpacing * 2
> +

This item isn't inside a Layout, so `Layout.` has no effect. You want 
`anchors.` instead.

Also the margins should be `Kirigami.Units.largeSpacing`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava marked 2 inline comments as done.
tcanabrava added a comment.


  I still need to play a bit with the folder save / load. the code from the old 
kcm is quite strange. it saves "included folders", but there's nothing using 
that. perhaps it's safer if we just remove everything that's not used.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67568.
tcanabrava added a comment.


  - fix Comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67567&id=67568

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67567.
tcanabrava marked 7 inline comments as done.
tcanabrava added a comment.


  - Simplify Checkboxes
  - Fix previouslyEnabled logic
  - Tell Qml that we have the values
  - Move code around
  - Fix QSet math
  - Qml gives us a Url, we want the Local file
  - use folderAdded and folderRemoved
  - Remove debug information
  - Add spacing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67563&id=67567

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Nathaniel Graham]

ngraham added a comment.


  I'm not sure I really understand the proposal. As far as I'm aware, you're 
the maintainer, so I'll accept with your wishes. All I really care about is 
that my weather forecast stops looking like this all the time: :-)
  
  F7557163: Screenshot_20191009_095550.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24483#544263 , @ngraham wrote:
  
  > To me it makes conceptual sense to display windiness when it's not 
including other severe weather conditions. In those cases, you care more about 
the other conditions than the fact that it's also windy.
  
  
  Different people care about different aspects, and different things are 
severe to them. Someone with a garden might not care about wind, but about 
precipitation. Someone driving a truck will care about wind, but not about rain 
or cloudyness. People commuting by bicycle will care for both. And so on.
  
  > For example if the wind accompanies rain or a storm, the fact that it's 
windy is not very interesting; what you're focusing on is the fact that it's a 
storm! If there's a tornado, of course it's also windy... 
  >  but what you need to be focusing on is the tornado! (this is also a 
condition we don't currently handle)
  
  Yes, chance of tornado, sandstorms, glaze, etc, are something someone (tm) 
should care for one day. But...
  
  > So I would probably favor showing a "windy" icon when it's only windy, or a 
"windy and cloudy" icon when the wind is accompanies by cloudiness as well.
  
  Sounds like you imply sunny with "windy" :) And cloudy is usually not a 
severe condition, unless one is out to watch the stars or pulling solar 
electricity, or? Sunny rather would be severe, e.g. putting human skin into 
danger.
  
  So far I had considered the main condition icon to be a hint to a typical 
pattern of weather, roughly represented by the icon. And not being the place to 
also hint to chances of potential exteme conditions, that would be a separate 
thing (to be done).
  
  And by what I understand the "it's windy" having not deeply researched 
things, it means here "as usual for this type of year here, so we will not 
explitily mention it, but additionally windy".

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

[Malte Kraus]

maltek accepted this revision.
maltek added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Thanks for the quick reaction (and sorry for my slow one!)
  
  > Which is a bit different, as it implies (to me) that the loop will still 
exit the next time the thread is woken up from its blocking call. Which is 
fine, the thread will be woken up when the next packet arrives and then exit.
  
  Fair enough. Maybe I was a bit quick with my judgement there.

REPOSITORY
  R106 KSysguard

BRANCH
  secteam_fixes

REVISION DETAIL
  https://phabricator.kde.org/D24359

To: ahiemstra, #plasma, maltek
Cc: maltek, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Hmm, I have some UX concerns here after trying it out:
  
  If I invoke Present Windows to see the desktop so that I can right-click on 
it to enter edit mode, when I exit the mode, all the windows return again 
unexpectedly. Exiting edit mode should only restore the windows if the Present 
Windows effect was invoked by entering edit more, not if it was already invoked 
manually by the user
  
  While in Edit mode, if I click on the desktop, it exits edit mode. This feels 
very unnatural and I find myself accidentally exiting the mode a lot. I think 
it makes sense to automatically exit the mode when another application is 
focused, but not the Plasma desktop itself.
  
  If we're eventually going to hide the "Lock Widgets" functionality from the 
context menu, we need to remove it from the toolbox as well, or else you can 
enter edit mode, lock widgets, and be unable to re-enter edit mode because the 
menu item to do it is disabled when widgets are locked (maybe this should be in 
another patch though?)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  See inline comments.
  
  Also functionality-wise there are some problems:
  
  1. When a new entry is added, if the KCM is closed and re-opened, the new 
entry has been forgotten
  2. When you add a path, the ugly URL schema bit doesn't get stripped off like 
it should: F7556828: Screenshot_20191009_090737.png 


INLINE COMMENTS

> filteredfoldermodel.cpp:147
> +
> +Q_FOREACH (const QString& mount, m_mountPoints) {
> +if (url.startsWith(mount) && mount.size() > mountPoint.size())

Don't use Q_FOREACH in new or ported code

> main.qml:23
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.12 as QQC2
> +import QtQuick.Dialogs 1.2 as QtDialogs

IIRC plasma isn't depending on Qt 5.12 yet, right?

> main.qml:39
> +QQC2.Label {
> +text: i18n("File Search helps you quickly locate all your files 
> based on their content")
> +}

This is a sentence, so it needs to end with a period.

> main.qml:47
> +onCheckStateChanged: {
> +if (!checkState === Qt.Unchecked) {
> +indexFileContents.checked = false;

This can be simplified to just `if (!checked)`

> main.qml:50
> +}
> +kcm.indexing = fileSearchEnabled.checked
> +}

Don't need to reference it with `fileSearchEnabled`, just do `kcm.indexing = 
checked`

> main.qml:53
> +
> +Component.onCompleted : {
> +fileSearchEnabled.checked = kcm.indexing ? Qt.Checked : 
> Qt.Unchecked

Don't do it this way, just use a binding:

`checked: kcm.indexing`

> main.qml:69
> +indexFileContents.checked = kcm.fileContents ? Qt.Checked : 
> Qt.Unchecked
> +}
> +}

Same comments as with the first checkbox

> main.qml:71
> +}
> +
> +QQC2.Label {

I would add some spacing between the last checkbox and the list view's 
explanatory label:

  Item {
  Layout.preferredHeight: Kirigami.Units.gridUnit
  }

> GB_2 wrote in main.qml:2
> Shouldn't this be you copyright?

Not done yet

> nicolasfella wrote in metadata.desktop:3
> That comment sounds wrong :)

Not done yet

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  latest version of D24264  does show the 
desktop when in edit mode (and as sideeffect edit mode doesn't close when the 
widget explorer is closed)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24519: Delegate KCM cursor theme config management to KConfigXT

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:99
>  textRole: "display"
> +currentIndex: 
> kcm.cursorSizeIndex(kcm.cursorThemeSettings.cursorSize);
>  onActivated: {

I think this will be broken if you change this combo box, then change theme.

When a user explicitly changes this combo box this binding gets broken with 
currentIndex now reflecting an explicit number.

On theme change cursorThemeSettings.cursorSize changes correctly but our 
binding is gone.

This might have to be a connection again

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24519

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24264: edit mode action and dbus

[Marco Martin]

mart updated this revision to Diff 67564.
mart added a comment.


  - show desktop when in edit mode

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24264?vs=67518&id=67564

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24264

AFFECTED FILES
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/itemcontainer.cpp
  containmentactions/contextmenu/menu.cpp
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp

To: mart, #plasma, #vdg
Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Nathaniel Graham]

ngraham added a comment.


  To me it makes conceptual sense to display windiness when it's not including 
other severe weather conditions. In those cases, you care more about the other 
conditions than the fact that it's also windy. For example if the wind 
accompanies rain or a storm, the fact that it's windy is not very interesting; 
what you're focusing on is the fact that it's a storm! If there's a tornado, of 
course it's also windy... but what you need to be focusing on is the tornado! 
(this is also a condition we don't currently handle)
  
  So I would probably favor showing a "windy" icon when it's only windy, or a 
"windy and cloudy" icon when the wind is accompanies by cloudiness as well.
  
  Does that makes sense? I'm also not a meteorologist. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I don't understand this patch in relation to the title. 
  If no-one uses this property this shouldn't make a difference?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24520

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24517: Port kcm cursor to KConfigXT

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> davidedmundson wrote in CMakeLists.txt:22
> Can you also  add
> 
>   install(FILES kded/touchpaddaemon.kcfg
>   DESTINATION ${KDE_INSTALL_KCFGDIR})
> 
> This doesn't explicitly do anything useful, but it allows future metadata 
> extraction for documentation purposes.

Ok I will add it

> davidedmundson wrote in kcmcursortheme.cpp:72
> I assume Kevin's patch set fixes this?

Yes but kevin patch is not yet merged.
However  we will need to go throught this code a second time after Kevin's 
patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24517

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67563.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml
  - Name fixes
  - Move ui/main to contents
  - Fix wrong types in Qml
  - Plug the controllers
  - Link to the save button
  - Fix borders and background for the Baloo KCM
  - Use kirigami BasicListItem
  - Spacing
  - Fix mapping of roles
  - Fix delegate / Mouse integration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=66643&id=67563

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24483#544189 , @ngraham wrote:
  
  > Where I live (in the desert), we often have days that are very windy with 
no clouds or rain, especially in the springtime. On such days, the data engine 
always falls back to `IonInterface::NotAvailable`, which is not accurate; a 
forecast //is// available, but we're not handling it.
  
  
  Not disputing that this should be handled.
  
  > Since this new condition is at the end of the conditional, it won't be 
triggered unless it really is windy with no other conditions.
  
  Yes, still curious what this general condition description implies for the 
other conditions, as it also might affect the icon to be done, so what is 
iconic for "weather-wind".
  
  Someone might do an icon showing fast-moving clouds, which would then not be 
matching the windy days as you described.
  
  > I agree that the proposed icon is not very good. I would be okay with 
delaying this until we have a real `weather-wind` icon if you would prefer.
  
  Yes, I would first like to see a narrowing definition what the weather-wind 
icon should be about, as people living in different climatic zones might have 
totally diferent associations. I would have never thought about wind in deserts 
:)
  
  So seems "wind" here could be meant as: moving airmasses also near ground, 
otherwise usual weather conditions in the given area/time of year, thus not 
mentioned?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24517: Port kcm cursor to KConfigXT

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> CMakeLists.txt:22
>  set(kcm_cursortheme_PART_SRCS kcmcursortheme.cpp ${libnoinst_SRCS})
> -
> +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc 
> GENERATE_MOC)
>  add_library(kcm_cursortheme MODULE ${kcm_cursortheme_PART_SRCS})

Can you also  add

  install(FILES kded/touchpaddaemon.kcfg
  DESTINATION ${KDE_INSTALL_KCFGDIR})

This doesn't explicitly do anything useful, but it allows future metadata 
extraction for documentation purposes.

> kcmcursortheme.cpp:72
> +// Unfortunately doesn't generate a ctor taking the parent as parameter
> +m_settings->setParent(this);
>  qmlRegisterType("org.kde.private.kcm_cursortheme", 1, 0, 
> "PreviewWidget");

I assume Kevin's patch set fixes this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24517

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 216 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/216/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 09 Oct 2019 14:41:14 +
 Build duration:
2 min 58 sec and counting
   CONSOLE OUTPUT
  [...truncated 113 lines...][2019-10-09T14:43:05.998Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-10-09T14:43:06.001Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-09T14:43:07.218Z] Checking out Revision 7db3c74d0335682a78bbcb741325004b36a68a90 (origin/master)[2019-10-09T14:43:06.106Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-10-09T14:43:06.201Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2019-10-09T14:43:06.202Z]  > git fetch --tags --force --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-09T14:43:07.169Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-10-09T14:43:07.431Z] Commit message: "Merge remote-tracking branch 'origin/Applications/19.08'"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2019-10-09T14:43:07.260Z]  > git config core.sparsecheckout # timeout=10[2019-10-09T14:43:07.262Z]  > git checkout -f 7db3c74d0335682a78bbcb741325004b36a68a90 # timeout=10[2019-10-09T14:43:11.039Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project discover --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-09T14:43:15.091Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-09T14:43:15.604Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-09T14:43:15.604Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-09T14:43:16.119Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-09T14:43:16.119Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-09T14:43:16.635Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-09T14:43:17.149Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-09T14:43:17.662Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-09T14:43:17.662Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-09T14:43:18.738Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-09T14:43:18.738Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-09T14:43:19.251Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-09T14:43:20.330Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-09T14:43:20.330Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-09T14:43:22.031Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-09T14:43:23.108Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-09T14:43:23.108Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-09T14:43:23.108Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-09T14:43:23.621Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-09T14:43:23.621Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-09T14:43:24.135Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-09T14:43:24.647Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-09T14:43:25.160Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-09T14:43:25.160Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-09T14:43:25.160Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-09T14:43:25.160Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-09T14:43:25.673Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-09T14:43:28.842Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-09T14:43:29.354Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-09T14:43:29.354Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-09T14:43:29.354Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-09T14:43:29.354Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-09T14:43:29.868Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-09T14:43:34.414Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-09T14:43:34.414Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-09T14:43:35.491Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-09T14:43:35.491Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-09T14:43:36.003Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-09T14:43:36.516Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-09T14:43:38.218Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-09T14:43:38.735Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-09T14:43:39.249Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-09T14:43:40.956Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-09T14:43:40.956Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-09T14:43:42.028Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-09T14:43:42.538Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-09T14:43:43.615Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-09T14:43:54.533Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-09T14:43:56.232Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-09T14:43:56.746Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-09T14:43:57.825Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-09T14:43:58.339Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-09T14:44:00.

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, mart, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24520

AFFECTED FILES
  kcms/cursortheme/xcursor/previewwidget.cpp
  kcms/cursortheme/xcursor/previewwidget.h

To: bport, #plasma, mart, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24519: Delegate KCM cursor theme config management to KConfigXT

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, mart, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24519

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/Delegate.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/cursortheme/xcursor/sortproxymodel.h

To: bport, #plasma, mart, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24518: On KCM cursor theme update attribute name

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, mart, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Rename m_model to m_themeModel and selectedIndex to themeSelectedIndex
  to avoid confusion because we have two models in this class.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24518

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, mart, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24517: Port kcm cursor to KConfigXT

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, mart, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  - Allow code reuse

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24517

AFFECTED FILES
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemesettings.kcfg
  kcms/cursortheme/cursorthemesettings.kcfgc
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, mart, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, mart, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24516

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, mart, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Nathaniel Graham]

ngraham added a comment.


  Where I live (in the desert), we often have days that are very windy with no 
clouds or rain, especially in the springtime. On such days, the data engine 
always falls back to `IonInterface::NotAvailable`, which is not accurate; a 
forecast //is// available, but we're not handling it.
  
  Since this new condition is at the end of the conditional, it won't be 
triggered unless it really is windy with no other conditions.
  
  I agree that the proposed icon is not very good. I would be okay with 
delaying this until we have a real `weather-wind` icon if you would prefer.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Disclaimer: nowhere a meteorologist myself, kitchen talk quality at best :)
  
  I have to tell I have no idea how "wind" actually matches the category and 
what general cloud/sky conditions could be derived. Where I have lived, wind as 
in: fast moving air masses with resulting air turbulence near the ground has 
been happening with clear sky, cloudy sky, overcast & all kinds of 
precipitation or not. I cannot remember wind to have been the main weather 
property describing the overall condition, unless perhaps being a storm, which 
then usually implies very cloudy sky.
  So for me wind always has been its own separate category, reported next to 
cloudiness and precipitation which both would be used to describe the main 
condition.
  
  The proposed placeholder icon also would not have matched my immediate idea 
if someone said "a windy day" where I would have rather expected a mix of 
clouds and sun. Actually fog would rather be seen with no wind usually?
  
  Do we have a definition what NOAA means when they talk about "windy day", so 
there is an idea what overall condition properties would be mapped onto this 
term instead of any of the others?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma
Cc: plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 215 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/215/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 09 Oct 2019 14:04:29 +
 Build duration:
1 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 113 lines...][2019-10-09T14:05:24.105Z] Checking out Revision 7db3c74d0335682a78bbcb741325004b36a68a90 (origin/master)[2019-10-09T14:05:24.128Z] Commit message: "Merge remote-tracking branch 'origin/Applications/19.08'"[Pipeline] }[2019-10-09T14:05:23.838Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-10-09T14:05:23.840Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-09T14:05:23.847Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-10-09T14:05:23.852Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2019-10-09T14:05:23.852Z]  > git fetch --tags --force --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-09T14:05:24.102Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-10-09T14:05:24.106Z]  > git config core.sparsecheckout # timeout=10[2019-10-09T14:05:24.107Z]  > git checkout -f 7db3c74d0335682a78bbcb741325004b36a68a90 # timeout=10[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2019-10-09T14:05:25.043Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project discover --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-09T14:05:28.315Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-09T14:05:28.315Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-09T14:05:28.573Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-09T14:05:28.573Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-09T14:05:28.573Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-09T14:05:28.832Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-09T14:05:29.088Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-09T14:05:29.345Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-09T14:05:29.345Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-09T14:05:29.345Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-09T14:05:29.602Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-09T14:05:29.860Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-09T14:05:30.117Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-09T14:05:30.117Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-09T14:05:30.376Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-09T14:05:30.632Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-09T14:05:30.889Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-09T14:05:30.889Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-09T14:05:33.407Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-09T14:05:33.407Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-09T14:05:33.407Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-09T14:05:33.407Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-09T14:05:33.407Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-09T14:05:33.407Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-09T14:05:35.935Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-09T14:05:36.195Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-09T14:05:36.195Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-09T14:05:37.130Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-09T14:05:37.694Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-09T14:05:37.694Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-09T14:05:37.694Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-09T14:05:37.694Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-09T14:05:37.

D24499: Do not warn about LayoutDirection in SearchField

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0115ad12b25a: Do not warn about LayoutDirection in 
SearchField (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24499?vs=67541&id=67553

REVISION DETAIL
  https://phabricator.kde.org/D24499

AFFECTED FILES
  src/controls/SearchField.qml

To: ahiemstra, #kirigami, broulik, ognarb, mart
Cc: ognarb, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D24498: Properly check enabled state of Action for ActionToolBar buttons

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
ahiemstra marked an inline comment as done.
Closed by commit R169:4479e865be45: Properly check enabled state of Action for 
ActionToolBar buttons (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24498?vs=67543&id=67552

REVISION DETAIL
  https://phabricator.kde.org/D24498

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami, ngraham, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
davidedmundson, mart, hein

D24501: Use MenuItem's action property directly in ActionMenuItem

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a1773a7d42c7: Use MenuItem's action property 
directly in ActionMenuItem (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24501?vs=67544&id=67551

REVISION DETAIL
  https://phabricator.kde.org/D24501

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/private/ActionMenuItem.qml
  src/controls/private/ActionsMenu.qml

To: ahiemstra, #kirigami, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
davidedmundson, mart, hein

D24469: Allow the global drawer to become a menu if desired

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:64c8bde7ea6c: Allow the global drawer to become a menu if 
desired (authored by nicolasfella).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24469?vs=67549&id=67550

REVISION DETAIL
  https://phabricator.kde.org/D24469

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

To: nicolasfella, #vdg, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24469: Allow the global drawer to become a menu if desired

[Nicolas Fella]

nicolasfella updated this revision to Diff 67549.
nicolasfella added a comment.


  - Remove unused import

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24469?vs=67548&id=67549

BRANCH
  toolbarmenu

REVISION DETAIL
  https://phabricator.kde.org/D24469

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

To: nicolasfella, #vdg, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24469: Allow the global drawer to become a menu if desired

[Nicolas Fella]

nicolasfella updated this revision to Diff 67548.
nicolasfella added a comment.


  - Rename property
  - Use privateActionToolbutton

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24469?vs=67434&id=67548

BRANCH
  toolbarmenu

REVISION DETAIL
  https://phabricator.kde.org/D24469

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

To: nicolasfella, #vdg, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24499: Do not warn about LayoutDirection in SearchField

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  Thanks

REPOSITORY
  R169 Kirigami

BRANCH
  searchfield_nowarning

REVISION DETAIL
  https://phabricator.kde.org/D24499

To: ahiemstra, #kirigami, broulik, ognarb
Cc: ognarb, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D24514: [XembedSNIProxy] Do not crash on null pointer

[Konrad Materka]

kmaterka added a comment.


  +few minor code style changes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24514

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24514: [XembedSNIProxy] Do not crash on null pointer

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  XCB may return null pointer as a response. Add a check to prevent
  segmentation fault.
  
  BUG: 356937

TEST PLAN
  It is hard to reproduce, but cause of the segmentation fault is pretty 
obvious thanks to debug dump from bug 409652

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24514

AFFECTED FILES
  xembed-sni-proxy/fdoselectionmanager.cpp
  xembed-sni-proxy/fdoselectionmanager.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24499: Do not warn about LayoutDirection in SearchField

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 67541.
ahiemstra added a comment.


  - Use "edit-clear-locationbar-{rtl,ltr}" as icon to match widgets style

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24499?vs=67502&id=67541

BRANCH
  searchfield_nowarning

REVISION DETAIL
  https://phabricator.kde.org/D24499

AFFECTED FILES
  src/controls/SearchField.qml

To: ahiemstra, #kirigami, broulik
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, davidedmundson, mart, hein

D24501: Use MenuItem's action property directly in ActionMenuItem

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 67544.
ahiemstra added a comment.


  - Simplify visible binding

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24501?vs=67504&id=67544

BRANCH
  simpleactionmenuitem

REVISION DETAIL
  https://phabricator.kde.org/D24501

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/private/ActionMenuItem.qml
  src/controls/private/ActionsMenu.qml

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
davidedmundson, mart, hein

D24498: Properly check enabled state of Action for ActionToolBar buttons

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 67543.
ahiemstra added a comment.


  - Do not implicitly convert float to bool

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24498?vs=67501&id=67543

BRANCH
  actiontoolbar_enable

REVISION DETAIL
  https://phabricator.kde.org/D24498

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
davidedmundson, mart, hein

D24498: Properly check enabled state of Action for ActionToolBar buttons

[Arjen Hiemstra]

ahiemstra marked an inline comment as done.
ahiemstra added inline comments.

INLINE COMMENTS

> apol wrote in ActionToolBar.qml:126
> I'd do the enabled && opacity, it feels very wrong using a real number as a 
> boolean >.<.

Agreed. I made the opacity check more explicit.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_enable

REVISION DETAIL
  https://phabricator.kde.org/D24498

To: ahiemstra, #kirigami, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
davidedmundson, mart, hein

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 214 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/214/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 09 Oct 2019 11:36:10 +
 Build duration:
2 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 113 lines...][2019-10-09T11:38:07.653Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-10-09T11:38:07.658Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-09T11:38:07.757Z]  > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10[2019-10-09T11:38:07.847Z] Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts[2019-10-09T11:38:07.847Z]  > git fetch --tags --force --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-09T11:38:08.876Z] Checking out Revision 7db3c74d0335682a78bbcb741325004b36a68a90 (origin/master)[2019-10-09T11:38:09.091Z] Commit message: "Merge remote-tracking branch 'origin/Applications/19.08'"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[2019-10-09T11:38:08.831Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-10-09T11:38:08.921Z]  > git config core.sparsecheckout # timeout=10[2019-10-09T11:38:08.925Z]  > git checkout -f 7db3c74d0335682a78bbcb741325004b36a68a90 # timeout=10[Pipeline] sh[2019-10-09T11:38:12.842Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project discover --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-09T11:38:18.943Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-09T11:38:18.943Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-09T11:38:18.943Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-09T11:38:18.943Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-09T11:38:18.943Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-09T11:38:18.943Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-09T11:38:18.943Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-09T11:38:18.943Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-09T11:38:18.943Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-09T11:38:19.515Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-09T11:38:19.515Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-09T11:38:19.515Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-09T11:38:20.014Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-09T11:38:20.014Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-09T11:38:20.014Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-09T11:38:20.014Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-09T11:38:20.014Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-09T11:38:20.014Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-09T11:38:20.513Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-09T11:38:20.513Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-09T11:38:20.513Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-09T11:38:21.013Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-09T11:38:21.013Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-09T11:38:21.013Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-09T11:38:21.013Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-09T11:38:21.513Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-09T11:38:21.513Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-09T11:38:26.481Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-09T11:38:26.980Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-09T11:38:26.980Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-09T11:38:26.980Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-09T11:38:27.480Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-09T11:38:27.480Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-09T11:38:29.137Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-09T11:38:29.137Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-09T11:38:29.137Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-09T11:38:29.137Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-09T11:38:29.137Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-09T11:38:29.137Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-09T11:38:30.186Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-09T11:38:30.186Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-09T11:38:30.186Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-09T11:38:31.235Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-09T11:38:31.734Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-09T11:38:32.233Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-09T11:38:32.732Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-09T11:38:37.707Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-09T11:38:50.565Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-09T11:38:50.565Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-09T11:38:50.565Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-09T11:38:50.565Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-09T11:38:50.565Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-09T11:38:50.

D24500: Be more explicit about action property types

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2b7683fe9db9: Be more explicit about action property 
types (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24500?vs=67503&id=67542

REVISION DETAIL
  https://phabricator.kde.org/D24500

AFFECTED FILES
  src/controls/Action.qml
  src/controls/private/ActionsMenu.qml
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
davidedmundson, mart, hein

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  In D24265#543873 , @ngraham wrote:
  
  > I would tend to agree. If we feel that it's too difficult to exit this 
mode, maybe we should make it more obvious, like changing the X button in the 
toolbox to a toolbutton with the "finish editing" text.
  
  
  The x is well obvious enough without cluttering with even more long text, but 
I do like to just start using an application (which means: my locus of 
attention is not on the shell anymore) and not have a stray mode there tough 
which i can forget about it being active, maybe the window has even been 
maximized, making it easier to forget about it even (Air France Flight 447)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Björn Feber]

GB_2 added a comment.


  In D24265#544016 , @mart wrote:
  
  > this happens because some other window gets focus (that behavior in 
somewhere deep in kwin and i think makes sense).
  >  Would you keep edit mode active when the focus goes to another app? I'm 
very hesitant about that and don't really like the concept...
  
  
  If it's not really solvable then yes, only exit the edit mode after you press 
"Finish customizing layout", that would be much better than having to re-enter 
edit mode every time if you want do more than 1 different thing (which is 
common if you really want to customize your complete desktop layout). You can 
easily exit it if you are done too, so I don't think it would be a problem.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  this happens because some other window gets focus (that behavior in somewhere 
deep in kwin and i think makes sense).
  Would you keep edit mode active when the focus goes to another app? I'm very 
hesitant about that and don't really like the concept...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 439 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/439/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 09 Oct 2019 08:40:49 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 125 lines...][2019-10-09T08:41:35.046Z]  > git checkout -f 7db3c74d0335682a78bbcb741325004b36a68a90 # timeout=10[2019-10-09T08:41:35.840Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-09T08:41:39.104Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-09T08:41:39.104Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-09T08:41:39.362Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-09T08:41:39.620Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-09T08:41:39.620Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-09T08:41:39.620Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-09T08:41:39.620Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-09T08:41:39.620Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-09T08:41:39.620Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-09T08:41:41.511Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-09T08:41:41.511Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-09T08:41:41.511Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-09T08:41:41.511Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-09T08:41:41.511Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-09T08:41:41.511Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-09T08:41:41.766Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-09T08:41:42.021Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-09T08:41:42.021Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-09T08:41:42.021Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-09T08:41:42.021Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-09T08:41:42.021Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-09T08:41:42.950Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-09T08:41:43.206Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-09T08:41:43.206Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-09T08:41:43.206Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-09T08:41:43.206Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-09T08:41:43.462Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-09T08:41:43.462Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-09T08:41:43.462Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-09T08:41:43.462Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-09T08:41:43.718Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-09T08:41:43.718Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-09T08:41:43.718Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-09T08:41:43.718Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-09T08:41:43.976Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-09T08:41:44.233Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-09T08:41:44.233Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-09T08:41:44.233Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-09T08:41:44.233Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-09T08:41:44.233Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-09T08:41:44.233Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-09T08:41:44.495Z] Retrieving: Plasma-krunner-kf5-qt5[2019-10-09T0

D24486: [Notifications] Report effective Inhibited state on DBus

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bb0e4208c86c: [Notifications] Report effective Inhibited 
state on DBus (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24486?vs=67525&id=67531

REVISION DETAIL
  https://phabricator.kde.org/D24486

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/settings.cpp

To: broulik, #plasma, dfaure, davidedmundson
Cc: davidedmundson, dfaure, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24486: [Notifications] Report effective Inhibited state on DBus

[Kai Uwe Broulik]

broulik updated this revision to Diff 67525.
broulik added a comment.


  - Let applet write `inhibited` directly with no side-effects

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24486?vs=67481&id=67525

REVISION DETAIL
  https://phabricator.kde.org/D24486

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/settings.cpp

To: broulik, #plasma, dfaure
Cc: davidedmundson, dfaure, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24486: [Notifications] Report effective Inhibited state on DBus

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Right. Given it's the applet's responsibility to enforce the inhibition, 
makes sense it is the only and direct governor of that property.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24486

To: broulik, #plasma, dfaure
Cc: davidedmundson, dfaure, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart