D24543: Set an icon theme for gtk applications in the icons kcm

2019-10-10 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 67664. gikari added a comment. Change brace initialization to curly bracket one REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24543?vs=67661=67664 BRANCH gtk-config-icon-theme REVISION DETAIL

D24543: Set an icon theme for gtk applications in the icons kcm

2019-10-10 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 67661. gikari added a comment. Fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24543?vs=67659=67661 BRANCH gtk-config-icon-theme REVISION DETAIL https://phabricator.kde.org/D24543 AFFECTED FILES

D24543: Set an icon theme for gtk applications in the icons kcm

2019-10-10 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 67659. gikari added a comment. Rebase on fixes from D21860 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24543?vs=67638=67659 BRANCH gtk-config-icon-theme REVISION DETAIL

D21860: Set a font for gtk applications in the fonts kcm

2019-10-10 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 67657. gikari added a comment. Replace brace initialization with brackets, use qGuiApp macros REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=67643=67657 BRANCH arcpatch-D21860 REVISION DETAIL

D24224: Start of the accessibility KCM

2019-10-10 Thread Kai Uwe Broulik
broulik added a comment. Can you please follow KDE Frameworks coding style REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava, ngraham Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D21860: Set a font for gtk applications in the fonts kcm

2019-10-10 Thread Mikhail Zolotukhin
gikari added inline comments. INLINE COMMENTS > broulik wrote in gtkconfig.cpp:36 > The cast is pointless Why? `QGuiApplication::instance()` returns `QCoreApplication` pointer, not `QGuiApplication` one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860

D21860: Set a font for gtk applications in the fonts kcm

2019-10-10 Thread Mikhail Zolotukhin
gikari marked 2 inline comments as done. gikari added inline comments. INLINE COMMENTS > broulik wrote in gtkconfig.cpp:34 > We typically don't use braces for initializations, see > https://techbase.kde.org/Policies/Frameworks_Coding_Style Sure, I will change that and other initializations to

D21860: Set a font for gtk applications in the fonts kcm

2019-10-10 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 67643. gikari added a comment. - Set an icon theme for gtk applications in the icons kcm REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=66597=67643 BRANCH arcpatch-D21860 REVISION DETAIL

D21860: Set a font for gtk applications in the fonts kcm

2019-10-10 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > gtkconfig.cpp:34 > +GtkConfig::GtkConfig(QObject *parent, const QVariantList&) : > +KDEDModule(parent), configEditor {new ConfigEditor()} > +{ We typically don't use braces for initializations, see

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 67640. ngraham added a comment. Remove old unused enum from the first revision REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24483?vs=67639=67640 BRANCH windy (branched from master) REVISION DETAIL

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 67639. ngraham added a comment. Handle windy + cloudy conditions as well now that we have appropriate icons REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24483?vs=67474=67639 BRANCH windy (branched from

D24543: Set an icon theme for gtk applications in the icons kcm

2019-10-10 Thread Mikhail Zolotukhin
gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY This is the addition to the D21860 for changing icon theme automatically as well Depends

D24224: Start of the accessibility KCM

2019-10-10 Thread Benjamin Port
bport added subscribers: ervin, bport. bport added inline comments. INLINE COMMENTS > kcmaccess.h:32-67 > +Q_PROPERTY(int timeoutDelay READ timeoutDelay > WRITE setTimeoutDelayNOTIFY timeoutDelayChanged) > +Q_PROPERTY(int bounceKeysDelay READ

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Alexander Potashev
aspotashev added a comment. In D24534#544785 , @davidedmundson wrote: > Original commit: https://git.reviewboard.kde.org/r/123738/ > > (following it through quite a few renames) > > From what I can tell, it's akin to the direction

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham
ngraham added a subscriber: jriddell. ngraham added a comment. FWIW Plasma 5.17 tars were already made so if we want this in Plasma 5.17.0, in addition to landing it on the stable branch, @jriddell will have to do some release magic to include it and you'll want to ping him about that.

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Alexander Potashev
aspotashev accepted this revision. aspotashev added a comment. The changes in messages are indeed reverted by this patch. REPOSITORY R119 Plasma Desktop BRANCH revert-force-stripes-string-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D24534 To: filipf,

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. Idea for a better string: "Fill each row/column before adding tasks to the next row/column" REPOSITORY R119 Plasma Desktop BRANCH revert-force-stripes-string-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D24534 To: filipf,

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks David, that's very helpful. Let's revert this in Plasma 5.17 for now (if translators approve) and work on a better string (or even a better UI) for Plasma 5.18. REPOSITORY R119

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread David Edmundson
davidedmundson added a comment. Original commit: https://git.reviewboard.kde.org/r/123738/ (following it through quite a few renames) From what I can tell, it's akin to the direction property in a Flow REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

2019-10-10 Thread Filip Fila
filipf added a comment. In D24533#544773 , @ngraham wrote: > Do you mean the equivalent of a column layout, with a horizontal line under the title? This sort of a style, the line is right next to the title. F7567596: image.png

[Breeze] [Bug 412810] Input is not shown when typing FDE password

2019-10-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=412810 Nate Graham changed: What|Removed |Added Resolution|--- |DOWNSTREAM CC|

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. After playing around with this option with my IOTM at various panel widths and various "maximum rows/columns" values, I still cannot for the life of me figure out what on earth it does--or else the feature is so buggy I'm unable to discover the pattern. REPOSITORY

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. Do you mean the equivalent of a column layout, with a horizontal line under the title? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D24533 To: davidre, #plasma, #vdg Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R115:fb5631928121: Increase UI commonality between KCM and applet (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24530: [XembedSNIProxy] If available, always use 32-bit color.

2019-10-10 Thread Konrad Materka
kmaterka added a comment. D24514 is merged, this one should apply smoothly now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: plasma-devel,

D24514: [XembedSNIProxy] Do not crash on null pointer

2019-10-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:741441765601: [XembedSNIProxy] Do not crash on null pointer (authored by kmaterka, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24531: [XembedSNIProxy] Scale only big icons

2019-10-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:13efbfca67f8: [XembedSNIProxy] Scale only big icons (authored by kmaterka, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Sefa Eyeoglu
sefaeyeoglu accepted this revision. sefaeyeoglu added a comment. This revision is now accepted and ready to land. In D24407#544728 , @ngraham wrote: > I had a feeling. I say let's land this, then fix that. Do you agree? No objections 

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. I had a feeling. I say let's land this, then fix that. Do you agree? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To: ngraham, #vdg, #plasma, drosca, broulik, sitter, sefaeyeoglu Cc: nicolasfella, ndavis, GB_2,

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. In D24407#544715 , @ngraham wrote: > In D24407#544714 , @sefaeyeoglu wrote: > > > In D24407#544707 , @ngraham wrote: > >

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. In D24407#544714 , @sefaeyeoglu wrote: > In D24407#544707 , @ngraham wrote: > > > That should be fixed by D24402 , in plasma-framework.

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. In D24407#544707 , @ngraham wrote: > That should be fixed by D24402 , in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

D24529: [XembedSNIProxy] Check size in each update()

2019-10-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:acf91005b60c: [XembedSNIProxy] Check size in each update() (authored by kmaterka, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. That should be fixed by D24402 , in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. Nice work! It looks very good now. One odd thing I just noticed: F7566825: plasma-pa-duplicate-defualt.mp4 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To:

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Filip Fila
filipf added a comment. In D24534#544703 , @ngraham wrote: > "rows of as many columns" > > I'm afraid I still have no idea what this means! :) Can you explain what it actually does? Then maybe we can come up with a clear string together.

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. "rows of as many columns" I'm afraid I still have no idea what this means! :) Can you explain what it actually does? Then maybe we can come up with a clear string together. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24534

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. Thanks for testing that, @sefaeyeoglu. I don't actually have a combination of devices that makes the combobox appear so that's much appreciated. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To: ngraham, #vdg,

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 67610. ngraham added a comment. Fix overflow in the applet and poor alignment in the KCM when the combobox is visible REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24407?vs=67293=67610 BRANCH

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Filip Fila
filipf added a subscriber: ngraham. filipf added a comment. I still think the string could be improved some, maybe @ngraham has an idea. But the question is can this land in 5.17 given it's a string change? (albeit just a revert) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. F7566730: 1570716308.png Looks like replacing the label with a combobox breaks alignment in the KCM and exceeds the full width in the applet. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY I changed the "forceStripes" checkbox string in D19280 , most likey because I thought it wasn't

Plasma 5.17 tars available

2019-10-10 Thread Jonathan Riddell
Tars for Plasma 5.17 are now available to distros with access to the server. Release will be on Tuesday. Jonathan

D24518: On KCM cursor theme update attribute name

2019-10-10 Thread Benjamin Port
bport updated this revision to Diff 67608. bport added a comment. Remove change not related to this commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24518?vs=67560=67608 REVISION DETAIL https://phabricator.kde.org/D24518 AFFECTED FILES

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

2019-10-10 Thread Benjamin Port
bport updated this revision to Diff 67607. bport added a comment. a cleaner approach to fix the bug REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24520?vs=67562=67607 REVISION DETAIL https://phabricator.kde.org/D24520 AFFECTED FILES

D24519: Delegate KCM cursor theme config management to KConfigXT

2019-10-10 Thread Benjamin Port
bport updated this revision to Diff 67606. bport added a comment. Take in consideration feedbacks REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24519?vs=67561=67606 REVISION DETAIL https://phabricator.kde.org/D24519 AFFECTED FILES

D24517: Port kcm cursor to KConfigXT

2019-10-10 Thread Benjamin Port
bport updated this revision to Diff 67605. bport added a comment. - Install kcfg file - Remove uneeded include from kcfg file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24517?vs=67559=67605 REVISION DETAIL https://phabricator.kde.org/D24517

D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method

2019-10-10 Thread Benjamin Port
bport updated this revision to Diff 67604. bport added a comment. Remove commented include REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24516?vs=67558=67604 REVISION DETAIL https://phabricator.kde.org/D24516 AFFECTED FILES

D24265: support global edit mode

2019-10-10 Thread Nathaniel Graham
ngraham added a comment. In D24265#544549 , @mart wrote: > I actually like that a lot, to me is really the click anywhere to dismiss pattern all over the place in modal dialogs, websites and what not. > If I have to remove it, i would at

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

2019-10-10 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D24533 AFFECTED FILES icons/CategoryDrawer.cpp

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 100 - Fixed!

2019-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/100/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 10 Oct 2019 11:47:44 + Build duration: 34 min and counting JUnit Tests Name: (root) Failed:

D24529: [XembedSNIProxy] Check size in each update()

2019-10-10 Thread Konrad Materka
kmaterka updated this revision to Diff 67601. kmaterka added a comment. getClientWindowSize -> calculateClientWindowSize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24529?vs=67596=67601 REVISION DETAIL https://phabricator.kde.org/D24529

D24529: [XembedSNIProxy] Check size in each update()

2019-10-10 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sniproxy.cpp:217 > It's a bit weird to have a method called "getSomething" that changes the > state of things True, get* should not have side effect. I will change it. REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Breeze] [Bug 412810] Input is not shown when typing FDE password

2019-10-10 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=412810 --- Comment #2 from Harald Sitter --- Created attachment 123122 --> https://bugs.kde.org/attachment.cgi?id=123122=edit working screenshot -- You are receiving this mail because: You are the assignee for the bug.

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 16 - Still Failing!

2019-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/16/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 10 Oct 2019 11:53:13 + Build duration: 5 min 16 sec and counting CONSOLE OUTPUT

D24529: [XembedSNIProxy] Check size in each update()

2019-10-10 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > sniproxy.cpp:217 > > +QSize SNIProxy::getClientWindowSize() const > +{ It's a bit weird to have a method called "getSomething" that changes the state

KDE CI: Plasma » kmenuedit » kf5-qt5 SUSEQt5.12 - Build # 23 - Fixed!

2019-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20SUSEQt5.12/23/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 10 Oct 2019 11:39:54 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 0

D24531: [XembedSNIProxy] Scale only big icons

2019-10-10 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: davidedmundson, Plasma, Plasma: Workspaces. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Do not scale up small icons to avoid quality detoriation.

[Breeze] [Bug 412810] Input is not shown when typing FDE password

2019-10-10 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=412810 --- Comment #1 from Harald Sitter --- That sounds more like a distro or plymouth bug. This is working fine with the test script and plymouth 0.9.3 https://phabricator.kde.org/source/breeze-plymouth/browse/master/test/plytest.sh$59 And also works

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 15 - Still Failing!

2019-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/15/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 10 Oct 2019 11:39:17 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 217 - Still unstable!

2019-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/217/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 10 Oct 2019 11:39:08 + Build duration: 6 min 56 sec and counting JUnit Tests Name: (root)

D24425: Listen to the application style changing

2019-10-10 Thread Kai Uwe Broulik
broulik closed this revision. broulik added a comment. https://cgit.kde.org/qqc2-desktop-style.git/commit/?id=8a14bd24607e917dbf46d961e5bc4be3a90a7881 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24425 To: broulik, #plasma, mart Cc:

[Breeze] [Bug 412810] New: Input is not shown when typing FDE password

2019-10-10 Thread Bart Ribbers
https://bugs.kde.org/show_bug.cgi?id=412810 Bug ID: 412810 Summary: Input is not shown when typing FDE password Product: Breeze Version: 5.16.5 Platform: Other OS: Linux Status: REPORTED Severity: normal

D24529: [XembedSNIProxy] Check size in each update()

2019-10-10 Thread Konrad Materka
kmaterka updated this revision to Diff 67596. kmaterka added a reviewer: broulik. kmaterka added a comment. Removed code style changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24529?vs=67591=67596 REVISION DETAIL

D24529: [XembedSNIProxy] Check size in each update()

2019-10-10 Thread Konrad Materka
kmaterka added a comment. In D24529#544568 , @broulik wrote: > Thanks for your patch! Generally we prefer coding style changes to be done separately as to not pollute the change with seemingly unrelated changes. Sure, you are right. I

D24514: [XembedSNIProxy] Do not crash on null pointer

2019-10-10 Thread Konrad Materka
kmaterka added a comment. In D24514#544336 , @ngraham wrote: > Does this really fix 356937? That seems to be about something other than a crash. Did you mean 409652 instead? Yes, sorry, copy & paste error. I'm working on several bus

D23578: Before requesting a scan, check the time threshold

2019-10-10 Thread Méven Car
meven added inline comments. INLINE COMMENTS > jgrulich wrote in main.qml:77 > What about this? I removed this because 1: Request scan failure should never happen anymore because the handler makes sure never to call requestScan too often. The timer can just constantly ask for request scans it

D23578: Before requesting a scan, check the time threshold

2019-10-10 Thread Méven Car
meven updated this revision to Diff 67595. meven marked 5 inline comments as done. meven added a comment. Rebase, clean wirelessScanTimerEnabled, better use delete m_wirelessScanRetryTimer.take to clean m_wirelessScanRetryTimer hashmap, add some comments REPOSITORY R116 Plasma Network

D24530: [XembedSNIProxy] If available, always use 32-bit color.

2019-10-10 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: davidedmundson, Plasma: Workspaces, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY If available, always use 32-bit color. We don't need

D24530: [XembedSNIProxy] If available, always use 32-bit color.

2019-10-10 Thread Konrad Materka
kmaterka added a comment. Needs to be applied after D24514 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24529: [XembedSNIProxy] Check size in each update()

2019-10-10 Thread Kai Uwe Broulik
broulik added a comment. Thanks for your patch! Generally we prefer coding style changes to be done separately as to not pollute the change with seemingly unrelated changes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24529 To: kmaterka,

D24529: [XembedSNIProxy] Check size in each update()

2019-10-10 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: davidedmundson, Plasma, Plasma: Workspaces. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY If needed, perform resize in each update(). Client window

D24407: Increase UI commonality between KCM and applet

2019-10-10 Thread Harald Sitter
sitter added a subscriber: nicolasfella. sitter added a comment. @nicolasfella do you have thoughts? The code looks fine, but then I don't really do qml on a daily basis. Visually I find the applet crowded, but maybe that's just me. REPOSITORY R115 Plasma Audio Volume Applet REVISION

D24265: support global edit mode

2019-10-10 Thread Marco Martin
mart added a comment. In D24265#544299 , @ngraham wrote: > Hmm, I have some UX concerns here after trying it out: > > If I invoke Present Windows to see the desktop so that I can right-click on it to enter edit mode, when I exit the mode,

No ECMAScript 6/7 in Frameworks, please

2019-10-10 Thread Kai Uwe Broulik
Hi everyone, just a quick heads up that KDE Frameworks minimum Qt version requirement policy [1] does not permit the use of ECMAScript 6/7 features in repositories such as KDeclarative and Plasma-Framework at this time. Current supported Frameworks minimum version is Qt 5.11 (I think? 5.13,