D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  As part of:
  
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24767

To: kmaterka, #plasma, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24768: Fix incorrect Credits model for Kirigami.AboutPage

[Ilya Bizyaev]

IlyaBizyaev created this revision.
IlyaBizyaev added a reviewer: Kirigami.
IlyaBizyaev added a project: Kirigami.
Herald added a subscriber: plasma-devel.
IlyaBizyaev requested review of this revision.

REVISION SUMMARY
  Credits section currently displays the list of translators.
  
  This fixes a copy-paste mistake.

TEST PLAN
  Opened Discover's About page with and without the change; after the fix, the 
Credits section disappeared.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24768

AFFECTED FILES
  src/controls/AboutPage.qml

To: IlyaBizyaev, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Adding support for Attention Icon to StatusNotifier tray icons
  
  BUG: 341255

TEST PLAN
  As described in bug report, Konversation can be used for tests.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24767

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: kmaterka
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Discover and KSysGuard in kde.org/applications?

[Carl Schwan]

Since neither Discover nor KSysguard has a website, having both applications in 
kde.org/applications would allow both applications to still have a 'web 
presence'. This can be useful if we want to link to Discover from somewhere 
else.

And kde.org/applications is not only display applications part of KDE 
Applications, but also extragear stuffs, so I don't see it as a problem to also 
display applications that are part of Plasma.

Carl

 Original Message 
On 18 Oct 2019, 23:03, Aleix Pol < aleix...@kde.org> wrote:
On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell  wrote:
>
> Would Plasma team like these listed on the KDE Apps webpage? So far I've not 
> had them because Plasma is a product of KDE that is not a standalone app.
Hi Jonathan,
I would say it's okay that they are not, I agree with your resoning.
At least Discover. But I can be persuaded otherwise.
Aleix

publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys

Re: Discover and KSysGuard in kde.org/applications?

[Aleix Pol]

Sure, but they also lose effectiveness.
For example, I don't know if the wallpapers installed from Discover
will work fine on Gnome, or LXQt. What about icon themes?

Aleix

On Fri, Oct 18, 2019 at 11:04 PM Nate Graham  wrote:
>
> Personally I would like to see then listed there. They're standalone
> apps that can be installed without Plasma, after all.
>
> Nate
>
>
>
> On 10/18/19 3:03 PM, Aleix Pol wrote:
> > On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell  wrote:
> >>
> >> Would Plasma team like these listed on the KDE Apps webpage?  So far I've 
> >> not had them because Plasma is a product of KDE that is not a standalone 
> >> app.
> >
> > Hi Jonathan,
> > I would say it's okay that they are not, I agree with your resoning.
> > At least Discover. But I can be persuaded otherwise.
> >
> > Aleix
> >
>

D24766: Revert change to make the notification persistent

[Nathaniel Graham]

ngraham added a comment.


  I had a feeling this would be popular. :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  revert-sticky-notifications (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24766

To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24766: Revert change to make the notification persistent

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d9db05ddef96: Revert change to make the notification 
persistent (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24766?vs=68265=68266

REVISION DETAIL
  https://phabricator.kde.org/D24766

AFFECTED FILES
  notifier/DiscoverNotifier.cpp

To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Discover and KSysGuard in kde.org/applications?

[Nate Graham]

Personally I would like to see then listed there. They're standalone 
apps that can be installed without Plasma, after all.


Nate



On 10/18/19 3:03 PM, Aleix Pol wrote:

On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell  wrote:


Would Plasma team like these listed on the KDE Apps webpage?  So far I've not 
had them because Plasma is a product of KDE that is not a standalone app.


Hi Jonathan,
I would say it's okay that they are not, I agree with your resoning.
At least Discover. But I can be persuaded otherwise.

Aleix

Re: Discover and KSysGuard in kde.org/applications?

[Aleix Pol]

On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell  wrote:
>
> Would Plasma team like these listed on the KDE Apps webpage?  So far I've not 
> had them because Plasma is a product of KDE that is not a standalone app.

Hi Jonathan,
I would say it's okay that they are not, I agree with your resoning.
At least Discover. But I can be persuaded otherwise.

Aleix

D24766: Revert change to make the notification persistent

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  

REPOSITORY
  R134 Discover Software Store

BRANCH
  revert-sticky-notifications (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24766

To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24766: Revert change to make the notification persistent

[Nathaniel Graham]

ngraham updated this revision to Diff 68265.
ngraham marked an inline comment as done.
ngraham added a comment.


  Don't stop keeping track of the notification, so we can still close it when 
Discover is launched

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24766?vs=68264=68265

BRANCH
  revert-sticky-notifications (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24766

AFFECTED FILES
  notifier/DiscoverNotifier.cpp

To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24766: Revert change to make the notification persistent

[Nathaniel Graham]

ngraham added a comment.


  That pares down the diff quite a bit. :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24766

To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24766: Revert change to make the notification persistent

[Aleix Pol Gonzalez]

apol added a comment.


  Other than that, LGTM

INLINE COMMENTS

> DiscoverNotifier.cpp:67
>  KRun::runCommand(QStringLiteral("plasma-discover"), nullptr);
> -if (m_updatesAvailableNotification) { 
> m_updatesAvailableNotification->close(); }
>  }

I wouldn't remove these. It's good that it reacts to opening Discover. It shows 
that it's connected.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24766

To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24766: Revert change to make the notification persistent

[Carl Schwan]

ognarb added a comment.


  +1 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24766

To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24766: Revert change to make the notification persistent

[Nicolas Fella]

nicolasfella added a comment.


  Yes please!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24766

To: ngraham, apol, broulik, #discover_software_store
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24766: Revert change to make the notification persistent

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, broulik, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Nobody liked it and it was annoying. From a conceptual standpoint, it was 
redundant
  anyway because the SNI in the system tray is already persistent when there's 
an update
  available.
  
  Targeting 5.17.1 for this.

TEST PLAN
  Restart plasmashell, see that the "updates available" notification disappears 
after a few seconds

REPOSITORY
  R134 Discover Software Store

BRANCH
  revert-sticky-notifications (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24766

AFFECTED FILES
  notifier/DiscoverNotifier.cpp
  notifier/DiscoverNotifier.h

To: ngraham, apol, broulik, #discover_software_store
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=340137

kouka...@gmail.com changed:

   What|Removed |Added

 CC||kouka...@gmail.com

--- Comment #10 from kouka...@gmail.com ---
I am in need of this feature. I have not updated to KDE5 because of it. I
really hope someone will implement it, as I don't have the skills to do it
myself. I am sure that there will be many users to find peace.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 68260.
gikari added a comment.


  Fix daemon hangup on font change

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=68258=68260

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json

To: gikari, #plasma, #vdg
Cc: ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[Nathaniel Graham]

ngraham added a comment.


  In D24763#549955 , @broulik wrote:
  
  > Nevermind I am an idiot and don't know how (colo(u)r) temperature works.
  
  
  Which is exactly why we need these labels. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24763

To: davidedmundson, #plasma, ngraham
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[Kai Uwe Broulik]

broulik added a comment.


  Nevermind I am an idiot and don't know how (colo(u)r) temperature works.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24763

To: davidedmundson, #plasma, ngraham
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24479: [KCM] Make multi-screen draggability more obvious

[Nathaniel Graham]

ngraham marked 3 inline comments as done.
ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Output.qml:273
> This still needs fixing. Regardless of whether it happens to work now or not.

Per discussion, we can do it this way for now since other pieces of code that 
are already committed do the same thing, and then we'll fix it for all of them 
in a follow-up patch.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[Kai Uwe Broulik]

broulik added a comment.


  In right to left layout the labels must be swapped.
  F7623875: Screenshot_20191018_194633.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24763

To: davidedmundson, #plasma, ngraham
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24479: [KCM] Make multi-screen draggability more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 68259.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use anchors correctly so the new label elides if necessary

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24479?vs=67509=68259

BRANCH
  make-draggability-more-obvious (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24479

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> broulik wrote in gtkconfig.cpp:116
> In what way? There's a comment in the style KCM saying
> 
>   // # FIXME - Doesn't apply all settings correctly due to bugs in 
> KApplication/KToolbar
>   KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);

@broulik signal from `KGlobalSettings` is never recieved with 
`KGlobalSettings::ToolbarStyleChanged` value as an argument. I debuged style 
kcm and daemon simultaneously and after stepping over the above line and the 
previous one which is

  KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, 
KGlobalSettings::SETTINGS_STYLE);

Only signal with `SettingsChanged` is received within the daemon.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 68258.
gikari added a comment.


  Fix pidof launching and remove static from the regexp's

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=68256=68258

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json

To: gikari, #plasma, #vdg
Cc: ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 68256.
gikari marked 16 inline comments as done.
gikari added a comment.


  Fix most of the issues brought by @broulik

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=68187=68256

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json

To: gikari, #plasma, #vdg
Cc: ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24765: [WIP] Notification applet on the phone

[Marco Martin]

mart requested review of this revision.
mart added a comment.


  behavior on mobile
  F7623351: vokoscreen-2019-10-18_18-05-35.mp4 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24765

To: mart, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24765: [WIP] Notification applet on the phone

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  some optimizations for tablet mode (touch first, but also on
  transformable laptops flipped to tablet)
  and some for specifically the mobile case (mobile phone)
  
  - hide the top toolbar in phone mode
  - in tablet mode (and therefore on phone mode too) don't select text but drag 
the item laterally to dismiss it

TEST PLAN
  - on phone form factor for the new behavior
  - on touch laptop in tablet mode
  - on desktop for its behavior not changing at all

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/mobilenotifications

REVISION DETAIL
  https://phabricator.kde.org/D24765

AFFECTED FILES
  applets/notifications/package/contents/ui/DraggableDelegate.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/SelectableLabel.qml

To: mart, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fixit then shipit!

INLINE COMMENTS

> main.qml:153
> +}
> +Item {}
> +}

Oh and one more thing, this should probably be a vertical spacer so the labels 
look grouped with the slider.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24763

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[David Edmundson]

davidedmundson updated this revision to Diff 68251.
davidedmundson added a comment.


  Made the patch even cooler

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24763?vs=68250=68251

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24763

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Nice.

INLINE COMMENTS

> main.qml:151
> +QQC2.Label {
> +text: i18nc("Night colour blue-ish", "Cold")
> +}

This should be "Cool" (the color pairs are "hot/cold" and "warm/cool"; mixing 
them is a bit weird))

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24763

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[David Edmundson]

davidedmundson added a comment.


  F7623296: Screenshot_20191018_165943.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24763

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24763: [kcms/nightcolor] Add hints to temperature slider direction

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Looked at it

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24763

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:9b2c7dec61de: [KEditFileType] Add a desktop file 
(authored by meven).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24758?vs=68243=68245

REVISION DETAIL
  https://phabricator.kde.org/D24758

AFFECTED FILES
  keditfiletype/CMakeLists.txt
  keditfiletype/org.kde.keditfiletype.desktop

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24740: [Media Controller] Multiple artists support

[Ilya Katsnelson]

K900 added a comment.


  Re: lockscreen/toolbar stuff: maybe the metadata parsing should go into the 
dataengine instead? I could write up a patch to move the metadata parsing logic 
there, and then we can have the actual QML bits refer to the specific parsed 
fields that will come pre-sanitized (probably always converted to a 
QStringList).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24740

To: lesf0, broulik
Cc: K900, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> meven wrote in CMakeLists.txt:57
> We have a bunch of apps to update, I used this because I found it in krusader 
> code

Yes, due to having no proper cmake deprecation warnings there are still some 
with old code. But lots of porting already happened :)

Perhaps KDE_INSTALL_DIRS_NO_DEPRECATED should be started to be enforced on CI :)

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kossebau wrote in CMakeLists.txt:57
> KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is deprecated, cmp. 
> https://api.kde.org/ecm/kde-module/KDEInstallDirs.html

We have a bunch of apps to update, I used this because I found it in krusader 
code

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

[Méven Car]

meven marked an inline comment as done.
meven added a comment.


  Thanks @kossebau @broulik

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

[Méven Car]

meven updated this revision to Diff 68243.
meven added a comment.


  Replace OnlyShowIn= by NoDisplay=true USe KDE_INSTALL_APPDIR instead of 
deprecated XDG_APPS_INSTALL_DIR

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24758?vs=68239=68243

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24758

AFFECTED FILES
  keditfiletype/CMakeLists.txt
  keditfiletype/org.kde.keditfiletype.desktop

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:432470576605: Fix NOAA picture of the day provider 
(authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24727?vs=68225=68242

REVISION DETAIL
  https://phabricator.kde.org/D24727

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

To: guoyunhe, #plasma, sitter
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  works well enough it seems
  F7622741: yJIMcaK.jpg 

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma, sitter
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:57
>  install( FILES filetypes.desktop  DESTINATION  ${KDE_INSTALL_KSERVICES5DIR} )
> +install(PROGRAMS org.kde.keditfiletype.desktop DESTINATION 
> ${XDG_APPS_INSTALL_DIR} )

KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is deprecated, cmp. 
https://api.kde.org/ecm/kde-module/KDEInstallDirs.html

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24759: [ksmserver] Drop unused logout effect widget

[David Edmundson]

davidedmundson created this revision.
davidedmundson added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  At some point there was an effect in kwin to fade to a grey (with a
  weird vigenette effect) as one logs out.
  
  This was signalled with a fake offscreen window with a special window
  ID.
  
  The kwin effect has gone, deleted in Plasma 5.8 with
  af80a546bfe258b54468b159bb8cf78f16ca9ebf 

  
  (Kwin still contains an effect called logout, but that's merely for the
  logout prompt)
  
  I intend to replace this logout effect but as I'm going to start from
  scratch we may as well communicate from ksmserver -> kwin with a new API
  that works on wayland and and solves some other issues all in one.

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ksmserver_kwin_state

REVISION DETAIL
  https://phabricator.kde.org/D24759

AFFECTED FILES
  ksmserver/logout.cpp
  ksmserver/server.cpp
  ksmserver/server.h

To: davidedmundson, #plasma, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

[Kai Uwe Broulik]

broulik added a comment.


  Should this be `NoDisplay` since you can't just launch it without an argument

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: Add a desktop for utility keditfiletype

[Méven Car]

meven updated this revision to Diff 68239.
meven added a comment.


  Add missing .desktop file

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24758?vs=68238=68239

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24758

AFFECTED FILES
  keditfiletype/CMakeLists.txt
  keditfiletype/org.kde.keditfiletype.desktop

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: Add a desktop for utility keditfiletype

[Méven Car]

meven created this revision.
meven added reviewers: broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Allow to display its Icon in Wayland
  BUG: 383615

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24758

AFFECTED FILES
  keditfiletype/CMakeLists.txt

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24757: Port away from KIconThemes

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e06e897f9d45: Port away from KIconThemes (authored by 
broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24757?vs=68232=68237

REVISION DETAIL
  https://phabricator.kde.org/D24757

AFFECTED FILES
  kcms/hardware/joystick/joywidget.cpp
  kcms/keys/CMakeLists.txt
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/runners/CMakeLists.txt
  kcms/runners/kcm.cpp

To: broulik, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24756: Port away from KIconThemes

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:88c1f2093cac: Port away from KIconThemes (authored by 
broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24756?vs=68231=68236

REVISION DETAIL
  https://phabricator.kde.org/D24756

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  klipper/CMakeLists.txt
  klipper/editactiondialog.cpp
  klipper/urlgrabber.cpp
  logout-greeter/CMakeLists.txt
  logout-greeter/shutdowndlg.cpp
  shell/CMakeLists.txt

To: broulik, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Nathaniel Graham]

ngraham added a comment.


  If it works for you @sitter then feel free to ignore me. But I believe my 
testing methodology is sound: I'm living in my built-from-source plasma session 
and I apply the patch, build and install kdeplasma-addons to `~/kde/usr`, and 
then restart plasmashell. This works for testing everything else.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Aha, the old one was indeed still running! I can see the new one now.
  
  - My request to give the scrollview a frame and the background isn't 
implemented yet.
  - My request to use the pointing hand cursor when hovering over an app isn't 
implemented yet.
  - Long app names still get elided rather than becoming multi-line strings.

INLINE COMMENTS

> AppChooserDialog.qml:99
> +bottom: parent.bottom
> +horizontalCenter: parent.horizontalCenter
> +}

Set left and right anchors too so it takes up the full width

> AppChooserDialog.qml:103
> +opacity: visible
> +placeholderText: i18n("search...");
> +

Capitalize the S

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  In D24732#549750 , @ngraham wrote:
  
  > On my system, it's at `/usr/lib64/libexec/xdg-desktop-portal-kde`. I tried 
overriding that file with the one I just built from source (because it didn't 
seem to use the built-from-source one at 
`~/kde/usr/lib64/libexec/xdg-desktop-portal-kde`) but even then, I still get 
the old dialog in the Flatpak version of Dolphin. What am I doing wrong here?
  
  
  Did you kill the previous one? It might still be running and that's why it 
didn't pick the new dialog. You can also start it manually, just kill any 
xdg-desktop-portal-kde instance and run the one you want (from any location).  
It will even tell you it's already running when you use 
"QT_LOGGING_RULES='xdp*.debug=true'".

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Nathaniel Graham]

ngraham added a comment.


  On my system, it's at `/usr/lib64/libexec/xdg-desktop-portal-kde`. I tried 
overriding that file with the one I just built from source (because it didn't 
seem to use the built-from-source one at 
`~/kde/usr/lib64/libexec/xdg-desktop-portal-kde`) but even then, I still get 
the old dialog in the Flatpak version of Dolphin. What am I doing wrong here?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  In D24265#549691 , @davidedmundson 
wrote:
  
  > Can you explain the intended difference between top and topcenter?
  
  
  when the toolbox is at topcenter, it snaps at center screen ,and if the 
resolution changes it will be moved to keeping being at center.
  while is it's just top, it will just do its best to keep the same absolute 
position (unless it has to be moved for decreased resolution

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: davidedmundson, ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Marco Martin]

mart updated this revision to Diff 68235.
mart added a comment.


  - remove dead code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24265?vs=67899=68235

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/main.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma, ngraham
Cc: davidedmundson, ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24264: edit mode action and dbus

[Marco Martin]

mart updated this revision to Diff 68234.
mart added a comment.


  - explanation++
  - remove redundant check

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24264?vs=67707=68234

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24264

AFFECTED FILES
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/itemcontainer.cpp
  containmentactions/contextmenu/menu.cpp
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp

To: mart, #plasma, #vdg, ngraham, GB_2, davidedmundson
Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari added a comment.


  In D24743#549712 , @ngraham wrote:
  
  > Nice work! So what's our update story here? If a user has set something 
from the GTK KCM that's not the same as the data set by the applicable other 
KCM, who wins, and what happens when said user upgrades to 5.18 (which is 
presumably the release that will have this)?
  
  
  There is a patch, that removes functionality from the gtk kcm: D24744 

  
  Without it the gtk kcm will override settings that was set from the daemon. 
But if the user sets something from plasma kcms again, the gtk style applied by 
gtk kcm will be overridden (but not all the settings, just the ones that was 
changed by plasma kcm).

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24750: Fix reading environment variables with newline

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:595ab88bc2ee: Fix reading environment variables with 
newline (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24750?vs=68217=68233

REVISION DETAIL
  https://phabricator.kde.org/D24750

AFFECTED FILES
  startkde/plasma-sourceenv.sh
  startkde/startplasma.cpp

To: fvogt, #plasma, apol, davidedmundson, adridg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24757: Port away from KIconThemes

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  At least where trivially possible.

TEST PLAN
  T11637 
  
  - Compiles
  - Global shortcuts still has app icons

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24757

AFFECTED FILES
  kcms/hardware/joystick/joywidget.cpp
  kcms/keys/CMakeLists.txt
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/runners/CMakeLists.txt
  kcms/runners/kcm.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Nathaniel Graham]

ngraham added a comment.


  Nice work! So what's our update story here? If a user has set something from 
the GTK KCM that's not the same as the data set by the applicable other KCM, 
who wins, and what happens when said user upgrades to 5.18 (which is presumably 
the release that will have this)?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24750: Fix reading environment variables with newline

[Adriaan de Groot]

adridg accepted this revision.
adridg added a comment.
This revision is now accepted and ready to land.


  Looked for -0 alternatives, couldn't find any. Dave tells me there's 
sufficient fallbacks, and otherwise we'll just patch it out in packaging.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24750

To: fvogt, #plasma, apol, davidedmundson, adridg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24756: Port away from KIconThemes

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  At least where trivially possible.

TEST PLAN
  T11637 
  
  - Compiles
  - Klipper's edit actions dialog still shows app icons

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24756

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  klipper/CMakeLists.txt
  klipper/editactiondialog.cpp
  klipper/urlgrabber.cpp
  logout-greeter/CMakeLists.txt
  logout-greeter/shutdowndlg.cpp
  shell/CMakeLists.txt

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Discover and KSysGuard in kde.org/applications?

[Jonathan Riddell]

Would Plasma team like these listed on the KDE Apps webpage?  So far I've
not had them because Plasma is a product of KDE that is not a standalone
app.

Jonathan

D24479: [KCM] Make multi-screen draggability more obvious

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Output.qml:273
> > Or the KCM re-creating the outputModel which would be weird.
> 
> It would, but:
> 
>   connect (m_config.get(), ::outputModelChanged,
>this, ::outputModelChanged);
> 
> which gets emitted in
> 
>   ConfigHandler::setConfig(KScreen::ConfigPtr config)  
> 
> A new screen would be a new config.
> 
> I think output model is the same object, but it would retrigger this 
> evaluation.

This still needs fixing. Regardless of whether it happens to work now or not.

> Screen.qml:56
> +top: parent.top
> +horizontalCenter: parent.horizontalCenter
> +margins: units.smallSpacing

It's better to set the left + right anchors and then setting the text alignment 
to be horizontally centered.

That way we will wrap or elide if the translated string is too long rather than 
overflow.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[David Edmundson]

davidedmundson added a comment.


  Can you explain the intended difference between top and topcenter?

INLINE COMMENTS

> ToolBoxButton.qml:87
>  id: stateTimer
> -interval: 100
> +interval: 0//toolBoxButton.state.indexOf("center") != -1 ? 0 : 100
>  onTriggered: updateState()

fix

> ToolBoxRoot.qml:42
>  }
> -
> -//FIXME: this timer shouldn't exist, but unfortunately when the focus 
> passes
> -//from the desktop to the dialog or vice versa, the event is not atomic
> -//and ends up with neither of those having focus, hiding the dialog when
> -//it shouldn't
> -Timer {
> -id: hideDialogTimer
> -interval: 0
> -//NOTE: it's checking activeFocusItem instead of active as active 
> doesn't correctly signal its change
> -property bool desktopOrDialogFocus: main.Window.activeFocusItem !== 
> null || (toolBoxLoader.item && toolBoxLoader.item.activeFocusItem !== null)
> -onDesktopOrDialogFocusChanged: {
> -if (!desktopOrDialogFocus) {
> -hideDialogTimer.restart();
> -}
> -
> -}
> -onTriggered: {
> -if (!desktopOrDialogFocus) {
> -open = false;
> -}
> -}
> -}
> -
> +/*
>  signal minimumWidthChanged

fix

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: davidedmundson, ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Björn Feber]

GB_2 added a comment.


  Why not? Currently you have to open the context menu for the panel or 
desktop, so it's inconsistent and confusing if you want to move a widget and 
the don't get the option to (without click+hold).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24264: edit mode action and dbus

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> appletslayout.cpp:534
> +QMouseEvent *me = static_cast(event);
> +if (me->button() == Qt::LeftButton || (me->buttons() & 
> Qt::LeftButton)) {
> +mousePressEvent(me);

the first clause seems redundant

> appletslayout.cpp:593
>  && m_mouseDownWasEditMode
> +&& (event->source() == Qt::MouseEventSynthesizedBySystem
> +|| event->source() == Qt::MouseEventSynthesizedByQt)

Please comment what this is doing.

> want with normal mouse the edit mode not being dismissed when clicking on 
> empty areas  but to do it on touch

> shellcorona.cpp:220
> +
> +connect(qApp, ::focusWindowChanged,
> +this, [this] (QWindow *focusWindow) {

that's clever

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24264

To: mart, #plasma, #vdg, ngraham, GB_2, davidedmundson
Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Yunhe Guo]

guoyunhe updated this revision to Diff 68225.
guoyunhe added a comment.


  Validate QUrl of image

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24727?vs=68185=68225

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24727

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

To: guoyunhe, #plasma
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  In D24265#549634 , @GB_2 wrote:
  
  > I'd also add the "Customize Layout..." menu item to the widget context 
menu, that way you can discover it much more easily.
  
  
  i would prefer not

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

[Harald Sitter]

sitter added a comment.


  When I put the code in a minimal standalone program I can confirm that the 
code works just fine. Are you sure your testing methodology is sound @ngraham ?
  
  In point of fact
  
if (url.isEmpty()) {
  
  should actually be `url.isValid` because the requirement is not just that it 
needs to be nonempty but also valid, and when changed that condition would show 
more clearly that the right code is run as the KIO warning should disappear.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Björn Feber]

GB_2 added a comment.


  I'd also add the "Customize Layout..." button to the widget menu, that way 
you can discover it much more easily.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24750: Fix reading environment variables with newline

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Thanks for the swift action

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24750

To: fvogt, #plasma, apol, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  In D24265#549583 , @GB_2 wrote:
  
  > An "Add Panel..." button in the toolbox would be very useful too :-)
  
  
  maybe.. tough it must have a submenus that loads the available installed 
panel layouts... may get messy

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: lbeltrame, cgiboudeaux.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  This way the repository with debuginfo does not have to be enabled
  manually before clicking on the button.
  This option works again now, so it should be passed as default.

TEST PLAN
  Not yet, waiting for feedback.

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24751

AFFECTED FILES
  src/doc/examples/installdbgsymbols_suse.sh

To: fvogt, lbeltrame, cgiboudeaux
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24260: [Style KCM] Don't explicitly reload KWin's configuration

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:58fe6dabbb0f: [Style KCM] Dont explicitly reload 
KWins configuration (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24260?vs=66947=68219

REVISION DETAIL
  https://phabricator.kde.org/D24260

AFFECTED FILES
  kcms/style/kcmstyle.cpp

To: broulik, #plasma, #kwin, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Björn Feber]

GB_2 added a comment.


  An "Add Panel..." button in the toolbox would be very useful too :-)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

[Björn Feber]

GB_2 added a comment.


  Only one last issue: the widget resizing handles disappear when you are on a 
blank area of the widget handle (the bar to the left/right).

INLINE COMMENTS

> GB_2 wrote in ToolBoxButton.qml:292
> This should probably be changed to "Finish Customizing Layout" to match the 
> current menu entry.

Not done.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  In D24732#549249 , @ngraham wrote:
  
  > Finally, I would consider adding the "Other applications are available in 
Discover" text to the bottom, so it doesn't interrupt the dialog's flow.
  
  
  I'm not sure about that, because we already have the button and  the search 
bar at the botttom.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich updated this revision to Diff 68218.
jgrulich added a comment.


  Address review comments

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68140=68218

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Kai Uwe Broulik]

broulik added a comment.


  Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK and 
drop the cursor to position radios

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: broulik, filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, crozbo, 
ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D24750: Fix reading environment variables with newline

[Fabian Vogt]

fvogt added a comment.


  Note, the "-0" option is only available in GNU env, not in BSD /env... I 
can't think of a better way to fix this though other than implementing env 
ourselves in native code.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24750

To: fvogt, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Björn Feber]

GB_2 added a comment.


  In D24744#549486 , @gikari wrote:
  
  > In D24744#549450 , @GB_2 wrote
  >
  > > Well, it'll be gone completely soon and the GTK theme comboboxes will be 
in the Application Style KCM.
  >
  >
  > Where would gtk theme installation buttons go?
  
  
  Could be for example a button next to the combobox or just the "Get New" 
button.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, crozbo, 
ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D24750: Fix reading environment variables with newline

[Fabian Vogt]

fvogt updated this revision to Diff 68217.
fvogt added a comment.


  arc is a PoS

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24750?vs=68216=68217

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24750

AFFECTED FILES
  startkde/plasma-sourceenv.sh
  startkde/startplasma.cpp

To: fvogt, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24750: Fix reading environment variables with newline

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, apol.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Use '\0' as separator as '\n' is likely to appear in values.
  
  BUG: 413130

TEST PLAN
  /etc/profile.d/mc.sh exported an mc() function,
  which resulted in "syntax error: unexpected end of file" in the Plasma 
session.
  Now the mc function is correctly set in the environment.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24750

AFFECTED FILES
  CMakeLists.txt
  startkde/plasma-sourceenv.sh
  startkde/startplasma.cpp

To: fvogt, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24740: [Media Controller] Multiple artists support

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1be4bb880fde: [Media Controller] Multiple artists support 
(authored by lesf0, committed by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24740?vs=68159=68213

REVISION DETAIL
  https://phabricator.kde.org/D24740

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: lesf0, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Kai Uwe Broulik]

broulik added a comment.


  Pretty cool!
  Some minor nitpicks.
  Once all the KCMs have been ported to KConfigXT (XML config description, 
currently ongoing) we'll have a compile-time checked way to read KDE settings 
and easier way to get the default values.

INLINE COMMENTS

> CMakeLists.txt:9
>  find_package(Qt5 REQUIRED NO_MODULE COMPONENTS Widgets Svg Test)
> -find_package(KF5 REQUIRED COMPONENTS I18n KIO ConfigWidgets NewStuff Archive 
> KCMUtils IconThemes)
> +find_package(KF5 REQUIRED COMPONENTS I18n KIO ConfigWidgets NewStuff Archive 
> KCMUtils IconThemes KDELibs4Support)
>  find_package(X11 REQUIRED)

Please don't use `KDELibs4Support` in new code

> configeditor.cpp:34
> +
> +#undef signals
> +#include 

Alternatively you could compile the project with `QT_NO_KEYWORDS`

> configeditor.cpp:105
> +{
> +QRegularExpression regExp(paramName + "=[^\n]*($|\n)");
> +

make `static` so it doesn't have to recreate it every time?

> configeditor.cpp:170
> +char line[512];
> +FILE *cmd(popen("pidof -s xsettingsd", "r"));
> +fgets(line, 512, cmd);

I would prefer using more higher level `QProcess` here

> configeditor.h:22
> +
> +#include 
> +

Perhaps ``?

> configvalueprovider.cpp:38
> +{
> +KIconTheme *newIconTheme(KIconLoader::global()->theme());
> +return newIconTheme->internalName();

`theme()` can return null

> configvalueprovider.cpp:53
> +KConfigGroup configGroup(config->group(QStringLiteral("KDE")));
> +QString 
> kdeConfigValue(configGroup.readEntry(QStringLiteral("ShowIconsOnPushButtons")));
> +

Pass `true` as second argument (which is the default), then it will return you 
a `bool` directly.

> configvalueprovider.cpp:79
> +KConfigGroup configGroup(config->group(QStringLiteral("Toolbar style")));
> +QString 
> kdeConfigValue(configGroup.readEntry(QStringLiteral("ToolButtonStyle")));
> +return getToolbarStyleInDesiredNotation(kdeConfigValue, notation);

Default value `TextBesideIcon`

> configvalueprovider.h:1
> +#pragma once
> +

Missing copyright header

> configvalueprovider.h:10
> +enum class ToolbarStyleNotation {
> +XSETTINGSD = 0,
> +SETTINGS_INI,

We typically don't use all caps for enums

> configvalueprovider.h:17-22
> +QString getConfigFontName(const QFont );
> +QString getConfigIconThemeName();
> +QString getConfigCursorThemeName();
> +QString getIconsOnButtonsConfigValue();
> +QString getIconsInMenusConfigValue();
> +QString getToolbarStyle(ToolbarStyleNotation notation);

All of those `const`?

> gtkconfig.cpp:37
> +GtkConfig::GtkConfig(QObject *parent, const QVariantList&) :
> +KDEDModule(parent), configValueProvider(new ConfigValueProvider()), 
> configEditor(new ConfigEditor())
> +{

One variable per line, please

> gtkconfig.cpp:47
> +  
> SLOT(onGlobalSettingsChange(int,int)));
> +}
> +

Should this initially apply all the settings?

> gtkconfig.cpp:110
> +{
> +using ChangeType = KGlobalSettings::ChangeType;
> +using SettingsCategory = KGlobalSettings::SettingsCategory;

You'll have to copy those enum values in since `KGlobalSettings` is deprecated, 
sorry.

> gtkconfig.cpp:116
> +} else if (changeType == ChangeType::SettingsChanged && arg == 
> SettingsCategory::SETTINGS_STYLE) {
> +// Since KGlobalSettings::ChangeType::ToolbarStyleChanged is not 
> working,
> +// we use the style settings category as a whole to change the 
> respective settings

In what way? There's a comment in the style KCM saying

  // # FIXME - Doesn't apply all settings correctly due to bugs in 
KApplication/KToolbar
  KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);

> gtkconfig.h:24
> +
> +#include 
> +

Unused

> gtkconfig.h:33
> +{
> +Q_CLASSINFO("D-Bus Interface", "org.kde.gtkconfig")
> +Q_OBJECT

Unused

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
crozbo, ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart