D24844: [Applet] Remove hamburger button and menu

pkloc added a comment. There is use case for quick increase of maximum volume and I use it a lot, for quiet youtube videos. I just checked, and "new" way is same amount of clicks away so I wouldn't oppose it too much. Still, personally old way feels more intuitive. Now I'm starting to

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 218 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/218/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 03:20:36 + Build duration: 21 min and counting JUnit Tests Name:

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

ngraham added a comment. In D24842#551772 , @filipf wrote: > Makes sense. It's unrelated to this patch but what's up with the double message ("No space on device left" and "not enough free disk space") here? Yeah I need to fix that too.

D24844: [Applet] Remove hamburger button and menu

ngraham added a comment. In D24844#551795 , @romangg wrote: > > user feedback indicates nobody clicks on. > > You will get the feedback from people who use it after you have removed it and people can't use it anymore. It's the cycle

D24844: [Applet] Remove hamburger button and menu

romangg added subscribers: manueljlin, romangg. romangg added a comment. > user feedback indicates nobody clicks on. You will get the feedback from people who use it after you have removed it and people can't use it anymore. > You raise the maximum volume by clicking on the

D24844: [Applet] Remove "Raise Maximum Volume" menu item from Hamburger menu

ngraham updated this revision to Diff 68494. ngraham added a comment. This revision is now accepted and ready to land. Remove the hamburger menu completely and fix the slider's max volume not adjusting dynamically REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

kossebau resigned from this revision. kossebau added a comment. Still sorry for having stalled this effort. Stepping down as maintainer of the weather applet now, so also resigning here. Might be the chance to pick this up and just move on :) REPOSITORY R114 Plasma Addons REVISION DETAIL

D12944: [weather applet] Show a note why "Show temperature" is disabled

kossebau abandoned this revision. kossebau added a comment. No time to care for this more, someone else needs to take over if needed/wanted, REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12944 To: kossebau, #plasma Cc: mart, ngraham, plasma-devel,

Re: Weather applet/dataengine: passing on maintainer baton

Am Dienstag, 22. Oktober 2019, 00:42:01 CEST schrieb Friedrich W. H. Kossebau: > * https://bugs.kde.org/buglist.cgi? > bug_status=__open__=Weather_id=1672869=plasmashell > (though I remember some more open?) Indeed. Seems there are 2x components for the Plasma widget, once with plasmashell

D24711: [Mouse KCM] Fix acceleration profile on X11

ngraham accepted this revision. ngraham added a comment. Lovely. REPOSITORY R119 Plasma Desktop BRANCH fixMouseAccelProfile REVISION DETAIL https://phabricator.kde.org/D24711 To: miraiko, #plasma, romangg, ngraham Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n,

Weather applet/dataengine: passing on maintainer baton

Hi, 3 and 1/2 years after I adopted the code for the weather applet in kdeplasma- addons and the respective weather dataengine in plasma-workspace, to make it live on in Plasma5 era instead of being moved into the attic*, I feel there are too many other things now which have more of my

D22201: [mobile/wifi] Rework NetworkSetting header

This revision was automatically updated to reflect the committed changes. Closed by commit R116:02888058564f: [mobile/wifi] Rework NetworkSetting header (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22201?vs=60970=68491#toc REPOSITORY R116 Plasma Network

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

This revision was automatically updated to reflect the committed changes. Closed by commit R134:62d595f24db6: Use the text OK instead of Proceed in updates dialog when things go wrong (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24808: [mobile/wifi] Group networks by connection state

nicolasfella updated this revision to Diff 68490. nicolasfella added a comment. - Use section property REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24808?vs=68376=68490 BRANCH groups REVISION DETAIL

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Makes sense. It's unrelated to this patch but what's up with the double message ("No space on device left" and "not enough free disk space") here? REPOSITORY R134 Discover Software Store

D24844: [Applet] Remove "Raise Maximum Volume" menu item from Hamburger menu

ngraham planned changes to this revision. ngraham added a comment. Looks like it's a simple matter to get rid of the whole hamburger menu; I'll do it in this patch. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24844 To: ngraham, #vdg, #plasma,

D24844: [Applet] Remove "Raise Maximum Volume" menu item from Hamburger menu

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This action suffers from the following problems: - It's buggy: tt does not take into

D24711: [Mouse KCM] Fix acceleration profile on X11

romangg updated this revision to Diff 68487. romangg added a comment. Small code style change. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24711?vs=68109=68487 BRANCH fixMouseAccelProfile REVISION DETAIL https://phabricator.kde.org/D24711

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

romangg added a comment. @miraiko Do you have an email address that should be used for the commit? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24711 To: miraiko, #plasma, romangg Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24720: [applets/systemtray] Rewrite popups with layouts

filipf marked 5 inline comments as done. filipf added a comment. Everything should work fine now hopefully. REPOSITORY R120 Plasma Workspace BRANCH popup-rewrite (branched from master) REVISION DETAIL https://phabricator.kde.org/D24720 To: filipf, #plasma, #vdg, ngraham Cc: ognarb,

D24720: [applets/systemtray] Rewrite popups with layouts

filipf updated this revision to Diff 68485. filipf added a comment. - pin button now appears in the "Status and Notifications" popup again - simpler code for checking layout mirroring REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:78ccc2eba9cb: [KCMs/Night Color] Add a valueForText handler for the new SpinBox (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

ngraham added a comment. In D24838#551712 , @zzag wrote: > Uh, I don't use Ukrainian locale. However, it doesn't matter that much. We format numbers practically the same way as in en_US. > > Given the current implementation of textFromValue

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Uh, I don't use Ukrainian locale. However, it doesn't matter that much. We format numbers practically the same way as in en_US. Given the current implementation of textFromValue and the

D24720: [applets/systemtray] Rewrite popups with layouts

ognarb added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:48 > +//Menu mode > +if (!activeApplet && hiddenItemsView.visible && > LayoutMirroring.enabled === false) { > +return units.smallSpacing; !LayoutMirroring.enabled

D24843: [KDEPlatformSystemTrayIcon] Recreate menu when deleted

kmaterka created this revision. kmaterka added reviewers: apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Recreate internal menu when needed. It is possible that internal representation

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added a comment. Based on a search of some examples of RTL UI settings I'm going to say headings also go on the right side, so it seems they were actually not correctly placed before. But I actually still have two other dilemmas: - the pin icon doesn't show up anymore in the

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

ngraham accepted this revision. ngraham added a comment. All right. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D24162 To: GB_2, #plasma, #vdg, ngraham Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24720: [applets/systemtray] Rewrite popups with layouts

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh I see what you mean. This is fine then! REPOSITORY R120 Plasma Workspace BRANCH popup-rewrite (branched from master) REVISION DETAIL https://phabricator.kde.org/D24720 To:

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

GB_2 added a comment. In D24162#551673 , @ngraham wrote: > Oh, so that would need to be done in D24839 then? That would need to be a new patch IMO. REPOSITORY R119 Plasma Desktop BRANCH master

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added a comment. The latest version already works with RTL without the `fillWidth` code being needed. So as far as I can tell the diff you posted only effectively removes the margins from headings. But I think we should keep them, i.e., align those headings with the container (@GB_2

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

ngraham added a comment. Oh, so that would need to be done in D24839 then? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D24162 To: GB_2, #plasma, #vdg, ngraham Cc: #vdg, plasma-devel, #plasma,

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

GB_2 added a comment. In D24162#551671 , @ngraham wrote: > The Edit Panel menu item probably shouldn't be visible while that panel is currently being edited: F7642545: Screenshot_20191021_131210.png

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

ngraham added a comment. The Edit Panel menu item probably shouldn't be visible while that panel is currently being edited: F7642545: Screenshot_20191021_131210.png REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

GB_2 updated this revision to Diff 68480. GB_2 added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24839?vs=68468=68480 BRANCH arcpatch-D24839 REVISION DETAIL https://phabricator.kde.org/D24839 AFFECTED FILES

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

ngraham added a comment. Also needs a rebase REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24839 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Otherwise the button says "Proceed" when the dialog is showing you an

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

GB_2 updated this revision to Diff 68476. GB_2 added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24162?vs=66679=68476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24162 AFFECTED FILES

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

ngraham added a comment. Needs a rebase REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D24162 To: GB_2, #plasma, #vdg, ngraham Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

ngraham added a comment. Does it work in your locale? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24838 To: ngraham, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

zzag removed a reviewer: zzag. zzag added inline comments. INLINE COMMENTS > main.qml:319 > +valueFromText: function(text, locale) { > +return parseInt(text); > +} Hmm, does parseInt take the

D24834: [KCM] Try harder to display all text in the visualizations

romangg added a comment. Next time. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24834 To: ngraham, romangg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,

D24720: [applets/systemtray] Rewrite popups with layouts

ngraham added a comment. This works for me: P482 Patch for https://phabricator.kde.org/D24720 F7642232: Screenshot_20191021_113604.png F7642255: Screenshot_20191021_114030.png

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Not needed for normal users with the new edit mode system. TEST PLAN Lock the widgets before

D24732: Rewrite AppChooser dialog

ngraham added a subscriber: mart. ngraham added a comment. In D24732#551035 , @jgrulich wrote: > In D24732#550902 , @ngraham wrote: > > > So close! You don't need to create a `Rectangle` to give the

D24834: [KCM] Try harder to display all text in the visualizations

ngraham added a comment. In D24834#551549 , @romangg wrote: > Add a more meaningful summary please and replace the `5.17` text with it. Oops sorry, I missed this before landing it. :( REPOSITORY R104 KScreen REVISION DETAIL

D24834: [KCM] Try harder to display all text in the visualizations

This revision was automatically updated to reflect the committed changes. Closed by commit R104:3c406779cca9: [KCM] Try harder to display all text in the visualizations (authored by ngraham). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24834?vs=68448=68466

D24834: [KCM] Try harder to display all text in the visualizations

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. In D24834#551507 , @ngraham wrote: > In D24834#551506 , @romangg wrote: > > > Looks good. If

D24834: [KCM] Try harder to display all text in the visualizations

romangg added a comment. Add a more meaningful summary please and remove the 5.17. REPOSITORY R104 KScreen BRANCH more-text-in-visualizations (branched from Plasma/5.17) REVISION DETAIL https://phabricator.kde.org/D24834 To: ngraham, romangg, #plasma Cc: plasma-devel, LeGast00n,

D24814: [KCMs] Make spinboxes editable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:4f90a137e7a3: [KCMs] Make spinboxes editable (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE

D24814: [KCMs] Make spinboxes editable

ngraham added a comment. Landing without explicit approval since D24816 which does the exact same thing elsewhere was approved, and the logic for approving is identical. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24814: [KCMs] Make spinboxes editable

ngraham updated this revision to Diff 68464. ngraham added a comment. Add valueFromText handlers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24814?vs=68397=68464 BRANCH editable-spinboxes (branched from Plasma/5.17) REVISION DETAIL

D24815: [Weather] Make update time spinbox editable

ngraham added a comment. Landing without approval since D24816 which does the exact same thing elsewhere was approved, and the logic for approving is identical. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24815 To:

D24815: [Weather] Make update time spinbox editable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:ec2392dbf70a: [Weather] Make update time spinbox editable (authored by ngraham). REPOSITORY R114 Plasma Addons

D24815: [Weather] Make update time spinbox editable

ngraham updated this revision to Diff 68462. ngraham added a comment. Add a valueFromText handler REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24815?vs=68398=68462 BRANCH editable-spinbox (branched from Plasma/5.17) REVISION DETAIL

D24816: [Applet] Make spinboxes editable

This revision was automatically updated to reflect the committed changes. Closed by commit R115:e1a2940de814: [Applet] Make spinboxes editable (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24816?vs=68460=68461

D24816: [Applet] Make spinboxes editable

ngraham updated this revision to Diff 68460. ngraham added a comment. Add valueForText handlers REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24816?vs=68399=68460 BRANCH editable-spinboxes (branched from Plasma/5.17) REVISION DETAIL

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

ngraham added a comment. @zzag https://phabricator.kde.org/D24838 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24813 To: ngraham, #vdg, #plasma, davidedmundson Cc: zzag, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

ngraham created this revision. ngraham added reviewers: zzag, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now you can enter "1 minute" and it will be parsed correctly TEST PLAN Enter "1 minute"

D24834: [KCM] Try harder to display all text in the visualizations

ngraham added a comment. You good with getting this into 5.17 now, and we can investigate what should be displayed in there for 5.18? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24834 To: ngraham, romangg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24834: [KCM] Try harder to display all text in the visualizations

ngraham added a comment. In D24834#551506 , @romangg wrote: > Looks good. If the display is too small to display two rows or the name is even longer, does it just elide? Yep. > One question I have long term is what information

D24834: [KCM] Try harder to display all text in the visualizations

romangg added a comment. Looks good. If the display is too small to display two rows or the name is even longer, does it just elide? One question I have long term is what information actually needs to be in there. Currently we have name and the logical size. Would only the name or name

D24765: [WIP] Notification applet on the phone

mart updated this revision to Diff 68455. mart added a comment. - don't show jobs in popups on mobile REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24765?vs=68253=68455 BRANCH mart/mobilenotifications REVISION DETAIL

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, hein, ngraham Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D24730: Port KCMSplashScreen to KConfigXT

crossi updated this revision to Diff 68450. crossi added a comment. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. remove unnecessary emit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24730?vs=68130=68450 REVISION DETAIL

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

ngraham added inline comments. INLINE COMMENTS > zzag wrote in main.qml:300 > Qt documentation says that we need to override valueFromText > > > Note: When applying a custom textFromValue implementation for editable > > spinboxes, a matching valueFromText implementation must be provided to be

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

zzag added inline comments. INLINE COMMENTS > main.qml:300 > } > - > -inputMethodHints: Qt.ImhDigitsOnly > -validator: IntValidator {bottom: 1; top: > 600;} // less than 12 hours (in minutes: 720)

D24833: [KCM] Revert change to reduce size of screens in visualization

ngraham added a comment. In D24833#551421 , @romangg wrote: > Yea it's better how it was before. But it could still be improved with some text/fonts/elide magic I guess. Should be fully improved in D24834

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cd14bbc9c720: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24834: [KCM] Try harder to display all text in the visualizations

ngraham created this revision. ngraham added reviewers: romangg, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY 5.17 TEST PLAN F7641815: More text.png

D24833: [KCM] Revert change to reduce size of screens in visualization

This revision was automatically updated to reflect the committed changes. Closed by commit R104:318c16f3c604: [KCM] Revert change to reduce size of screens in visualization (authored by ngraham). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D24833: [KCM] Revert change to reduce size of screens in visualization

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Yea it's better how it was before. But it could still be improved with some text/fonts/elide magic I guess. 5.17 REPOSITORY R104 KScreen BRANCH bigger-screens-in-visualization

D24833: [KCM] Revert change to reduce size of screens in visualization

ngraham created this revision. ngraham added reviewers: VDG, Plasma, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This was done in D23798 , but in retrospect,

D24068: docs: add contributing guide

romangg added inline comments. INLINE COMMENTS > yurchor wrote in CONTRIBUTING.md:58 > Typo: "communication" (singular) or "happen" Thanks! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24068 To: romangg, #plasma Cc: yurchor, broulik, ngraham, plasma-devel,

D24068: docs: add contributing guide

romangg updated this revision to Diff 68445. romangg marked an inline comment as done. romangg added a comment. - Rebase - Fix typo REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=66437=68445 BRANCH contributingGuide REVISION DETAIL

D24832: Re-add category display to app delegates

This revision was automatically updated to reflect the committed changes. Closed by commit R134:9dc1768ac897: Re-add category display to app delegates (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24832?vs=68443=68444

D24832: Re-add category display to app delegates

ngraham updated this revision to Diff 68443. ngraham marked an inline comment as done. ngraham added a comment. Simplify layout conditional REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24832?vs=68439=68443 BRANCH

D24479: [KCM] Make multi-screen draggability more obvious

ngraham updated this revision to Diff 68440. ngraham added a comment. Reduce label opacity REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24479?vs=68259=68440 BRANCH make-draggability-more-obvious (branched from master) REVISION DETAIL

D24479: [KCM] Make multi-screen draggability more obvious

ngraham added a comment. All right. :) REPOSITORY R104 KScreen BRANCH make-draggability-more-obvious (branched from master) REVISION DETAIL https://phabricator.kde.org/D24479 To: ngraham, romangg, #plasma, #vdg Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n,

D24832: Re-add category display to app delegates

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's try and see what it feels like INLINE COMMENTS > ApplicationDelegate.qml:77 > +level: delegateArea.compact ? 3 : 2 > +Layout.fillWidth:

D24479: [KCM] Make multi-screen draggability more obvious

romangg added a comment. Not sure. Do what you feel is best and then commit. ;) REPOSITORY R104 KScreen BRANCH make-draggability-more-obvious (branched from master) REVISION DETAIL https://phabricator.kde.org/D24479 To: ngraham, romangg, #plasma, #vdg Cc: GB_2, davidedmundson,

D24479: [KCM] Make multi-screen draggability more obvious

ngraham marked an inline comment as done. ngraham added a comment. Better? F7641631: Screenshot_20191021_081742.png REPOSITORY R104 KScreen BRANCH make-draggability-more-obvious (branched from master) REVISION DETAIL

D24832: Re-add category display to app delegates

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY A year ago, I removed this in 0911fbcd561c

D24479: [KCM] Make multi-screen draggability more obvious

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. I'm not 100% happy with the font of the message in the overview. Maybe decrease opacity? But it's also not a pressing issue. REPOSITORY R104 KScreen BRANCH

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

ngraham updated this revision to Diff 68434. ngraham marked 2 inline comments as done. ngraham added a comment. Handle singular and plural forms of the word REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24813?vs=68396=68434 BRANCH

D24634: Allow contextualActions to flow into the header toolbar

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d09b13861254: Allow contextualActions to flow into the header toolbar (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24634?vs=67906=68433

D20132: Actually make the network list view show up

jgrulich added a comment. Can we drop this request? I believe it works just fine now. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20132 To: vkrause, jgrulich Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 217 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/217/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 11:07:18 + Build duration: 10 min and counting CONSOLE OUTPUT

D24265: support global edit mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ae55560053ef: support global edit mode (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24265?vs=68414=68426#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24818: Filter invalid services in most used model

This revision was automatically updated to reflect the committed changes. Closed by commit R124:ec90e4066c16: Filter invalid services in most used model (authored by broulik). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24818?vs=68401=68425

D24264: edit mode action and dbus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c9c0f070a91b: edit mode action and dbus (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=68234=68423 REVISION DETAIL

D24749: Fix build with older glibc: link there to librt for clock_gettime

This revision was automatically updated to reflect the committed changes. Closed by commit R111:3cd40fede73e: Fix build with older glibc: link there to librt for clock_gettime (authored by kossebau). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D24785: Store stashed model index as QPersistentModelIndex

This revision was automatically updated to reflect the committed changes. Closed by commit R124:de7f988c71b2: Store stashed model index as QPersistentModelIndex (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

Monday meeting notes from 21/10/2019

Kai Uwe: plasma-browser-integration: * Shows host version number in extension about screen now Notifications: * Worked around a crash in old notifications with newer Qt * New system since Plasma 5.16 isn't affected but 5.12 LTS was, so I had to do something KWin: * Startup feedback ("bouncing

D24634: [WIP] Allow contextualActions to flow into the header toolbar

mart accepted this revision. mart added a comment. just remove the WIP from the review title then good to go REPOSITORY R169 Kirigami BRANCH contextactions_in_toolbar REVISION DETAIL https://phabricator.kde.org/D24634 To: ahiemstra, #kirigami, ngraham, mart Cc: mart, ngraham,

D24768: Fix incorrect Credits model for Kirigami.AboutPage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9e3407ec40ab: Fix incorrect Credits model for Kirigami.AboutPage (authored by IlyaBizyaev). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24768?vs=68269=68418

D24763: [kcms/nightcolor] Add hints to temperature slider direction

This revision was automatically updated to reflect the committed changes. Closed by commit R119:04e426461927: [kcms/nightcolor] Add hints to temperature slider direction (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration

crossi updated this revision to Diff 68416. crossi added a comment. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. restore blank lines REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24819?vs=68405=68416 REVISION DETAIL

D24265: support global edit mode

GB_2 added inline comments. INLINE COMMENTS > ToolBoxButton.qml:230 > +PlasmaComponents3.ToolTip { > +text: i18n("Close Edit Mode") > +} Please change to "Finish Customizing Layout" to match the menu entry. REPOSITORY R119 Plasma Desktop

D24265: support global edit mode

mart updated this revision to Diff 68414. mart added a comment. - don't dismiss applet edit mode when overing the handle REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=68235=68414 BRANCH mart/editMode REVISION DETAIL

  1   2   >