KDE CI: Plasma » plasma-browser-integration » stable-kf5-qt5 FreeBSDQt5.13 - Build # 24 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/stable-kf5-qt5%20FreeBSDQt5.13/24/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 23 Oct 2019 05:53:22 +
 Build duration:
5 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 2 lines...][Pipeline] Start of Pipeline[Pipeline] nodeRunning on FreeBSD Builder 1 in /usr/home/jenkins/workspace/Plasma/plasma-browser-integration/stable-kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2019-10-23T05:53:23.803Z] No credentials specified[2019-10-23T05:53:23.805Z] Cloning the remote Git repository[2019-10-22T16:13:39.068Z] Cloning repository git://anongit.kde.org/plasma-browser-integration[2019-10-22T16:13:39.068Z]  > git init /usr/home/jenkins/workspace/Plasma/plasma-browser-integration/stable-kf5-qt5 FreeBSDQt5.13 # timeout=10[2019-10-22T16:13:39.076Z] Fetching upstream changes from git://anongit.kde.org/plasma-browser-integration[2019-10-22T16:13:39.077Z]  > git --version # timeout=10[2019-10-22T16:13:39.082Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-browser-integration +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-10-23T05:53:33.024Z] Checking out Revision fd3c93e994e76b4772f51ca5ea8712e6539e4d49 (refs/remotes/origin/Plasma/5.17)[2019-10-23T05:53:33.057Z] Commit message: "GIT_SILENT made messages (after extraction)"[2019-10-22T16:13:48.161Z]  > git config remote.origin.url git://anongit.kde.org/plasma-browser-integration # timeout=10[2019-10-22T16:13:48.164Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-22T16:13:48.175Z]  > git config remote.origin.url git://anongit.kde.org/plasma-browser-integration # timeout=10[2019-10-22T16:13:48.183Z] Fetching upstream changes from git://anongit.kde.org/plasma-browser-integration[2019-10-22T16:13:48.183Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-browser-integration +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-10-22T16:13:48.259Z]  > git rev-parse Plasma/5.17^{commit} # timeout=10[2019-10-22T16:13:48.275Z]  > git rev-parse refs/remotes/origin/Plasma/5.17^{commit} # timeout=10[2019-10-22T16:13:48.281Z]  > git config core.sparsecheckout # timeout=10[2019-10-22T16:13:48.291Z]  > git checkout -f fd3c93e994e76b4772f51ca5ea8712e6539e4d49 # timeout=10[2019-10-22T16:13:48.314Z]  > git rev-list --no-walk fe64fea532a1d6a73f11292dc50018224b6e995f # timeout=10[Pipeline] checkout[2019-10-23T05:53:33.133Z] No credentials specified[2019-10-23T05:53:33.135Z] Cloning the remote Git repository[2019-10-22T16:13:48.393Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-10-22T16:13:48.393Z]  > git init /usr/home/jenkins/workspace/Plasma/plasma-browser-integration/stable-kf5-qt5 FreeBSDQt5.13/ci-tooling # timeout=10[2019-10-22T16:13:48.401Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-10-22T16:13:48.401Z]  > git --version # timeout=10[2019-10-22T16:13:48.410Z]  > git fetch --tags --force --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-23T05:53:34.416Z] Checking out Revision caef857fc303917e5022e227386bdb7a9017d4b9 (origin/master)[2019-10-23T05:53:34.446Z] Commit message: "Use default parameters instead of a global before_script block"[Pipeline] checkout[2019-10-23T05:53:34.725Z] No credentials specified[2019-10-23T05:53:34.731Z] Cloning the remote Git repository[2019-10-22T16:13:49.527Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-10-22T16:13:49.530Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-22T16:13:49.537Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-10-22T16:13:49.543Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-10-22T16:13:49.543Z]  > git fetch --tags --force --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-22T16:13:49.665Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-10-22T16:13:49.674Z]  > git config core.sparsecheckout # timeout=10[2019-10-22T16:13:49.680Z]  > git checkout -f caef857fc303917e5022e227386bdb7a9017d4b9 # timeout=10[2019-10-22T16:13:49.991Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-10-22T16:13:49.991Z]  > git init /usr/home/jenkins/workspace/Plasma/plasma-browser-integration/stable-kf5-qt5 FreeBSDQt5.13/ci-tooling/repo-metadata # timeout=10[2019-10-22T16:13:49.998Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-10-22T16:13:49.998Z]  > git --version # timeout=10[2019-10-22T16:13:50.006Z]  > git fetch --tags --force 

D24847: KCM Icons fix theme selected when we hit delete theme

[Kevin Ottens]

ervin added a subscriber: bport.
ervin added a comment.


  Hello,
  
  - F7654931: signature.asc 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis added a comment.


  I think it might be a good idea to add an animation mode for the sunken 
state. Right now, the transition is just instant.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis added a comment.


  In D24706#552291 , @ngraham wrote:
  
  > I'm not a fan of changing the background for focused buttons. I think it 
just confuses things, and doesn't fix the current problem; it just changes it. 
IMO focus (not hover, focus) should be indicated exclusively with an outline 
around the control drawn in the highlight color.
  
  
  I like having an effect similar to list items in Plasmashell. Anyway, here's 
what no focus background looks like: F7654754: 
breeze_mod_button_demo3-NoFocusBG-2019-10-23_01.06.42.webm 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis updated this revision to Diff 68584.
ndavis added a comment.


  - Remove focus background

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24706?vs=68496=68584

BRANCH
  ndavis/pushbutton-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24706

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

[Aleix Pol Gonzalez]

apol added a comment.


  +1 conceptually.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24877

To: davidedmundson, #plasma
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

[Nathaniel Graham]

ngraham added a comment.


  > Deal with a certain distro renaming qdbus.
  
  FWIW we have the same issue in other places too 
(https://bugs.kde.org/show_bug.cgi?id=413007) so perhaps a generic solution 
would work... or else maybe we should lobby said distro(s?) to make a 
compatibility symlink.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24877

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  I want to move the shortcuts out of ksmserver. None of the actions now 
involve ksmserver directly and the
  layering is now such that a wayland only session could run without ksmserver.
  
  This patch uses .desktop file actions so kglobalaccel just calls the relevant 
hook directly rather than needing
  a background service constantly running
  
  WIP as:
  I need migration,
  I need to write the default shortcut in the correct syntax.
  We would need some way to hide the default _launch entry
  We've lost the kauthorized key, but we should be handling that in the 
receiver anyway?
  Deal with a certain distro renaming qdbus.
  
  But I wanted some early feedback on whether this was a clever use of the 
existing framework, or a dirty hack.

TEST PLAN
  WIP

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24877

AFFECTED FILES
  ksmserver/main.cpp
  ksmserver/server.cpp
  ksmserver/server.h
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/org.kde.plasma.session.desktop

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

[Christian Muehlhaeuser]

muesli added a comment.


  Would love to finish this one up! :)
  Any suggestions how to move forward?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24759: [ksmserver] Drop unused logout effect widget

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9b857cce251f: [ksmserver] Drop unused logout effect 
widget (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24759?vs=68240=68573

REVISION DETAIL
  https://phabricator.kde.org/D24759

AFFECTED FILES
  ksmserver/logout.cpp
  ksmserver/server.cpp
  ksmserver/server.h

To: davidedmundson, #plasma, #kwin, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 169 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/169/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 19:49:16 +
 Build duration:
6 min 51 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24865: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka requested review of this revision.
kmaterka added a comment.


  I added ugly way of checking if passed QVariant(QIcon) is null. Should I 
create native C++ method for that check or this can be done in QML, but in 
nicer way?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added inline comments.

INLINE COMMENTS

> StatusNotifierItem.qml:52
> +if (taskIcon.status === PlasmaCore.Types.NeedsAttentionStatus) {
> +if (AttentionIcon && AttentionIcon != "QVariant(QIcon, 
> QIcon(null))") {
> +return AttentionIcon

I know... Do you know another way how to check if QVariant(QIcon) is null? I 
know that I can create simple native method in systemtray.cpp for that - will 
it be better?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka updated this revision to Diff 68566.
kmaterka added a comment.


  Fallback to Icon if there is no AttentionIcon.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24865?vs=68543=68566

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24870: Apply autoplay prevention evasion also to document.createElement

[Kai Uwe Broulik]

broulik added a comment.


  I am not sure. I thought since a video is likely in the DOM or otherwise it 
won't be visible, the user can at least play it.
  But then I just remembered how Spotify used a `` tag for playing its 
music...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24870

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: [Mouse KCM] Fix acceleration profile on X11

[Mirai Komachi]

miraiko added a comment.


  @romangg sorry for the late reply, all is well, thanks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg, ngraham
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24870: Apply autoplay prevention evasion also to document.createElement

[Fabian Vogt]

fvogt added a comment.


  Is this not needed for `` as well?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24870

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24870: Apply autoplay prevention evasion also to document.createElement

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It affects audio player created this way the same as a `new Audio()`
  
  BUG: 411742

TEST PLAN
  - Google translate still works
  - Cambridge dictionary works now 
https://dictionary.cambridge.org/dictionary/english/example
  - Forvo.com works now

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24870

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24847: KCM Icons fix theme selected when we hit delete theme

[Nathaniel Graham]

ngraham added a comment.


  Does this patch have unmarked dependencies? It doesn't apply for me:
  
$ arc patch D24847
INFO  Base commit is not in local repository; trying to fetch.
created and checked out branch arcpatch-D24847.


This diff is against commit 38806dbe3f9a65aea6ae031b959ff4adac9bf444, 
but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (528388bfeb69fc22a259845e28fbef2a375e7bd6)
[Y/n] y

Checking patch kcms/icons/package/contents/ui/main.qml...
Checking patch kcms/icons/main.cpp...
error: while searching for:
m_model->load();
m_model->setSelectedTheme(KIconTheme::current());
updateNeedsSave();
}

void IconModule::save()

error: patch failed: kcms/icons/main.cpp:148
Checking patch kcms/icons/iconsmodel.cpp...
Applied patch kcms/icons/package/contents/ui/main.qml cleanly.
Applying patch kcms/icons/main.cpp with 1 reject...
Rejected hunk #1.
Applied patch kcms/icons/iconsmodel.cpp cleanly.

 Patch Failed! 
Usage Exception: Unable to apply patch!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 168 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/168/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 18:05:17 +
 Build duration:
7 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 3424 lines...][2019-10-22T18:12:37.285Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-22T18:12:37.285Z]   ^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-22T18:12:37.285Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-22T18:12:37.285Z]^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-22T18:12:37.285Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-22T18:12:37.285Z]  ^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:337:34: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-22T18:12:37.285Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-22T18:12:37.285Z]  ^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-22T18:12:37.285Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T18:12:37.285Z]^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-22T18:12:37.285Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-22T18:12:37.285Z]  ^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:337:60: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-22T18:12:37.285Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-22T18:12:37.285Z]^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-22T18:12:37.285Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-22T18:12:37.285Z]   ^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-22T18:12:37.285Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-22T18:12:37.285Z]^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-22T18:12:37.285Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-22T18:12:37.285Z]  ^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:337:94: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-22T18:12:37.285Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-22T18:12:37.285Z]  ^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-22T18:12:37.285Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-22T18:12:37.285Z]   ^[2019-10-22T18:12:37.285Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-22T18:12:37.285Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-22T18:12:37.285Z]

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/52/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 17:59:21 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 456 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/456/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 18:05:16 +
 Build duration:
8 min 13 sec and counting
   CONSOLE OUTPUT
  [...truncated 4533 lines...][2019-10-22T18:13:18.628Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T18:13:18.628Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:29:[2019-10-22T18:13:18.628Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T18:13:18.628Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T18:13:18.628Z]   |^~[2019-10-22T18:13:18.628Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:448:70: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T18:13:18.628Z]   448 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-22T18:13:18.628Z]   |  ^[2019-10-22T18:13:18.628Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T18:13:18.628Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:29:[2019-10-22T18:13:18.628Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T18:13:18.628Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T18:13:18.628Z]   |^~[2019-10-22T18:13:18.628Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp: In member function ���void KCMLookandFeel::setColors(const QString&, const QString&)���:[2019-10-22T18:13:18.628Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:468:72: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T18:13:18.628Z]   468 | KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-22T18:13:18.628Z]   |^[2019-10-22T18:13:18.628Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T18:13:18.628Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:29:[2019-10-22T18:13:18.628Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T18:13:18.628Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T18:13:18.628Z]   |^~[2019-10-22T18:13:18.628Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:468:72: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T18:13:18.628Z]   468 | KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-22T18:13:18.628Z]   |^[2019-10-22T18:13:18.628Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T18:13:18.628Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:29:[2019-10-22T18:13:18.628Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T18:13:18.628Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T18:13:18.628Z]   |^~[2019-10-22T18:13:18.628Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp: In member function ���void KCMLookandFeel::setCursorTheme(QString)���:[2019-10-22T18:13:18.628Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:538:71: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T18:13:18.628Z]   538 | KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2019-10-22T18:13:18.628Z]   |

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/14/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 18:01:08 +
 Build duration:
9 min 26 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 37 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/37/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 18:03:13 +
 Build duration:
5 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4065)0%
(0/2771)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1438)0%
(0/1110)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/823)0%
(0/484)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/231)0%
(0/116)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1026)0%
(0/780)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 74 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/74/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 18:03:16 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/6)0%
(0/18)0%
(0/18)0%
(0/1533)0%
(0/605)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/272)0%
(0/126)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/100)0%
(0/27)core0%
(0/9)0%
(0/9)0%
(0/502)0%
(0/232)icons0%
(0/3)0%
(0/3)0%
(0/241)0%
(0/48)sidebar0%
(0/1)0%
(0/1)0%
(0/314)0%
(0/139)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/104)0%
(0/33)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 39 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/39/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 18:01:07 +
 Build duration:
3 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2583)14%
(212/1503)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/258)0%
(0/136)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D24192: WIP: Active page follow the focus

[Marco Martin]

mart added a comment.


  loses the focus after changing page because when current item changes, it 
sets focus to the page, which probably isn't set as focus scope

INLINE COMMENTS

> ognarb wrote in PageRow.qml:172
> @mart removePage doesn't work well, how can I change the current page?

what do you mean with doesn't work well?
anywaus, you should just set the current index, not removing anything from the 
row. it's a destructive action that should never happen automatically

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24192

To: ognarb, #kirigami, #plasma_accessibility
Cc: broulik, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, hein

D24861: Fix size of SpinBoxes

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
kmaterka marked an inline comment as done.
Closed by commit R885:2481a8eb6a22: Fix size of SpinBoxes (authored by 
kmaterka).

REPOSITORY
  R885 Redshift Control for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24861?vs=68558=68561

REVISION DETAIL
  https://phabricator.kde.org/D24861

AFFECTED FILES
  CMakeLists.txt
  package/contents/ui/config/ConfigGeneral.qml

To: kmaterka, martinkostolny, broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24861: Fix size of SpinBoxes

[Konrad Materka]

kmaterka marked an inline comment as done.
kmaterka added inline comments.

INLINE COMMENTS

> ngraham wrote in ConfigGeneral.qml:64
> Don't hardcode things like this; instead do `Kirigami.Units.gridUnit * 4`

OK, I made it the same width as IconPicker, it should look nice

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D24861

To: kmaterka, martinkostolny, broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24861: Fix size of SpinBoxes

[Konrad Materka]

kmaterka updated this revision to Diff 68558.
kmaterka added a comment.


  Do not use hardcoded values

REPOSITORY
  R885 Redshift Control for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24861?vs=68529=68558

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24861

AFFECTED FILES
  CMakeLists.txt
  package/contents/ui/config/ConfigGeneral.qml

To: kmaterka, martinkostolny, broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

[Anthony Fieroni]

anthonyfieroni added a comment.


  You can try it like that:
  
if (!m_editMode) {
event->setAccepted(false);
}

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24748

To: davidedmundson, #plasma
Cc: anthonyfieroni, wbauer, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Plasma 5.17.1

[Jonathan Riddell]

Plasma 5.17.1 is now released
https://www.kde.org/announcements/plasma-5.17.1.php

D24861: Fix size of SpinBoxes

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ConfigGeneral.qml:64
>  id: manualTemperatureStep
> +Layout.minimumWidth: 80
>  decimals: 0

Don't hardcode things like this; instead do `Kirigami.Units.gridUnit * 4`

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D24861

To: kmaterka, martinkostolny, broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: [RFC] Change button style

[Nathaniel Graham]

ngraham added a comment.


  I'm not a fan of changing the background for focused buttons. I think it just 
confuses things, and doesn't fix the current problem; it just changes it. IMO 
focus (not hover, focus) should be indicated exclusively with an outline around 
the control drawn in the highlight color.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 51 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/51/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 14:40:47 +
 Build duration:
27 min and counting
   CONSOLE OUTPUT
  [...truncated 211 lines...][2019-10-22T15:08:35.004Z] TERM  = 'su'[2019-10-22T15:08:35.004Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.13'[2019-10-22T15:08:35.004Z] BUILD_TAG = 'jenkins-Plasma-plasma-desktop-stable-kf5-qt5 FreeBSDQt5.13-51'[2019-10-22T15:08:35.004Z] BUILD_DISPLAY_NAME= '#51'[2019-10-22T15:08:35.004Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/51/display/redirect'[2019-10-22T15:08:35.004Z] USER  = 'jenkins'[2019-10-22T15:08:35.004Z] HOME  = '/home/jenkins'[2019-10-22T15:08:35.004Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/51/'[2019-10-22T15:08:35.004Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2019-10-22T15:08:35.004Z] HUDSON_URL= 'https://build.kde.org/'[2019-10-22T15:08:35.004Z] SHELL = '/usr/local/bin/bash'[2019-10-22T15:08:35.004Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13'[2019-10-22T15:08:35.004Z] MM_CHARSET= 'UTF-8'[2019-10-22T15:08:35.004Z] STAGE_NAME= 'Configuring Build'[2019-10-22T15:08:35.004Z] NODE_NAME = 'FreeBSD Builder 1'[2019-10-22T15:08:35.004Z] BLOCKSIZE = 'K'[2019-10-22T15:08:35.004Z] EXECUTOR_NUMBER   = '0'[2019-10-22T15:08:35.004Z] SHLVL = '0'[2019-10-22T15:08:35.004Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-22T15:08:35.004Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2019-10-22T15:08:35.004Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-10-22T15:08:35.004Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-10-22T15:08:35.004Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-10-22T15:08:35.005Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-10-22T15:08:35.005Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-10-22T15:08:35.005Z] QT_SELECT = 'qt5'[2019-10-22T15:08:35.005Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-22T15:08:35.005Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-10-22T15:08:35.005Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-10-22T15:08:35.005Z] [2019-10-22T15:08:35.005Z] [2019-10-22T15:08:35.005Z] == Commencing Configuration:[2019-10-22T15:08:35.005Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13"[2019-10-22T15:08:35.272Z] -- The C compiler identification is Clang 6.0.1[2019-10-22T15:08:35.554Z] -- The CXX compiler identification is Clang 6.0.1[2019-10-22T15:08:35.554Z] -- Check for working C compiler: /usr/bin/cc[2019-10-22T15:08:35.866Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-22T15:08:35.866Z] -- Detecting C compiler ABI info[2019-10-22T15:08:35.866Z] -- Detecting C compiler ABI info - done[2019-10-22T15:08:35.866Z] -- Detecting C compile features[2019-10-22T15:08:36.529Z] -- Detecting C compile features - done[2019-10-22T15:08:36.529Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-22T15:08:36.529Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-22T15:08:36.529Z] -- Detecting CXX compiler ABI info[2019-10-22T15:08:36.822Z] -- Detecting CXX compiler ABI info - done[2019-10-22T15:08:36.822Z] -- Detecting CXX compile features[2019-10-22T15:08:37.897Z] -- Detecting CXX compile features - done[2019-10-22T15:08:37.897Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-desktop.[2019-10-22T15:08:37.897Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-10-22T15:08:37.897Z] -- Looking for __GLIBC__[2019-10-22T15:08:37.897Z] -- Looking for __GLIBC__ - not 

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 73 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/73/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 14:52:27 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 266 lines...][2019-10-22T15:06:14.945Z] LESSOPEN  = 'lessopen.sh %s'[2019-10-22T15:06:14.945Z] USER  = 'jenkins'[2019-10-22T15:06:14.945Z] MORE  = '-sl'[2019-10-22T15:06:14.945Z] CSHEDIT   = 'emacs'[2019-10-22T15:06:14.945Z] SHLVL = '2'[2019-10-22T15:06:14.945Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-stable-kf5-qt5 SUSEQt5.12-73'[2019-10-22T15:06:14.945Z] WINDOWMANAGER = 'xterm'[2019-10-22T15:06:14.945Z] PAGER = 'less'[2019-10-22T15:06:14.945Z] EXECUTOR_NUMBER   = '0'[2019-10-22T15:06:14.945Z] CVS_RSH   = 'ssh'[2019-10-22T15:06:14.945Z] LIBGL_DEBUG   = 'quiet'[2019-10-22T15:06:14.945Z] STAGE_NAME= 'Configuring Build'[2019-10-22T15:06:14.945Z] NODE_LABELS   = 'Docker Swarm-956f511cdae2 SUSEQt5.12'[2019-10-22T15:06:14.945Z] XCURSOR_THEME = 'DMZ-Black'[2019-10-22T15:06:14.945Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-10-22T15:06:14.945Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-10-22T15:06:14.945Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-10-22T15:06:14.945Z] PROFILEREAD   = 'true'[2019-10-22T15:06:14.945Z] MAIL  = '/var/mail/jenkins'[2019-10-22T15:06:14.945Z] HOSTTYPE  = 'x86_64'[2019-10-22T15:06:14.945Z] BUILD_ID  = '73'[2019-10-22T15:06:14.945Z] LESSKEY   = '/etc/lesskey.bin'[2019-10-22T15:06:14.945Z] OLDPWD= '/home/jenkins'[2019-10-22T15:06:14.945Z] LC_CTYPE  = 'C.UTF-8'[2019-10-22T15:06:14.945Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-22T15:06:14.945Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-10-22T15:06:14.945Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-10-22T15:06:14.945Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-10-22T15:06:14.945Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-10-22T15:06:14.945Z] QT_SELECT = 'qt5'[2019-10-22T15:06:14.945Z] LANG  = 'en_US.UTF-8'[2019-10-22T15:06:14.945Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-22T15:06:14.945Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-10-22T15:06:14.945Z] [2019-10-22T15:06:14.945Z] [2019-10-22T15:06:14.945Z] == Commencing Configuration:[2019-10-22T15:06:14.945Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.12"[2019-10-22T15:06:15.504Z] -- The C compiler identification is GNU 9.2.1[2019-10-22T15:06:16.063Z] -- The CXX compiler identification is GNU 9.2.1[2019-10-22T15:06:16.063Z] -- Check for working C compiler: /usr/bin/cc[2019-10-22T15:06:18.569Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-22T15:06:18.569Z] -- Detecting C compiler ABI info[2019-10-22T15:06:18.569Z] -- Detecting C compiler ABI info - done[2019-10-22T15:06:18.569Z] -- Detecting C compile features[2019-10-22T15:06:18.569Z] -- Detecting C compile features - done[2019-10-22T15:06:18.569Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-22T15:06:18.825Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-22T15:06:18.825Z] -- Detecting CXX compiler ABI info[2019-10-22T15:06:18.825Z] -- Detecting CXX compiler ABI info - done[2019-10-22T15:06:18.825Z] -- Detecting CXX compile features[2019-10-22T15:06:18.825Z] -- Detecting CXX compile features - done[2019-10-22T15:06:18.825Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for systemsettings.[2019-10-22T15:06:18.825Z] -- Looking for __GLIBC__[2019-10-22T15:06:18.825Z] -- Looking for __GLIBC__ - found[2019-10-22T15:06:18.825Z] -- Performing Test _OFFT_IS_64BIT[2019-10-22T15:06:19.081Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-10-22T15:06:19.081Z] -- Performing Test HAVE_DATE_TIME[2019-10-22T15:06:19.081Z] -- Performing Test HAVE_DATE_TIME - Success[2019-10-22T15:06:19.081Z] -- Found KF5Crash: 

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

[Wolfgang Bauer]

wbauer added a comment.


  One thing maybe: with the Desktop layout, if you switch an applet to edit 
mode (by pressing and holding the left mouse button), it's not possible to exit 
edit mode by left-clicking on the desktop (even if no left-click action is 
configured). You need to click on a different applet now, but what if there is 
none...
  
  Without this patch it works.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24748

To: davidedmundson, #plasma
Cc: wbauer, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 36 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/36/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 14:52:21 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 260 lines...][2019-10-22T15:06:07.184Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-10-22T15:06:07.184Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12'[2019-10-22T15:06:07.184Z] HUDSON_URL= 'https://build.kde.org/'[2019-10-22T15:06:07.184Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-10-22T15:06:07.184Z] NODE_NAME = 'Docker Swarm-6747945ca010'[2019-10-22T15:06:07.184Z] HOST  = '6747945ca010'[2019-10-22T15:06:07.184Z] LESSOPEN  = 'lessopen.sh %s'[2019-10-22T15:06:07.184Z] USER  = 'jenkins'[2019-10-22T15:06:07.184Z] MORE  = '-sl'[2019-10-22T15:06:07.184Z] CSHEDIT   = 'emacs'[2019-10-22T15:06:07.184Z] SHLVL = '2'[2019-10-22T15:06:07.184Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.12-36'[2019-10-22T15:06:07.184Z] WINDOWMANAGER = 'xterm'[2019-10-22T15:06:07.184Z] PAGER = 'less'[2019-10-22T15:06:07.184Z] EXECUTOR_NUMBER   = '0'[2019-10-22T15:06:07.184Z] CVS_RSH   = 'ssh'[2019-10-22T15:06:07.184Z] LIBGL_DEBUG   = 'quiet'[2019-10-22T15:06:07.184Z] STAGE_NAME= 'Configuring Build'[2019-10-22T15:06:07.184Z] NODE_LABELS   = 'Docker Swarm-6747945ca010 SUSEQt5.12'[2019-10-22T15:06:07.184Z] XCURSOR_THEME = 'DMZ-Black'[2019-10-22T15:06:07.184Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-10-22T15:06:07.184Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-10-22T15:06:07.184Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-10-22T15:06:07.184Z] PROFILEREAD   = 'true'[2019-10-22T15:06:07.184Z] MAIL  = '/var/mail/jenkins'[2019-10-22T15:06:07.184Z] HOSTTYPE  = 'x86_64'[2019-10-22T15:06:07.184Z] BUILD_ID  = '36'[2019-10-22T15:06:07.184Z] LESSKEY   = '/etc/lesskey.bin'[2019-10-22T15:06:07.184Z] OLDPWD= '/home/jenkins'[2019-10-22T15:06:07.184Z] LC_CTYPE  = 'C.UTF-8'[2019-10-22T15:06:07.184Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-22T15:06:07.184Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-10-22T15:06:07.184Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-10-22T15:06:07.184Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-10-22T15:06:07.184Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-10-22T15:06:07.184Z] QT_SELECT = 'qt5'[2019-10-22T15:06:07.184Z] LANG  = 'en_US.UTF-8'[2019-10-22T15:06:07.184Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-22T15:06:07.184Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-10-22T15:06:07.184Z] [2019-10-22T15:06:07.184Z] [2019-10-22T15:06:07.184Z] == Commencing Configuration:[2019-10-22T15:06:07.184Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12"[2019-10-22T15:06:13.724Z] -- The C compiler identification is GNU 9.2.1[2019-10-22T15:06:14.652Z] -- The CXX compiler identification is GNU 9.2.1[2019-10-22T15:06:14.652Z] -- Check for working C compiler: /usr/bin/cc[2019-10-22T15:06:16.533Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-22T15:06:16.533Z] -- Detecting C compiler ABI info[2019-10-22T15:06:17.477Z] -- Detecting C compiler ABI info - done[2019-10-22T15:06:17.477Z] -- Detecting C compile features[2019-10-22T15:06:17.477Z] -- Detecting C compile features - done[2019-10-22T15:06:17.477Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-22T15:06:17.742Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-22T15:06:17.742Z] -- Detecting CXX compiler ABI info[2019-10-22T15:06:17.742Z] -- Detecting CXX compiler ABI info - done[2019-10-22T15:06:17.742Z] -- Detecting CXX compile features[2019-10-22T15:06:17.742Z] -- Detecting CXX compile features - done[2019-10-22T15:06:18.531Z] Installing in 

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 201 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/201/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 14:51:10 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 276 lines...][2019-10-22T15:01:35.221Z] WINDOWMANAGER = 'xterm'[2019-10-22T15:01:35.221Z] PAGER = 'less'[2019-10-22T15:01:35.221Z] EXECUTOR_NUMBER   = '0'[2019-10-22T15:01:35.222Z] CVS_RSH   = 'ssh'[2019-10-22T15:01:35.222Z] LIBGL_DEBUG   = 'quiet'[2019-10-22T15:01:35.222Z] STAGE_NAME= 'Configuring Build'[2019-10-22T15:01:35.222Z] NODE_LABELS   = 'Docker Swarm-23f8ef1c991f SUSEQt5.12'[2019-10-22T15:01:35.222Z] XCURSOR_THEME = 'DMZ-Black'[2019-10-22T15:01:35.222Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-10-22T15:01:35.222Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-10-22T15:01:35.222Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-10-22T15:01:35.222Z] PROFILEREAD   = 'true'[2019-10-22T15:01:35.222Z] MAIL  = '/var/mail/jenkins'[2019-10-22T15:01:35.222Z] HOSTTYPE  = 'x86_64'[2019-10-22T15:01:35.222Z] BUILD_ID  = '201'[2019-10-22T15:01:35.222Z] LESSKEY   = '/etc/lesskey.bin'[2019-10-22T15:01:35.222Z] OLDPWD= '/home/jenkins'[2019-10-22T15:01:35.222Z] LC_CTYPE  = 'C.UTF-8'[2019-10-22T15:01:35.222Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-22T15:01:35.222Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-10-22T15:01:35.222Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-10-22T15:01:35.222Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-10-22T15:01:35.222Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-10-22T15:01:35.222Z] QT_SELECT = 'qt5'[2019-10-22T15:01:35.222Z] LANG  = 'en_US.UTF-8'[2019-10-22T15:01:35.222Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-22T15:01:35.222Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-10-22T15:01:35.222Z] [2019-10-22T15:01:35.222Z] [2019-10-22T15:01:35.222Z] == Commencing Configuration:[2019-10-22T15:01:35.222Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12"[2019-10-22T15:01:35.222Z] -- The C compiler identification is GNU 9.2.1[2019-10-22T15:01:35.483Z] -- The CXX compiler identification is GNU 9.2.1[2019-10-22T15:01:35.483Z] -- Check for working C compiler: /usr/bin/cc[2019-10-22T15:01:40.830Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-22T15:01:40.830Z] -- Detecting C compiler ABI info[2019-10-22T15:01:41.107Z] -- Detecting C compiler ABI info - done[2019-10-22T15:01:41.107Z] -- Detecting C compile features[2019-10-22T15:01:41.107Z] -- Detecting C compile features - done[2019-10-22T15:01:41.107Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-22T15:01:41.394Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-22T15:01:41.394Z] -- Detecting CXX compiler ABI info[2019-10-22T15:01:41.671Z] -- Detecting CXX compiler ABI info - done[2019-10-22T15:01:41.671Z] -- Detecting CXX compile features[2019-10-22T15:01:41.671Z] -- Detecting CXX compile features - done[2019-10-22T15:01:41.671Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2019-10-22T15:01:41.671Z] -- Looking for __GLIBC__[2019-10-22T15:01:41.930Z] -- Looking for __GLIBC__ - found[2019-10-22T15:01:41.930Z] -- Performing Test _OFFT_IS_64BIT[2019-10-22T15:01:42.191Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-10-22T15:01:42.191Z] -- Performing Test HAVE_DATE_TIME[2019-10-22T15:01:42.455Z] -- Performing Test HAVE_DATE_TIME - Success[2019-10-22T15:01:42.455Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.64.0") [2019-10-22T15:01:42.455Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2019-10-22T15:01:42.455Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b3065f7db0d6: Install krunner desktop file to 
${KDE_INSTALL_APPDIR} (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24857?vs=68550=68551

REVISION DETAIL
  https://phabricator.kde.org/D24857

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: meven, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

[Méven Car]

meven updated this revision to Diff 68550.
meven added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24857?vs=68523=68550

BRANCH
  arcpatch-D24857

REVISION DETAIL
  https://phabricator.kde.org/D24857

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: meven, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/13/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 14:38:49 +
 Build duration:
6 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 199 lines...][2019-10-22T14:44:47.844Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2019-10-22T14:44:47.844Z] EDITOR= 'vi'[2019-10-22T14:44:47.844Z] ENV   = '/home/jenkins/.shrc'[2019-10-22T14:44:47.844Z] HUDSON_HOME   = '/home/production/data'[2019-10-22T14:44:47.844Z] CCACHE_DIR= '/home/jenkins/.ccache/'[2019-10-22T14:44:47.844Z] BUILD_ID  = '13'[2019-10-22T14:44:47.844Z] OLDPWD= '/usr/home/jenkins'[2019-10-22T14:44:47.844Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2019-10-22T14:44:47.844Z] _ = '/usr/local/bin/java'[2019-10-22T14:44:47.844Z] TERM  = 'su'[2019-10-22T14:44:47.844Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.13'[2019-10-22T14:44:47.844Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-13'[2019-10-22T14:44:47.844Z] BUILD_DISPLAY_NAME= '#13'[2019-10-22T14:44:47.844Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/13/display/redirect'[2019-10-22T14:44:47.844Z] USER  = 'jenkins'[2019-10-22T14:44:47.844Z] HOME  = '/home/jenkins'[2019-10-22T14:44:47.844Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/13/'[2019-10-22T14:44:47.844Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2019-10-22T14:44:47.844Z] HUDSON_URL= 'https://build.kde.org/'[2019-10-22T14:44:47.844Z] SHELL = '/usr/local/bin/bash'[2019-10-22T14:44:47.844Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2019-10-22T14:44:47.844Z] MM_CHARSET= 'UTF-8'[2019-10-22T14:44:47.844Z] STAGE_NAME= 'Configuring Build'[2019-10-22T14:44:47.844Z] NODE_NAME = 'FreeBSD Builder 1'[2019-10-22T14:44:47.844Z] BLOCKSIZE = 'K'[2019-10-22T14:44:47.844Z] EXECUTOR_NUMBER   = '0'[2019-10-22T14:44:47.844Z] SHLVL = '0'[2019-10-22T14:44:47.844Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-22T14:44:47.844Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2019-10-22T14:44:47.844Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-10-22T14:44:47.844Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-10-22T14:44:47.844Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-10-22T14:44:47.844Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-10-22T14:44:47.844Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-10-22T14:44:47.844Z] QT_SELECT = 'qt5'[2019-10-22T14:44:47.844Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-22T14:44:47.844Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-10-22T14:44:47.844Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-10-22T14:44:47.844Z] [2019-10-22T14:44:47.844Z] [2019-10-22T14:44:47.844Z] == Commencing Configuration:[2019-10-22T14:44:47.844Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2019-10-22T14:44:48.100Z] -- The C compiler identification is Clang 6.0.1[2019-10-22T14:44:48.100Z] -- The CXX compiler identification is Clang 6.0.1[2019-10-22T14:44:48.100Z] -- Check for working C compiler: /usr/bin/cc[2019-10-22T14:44:48.100Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-22T14:44:48.100Z] -- Detecting C compiler ABI info[2019-10-22T14:44:48.355Z] -- Detecting C compiler ABI info - done[2019-10-22T14:44:48.355Z] -- Detecting C compile features[2019-10-22T14:44:48.355Z] -- Detecting C compile features - done[2019-10-22T14:44:48.355Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-22T14:44:48.611Z] -- Check for working CXX compiler: 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 38 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/38/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 14:38:52 +
 Build duration:
4 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 258 lines...][2019-10-22T14:43:34.740Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-10-22T14:43:34.740Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/38/display/redirect'[2019-10-22T14:43:34.740Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-10-22T14:43:34.740Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-10-22T14:43:34.740Z] HUDSON_URL= 'https://build.kde.org/'[2019-10-22T14:43:34.740Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-10-22T14:43:34.740Z] NODE_NAME = 'Docker Swarm-29b69874b1fd'[2019-10-22T14:43:34.740Z] HOST  = '29b69874b1fd'[2019-10-22T14:43:34.740Z] LESSOPEN  = 'lessopen.sh %s'[2019-10-22T14:43:34.740Z] USER  = 'jenkins'[2019-10-22T14:43:34.740Z] MORE  = '-sl'[2019-10-22T14:43:34.740Z] CSHEDIT   = 'emacs'[2019-10-22T14:43:34.740Z] SHLVL = '2'[2019-10-22T14:43:34.740Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-38'[2019-10-22T14:43:34.740Z] WINDOWMANAGER = 'xterm'[2019-10-22T14:43:34.740Z] PAGER = 'less'[2019-10-22T14:43:34.740Z] EXECUTOR_NUMBER   = '0'[2019-10-22T14:43:34.740Z] CVS_RSH   = 'ssh'[2019-10-22T14:43:34.740Z] LIBGL_DEBUG   = 'quiet'[2019-10-22T14:43:34.740Z] STAGE_NAME= 'Configuring Build'[2019-10-22T14:43:34.740Z] NODE_LABELS   = 'Docker Swarm-29b69874b1fd SUSEQt5.12'[2019-10-22T14:43:34.740Z] XCURSOR_THEME = 'DMZ-Black'[2019-10-22T14:43:34.740Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-10-22T14:43:34.740Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-10-22T14:43:34.740Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-10-22T14:43:34.740Z] PROFILEREAD   = 'true'[2019-10-22T14:43:34.740Z] MAIL  = '/var/mail/jenkins'[2019-10-22T14:43:34.740Z] HOSTTYPE  = 'x86_64'[2019-10-22T14:43:34.740Z] BUILD_ID  = '38'[2019-10-22T14:43:34.740Z] LESSKEY   = '/etc/lesskey.bin'[2019-10-22T14:43:34.740Z] OLDPWD= '/home/jenkins'[2019-10-22T14:43:34.740Z] LC_CTYPE  = 'C.UTF-8'[2019-10-22T14:43:34.740Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-22T14:43:34.740Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-10-22T14:43:34.740Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-10-22T14:43:34.740Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-10-22T14:43:34.740Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-10-22T14:43:34.740Z] QT_SELECT = 'qt5'[2019-10-22T14:43:34.740Z] LANG  = 'en_US.UTF-8'[2019-10-22T14:43:34.740Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-22T14:43:34.740Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-10-22T14:43:34.740Z] [2019-10-22T14:43:34.740Z] [2019-10-22T14:43:34.740Z] == Commencing Configuration:[2019-10-22T14:43:34.740Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2019-10-22T14:43:34.740Z] -- The C compiler identification is GNU 9.2.1[2019-10-22T14:43:35.238Z] -- The CXX compiler identification is GNU 9.2.1[2019-10-22T14:43:35.238Z] -- Check for working C compiler: /usr/bin/cc[2019-10-22T14:43:35.737Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-22T14:43:35.737Z] -- Detecting C compiler ABI info[2019-10-22T14:43:35.737Z] -- Detecting C compiler ABI info - done[2019-10-22T14:43:35.737Z] -- Detecting C compile features[2019-10-22T14:43:35.737Z] -- Detecting C compile features - done[2019-10-22T14:43:35.737Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-22T14:43:35.737Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-22T14:43:35.737Z] -- Detecting CXX compiler ABI 

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 455 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/455/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 14:22:28 +
 Build duration:
9 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 3011 lines...][2019-10-22T14:32:02.446Z] [ 47%] Generating desktopthemesettings.h, desktopthemesettings.cpp[2019-10-22T14:32:02.446Z] [ 47%] Generating desktopthemesettings.moc[2019-10-22T14:32:02.446Z] Scanning dependencies of target kcm_desktoptheme[2019-10-22T14:32:02.446Z] [ 47%] Building CXX object kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/kcm_desktoptheme_autogen/mocs_compilation.cpp.o[2019-10-22T14:32:02.446Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/desktoptheme/kcm_desktoptheme_autogen/EWIEGA46WW/moc_kcm.cpp:9,[2019-10-22T14:32:02.446Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/desktoptheme/kcm_desktoptheme_autogen/mocs_compilation.cpp:2:[2019-10-22T14:32:02.446Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/build/kcms/desktoptheme/kcm_desktoptheme_autogen/EWIEGA46WW/../../../../../kcms/desktoptheme/kcm.h:26:10: fatal error: KQuickAddons/ManagedConfigModule: No such file or directory[2019-10-22T14:32:02.446Z]26 | #include [2019-10-22T14:32:02.446Z]   |  ^~[2019-10-22T14:32:02.446Z] compilation terminated.[2019-10-22T14:32:02.446Z] make[2]: *** [kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/build.make:75: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/kcm_desktoptheme_autogen/mocs_compilation.cpp.o] Error 1[2019-10-22T14:32:02.446Z] make[1]: *** [CMakeFiles/Makefile2:5297: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/all] Error 2[2019-10-22T14:32:02.446Z] make[1]: *** Waiting for unfinished jobs[2019-10-22T14:32:02.446Z] [ 47%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/__/krdb/krdb.cpp.o[2019-10-22T14:32:05.546Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/krdb/krdb.cpp: In function ���void applyGtkStyles(bool, int)���:[2019-10-22T14:32:05.546Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/krdb/krdb.cpp:93:33: warning: unused parameter ���active��� [-Wunused-parameter][2019-10-22T14:32:05.546Z]93 | static void applyGtkStyles(bool active, int version)[2019-10-22T14:32:05.546Z]   |~^~[2019-10-22T14:32:05.546Z] [ 47%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/styleconfdialog.cpp.o[2019-10-22T14:32:07.883Z] [ 47%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/kcmstyle.cpp.o[2019-10-22T14:32:08.381Z] [ 47%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/stylesmodel.cpp.o[2019-10-22T14:32:10.718Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In lambda function:[2019-10-22T14:32:10.719Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:237:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T14:32:10.719Z]   237 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-22T14:32:10.719Z]   |  ^[2019-10-22T14:32:10.719Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T14:32:10.719Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-22T14:32:10.719Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T14:32:10.719Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T14:32:10.719Z]   |^~[2019-10-22T14:32:10.719Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:237:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T14:32:10.719Z]   237 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-22T14:32:10.719Z]   |  ^[2019-10-22T14:32:10.719Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T14:32:10.719Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-22T14:32:10.719Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T14:32:10.719Z]   560 | static 

D24798: Migrate QQC1 to QQC2

[Konrad Materka]

kmaterka added inline comments.

INLINE COMMENTS

> ngraham wrote in configTimeZones.qml:53
> While you're doing some porting, this entire thing can be replaced with a 
> `Kirigami.InlineMessage` which will drastically reduce the amount of code 
> here, and you can also remove the `PlasmaComponents` import (`PlasmaCore` is 
> still needed for units, unless you want to also port things to use 
> `Kirigami.Units` instead)

You can take my changes from D24853 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24798

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: kmaterka, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: [Mouse KCM] Fix acceleration profile on X11

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:829501dd7779: [Mouse KCM] Fix acceleration profile on X11 
(authored by miraiko, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24711?vs=68487=68549

REVISION DETAIL
  https://phabricator.kde.org/D24711

AFFECTED FILES
  kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp

To: miraiko, #plasma, romangg, ngraham
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  There still isn't a border around the inner view. That's what I'm trying to 
get there. Otherwise it doesn't look like an inner view; it looks like a 
floating rectangle.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich added a comment.


  Updated screenshot:
  F7649124: Screenshot_20191022_161043.png 

  
  To be honest, I liked the result more when the "view" wasn't using a 
different background.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 454 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/454/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 22 Oct 2019 13:52:18 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 3011 lines...][2019-10-22T14:07:58.193Z]   |~^~[2019-10-22T14:07:59.852Z] [ 47%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/previewwidget.cpp.o[2019-10-22T14:08:00.900Z] [ 47%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/styleconfdialog.cpp.o[2019-10-22T14:08:01.946Z] [ 47%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/setpreviewwidget.cpp.o[2019-10-22T14:08:02.994Z] [ 47%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/kcmstyle.cpp.o[2019-10-22T14:08:04.652Z] [ 47%] Linking CXX executable ../../../bin/kcolorschemeeditor[2019-10-22T14:08:05.152Z] [ 47%] Built target kcolorschemeeditor[2019-10-22T14:08:06.201Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In lambda function:[2019-10-22T14:08:06.201Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:237:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T14:08:06.201Z]   237 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-22T14:08:06.201Z]   |  ^[2019-10-22T14:08:06.201Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T14:08:06.201Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-22T14:08:06.201Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T14:08:06.201Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T14:08:06.201Z]   |^~[2019-10-22T14:08:06.201Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:237:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T14:08:06.201Z]   237 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-22T14:08:06.201Z]   |  ^[2019-10-22T14:08:06.201Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T14:08:06.201Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-22T14:08:06.201Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T14:08:06.201Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T14:08:06.201Z]   |^~[2019-10-22T14:08:06.700Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In member function ���virtual void KCMStyle::save()���:[2019-10-22T14:08:06.700Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:333:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T14:08:06.700Z]   333 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-22T14:08:06.700Z]   |  ^[2019-10-22T14:08:06.700Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-22T14:08:06.700Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-22T14:08:06.700Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-22T14:08:06.700Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T14:08:06.700Z]   |^~[2019-10-22T14:08:06.700Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:333:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-22T14:08:06.700Z]   333 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-22T14:08:06.700Z]   |

D24853: [DigitalClock] Fix layout and QML warnings

[Konrad Materka]

kmaterka marked 3 inline comments as done.
kmaterka added a comment.


  In D24853#552228 , @ngraham wrote:
  
  > Some of this partially conflicts with D24798 
 FWIW.
  
  
  I can wait and rebase later - your decision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24855: Rename "Close Edit Mode" tooltip to just "Close"

[Nathaniel Graham]

ngraham added a comment.


  > n alternative would be "Finish Customizing Layout" so it matches the menu 
entry.
  
  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24855

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24856: Add a .desktop file to ksplashqml

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ksplashqml.desktop.cmake:3
> +Exec=@CMAKE_INSTALL_PREFIX@/bin/ksplashqml
> +Name=ksplashqml
> +NoDisplay=true

Human readable name please

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24856

To: meven, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

[Nathaniel Graham]

ngraham added a comment.


  Some of this partially conflicts with D24798 
 FWIW.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 166 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/166/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 22 Oct 2019 13:52:19 +
 Build duration:
2 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 3194 lines...][2019-10-22T13:54:07.213Z]  ^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-22T13:54:07.213Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-22T13:54:07.213Z]^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-22T13:54:07.213Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-22T13:54:07.213Z]  ^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:337:60: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-22T13:54:07.213Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-22T13:54:07.213Z]^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-22T13:54:07.213Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-22T13:54:07.213Z]   ^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-22T13:54:07.213Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-22T13:54:07.213Z]^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-22T13:54:07.213Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-22T13:54:07.213Z]  ^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:337:94: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-22T13:54:07.213Z] KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);[2019-10-22T13:54:07.213Z]  ^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-22T13:54:07.213Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-22T13:54:07.213Z]   ^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-22T13:54:07.213Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-22T13:54:07.213Z]^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-22T13:54:07.213Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-22T13:54:07.213Z]  ^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:340:24: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-22T13:54:07.213Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-22T13:54:07.213Z]^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-22T13:54:07.213Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-22T13:54:07.213Z]   ^[2019-10-22T13:54:07.213Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-22T13:54:07.213Z] #  

D24822: Port the desktoptheme kcm to ManagedConfigModule

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:331c25893d06: Port the desktoptheme kcm to 
ManagedConfigModule (authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24822?vs=68409=68547

REVISION DETAIL
  https://phabricator.kde.org/D24822

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h

To: ervin, mart, bport, crossi, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24866: Wired setting: improve handling of link negotiation

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  Adds option to ignore link-negotiation, also uses a combobox, similar to what
  nm-connection-editor is using, to give a choice only with sane values for 
speed.
  
  BUG: 413211

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  ethernet-changes

REVISION DETAIL
  https://phabricator.kde.org/D24866

AFFECTED FILES
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h

To: jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24844: [Applet] Remove hamburger button and menu

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  All right, sounds like this needs to go back to the drawing board. Sorry for 
raising everyone's blood pressure. :)
  
  @manueljlin has some very nice mockups for an improved UI. Perhaps a saner 
approach is to first implement those, and then later, investigate ways to fix 
the issues described here. I do very much want to somehow fix the awkwardness 
and bugginess of having two methods to raise the maximum volume that conflict 
with one another.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24844

To: ngraham, #vdg, #plasma, filipf
Cc: broulik, pkloc, romangg, manueljlin, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  In D24865#552202 , @broulik wrote:
  
  > You might want to split that into a proper if statement otherwise it 
becomes somewhat hard to read. Something like
  >
  >   source: {
  >   if (taskIcon.status === PlasmaCore.Types.NeedsAttentionStatus && 
(AttentionIcon || AttentionIconName)) {
  >   return AttentionIcon || AttentionIconName;
  >   }
  >   return Icon || IconName;
  >   }
  >
  
  
  The problem is that StatusNotifierItemSource always puts empty values for all 
elements. This is needed to initialize all roleNames (for QML delegate model 
etc).  Anyway, it is always at least: "QVariant(QIcon, QIcon(null))". 
  In the situation when IconName was passed and not IconPixmap the check:
  
source: Icon ? Icon : IconName
  
  worked because when there was no IconPixmap (="Icon"), then in 
StatusNotifierItemSource::refreshCallback Icon was loaded from IconName and 
replaced empty "Icon". In other works, this check was not needed in QML.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Kai Uwe Broulik]

broulik added a comment.


  You might want to split that into a proper if statement otherwise it becomes 
somewhat hard to read. Something like
  
source: {
if (taskIcon.status === PlasmaCore.Types.NeedsAttentionStatus && 
(AttentionIcon || AttentionIconName)) {
return AttentionIcon || AttentionIconName;
}
return Icon || IconName;
}

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  I need to add one more check: when AttentionIcon is not set, it should 
fallback to Icon(Name)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks for following up!
  
  (Out of curiosity, do we not need to fall back to the regular icon in case it 
doesn't have an attention icon in needs attention state? Spec only says "can be 
used", doesn't state it's mandatory - can be a separate patch)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Luca Beltrame]

lbeltrame added a comment.


  Tested, works. +1.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka updated this revision to Diff 68543.
kmaterka added a comment.


  Use enum for status check

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24865?vs=68541=68543

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  In D24865#552191 , @broulik wrote:
  
  > `PlasmaCore.IconItem` has a `status` property, so you probably need to 
explicitly check `taskIcon.status` then it should work with the proper enum
  
  
  Oh! Now it looks obvious! I will switch to enum, as I intended, IMO with enum 
it looks cleaner (but longer)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  In D24767#552096 , @broulik wrote:
  
  > Doesn't this break the binding for `source`? My tray icons don't update 
anymore
  
  
  Fix in D24865 , sorry...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24767

To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Kai Uwe Broulik]

broulik added a comment.


  `PlasmaCore.IconItem` has a `status` property, so you probably need to 
explicitly check `taskIcon.status` then it should work with the proper enum

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24865: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Adding support for Attention Icon to StatusNotifier tray icons.
  Binding is working correctly only when "Status" is used, not derived "status".
  
  BUG: 341255

TEST PLAN
  As described in bug report, Konversation can be used for tests.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: kmaterka, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24730: Port KCMSplashScreen to KConfigXT

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:77b27da43cd2: Port KCMSplashScreen to KConfigXT (authored 
by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24730?vs=68532=68534

REVISION DETAIL
  https://phabricator.kde.org/D24730

AFFECTED FILES
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml
  kcms/ksplash/splashscreensettings.kcfg
  kcms/ksplash/splashscreensettings.kcfgc

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, apol, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24731: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fd1f77d5dbff: KCMSplashScreen fix warning, use 
KPackage::Package instead of Plasma::Package (authored by crossi).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24731?vs=68131=68535

REVISION DETAIL
  https://phabricator.kde.org/D24731

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h

To: crossi, #plasma, ervin, mart, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1b857f927037: KCM LookAndFeel : Remove unused 
Q_PROPERTIES, getter const, internal method… (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24819?vs=68416=68536

REVISION DETAIL
  https://phabricator.kde.org/D24819

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24820: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:550a9a25d628: KCM LookAndFeel : fix warnings, use 
KPackage instead of Plasma::Package (authored by crossi).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24820?vs=68406=68537

REVISION DETAIL
  https://phabricator.kde.org/D24820

AFFECTED FILES
  kcms/lookandfeel/autotests/kcmtest.cpp
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24729: remove unnecessary ; + add const to getter + typo in Roles declaration.

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c402ff93c219: remove unnecessary ; + add const to getter 
+ typo in Roles declaration. (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24729?vs=68129=68533

REVISION DETAIL
  https://phabricator.kde.org/D24729

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24730: Port KCMSplashScreen to KConfigXT

[Cyril Rossi]

crossi updated this revision to Diff 68532.
crossi added a comment.


  Use both key and name tag in entry to generate pretty signals' name.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24730?vs=68450=68532

REVISION DETAIL
  https://phabricator.kde.org/D24730

AFFECTED FILES
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml
  kcms/ksplash/splashscreensettings.kcfg
  kcms/ksplash/splashscreensettings.kcfgc

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, apol, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24848: fix kcm fonts "typo" on connect

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.


  In D24848#551863 , @broulik wrote:
  
  > Interesting, I thought Qt would/could static_assert that
  
  
  Well, it turns out the signatures were compatible in fact (getters connected 
to a function which takes no parameter, signatures are fine). But since it is 
done by the C++ compiler, this one has no idea if the second parameter of the 
connect is indeed a signal (this is a completely alien concept to it). This is 
the one blind spot of the new style connects.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24848

To: bport, #plasma, mart, ervin, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  In D24767#552096 , @broulik wrote:
  
  > Doesn't this break the binding for `source`? My tray icons don't update 
anymore
  
  
  Hmm, I will test that. It is possible :/ Definitely there is something wrong 
with PlasmaCore.IconItem.source binding. AttentionIcon was not shown when I did:
  
PlasmaCore.IconItem {
id: iconItem
source: status === PlasmaCore.Types.NeedsAttentionStatus ? 
(AttentionIcon ? AttentionIcon : AttentionIconName) : (Icon ? Icon : IconName)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24767

To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24861: Fix size of SpinBoxes

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: martinkostolny, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  The numbers in the text entry box for "Manual Brightness Step" in the 
Redshift System Tray controller don't fit properly.
  
  BUG: 413218

TEST PLAN
  1. right click on Redshift System Tray icon
  2. Click on "Configure Redshift Control
  
  Observed:
  Numbers in text entry box for "Manual Brightness Step" is cut off
  
  Expected:
  Numbers should be wholly visible.

REPOSITORY
  R885 Redshift Control for Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24861

AFFECTED FILES
  CMakeLists.txt
  package/contents/ui/config/ConfigGeneral.qml

To: kmaterka, martinkostolny, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24767: [SystemTray] Support for AttentionIcon

[Kai Uwe Broulik]

broulik added a comment.


  Doesn't this break the binding for `source`? My tray icons don't update 
anymore

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24767

To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

[Konrad Materka]

kmaterka updated this revision to Diff 68524.
kmaterka marked 3 inline comments as done.
kmaterka added a comment.


  Review changes: Kirigami component, removed anchors

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24853?vs=68512=68524

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24853

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml

To: kmaterka, #plasma, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

[Konrad Materka]

kmaterka marked 3 inline comments as done.
kmaterka added inline comments.

INLINE COMMENTS

> davidedmundson wrote in configTimeZones.qml:32
> Do you need these?
> 
> Generally it's a sign of a problem or bad layering if the root item has 
> anchors in it.

Ops, copy from HolidayConfig.qml. I'll remove it, width/height are not 
needed, I just checked, AppletConfiguration.qml handles that.

> davidedmundson wrote in configTimeZones.qml:56
> If we're going to port stuff, we may as well port to:
> 
> https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1InlineMessage.html
> 
> the library version of this

Cool! I need there must be something!

> davidedmundson wrote in configTimeZones.qml:96
> What's this for? Opacity should be inherited by children

I will use Kirigami component.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

[Méven Car]

meven updated this revision to Diff 68523.
meven added a comment.


  Fix unrelated change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24857?vs=68522=68523

BRANCH
  arcpatch-D24857

REVISION DETAIL
  https://phabricator.kde.org/D24857

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: meven, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

[Méven Car]

meven updated this revision to Diff 68522.
meven added a comment.


  Fix unrelated change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24857?vs=68521=68522

BRANCH
  arcpatch-D24857

REVISION DETAIL
  https://phabricator.kde.org/D24857

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  ksplash/ksplashqml/CMakeLists.txt

To: meven, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

[Méven Car]

meven created this revision.
meven added reviewers: apol, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  To avoid kwin warnings in ~/.local/share/sddm/wayland-session.log such as :
  kwin_core: Could not find the desktop file for 
"/home/meven/kde/usr/bin/krunner"
  kwin_core: Did not grant the interface "org_kde_plasma_window_management" to 
"/home/meven/kde/usr/bin/krunner" . Please request it under 
X-KDE-Wayland-Interfaces

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24857

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  ksplash/ksplashqml/CMakeLists.txt

To: meven, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24856: Add a .desktop file to ksplashqml

[Méven Car]

meven created this revision.
meven added reviewers: apol, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  To prevent warnings in kwin such as :
  kwin_core: Did not grant the interface "org_kde_plasma_window_management" to 
"/home/meven/kde/usr/bin/ksplashqml" . Please request it under 
X-KDE-Wayland-Interfaces

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24856

AFFECTED FILES
  krunner/CMakeLists.txt
  ksplash/ksplashqml/CMakeLists.txt
  ksplash/ksplashqml/ksplashqml.desktop.cmake

To: meven, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24765: Notification applet on the phone

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:739935124269: Notification applet on the phone (authored 
by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24765?vs=68518=68519

REVISION DETAIL
  https://phabricator.kde.org/D24765

AFFECTED FILES
  applets/notifications/package/contents/ui/DraggableDelegate.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/SelectableLabel.qml

To: mart, #plasma, broulik
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24765: Notification applet on the phone

[Marco Martin]

mart updated this revision to Diff 68518.
mart added a comment.


  - remove unused import

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24765?vs=68517=68518

BRANCH
  mart/mobilenotifications

REVISION DETAIL
  https://phabricator.kde.org/D24765

AFFECTED FILES
  applets/notifications/package/contents/ui/DraggableDelegate.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/SelectableLabel.qml

To: mart, #plasma
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24765: Notification applet on the phone

[Marco Martin]

mart updated this revision to Diff 68517.
mart added a comment.


  - always show jobs

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24765?vs=68455=68517

BRANCH
  mart/mobilenotifications

REVISION DETAIL
  https://phabricator.kde.org/D24765

AFFECTED FILES
  applets/notifications/package/contents/ui/DraggableDelegate.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/SelectableLabel.qml
  applets/notifications/package/contents/ui/global/Globals.qml

To: mart, #plasma
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

[David Edmundson]

davidedmundson added a comment.


  Concept +1, I love layouts

INLINE COMMENTS

> configTimeZones.qml:32
>  id: timeZonesPage
> -width: parent.width
> -height: parent.height
> +anchors.left: parent.left
> +anchors.right: parent.right

Do you need these?

Generally it's a sign of a problem or bad layering if the root item has anchors 
in it.

> configTimeZones.qml:56
>  
> +Rectangle {
> +id: messageWidget

If we're going to port stuff, we may as well port to:

https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1InlineMessage.html

the library version of this

> configTimeZones.qml:96
> +source: "dialog-warning"
> +opacity: messageWidget.opacity
>  }

What's this for? Opacity should be inherited by children

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24854: [Desktop Toolbox] Add missing i18n domain

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c79902431d9a: [Desktop Toolbox] Add missing i18n domain 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24854?vs=68513=68515

REVISION DETAIL
  https://phabricator.kde.org/D24854

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24855: Rename "Close Edit Mode" tooltip to just "Close"

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  We don't call it the "edit mode" anywhere else in the UI. An alternative 
would be "Finish Customizing Layout" so it matches the menu entry.

TEST PLAN
  Hover over the desktop toolbox close button.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24855

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24854: [Desktop Toolbox] Add missing i18n domain

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 413227
  FIXED-IN: 5.17.1

TEST PLAN
  My toolbox is now ridiculously long "Werkzeugkasten der Arbeitsfläche"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24854

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

[Konrad Materka]

kmaterka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Fixed issue when time zone configuration page was not scaling corrently. As a 
result two
  srollbars were rendered.
  Fixed few QML layout warnings and undefined references.

TEST PLAN
  Open Time zones configuration page and shrink window - two scrollbars are 
rendered.
  Expected: table is scalled correctly and only one scrollbar in table is 
rendered.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24853

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml

To: kmaterka
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

[Björn Feber]

GB_2 updated this revision to Diff 68510.
GB_2 added a comment.


  Avoid negating entire boolean statements

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24839?vs=68480=68510

BRANCH
  arcpatch-D24839

REVISION DETAIL
  https://phabricator.kde.org/D24839

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24849: [Windows Runner] Gather window again when running result

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:549374ba5f1e: [Windows Runner] Gather window again when 
running result (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24849?vs=68503=68508

REVISION DETAIL
  https://phabricator.kde.org/D24849

AFFECTED FILES
  runners/windows/windowsrunner.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: [Mouse KCM] Fix acceleration profile on X11

[Roman Gilg]

romangg added a comment.


  In D24711#551742 , @romangg wrote:
  
  > @miraiko Do you have an email address that should be used for the commit? 
Name Mirai Komachi, right?
  
  
  ping @miraiko

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixMouseAccelProfile

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg, ngraham
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24849: [Windows Runner] Gather window again when running result

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since we fixed `RunnerManager::teardown` to actually be emitted, the runner 
would throw away its gathered window info and then crash in `run()`.
  I couldn't figure out what the proper API was so this is a workaround to keep 
it from crashing at least.
  However, the runner also didn't check whether the window was actually still 
valid by the time `run()` was called, so querying for the window again once it 
is called and checking validity is a good thing either way imho.
  In the future, this probably should be ported to using libtaskmanager :)
  
  BUG: 412386
  FIXED-IN: 5.17.1

TEST PLAN
  - Can activate windows fine again without crashing

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24849

AFFECTED FILES
  runners/windows/windowsrunner.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich updated this revision to Diff 68502.
jgrulich added a comment.


  - Add Kirigami2 as a dependency

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68501=68502

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

[Jan Grulich]

jgrulich updated this revision to Diff 68501.
jgrulich added a comment.


  - Code improvements

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68382=68501

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24706: [RFC] Change button style

[Noah Davis]

ndavis added a comment.


  Currently, this makes text on light colorschemes that use a light Selection 
Text color difficult to read.
  
  To fix that and keep this look, one of these things will need to happen:
  -Change the colorschemes to use dark Selection Text on light themes. For 
colorschemes intended to be used with a Kvantum theme (Arc, Adapta), this isn't 
such a problem, but it's still less than ideal and it'll be really unpleasant 
for users of those colorschemes.
  
  - Adapt the colors created in the code to combinations of colors in the 
colorscheme. This could get messy and partially turns the colorscheme into a 
problem to solve instead of just a way to define a set of colors.
  - Add More colorscheme colors. We already have a lot of these and we don't 
make good use of all of them.
  - Use existing colorscheme colors in ways that don't reflect their 
names/descriptions. For instance, using Focus for the background of the focus 
effect and hover for the outline or vice versa. This makes it less clear which 
colorscheme colors affect what things.
  
  This is probably not everything, just what I've thought of.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> menu.cpp:146
> +// Only show "Unlock Widgets" in the UI, not "Lock Widgets"
> +if (!(name == QLatin1String("lock widgets") && 
> c->corona()->immutability() == Plasma::Types::Mutable)) {
> +actions << a;

Please avoid negating entire boolean statements.

Instead of `!(foo && bar)` use `!foo || !bar`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D24839

REVISION DETAIL
  https://phabricator.kde.org/D24839

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24846: Port kcm icons to kconfigxt

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> broulik wrote in IconSizePopup.qml:45
> Do you not need to leave this (or a similar) connect in place?

This one is replaced (and that fix bug described above by call onVisibleChange)
and with kconfigxt property handling

> broulik wrote in IconSizePopup.qml:47-53
> I don't like this duplication, especially since sometimes you use 
> `currentIndex` and sometimes the `currentCategory`

I wiil look if I can simplify that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart