D25090: kcm/fonts: Do not load image preview before loading settings

2019-11-03 Thread Bhushan Shah 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0b8ef770d420: kcm/fonts: Do not load image preview before 
loading settings (authored by bshah).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25090?vs=69101=69249

REVISION DETAIL
  https://phabricator.kde.org/D25090

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bshah, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25134: Add KDEClangFormat cmake support

2019-11-03 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This allows devs to run: "make clang-format" and format all files easily
  using the preset KDE clang format style
  
  This patch adds support so devs can easily test the intended formatting
  now, it doesn't change the code yet..
  
  If this patch is accepted I'll treat it as being accepted for all Plasma
  repos. Doing an initial run to commit everything will happen later.

TEST PLAN
  Ran script
  git diff was full of amazingly cleaned code

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25134

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

2019-11-03 Thread Filip Fila 
filipf added a comment.


  In D24720#558099 , @safaalfulaij 
wrote:
  
  > Hi :)
  >  Please tag me in case you need any RTL help.
  >  Yes, headers are aligned based on direction before, which was bad. It's 
almost better to align them to the other side even if they're not translated. 
You never know.
  >  And good that you spotted the issue with QML's Layouts regarding RTL 
:)
  >
  > As a user, I'm happy to see more work being done to refactor the code and 
make it easier! <3
  
  
  Will do, thanks :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg, ngraham, mart
Cc: safaalfulaij, manueljlin, ognarb, ngraham, kmaterka, mart, GB_2, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D24720: [applets/systemtray] Rewrite popups with layouts

2019-11-03 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5b3f5bd9c32e: [applets/systemtray] Rewrite popups with 
layouts (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24720?vs=68485=69217

REVISION DETAIL
  https://phabricator.kde.org/D24720

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf, #plasma, #vdg, ngraham, mart
Cc: safaalfulaij, manueljlin, ognarb, ngraham, kmaterka, mart, GB_2, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D24720: [applets/systemtray] Rewrite popups with layouts

2019-11-03 Thread Safa Alfulaij 
safaalfulaij added a comment.


  Hi :)
  Please tag me in case you need any RTL help.
  Yes, headers are aligned based on direction before, which was bad. It's 
almost better to align them to the other side even if they're not translated. 
You never know.
  And good that you spotted the issue with QML's Layouts regarding RTL 
:)
  
  As a user, I'm happy to see more work being done to refactor the code and 
make it easier! <3

REPOSITORY
  R120 Plasma Workspace

BRANCH
  popup-rewrite (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg, ngraham, mart
Cc: safaalfulaij, manueljlin, ognarb, ngraham, kmaterka, mart, GB_2, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D25124: Make env in plasma-sourceenv.sh call portable

2019-11-03 Thread Steve Wills 
swills updated this revision to Diff 69212.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25124?vs=69203=69212

REVISION DETAIL
  https://phabricator.kde.org/D25124

AFFECTED FILES
  startkde/plasma-sourceenv.sh

To: swills, fvogt, adridg, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

2019-11-03 Thread David Hallas 
hallas added a comment.


  In D25125#558043 , @anthonyfieroni 
wrote:
  
  > Set QT_PLUGIN_PATH to you local path with plugin after that set the system 
path for others
  >  `QT_PLUGIN_PATH=/local/path:/system/path executable`
  
  
  Thanks for the info :) But what executable would load the plugins? Would I 
have to set the `QT_PLUGIN_PATH` globally on my system, and use my installed 
kde to test? Or do we have a command line tool to load these plugins?

INLINE COMMENTS

> anthonyfieroni wrote in ksolidnotify.h:50
> This is public signal, are you sure none use it?

I think ;) As far as I can tell this is an internal class so it's API is not 
exported. I have also done a `git grep` in the plasma-workspace repository for 
any users, but I have found none.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25125

To: hallas, #frameworks, broulik, bruns
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

2019-11-03 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  Set QT_PLUGIN_PATH to you local path with plugin after that set the system 
path for others
  `QT_PLUGIN_PATH=/local/path:/system/path executable`

INLINE COMMENTS

> ksolidnotify.h:50
>  void notify(Solid::ErrorType solidError, const QString& error, const 
> QString& errorDetails, const QString );
> -void blockingAppsReady(const QStringList );
>  void clearNotification(const QString );

This is public signal, are you sure none use it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25125

To: hallas, #frameworks, broulik, bruns
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

2019-11-03 Thread David Hallas 
hallas added a comment.


  Note that I haven't tested this patch locally because I don't know how to 
"run" the locally compiled devicenotifier. I can see that I get a 
`plasma_engine_devicenotifications.so` library from building the project, but I 
don't know how to "run" it, do we have a cli tool to load the shared library 
for testing? Or how do you guys test?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25125

To: hallas, #frameworks, broulik, bruns
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

2019-11-03 Thread David Hallas 
hallas created this revision.
hallas added reviewers: Frameworks, broulik, bruns.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Use the KListOpenFilesJob class from KCoreAddons to retrieve the
  applications that are blocking an unmount. The KListOpenFilesJob is a
  generalized version of the code here.

TEST PLAN
  Insert a USB stick
  Open a file from the USB stick
  Remove the USB stick using the Device Notifier
  Notice the error message

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use_klistopenfilesjob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25125

AFFECTED FILES
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/devicenotifications/ksolidnotify.h

To: hallas, #frameworks, broulik, bruns
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 42 - Still unstable!

2019-11-03 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/42/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 03 Nov 2019 07:54:04 +
 Build duration:
6 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2583)14%
(212/1503)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/258)0%
(0/136)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still unstable!

2019-11-03 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/18/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 03 Nov 2019 07:54:04 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest