D25185: Icon: solve threading issue on when the source is http

bcooksley added a comment. As a reminder, please ensure that all QNetworkAccessManager code is built to force handling of redirects on - code that interacts with KDE.org and does not explicitly handle redirects is not supported by Sysadmin. REPOSITORY R169 Kirigami REVISION DETAIL

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69372. apol added a comment. deadlock REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69371=69372 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25185 AFFECTED FILES src/icon.cpp src/icon.h

D25185: Icon: solve threading issue on when the source is http

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY For starters, QQmlEngine::networkAccessManager is not reentrant and would give us a warning

D25180: [GTK3/Firefox] Fix scrollbar click region

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works perfectly. Definitely 5.17.x material, especially since the bug we're fixing was a regression in 5.17. REPOSITORY R98 Breeze for Gtk BRANCH scrollbar-click-region

D25180: [GTK3/Firefox] Fix scrollbar click region

cblack created this revision. cblack added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Scrollbars now have a click region equivalent to their visual space. FIXED-IN: 5.?? (Is

D25179: Don't move the drawer collapse button if there's no icon or image

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise it moves but the content doesn't extend because there's no images and it looks off.

D25174: Fix binding loop on toobig

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1f7d5ff90879: Fix binding loop on toobig (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25174?vs=69350=69361 REVISION DETAIL

D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This removes the icon collapse behaviour of ToolBarPageHeader in favour of the

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This changes the layouting code in ActionToolBar to support reducing actions to

D25176: Add a displayHint property to Action

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This property can be used to indicate preferences on how to display the action to

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge updated this revision to Diff 69357. jjorge marked 6 inline comments as done. jjorge added a comment. - hopefully correct all problems found in nice ahiemstra's revision - - indentation corrected to 4 chars - - function braces in newline - - We can calculate charge even if current

D25175: FormLayout: Fix label height if wide mode is false

This revision was automatically updated to reflect the committed changes. Closed by commit R169:839983aa3604: FormLayout: Fix label height if wide mode is false (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25175?vs=69355=69356

D25175: FormLayout: Fix label height if wide mode is false

jbbgameich updated this revision to Diff 69355. jbbgameich edited the test plan for this revision. jbbgameich added a comment. Use implicit height instead of font metrics REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25175?vs=69353=69355 BRANCH

D25175: FormLayout: Fix label height if wide mode is false

jbbgameich added inline comments. INLINE COMMENTS > mart wrote in FormLayout.qml:277 > fontmetrics is the default font height, and this being an heading may be more > (when is heading) > does it work if instead you do here > return implicitHeight ? It works but produces a slightly smaller

D25175: FormLayout: Fix label height if wide mode is false

mart added inline comments. INLINE COMMENTS > FormLayout.qml:277 > +} else { > +return Kirigami.Units.fontMetrics.height > +} fontmetrics is the default font height, and this being an heading may be more (when is heading) does it

D25109: Make it impossible to open the progress view sheet multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit R134:762a36fcd96b: Make it impossible to open the progress view sheet multiple times (authored by jbbgameich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D15702: User can define margins for the desktop

mvourlakos added a comment. this is not needed any more... https://phabricator.kde.org/R120:328817b582fa is going to help to add transparent plasma panels below Latte docks/panels REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15702 To: mvourlakos, #plasma,

D25175: FormLayout: Fix label height if wide mode is false

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY previously the height of the label was based on the content's height. However this doesn't work in non wide mode. With

D25121: update panel shadows when background hints are changed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:328817b582fa: update panel shadows when background hints are changed (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25174: Fix binding loop on toobig

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise the buttons would not be shown in some cases TEST PLAN Now I can update with

KDE CI: Plasma » kgamma5 » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 06 Nov 2019 13:47:33 + Build duration: 20 min and counting

KDE CI: Plasma » kgamma5 » kf5-qt5 SUSEQt5.12 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 06 Nov 2019 13:47:33 + Build duration: 4 min 47 sec and counting JUnit Tests Name: (root) Failed: 0

D25172: Fix overloaded signal

This revision was automatically updated to reflect the committed changes. Closed by commit R100:80beb01fab3f: Fix overloaded signal (authored by davidedmundson). REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25172?vs=69344=69346 REVISION DETAIL

D25172: Fix overloaded signal

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Compiled locally due to QT_DEPRECATED_SINCE, won't on CI TEST PLAN Still

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.12 - Build # 125 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.12/125/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 11:06:05 + Build duration: 3 hr 4 min and counting JUnit Tests Name: (root)

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 474 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/474/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 31 Oct 2019 02:25:12 + Build duration: 4 min 35 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 206 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/206/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 31 Oct 2019 09:17:01 + Build duration: 25 min and counting JUnit Tests Name:

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra added a comment. You are right, sorry. I was confusing /sys with /proc, which does have a lot of "put all of this information in a single file" stuff going on. It would still be nice if there was a better way of getting this information, but that is not related to this change. So

D25157: [Slideshow] Reenable other modes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d0df800b46f9: [Slideshow] Reenable other modes (authored by davidre). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25157?vs=69309=69335 REVISION DETAIL

D25086: [WIP] Port to KGlobalAccel

davidre added a comment. In D25086#559109 , @mlaurent wrote: > For me it seems ok > > Did you finish it ? is it work ? or still in progress ? Shortcut setting and displaying works so far in my testing. I still need to do the

D25086: [WIP] Port to KGlobalAccel

mlaurent added a comment. For me it seems ok Did you finish it ? is it work ? or still in progress ? REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent Cc: apol, mlaurent, plasma-devel, LeGast00n,