D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement

broulik updated this revision to Diff 69622. broulik added a comment. - Add missing `play()` call REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24870?vs=69545=69622 REVISION DETAIL https://phabricator.kde.org/D24870 AFFECTED FILES

Re: KScreen/libkscreen commit message policies

On Mon, Nov 11, 2019 at 10:58 PM Luigi Toscano wrote: > > Roman Gilg ha scritto: > > Hi, > > > > I just pushed commit message policies to KScreen [1] and libkscreen > > [2] (linked below from GitHub so they can be read with Markdown > > formatted). > > > > I intend to revert in the future all

D25027: feat(kcm): zoom preview automatically

davidedmundson commandeered this revision. davidedmundson added a reviewer: romangg. davidedmundson added a comment. Edit, it was done. Just not reuploaded and approved in the correct order. Try to do that. commandeering just to close REPOSITORY R104 KScreen REVISION DETAIL

Re: KScreen/libkscreen commit message policies

El dilluns, 11 de novembre de 2019, a les 23:25:34 CET, Albert Astals Cid va escriure: > El dilluns, 11 de novembre de 2019, a les 22:41:18 CET, Roman Gilg va > escriure: > > Hi, > > > > I just pushed commit message policies to KScreen [1] and libkscreen > > [2] (linked below from GitHub so

D25027: feat(kcm): zoom preview automatically

davidedmundson reopened this revision. davidedmundson added a comment. You missed a review comment. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25027 To: romangg, #plasma Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

Re: KScreen/libkscreen commit message policies

El dilluns, 11 de novembre de 2019, a les 22:41:18 CET, Roman Gilg va escriure: > Hi, > > I just pushed commit message policies to KScreen [1] and libkscreen > [2] (linked below from GitHub so they can be read with Markdown > formatted). That's not how it works, you can't override the manifesto

D24068: docs: add contributing guide

davidedmundson added a comment. > Since there is no other one at the moment I don't see the need to ask again You could at least follow up the replies. It was even met with a positive response, with some effort this could easily become a thing. It's a completely different story to

Re: KScreen/libkscreen commit message policies

Roman Gilg ha scritto: > Hi, > > I just pushed commit message policies to KScreen [1] and libkscreen > [2] (linked below from GitHub so they can be read with Markdown > formatted). > > I intend to revert in the future all manual commits to KScreen and > libkscreen deliberately ignoring the

KScreen/libkscreen commit message policies

Hi, I just pushed commit message policies to KScreen [1] and libkscreen [2] (linked below from GitHub so they can be read with Markdown formatted). I intend to revert in the future all manual commits to KScreen and libkscreen deliberately ignoring the policies. Here "manual" means here that I

D25027: feat(kcm): zoom preview automatically

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. romangg marked 3 inline comments as done. Closed by commit R104:643e32c2bd2f: feat(kcm): zoom preview automatically (authored by romangg).

D25026: feat(kcm): always use 0.25 slider scale steps

This revision was automatically updated to reflect the committed changes. Closed by commit R104:fb170c3aa80e: feat(kcm): always use 0.25 slider scale steps (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25026?vs=68932=69611 REVISION

D25062: fix(kded): read rotated output size

This revision was automatically updated to reflect the committed changes. Closed by commit R104:0cf25b853ae3: fix(kded): read rotated output size (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25062?vs=69016=69610 REVISION DETAIL

D25021: fix: use output hashMd5 for control files

This revision was automatically updated to reflect the committed changes. Closed by commit R104:0f685b76633e: fix: use output hashMd5 for control files (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25021?vs=68923=69609#toc REPOSITORY R104 KScreen CHANGES SINCE

D25020: fix: create control files only when needed

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:7de6c0c36d55: fix: create control files only when needed (authored by romangg). REPOSITORY R104 KScreen CHANGES

D25064: docs: add contributing guide

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:4e176e1d5e07: docs: add contributing guide (authored by romangg). CHANGED PRIOR TO COMMIT

D24068: docs: add contributing guide

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:50cf930ec824: docs: add contributing guide (authored by romangg). CHANGED PRIOR TO COMMIT

D25263: [ComboBox] Don't dim Popup

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good riddance IMO. :) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25263 To: broulik, #plasma, mart, ngraham Cc: ngraham,

D25018: Move ACPI battery information from /proc/acpi to /sys

alexde added a comment. In D25018#561268 , @jjorge wrote: > > Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? > > Yes : this is a percentage. States out of this value are bad

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge marked an inline comment as done. jjorge added a comment. > Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? Yes : this is a percentage. States out of this value are bad hardware : I have a travel battery which shows

D25264: [Cursor Theme KCM] Elide size ComboBox text

broulik created this revision. broulik added reviewers: Plasma, IlyaBizyaev. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Vanilla `ItemDelegate` elides but this one has custom `contentItem` to add the

D25263: [ComboBox] Don't dim Popup

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The dimming only works with pure QML applications based on `ApplicationWindow` which is why

D25018: Move ACPI battery information from /proc/acpi to /sys

alexde added inline comments. INLINE COMMENTS > acpi.c:129 > +} else if (state < 0) { > +state = 0; /* prevent insane numbers with bad hardware */ > } Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? > acpi.c:161

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. Thanks. Just some thoughts : designcharge is usefull if you want to see the percentage of charge you reach against what it should be with a new battery. For some adicional sensors, of course, even if I dont see what ones you are thinking about. REPOSITORY R106

D25252: Fix binding loop in lockscreen media controls

This revision was automatically updated to reflect the committed changes. Closed by commit R120:419b9708ee9e: Fix binding loop in lockscreen media controls (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9098606194e1: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25178?vs=69360=69591#toc

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

This revision was automatically updated to reflect the committed changes. Closed by commit R169:b60dd839ee0b: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25177?vs=69588=69590#toc

D25176: Add a displayHint property to Action

This revision was automatically updated to reflect the committed changes. ahiemstra marked an inline comment as done. Closed by commit R169:2fe7e4598871: Add a displayHint property to Action (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

ahiemstra updated this revision to Diff 69588. ahiemstra added a comment. - Also add to kirigami.qrc.in REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25177?vs=69580=69588 BRANCH actiontoolbar_icononly REVISION DETAIL

D25261: [sddm-theme] Fix initial focus after SDDM QQC2 Port

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY QQC2 StackView has a major behavioural difference

D25252: Fix binding loop in lockscreen media controls

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Clever! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25252 To: davidedmundson, #plasma, broulik Cc: broulik, filipf, plasma-devel,

D25222: [Lock Screen] Fix album art binding loop

filipf abandoned this revision. filipf added a comment. continued in D25252 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25222 To: filipf, davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n,

D25252: Fix binding loop in lockscreen media controls

filipf added a comment. I'm not seeing any binding loop warnings when testing this fwiw. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25252 To: davidedmundson, #plasma Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kirigami.qrc:34 > alias="private/EdgeShadow.qml">src/controls/private/EdgeShadow.qml > +

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/8/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 11 Nov 2019 13:20:57 + Build duration: 3 min 55 sec and counting CONSOLE

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 26 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/26/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 11 Nov 2019 13:20:58 + Build duration: 1 min 54 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/25/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 11 Nov 2019 13:11:59 + Build duration: 3 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/7/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 11 Nov 2019 13:12:00 + Build duration: 2 min 28 sec and counting CONSOLE

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

ahiemstra updated this revision to Diff 69580. ahiemstra marked an inline comment as done. ahiemstra added a comment. - Add ActionToolBarLayoutDetails.qml to qrc file REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25177?vs=69463=69580 BRANCH

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

mart added inline comments. INLINE COMMENTS > ActionToolBarLayoutDetails.qml:1 > +/* > + * Copyright 2018 Marco Martin please add this file to kirigami.qrc and kirigami.qrc.in REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25177 To: ahiemstra, #kirigami Cc:

KDE CI: Plasma » plasma-sdk » kf5-qt5 SUSEQt5.12 - Build # 86 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-sdk/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Nov 2019 11:50:21 + Build duration: 2 min 7 sec and counting JUnit Tests Name: (root)

D25086: Port to KGlobalAccel

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. for me all is ok. REPOSITORY R103 KMenu Editor BRANCH globalaccel (branched from master) REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma,

Monday meeting notes for 11/11/2019

Kai Uwe Notifications: * Worked on showing a hint in notification settings and plasmoid when notifications aren't done by Plasma * I've seen people complain that their notifications were ugly when in fact they were running "Dunst" instead of Plasma notifications plasma-browser-integration: *

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. So, with this my system lists battery in ksysguard again, which is really nice. I do wonder about the usefulness of the "DesignCharge" sensor and would maybe like to see some

D25086: Port to KGlobalAccel

davidre updated this revision to Diff 69577. davidre marked 2 inline comments as done. davidre added a comment. QLatin1String REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69483=69577 BRANCH globalaccel (branched from master) REVISION

D25252: Fix binding loop in lockscreen media controls

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY When we load and position the Image the height is constrained, the width