KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 277 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/277/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 04:37:10 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/69/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 02:29:35 +
 Build duration:
1 min 47 sec and counting

D25476: [GTK3] Fix invalid colour name in treeview

[Carson Black]

cblack created this revision.
cblack added reviewers: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Treeview used an invalid colour: `@theme_base_fg_color` instead of 
`@theme_fg_color`.
  BUG: 414391
  FIXED-IN: 5.17.4

TEST PLAN
  See that 414391 is fixed.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  fix-treeview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25476

AFFECTED FILES
  src/gtk3/widgets/_treeview.scss

To: cblack, #breeze, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Yunhe Guo]

guoyunhe added a comment.


  I didn't find good solutions for QQC2. It has been a blocker for a long time 
https://bugs.kde.org/show_bug.cgi?id=403153

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Kai Uwe Broulik]

broulik added a comment.


  How about we fix the size or the combo instead?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25466: Add Captive Portal auto-refresh handling

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, bcooksley, fvogt, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When configured to detect captive portals, NetworkManager prompts the user to 
log in by opening http://networkcheck.kde.org
  A captive portal will redirect the user and once logged in, redirect 
somewhere else or back to networkcheck.
  Currently, it doesn't automatically detect the fact that the user is now 
logged in and only notices after like 10 minutes.
  With this patch, when a new tab is opened pointing to KDE networkcheck, 
whenever the tab completes a navigation, (after a short delay) NetworkManager 
is asked to re-check network connectivity to update network connectivity 
basically immediately once connected.
  When user is then redirected back to KDE networkcheck, which just returns 
"OK\n", the tab is closed to not leave the user sitting at this empty OK page.

TEST PLAN
  - Setup my NM to use networkcheck.kde.org, connected to a wifi with captive 
portal, clicked "Log in" on the "you need to login" prompt, my browser opened, 
I agreed to terms, hit "Connect", got redirected to some welcome page
  - With this patch the exclamation mark on the icon goes away almost 
immediately after connecting
  - Previously it would stay there pretty much forever

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D25466

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/constants.js
  extension/extension-captiveportal.js
  extension/manifest.json
  extension/options.html
  host/CMakeLists.txt
  host/captiveportalplugin.cpp
  host/captiveportalplugin.h
  host/main.cpp

To: broulik, #plasma, bcooksley, fvogt, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Yunhe Guo]

guoyunhe added a comment.


  In D25381#566128 , @ndavis wrote:
  
  > `oxygen-demo5`
  
  
  Thanks for the tip!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma, ngraham, ndavis
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[Nathaniel Graham]

ngraham added a comment.


  Personally I don't see this setting as a super niche thing. The bug report 
has four duplicates, so there is clearly quite a bit of demand from users. On 
macOS, this is literally the first thing I change on a new install, and it's 
displayed very prominently in the "General" page of their System Settings app.
  
  I share you concern about this KCM becoming a dumping ground. But I don't see 
a better place for this setting right now. And I think it does make some sense 
for it to hold general behavioral settings that affect both apps and Plasma.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

To: ngraham, #plasma, #vdg, ndavis
Cc: davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25459: fix(kcm): improve i18n of device combobox

[Roman Gilg]

romangg added subscribers: broulik, romangg.
romangg added a comment.


  Thanks for the patch. @broulik: since you changed it last iirc is this good 
to go? Since it's a string change only master?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25459

To: guoyunhe, kde-i18n-doc, #plasma, #localization
Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[David Edmundson]

davidedmundson added a comment.


  My primary concern is that it's a really super niche tweak thing. It's valid 
but certainly as niche as whether you show the up/down arrows or whatever, yet 
we're presenting it on the very first level of "Workspace Behaviour".
  
  I also fear workspace behaviour becoming a dumping ground. Literally 
everything in systemsettings falls under that umbrella". There's definitely a 
need for careful thinking.
  
  In terms of addressing the initial points. Whether something is QWidgets or 
QtQuick or GTK (via QtQucickControls) is not a reason to show something 
different as we have goals to sync them.
  It being form vs function and the function affecting the plasma theme is a 
valid argument.
  
  Would be good for some others to chime in.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

To: ngraham, #plasma, #vdg, ndavis
Cc: davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25462: [Colors KCM] Use Kirigami.SearchField

[Alexander Potashev]

aspotashev added a comment.


  In D25462#566157 , @ngraham wrote:
  
  > In the worst-case scenario, you can override `placeholderText` here and 
provide a translated string.
  
  
  Ah, right. Thanks for the reminder!
  
  How about including the workaround in this patch?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25462

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25462: [Colors KCM] Use Kirigami.SearchField

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D25462#566149 , @aspotashev 
wrote:
  
  > The translation part of SearchField is indeed buggy: 
https://bugs.kde.org/show_bug.cgi?id=413900
  >
  > May be it's not time to adopt it yet?
  
  
  IMO, more like time to fix that bug. :) In the worst-case scenario, you can 
override `placeholderText` here and provide a translated string.
  
  However there is a deeper problem: now that System Settings uses a 
`SearchField` in its own toolbar, the Ctrl+F shortcut to trigger it becomes 
ambiguous. I guess we need to fix that too. However I see that this is already 
the case even without this patch, so there's no regression here at least.
  
  Therefore, +1.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25462

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25462: [Colors KCM] Use Kirigami.SearchField

[Alexander Potashev]

aspotashev added a comment.


  The translation part of SearchField is indeed buggy: 
https://bugs.kde.org/show_bug.cgi?id=413900
  
  May be it's not time to adopt it yet?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25462

To: broulik, #plasma, #vdg
Cc: aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25462: [Colors KCM] Use Kirigami.SearchField

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Gets rid of some code duplication.

TEST PLAN
  - Filtering works
  - Clear button works
  
  For some reason it's not translated

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25462

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Noah Davis]

ndavis added a comment.


  In D25381#566100 , @guoyunhe wrote:
  
  > Yes, this patch needs minimization. What is the software in your 
screenshot? @ndavis
  
  
  `oxygen-demo5`

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma, ngraham, ndavis
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25406: [ToolTip] Base timeout on text length

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:5ca508bd6adc: [ToolTip] Base timeout on text length 
(authored by broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25406?vs=70002&id=70155

REVISION DETAIL
  https://phabricator.kde.org/D25406

AFFECTED FILES
  org.kde.desktop/ToolTip.qml

To: broulik, #plasma, ngraham, #vdg, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Yunhe Guo]

guoyunhe added a comment.


  Yes, this patch needs minimization. What is the software in your screenshot? 
@ndavis

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma, ngraham, ndavis
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25439: Don't CacheUser/UnCacheUser when editing Realname

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:a2f7d308f9b5: Don't CacheUser/UnCacheUser when 
editing Realname (authored by meven).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25439?vs=70108&id=70153

REVISION DETAIL
  https://phabricator.kde.org/D25439

AFFECTED FILES
  src/lib/accountmodel.cpp

To: meven, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25459: Device ComboBox: fix label and layout

[Yunhe Guo]

guoyunhe updated this revision to Diff 70151.
guoyunhe added a comment.


  update commit message

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25459?vs=70149&id=70151

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25459

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml

To: guoyunhe, kde-i18n-doc, #plasma, #localization
Cc: ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25459: Device ComboBox: fix label and layout

[Luigi Toscano]

ltoscano added a comment.


  Before anything else you need to change the commit message (yes, just here, 
because reasons):
  https://marc.info/?l=kde-devel&m=157350852208190&w=2

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25459

To: guoyunhe, kde-i18n-doc, #plasma, #localization
Cc: ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25459: Device ComboBox: fix label and layout

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  The original label cause i18n problems, the parameter %1 is never given. The 
layout doesn't fit the form. This patch uses Kirigami label and form layout. 
And fix the i18n message.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25459

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml

To: guoyunhe
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart