D25863: Remove traces of old GTK configs

2019-12-10 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > appearancegtk2.cpp:146 > { > -m_settings = QMap { > -{"toolbar_style", "GTK_TOOLBAR_ICONS"}, > -{"show_icons_buttons", "0"}, > -{"show_icons_menus", "0"}, > -{"primary_button_warps_slider", "false"} > -}; > +

D25863: Remove traces of old GTK configs

2019-12-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R99:338ce2466e4a: Remove traces of old GTK configs (authored by gikari, committed by ngraham). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25863?vs=

D25580: [System Tray] Unified data model for System Tray items

2019-12-10 Thread Konrad Materka
kmaterka updated this revision to Diff 71232. kmaterka added a comment. Review fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=71231&id=71232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25580 AFFECTED FILES apple

D25580: [System Tray] Unified data model for System Tray items

2019-12-10 Thread Konrad Materka
kmaterka updated this revision to Diff 71231. kmaterka marked 5 inline comments as done. kmaterka added a comment. Review fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=70464&id=71231 BRANCH master REVISION DETAIL https://phabric

D25580: [System Tray] Unified data model for System Tray items

2019-12-10 Thread Konrad Materka
kmaterka marked 5 inline comments as done. kmaterka added inline comments. INLINE COMMENTS > nicolasfella wrote in ConfigEntries.qml:68 > You can try doing > > for (item of systemTrayModel) { > ] > > But I don't know if that will work Unfortunately model is not iterable. This code will be

D25860: [plasmoid] Show device battery percentage

2019-12-10 Thread Aleix Pol Gonzalez
apol added a comment. +1 cool! Really missed it. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D25860 To: broulik, #plasma, #vdg, drosca Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himces

D25861: [Notifications] Fix crash accessing ViewTransition attached property

2019-12-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:34ca49210ff4: [Notifications] Fix crash accessing ViewTransition attached property (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25

D25861: [Notifications] Fix crash accessing ViewTransition attached property

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. No more crashes so far. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25861 To: broulik, #plasma, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, a

D25863: Remove traces of old GTK configs

2019-12-10 Thread Mikhail Zolotukhin
gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since slider behavior is controlled by kded daemon, gtk kcm has no control over it now. It appears, that some traces of the warp

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-10 Thread Matej Mrenica
mthw updated this revision to Diff 71222. mthw added a comment. Tried to implement your suggestion, hopefully correctly, works correctly so far. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=71175&id=71222 BRANCH master REVISION DETA

D25861: [Notifications] Fix crash accessing ViewTransition attached property

2019-12-10 Thread Kai Uwe Broulik
broulik updated this revision to Diff 71219. broulik added a comment. - remove leftover debugging REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25861?vs=71217&id=71219 REVISION DETAIL https://phabricator.kde.org/D25861 AFFECTED FILES applets

D25861: [Notifications] Fix crash accessing ViewTransition attached property

2019-12-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's something really funky going on in this... Avoid using `ViewTransition` attached

D25860: [plasmoid] Show device battery percentage

2019-12-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY While it is typically shown in Battery Monitor, it can still be useful to have it in

D25851: [Notifications] Add quick reply feature

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. All right, let's stay with a single line for now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25851 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBo

D25851: [Notifications] Add quick reply feature

2019-12-10 Thread Kai Uwe Broulik
broulik added a comment. I'm not sure. `TextArea` is a lot more annoying to work with, and the replies typically are short. I think Android also only has single line. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25851 To: broulik, #plasma, #vdg Cc: ngrah

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-10 Thread Kai Uwe Broulik
broulik added a comment. You can just do something like var parts = []; if (powerManagementDisabled) { parts.push(i18n("Powermanagement disabled")); } if (pmSource.data["AC Adapter"] && pmSource.data["AC Adapter"]["Plugged in"]) { parts.push(blabla); } el

D25846: [Cuttlefish] Use the same actions in all menus

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. Nice, a very good refactor. INLINE COMMENTS > Menu.qml:24 > > -import QtQuick 2.5 > -import Qt.labs.platform 1.0 > +import QtQuick 2.3 > +import QtQuick.Controls 2.5 as QQC2 unrelated > Menu.qml:47 > +property Component submenuComponent: actionsMenu >

D25851: [Notifications] Add quick reply feature

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. Beautiful! Can we make it handle multi-line text input by becoming taller? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25851 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouka

D25851: [Notifications] Add quick reply feature

2019-12-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a quick reply feature with a text field inline in the notification popup. An acti

D25428: Improved support for desktop "Folder View"

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. Does `grabChanged` work? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: mart, ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragree

D25428: Improved support for desktop "Folder View"

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. In D25428#574844 , @steffenh wrote: > and second we need to change QtQuick from 2.8 to 2.12. That's fine. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plas

D25428: Improved support for desktop "Folder View"

2019-12-10 Thread Steffen Hartleib
steffenh added a comment. Ok a quick look at TapHandler, first I am missing a positionChanged signal in the TapHandler and second we need to change QtQuick from 2.8 to 2.12. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ng

D25844: Don't compress tasks before grouping, when task manager is vertical.

2019-12-10 Thread George Vogiatzis
gvgeo updated this revision to Diff 71191. gvgeo retitled this revision from "Add grouping options in Icons-only Task Manager" to "Don't compress tasks before grouping, when task manager is vertical.". gvgeo edited the summary of this revision. gvgeo added a comment. In D25844#574741

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

2019-12-10 Thread Kevin Ottens
ervin added a comment. In D25843#574736 , @davidedmundson wrote: > It's true that's the only user of it right now, so this is technically correct. > > I don't think it's a problem for us to emit changes for the other things. KConfigWatcher

D25846: [Cuttlefish] Use the same actions in all menus

2019-12-10 Thread David Redondo
davidre created this revision. davidre added reviewers: Plasma, ngraham, cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Defines the actions in one place and uses them for the context menus and buttons

D25841: [Cuttlefish] Set context properties before loading file

2019-12-10 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R118:e56bc283019f: [Cuttlefish] Set context properties before loading file (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25841?vs=71180&id=711

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. In D25844#574762 , @davidedmundson wrote: > To give history > > We had a UX in Plasma 4 where choosing between an analog and digital clock would be an option in the main clock applet, but choosing the binary clock w

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread David Edmundson
davidedmundson added a comment. > I'm not sure of the history behind why this split is presented in the form of two different applets To give history We had a UX in Plasma 4 where choosing between an analog and digital clock would be an option in the main clock applet, but choosing

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. FWIW the bug this fixes (https://bugs.kde.org/show_bug.cgi?id=368430) is starting to accumulate duplicates. There seems to be some user demand for this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, he

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. @gvgeo since we already have a patch that disables grouping, maybe you could use this one to implement only the change to the compressing animation? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25844 To: gvgeo, #plasma, #vdg Cc: GB

D25740: Add item spacing to size hint

2019-12-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R31:74285aea999c: Add item spacing to size hint (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25740?vs=70903&id=71189 REVISION DETAIL https://ph

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread Björn Feber
GB_2 added a comment. I already made a patch for this: D23242 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25844 To: gvgeo, #plasma, #vdg Cc: GB_2, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. In D25844#574728 , @gvgeo wrote: > In D25844#574714 , @broulik wrote: > > > So you want to be able to not group apps in IOTM, that is literally what IOTM is about, isnt it?

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

2019-12-10 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It's true that's the only user of it right now, so this is technically correct. I don't think it's a problem for us to emit changes for the other things. KConfigWatcher

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread George Vogiatzis
gvgeo added inline comments. INLINE COMMENTS > layout.js:88 > +// Fit more tasks in this case, that is possible to cut text, > before combining tasks. > +return Math.ceil(length / maximum) * maxStripes() + 1; > +} This has an effect mostly for small displays. On bigger disp

D25845: UpdatesPage: Fix references to \x9C in comments

2019-12-10 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes. Closed by commit R134:d25579fe4236: UpdatesPage: Fix references to \x9C in comments (authored by aspotashev). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25845?vs=7118

D25845: UpdatesPage: Fix references to \x9C in comments

2019-12-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R134 Discover Software Store BRANCH 9c REVISION DETAIL https://phabricator.kde.org/D25845 To: aspotashev, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Fere

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread George Vogiatzis
gvgeo added a comment. In D25844#574714 , @broulik wrote: > So you want to be able to not group apps in IOTM, that is literally what IOTM is about, isnt it? I don't know what the reasoning between splitting the task managers is. But fro

D25845: UpdatesPage: Fix references to \x9C in comments

2019-12-10 Thread Alexander Potashev
aspotashev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R134 Discover Software Store BRANCH 9c REVISION DETAIL https://phabricator.kde.org/D25845 AFFECTED FILES

D25840: [Icons KCM] Use help-browser icon

2019-12-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:0381ed06a07a: [Icons KCM] Use help-browser icon (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25840?vs=71177&id=71186 REVISION DETAI

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread Kai Uwe Broulik
broulik added a comment. So you want to be able to not group apps in IOTM, that is literally what IOTM is about, isnt it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25844 To: gvgeo, #plasma, #vdg Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jr

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread George Vogiatzis
gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. gvgeo added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Expose grouping options from 'Task Manager' to 'Icons-only Task Manager'. Also disable the behavior

D25842: [Cuttlefish] Replace deprectated method KDeclarative::setupBindings()

2019-12-10 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R118:43c4d215bd5e: [Cuttlefish] Replace deprectated method KDeclarative::setupBindings() (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25842?v

D25792: Add notifiers to workspace options kcfg

2019-12-10 Thread Cyril Rossi
crossi added a comment. Thanks @davidedmundson for spotting this regression. Actually, only AnimationDurationFactor should notify. From D25586 See kcms/workspaceoptions/workspaceoptions.cpp line 221. REPOSITORY R119 Plasma Desktop REVISION

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

2019-12-10 Thread Cyril Rossi
crossi created this revision. crossi added reviewers: Plasma, ervin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Following D25792 and D25586

D25842: [Cuttlefish] Replace deprectated method KDeclarative::setupBindings()

2019-12-10 Thread David Redondo
davidre created this revision. davidre added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Replace method call like described in the documentation. Also we don't need to cast &engine beca

D25841: [Cuttlefish] Set context properties before loading file

2019-12-10 Thread David Redondo
davidre updated this revision to Diff 71180. davidre added a comment. codestyle++ REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25841?vs=71179&id=71180 BRANCH contextprops (branched from master) REVISION DETAIL https://phabricator.kde.org/D25841

D25841: [Cuttlefish] Set context properties before loading file

2019-12-10 Thread David Redondo
davidre created this revision. davidre added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise we load the file and the context properties are still undefined leading to a buch Refe

D25838: [Applets/Kickoff] Show apps by their real names on top by default

2019-12-10 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I agree with this. REPOSITORY R119 Plasma Desktop BRANCH show-apps-by-name (branched from master) REVISION DETAIL https://phabricator.kde.org/D25838 To: ngraham, #vdg, #plasma, ndav

D25428: Improved support for desktop "Folder View"

2019-12-10 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > FolderItemDelegate.qml:213 > + > +MouseArea { > +id: mousearea How much of this can be done with pointer handlers? https://doc.qt.io/qt-5/qml-qtquick-taphandler.html quickly looking at this mousearea it seems that

D25840: [Icons KCM] Use help-browser icon

2019-12-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `system-help` appears to be an action icon and not available in larger size in Adwaita, add `

D25837: [Style KCM] Fit widget style preview better

2019-12-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4b444eb2031a: [Style KCM] Fit widget style preview better (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25837?vs=71170&id=71176 REVI

D25837: [Style KCM] Fit widget style preview better

2019-12-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25837 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jr

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-10 Thread Matej Mrenica
mthw updated this revision to Diff 71175. mthw added a comment. The second line is everywhere now. I guessed it would make more sense. But if you dont't like it that way, I can remove it. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=699

D25835: [kcms/launchfeedback] Port to KConfig notifiers

2019-12-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b9a54826350c: [kcms/launchfeedback] Port to KConfig notifiers (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25835?vs=71161&id=

D25837: [Style KCM] Fit widget style preview better

2019-12-10 Thread Kai Uwe Broulik
broulik updated this revision to Diff 71170. broulik retitled this revision from "[Style KCM] Horizontally center widget style preview" to "[Style KCM] Fit widget style preview better". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a com

D25837: [Style KCM] Horizontally center widget style preview

2019-12-10 Thread Kai Uwe Broulik
broulik added a comment. In D25837#574591 , @ngraham wrote: > Could we scale the previews within the delegates down a bit instead? Oooh, good idea. I bet I could just use `scale` and everything should magically work. Not sure how blurry i

D25826: [emojier] disable session manager

2019-12-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. I was thinking of this thing as an app, since that's how we present it. But I guess if you don't think of it as an app, that makes sense. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D25837: [Style KCM] Horizontally center widget style preview

2019-12-10 Thread Nathaniel Graham
ngraham added a comment. Could we scale the previews within the delegates down a bit instead? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25837 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2

D25838: [Applets/Kickoff] Show apps by their real names on top by default

2019-12-10 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now Kickoff shows apps' captions/subtitles on top, with the real name below them. Thi

D25837: [Style KCM] Horizontally center widget style preview

2019-12-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the widget style is too wide. The delegates are already quite large as they is so I'd

D25711: Remove scrollbar behavior option in GTK KCM

2019-12-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R99:abffd8d7c5d8: Remove scrollbar behavior option in GTK KCM (authored by gikari, committed by ngraham). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D25703: Sync scrollbar behavior with GTK applications

2019-12-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R99:68787ff9d3d4: Sync scrollbar behavior with GTK applications (authored by gikari, committed by ngraham). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D25836: Remove redundant finder

2019-12-10 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R99:0b815d1a88d5: Remove redundant finder (authored by apol). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25836?vs=71163&id=71164 REVISION DETAIL

D25836: Remove redundant finder

2019-12-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R99 KDE Gtk Configuration Tool BRANCH master REVISION DETAIL https://phabricator.kde.org/D25836 To: apol, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Fere

D25836: Remove redundant finder

2019-12-10 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's already available in upstream cmake TEST PLAN built kde-gtk-config REPOSITORY R99 KDE Gtk Configuration Tool BRANCH master

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-10 Thread Kai Uwe Broulik
broulik added a comment. Probably: > MainText: Battery at X% > SubText: Powermanagement disabled\n > HH:MM left REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-dev

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-10 Thread Matej Mrenica
mthw added inline comments. INLINE COMMENTS > broulik wrote in batterymonitor.qml:56 > You still haven't addressed this. Don't just `return` when > `powermanagementDisabled`, I would still want to see my battery state when > this is the case? OK, would you like to see: MainText: Power manageme

D25826: [emojier] disable session manager

2019-12-10 Thread Aleix Pol Gonzalez
apol added a comment. In D25826#574375 , @ngraham wrote: > Hmm, I want this thing to be restored if the window was open when I restarted the machine though, right? Why? In case you forgot to choose an emoji? REPOSITORY R119 Plasma Desk

D25835: [kcms/launchfeedback] Port to KConfig notifiers

2019-12-10 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This gets rid of all C++ code in this KCM! It gets rid of a kwin tie in where one shouldn't exist and also expose

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-10 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in batterymonitor.qml:56 > You can probably just return `plasmoid.title` in the default case. > Also, what's the reason for not showing percent

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-10 Thread Matej Mrenica
mthw added a comment. Is everything fine now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Zren

D25792: Add notifiers to workspace options kcfg

2019-12-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8b00bcb9bc09: Add notifiers to workspace options kcfg (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25792?vs=71030&id=71155 R