date:20191211

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-11 Thread Christian

Fuchs added a comment.


  Sidenote, maybe an upstream bug / wish can be added about
  
  > Oh darn, so it does. I checked the docs and tried setting 
SH_ScrollBar_MiddleClickAbsolutePosition explicitly, but it looks like there's 
actually no option to do page-by-page navigation for clicking in the scroll 
track when using the left-click-warps-slider style :/
  
  Thanks for adding the help text :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25873

To: ngraham, #vdg, #plasma, Fuchs
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-11 Thread Nathaniel Graham

ngraham updated this revision to Diff 71328.
ngraham added a comment.


  Only show the message when left-click-navigates-by-page mode is in use

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25873?vs=71250=71328

BRANCH
  explanatory-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25873

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, Fuchs
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-11 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> ndavis wrote in main.qml:164
> This is incorrect. Middle clicking still jumps to the clicked location.

Oh darn, so it does. I checked the docs and tried setting 
`SH_ScrollBar_MiddleClickAbsolutePosition` explicitly, but it looks like 
there's actually no option to do page-by-page navigation for clicking in the 
scroll track when using the left-click-warps-slider style :/

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25873

To: ngraham, #vdg, #plasma, Fuchs
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25908: Lock screen by default, on mobile

2019-12-11 Thread Nicolas Fella

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Works fine for me

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25908

To: apol, #plasma, broulik, nicolasfella
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25910: [Notifications] Add support for global do not disturb toggle shortcut

2019-12-11 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It enables do not disturb until turned off and allows disabling it.

TEST PLAN
  It doesn't have a shortcut by default, should it have one? I'm trying to get 
a shortcut config thing into notification KCM
  
  If you press the shortcut you get an OSD as well as the tray icon changing to 
show the crossed out bell or not
  F7813184: Screenshot_20191211_224136.png 

  F7813185: Screenshot_20191211_224155.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25910

AFFECTED FILES
  applets/notifications/CMakeLists.txt
  applets/notifications/globalshortcuts.cpp
  applets/notifications/globalshortcuts.h
  applets/notifications/notificationapplet.cpp
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25908: Lock screen by default, on mobile

2019-12-11 Thread Nicolas Fella

nicolasfella added a comment.


  Oh yes please
  
  +1

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D25908

To: apol, #plasma, broulik
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25908: Lock screen by default, on mobile

2019-12-11 Thread Aleix Pol Gonzalez

apol created this revision.
apol added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  At the moment it will do the same thing as the desktop: show the logout dialog
  countdown, which doesn't make a lot of sense in this form factor.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25908

AFFECTED FILES
  daemon/powerdevilprofilegenerator.cpp

To: apol, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

2019-12-11 Thread AE

https://bugs.kde.org/show_bug.cgi?id=369158

--- Comment #6 from AE  ---
Hi! Unfortunately I'm not using a dual screen setup these days, so I cannot
confirm or deny.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-11 Thread Noah Davis

ndavis added inline comments.

INLINE COMMENTS

> main.qml:164
> +QQC2.Label {
> +text: scrollbarLeftClickNavigatesByPage.checked ? 
> i18n("Middle-click to scroll to clicked location") : i18n("Middle-click to 
> scroll by page")
> +font.pointSize: theme.smallestFont.pointSize

This is incorrect. Middle clicking still jumps to the clicked location.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25873

To: ngraham, #vdg, #plasma, Fuchs
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25884: Find qdbus command correctly

2019-12-11 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1657457702a4: Find qdbus command correctly (authored by 
ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25884?vs=71273=71294

REVISION DETAIL
  https://phabricator.kde.org/D25884

AFFECTED FILES
  CMakeLists.txt
  wallpapers/image/CMakeLists.txt
  wallpapers/image/wallpaper.knsrc
  wallpapers/image/wallpaper.knsrc.cmake

To: ngraham, davidedmundson, fvogt, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24238: Port the pager applet away from QtWidgets

2019-12-11 Thread David Faure

dfaure added a comment.


  Oh I see.
  
  Is there a non-deprecated method to get the overall geometry of all screens 
combined, or do we need to iterate over the list of screens?
  Surprising that this doesn't seem to be anywhere in the API  !?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: dfaure, hein, apol
Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

2019-12-11 Thread Nathaniel Graham

ngraham updated this revision to Diff 71290.
ngraham added a comment.


  Fix the rebase

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25889?vs=71287=71290

BRANCH
  polish-review-reviewing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25889

AFFECTED FILES
  discover/qml/ReviewDelegate.qml

To: ngraham, #vdg, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

2019-12-11 Thread Nathaniel Graham

ngraham updated this revision to Diff 71287.
ngraham added a comment.


  Rebase

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25889?vs=71284=71287

BRANCH
  polish-review-reviewing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25889

AFFECTED FILES
  discover/qml/ReviewDelegate.qml

To: ngraham, #vdg, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25886: Add support for sub-comments to the Reviews backend

2019-12-11 Thread Dan Leinir Turthra Jensen

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:a4b6d2d5c25e: Add support for sub-comments to the Reviews 
backend (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25886?vs=71277=71286

REVISION DETAIL
  https://phabricator.kde.org/D25886

AFFECTED FILES
  discover/qml/ReviewDelegate.qml
  libdiscover/ReviewsBackend/ReviewsModel.cpp
  libdiscover/ReviewsBackend/ReviewsModel.h
  libdiscover/backends/KNSBackend/KNSReviews.cpp

To: leinir, #discover_software_store, #plasma, apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25886: Add support for sub-comments to the Reviews backend

2019-12-11 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice!

REPOSITORY
  R134 Discover Software Store

BRANCH
  add-support-for-subcomments (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25886

To: leinir, #discover_software_store, #plasma, apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

2019-12-11 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: VDG, apol, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Now with 100% more Emojis! And the UI doesn't blend into the actual review 
itself so much.

TEST PLAN
  F7812702: Reviews.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  polish-review-reviewing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25889

AFFECTED FILES
  discover/qml/ReviewDelegate.qml

To: ngraham, #vdg, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25846: [Cuttlefish] Use the same actions in all menus

2019-12-11 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:6e3f467ad266: [Cuttlefish] Use the same actions in all 
menus (authored by davidre).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25846?vs=71255=71282

REVISION DETAIL
  https://phabricator.kde.org/D25846

AFFECTED FILES
  cuttlefish/package/contents/ui/Actions.qml
  cuttlefish/package/contents/ui/Menu.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml

To: davidre, #plasma, ngraham, cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25886: Add support for sub-comments to the Reviews backend

2019-12-11 Thread Dan Leinir Turthra Jensen

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Using a similar style to the comments delegate in KNewStuffQuick, this
  adds the functionality for having subcomments in the Reviews model.
  The end result is that we no longer have incorrect numbers showing in
  Discover, as it now shows all the items returned by the server.
  
  - Adds a role for the depth of reviews (used for comments on reviews)
  - Adds sub-comments (and set their depth) in the KNS backend's reviews
  - Adapts the ReviewDelegate to have indentation marks (styled like KNSQuick)

REPOSITORY
  R134 Discover Software Store

BRANCH
  add-support-for-subcomments (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25886

AFFECTED FILES
  discover/qml/ReviewDelegate.qml
  libdiscover/ReviewsBackend/ReviewsModel.cpp
  libdiscover/ReviewsBackend/ReviewsModel.h
  libdiscover/backends/KNSBackend/KNSReviews.cpp

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-12-11 Thread Nathaniel Graham

ngraham added a comment.


  Fixed in D25885 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22359

To: ndavis, #vdg, #plasma, davidedmundson
Cc: mart, KonqiDragon, ngraham, davidedmundson, filipf, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D24238: Port the pager applet away from QtWidgets

2019-12-11 Thread Carl Schwan

ognarb added a comment.


  This patch maybe created this bug: https://bugs.kde.org/show_bug.cgi?id=414849

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: dfaure, hein, apol
Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25884: Find qdbus command correctly

2019-12-11 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: davidedmundson, fvogt, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The wallpeper knsrc file file assumes that `qdbus` is in $PATH. However this 
is not
  guaranteed; the command lives in the Qt binaries dir which is not typically 
in $PATH,
  and distros typically create symlinks with different names in `/usr/bin`, but 
not all
  create a second compatibility symlink at `/usr/bin/qdbus` that points to the 
version
  for the current Qt version.
  
  Therefore, we should find the command in the Qt binaries dir itself rather 
than relying
  on these compatibility symlinks.

TEST PLAN
  See that the knsrc file now has the absolute path to `qdbus` in it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  find-qdbus-correctly (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25884

AFFECTED FILES
  CMakeLists.txt
  wallpapers/image/CMakeLists.txt
  wallpapers/image/wallpaper.knsrc
  wallpapers/image/wallpaper.knsrc.cmake

To: ngraham, davidedmundson, fvogt, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25882: Remove dynamic item creation in DefaultListItemBackground

2019-12-11 Thread Arjen Hiemstra

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  For some unknown reason, DefaultListItemBackground uses dynamic item creation
  instead of just declaring items for its separators. This patch removes the
  dynamic item creation and just declares the separtor. This saves more than
  1ms runtime per delegate that gets created in Kirigami Gallery's List View 
page,
  reducing the time per delegate from more than 1ms to ~300us.

TEST PLAN
  Kirigami Gallery's List View page still looks the same

REPOSITORY
  R169 Kirigami

BRANCH
  remove_dynamicitem

REVISION DETAIL
  https://phabricator.kde.org/D25882

AFFECTED FILES
  src/controls/private/DefaultListItemBackground.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25879: Add an option to enable QML profiling

2019-12-11 Thread Arjen Hiemstra

This revision was automatically updated to reflect the committed changes.
ahiemstra marked an inline comment as done.
Closed by commit R1014:693c491bc577: Add an option to enable QML profiling 
(authored by ahiemstra).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25879?vs=71264=71267

REVISION DETAIL
  https://phabricator.kde.org/D25879

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: ahiemstra, #kirigami, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein

D25879: Add an option to enable QML profiling

2019-12-11 Thread Arjen Hiemstra

ahiemstra marked an inline comment as done.
ahiemstra added inline comments.

INLINE COMMENTS

> bshah wrote in CMakeLists.txt:33
> Commit description and code doesn't match :)

D'oh.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D25879

To: ahiemstra, #kirigami, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein

D25879: Add an option to enable QML profiling

2019-12-11 Thread Arjen Hiemstra

ahiemstra updated this revision to Diff 71264.
ahiemstra added a comment.


  - Actually set qml profiling to ON by default

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25879?vs=71263=71264

BRANCH
  qmlprofiling

REVISION DETAIL
  https://phabricator.kde.org/D25879

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: ahiemstra, #kirigami, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein

D25879: Add an option to enable QML profiling

2019-12-11 Thread Arjen Hiemstra

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a CMake option to enable QML profiler and debugger integration.
  This allows running the gallery through the QML profiler, which makes it
  simple to profile Kirigami through running Kirigami Gallery.
  
  It is by default set to "ON" because I do not think there really is any
  risk related to enabling it.

TEST PLAN
  With the option on, starting Kirigami Gallery from command line will print
  "QML debugging is enabled". Without it, no such print happens.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  qmlprofiling

REVISION DETAIL
  https://phabricator.kde.org/D25879

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: ahiemstra, #kirigami
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein

D25879: Add an option to enable QML profiling

2019-12-11 Thread Bhushan Shah

bshah requested changes to this revision.
bshah added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:33
>  
> +option(ENABLE_QML_PROFILING "Enable QML profiler support" OFF)
> +

Commit description and code doesn't match :)

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D25879

To: ahiemstra, #kirigami, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein

D23241: Show application window icon on AboutPage

2019-12-11 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:59a9b92fc6c7: Show application window icon on AboutPage 
(authored by caspermeijn, committed by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23241?vs=64512=71258

REVISION DETAIL
  https://phabricator.kde.org/D23241

AFFECTED FILES
  src/controls/AboutPage.qml
  src/settings.cpp
  src/settings.h

To: caspermeijn, mart, apol, #kirigami, hein
Cc: bcooksley, sitter, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, mart, hein

D23241: Show application window icon on AboutPage

2019-12-11 Thread Marco Martin

mart accepted this revision.
mart added a comment.


  It looks quite weird to have it in something called "Settings", tough.. i' 
fine (in kf6 should really be renamed to something more sensible)
  
  I agree with Eike that it would be better for it to be in Qt.Application, but 
i'm fine with it for now

REPOSITORY
  R169 Kirigami

BRANCH
  about_icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23241

To: caspermeijn, mart, apol, #kirigami, hein
Cc: bcooksley, sitter, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, mart, hein

D25846: [Cuttlefish] Use the same actions in all menus

2019-12-11 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> Menu.qml:24
>  
> -import QtQuick 2.5
> -import Qt.labs.platform 1.0
> +import QtQuick 2.3
> +import QtQuick.Controls 2.5 as QQC2

Sorry that came from the copy-pasting from Kirigami

> Menu.qml:47
> +property Component submenuComponent: actionsMenu
> +//renamed to work on both Qt 5.9 and 5.10
> +property Component itemDelegate: QQC2.MenuItem { }

Dito

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25846

To: davidre, #plasma, ngraham, cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25846: [Cuttlefish] Use the same actions in all menus

2019-12-11 Thread David Redondo

davidre updated this revision to Diff 71255.
davidre marked 2 inline comments as done.
davidre added a comment.


  Comments

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25846?vs=71193=71255

BRANCH
  actions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25846

AFFECTED FILES
  cuttlefish/package/contents/ui/Actions.qml
  cuttlefish/package/contents/ui/Menu.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml

To: davidre, #plasma, ngraham, cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D13175: List the Activity Pager also as an alternative to e.g. the Activity Bar

2019-12-11 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:d9109808cd16: List the Activity Pager also as an 
alternative to e.g. the Activity Bar (authored by hein, committed by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13175?vs=35035=71254

REVISION DETAIL
  https://phabricator.kde.org/D13175

AFFECTED FILES
  applets/activitypager/metadata.desktop

To: hein, broulik, mart
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25874: [Task Manager] Consider parent PID for audio stream

2019-12-11 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For modern web browsers, the audio stream isn't owned by the same process as 
the window, making the mapping fail.
  When no PID is find for a window, check the streams, whether the PID might be 
actually the parent PID.

TEST PLAN
  - I get audio indicator on Chrome again

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25874

AFFECTED FILES
  CMakeLists.txt
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/ui/PulseAudio.qml
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-11 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, Fuchs.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This way the behavior of the related action is clear no matter which setting 
is chosen.

TEST PLAN
  F7812234: labels.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  explanatory-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25873

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, Fuchs
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25872: Refactor GTK KCM code

2019-12-11 Thread Mikhail Zolotukhin

gikari created this revision.
gikari added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  This diff introduces purely cosmetic changes.
  
  1. KCM now compiled with no signals/slot keywords to avoid clash with gtk
  2. Remove linking of XCursors library, because it is no longer needed
  3. Replace some for-cycles with range-based ones
  4. Wrap some string literals with QStringLiteral
  5. Rearrange include headers
  6. Some other changes to better match code style

TEST PLAN
  Check, if there is no regressions

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  refactor-kcm-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25872

AFFECTED FILES
  CMakeLists.txt
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk2.h
  src/appearancegtk3.cpp
  src/appearancegtk3.h
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/dialog_installer.cpp
  src/dialog_installer.h
  src/dialog_uninstaller.cpp
  src/dialog_uninstaller.h
  src/gtkconfigkcmodule.cpp
  src/gtkconfigkcmodule.h
  src/installer.cpp
  src/thread.cpp
  src/thread.h
  tests/CMakeLists.txt
  tests/configsavetest.h

To: gikari, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

D25908: Lock screen by default, on mobile

D25910: [Notifications] Add support for global do not disturb toggle shortcut

D25908: Lock screen by default, on mobile

D25908: Lock screen by default, on mobile

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

D25884: Find qdbus command correctly

D24238: Port the pager applet away from QtWidgets

D25889: Polish the "review this review" UI and presentation

D25889: Polish the "review this review" UI and presentation

D25886: Add support for sub-comments to the Reviews backend

D25886: Add support for sub-comments to the Reviews backend

D25889: Polish the "review this review" UI and presentation

D25846: [Cuttlefish] Use the same actions in all menus

D25886: Add support for sub-comments to the Reviews backend

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

D24238: Port the pager applet away from QtWidgets

D25884: Find qdbus command correctly

D25882: Remove dynamic item creation in DefaultListItemBackground

D25879: Add an option to enable QML profiling

D25879: Add an option to enable QML profiling

D25879: Add an option to enable QML profiling

D25879: Add an option to enable QML profiling

D25879: Add an option to enable QML profiling

D23241: Show application window icon on AboutPage

D23241: Show application window icon on AboutPage

D25846: [Cuttlefish] Use the same actions in all menus

D25846: [Cuttlefish] Use the same actions in all menus

D13175: List the Activity Pager also as an alternative to e.g. the Activity Bar

D25874: [Task Manager] Consider parent PID for audio stream

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

D25872: Refactor GTK KCM code

35 matches

Site Navigation

Mail list logo

Footer information