D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-12 Thread Tranter Madi
trmdi updated this revision to Diff 71408. trmdi added a comment. - emit signals when setConnected REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71391=71408 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25936: [Desktop Containment] Hide tooltip while rotating the widget

2019-12-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The tooltip doesn't follow along and looks quite awkward when it's stuck in its original

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

2019-12-12 Thread Nathaniel Graham
ngraham added a comment. All right, you've convinced me. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

2019-12-12 Thread Kai Uwe Broulik
broulik added a comment. How is it, though? It is an internal hint on some DBus method no user will ever see. Internally it's all things like notificationsInhibitedUntil, even the (public) DBus API says "Inhibited" REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

2019-12-12 Thread Nathaniel Graham
ngraham added a comment. Yeah but this is a user-facing thing (well, sort of user-facing). Eh, your choice. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

2019-12-12 Thread Nathaniel Graham
ngraham updated this revision to Diff 71399. ngraham added a comment. Improve begin/end strings again REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71387=71399 BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

2019-12-12 Thread Kai Uwe Broulik
broulik added a comment. Internally it uses "inhibited" for that everywhere REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

2019-12-12 Thread Nathaniel Graham
ngraham added a comment. `x-kde-show-when-in-do-not-disturb-mode` maybe? Might be nice to reference the feature itself in the keyword since "inhibited" is rather vague. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham,

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

2019-12-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This can be useful for notifications that confirm direct user interaction, such as successful

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-12-12 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5174aa9e1a29: Add grouping and Show Only Minimized options to icons-only task manager (authored by GB_2, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

2019-12-12 Thread Roman Gilg
romangg added a comment. One more thing I forgot: strings "Turn on at" and "Fully on at" and so on are too unclear for me and also sound a bit dumb. ;) Proposal: "Begin shift at" and "Fully engaged at". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25920

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 580 - Still unstable!

2019-12-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/580/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Dec 2019 19:50:47 + Build duration: 9 min 53 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 315 - Still unstable!

2019-12-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/315/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 19:50:47 + Build duration: 4 min 57 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 579 - Still Failing!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/579/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Dec 2019 19:44:32 + Build duration: 3 min 2 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 314 - Still Failing!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/314/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 19:44:32 + Build duration: 1 min 44 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 578 - Failure!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/578/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Dec 2019 19:41:42 + Build duration: 2 min 40 sec and counting CONSOLE OUTPUT

D25933: [applets/pager] Calculate full screen geometry

2019-12-12 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Code original was QDesktopWidget::geometry() which covers all screens.

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 313 - Failure!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/313/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 19:41:41 + Build duration: 2 min 4 sec and counting CONSOLE OUTPUT

D25910: [Notifications] Add support for global do not disturb toggle shortcut

2019-12-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e793d6437225: [Notifications] Add support for global do not disturb toggle shortcut (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25910?vs=71324=71393#toc REPOSITORY

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-12 Thread Tranter Madi
trmdi updated this revision to Diff 71391. trmdi added a comment. - Redirect the signals - Rename the functions - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into add-otherShellHelper REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25844: Don't compress tasks before grouping, when task manager is vertical

2019-12-12 Thread George Vogiatzis
gvgeo updated this revision to Diff 71390. gvgeo retitled this revision from "Don't compress tasks before grouping, when task manager is vertical or icons-only" to "Don't compress tasks before grouping, when task manager is vertical". gvgeo edited the summary of this revision. gvgeo added a

D25844: Don't compress tasks before grouping, when task manager is vertical or icons-only

2019-12-12 Thread George Vogiatzis
gvgeo updated this revision to Diff 71388. gvgeo retitled this revision from "Don't compress tasks before grouping, when task manager is vertical." to "Don't compress tasks before grouping, when task manager is vertical or icons-only". gvgeo edited the summary of this revision. gvgeo added a

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-12-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:96f485db411c: [Notifications KCM] Show hint if notifications arent available or provided by… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

2019-12-12 Thread Nathaniel Graham
ngraham updated this revision to Diff 71387. ngraham added a comment. Tweak location-related mode strings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71381=71387 BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

2019-12-12 Thread Nathaniel Graham
ngraham added a comment. In D25920#576403 , @romangg wrote: > Yea, new strings are better. I like the overall look of the KCM in this redesign. Thanks! > Maybe the description at the top could be in some kind of "info" box or in

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-12-12 Thread Eike Hein
hein added a comment. Let's go for it, it's fairly in line with the TM applet refectoring we planned in Valencia at the end of the day REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, hein, ngraham Cc: ngraham, hein, #vdg,

D23039: Make Kickoff restore favorites order when dragging an item to desktop

2019-12-12 Thread Eike Hein
hein accepted this revision. hein added a comment. Good one, thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23039 To: lisin, #plasma, ngraham, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

2019-12-12 Thread Roman Gilg
romangg added a comment. Yea, new strings are better. I like the overall look of the KCM in this redesign. Maybe the description at the top could be in some kind of "info" box or in another way better styled? For the strings: `Sunset/rise at current location`? REPOSITORY R119 Plasma

D25932: [Task Manager] Better align badge in tooltip

2019-12-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Centers it vertically around the close button rather than the combined height TEST

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

2019-12-12 Thread Nathaniel Graham
ngraham updated this revision to Diff 71381. ngraham added a comment. - Disclose location usage - Use better string for manual location mode REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71359=71381 BRANCH polish-nightcolor-ui

D25882: Remove dynamic item creation in DefaultListItemBackground

2019-12-12 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R169:48177613f2ca: Remove dynamic item creation in DefaultListItemBackground (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D25923: [KCMs/Night Color] Remove "manual location entry" mode

2019-12-12 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Vlad and I talked in person and he convinced me that this was a bad idea. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25923 To: ngraham, #vdg, #plasma, davidedmundson Cc: zzag, plasma-devel,

D25826: [emojier] disable session manager

2019-12-12 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:24e43c524c9e: [emojier] disable session manager (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25826?vs=71140=71364 REVISION

D25923: [KCMs/Night Color] Remove "manual location entry" mode

2019-12-12 Thread Vlad Zahorodnii
zzag added a comment. -1 This mode can be useful for people concerned about privacy. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25923 To: ngraham, #vdg, #plasma, davidedmundson Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25923: [KCMs/Night Color] Remove "manual location entry" mode

2019-12-12 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This mode allows you to set Night Color to trigger based on the

D25838: [Applets/Kickoff] Show apps by their real names on top by default

2019-12-12 Thread Michael Tunnell
michaeltunnell added a comment. Always exciting to see KDE willing to polish the small things. This should also be done on the Application Launcher from the Configure Desktop settings REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25838 To: ngraham,

D25919: Add open containing folder action

2019-12-12 Thread Nathaniel Graham
ngraham added a comment. Awesome, but the button does not work for me. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25919 To: davidre, #plasma, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

2019-12-12 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch polishes the Night Color UI to make it more obvious what the

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 312 - Still Failing!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/312/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 13:51:36 + Build duration: 3 min 27 sec and counting CONSOLE OUTPUT [...truncated

D25919: Add open containing folder action

2019-12-12 Thread David Redondo
davidre updated this revision to Diff 71358. davidre added a comment. fix diff REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25919?vs=71357=71358 BRANCH arcpatch-D25919 REVISION DETAIL https://phabricator.kde.org/D25919 AFFECTED FILES

D25919: Add open containing folder action

2019-12-12 Thread David Redondo
davidre created this revision. davidre added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Adds open containing folder to the actions. That means this function is accesible from

D25428: Improved support for desktop "Folder View"

2019-12-12 Thread Steffen Hartleib
steffenh added a comment. I was trying to use the TapHandler, but I came across a problem with DragAndDrop that I need help with. If I try a DragAndDrop with touch the following happens: - I get a drag cursor, but i get no drag icon - if I release the touch the drag don`t end, I

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 311 - Still Failing!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/311/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 12:39:50 + Build duration: 3 min 6 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 310 - Still Failing!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/310/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 12:06:52 + Build duration: 8 min 6 sec and counting CONSOLE OUTPUT [...truncated

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-12 Thread Nathaniel Graham
ngraham added a comment. Yeah, I'll take over the review. Working through some other stuff first, will resume later today or tomorrow. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, ndavis Cc: ndavis, broulik,

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

2019-12-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When Plasma notification service isn't available or provided by someone else, disable the

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-12 Thread Matej Mrenica
mthw added a comment. What does it mean? Can this patch still go forward? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25916: [Notifications] Provide better feedback when copying a single file

2019-12-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D25916 AFFECTED FILES

D25772: [Notifications] Add ServerInfo class

2019-12-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:147debe3758f: [Notifications] Add ServerInfo class (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25772?vs=71345=71348 REVISION

D25772: [Notifications] Add ServerInfo class

2019-12-12 Thread Kai Uwe Broulik
broulik updated this revision to Diff 71345. broulik added a comment. - Drop `Q_INVOKABLE` - Rename slot - Add missing `ServerInfo` file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25772?vs=70976=71345 REVISION DETAIL

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

2019-12-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=365318 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|NEEDSINFO

D25915: Don't set a new palette if the application has a custom color scheme set

2019-12-12 Thread David Redondo
davidre created this revision. davidre added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY If an application has explicitly set a custom color scheme we shouldn't change the palette when

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-12 Thread Nathaniel Graham
ngraham updated this revision to Diff 71340. ngraham added a comment. Add comment about the Qt situation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25873?vs=71337=71340 BRANCH explanatory-text (branched from master) REVISION DETAIL

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-12 Thread Nathaniel Graham
ngraham updated this revision to Diff 71337. ngraham added a comment. ...and elide REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25873?vs=71336=71337 BRANCH explanatory-text (branched from master) REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 309 - Failure!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/309/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 09:54:08 + Build duration: 3 min 17 sec and counting CONSOLE OUTPUT [...truncated

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

2019-12-12 Thread Dimitar Petrovski
https://bugs.kde.org/show_bug.cgi?id=365318 --- Comment #16 from Dimitar Petrovski --- I have tested the issue now, and I can not reproduce it, I guess it was fixed during the years -- You are receiving this mail because: You are the assignee for the bug.

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-12 Thread Nathaniel Graham
ngraham updated this revision to Diff 71336. ngraham marked an inline comment as done. ngraham added a comment. Fill width REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25873?vs=71328=71336 BRANCH explanatory-text (branched from master)

KDE CI: Plasma » plasma-integration » kf5-qt5 SUSEQt5.12 - Build # 35 - Still unstable!

2019-12-12 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Dec 2019 09:41:47 + Build duration: 3 min 6 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Failing!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Dec 2019 09:41:48 + Build duration: 1 min 59 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 26 - Still Failing!

2019-12-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/26/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Dec 2019 09:41:56 + Build duration: 1 min 51 sec and counting CONSOLE OUTPUT

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-12 Thread David Edmundson
davidedmundson added a comment. It's not a common pattern we do in plasma currently, but that doesn't necessarily mean we shouldn't use it. INLINE COMMENTS > main.qml:131 > > +QQC2.Label { > +text: singleClick.checked ? i18n("Select by clicking on item's > selection

D25449: Start of the new Formats KCM

2019-12-12 Thread Kevin Ottens
ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Like the other ones, please use name and key in the entry elements of your kcfg files. INLINE COMMENTS > kcm.cpp:33 > + > +Formats::Formats(QObject* parent, const QVariantList&

D25838: [Applets/Kickoff] Show apps by their real names on top by default

2019-12-12 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:9e708f955711: [Applets/Kickoff] Show apps by their real names on top by default (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25838: [Applets/Kickoff] Show apps by their real names on top by default

2019-12-12 Thread Méven Car
meven added a comment. In D25838#574655 , @ndavis wrote: > I agree with this. Me too, nice consistency win REPOSITORY R119 Plasma Desktop BRANCH show-apps-by-name (branched from master) REVISION DETAIL

D25375: Start of the accessibility KCM

2019-12-12 Thread Kevin Ottens
ervin requested changes to this revision. ervin added a comment. I think we discussed this already, but I'm not sure so before it gets lost... :-) Please consider using both key and name for your kcfg items, this allows to both respect the past storage format and provide nicer property