D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi updated this revision to Diff 71408.
trmdi added a comment.


  - emit signals when setConnected

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25807?vs=71391&id=71408

BRANCH
  add-otherShellHelper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25807

AFFECTED FILES
  shell/CMakeLists.txt
  shell/othershellhelper.cpp
  shell/othershellhelper.h
  shell/shellcorona.cpp
  shell/shellcorona.h

To: trmdi, #plasma, mvourlakos, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25936: [Desktop Containment] Hide tooltip while rotating the widget

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The tooltip doesn't follow along and looks quite awkward when it's stuck in 
its original position.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25936

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

[Nathaniel Graham]

ngraham added a comment.


  All right, you've convinced me. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

[Kai Uwe Broulik]

broulik added a comment.


  How is it, though? It is an internal hint on some DBus method no user will 
ever see. Internally it's all things like notificationsInhibitedUntil, even the 
(public) DBus API says "Inhibited"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

[Nathaniel Graham]

ngraham added a comment.


  Yeah but this is a user-facing thing (well, sort of user-facing).
  
  Eh, your choice.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71399.
ngraham added a comment.


  Improve begin/end strings again

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71387&id=71399

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

[Kai Uwe Broulik]

broulik added a comment.


  Internally it uses "inhibited" for that everywhere

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

[Nathaniel Graham]

ngraham added a comment.


  `x-kde-show-when-in-do-not-disturb-mode` maybe? Might be nice to reference 
the feature itself in the keyword since "inhibited" is rather vague.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This can be useful for notifications that confirm direct user interaction, 
such as successful Bluetooth pairing, Screenshot creation, or plasmoid removal.
  It only overrules filtering based on urgency, disabling notifications for 
that application altogether will still hide them.

TEST PLAN
  Enabled dnd mode, `notify-send foo bar -h 
string:x-kde-show-when-inhibited:true` and it showed up regardless

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

AFFECTED FILES
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationfilterproxymodel.cpp
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5174aa9e1a29: Add grouping and "Show Only 
Minimized" options to icons-only task manager (authored by GB_2, committed 
by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23242?vs=63979&id=71396

REVISION DETAIL
  https://phabricator.kde.org/D23242

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Roman Gilg]

romangg added a comment.


  One more thing I forgot: strings "Turn on at" and "Fully on at" and so on are 
too unclear for me and also sound a bit dumb. ;) Proposal: "Begin shift at" and 
"Fully engaged at".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 580 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/580/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Dec 2019 19:50:47 +
 Build duration:
9 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.17.80.xmlacc/LibKWorkspace-5.17.80.xmlacc/LibNotificationManager-5.17.80.xmlacc/LibTaskManager-5.17.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.17.80/log.txtlogs/LibKWorkspace/5.17.80/log.txtlogs/LibNotificationManager/5.17.80/log.txtlogs/LibTaskManager/5.17.80/log.txt
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtestName: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.runners.bookmarks.tests.testChromeBookmarksName: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(20/125)11%
(51/465)11%
(51/465)6%
(2576/41579)4%
(1264/28633)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/948)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/279)0%
(0/186)applets.kicker.plugin0%
(0/38)0%
(0/38)0%
(0/3351)0%
(0/2630)applets.notifications0%
(0/8)0%
(0/8)0%
(0/207)0%
(0/88)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/278)0%
(0/223)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%
(0/66)components.containmentlayoutmanager0%
(0/10)0%
(0/10)0%

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 315 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/315/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Dec 2019 19:50:47 +
 Build duration:
4 min 57 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.runners.bookmarks.tests.testChromeBookmarksName: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 579 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/579/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Dec 2019 19:44:32 +
 Build duration:
3 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 2532 lines...][2019-12-12T19:47:27.804Z]   |^~~~[2019-12-12T19:47:27.804Z] /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:259:41: warning: ���void Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, QObject*, const char*)��� is deprecated [-Wdeprecated-declarations][2019-12-12T19:47:27.804Z]   259 | Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, nullptr, nullptr);[2019-12-12T19:47:27.804Z]   | ^~~~[2019-12-12T19:47:27.804Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-12-12T19:47:27.804Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-12-12T19:47:27.804Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: declared here[2019-12-12T19:47:27.804Z]83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-12-12T19:47:27.804Z]   |^~~~[2019-12-12T19:47:27.804Z] /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:259:110: warning: ���void Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, QObject*, const char*)��� is deprecated [-Wdeprecated-declarations][2019-12-12T19:47:27.804Z]   259 | Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, nullptr, nullptr);[2019-12-12T19:47:27.804Z]   |  ^[2019-12-12T19:47:27.804Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-12-12T19:47:27.804Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-12-12T19:47:27.804Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: declared here[2019-12-12T19:47:27.804Z]83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-12-12T19:47:27.804Z]   |^~~~[2019-12-12T19:47:27.805Z] /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:259:110: warning: ���void Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, QObject*, const char*)��� is deprecated [-Wdeprecated-declarations][2019-12-12T19:47:27.805Z]   259 | Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, nullptr, nullptr);[2019-12-12T19:47:27.805Z]   |  ^[2019-12-12T19:47:27.805Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-12-12T19:47:27.805Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-12-12T19:47:27.805Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: declared here[2019-12-12T19:47:27.805Z]83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-12-12T19:47:27.805Z]   |^~~~[2019-12-12T19:47:27.805Z] /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:253:16: warning: enumeration value ���HybridSuspendState��� not handled in switch [-Wswitch][2019-12-12T19:47:27.805Z]   253 | switch ((Solid::PowerManagement::SleepState)match.data().toInt()) {[2019-12-12T19:47:27.805Z]   |^[2019-12-12T19:47:27.805Z] Scanning dependencies of target plasma_applet_appmenu[2019-12-12T19:47:27.805Z] [ 48%] Building CXX object applets/appmenu/lib/CMakeFiles/plasma_applet_appmenu.dir/plasma_applet_appmenu_autogen/mocs_compilation.cpp.o[2019-12-12T19:47:27.805Z] [ 48%] Building CXX object applets/appmenu/lib/CMakeFiles/plasma_applet_appmenu.dir/appmenuapplet.cpp.o[2019-12-12T19:47:27.805Z] [ 48%] Linking CXX shared module ../../bin/krunner_bookmarksrunner.so[2019-12-12T19:47:28.061Z] [ 48%] Built target krunner_a

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 314 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/314/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Dec 2019 19:44:32 +
 Build duration:
1 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 2925 lines...][2019-12-12T19:46:06.158Z] [ 51%] Linking CXX shared module ../../bin/krunner_powerdevil.so[2019-12-12T19:46:06.158Z] [ 51%] Built target appmenuplugin_autogen[2019-12-12T19:46:06.416Z] [ 51%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/digitalclockplugin.cpp.o[2019-12-12T19:46:06.416Z] [ 51%] Built target krunner_powerdevil[2019-12-12T19:46:06.416Z] Scanning dependencies of target kickerplugin_autogen[2019-12-12T19:46:06.416Z] [ 51%] Automatic MOC for target kickerplugin[2019-12-12T19:46:06.675Z] [ 51%] Linking CXX shared module ../../bin/krunner_bookmarksrunner.so[2019-12-12T19:46:07.241Z] [ 51%] Building CXX object applets/appmenu/lib/CMakeFiles/plasma_applet_appmenu.dir/appmenuapplet.cpp.o[2019-12-12T19:46:07.499Z] [ 51%] Built target krunner_bookmarksrunner[2019-12-12T19:46:07.499Z] [ 51%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/clipboardmenu.cpp.o[2019-12-12T19:46:07.499Z] [ 51%] Building CXX object applets/calendar/CMakeFiles/plasma_applet_calendar.dir/calendarapplet.cpp.o[2019-12-12T19:46:08.071Z] Scanning dependencies of target plasma_applet_notifications[2019-12-12T19:46:08.331Z] [ 51%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/plasma_applet_notifications_autogen/mocs_compilation.cpp.o[2019-12-12T19:46:08.331Z] Scanning dependencies of target org.kde.plasma.private.systemtray[2019-12-12T19:46:08.331Z] [ 52%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/org.kde.plasma.private.systemtray_autogen/mocs_compilation.cpp.o[2019-12-12T19:46:08.331Z] Scanning dependencies of target org.kde.plasma.systemtray[2019-12-12T19:46:08.331Z] [ 53%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/org.kde.plasma.systemtray_autogen/mocs_compilation.cpp.o[2019-12-12T19:46:08.331Z] [ 53%] Linking CXX shared module ../../bin/kcm_krunner_kill.so[2019-12-12T19:46:08.904Z] [ 53%] Built target kcm_krunner_kill[2019-12-12T19:46:08.904Z] [ 53%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/notificationapplet.cpp.o[2019-12-12T19:46:09.173Z] [ 53%] Built target kickerplugin_autogen[2019-12-12T19:46:09.173Z] [ 53%] Generating ui_statusnotifiertest.h[2019-12-12T19:46:09.173Z] Scanning dependencies of target statusnotifiertest[2019-12-12T19:46:09.173Z] [ 53%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest_autogen/mocs_compilation.cpp.o[2019-12-12T19:46:09.434Z] [ 53%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/systemtraycontainer.cpp.o[2019-12-12T19:46:09.434Z] [ 53%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/main.cpp.o[2019-12-12T19:46:09.434Z] [ 53%] Linking CXX shared module ../../bin/plasma_applet_calendar.so[2019-12-12T19:46:09.434Z] [ 53%] Linking CXX shared library ../../../bin/libdigitalclockplugin.so[2019-12-12T19:46:09.434Z] [ 53%] Built target plasma_applet_calendar[2019-12-12T19:46:09.434Z] [ 53%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/filemenu.cpp.o[2019-12-12T19:46:09.434Z] [ 53%] Built target digitalclockplugin[2019-12-12T19:46:09.434Z] [ 53%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/systemtray.cpp.o[2019-12-12T19:46:10.007Z] [ 53%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/debug.cpp.o[2019-12-12T19:46:10.007Z] [ 53%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest.cpp.o[2019-12-12T19:46:10.007Z] [ 53%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/globalshortcuts.cpp.o[2019-12-12T19:46:10.007Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/notifications/globalshortcuts.cpp:21:10: fatal error: 'globalshortcuts.h' file not found[2019-12-12T19:46:10.007Z] #include "globalshortcuts.h"[2019-12-12T19:46:10.007Z]  ^~~[2019-12-12T19:46:10.278Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/notifications/notificationapplet.cpp:36:10: fatal error: 'globalshortcuts.h' file not found[2019-12-12T19:46:10.278Z] #include "globalshortcuts.h"[2019-12-12T19:46:10.278Z]  ^~~[2019-12-12T19:46:10.278Z] 1 error generated.[2019-12-12T19:46:10.278Z] gmake[2]: *** [applets/notifications/CMakeFiles/plasma_applet_notifications.dir/build.make:76: applets/notificat

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 578 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/578/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Dec 2019 19:41:42 +
 Build duration:
2 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 2570 lines...][2019-12-12T19:44:14.611Z] [ 48%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/timezonemodel.cpp.o[2019-12-12T19:44:14.870Z] [ 48%] Linking CXX shared module ../../bin/krunner_powerdevil.so[2019-12-12T19:44:15.129Z] [ 48%] Built target krunner_powerdevil[2019-12-12T19:44:15.129Z] [ 48%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/timezonesi18n.cpp.o[2019-12-12T19:44:15.129Z] [ 48%] Building CXX object applets/calendar/CMakeFiles/plasma_applet_calendar.dir/calendarapplet.cpp.o[2019-12-12T19:44:15.696Z] [ 48%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/digitalclockplugin.cpp.o[2019-12-12T19:44:15.696Z] [ 48%] Linking CXX shared module ../../bin/kcm_krunner_kill.so[2019-12-12T19:44:15.696Z] [ 48%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/clipboardmenu.cpp.o[2019-12-12T19:44:15.696Z] Scanning dependencies of target kickerplugin_autogen[2019-12-12T19:44:15.696Z] [ 48%] Automatic MOC for target kickerplugin[2019-12-12T19:44:15.953Z] [ 48%] Linking CXX shared module ../../../bin/plasma_applet_appmenu.so[2019-12-12T19:44:16.210Z] [ 48%] Built target kcm_krunner_kill[2019-12-12T19:44:16.210Z] Scanning dependencies of target org.kde.plasma.private.systemtray[2019-12-12T19:44:16.210Z] [ 48%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/org.kde.plasma.private.systemtray_autogen/mocs_compilation.cpp.o[2019-12-12T19:44:16.210Z] Scanning dependencies of target plasma_applet_notifications[2019-12-12T19:44:16.210Z] [ 49%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/plasma_applet_notifications_autogen/mocs_compilation.cpp.o[2019-12-12T19:44:16.467Z] [ 49%] Linking CXX shared module ../../bin/krunner_windows.so[2019-12-12T19:44:16.722Z] [ 49%] Built target plasma_applet_appmenu[2019-12-12T19:44:16.722Z] [ 49%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/notificationapplet.cpp.o[2019-12-12T19:44:16.722Z] [ 49%] Linking CXX shared module ../../bin/plasma_applet_calendar.so[2019-12-12T19:44:16.722Z] [ 49%] Built target kickerplugin_autogen[2019-12-12T19:44:16.722Z] [ 49%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/filemenu.cpp.o[2019-12-12T19:44:16.980Z] [ 49%] Built target plasma_applet_calendar[2019-12-12T19:44:16.980Z] /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/applets/notifications/notificationapplet.cpp:36:10: fatal error: globalshortcuts.h: No such file or directory[2019-12-12T19:44:16.980Z]36 | #include "globalshortcuts.h"[2019-12-12T19:44:16.980Z]   |  ^~~[2019-12-12T19:44:16.980Z] compilation terminated.[2019-12-12T19:44:16.980Z] make[2]: *** [applets/notifications/CMakeFiles/plasma_applet_notifications.dir/build.make:76: applets/notifications/CMakeFiles/plasma_applet_notifications.dir/notificationapplet.cpp.o] Error 1[2019-12-12T19:44:16.980Z] make[2]: *** Waiting for unfinished jobs[2019-12-12T19:44:16.980Z] [ 49%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/globalshortcuts.cpp.o[2019-12-12T19:44:16.980Z] /home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/applets/notifications/globalshortcuts.cpp:21:10: fatal error: globalshortcuts.h: No such file or directory[2019-12-12T19:44:16.980Z]21 | #include "globalshortcuts.h"[2019-12-12T19:44:16.980Z]   |  ^~~[2019-12-12T19:44:16.980Z] compilation terminated.[2019-12-12T19:44:16.980Z] make[2]: *** [applets/notifications/CMakeFiles/plasma_applet_notifications.dir/build.make:102: applets/notifications/CMakeFiles/plasma_applet_notifications.dir/globalshortcuts.cpp.o] Error 1[2019-12-12T19:44:16.980Z] [ 49%] Generating ui_statusnotifiertest.h[2019-12-12T19:44:16.980Z] Scanning dependencies of target plasma_engine_applicationjobs_autogen[2019-12-12T19:44:16.980Z] [ 49%] Generating plasma-dataengine-applicationjobs.json[2019-12-12T19:44:16.980Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"[2019-12-12T19:44:16.980Z] Found property definition "X-KDE-ParentApp" with type "QString"[2019-12-12T19:44:16.980Z] Generated  "/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/dataengines/applicationjobs/plasma-dataengine-applicationjobs.json" [2019-12-12T19:44:16.980Z] [2019-12-12T19:44:16.980Z] Scanning dependencies of target org.kde.plasma.systemtray[2019-12-12T19:44:16.980Z] [ 49%] Automatic MOC for target plasma_engine_appli

D25933: [applets/pager] Calculate full screen geometry

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Code original was QDesktopWidget::geometry() which covers all screens.
  
  This effectively matches the internal implementation used there.
  
  BUG: (fixme)

TEST PLAN
  Only tested with one monitor. 
  Pager still looks normal

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25933

AFFECTED FILES
  applets/pager/plugin/windowmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 313 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/313/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Dec 2019 19:41:41 +
 Build duration:
2 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 2891 lines...][2019-12-12T19:43:41.440Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-12-12T19:43:41.440Z]^[2019-12-12T19:43:41.440Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-12-12T19:43:41.440Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-12-12T19:43:41.440Z]  ^[2019-12-12T19:43:41.440Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/runners/powerdevil/PowerDevilRunner.cpp:212:13: warning: enumeration value 'HybridSuspendState' not handled in switch [-Wswitch][2019-12-12T19:43:41.440Z] switch ((Solid::PowerManagement::SleepState)value) {[2019-12-12T19:43:41.440Z] ^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/runners/powerdevil/PowerDevilRunner.cpp:256:41: warning: 'requestSleep' is deprecated [-Wdeprecated-declarations][2019-12-12T19:43:41.441Z] Solid::PowerManagement::requestSleep(Solid::PowerManagement::SuspendState, nullptr, nullptr);[2019-12-12T19:43:41.441Z] ^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:1: note: 'requestSleep' has been explicitly marked deprecated here[2019-12-12T19:43:41.441Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-12-12T19:43:41.441Z] ^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-12-12T19:43:41.441Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-12-12T19:43:41.441Z]^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-12-12T19:43:41.441Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-12-12T19:43:41.441Z]  ^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/runners/powerdevil/PowerDevilRunner.cpp:259:41: warning: 'requestSleep' is deprecated [-Wdeprecated-declarations][2019-12-12T19:43:41.441Z] Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, nullptr, nullptr);[2019-12-12T19:43:41.441Z] ^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:1: note: 'requestSleep' has been explicitly marked deprecated here[2019-12-12T19:43:41.441Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-12-12T19:43:41.441Z] ^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-12-12T19:43:41.441Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-12-12T19:43:41.441Z]^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-12-12T19:43:41.441Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-12-12T19:43:41.441Z]  ^[2019-12-12T19:43:41.441Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/runners/powerdevil/PowerDevilRunner.cpp:253:17: warning: enumeration value 'HybridSuspendState' not handled in switch [-Wswitch][2019-12-12T19:43:41.441Z] switch ((Solid::PowerManagement::SleepState)match.data().toInt()) {[2019-12-12T19:43:41.441Z] ^[2019-12-12T19:43:41.441Z] [ 51%] Linking CXX shared module ../../bin/krunner_windows.so[2019-12-12T19:43:42.009Z] [ 51%] Built target krunner_windows[2019-12-12T19:43:42.009Z] 6 warnings generated.[2019-12-12T19:43:42.009Z] Scanning dependencies of target plasma_applet_notifications[2019-12-12T19:43:42.009Z] [ 51%]

D25910: [Notifications] Add support for global do not disturb toggle shortcut

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e793d6437225: [Notifications] Add support for global do 
not disturb toggle shortcut (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25910?vs=71324&id=71393#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25910?vs=71324&id=71393

REVISION DETAIL
  https://phabricator.kde.org/D25910

AFFECTED FILES
  applets/notifications/CMakeLists.txt
  applets/notifications/globalshortcuts.cpp
  applets/notifications/notificationapplet.cpp
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi updated this revision to Diff 71391.
trmdi added a comment.


  - Redirect the signals
  - Rename the functions
  - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into 
add-otherShellHelper

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25807?vs=71079&id=71391

BRANCH
  add-otherShellHelper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25807

AFFECTED FILES
  shell/CMakeLists.txt
  shell/othershellhelper.cpp
  shell/othershellhelper.h
  shell/shellcorona.cpp
  shell/shellcorona.h

To: trmdi, #plasma, mvourlakos, davidedmundson, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25844: Don't compress tasks before grouping, when task manager is vertical

[George Vogiatzis]

gvgeo updated this revision to Diff 71390.
gvgeo retitled this revision from "Don't compress tasks before grouping, when 
task manager is vertical or icons-only" to "Don't compress tasks before 
grouping, when task manager is vertical".
gvgeo edited the summary of this revision.
gvgeo added a comment.


  Revert previous update, as D23242  does 
not enable 'Group only when the Task Manager is full' option.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25844?vs=71388&id=71390

REVISION DETAIL
  https://phabricator.kde.org/D25844

AFFECTED FILES
  applets/taskmanager/package/contents/ui/code/layout.js

To: gvgeo, #plasma, #vdg
Cc: davidedmundson, GB_2, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25844: Don't compress tasks before grouping, when task manager is vertical or icons-only

[George Vogiatzis]

gvgeo updated this revision to Diff 71388.
gvgeo retitled this revision from "Don't compress tasks before grouping, when 
task manager is vertical." to "Don't compress tasks before grouping, when task 
manager is vertical or icons-only".
gvgeo edited the summary of this revision.
gvgeo added a comment.


  Now that D23242  got accepted, updated to 
fit icon-only groups too.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25844?vs=71191&id=71388

REVISION DETAIL
  https://phabricator.kde.org/D25844

AFFECTED FILES
  applets/taskmanager/package/contents/ui/code/layout.js

To: gvgeo, #plasma, #vdg
Cc: davidedmundson, GB_2, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:96f485db411c: [Notifications KCM] Show hint if 
notifications aren't available or provided by… (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25097?vs=71137&id=71389

REVISION DETAIL
  https://phabricator.kde.org/D25097

AFFECTED FILES
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71387.
ngraham added a comment.


  Tweak location-related mode strings

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71381&id=71387

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham added a comment.


  In D25920#576403 , @romangg wrote:
  
  > Yea, new strings are better. I like the overall look of the KCM in this 
redesign.
  
  
  Thanks!
  
  > Maybe the description at the top could be in some kind of "info" box or in 
another way better styled?
  
  That's slightly out of scope for the current patch, and I kind of like it 
floating there where it currently. I tried using a KMessageWidget and a frame 
and it didn't feel right. Maybe we could make it wider?
  
  > For the strings: `Sunset/rise at current location`?
  
  Good idea!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

[Eike Hein]

hein added a comment.


  Let's go for it, it's fairly in line with the TM applet refectoring we 
planned in Valencia at the end of the day

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23039: Make Kickoff restore favorites order when dragging an item to desktop

[Eike Hein]

hein accepted this revision.
hein added a comment.


  Good one, thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23039

To: lisin, #plasma, ngraham, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Roman Gilg]

romangg added a comment.


  Yea, new strings are better. I like the overall look of the KCM in this 
redesign. Maybe the description at the top could be in some kind of "info" box 
or in another way better styled?
  
  For the strings: `Sunset/rise at current location`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25932: [Task Manager] Better align badge in tooltip

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Centers it vertically around the close button rather than the combined height

TEST PLAN
  Before
  F7814288: Screenshot_20191212_183656.png 

  After
  F7814289: Screenshot_20191212_183527.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25932

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, #vdg, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham updated this revision to Diff 71381.
ngraham added a comment.


  - Disclose location usage
  - Use better string for manual location mode

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25920?vs=71359&id=71381

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25882: Remove dynamic item creation in DefaultListItemBackground

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:48177613f2ca: Remove dynamic item creation in 
DefaultListItemBackground (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25882?vs=71269&id=71377

REVISION DETAIL
  https://phabricator.kde.org/D25882

AFFECTED FILES
  src/controls/private/DefaultListItemBackground.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25923: [KCMs/Night Color] Remove "manual location entry" mode

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Vlad and I talked in person and he convinced me that this was a bad idea.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25923

To: ngraham, #vdg, #plasma, davidedmundson
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25826: [emojier] disable session manager

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:24e43c524c9e: [emojier] disable session manager (authored 
by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25826?vs=71140&id=71364

REVISION DETAIL
  https://phabricator.kde.org/D25826

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp

To: davidedmundson, #plasma, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25923: [KCMs/Night Color] Remove "manual location entry" mode

[Vlad Zahorodnii]

zzag added a comment.


  -1
  
  This mode can be useful for people concerned about privacy.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25923

To: ngraham, #vdg, #plasma, davidedmundson
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25923: [KCMs/Night Color] Remove "manual location entry" mode

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This mode allows you to set Night Color to trigger based on the 
sunset/sunrise times of an
  arbitrary latitude/longitude location. However this is completely pointless; 
there is no
  conceivable use case for setting the location to any place other than your 
current
  location. The only reason why you would want to enter your current location 
manually is
  if the automatic geolocation feature is broken. However if this is the case, 
it is much
  faster to just enter start/end times manually than it is to look up your 
latitude and
  longitude and enter them into the text fields here.
  
  Therefore, this patch removes that mode from the KCM and requires that people 
who don't
  use the automatic geolocation feature enter the start/end times manually.
  
  In the future, we could even remove the geolocator and base the location on 
the current
  time zone so we can bypass failures of the geolocator.

TEST PLAN
  Modes now: F7814125 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-manual-location-entry-mode (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25923

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25838: [Applets/Kickoff] Show apps by their real names on top by default

[Michael Tunnell]

michaeltunnell added a comment.


  Always exciting to see KDE willing to polish the small things.
  
  This should also be done on the Application Launcher from the Configure 
Desktop settings

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25838

To: ngraham, #vdg, #plasma, ndavis
Cc: meven, ndavis, michaeltunnell, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25919: Add open containing folder action

[Nathaniel Graham]

ngraham added a comment.


  Awesome, but the button does not work for me.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25919

To: davidre, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch polishes the Night Color UI to make it more obvious what the 
feature does,
  what the activation triggers are and mean, and when activation will start and 
end.

TEST PLAN
  F7814072: demo-2019-12-12_15.13.35.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 312 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/312/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Dec 2019 13:51:36 +
 Build duration:
3 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 2644 lines...][2019-12-12T13:54:46.222Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/desktopgrid/desktopgrid.cpp.o[2019-12-12T13:54:46.222Z] [ 47%] Built target kwin5_aurorae[2019-12-12T13:54:46.222Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/diminactive/diminactive.cpp.o[2019-12-12T13:54:46.483Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/effect_builtins.cpp.o[2019-12-12T13:54:46.483Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/flipswitch/flipswitch.cpp.o[2019-12-12T13:54:46.745Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/glide/glide.cpp.o[2019-12-12T13:54:47.005Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/invert/invert.cpp.o[2019-12-12T13:54:47.657Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/logging.cpp.o[2019-12-12T13:54:48.243Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/lookingglass/lookingglass.cpp.o[2019-12-12T13:54:48.243Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magiclamp/magiclamp.cpp.o[2019-12-12T13:54:48.530Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magnifier/magnifier.cpp.o[2019-12-12T13:54:50.568Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mouseclick/mouseclick.cpp.o[2019-12-12T13:54:50.568Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mousemark/mousemark.cpp.o[2019-12-12T13:54:50.568Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows.cpp.o[2019-12-12T13:54:50.569Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows_proxy.cpp.o[2019-12-12T13:54:50.569Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/resize/resize.cpp.o[2019-12-12T13:54:50.827Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showfps/showfps.cpp.o[2019-12-12T13:54:51.088Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showpaint/showpaint.cpp.o[2019-12-12T13:54:51.673Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slide/slide.cpp.o[2019-12-12T13:54:51.994Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/thumbnailaside/thumbnailaside.cpp.o[2019-12-12T13:54:53.126Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/touchpoints/touchpoints.cpp.o[2019-12-12T13:54:53.126Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/effects/presentwindows/presentwindows.cpp:1584:37: warning: 'desktop' is deprecated [-Wdeprecated-declarations][2019-12-12T13:54:53.126Z] desktop = activeWindow->desktop();[2019-12-12T13:54:53.126Z] ^[2019-12-12T13:54:53.126Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/libkwineffects/kwineffects.h:2177:17: note: 'desktop' has been explicitly marked deprecated here[2019-12-12T13:54:53.126Z] virtual int KWIN_DEPRECATED desktop() const = 0; // prefer isOnXXX()[2019-12-12T13:54:53.126Z] ^[2019-12-12T13:54:53.126Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/build/kwin_export.h:25:43: note: expanded from macro 'KWIN_DEPRECATED'[2019-12-12T13:54:53.126Z] #  define KWIN_DEPRECATED __attribute__ ((__deprecated__))[2019-12-12T13:54:53.126Z]   ^[2019-12-12T13:54:53.761Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/trackmouse/trackmouse.cpp.o[2019-12-12T13:54:53.761Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/windowgeometry/windowgeometry.cpp.o[2019-12-12T13:54:54.027Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/wobblywindows/wobblywindows.cpp.o[2019-12-12T13:54:54.027Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/zoom/zoom.cpp.o[2019-12-12T13:54:54.309Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/qrc_shaders.cpp.o[2019-12-12T13:54:54.309Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/blurconfig.cpp.o[2019-12-12T13:54:54.594Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/coverswitchconfig.cpp.o[2019-12-12T13:54:54.897Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeconfig.cpp.o[2019-12-12T13:54:54.897Z] 1 warning generated.[2019-12-12T13:54:54.897Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeslideconfig.cpp.o[2019-12-12T13:54:

D25919: Add open containing folder action

[David Redondo]

davidre updated this revision to Diff 71358.
davidre added a comment.


  fix diff

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25919?vs=71357&id=71358

BRANCH
  arcpatch-D25919

REVISION DETAIL
  https://phabricator.kde.org/D25919

AFFECTED FILES
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Actions.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25919: Add open containing folder action

[David Redondo]

davidre created this revision.
davidre added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Adds open containing folder to the actions. That means this function is 
accesible from the sidebar in either mode or from the context menu.

REPOSITORY
  R118 Plasma SDK

BRANCH
  open-containing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25919

AFFECTED FILES
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Actions.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

[Steffen Hartleib]

steffenh added a comment.


  I was trying to use the TapHandler, but I came across a problem with 
DragAndDrop that I need help with.
  
  If I try a DragAndDrop with touch the following happens:
  
  - I get a drag cursor, but i get no drag icon
  - if I release the touch the drag don`t end, I need to extra tap the desktop 
to end the drag. At the tap point the dragged Item appears
  - additionally I found, a error message in the log "QObject::disconnect: 
Unexpected null parameter"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham, mart
Cc: mart, ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 311 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/311/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Dec 2019 12:39:50 +
 Build duration:
3 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 2996 lines...][2019-12-12T12:42:40.289Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/desktopgrid/desktopgrid.cpp.o[2019-12-12T12:42:40.856Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/diminactive/diminactive.cpp.o[2019-12-12T12:42:40.856Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/effect_builtins.cpp.o[2019-12-12T12:42:41.123Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/flipswitch/flipswitch.cpp.o[2019-12-12T12:42:41.391Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/glide/glide.cpp.o[2019-12-12T12:42:41.672Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/invert/invert.cpp.o[2019-12-12T12:42:41.673Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/logging.cpp.o[2019-12-12T12:42:41.673Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/lookingglass/lookingglass.cpp.o[2019-12-12T12:42:42.243Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magiclamp/magiclamp.cpp.o[2019-12-12T12:42:42.816Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magnifier/magnifier.cpp.o[2019-12-12T12:42:43.075Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mouseclick/mouseclick.cpp.o[2019-12-12T12:42:43.075Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mousemark/mousemark.cpp.o[2019-12-12T12:42:43.336Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows.cpp.o[2019-12-12T12:42:43.336Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows_proxy.cpp.o[2019-12-12T12:42:43.593Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showfps/showfps.cpp.o[2019-12-12T12:42:43.593Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/resize/resize.cpp.o[2019-12-12T12:42:43.853Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showpaint/showpaint.cpp.o[2019-12-12T12:42:43.853Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slide/slide.cpp.o[2019-12-12T12:42:44.792Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/thumbnailaside/thumbnailaside.cpp.o[2019-12-12T12:42:44.792Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/touchpoints/touchpoints.cpp.o[2019-12-12T12:42:45.049Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/effects/presentwindows/presentwindows.cpp:1584:37: warning: 'desktop' is deprecated [-Wdeprecated-declarations][2019-12-12T12:42:45.049Z] desktop = activeWindow->desktop();[2019-12-12T12:42:45.049Z] ^[2019-12-12T12:42:45.049Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/libkwineffects/kwineffects.h:2177:17: note: 'desktop' has been explicitly marked deprecated here[2019-12-12T12:42:45.049Z] virtual int KWIN_DEPRECATED desktop() const = 0; // prefer isOnXXX()[2019-12-12T12:42:45.049Z] ^[2019-12-12T12:42:45.049Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/build/kwin_export.h:25:43: note: expanded from macro 'KWIN_DEPRECATED'[2019-12-12T12:42:45.049Z] #  define KWIN_DEPRECATED __attribute__ ((__deprecated__))[2019-12-12T12:42:45.049Z]   ^[2019-12-12T12:42:45.049Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/trackmouse/trackmouse.cpp.o[2019-12-12T12:42:45.324Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/windowgeometry/windowgeometry.cpp.o[2019-12-12T12:42:45.587Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/wobblywindows/wobblywindows.cpp.o[2019-12-12T12:42:45.587Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/zoom/zoom.cpp.o[2019-12-12T12:42:45.845Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/qrc_shaders.cpp.o[2019-12-12T12:42:45.845Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/blurconfig.cpp.o[2019-12-12T12:42:45.845Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/coverswitchconfig.cpp.o[2019-12-12T12:42:46.110Z] 1 warning generated.[2019-12-12T12:42:46.110Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeconfig.cpp.o[2019-12-12T12:42:46.692Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeslideconfig.cpp.o[2019-12-12T12:42:46.692Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 310 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/310/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Dec 2019 12:06:52 +
 Build duration:
8 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 2998 lines...][2019-12-12T12:14:38.452Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/diminactive/diminactive.cpp.o[2019-12-12T12:14:38.452Z] [ 47%] Built target kwin5_aurorae[2019-12-12T12:14:38.452Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/effect_builtins.cpp.o[2019-12-12T12:14:38.452Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/flipswitch/flipswitch.cpp.o[2019-12-12T12:14:38.726Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/glide/glide.cpp.o[2019-12-12T12:14:38.726Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/invert/invert.cpp.o[2019-12-12T12:14:39.291Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/logging.cpp.o[2019-12-12T12:14:39.558Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/lookingglass/lookingglass.cpp.o[2019-12-12T12:14:39.558Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magiclamp/magiclamp.cpp.o[2019-12-12T12:14:40.122Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magnifier/magnifier.cpp.o[2019-12-12T12:14:40.385Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mouseclick/mouseclick.cpp.o[2019-12-12T12:14:40.385Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mousemark/mousemark.cpp.o[2019-12-12T12:14:40.951Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows.cpp.o[2019-12-12T12:14:40.951Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows_proxy.cpp.o[2019-12-12T12:14:40.951Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/resize/resize.cpp.o[2019-12-12T12:14:40.951Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showfps/showfps.cpp.o[2019-12-12T12:14:41.233Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showpaint/showpaint.cpp.o[2019-12-12T12:14:41.532Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slide/slide.cpp.o[2019-12-12T12:14:42.157Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/thumbnailaside/thumbnailaside.cpp.o[2019-12-12T12:14:42.431Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/touchpoints/touchpoints.cpp.o[2019-12-12T12:14:42.431Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/effects/presentwindows/presentwindows.cpp:1584:37: warning: 'desktop' is deprecated [-Wdeprecated-declarations][2019-12-12T12:14:42.431Z] desktop = activeWindow->desktop();[2019-12-12T12:14:42.431Z] ^[2019-12-12T12:14:42.431Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/libkwineffects/kwineffects.h:2177:17: note: 'desktop' has been explicitly marked deprecated here[2019-12-12T12:14:42.431Z] virtual int KWIN_DEPRECATED desktop() const = 0; // prefer isOnXXX()[2019-12-12T12:14:42.431Z] ^[2019-12-12T12:14:42.431Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/build/kwin_export.h:25:43: note: expanded from macro 'KWIN_DEPRECATED'[2019-12-12T12:14:42.431Z] #  define KWIN_DEPRECATED __attribute__ ((__deprecated__))[2019-12-12T12:14:42.431Z]   ^[2019-12-12T12:14:42.705Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/trackmouse/trackmouse.cpp.o[2019-12-12T12:14:42.705Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/windowgeometry/windowgeometry.cpp.o[2019-12-12T12:14:42.973Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/wobblywindows/wobblywindows.cpp.o[2019-12-12T12:14:43.293Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/zoom/zoom.cpp.o[2019-12-12T12:14:43.293Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/qrc_shaders.cpp.o[2019-12-12T12:14:43.293Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/blurconfig.cpp.o[2019-12-12T12:14:43.293Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/coverswitchconfig.cpp.o[2019-12-12T12:14:43.897Z] 1 warning generated.[2019-12-12T12:14:43.897Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeconfig.cpp.o[2019-12-12T12:14:43.897Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeslideconfig.cpp.o[2019-12-12T12:14:44.475Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/desktopgridconfig.cpp.o[2019-12-12T12:14:44.475Z

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I'll take over the review. Working through some other stuff first, will 
resume later today or tomorrow.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When Plasma notification service isn't available or provided by someone else, 
disable the plasmoid.
  Do not disturb controls are disabled and the applet stays in the popup 
crossed out.
  Effectively D25097  of plasma-desktop for 
the applet itself.

TEST PLAN
  F7813928: Screenshot_20191212_124651.png 

  F7813929: Screenshot_20191212_124701.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25917

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  What does it mean? Can this patch still go forward?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25916: [Notifications] Provide better feedback when copying a single file

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D25916

AFFECTED FILES
  libnotificationmanager/job_p.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25772: [Notifications] Add ServerInfo class

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:147debe3758f: [Notifications] Add ServerInfo class 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25772?vs=71345&id=71348

REVISION DETAIL
  https://phabricator.kde.org/D25772

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/serverinfo.cpp
  libnotificationmanager/serverinfo.h

To: broulik, #plasma, davidedmundson
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25772: [Notifications] Add ServerInfo class

[Kai Uwe Broulik]

broulik updated this revision to Diff 71345.
broulik added a comment.


  - Drop `Q_INVOKABLE`
  - Rename slot
  - Add missing `ServerInfo` file

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25772?vs=70976&id=71345

REVISION DETAIL
  https://phabricator.kde.org/D25772

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/serverinfo.cpp
  libnotificationmanager/serverinfo.h

To: broulik, #plasma
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=365318

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |FIXED

--- Comment #17 from Nate Graham  ---
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25915: Don't set a new palette if the application has a custom color scheme set

[David Redondo]

davidre created this revision.
davidre added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  If an application has explicitly set a custom color scheme we shouldn't change
  the palette when the global color scheme changes because it explicitly wants 
to
  use its custom one. For the same reason we already don't update the titlebar
  color to the global one if this property is set.

TEST PLAN
  Change colorscheme in kate or kcolorschemedemo and change change the global
  one in the colors kcm.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  customtheme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25915

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

[Nathaniel Graham]

ngraham updated this revision to Diff 71340.
ngraham added a comment.


  Add comment about the Qt situation

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25873?vs=71337&id=71340

BRANCH
  explanatory-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25873

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, Fuchs
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

[Nathaniel Graham]

ngraham updated this revision to Diff 71337.
ngraham added a comment.


  ...and elide

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25873?vs=71336&id=71337

BRANCH
  explanatory-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25873

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, Fuchs
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 309 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/309/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Dec 2019 09:54:08 +
 Build duration:
3 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 2656 lines...][2019-12-12T09:57:03.929Z] [ 47%] Linking CXX shared module ../../../../bin/org.kde.kdecoration2/kwin5_aurorae.so[2019-12-12T09:57:04.190Z] [ 47%] Built target kwin5_aurorae[2019-12-12T09:57:04.190Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/desktopgrid/desktopgrid.cpp.o[2019-12-12T09:57:05.593Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/diminactive/diminactive.cpp.o[2019-12-12T09:57:05.593Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/effect_builtins.cpp.o[2019-12-12T09:57:05.593Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/flipswitch/flipswitch.cpp.o[2019-12-12T09:57:05.593Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/glide/glide.cpp.o[2019-12-12T09:57:05.866Z] [ 47%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/invert/invert.cpp.o[2019-12-12T09:57:05.866Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/logging.cpp.o[2019-12-12T09:57:06.448Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/lookingglass/lookingglass.cpp.o[2019-12-12T09:57:06.448Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magiclamp/magiclamp.cpp.o[2019-12-12T09:57:07.011Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magnifier/magnifier.cpp.o[2019-12-12T09:57:07.011Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mouseclick/mouseclick.cpp.o[2019-12-12T09:57:07.267Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mousemark/mousemark.cpp.o[2019-12-12T09:57:07.525Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows.cpp.o[2019-12-12T09:57:07.804Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindows/presentwindows_proxy.cpp.o[2019-12-12T09:57:07.805Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/resize/resize.cpp.o[2019-12-12T09:57:08.077Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showfps/showfps.cpp.o[2019-12-12T09:57:08.077Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showpaint/showpaint.cpp.o[2019-12-12T09:57:08.697Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slide/slide.cpp.o[2019-12-12T09:57:09.281Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/thumbnailaside/thumbnailaside.cpp.o[2019-12-12T09:57:09.281Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/touchpoints/touchpoints.cpp.o[2019-12-12T09:57:09.281Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/trackmouse/trackmouse.cpp.o[2019-12-12T09:57:09.281Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/effects/presentwindows/presentwindows.cpp:1584:37: warning: 'desktop' is deprecated [-Wdeprecated-declarations][2019-12-12T09:57:09.281Z] desktop = activeWindow->desktop();[2019-12-12T09:57:09.281Z] ^[2019-12-12T09:57:09.281Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/libkwineffects/kwineffects.h:2177:17: note: 'desktop' has been explicitly marked deprecated here[2019-12-12T09:57:09.281Z] virtual int KWIN_DEPRECATED desktop() const = 0; // prefer isOnXXX()[2019-12-12T09:57:09.281Z] ^[2019-12-12T09:57:09.281Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/build/kwin_export.h:25:43: note: expanded from macro 'KWIN_DEPRECATED'[2019-12-12T09:57:09.281Z] #  define KWIN_DEPRECATED __attribute__ ((__deprecated__))[2019-12-12T09:57:09.281Z]   ^[2019-12-12T09:57:09.548Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/windowgeometry/windowgeometry.cpp.o[2019-12-12T09:57:09.861Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/wobblywindows/wobblywindows.cpp.o[2019-12-12T09:57:10.152Z] [ 48%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/zoom/zoom.cpp.o[2019-12-12T09:57:10.152Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/qrc_shaders.cpp.o[2019-12-12T09:57:10.439Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/blurconfig.cpp.o[2019-12-12T09:57:10.729Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/coverswitchconfig.cpp.o[2019-12-12T09:57:10.729Z] 1 warning generated.[2019-12-12T09:57:10.729Z] [ 49%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeconfig.cpp.o[2019-12-12T09:57:11.721Z

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

[Dimitar Petrovski]

https://bugs.kde.org/show_bug.cgi?id=365318

--- Comment #16 from Dimitar Petrovski  ---
I have tested the issue now, and I can not reproduce it, I guess it was fixed
during the years

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

[Nathaniel Graham]

ngraham updated this revision to Diff 71336.
ngraham marked an inline comment as done.
ngraham added a comment.


  Fill width

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25873?vs=71328&id=71336

BRANCH
  explanatory-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25873

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, Fuchs
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-integration » kf5-qt5 SUSEQt5.12 - Build # 35 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Dec 2019 09:41:47 +
 Build duration:
3 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)Name: projectroot.home.jenkins.workspace.Plasma.plasma-integration.kf5-qt5_SUSEQt512 Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.home.jenkins.workspace.Plasma.plasma-integration.kf5-qt5_SUSEQt512.autotests.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)78%
(21/27)78%
(21/27)62%
(1461/2363)42%
(571/1372)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(595/605)55%
(266/483)src.platformtheme81%
(13/16)81%
(13/16)53%
(866/1644)36%
(305/853)tests0%
(0/3)0%
(0/3)0%
(0/114)0%
(0/36)

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Dec 2019 09:41:48 +
 Build duration:
1 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 405 lines...][2019-12-12T09:43:19.295Z] [ 16%] Building CXX object autotests/CMakeFiles/kfiledialogqml_unittest.dir/kfiledialogqml_unittest.cpp.o[2019-12-12T09:43:19.946Z] [ 16%] Built target KDEPlasmaPlatformTheme_autogen[2019-12-12T09:43:20.260Z] [ 16%] Built target windowdecotest_autogen[2019-12-12T09:43:20.561Z] Scanning dependencies of target khintssettings_unittest[2019-12-12T09:43:20.561Z] [ 16%] Built target kfontsettingsdata_unittest_autogen[2019-12-12T09:43:20.829Z] [ 17%] Building CXX object autotests/CMakeFiles/khintssettings_unittest.dir/khintssettings_unittest_autogen/mocs_compilation.cpp.o[2019-12-12T09:43:20.829Z] [ 18%] Generating statusnotifierwatcher_interface.cpp, statusnotifierwatcher_interface.h[2019-12-12T09:43:20.829Z] [ 20%] Generating statusnotifierwatcher_interface.moc[2019-12-12T09:43:21.106Z] Scanning dependencies of target kdirselectdialog_unittest[2019-12-12T09:43:21.106Z] [ 21%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/kdirselectdialog_unittest_autogen/mocs_compilation.cpp.o[2019-12-12T09:43:21.106Z] [ 22%] Built target kfiledialog_unittest_autogen[2019-12-12T09:43:21.106Z] [ 22%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/kdirselectdialog_unittest.cpp.o[2019-12-12T09:43:21.106Z] [ 23%] Building CXX object autotests/CMakeFiles/khintssettings_unittest.dir/khintssettings_unittest.cpp.o[2019-12-12T09:43:21.376Z] Scanning dependencies of target kdeplatformsystemtrayicon_unittest[2019-12-12T09:43:21.668Z] [ 24%] Building CXX object autotests/CMakeFiles/kdeplatformsystemtrayicon_unittest.dir/kdeplatformsystemtrayicon_unittest_autogen/mocs_compilation.cpp.o[2019-12-12T09:43:21.963Z] [ 24%] Built target kdeplatformtheme_unittest_autogen[2019-12-12T09:43:21.963Z] Scanning dependencies of target ksni_unittest[2019-12-12T09:43:22.231Z] [ 25%] Building CXX object autotests/CMakeFiles/ksni_unittest.dir/ksni_unittest_autogen/mocs_compilation.cpp.o[2019-12-12T09:43:22.231Z] [ 27%] Building CXX object autotests/CMakeFiles/ksni_unittest.dir/ksni_unittest.cpp.o[2019-12-12T09:43:22.508Z] [ 28%] Building CXX object autotests/CMakeFiles/khintssettings_unittest.dir/__/src/platformtheme/khintssettings.cpp.o[2019-12-12T09:43:23.100Z] [ 29%] Building CXX object autotests/CMakeFiles/kdeplatformsystemtrayicon_unittest.dir/kdeplatformsystemtrayicon_unittest.cpp.o[2019-12-12T09:43:23.100Z] [ 30%] Linking CXX executable ../bin/kfiledialogqml_unittest[2019-12-12T09:43:23.362Z] [ 30%] Built target kfiledialogqml_unittest[2019-12-12T09:43:23.621Z] Scanning dependencies of target kfontsettingsdata_unittest[2019-12-12T09:43:23.621Z] [ 31%] Building CXX object autotests/CMakeFiles/kfontsettingsdata_unittest.dir/kfontsettingsdata_unittest_autogen/mocs_compilation.cpp.o[2019-12-12T09:43:23.892Z] [ 32%] Building CXX object autotests/CMakeFiles/kfontsettingsdata_unittest.dir/kfontsettingsdata_unittest.cpp.o[2019-12-12T09:43:24.526Z] [ 34%] Linking CXX executable ../bin/ksni_unittest[2019-12-12T09:43:24.812Z] [ 34%] Built target ksni_unittest[2019-12-12T09:43:24.812Z] [ 35%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kdeplatformfiledialogbase.cpp.o[2019-12-12T09:43:25.478Z] [ 36%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kdirselectdialog.cpp.o[2019-12-12T09:43:26.485Z] [ 37%] Linking CXX executable ../bin/khintssettings_unittest[2019-12-12T09:43:26.778Z] [ 38%] Building CXX object autotests/CMakeFiles/kdeplatformsystemtrayicon_unittest.dir/__/src/platformtheme/kdeplatformsystemtrayicon.cpp.o[2019-12-12T09:43:27.076Z] [ 38%] Built target khintssettings_unittest[2019-12-12T09:43:27.076Z] [ 40%] Building CXX object autotests/CMakeFiles/kdeplatformsystemtrayicon_unittest.dir/statusnotifierwatcher_interface.cpp.o[2019-12-12T09:43:29.372Z] [ 41%] Building CXX object autotests/CMakeFiles/kfontsettingsdata_unittest.dir/__/src/platformtheme/kfontsettingsdata.cpp.o[2019-12-12T09:43:29.372Z] [ 42%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kfiletreeview.cpp.o[2019-12-12T09:43:30.459Z] Scanning dependencies of target kfiledialog_unittest[2019-12-12T09:43:30.459Z] [ 43%] Building CXX object autotests/CMakeFiles/kfiledialog_unittest.dir/kfiledialog_unittest_autogen/mocs_compilation.cpp.o[2019-12-12T09:43:30.459Z] /usr/home/jenkins/workspace/Plasma/plasma-integration/kf5-qt5 FreeBSDQt5.13/src/platformtheme/kdirselectdialog.cpp:331:20: error: no member named 'setIconProvider' in 'KHistoryComboBox'[2019-12-12T09:43:30.459Z] d->m_urlCombo->setIconProvider([](const QString &name) {[2019-12-12T09:43:30.459Z] ~~

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 26 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/26/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Dec 2019 09:41:56 +
 Build duration:
1 min 51 sec and counting
   CONSOLE OUTPUT
  [...truncated 271 lines...][2019-12-12T09:43:37.316Z] BUILD_ID  = '26'[2019-12-12T09:43:37.316Z] LESSKEY   = '/etc/lesskey.bin'[2019-12-12T09:43:37.316Z] OLDPWD= '/home/jenkins'[2019-12-12T09:43:37.316Z] LC_CTYPE  = 'C.UTF-8'[2019-12-12T09:43:37.316Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-12-12T09:43:37.316Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-12-12T09:43:37.316Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-12-12T09:43:37.316Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-12-12T09:43:37.316Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-12-12T09:43:37.316Z] QT_SELECT = 'qt5'[2019-12-12T09:43:37.316Z] LANG  = 'en_US.UTF-8'[2019-12-12T09:43:37.316Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-12-12T09:43:37.316Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-12-12T09:43:37.316Z] [2019-12-12T09:43:37.316Z] [2019-12-12T09:43:37.316Z] == Commencing Configuration:[2019-12-12T09:43:37.316Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12"[2019-12-12T09:43:39.863Z] -- The C compiler identification is GNU 9.2.1[2019-12-12T09:43:41.279Z] -- The CXX compiler identification is GNU 9.2.1[2019-12-12T09:43:41.606Z] -- Check for working C compiler: /usr/bin/cc[2019-12-12T09:43:41.606Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-12-12T09:43:41.606Z] -- Detecting C compiler ABI info[2019-12-12T09:43:41.923Z] -- Detecting C compiler ABI info - done[2019-12-12T09:43:41.923Z] -- Detecting C compile features[2019-12-12T09:43:41.923Z] -- Detecting C compile features - done[2019-12-12T09:43:41.923Z] -- Check for working CXX compiler: /usr/bin/c++[2019-12-12T09:43:42.214Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-12-12T09:43:42.214Z] -- Detecting CXX compiler ABI info[2019-12-12T09:43:42.498Z] -- Detecting CXX compiler ABI info - done[2019-12-12T09:43:42.498Z] -- Detecting CXX compile features[2019-12-12T09:43:42.498Z] -- Detecting CXX compile features - done[2019-12-12T09:43:42.498Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for kgamma.[2019-12-12T09:43:42.776Z] -- Looking for __GLIBC__[2019-12-12T09:43:43.044Z] -- Looking for __GLIBC__ - found[2019-12-12T09:43:43.044Z] -- Performing Test _OFFT_IS_64BIT[2019-12-12T09:43:43.307Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-12-12T09:43:43.307Z] -- Performing Test HAVE_DATE_TIME[2019-12-12T09:43:43.564Z] -- Performing Test HAVE_DATE_TIME - Success[2019-12-12T09:43:43.564Z] -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.65.0") [2019-12-12T09:43:43.564Z] -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.65.0") [2019-12-12T09:43:43.564Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.65.0") [2019-12-12T09:43:43.823Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2019-12-12T09:43:43.823Z] -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.65.0") [2019-12-12T09:43:43.823Z] -- Found KF5: success (found suitable version "5.65.0", minimum required is "5.62.0") found components:  Config ConfigWidgets DocTools I18n [2019-12-12T09:43:44.083Z] -- Found X11: /usr/include   [2019-12-12T09:43:44.083Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so[2019-12-12T09:43:44.347Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found[2019-12-12T09:43:44.347Z] -- Looking for gethostbyname[2019-12-12T09:43:44.605Z] -- Looking for gethostbyname - found[2019-12-12T09:43:44.605Z] -- Looking for connect[2019-12-12T09:43:44.864Z] -- Looking for connect - found[2019-12-12T09:43:44.864Z] -- Looking for remove[2019-12-12T09:43:44.864Z] -- Looking for remove - found[2019-12-12T09:43:44.864Z] -- Looking for shmat[2019-12-12T09:43:45.123Z] -- Looking for shmat - found[2019-12-12T09:43:45.123Z] -- Looking for IceConnectionNumber in ICE[2019-12-12T09:43:45.123Z

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

[David Edmundson]

davidedmundson added a comment.


  It's not a common pattern we do in plasma currently, but that doesn't 
necessarily mean we shouldn't use it.

INLINE COMMENTS

> main.qml:131
>  
> +QQC2.Label {
> +text: singleClick.checked ? i18n("Select by clicking on item's 
> selection marker") : i18n("Select by single-clicking")

For almost all lablels:

Layout.fillWidth: true

either elide or wrap

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25873

To: ngraham, #vdg, #plasma, Fuchs
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25449: Start of the new Formats KCM

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Like the other ones, please use name and key in the entry elements of your 
kcfg files.

INLINE COMMENTS

> kcm.cpp:33
> +
> +Formats::Formats(QObject* parent, const QVariantList& args)
> +: KQuickAddons::ManagedConfigModule(parent, args)

Ditto

> kcm.cpp:41
> +
> +KAboutData* about = new KAboutData(
> +QStringLiteral("kcm_formats"), i18n("Formats Configuration Module"),

Ditto, beside could be auto

> kcm.cpp:107
> +{
> +// I don't know how to do this `save` within the KConfigXT
> +auto config = KConfigGroup(KSharedConfig::openConfig("plasma-localerc"), 
> "Formats");

Overriding usrSave in the settings object perhaps?

> kcm.cpp:161
> +}
> +#include "kcm.moc"

Missing an empty line before this one.

> kcm.h:38
> +public:
> +Formats(QObject* parent, const QVariantList& args);
> +virtual ~Formats() override;

Space before * and & not after

> localemodel.cpp:15
> +// Ensure that the "Default (C)" locale always appears at the top
> +if (c1.name()== QLatin1Char('C') && c2.name()!=QLatin1String("C")) 
> return true;
> +if (c2.name()== QLatin1Char('C')) return false;

Missing spaces around !=

> localemodel.cpp:16
> +if (c1.name()== QLatin1Char('C') && c2.name()!=QLatin1String("C")) 
> return true;
> +if (c2.name()== QLatin1Char('C')) return false;
> +

Missing space before ==

> localemodel.cpp:36
> +
> +QString getCountryLocale(const QString& localeName)
> +{

Space before & and not after

> localemodel.cpp:51
> +
> +QString getFlagCode(const QString& localeName)
> +{

Ditto

> localemodel.cpp:62
> +
> +LocaleModel::LocaleModel(QObject* parent)
> +{

Ditto

> localemodel.cpp:69
> +
> +for(auto locale : allLocales) {
> +const QString clabel = !locale.nativeCountryName().isEmpty() ? 
> locale.nativeCountryName() : QLocale::countryToString(locale.country());

for (const auto &localbe: qAsConst(allLocales))

> localemodel.cpp:83
> +
> +int LocaleModel::rowCount(const QModelIndex& parent) const
> +{

Space before & not after

> localemodel.cpp:89
> +
> +QVariant LocaleModel::data(const QModelIndex& idx, int role) const
> +{

Ditto

> localemodel.cpp:104
> +
> +int LocaleModel::indexFor(const QString& value) const
> +{

Ditto

> localemodel.cpp:106
> +{
> +for(int i = 0; i < m_data.size(); i++) {
> +if (m_data.at(i).localeValue == value) {

This sounds like a std::find_if

> localemodel.cpp:121
> +{
> +return QHash ({
> +{ Flag, "flag" },

You could just have return { here

> main.qml:34
> +
> +QQC2.ComboBox {
> +Kirigami.FormData.label: i18n("Region")

Shouldn't controls be deactivated based on the keys mutability here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava, ervin
Cc: ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25838: [Applets/Kickoff] Show apps by their real names on top by default

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9e708f955711: [Applets/Kickoff] Show apps by their real 
names on top by default (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25838?vs=71168&id=71334

REVISION DETAIL
  https://phabricator.kde.org/D25838

AFFECTED FILES
  applets/kickoff/package/contents/config/main.xml

To: ngraham, #vdg, #plasma, ndavis
Cc: meven, ndavis, michaeltunnell, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25838: [Applets/Kickoff] Show apps by their real names on top by default

[Méven Car]

meven added a comment.


  In D25838#574655 , @ndavis wrote:
  
  > I agree with this.
  
  
  Me too, nice consistency win

REPOSITORY
  R119 Plasma Desktop

BRANCH
  show-apps-by-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25838

To: ngraham, #vdg, #plasma, ndavis
Cc: meven, ndavis, michaeltunnell, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.


  I think we discussed this already, but I'm not sure so before it gets lost... 
:-)
  
  Please consider using both key and name for your kcfg items, this allows to 
both respect the past storage format and provide nicer property names on the 
C++/QML side. Currently the storage used names are leaking to the internal API.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra