D26069: Fix usage of deprecated QSet/QList methods

2019-12-17 Thread Alexey Min
alexeymin updated this revision to Diff 71749.
alexeymin added a comment.


  I feel sad doing such things

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26069?vs=71748=71749

BRANCH
  arcpatch-D26069

REVISION DETAIL
  https://phabricator.kde.org/D26069

AFFECTED FILES
  libdiscover/resources/StandardBackendUpdater.cpp

To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D26069: Fix usage of deprecated QSet/QList methods

2019-12-17 Thread Alexey Min
alexeymin updated this revision to Diff 71748.
alexeymin added a comment.


  Add QT_VERSION_CHECK checks

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26069?vs=71731=71748

BRANCH
  arcpatch-D26069

REVISION DETAIL
  https://phabricator.kde.org/D26069

AFFECTED FILES
  libdiscover/resources/StandardBackendUpdater.cpp

To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D26069: Fix usage of deprecated QSet/QList methods

2019-12-17 Thread Alexey Min
alexeymin added a comment.


  No :( just checked, Qt 5.12's 
https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qset.h?h=v5.12.0 
is missing `inline QSet(InputIterator first, InputIterator last)`, which 
appeared only in 5.14.
  
  I guess I need an `#ifdef` for QSet construction then.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26069

To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D26072: Port away from KIconThemes

2019-12-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R128:39ce0e82856e: Port away from KIconThemes (authored by 
vkrause).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26072?vs=71738=71745

REVISION DETAIL
  https://phabricator.kde.org/D26072

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/accountinfo.cpp
  src/lib/accountmodel.cpp
  src/usermanager.cpp

To: vkrause, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26035: battery: Improve the brightness responsiveness

2019-12-17 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 71743.
apol added a comment.


  Use a more meaningful step size for the screen. Having steps of 1 in a 1 to 
7000 slider was awkward.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26035?vs=71643=71743

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26035

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js
  dataengines/powermanagement/powermanagementjob.cpp
  dataengines/powermanagement/powermanagementjob.h

To: apol, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25945: Sync dark theme preference for GTK3 applications

2019-12-17 Thread Björn Feber
GB_2 added a comment.


  In D25945#577731 , @gikari wrote:
  
  > In D25945#577677 , @cblack wrote:
  >
  > > For flatpaks not respecting the setting preference, have you checked that 
the dark theme variant is installed?
  >
  >
  > Yes, I have installed the theme. But after changing the value in gtk 
configs nothing happens. It could also be the result of my local setup bugs 
(because as the @GB_2 said, the patch works for him flawlessly). So I think he 
(or someone else) should test it.
  >
  > There is a bug  about flatpak 
not using selected GTK theme on X11. It is because it can only be done by 
letting the xsettingd to control the theme of the flatpak app. So, to test 
dark-theme preference sync you need to add to the 
`~/.config/xsettingsd/xsettingsd.conf` this line:
  >
  >   Net/ThemeName "Adwaita"
  >
  >
  > check the dark theme preference checkbox in old GTK KCM and then relaunch 
xsettingsd. The flatpak app should be dark.
  
  
  No, looks like there is no way to make this option work for Flatpak apps, 
because it can't be set with xsettingsd.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  sync-dark-gtk3-theme-preference (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25945

To: gikari, apol, cblack, broulik, #vdg
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26069: Fix usage of deprecated QSet/QList methods

2019-12-17 Thread Aleix Pol Gonzalez
apol added a comment.


  Will all of this build on Qt 5.12?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26069

To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2

2019-12-17 Thread Carl Schwan
ognarb added a comment.


  Thanks for the review :) I will create a follow up patch with the ComboBox 
port when I figure that is going wrong with my desktop theme.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma, davidedmundson
Cc: davidedmundson, GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2

2019-12-17 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes.
Closed by commit R118:3e0877c9c99d: refactor(lookandfeelexplorer): Port almost 
entire look and feel explorer to QQC2 (authored by ognarb).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25778?vs=71733=71739

REVISION DETAIL
  https://phabricator.kde.org/D25778

AFFECTED FILES
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml

To: ognarb, #vdg, #plasma, davidedmundson
Cc: davidedmundson, GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D26072: Port away from KIconThemes

2019-12-17 Thread Volker Krause
vkrause created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This was only using the deprecated IconSize() method.

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26072

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/accountinfo.cpp
  src/lib/accountmodel.cpp
  src/usermanager.cpp

To: vkrause
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

2019-12-17 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > 60: StylePrivate.PropertyWriter is not a type
  
  Sounds like you just had your QQC2 style broken.
  
  In any case, this code all looks fine.
  Better to have to port one little combobox in our own time later, than have 
to deal with regressions.

REPOSITORY
  R118 Plasma SDK

BRANCH
  arcpatch-D25778

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma, davidedmundson
Cc: davidedmundson, GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D26065: [KCM/Access] Port to use KConfigXT

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71734.
meven marked 12 inline comments as done.
meven added a comment.


  Address review

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26065?vs=71719=71734

BRANCH
  kaccess-kconfigxt

REVISION DETAIL
  https://phabricator.kde.org/D26065

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/kaccess_settings.kcfg
  kcms/access/kaccess_settings.kcfgc
  kcms/access/kcmaccess.cpp

To: meven, ervin, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

2019-12-17 Thread Carl Schwan
ognarb updated this revision to Diff 71733.
ognarb marked 2 inline comments as done.
ognarb added a comment.


  - fix naming

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25778?vs=71732=71733

BRANCH
  arcpatch-D25778

REVISION DETAIL
  https://phabricator.kde.org/D25778

AFFECTED FILES
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml

To: ognarb, #vdg, #plasma
Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26039: [Plasma Style KCM] Add search filter

2019-12-17 Thread Noah Davis
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Visually LGTM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

2019-12-17 Thread Carl Schwan
ognarb added inline comments.

INLINE COMMENTS

> guoyunhe wrote in MetadataEditor.qml:108
> This need to be changed to `QQC2.ComboBox`

I tried but I get

  Type QQC2.ComboBox unavailable
  60: StylePrivate.PropertyWriter is not a type

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma
Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

2019-12-17 Thread Carl Schwan
ognarb updated this revision to Diff 71732.
ognarb marked 2 inline comments as done.
ognarb added a comment.


  - Use same button width as for the text field
  - Fix dialog not closing
  - Improve margin

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25778?vs=70999=71732

BRANCH
  arcpatch-D25778

REVISION DETAIL
  https://phabricator.kde.org/D25778

AFFECTED FILES
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml

To: ognarb, #vdg, #plasma
Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26049: [KCM/NightColor] Allow the user to know the default settings are selected

2019-12-17 Thread Roman Gilg
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Maybe someone besides me who worked more recently on the 
KCM wants to give his ok as well. If nothing comes in till tomorrow, push. 
Thanks.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  nightcolor-default

REVISION DETAIL
  https://phabricator.kde.org/D26049

To: meven, #kwin, crossi, ervin, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26069: Fix usage of deprecated QSet/QList methods

2019-12-17 Thread Alexey Min
alexeymin created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexeymin requested review of this revision.

REVISION SUMMARY
  COmpiiling with Qt 5.14 produces the following warnings:
  
  .../libdiscover/resources/StandardBackendUpdater.cpp:70:43: warning:
  
‘QList QSet::toList() const [with T = AbstractResource*]’ is 
deprecated:
Use values() instead. [-Wdeprecated-declarations]
  
  .../libdiscover/resources/StandardBackendUpdater.cpp:220:48: warning:
  
‘QSet QList::toSet() const [with T = AbstractResource*]’ is 
deprecated:
Use QSet(list.begin(), list.end()) instead. [-Wdeprecated-declarations]

TEST PLAN
  clean build with Qt 5.14 with no warnings

REPOSITORY
  R134 Discover Software Store

BRANCH
  alexeymin/fix-deprecation-warnings

REVISION DETAIL
  https://phabricator.kde.org/D26069

AFFECTED FILES
  libdiscover/resources/StandardBackendUpdater.cpp

To: alexeymin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26049: [KCM/NightColor] Allow the user to know the default settings are selected

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71730.
meven marked 2 inline comments as done.
meven added a comment.


  Fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26049?vs=71725=71730

BRANCH
  nightcolor-default

REVISION DETAIL
  https://phabricator.kde.org/D26049

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: meven, #kwin, crossi, ervin, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26065: [KCM/Access] Port to use KConfigXT

2019-12-17 Thread Kai Uwe Broulik
broulik added a comment.


  I read kaccess.cpp and commented on where the defaults diverge, there could 
be more. There's also some keys that have typos and/or don't match.
  This shows quite impressively why having this stuff in a central place is 
useful :)
  Given kaccess.cpp is what does the handling, ultimately its defaults will be 
what is being used, not the ones in the KCM.

INLINE COMMENTS

> kaccess_settings.kcfg:13
> +
> +
> +  Whether or not to use a custom bell

lol

Can you give this a better name, like "customBell"

(Arts was the KDE 3 sound server)

> kaccess_settings.kcfg:17
> +
> +
> +  The custom bell sound file

Likewise, customBellFile

> kaccess_settings.kcfg:46
> +
> +  Lock sticked keys
> +  true

"stickied" is not a word but I can see that "stuck" implies something else

> kaccess_settings.kcfg:55
> +  Send a system bell notification when sticky keys are enabled or 
> disabled
> +  true
> +

The default is `false`

> kaccess_settings.kcfg:61
> +
> +
> +  Send a plasma notification when a lock key or sticky keys state 
> changes

"key" or whatever that k stands for?

> kaccess_settings.kcfg:76
> +  Use system bell when a key is pressed
> +  true
> +

The default is `false`

> kaccess_settings.kcfg:80
> +  Use system bell when a key is accepted
> +  true
> +

The default is `false`

> kaccess_settings.kcfg:84
> +  Use system bell when a key is rejected
> +  true
> +

The default is `false`

> kaccess_settings.kcfg:97
> +  Use system bell when a bounced key is rejected
> +  true
> +

BounceKeysRejectBeep

> kaccess_settings.kcfg:121
> +
> +
> +  Send a plasma notification when a keyboard accessbility feature 
> is enabled or disabled

There is only `kNotifyAccessX` (note the X)

> kaccess_settings.kcfg:142
> +
> +  1000
> +

This is actually being calculated referencing "interal" in kaccess code:

  mouseGroup.readEntry("MKTimeToMax", (5000 + interval / 2) / interval);

> kaccess_settings.kcfg:144
> +
> +
> +  5000

The key is `MKTimeToMax`

> kaccess_settings.kcfg:148
> +
> +  1000
> +

Defaults to `interval`

> kaccess_settings.kcfg:155
> +
> +  Acceleration profil
> +  0

profil*e*

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26065

To: meven, ervin, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71729.
meven added a comment.


  Ensure the black list opt-in checkbox change apply button state

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=71728=71729

BRANCH
  activity_kcm

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26049: [KCM/NightColor] Allow the user to know the default settings are selected

2019-12-17 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> romangg wrote in main.qml:65
> What is this supposed to do?

Disable the restore default button

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26049

To: meven, #kwin, crossi, ervin, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-17 Thread Méven Car
meven created this revision.
meven added reviewers: Plasma, ervin, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  kcmshell5 kcm_activities
  Changed settings, restored defaults

REPOSITORY
  R119 Plasma Desktop

BRANCH
  activity_kcm

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25874: [Task Manager] Consider parent PID for audio stream

2019-12-17 Thread Kai Uwe Broulik
broulik added a comment.


  I have not. Given a browser window typically has dozens of children whereas 
you typically have few audio streams, I think if any it will be slower.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25874

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25874: [Task Manager] Consider parent PID for audio stream

2019-12-17 Thread Eike Hein
hein added a comment.


  Just as a sanity check: libtm knows the pid for a window. Have you checked if 
there might be a faster way of doing this by checking if the stream pid is 
among its children?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25874

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25762: Don't bother serializing window icon pixmap for known services

2019-12-17 Thread Kai Uwe Broulik
broulik planned changes to this revision.
broulik added a comment.


  > That means you can limit serializing to cases where the window is in 
usingFallbackIcon.
  
  Good idea, I'll give it a try.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25762

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25762: Don't bother serializing window icon pixmap for known services

2019-12-17 Thread Eike Hein
hein added a comment.


  Ah right, I didn't look at the code context and forgot we don't just load the 
custom pixmap in the same function body but also in Private::icon. But we also 
do this there:
  
  `usingFallbackIcon.insert(window)`
  
  That means you can limit serializing to cases where the window is in 
`usingFallbackIcon`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25762

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26049: [KCM/NightColor] Allow the user to know the default settings are selected

2019-12-17 Thread Roman Gilg
romangg added inline comments.

INLINE COMMENTS

> main.qml:65
> +} else {
> +cA.nightColorAvailable = true;
> +}

What is this supposed to do?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26049

To: meven, #kwin, crossi, ervin, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25580: [System Tray] Unified data model for System Tray items

2019-12-17 Thread Konrad Materka
kmaterka added a comment.


  In D25580#578732 , @trmdi wrote:
  
  > Please make sure it would not bring this bug back: 
https://phabricator.kde.org/R120:6fcf9a5e03ba573fd0bfe30125f4c739b196a989
  
  
  I double checked that. If I understand correctly the root cause of BUG 393630 
was the use of `plasmoid.rootItem` - it is not introduced again.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25580

To: kmaterka, #plasma, broulik, ngraham, nicolasfella
Cc: trmdi, plasma-devel, nicolasfella, anthonyfieroni, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D26049: [KCM/NightColor] Allow the user to know the default settings are selected

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71725.
meven added a comment.


  Mark state as default when nightcolor is not available

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26049?vs=71715=71725

BRANCH
  nightcolor-default

REVISION DETAIL
  https://phabricator.kde.org/D26049

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: meven, #kwin, crossi, ervin, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

2019-12-17 Thread Björn Feber
GB_2 added a comment.


  Ping.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma
Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26039: [Plasma Style KCM] Add search filter

2019-12-17 Thread David Redondo
davidre updated this revision to Diff 71724.
davidre added a comment.


  I think this signal is not needed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71723=71724

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26039: [Plasma Style KCM] Add search filter

2019-12-17 Thread David Redondo
davidre updated this revision to Diff 71723.
davidre added a comment.


  Don't have a overly long line

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71722=71723

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26039: [Plasma Style KCM] Add search filter

2019-12-17 Thread David Redondo
davidre updated this revision to Diff 71722.
davidre marked an inline comment as done.
davidre added a comment.


  - better string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71721=71722

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26039: [Plasma Style KCM] Add search filter

2019-12-17 Thread David Redondo
davidre updated this revision to Diff 71721.
davidre added a comment.


  Diff against master

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71720=71721

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26039: [Plasma Style KCM] Add search filter

2019-12-17 Thread David Redondo
davidre updated this revision to Diff 71720.
davidre marked 2 inline comments as done.
davidre added a comment.


  - Reinstate isSaveNeeded
  - Fix initial index and pendingDeletion

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71654=71720

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  applets/icontasks/metadata.desktop
  applets/kicker/package/metadata.desktop
  applets/kickoff/package/contents/config/main.xml
  applets/kickoff/package/contents/ui/Header.qml
  applets/kimpanel/backend/ibus/CMakeLists.txt
  applets/kimpanel/backend/ibus/README
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/ibus15/README
  applets/kimpanel/backend/ibus/ibus15/panel.cpp
  applets/minimizeall/package/metadata.desktop
  applets/showActivityManager/package/metadata.desktop
  applets/showdesktop/package/metadata.desktop
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/window-list/metadata.desktop
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/ConfigOverlay.qml
  kaccess/kaccess.notifyrc
  kcms/access/kcmaccess.desktop
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/autostart/autostart.desktop
  kcms/baloo/kcm_baloofile.desktop
  kcms/baloo/package/metadata.desktop
  kcms/componentchooser/EXAMPLE.desktop
  kcms/componentchooser/componentchooser.desktop
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h
  kcms/icons/main.cpp
  kcms/kfontinst/dbus/fontinst.actions
  kcms/launch/launchfeedback.cpp
  kcms/launch/launchfeedback.h
  kcms/launch/launchfeedbacksettings.kcfgc
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/metadata.desktop
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/nightcolor/kcm_nightcolor.desktop
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml
  kcms/nightcolor/package/metadata.desktop
  kcms/notifications/package/contents/ui/main.qml
  kcms/solid_actions/device-actions/solid-device-Battery.desktop
  kcms/spellchecking/spellchecking.desktop
  kcms/style/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc
  org.kde.plasmashell.metainfo.xml
  toolboxes/desktoptoolbox/metadata.desktop
  toolboxes/paneltoolbox/metadata.desktop
  toolboxes/plasma-toolbox-paneltoolbox.desktop

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26065: [KCM/Access] Port to use KConfigXT

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71719.
meven added a comment.


  Fix some default values

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26065?vs=71716=71719

BRANCH
  kaccess-kconfigxt

REVISION DETAIL
  https://phabricator.kde.org/D26065

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/kaccess_settings.kcfg
  kcms/access/kaccess_settings.kcfgc
  kcms/access/kcmaccess.cpp

To: meven, ervin, #plasma, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26031: feat: access outputs controls through config control

2019-12-17 Thread Roman Gilg
romangg added a comment.


  In D26031#579232 , @davidedmundson 
wrote:
  
  > Why do we need to compare names as well as ID?
  
  
  The id is the output hash which can be either calculated from its name or 
edid. If you have two of the same output models that have the same edid you 
can't distinguish them. The name contains the port the output is connected with.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26031

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26031: feat: access outputs controls through config control

2019-12-17 Thread David Edmundson
davidedmundson added a comment.


  Why do we need to compare names as well as ID?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26031

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26065: [KCM/Access] Port to use KConfigXT

2019-12-17 Thread Méven Car
meven created this revision.
meven added reviewers: ervin, Plasma, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  Tested changing settings

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kaccess-kconfigxt

REVISION DETAIL
  https://phabricator.kde.org/D26065

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/kaccess_settings.kcfg
  kcms/access/kaccess_settings.kcfgc
  kcms/access/kcmaccess.cpp

To: meven, ervin, #plasma, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26039: [Plasma Style KCM] Add search filter

2019-12-17 Thread David Redondo
davidre added a comment.


  In D26039#579200 , @crossi wrote:
  
  > Some concern here as I tested the patch. The filter is working but the 
implementation breaks some functionality.
  >
  > - At initialization, the current theme is not selected in the grid view.
  > - When settings a theme for deletion, it does not activate the apply button 
and the theme is no longer greyed out in the grid view.
  
  
  Curious every issue you describe works for me. It would surprise me because 
the relevant code should be copied as is from the colors kcm.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26049: [KCM/NightColor] Allow the user to know the default settings are selected

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71715.
meven added a comment.


  clean up diff

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26049?vs=71714=71715

BRANCH
  nightcolor-default

REVISION DETAIL
  https://phabricator.kde.org/D26049

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: meven, #kwin, crossi, ervin, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-17 Thread Björn Feber
GB_2 added a comment.


  Ping :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, ndavis
Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26049: [KCM/NightColor] Allow the user to know the default settings are selected

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71714.
meven added a comment.


  [KCM/Access] Port to use KConfigXT

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26049?vs=71678=71714

BRANCH
  kaccess-kconfigxt

REVISION DETAIL
  https://phabricator.kde.org/D26049

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/kaccess_settings.kcfg
  kcms/access/kaccess_settings.kcfgc
  kcms/access/kcmaccess.cpp
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: meven, #kwin, crossi, ervin, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26039: [Plasma Style KCM] Add search filter

2019-12-17 Thread Cyril Rossi
crossi added a comment.


  Some concern here as I tested the patch. The filter is working but the 
implementation breaks some functionality.
  
  - At initialization, the current theme is not selected in the grid view.
  - When settings a theme for deletion, it does not activate the apply button 
and the theme is no longer greyed out in the grid view.

INLINE COMMENTS

> kcm.cpp:72
> +
> +connect(m_model, ::pendingDeletionsChanged, this, [this] {
> +setNeedsSave(true);

Should connect to KCMDesktopTheme::settingsChanged slot to request 
ManagedConfigModule to reassess isSaveNeeded().

> kcm.cpp:313
>  
> -bool KCMDesktopTheme::isSaveNeeded() const
> -{

Why removing this ?

It is necessary for ManagedConfigModule to enable the apply button when items 
are marked for deletion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik
Cc: ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26063: QMultiHash::insertMulti is deprecated. Use directly ::insert

2019-12-17 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:3f2fab734574: QMultiHash::insertMulti is deprecated. Use 
directly ::insert (authored by mlaurent).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26063?vs=71700=71713

REVISION DETAIL
  https://phabricator.kde.org/D26063

AFFECTED FILES
  processui/ProcessModel.cpp

To: mlaurent, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

2019-12-17 Thread Dan Leinir Turthra Jensen
leinir added a comment.


  In D25961#578727 , @zachus wrote:
  
  > is there a server out there to run it against?
  
  
  The provider file points it at the opendesktop.org server (that is to say, 
the KDE Store), so testing can be done against the live servers that already 
provide all our content :)
  
  Note also that the current client id and secret means you will be told that 
Bhushan Shah is asking for access to your things during sign-in - this is 
because that's who asked for test access in order to build this, so don't 
worry, that's currently expected. Before merging, it'll want to be swapped out 
for a more proper id, though we'll probably want to give this some thought - do 
we want one default for all of KDE's software, do we want one that can be 
replaced by distributions, or do we want distributions to have to do this? i'm 
currently unsure, but leaning towards option two (meaning, ship with a default 
id and secret set, but offer the ability for distributions and app developers 
to swap this out with one of their own).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25961

To: leinir
Cc: zachus, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26056: [dataengine/geolocation] Add logging category

2019-12-17 Thread Méven Car
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:523ef71c8790: [dataengine/geolocation] Add logging 
category (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26056?vs=71710=71711

REVISION DETAIL
  https://phabricator.kde.org/D26056

AFFECTED FILES
  dataengines/geolocation/CMakeLists.txt
  dataengines/geolocation/location_gps.cpp
  plasma-workspace.categories

To: meven, apol, #plasma, crossi, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26056: [dataengine/geolocation] Add logging category

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71710.
meven added a comment.


  Use qCDebug/qCWarning instead of qDebug/qWarning

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26056?vs=71704=71710

BRANCH
  arcpatch-D26056

REVISION DETAIL
  https://phabricator.kde.org/D26056

AFFECTED FILES
  dataengines/geolocation/CMakeLists.txt
  dataengines/geolocation/location_gps.cpp
  plasma-workspace.categories

To: meven, apol, #plasma, crossi, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25539: feat(kcm): add revert timer

2019-12-17 Thread Kai Uwe Broulik
broulik added a comment.


  > With direct-apply having a revert window/overlay/inline message only shown 
when certain critical options were changed could be a good compromise.
  
  It needs to be made absolute sure, though, that the keyboard focus is 
correct, so hitting e.g. Return will undo it, which iirc is the main point of 
having a modal dialog instead of an inline thing.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25539: feat(kcm): add revert timer

2019-12-17 Thread Roman Gilg
romangg added a comment.


  With direct-apply having a revert window/overlay/inline message only shown 
when certain critical options were changed could be a good compromise. Though I 
would still like to see direct-apply land first in this case and then we can 
look into when and how the revert functionality should hook into.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26042: Captive portal notification improvements

2019-12-17 Thread David Edmundson
davidedmundson added a comment.


  Due to a confusing design notification objects can delete themselves.
  
  If the network changes after the notification is externally closed this will 
crash.

INLINE COMMENTS

> portalmonitor.h:42
> +private:
> +KNotification *m_notification = nullptr;
>  };

Needs to be QPointer

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26042

To: jgrulich, ngraham, broulik, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25762: Don't bother serializing window icon pixmap for known services

2019-12-17 Thread Kai Uwe Broulik
broulik added a comment.


  > why don't we just change the check to QIcon::isNull?
  
  We still want to serialize custom pixmap data icons which won't be null.
  What we want to do is tell between "icon on disk" and "icon from pixmap data" 
which we can't really at the moment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25762

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-17 Thread David Redondo
davidre added a comment.


  In D25807#579144 , @trmdi wrote:
  
  > In D25807#579125 , @davidre 
wrote:
  >
  > > I have a question about naming. If I had an application like panel or 
latte I would call setAvailableScreenRect? That seems kinda backwards to me? 
That part of the screen is not available isn't  it but rather not available 
anymore? Maybe I'm understanding the approach taken here wrong?
  >
  >
  > availableScreenRect = screen_geometry - panels
  >
  > 
https://api.kde.org/frameworks/plasma-framework/html/classPlasma_1_1Corona.html#ad8ffd115128a128efd830540eeba5dd1
  >
  > The approach here is we have availablescreenrect of plasmashell, then latte 
send another one. The final result is the intersection of all 
availablescreenrects.
  
  
  Thanks for the explanation! That makes it clearer to me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26056: [dataengine/geolocation] Add logging category

2019-12-17 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> location_gps.cpp:98
>  } else {
> -qDebug() << "gpsd not found";
> +qWarning(DATAENGINE_GEOLOCATION) << "gpsd not found";
>  }

Change to qCWarning

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26056

REVISION DETAIL
  https://phabricator.kde.org/D26056

To: meven, apol, #plasma, crossi, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26041: Move applet configuration to KCM

2019-12-17 Thread Jan Grulich
jgrulich marked 10 inline comments as done.
jgrulich added inline comments.

INLINE COMMENTS

> ngraham wrote in ConfigurationDialog.qml:55
> this shouldn't need to be in `Component.onCompleted:`; just set `checked` 
> directly as a binding: `checked: configuration.unlockModemOnDetection`

I did it this way, because if I use checked: foo, then it reports warning about 
non-NOTIFYable property.

> ngraham wrote in main.qml:205
> Use the attached ToolTip property instead of creating a whole object; it's 
> lighter that way

I tried, doesn't seem to work. I followed the example from 
https://doc-snapshots.qt.io/qt5-5.12/qml-qtquick-controls2-tooltip.html and it 
says there is no such attached property.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26041

To: jgrulich, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26041: Move applet configuration to KCM

2019-12-17 Thread Jan Grulich
jgrulich updated this revision to Diff 71707.
jgrulich added a comment.


  Fix review comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26041?vs=71657=71707

BRANCH
  kcm-config

REVISION DETAIL
  https://phabricator.kde.org/D26041

AFFECTED FILES
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  kcm/CMakeLists.txt
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml

To: jgrulich, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25762: Don't bother serializing window icon pixmap for known services

2019-12-17 Thread Eike Hein
hein added a comment.


  If the concern is that QIcon::name isn't good enough but we actually have an 
icon inside, why don't we just change the check to QIcon::isNull?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25762

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26042: Captive portal notification improvements

2019-12-17 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1ffef126b8f0: Captive portal notification improvements 
(authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26042?vs=71660=71706

REVISION DETAIL
  https://phabricator.kde.org/D26042

AFFECTED FILES
  kded/portalmonitor.cpp
  kded/portalmonitor.h

To: jgrulich, ngraham, broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


kquickcharts should be added to plasma-workspace as dependency

2019-12-17 Thread Konrad Materka
Hi,

I found that plasma-workspace (notification applet) requires KQuickCharts,
but it is not added as a dependency in kdesrc-build. As a result I've got
this error:
file:///home/user/kde/usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/main.qml:96:37:
Type CompactRepresentation unavailable

file:///home/user/kde/usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/CompactRepresentation.qml:27:1:
module "org.kde.quickcharts" is not installed

-- 
Regards:
Konrad Materka


D26045: Add immutability to KCM Icons

2019-12-17 Thread Cyril Rossi
crossi added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:55
> Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff 
> Marco fixed a while back?

Yes it should.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-17 Thread Cyril Rossi
crossi added inline comments.

INLINE COMMENTS

> kcmcursortheme.cpp:367
>  {
>  m_settings->save();
> +setPreferredSize(m_settings->cursorSize());

Now you should simply call ManagedConfigModule::save(); instead

> kcmcursortheme.cpp:384
>  {
>  m_settings->load();
> +setPreferredSize(m_settings->cursorSize());

ManagedConfigModule::load();

> kcmcursortheme.cpp:403
>  {
>  m_settings->setDefaults();
>  m_preferredSize = m_settings->cursorSize();

ManagedConfigModule::defaults();

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26052

To: bport, #plasma, ervin, crossi
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-17 Thread Tranter Madi
trmdi added a comment.


  In D25807#579125 , @davidre wrote:
  
  > I have a question about naming. If I had an application like panel or latte 
I would call setAvailableScreenRect? That seems kinda backwards to me? That 
part of the screen is not available isn't  it but rather not available anymore? 
Maybe I'm understanding the approach taken here wrong?
  
  
  availableScreenRect = screen_geometry - panels
  
  
https://api.kde.org/frameworks/plasma-framework/html/classPlasma_1_1Corona.html#ad8ffd115128a128efd830540eeba5dd1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26047: Expose KConfig settings to allow registration in KCM Notification

2019-12-17 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> settings.h:343
>  
> +QList configSkeletons() const;
> +

Not a fan of this becoming public API

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26045: Add immutability to KCM Icons

2019-12-17 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> main.qml:38
>  view.currentIndex: kcm.pluginIndex(kcm.iconsSettings.theme)
> -enabled: !kcm.downloadingFile
>  

Why this change?

> main.qml:55
>  
> +enabled: !kcm.iconsSettings.isImmutable("Theme") // don't allow to 
> change theme if immutable, but allow to change icon sizes
> +

Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff 
Marco fixed a while back?

> main.qml:230
>  QtControls.Button {
> +enabled: true
>  id: iconSizesButton

This is the default

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24846: Port kcm icons to kconfigxt

2019-12-17 Thread Cyril Rossi
crossi added inline comments.

INLINE COMMENTS

> iconsmodel.cpp:29
>  #include 
> +#include 
>  

include not used

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-17 Thread David Redondo
davidre added a comment.


  I have a question about naming. If I had an application like panel or latte I 
would call setAvailableScreenRect? That seems kinda backwards to me? That part 
of the screen is not available isn't  it but rather not available anymore? 
Maybe I'm understanding the approach taken here wrong?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart