date:20191223

D26192: Fix localization of the systemmonitor widget configuration window

2019-12-23 Thread Yuri Chornoivan

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9f5ed252baa4: Fix localization of the systemmonitor 
widget configuration window (authored by yurchor).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26192?vs=72105=72130

REVISION DETAIL
  https://phabricator.kde.org/D26192

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/net/Messages.sh

To: yurchor, #localization, #plasma, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26200: Add shortcut for closing pages

2019-12-23 Thread Nathaniel Graham

ngraham added a comment.


  Hmm, does not work for me with Discover.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26200

To: nicolasfella, #kirigami, mart, ngraham
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26199: Remove unneeded shortcut for page naviagtion

2019-12-23 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me with Kirigami from git master.

REPOSITORY
  R134 Discover Software Store

BRANCH
  shortcut

REVISION DETAIL
  https://phabricator.kde.org/D26199

To: nicolasfella, #discover_software_store, ngraham
Cc: ngraham, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26199: Remove unneeded shortcut for page naviagtion

2019-12-23 Thread Alexey Min

alexeymin added a comment.


  Doesn't work for me, needs very fresh kirigami too?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26199

To: nicolasfella, #discover_software_store
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26200: Add shortcut for closing pages

2019-12-23 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added reviewers: Kirigami, mart, ngraham.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The lack of standard way to close a page has always bothered me, particularly 
on the desktop. On mobile this is less of an issue since there is always only 
one page visible. Discover and Calindori have implemented Esc as shortcut for 
closing a page already.

TEST PLAN
  Closed some pages in plasma-phonebook

REPOSITORY
  R169 Kirigami

BRANCH
  close

REVISION DETAIL
  https://phabricator.kde.org/D26200

AFFECTED FILES
  src/controls/ApplicationWindow.qml

To: nicolasfella, #kirigami, mart, ngraham
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26199: Remove unneeded shortcut for page naviagtion

2019-12-23 Thread Nicolas Fella

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Kirigami provides shortcuts for page navigation out of the box

TEST PLAN
  Still can switch pages by Alt+Arrow

REPOSITORY
  R134 Discover Software Store

BRANCH
  shortcut

REVISION DETAIL
  https://phabricator.kde.org/D26199

AFFECTED FILES
  discover/qml/DiscoverPage.qml

To: nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

2019-12-23 Thread Nathaniel Graham

ngraham added a comment.


  IIRC Kai told me in person that this was okay, but let's wait for official 
confirmation.

REPOSITORY
  R112 Milou

BRANCH
  fix-bad-text-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25374

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

2019-12-23 Thread Nathaniel Graham

ngraham added a comment.


  The Meta+Ctrl+Left/Light shortcuts being proposed for virtual desktop 
switching in D24281 . Let's wait to see 
what shakes out of that first.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26183: Fix build with Qt 5.14

2019-12-23 Thread Tomaz Canabrava

This revision was automatically updated to reflect the committed changes.
Closed by commit R112:dfecda35d4c7: Fix build with Qt 5.14 (authored by 
tcanabrava).

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26183?vs=72067=72114

REVISION DETAIL
  https://phabricator.kde.org/D26183

AFFECTED FILES
  lib/draghelper.cpp

To: tcanabrava, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

2019-12-23 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b25a0d41985e: [Plasma Style KCM] Add search filter 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=72088=72106

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26179: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ervin wrote in componentchooserfilemanager.cpp:72
> Opening curly brace should be on the same line than for

Is it me or it's in fact not done? Also should have space before & not after.

> ervin wrote in componentchooserfilemanager.cpp:94
> Space before * not after

Is it me or it's not done in fact?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26179

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26192: Fix localization of the systemmonitor widget configuration window

2019-12-23 Thread Yuri Chornoivan

yurchor created this revision.
yurchor added reviewers: Localization, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  Currently, the common config window messages are neither extracted nor used 
in all 5 widgets. It is not possible to add several translation catalogs for a 
single QML widget thus the messages are extracted into all 5 widget catalogs.
  
  Idea of the fix by Victor Ryzhykh.

TEST PLAN
  Extraction tested to work as expected, translation should work too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26192

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/net/Messages.sh

To: yurchor, #localization, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26179: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72102.
meven added a comment.


  fix two indentation issues

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26179?vs=72092=72102

BRANCH
  arcpatch-D26100

REVISION DETAIL
  https://phabricator.kde.org/D26179

AFFECTED FILES
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/kcm_componentchooser.cpp

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

2019-12-23 Thread Kevin Ottens

ervin added a comment.


  Still some broken indentation, the files have weird indentation in that 
module it seems

INLINE COMMENTS

> componentchooserterminal.h:33
>   void defaults() override;
> +bool isDefaults() const override;
>  

broken indentation

> kcm_componentchooser.cpp:40
>   connect(m_chooser,SIGNAL(changed(bool)),this,SIGNAL(changed(bool)));
> - setButtons( Default|Apply|Help );
> +connect(m_chooser, ::defaulted, this, 
> ::defaulted);
>  

broken indentation

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26100

To: meven, crossi, #plasma, ngraham, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26181: [KCM/Component] Clean deprecated code, modernize code

2019-12-23 Thread Méven Car

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c9eaa0d9ae73: [KCM/Component] Clean deprecated code, 
modernize code (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26181?vs=72097=72101

REVISION DETAIL
  https://phabricator.kde.org/D26181

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72100.
meven added a comment.


  Space formatting

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26100?vs=72099=72100

BRANCH
  component-browser

REVISION DETAIL
  https://phabricator.kde.org/D26100

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browser_settings.kcfg
  kcms/componentchooser/browser_settings.kcfgc
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/kcm_componentchooser.cpp

To: meven, crossi, #plasma, ngraham, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72099.
meven marked 4 inline comments as done.
meven added a comment.


  Keep isDefaults virtual, fix a fishy ref&, space formatting

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26100?vs=72053=72099

BRANCH
  component-browser

REVISION DETAIL
  https://phabricator.kde.org/D26100

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browser_settings.kcfg
  kcms/componentchooser/browser_settings.kcfgc
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/kcm_componentchooser.cpp

To: meven, crossi, #plasma, ngraham, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26189: Port to QRandomGenerator

2019-12-23 Thread Laurent Montel

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:161b6c42205f: Port to QRandomGenerator (authored by 
mlaurent).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26189?vs=72085=72098

REVISION DETAIL
  https://phabricator.kde.org/D26189

AFFECTED FILES
  tests/graphicssignalplotterbenchmark.cpp
  tests/signalplotterbenchmark.cpp

To: mlaurent, dfaure, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Proposal for Season of KDE 2020

2019-12-23 Thread Kartik Ramesh

Hello,

I wanted to participate in Season Of KDE 2020, and was particularly
interested in the Plasma-Phonebook project. I'm currently understanding the
codebase and relevant frameworks involved in the project.
I needed some help regarding my proposal for the same, I wanted to discuss
and re-frame my proposal before I submit it. Who should I contact for this?

Thanks,
Kartik

D26181: [KCM/Component] Clean deprecated code, modernize code

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72097.
meven marked 3 inline comments as done.
meven added a comment.


  Fix & position

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26181?vs=72096=72097

BRANCH
  arcpatch-D26181

REVISION DETAIL
  https://phabricator.kde.org/D26181

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26181: [KCM/Component] Clean deprecated code, modernize code

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72096.
meven added a comment.


  Fix indentation (file mostly uses Tabs but not only), fix & position

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26181?vs=72063=72096

BRANCH
  arcpatch-D26181

REVISION DETAIL
  https://phabricator.kde.org/D26181

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72093.
meven marked 3 inline comments as done.
meven added a comment.


  Fix position of *

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=72091=72093

BRANCH
  arcpatch-D26068

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26179: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72092.
meven added a comment.


  Fix formatting

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26179?vs=72090=72092

BRANCH
  arcpatch-D26179

REVISION DETAIL
  https://phabricator.kde.org/D26179

AFFECTED FILES
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> PrivacyTab.cpp:57
>  
> -Private()
> -: viewBlacklistedApplicationsRoot(nullptr)
> +Private(QObject* parent)
> +: mainConfig(new KActivityManagerdSettings(parent))

Space before * not after

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72091.
meven added a comment.


  Fix * position

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=72089=72091

BRANCH
  arcpatch-D26068

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26179: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72090.
meven added a comment.


  Formatting issues fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26179?vs=72059=72090

BRANCH
  arcpatch-D26179_1

REVISION DETAIL
  https://phabricator.kde.org/D26179

AFFECTED FILES
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

2019-12-23 Thread Kevin Ottens

ervin added inline comments.

INLINE COMMENTS

> davidre wrote in themesmodel.cpp:237
> Is it also needed in a const member method?

Not strictly speaking indeed.

Now C++ being what it is you're never safe of someone introducing a member as 
mutable though. ;-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72089.
meven added a comment.


  Make pluginConfig and mainConfig pointers

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=71729=72089

BRANCH
  arcpatch-D26068

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

2019-12-23 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> themesmodel.cpp:161
> +QStringList themes;
> +const QStringList  = 
> QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, 
> QStringLiteral("plasma/desktoptheme"), QStandardPaths::LocateDirectory);
> +for(const QString  : packs) {

Yeah that doesn't look right. The load method is a straight copy from the old 
load method.

> themesmodel.cpp:237
> +
> +for (const auto  : m_data) {
> +if (item.pendingDeletion) {

Is it also needed in a const member method?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

2019-12-23 Thread David Redondo

davidre updated this revision to Diff 72088.
davidre added a comment.


  Diff against master, somehow this branch is screwed up when using arc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=72087=72088

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

2019-12-23 Thread David Redondo

davidre updated this revision to Diff 72087.
davidre marked 7 inline comments as done.
davidre added a comment.


  - ervin's comments
  - remove unused method declaration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71760=72087

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  applets/icontasks/metadata.desktop
  applets/kicker/package/metadata.desktop
  applets/kickoff/package/contents/config/main.xml
  applets/kickoff/package/contents/ui/Header.qml
  applets/kimpanel/backend/ibus/CMakeLists.txt
  applets/kimpanel/backend/ibus/README
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/ibus15/README
  applets/kimpanel/backend/ibus/ibus15/panel.cpp
  applets/minimizeall/package/metadata.desktop
  applets/showActivityManager/package/metadata.desktop
  applets/showdesktop/package/metadata.desktop
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/window-list/metadata.desktop
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/ConfigOverlay.qml
  kaccess/kaccess.notifyrc
  kcms/access/kcmaccess.desktop
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/autostart/autostart.desktop
  kcms/baloo/kcm_baloofile.desktop
  kcms/baloo/package/metadata.desktop
  kcms/componentchooser/EXAMPLE.desktop
  kcms/componentchooser/componentchooser.desktop
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h
  kcms/icons/main.cpp
  kcms/kfontinst/dbus/fontinst.actions
  kcms/launch/launchfeedback.cpp
  kcms/launch/launchfeedback.h
  kcms/launch/launchfeedbacksettings.kcfgc
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/metadata.desktop
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/nightcolor/kcm_nightcolor.desktop
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml
  kcms/nightcolor/package/metadata.desktop
  kcms/notifications/package/contents/ui/main.qml
  kcms/solid_actions/device-actions/solid-device-Battery.desktop
  kcms/spellchecking/spellchecking.desktop
  kcms/style/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc
  org.kde.plasmashell.metainfo.xml
  toolboxes/desktoptoolbox/metadata.desktop
  toolboxes/paneltoolbox/metadata.desktop
  toolboxes/plasma-toolbox-paneltoolbox.desktop

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

2019-12-23 Thread Kevin Ottens

ervin added inline comments.

INLINE COMMENTS

> settings.h:343
>  
> +QList configSkeletons() const;
> +

Will need API documentation

> broulik wrote in settings.h:343
> Not a fan of this becoming public API

@broulik I understand you don't like much this becoming exposed as one could 
abuse it to kill encapsulation and state... but we can't have it both ways 
either. This facade makes it impossible to plug as is in existing systems 
around KCM or ConfigModule without large efforts. I don't think we can have it 
both ways here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-23 Thread Andreas Hartmetz

ahartmetz added a comment.


  In D26185#582095 , @anthonyfieroni 
wrote:
  
  > Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 
5.14+
  
  
  That unfortunately does not seem to help. I set the environment in a shell 
inside konsole from which I launched the konsole in which I took the screenshot.
  F7832463: qt_enable_highdpi_scaling.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26189: Port to QRandomGenerator

2019-12-23 Thread Laurent Montel

mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QRandomGenerator

TEST PLAN
  autotest ok

REPOSITORY
  R111 KSysguard Library

BRANCH
  port_QRandomGenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26189

AFFECTED FILES
  tests/graphicssignalplotterbenchmark.cpp
  tests/signalplotterbenchmark.cpp

To: mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26179: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> componentchooserfilemanager.cpp:72
>  bool first = true;
> -Q_FOREACH(const KService::Ptr& service, apps)
> +for (const KService::Ptr& service : apps)
>  {

Opening curly brace should be on the same line than for

> componentchooserfilemanager.cpp:94
>  QString storageId;
> -Q_FOREACH(QRadioButton* button, qFindChildren(this)) {
> +for (QRadioButton* button : qAsConst(mDynamicRadioButtons)) {
>  if (button->isChecked()) {

Space before * not after

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26179

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26181: [KCM/Component] Clean deprecated code, modernize code

2019-12-23 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> componentchooser.cpp:83
>  
> - for (KService::List::const_iterator tit = offers.begin(); tit != 
> offers.end(); ++tit) {
> - ComponentSelector->addItem((*tit)->name());
> - m_lookupDict.insert((*tit)->name(), (*tit)->desktopEntryName());
> - m_revLookupDict.insert((*tit)->desktopEntryName(), 
> (*tit)->name());
> +for (const auto : offers) {
> +ComponentSelector->addItem(service->name());

Indentation looks wrong

> componentchooser.cpp:125
>  
> - const QStringList services=KGlobal::dirs()->findAllResources( 
> "data",QStringLiteral("kcm_componentchooser/*.desktop"),
> - 
> KStandardDirs::NoDuplicates);
> - for (QStringList::const_iterator it=services.constBegin(); 
> it!=services.constEnd(); ++it)
> +const QStringList directories = 
> QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, 
> QStringLiteral("kcm_componentchooser"), QStandardPaths::LocateDirectory);
> +QStringList services;

Indentation looks wrong

> componentchooser.cpp:127
> +QStringList services;
> +for(const QString& directory : directories) {
> +const QDir dir(directory);

Space before & not after

> componentchooser.cpp:129
> +const QDir dir(directory);
> +for(const QString& f: dir.entryList(QStringList("*.desktop"))) {
> +services += dir.absoluteFilePath(f);

Space before & not after

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26181

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

2019-12-23 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> componentchooser.cpp:207
> +
> +CfgPlugin * plugin = dynamic_cast( configWidget );
> +emit defaulted(plugin->isDefaults());

No spaces between the parenthesis, no space after *

> componentchooser.h:42
>   virtual void defaults()=0;
> +virtual bool isDefaults() const {
> +return false;

Wrong indentation for that file which happens to be non standard

Also it's probably best to keep it pure-virtual to avoid the bastardization of 
something which looks like an interface into an abstract class.

> componentchooser.h:64
>   void changed(bool);
> +void defaulted(bool);
>  };

ditto

> componentchooser.h:94
>   void changed(bool);
> +void defaulted(bool);
>  

ditto

> componentchooserbrowser.cpp:112
> +  " ('x-scheme-handler/http' in 
> ServiceTypes or 'x-scheme-handler/https' in ServiceTypes)");
> +const auto  = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), constraint);
>  for (const auto  : browsers) {

Ref on a temporary sounds fishy to me.

> componentchooserbrowser.h:31
>   void defaults() override;
> +bool isDefaults() const override;
>  

Wrong indentation

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26100

To: meven, crossi, #plasma, ngraham, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-23 Thread Anthony Fieroni

anthonyfieroni added a comment.


  Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 5.14+

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

2019-12-23 Thread Kevin Ottens

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Looks good to me, hoping we don't have two items with the same name in 
different settings objects.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26077: [kcms/ksmserver] Swap shutdown options

2019-12-23 Thread Kevin Ottens

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  I'm surprised, I was sure I checked that... but maybe I did it only for the 
loginMode. This is indeed the better quick and dirty fix we can apply for now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26077

To: broulik, #plasma, ervin
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Oops, selected wrong state :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Kevin Ottens

ervin accepted this revision.
ervin added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> PrivacyTab.cpp:50
>  public:
> -KSharedConfig::Ptr mainConfig;
> -KSharedConfig::Ptr pluginConfig;
> +KActivityManagerdSettings mainConfig;
> +KActivityManagerdPluginsSettings pluginConfig;

I'd have it by pointer and give it a parent at construction time. It's a more 
common pattern for QObject as members.

> PrivacyTab.cpp:51
> +KActivityManagerdSettings mainConfig;
> +KActivityManagerdPluginsSettings pluginConfig;
>  

Ditto

REPOSITORY
  R119 Plasma Desktop

BRANCH
  activity_kcm

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

2019-12-23 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filterproxymodel.cpp:110
> +
> +bool FilterProxyModel::filterAcceptsRow(int source_row, const QModelIndex 
> _parent) const
> +{

Ditto

> filterproxymodel.h:61
> +
> +bool filterAcceptsRow(int source_row, const QModelIndex _parent) 
> const override;
> +

s/source_row/sourceRow/ same for source_parent

> ThemePreview.qml:180
>  Kirigami.Icon {
> -visible: model.followsSystemColors
> +visible: model.colorType == Private.ThemesModel.FollowsColorTheme
>  source: "color-profile"

Better use === with this bloody javascript

> themesmodel.cpp:161
> +QStringList themes;
> +const QStringList  = 
> QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, 
> QStringLiteral("plasma/desktoptheme"), QStandardPaths::LocateDirectory);
> +for(const QString  : packs) {

A ref on a temporary sounds like a bad idea to me.

> themesmodel.cpp:165
> +const QStringList  = cd.entryList(QDir::Dirs | QDir::Hidden 
> | QDir::NoDotAndDotDot);
> +Q_FOREACH (const QString , entries) {
> +const QString _metadata = ppath + QLatin1Char('/') + pack + 
> QStringLiteral("/metadata.desktop");

Don't use Q_FOREACH but a proper for in new code

> themesmodel.cpp:173
> +
> +for (const QString  : themes) {
> +int themeSepIndex = theme.lastIndexOf(QLatin1Char('/'), -1);

qAsConst(themes)

> themesmodel.cpp:237
> +
> +for (const auto  : m_data) {
> +if (item.pendingDeletion) {

qAsConst(m_data)

> themesmodel.h:65
> +
> +int rowCount(const QModelIndex ) const override;
> +QVariant data(const QModelIndex , int role) const override;

This one and the two following are missing the default values for their 
parameters (which parents have, I wish override would check for that too).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-23 Thread Andreas Hartmetz

ahartmetz added a comment.


  Compiled against Qt 5.14 before this change:
  F7832282: before.png 
  
  Compiled against Qt 5.14 after this change:
  F7832284: after.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-23 Thread Andreas Hartmetz

ahartmetz created this revision.
ahartmetz added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahartmetz requested review of this revision.

REVISION SUMMARY
  Whatever behavior change was apparently expected in Qt 5.14 didn't happen. I 
compiled against Qt 5.14 and got rather bad looking fonts. Tested on a 14" full 
HD screen which is almost HiDPI (Windows scales 1.25x or 1.50x or so unless 
configured otherwise).

TEST PLAN
  Compiled and ran the whole KDE / Plasma stack and looked at font rendering in 
konsole (most extreme difference), also tested changing only the environment 
variable. It is clear that the environment variable makes the difference.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

AFFECTED FILES
  startkde/startplasma.cpp

To: ahartmetz, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26183: Fix build with Qt 5.14

2019-12-23 Thread Tomaz Canabrava

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R112 Milou

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26183

AFFECTED FILES
  lib/draghelper.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26045: Add immutability to KCM Icons

2019-12-23 Thread Kevin Ottens

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26181: [KCM/Component] Clean deprecated code, modernize code

2019-12-23 Thread Méven Car

meven created this revision.
meven added reviewers: ervin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  No changes

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26181

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-23 Thread Kevin Ottens

ervin added a comment.


  Just a couple of stylistic issues left AFAICT

INLINE COMMENTS

> iconsmodel.h:47
>  public:
> -IconsModel(QObject *parent);
> +IconsModel(QObject *parent, IconsSettings *iconsSettings);
>  ~IconsModel() override;

Kind of a nitpick in this context, but parent should go last and default to 
nullptr. It's the Qt convention for QObject ctors.

> iconssettings.cpp:48
> +if (m_themeDirty)
> +{
> +KIconTheme::reconfigure();

The opening curly braces should be on the same line than the if

> main.cpp:135
>  m_model->load();
> -loadIconSizes();
> -m_model->setSelectedTheme(KIconTheme::current());
> -setNeedsSave(false);
> -m_selectedThemeDirty = false;
> -m_iconSizesDirty = false;
> +emit m_settings->ThemeChanged();
>  }

This one likely requires a comment, since normally you wouldn't need such an 
emit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26160: [Notifications] For non-configurable applications use fake "@other" category

2019-12-23 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4280515eebb0: [Notifications] For non-configurable 
applications use fake @other category (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26160?vs=72012=72061

REVISION DETAIL
  https://phabricator.kde.org/D26160

AFFECTED FILES
  libnotificationmanager/notificationfilterproxymodel.cpp
  libnotificationmanager/plasmanotifyrc

To: broulik, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26161: [Notifications KCM] Add "Other Applications" category

2019-12-23 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:41e27fa56cd8: [Notifications KCM] Add Other 
Applications category (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26161?vs=72013=72062

REVISION DETAIL
  https://phabricator.kde.org/D26161

AFFECTED FILES
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/sourcesmodel.cpp

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26179: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72058.
meven added a comment.


  Add an override in header

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26179?vs=72056=72058

BRANCH
  arcpatch-D26100

REVISION DETAIL
  https://phabricator.kde.org/D26179

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browser_settings.kcfg
  kcms/componentchooser/browser_settings.kcfgc
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/kcm_componentchooser.cpp

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26179: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72059.
meven added a comment.


  Add an override in header

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26179?vs=72058=72059

BRANCH
  arcpatch-D26100

REVISION DETAIL
  https://phabricator.kde.org/D26179

AFFECTED FILES
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26179: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Méven Car

meven created this revision.
meven added reviewers: Plasma, crossi, ervin.
meven added a project: Plasma.
meven requested review of this revision.

TEST PLAN
  kcmshell5 componentchooser

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D26100

REVISION DETAIL
  https://phabricator.kde.org/D26179

AFFECTED FILES
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26178: [KCM/Component] Clean up code of filemanager cfg

2019-12-23 Thread Méven Car

meven created this revision.
meven added reviewers: Plasma, crossi, ervin.
meven added a project: Plasma.
meven requested review of this revision.

TEST PLAN
  kcmshell5 componentchooser

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D26100

REVISION DETAIL
  https://phabricator.kde.org/D26178

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browser_settings.kcfg
  kcms/componentchooser/browser_settings.kcfgc
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/kcm_componentchooser.cpp

To: meven, #plasma, crossi, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72053.
meven added a comment.


  Clean unrelated changes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26100?vs=72052=72053

BRANCH
  arcpatch-D26100

REVISION DETAIL
  https://phabricator.kde.org/D26100

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browser_settings.kcfg
  kcms/componentchooser/browser_settings.kcfgc
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/kcm_componentchooser.cpp

To: meven, crossi, #plasma, ngraham, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72052.
meven added a comment.


  [KCM/Component] Clean up code of filemanager cfg

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26100?vs=71894=72052

BRANCH
  arcpatch-D26100

REVISION DETAIL
  https://phabricator.kde.org/D26100

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browser_settings.kcfg
  kcms/componentchooser/browser_settings.kcfgc
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/kcm_componentchooser.cpp

To: meven, crossi, #plasma, ngraham, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25584: [TabBar] Add a border property

2019-12-23 Thread Filip Fila

filipf updated this revision to Diff 72051.
filipf added a comment.


  clean up

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25584?vs=72050=72051

BRANCH
  border-property (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25584

AFFECTED FILES
  org.kde.desktop/TabBar.qml

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: mart, ahiemstra, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D25584: [TabBar] Add a border property

2019-12-23 Thread Filip Fila

filipf updated this revision to Diff 72050.
filipf added a comment.


  remove tabbar frame

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25584?vs=70473=72050

BRANCH
  border-property (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25584

AFFECTED FILES
  org.kde.desktop/TabBar.qml

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: mart, ahiemstra, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

2019-12-23 Thread Filip Fila

filipf added a comment.


  @broulik?

REPOSITORY
  R112 Milou

BRANCH
  fix-bad-text-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25374

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25973: Make the theme info QuickWidget transparent

2019-12-23 Thread Filip Fila

filipf abandoned this revision.
filipf added a comment.


  Going to have to be a no from me since the lack of font anti-aliasing looks 
pretty bad with darker color schemes. Not sure if it's worth it to report the 
bug to Qt.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D25973

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2019-12-23 Thread Méven Car

meven updated this revision to Diff 72041.
meven added a comment.


  Use default fallthrough

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26147?vs=71962=72041

BRANCH
  arcpatch-D26147

REVISION DETAIL
  https://phabricator.kde.org/D26147

AFFECTED FILES
  applets/kicker/plugin/computermodel.cpp

To: meven, ngraham, #plasma, #vdg, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

62 matches

Mail list logo