KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/6/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 04 Jan 2020 05:13:35 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 246 lines...][2020-01-04T05:27:20.532Z] -- Performing Test HAVE_DATE_TIME[2020-01-04T05:27:20.532Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-04T05:27:20.787Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:27:20.787Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:27:20.787Z] -- Found KF5Plasma: /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:27:20.787Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2020-01-04T05:27:20.787Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] -- Found KF5People: /usr/home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] -- Found KF5: success (found suitable version "5.66.0", minimum required is "5.0.0") found components:  Plasma Service Declarative I18n KIO People [2020-01-04T05:27:20.787Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:27:20.787Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:27:20.787Z] -- Found KF5PlasmaQuick: /usr/home/jenkins/install-prefix/lib/cmake/KF5PlasmaQuick/KF5PlasmaQuickConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.66.0") [2020-01-04T05:27:20.787Z] -- Found KF5: success (found version "5.66.0") found components:  PlasmaQuick DBusAddons Notifications [2020-01-04T05:27:20.787Z] -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.6.3") [2020-01-04T05:27:20.787Z] -- Checking for module 'gstreamer-1.0'[2020-01-04T05:27:20.787Z] --   Found gstreamer-1.0, version 1.14.4[2020-01-04T05:27:20.787Z] -- Found GStreamer package: 1.14.4[2020-01-04T05:27:20.787Z] -- Found GStreamer: /usr/local/lib/libgstreamer-1.0.so (Required is at least version "1.1.90") [2020-01-04T05:27:21.042Z] -- Found GLIB2: /usr/local/lib/libglib-2.0.so  [2020-01-04T05:27:21.042Z] -- Checking for module 'gobject-2.0'[2020-01-04T05:27:21.042Z] --   Found gobject-2.0, version 2.56.3[2020-01-04T05:27:21.042Z] -- Found GOBJECT: /usr/local/lib/libgobject-2.0.so;/usr/local/lib/libgmodule-2.0.so;/usr/local/lib/libgthread-2.0.so;/usr/local/lib/libglib-2.0.so  [2020-01-04T05:27:21.042Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:67 (message):[2020-01-04T05:27:21.042Z]   warnings during generation of metainfo for org.kde.plasma.phone: Package[2020-01-04T05:27:21.042Z]   type "Plasma/LookAndFeel" not found[2020-01-04T05:27:21.042Z] [2020-01-04T05:27:21.042Z]   org.kde.kcoreaddons: Invalid plugin metadata: Attempting to create a[2020-01-04T05:27:21.042Z]   KAboutPerson from json without 'Name' property:[2020-01-04T05:27:21.042Z]   QJsonObject({"Email":"","Name":""})[2020-01-04T05:27:21.042Z] [2020-01-04T05:27:21.042Z] Call Stack (most recent call first):[2020-01-04T05:27:21.042Z]   /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaMacros.cmake:34 (kpackage_install_package)[2020-01-04T05:27:21.042Z]   CMakeLists.txt:45 

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 04 Jan 2020 05:13:35 +
 Build duration:
1 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 283 lines...][2020-01-04T05:15:11.245Z] [2020-01-04T05:15:11.245Z] [2020-01-04T05:15:11.245Z] == Commencing Configuration:[2020-01-04T05:15:11.245Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12"[2020-01-04T05:15:11.504Z] -- The C compiler identification is GNU 9.2.1[2020-01-04T05:15:11.764Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-04T05:15:11.764Z] -- Check for working C compiler: /usr/bin/cc[2020-01-04T05:15:11.764Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-04T05:15:11.764Z] -- Detecting C compiler ABI info[2020-01-04T05:15:12.046Z] -- Detecting C compiler ABI info - done[2020-01-04T05:15:12.046Z] -- Detecting C compile features[2020-01-04T05:15:12.046Z] -- Detecting C compile features - done[2020-01-04T05:15:12.046Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-04T05:15:12.315Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-04T05:15:12.315Z] -- Detecting CXX compiler ABI info[2020-01-04T05:15:12.577Z] -- Detecting CXX compiler ABI info - done[2020-01-04T05:15:12.577Z] -- Detecting CXX compile features[2020-01-04T05:15:12.577Z] -- Detecting CXX compile features - done[2020-01-04T05:15:12.577Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:15:12.577Z] -- Looking for __GLIBC__[2020-01-04T05:15:12.847Z] -- Looking for __GLIBC__ - found[2020-01-04T05:15:12.847Z] -- Performing Test _OFFT_IS_64BIT[2020-01-04T05:15:13.119Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-04T05:15:13.119Z] -- Performing Test HAVE_DATE_TIME[2020-01-04T05:15:13.384Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-04T05:15:13.384Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:15:13.384Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:15:13.384Z] -- Found KF5Plasma: /home/jenkins/install-prefix/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.384Z] -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.384Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:15:13.384Z] -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.384Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2020-01-04T05:15:13.384Z] -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.648Z] -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.648Z] -- Found KF5People: /home/jenkins/install-prefix/lib64/cmake/KF5People/KF5PeopleConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.648Z] -- Found KF5: success (found suitable version "5.66.0", minimum required is "5.0.0") found components:  Plasma Service Declarative I18n KIO People [2020-01-04T05:15:13.648Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:15:13.648Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-phone-components.[2020-01-04T05:15:13.648Z] -- Found KF5PlasmaQuick: /home/jenkins/install-prefix/lib64/cmake/KF5PlasmaQuick/KF5PlasmaQuickConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.648Z] -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.648Z] -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.66.0") [2020-01-04T05:15:13.648Z] -- Found KF5: success (found 

D26409: [kicker] Use arrow functions in event handlers

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Fixes warnings from qmllint about unqualified property access. It also makes 
the code more readable since it's clear which are the signal's arguments

TEST PLAN
  Did kicker/dashboard things

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arrow

REVISION DETAIL
  https://phabricator.kde.org/D26409

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/DashboardTabBar.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml
  applets/kicker/package/contents/ui/SideBarItem.qml
  applets/kicker/package/contents/ui/SideBarSection.qml

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26406: [kicker] Fix some unqualified root property access

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:64aa80431386: [kicker] Fix some unqualified root property 
access (authored by nicolasfella).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26406?vs=72719=72721

REVISION DETAIL
  https://phabricator.kde.org/D26406

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/ItemListDialog.qml
  applets/kicker/package/contents/ui/ItemListView.qml

To: nicolasfella, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26406: [kickoff] Fix some unqualified root property access

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Those will break in Qt 6. Apply suggestions from qmllint

TEST PLAN
  Did kicker/dashboard things

REPOSITORY
  R119 Plasma Desktop

BRANCH
  rpa

REVISION DETAIL
  https://phabricator.kde.org/D26406

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/ItemListDialog.qml
  applets/kicker/package/contents/ui/ItemListView.qml

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Alex Debus]

alexde added a comment.


  > UI-wise, this would probably be better off as a button than a checkbox.
  
  Personally, I'm more inclined to a checkbox. Why is "turn wifi on/off" not an 
action? Right now, I don't see the big difference.
  
  (I assume "hotspot" and "shared wifi" are equivalent.)
  
  1. If you have configured several hotspots in the KCM, you probably need to 
choose a default one or a specific one when activating the hotspot.
  2. What do you think about adding a small configure button for the default 
hotspot directly on the plasma-nm frontend  next to the hotspot checkbox/button?
- That would make it much easier for newcomers to use and configure their 
hotspot without first digging in the KCM.
  3. I also think that a hotspot (shared wifi) connection should be better 
separated from the other wifi connections in the KCM. If I create a new hotspot 
in the KCM now, it hides in the long list of known connections.
  4. That's somehow also true for the plasma-nm list of available networks: 
It's not really clear that a hotspot in the list is a indeed hotspot but not 
another access point.
  
  In D26392#587159 , @mthw wrote:
  
  > @apol You are right, it is not possible to create a hotspot if one is 
already connected to a WiFi network. Currently enabling hotspot disables your 
previous connection (WiFi) and hides available WiFi networks.
  
  
  Is this also true if one has two wifi network cards? IIRC I could run both 
with an additional usb netwok card simultaneously.
  
  ---
  
  @jgrulich do you intend to create another patch to display all connected 
clients, similiar to the list of active connections? :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: alexde, mthw, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Johnny Jazeix]

jjazeix added a comment.


  > @jjazeix please apply it to stable branch also
  
  Done: 
https://commits.kde.org/latte-dock/e740bd38032441d5c03ba5321a76dad0ba5af9b9
  Build ok: 
https://build.kde.org/job/Extragear/job/latte-dock/job/stable-kf5-qt5%20FreeBSDQt5.13/102/

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Michail Vourlakos]

mvourlakos added a comment.


  In D26399#587183 , @bcooksley 
wrote:
  
  > It was the Latte Dock code that needed adjusting to make use of ECM's 
`KDECompilerSettings` module.
  
  
  Oh, I had commented a line in cmake...
  I can not remember why...
  no prob, it still builds in my system.
  
  @jjazeix please apply it to stable branch also

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Johnny Jazeix]

jjazeix closed this revision.
jjazeix added a comment.


  > No prob... Did I understood correctly that this was fixable on your side 
without any need to touch Latte code? (dont worry about commiting and reverting)
  
  I updated the CMakeLists.txt: 
https://cgit.kde.org/latte-dock.git/diff/CMakeLists.txt?id=d2170f13c04e13e392ae780ee28b60ddebb20c9a

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26385: Kicker/RecentDocuments Avoid referring to hidden places

[Eike Hein]

hein added a comment.


  Thanks!
  
  We can revisit it after some more discussion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26385

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Ben Cooksley]

bcooksley added a comment.


  It was the Latte Dock code that needed adjusting to make use of ECM's 
`KDECompilerSettings` module.

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Méven Car]

meven added a comment.


  In D26386#587169 , @hein wrote:
  
  > It should be `iconName` after `label`.
  
  
  I like this suggestion.
  It entails a lot of error-prone code change.
  Will do.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Michail Vourlakos]

mvourlakos added a comment.


  In D26399#587161 , @jjazeix wrote:
  
  > In D26399#587133 , @bcooksley 
wrote:
  >
  > > Unfortunate, it definitely looked like QMLLint was the cause of the 
issues.
  > >
  > > Given that Latte Dock is the only application impacted by this, does it 
do anything else special with regards to linking the application (such as not 
making use of ECM).
  >
  >
  > I revert this change and added back `include(KDECompilerSettings 
NO_POLICY_SCOPE)` in the CMakeLists.txt.
  >  The build is now ok 
(https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/).
 I guess it was missing the flags during the link provided by this module 
(-fsanitize=address -fno-omit-frame-pointer -fno-optimize-sibling-calls)
  >  @mvourlakos is the change ok for you?
  >  If yes, I can add it in the stable branch too.
  
  
  No prob... Did I understood correctly that this was fixable on your side 
without any need to touch Latte code? (dont worry about commiting and reverting)

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26385: Kicker/RecentDocuments Avoid referring to hidden places

[Méven Car]

meven added a comment.


  In D26385#587173 , @hein wrote:
  
  > I don't agree with this patch. Hiding a place or section from the Places 
panel doesn't mean the user didn't add it and it's not to be used. We don't 
hide it from Folder View's config or relative title generator either. Hidden is 
not removed. Please revert.
  
  
  I meant to do this, as the use might be confused to discover a place name he 
never sees.
  For instance "Hard disk (400 GB)" (mountpoint /) might be hidden but will be 
the prefix to all local files not in other places.
  To me it is confusing, but for consistency let's keep those visible.
  
  Reverted in 4446d687d337dc3f33fc50ca65a8beb161367204 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26385

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26385: Kicker/RecentDocuments Avoid referring to hidden places

[Eike Hein]

hein added a comment.


  I don't agree with this patch. Hiding a place or section from the Places 
panel doesn't mean the user didn't add it and it's not to be used. We don't 
hide it from Folder View's config or relative title generator either. Hidden is 
not removed. Please revert.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26385

To: meven, #plasma, ngraham
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Ben Cooksley]

bcooksley added a comment.


  Thanks for sorting that Johnny, it's appreciated.

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  It should be `iconName` after `label`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3a6e3f927111: [KFilePlacesModel] Fix supported scheme 
check for devices (authored by broulik).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25991?vs=71522=72708#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25991?vs=71522=72708

REVISION DETAIL
  https://phabricator.kde.org/D25991

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: kde-frameworks-devel, bruns, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Nathaniel Graham]

ngraham added a comment.


  No response, I think you can land this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Johnny Jazeix]

jjazeix added a comment.


  In D26399#587133 , @bcooksley 
wrote:
  
  > Unfortunate, it definitely looked like QMLLint was the cause of the issues.
  >
  > Given that Latte Dock is the only application impacted by this, does it do 
anything else special with regards to linking the application (such as not 
making use of ECM).
  
  
  I revert this change and added back `include(KDECompilerSettings 
NO_POLICY_SCOPE)` in the CMakeLists.txt.
  The build is now ok 
(https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/).
 I guess it was missing the flags during the link provided by this module 
(-fsanitize=address -fno-omit-frame-pointer -fno-optimize-sibling-calls)
  @mvourlakos is the change ok for you?

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Matej Mrenica]

mthw added a comment.


  @apol You are right, it is not possible to create a hotspot if one is already 
connected to a WiFi network. Currently enabling hotspot disables your previous 
connection (WiFi) and hides available WiFi networks.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: mthw, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26403: [ToolTip] Round position

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:415683af956c: [ToolTip] Round position (authored by 
broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26403?vs=72705=72706

REVISION DETAIL
  https://phabricator.kde.org/D26403

AFFECTED FILES
  org.kde.desktop/ToolTip.qml

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26403: [ToolTip] Round position

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense to me.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26403

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26403: [ToolTip] Round position

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise screws up font rendering

TEST PLAN
  Before
  F7858341: Screenshot_20200103_192446.png 

  After
  F7858342: Screenshot_20200103_192811.png 

  
  If accepted, will do the same patch to plasmacomponents3

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26403

AFFECTED FILES
  org.kde.desktop/ToolTip.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Alexander Fieroch]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #48 from Alexander Fieroch  
---
I just recognized repeating messages with journalctl

Jan 03 19:12:37 m19040-lin dbus-daemon[1129]: [system] Activating service
name='org.kde.powerdevil.backlighthelper' requested by ':1.146' (uid=1000
pid=2889 comm="/usr/lib/x86_64-linux-gnu/libexec/org_kde_powerdev"
label="unconfined") (using servicehelper)
Jan 03 19:12:37 m19040-lin org.kde.powerdevil.backlighthelper[13052]:
QDBusArgument: read from a write-only object
Jan 03 19:12:37 m19040-lin org.kde.powerdevil.backlighthelper[13052]:
QDBusArgument: read from a write-only object
Jan 03 19:12:37 m19040-lin org.kde.powerdevil.backlighthelper[13052]:
QDBusArgument: read from a write-only object
Jan 03 19:12:37 m19040-lin dbus-daemon[1129]: [system] Successfully activated
service 'org.kde.powerdevil.backlighthelper'


Jan 03 19:13:16 m19040-lin dbus-daemon[1129]: [system] Activating service
name='org.kde.powerdevil.backlighthelper' requested by ':1.146' (uid=1000
pid=2889 comm="/usr/lib/x86_64-linux-gnu/libexec/org_kde_powerdev"
label="unconfined") (using servicehelper)
Jan 03 19:13:16 m19040-lin org.kde.powerdevil.backlighthelper[13302]:
QDBusArgument: read from a write-only object
Jan 03 19:13:16 m19040-lin org.kde.powerdevil.backlighthelper[13302]:
QDBusArgument: read from a write-only object
Jan 03 19:13:16 m19040-lin org.kde.powerdevil.backlighthelper[13302]:
QDBusArgument: read from a write-only object
Jan 03 19:13:16 m19040-lin dbus-daemon[1129]: [system] Successfully activated
service 'org.kde.powerdevil.backlighthelper'


Maybe this helps? is backlighthelper buggy?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Alexander Fieroch]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #47 from Alexander Fieroch  
---
there is no additional console output when it switches between 0% and the real
load.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Alexander Fieroch]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #46 from Alexander Fieroch  
---
(In reply to Konrad Materka from comment #41)
> I'm not able to reproduce, can you check few things?
> 1. I battery listed correctly if you click on the tray icon?
> 2. Can you run: plasmoidviewer -a org.kde.plasma.battery
> a) is battery listed?

same as in taskbar - battery with 0% load

> b) is it still listed after few hours (or whatever is needed for bug to
> occur)

seems to be random for me

> c) if battery not visible, can you send logs (console output) from
> plasmoidviewer?

$ plasmoidviewer -a org.kde.plasma.battery
QML debugging is enabled. Only use this in a safe environment.
qml: View QML loaded
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_powerdevilglobalconfig.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_kontact.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kipiplugin_dropbox.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/blenderthumbnail.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/ownclouddolphinactionplugin.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kio_kamera.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/okularpart.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_sdsummary.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/windowsexethumbnail.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_driver_manager.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/libaudiocd_encoder_opus.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/krunner_katesessions.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/libkcm_qtquicksettings.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/k3bffmpegdecoder.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/k3bmpcdecoder.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kontact_knotesplugin.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kipiplugin_facebook.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/gsthumbnail.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/accountwizard_plugin.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_whoopsie.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kded_notificationhelper.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/imagethumbnail.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kipiplugin_wikimedia.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kmailpart.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/akonadi_serializer_contactgroup.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_k3bexternalencoder.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_akonadicontact_actions.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/plasma-geolocation-gps.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_dolphingeneral.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_notificationhelper.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/krunner_kwin.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_kio.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/krunner_dictionary.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/akonadi_serializer_kcalcore.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/comicbookthumbnail.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/krunner_datetime.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kontact_akregatorplugin.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_kleopatra.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kio_bluetooth.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kdeconnect_pausemusic_config.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/k3baudiometainforenamerplugin.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kio_krarc.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/krunner_pimcontacts.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_memory.so"
org.kde.plasma: invalid metadata
"/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_clock.so"
org.kde.plasma: invalid 

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Ben Cooksley]

bcooksley added a comment.


  Unfortunate, it definitely looked like QMLLint was the cause of the issues.
  
  Given that Latte Dock is the only application impacted by this, does it do 
anything else special with regards to linking the application (such as not 
making use of ECM).

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Nathaniel Graham]

ngraham added a comment.


  Yeah, it definitely bloats this diff, but maybe it would make subsequent ones 
smaller and cleaner?
  
  #plasma  folks, what do you think?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Johnny Jazeix]

jjazeix added a comment.


  Commited in 
https://commits.kde.org/latte-dock/e705eed41556649661f959b714a016938c19817c
  Build still not ok in 
https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/118/console
  The issue is due to the link error, probably not qmllint

REVISION DETAIL
  https://phabricator.kde.org/D26399

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26401: KCM Baloo: Migrate to KConfigXT and add immutability

[Benjamin Port]

bport created this revision.
Herald added a project: Plasma.
Herald edited subscribers, added: plasma-devel; removed: Plasma.
bport requested review of this revision.

REVISION SUMMARY
  File indexing and Content file indexing benefits from immutability. But 
exclude/include list don't benefits from it because the UI represent both with 
the same list

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26401

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml

To: bport
Cc: meven, crossi, ervin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Johnny Jazeix]

jjazeix updated this revision to Diff 72700.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26399?vs=72698=72700

REVISION DETAIL
  https://phabricator.kde.org/D26399

AFFECTED FILES
  app/FakeTarget.cmake

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

[Johnny Jazeix]

jjazeix created this revision.
jjazeix added reviewers: bcooksley, mvourlakos.
jjazeix added a project: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jjazeix requested review of this revision.

REVISION SUMMARY
  Should fix the CI

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26399

AFFECTED FILES
  app/FakeTarget.cmake

To: jjazeix, bcooksley, mvourlakos
Cc: plasma-devel, acemond, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, niccolove, ragreen, lavender, ZrenBot, ngraham, alexeymin, 
himcesjf, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Méven Car]

meven added a comment.


  I am not too fond of this version growing the number of parameters of 
Kicker::createActionItem, and given its third parameter before icon is QVariant 
this becomes error-prone.
  There are a lot more usage of this method that I haven't yet updated, if we 
want to follow this course.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Méven Car]

meven updated this revision to Diff 72697.
meven added a comment.


  Add an icon parameter to Kicker::createActionItem

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26386?vs=72673=72697

BRANCH
  arcpatch-D26386

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  Nice feature.
  
  UI-wise, this would probably be better off as a button than a checkbox. 
Creating a hotspot is an action, and action == button. Once the hotspot has 
been created, the button text can change from "Create Hotspot..." to "Disable 
Hotspot". This is a bit nonstandard HIG-wise, but I think it's appropriate 
rnough here.
  
  If you need an icon, please file a bug in Breeze | Icons and we'll get on it 
ASAP. Even if the icon doesn't get in in time for Plasma 5.18, having an 
iconless button isn't the end of the world.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26385: Kicker/RecentDocuments Avoid referring to hidden places

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:aa259e389848: Kicker/RecentDocuments Avoid referring to 
hidden places (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26385?vs=72671=72696

REVISION DETAIL
  https://phabricator.kde.org/D26385

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Méven Car]

meven added a comment.


  In D26386#587025 , @ngraham wrote:
  
  > Is there no way to set the icon during initialization so these can stay 
const?
  
  
  I would have needed to edit `Kicker::createActionItem`, it might be 
interesting.
  But not keeping the const is not too important those variables have a limited 
lifetime anyway.
  Not having const here does not add a copy or anything.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26398: [KCM/Activities] Use KConfigXT in ui

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ervin, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Port the ui components to use KConfig XT features to reduce amount of 
boilerplate code.

TEST PLAN
  kcmshell5 activities

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26398

AFFECTED FILES
  kcms/activities/ActivitiesTab.cpp
  kcms/activities/ActivitiesTab.h
  kcms/activities/MainConfigurationWidget.cpp
  kcms/activities/MainConfigurationWidget.h
  kcms/activities/PrivacyTab.cpp
  kcms/activities/PrivacyTab.h
  kcms/activities/SwitchingTab.cpp
  kcms/activities/SwitchingTab.h
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: meven, #plasma, ervin, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel

[Nathaniel Graham]

ngraham updated this revision to Diff 72692.
ngraham added a comment.


  Fix that issue

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26312?vs=72435=72692

BRANCH
  fix-clock-long-date-in-vertical-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26312

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: ngraham, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Nathaniel Graham]

ngraham added a comment.


  Is there no way to set the icon during initialization so these can stay const?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

[Nathaniel Graham]

ngraham updated this revision to Diff 72690.
ngraham added a comment.


  Do that

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26379?vs=72657=72690

BRANCH
  section-grouping-in-notifications-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26379

AFFECTED FILES
  kcms/notifications/package/contents/ui/main.qml

To: ngraham, broulik, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Aleix Pol Gonzalez]

apol added a comment.


  Cool feature!

INLINE COMMENTS

> Toolbar.qml:133
> +
> +onClicked: {
> +if (checked) {

is it always prossible to create the hotspot? I'd expect it not to be possible 
at all sometimes (visible should be false then) and if the wifi is in use it 
might not be able to do it? (enabled false then).

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26395: [XembedSNIProxy] Send all container windows to background on KWin restart

[Konrad Materka]

kmaterka added a comment.


  This is another approach to fix 357443 
. It is still a workaround, but 
more reliable and uses better concept.

INLINE COMMENTS

> fdoselectionmanager.cpp:167
> +// workaround for BUG 357443: when KWin is restarted, container 
> window is shown on top
> +if (event->state == XCB_VISIBILITY_UNOBSCURED) {
> +for (auto sniProxy : m_proxies.values()) {

XCB_VISIBILITY_UNOBSCURED is rare. During simulated click (when we stack window 
above) xembedsniproxy receives XCB_VISIBILITY_PARTIALLY_OBSCURED. Obviously we 
ignore the last possible case: XCB_VISIBILITY_FULLY_OBSCURED.

> fdoselectionmanager.cpp:168
> +if (event->state == XCB_VISIBILITY_UNOBSCURED) {
> +for (auto sniProxy : m_proxies.values()) {
> +sniProxy->hideContainerWindow(event->window);

Iteration sucks, but this is the simplest (a in most cases the quickest) 
method. In this event we receive container window id, we can get its child and 
get sniproxy using it:

  xcb_connection_t *c = QX11Info::connection();
  xcb_query_tree_cookie_t cookie = xcb_query_tree(c, event->window);
  QScopedPointer
  reply(xcb_query_tree_reply(c, cookie, nullptr));
  
  if (reply && xcb_query_tree_children_length(reply.data()) == 1) {
  xcb_window_t *children = xcb_query_tree_children(reply.data());
  const auto sniProxy = m_proxies.value(children[0]);
  if (sniProxy) {
  sniProxy->handleExposeEvent(event->window);
  }
  }

IMO this is slower.

The best would be to have second map like m_proxies, but with container windows 
id (or something similar in the idea).

> sniproxy.cpp:527
>  qCDebug(SNIPROXY) << "Received click" << mouseButton << "with passed 
> x*y" << x << y;
> +sendingClickEvent = true;
>  

During click, container window is showed for a brief moment (STACK_ABOVE), so 
it is possible that it will sent visibility event. This is probably not needed, 
I tested it and all events generated in this method (stack above, click, stack 
below) were processed before visibility event is received in XEmbedSNIProxy. I 
added this just in case - I'm not sure how X events are queued and how reliable 
the order is.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26395

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26395: [XembedSNIProxy] Send all container windows to background on KWin restart

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  For each tray icon XEmbedSNIProxy is creating container window 32x32 in size. 
It is black with opaque set to 0 (fully transparent when compositor is 
enabled). All of these container windows are stacked below all windows, so 
normally you can't see them. On creation all container windows are created in 
top-left corner. When user clicks on the tray icon, container window is moved 
to the click location (to handle events correctly).
  On KWin restart all windows are shuffled, usually KWin is able to restore 
ordering correctly, but for some reason not it this case. As a result 
black/transparent container windows are stacked above all other windows and 
panels.
  To solve that, when container window is visible, XembedSNIProxy needs to 
stack container window below again.
  
  BUG: 357443
  FIXED-IN: 5.18.0

TEST PLAN
  1. Run any application with XEmbed system tray icon, do not click on the icon
  2. Restart KWin
  3. [Optional] Disable compositor - with disable container window is black and 
easier to spot
  4. Expected:
  
  a) before fix: black/transparent rectangle in the top-left corner, reacts to 
mouse click
  b) after fix: no rectangle, mouse clicks work as expected.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26395

AFFECTED FILES
  xembed-sni-proxy/fdoselectionmanager.cpp
  xembed-sni-proxy/sniproxy.cpp
  xembed-sni-proxy/sniproxy.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26382: Port KCM menu away from PlasmaComponents

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:5e055c1e1754: Port KCM menu away from PlasmaComponents 
(authored by davidedmundson).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26382?vs=72666=72683

REVISION DETAIL
  https://phabricator.kde.org/D26382

AFFECTED FILES
  kcm/qml/ConnectionItem.qml

To: davidedmundson, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Jan Grulich]

jgrulich added a comment.


  There are two things which need work or I'm not sure about:
  
  1. If this should be placed as a checkbox in the applet
  2. We need a different icon for the hotspot, currently there is no such icon 
in the Plasma theme and freeze for Plasma 5.18 is soon

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  This adds a simple checkbox, which will create and stop hotspot. Hotspot can 
be also
  configured from the KCM, where users can choose a name and password.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  hotspot

REVISION DETAIL
  https://phabricator.kde.org/D26392

AFFECTED FILES
  applet/contents/ui/Toolbar.qml
  kcm/kcm.cpp
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/main.qml
  kded/networkmanagement.notifyrc
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp

To: jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26077: [kcms/ksmserver] Swap shutdown options

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c4dc4bd45238: [kcms/ksmserver] Swap shutdown options 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26077?vs=71761=72681

REVISION DETAIL
  https://phabricator.kde.org/D26077

AFFECTED FILES
  kcms/ksmserver/smserverconfigdlg.ui

To: broulik, #plasma, ervin
Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26388: Get rid of KGlobalSettings

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Looks fine to me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26388

To: ervin, #plasma, mart, davidedmundson, bport, crossi, meven
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26390: DesktopPaths KCM: Move the view logic in a ui file

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, crossi, bport, meven, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  Now the revert/apply/defaults buttons work as expected.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26390

AFFECTED FILES
  kcms/desktoppaths/CMakeLists.txt
  kcms/desktoppaths/globalpaths.cpp
  kcms/desktoppaths/globalpaths.h
  kcms/desktoppaths/globalpaths.ui

To: ervin, #plasma, crossi, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26391: DesktopPaths KCM: Remove the moving directory logic

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, crossi, bport, meven, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This simplifies greatly this otherwise mundane KCM. It introduced a lot
  of complexity while gettings things wrong anyway: it would miss if a
  directory is included in another one except in the "autostart inside
  desktop" case, it would also leave you stranded in case of an
  uncompleted move.
  
  So now the KCM has a clear purpose: edit the settings. Moving data
  around is still up to the user using a proper filemanager.
  
  Long term it would probably be better for the filemanager to edit the
  settings automatically when the user move on of those folders around,
  then the KCM could be decommissioned.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26391

AFFECTED FILES
  kcms/desktoppaths/globalpaths.cpp
  kcms/desktoppaths/globalpaths.h

To: ervin, #plasma, crossi, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26388: Get rid of KGlobalSettings

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  After grepping in all our repositories, it looks like the SETTINGS_PATHS
  category is completely unused (at least I couldn't find anyone doing
  anything paths related on the slot end).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26388

AFFECTED FILES
  kcms/desktoppaths/CMakeLists.txt
  kcms/desktoppaths/globalpaths.cpp

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26389: DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, crossi, bport, meven, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  Our KCoreConfigSkeleton subclass is interestingly hand written since
  it's too remote from what we usually do (the resulting file needs to be
  sourceable and we don't want the usual behavior of removing keys when
  they're set to defaults).
  
  The only one which was "more standard" was the autostart path, but
  really with the URL conversion on top and for just a single entry, I
  shoved it in the hand written class as well.
  
  Doesn't reduce the code much, but at least it separates that logic from
  the KCM and it opens the door to properly working defaults button.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26389

AFFECTED FILES
  kcms/desktoppaths/CMakeLists.txt
  kcms/desktoppaths/desktoppathssettings.cpp
  kcms/desktoppaths/desktoppathssettings.h
  kcms/desktoppaths/desktoppathssettingsbase.kcfg
  kcms/desktoppaths/globalpaths.cpp
  kcms/desktoppaths/globalpaths.h

To: ervin, #plasma, crossi, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Luca Carlon]

luc4 added a comment.


  I don't see why, it was proposed after mine and it is already merged... Does 
not seem to need a review.
  Thanks for answering though.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Alex Debus]

alexde added a comment.


  In D21273#586877 , @luc4 wrote:
  
  > Probably the consequence of not reviewing changes? This one can probably be 
abandoned.
  
  
  What a shame!  As you are familiar with the code, you could probably review 
the other patch too and see if it there's space for improvements, which 
probably your patch already coveres. :)

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Luca Carlon]

luc4 added a comment.


  Probably the consequence of not reviewing changes? This one can probably be 
abandoned.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Alex Debus]

alexde added a comment.


  This patch looks pretty similar to the already merged one 
https://phabricator.kde.org/D25018. How are they related?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Luca Carlon]

luc4 added a comment.


  Ping.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8c09cfd92dbf: ActionToolBar: Only show the overflow 
button if there are visible items in the… (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26279?vs=72344=72672

REVISION DETAIL
  https://phabricator.kde.org/D26279

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami, ngraham, apol
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

D26385: Kicker/RecentDocuments Avoid referring to hidden places

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26385

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26382: Port KCM menu away from PlasmaComponents

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Plasma's menu can't handle being in a nested window and opens in the
  wrong place.
  
  Porting to QQC resolves this, and we ideally shouldn't be using this
  import within a KCM.
  
  BUG: 414762

TEST PLAN
  Opened menu
  It was in the right place
  Clicking on delete still worked

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26382

AFFECTED FILES
  kcm/qml/ConnectionItem.qml

To: davidedmundson, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart