D26514: Delay popup for containments

trmdi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Make use of the new parameter added in D26484 BUG: 415917 TEST PLAN Drop files into

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

On Tuesday, January 07, 2020 10:51 CET, David Edmundson wrote: > I propose that we completely drop the Qt4 builds from Breeze+Oxygen > after Plasma 5.18. +1 from OpenMandriva -- we've dropped Qt 4.x a couple of months ago. ttyl bero

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

On Jan 7, 2020, at 3:51 AM, David Edmundson wrote: > > We're starting to see a lot of preparation for Qt6 porting API which > we know will be deprecated. > > One place where this is problematic is Breeze + Oxygen QStyles where > we currently provide Qt4 builds. I don't want this to hold us back

D26482: [Folder view] Don't create a rubberband when dragging during a rename

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d4d39892d62e: [Folder view] Dont create a rubberband when dragging during a rename (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ngraham updated this revision to Diff 73023. ngraham added a comment. Add a `preferred://wallpaperlocations` token and replace it with the real values REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26483?vs=72941=73023 BRANCH

D26510: [wallpapers/image] Disambiguate identical folder names in paths list

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY When multiple paths that end in the same folder name are added (for example with D26483

D26386: Kicker/RecentDocuments: add icons to actions

hein accepted this revision. hein added a comment. Good stuff! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26386 To: meven, #plasma, ngraham, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This rewrites the "Background services" KCM in QML using `ScrollViewKCM`. The two separate

D26261: Rewrite GTK KCM

gikari requested review of this revision. gikari marked an inline comment as done. gikari added a comment. This revision is now accepted and ready to land. > Taking advantage of the GTK_THEME environment variable would be a more elegant solution On the other hand this does not work for

D26261: Rewrite GTK KCM

gikari updated this revision to Diff 73015. gikari added a comment. - Fixed combobox selection after theme deletion (please test) - Minor code style changes REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26261?vs=73006=73015 BRANCH

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

On 1/7/20 11:51 AM, David Edmundson wrote: > I propose that we completely drop the Qt4 builds from Breeze+Oxygen > after Plasma 5.18. +1

D26504: [WIP] [Panel Shadows] Port to KWindowSystem shadows API

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. TEST PLAN Compile check only. REPOSITORY R120 Plasma Workspace BRANCH port-to-shadows-api REVISION DETAIL

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/48/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 18:11:24 + Build duration: 3 min 46 sec and counting JUnit Tests Name:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 49 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/49/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 18:11:20 + Build duration: 3 min 48 sec and counting JUnit Tests

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/26/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 07 Jan 2020 18:11:21 + Build duration: 2 min 29 sec and counting JUnit Tests

D26261: Rewrite GTK KCM

gikari added a comment. In D26261#589834 , @cblack wrote: > Code-wise, all of the stuff touching GTK looks fine except for the overengineered GTK3 theme preview, but that's relatively minor since it should still work as intended. I will

D26261: Rewrite GTK KCM

cblack accepted this revision. cblack added a comment. Code-wise, all of the stuff touching GTK looks fine except for the overengineered GTK3 theme preview, but that's relatively minor since it should still work as intended. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH

D26261: Rewrite GTK KCM

ngraham added a comment. that's weird, it started working for me after your last update... REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-theme-through-kded REVISION DETAIL https://phabricator.kde.org/D26261 To: gikari, apol, #vdg, ngraham Cc: cblack, baberts, ngraham,

D26261: Rewrite GTK KCM

gikari added a comment. In D26261#589829 , @ngraham wrote: > Everything works Wait, I didn't fixed the empty combobox thing yet REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-theme-through-kded REVISION DETAIL

D26261: Rewrite GTK KCM

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, we can fix that separately then. Everything works, so I'm giving this my QA blessing. Please wait for code review approval from @cblack or a #plasma

D26261: Rewrite GTK KCM

gikari added a comment. In D26261#589827 , @ngraham wrote: > I don't know if this is a bug in the KCM or a bug in the GHNS dialog, but when I delete a theme from the KCM, it's still listed as installed in the dialog. However when I delete a

D26261: Rewrite GTK KCM

ngraham added a comment. Nice, works fine for those now. I don't know if this is a bug in the KCM or a bug in the GHNS dialog, but when I delete a theme from the KCM, it's still listed as installed in the dialog. However when I delete a theme from the dialog, it disappears from the KCM as

D26261: Rewrite GTK KCM

gikari updated this revision to Diff 73006. gikari added a comment. Do not display error, when the theme archive selection is canceled REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26261?vs=72305=73006 BRANCH set-theme-through-kded

D26261: Rewrite GTK KCM

ngraham added a comment. If it needs to instantly apply something, sure, I guess it can instantly apply Breeze. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26261 To: gikari, apol, #vdg, ngraham Cc: cblack, baberts, ngraham, plasma-devel,

D26261: Rewrite GTK KCM

gikari added a comment. > It doesn't need to instantly apply it, but it should select Breeze and mark the state as dirty so the Apply button becomes enabled. But the theme is now deleted and configuration is in the incorrect state - GTK apps are requesting a theme, that does not exist

D26261: Rewrite GTK KCM

ngraham added a comment. In D26261#589811 , @gikari wrote: > > - When you delete the current theme, the combobox becomes empty. It should probably go back to the default theme or Breeze or something. > > So, it needs to select Breeze in

D26261: Rewrite GTK KCM

gikari added a comment. > - When you delete the current theme, the combobox becomes empty. It should probably go back to the default theme or Breeze or something. So, it needs to select Breeze in otherwise empty combobox and instantly apply it? REPOSITORY R99 KDE Gtk Configuration

D26261: Rewrite GTK KCM

cblack added inline comments. INLINE COMMENTS > themepreviewer.cpp:85 > + > +void ThemePreviewer::showGtk3App(const QString& themeName) > +{ Taking advantage of the `GTK_THEME` environment variable would be a more elegant solution than copying the current configuration to another place,

D26261: Rewrite GTK KCM

ngraham added a comment. Never mind, I was an idiot and hadn't restarted kded5. Almost everything works perfectly after that. I only found two bugs: - When you delete the current theme, the combobox becomes empty. It should probably go back to the default theme or Breeze or something.

D26261: Rewrite GTK KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. When I apply this and go to the rewritten KCM, the comboboxes are both empty: F7867971: Screenshot_20200107_095737.png Also clicking

D26386: Kicker/RecentDocuments: add icons to actions

meven planned changes to this revision. meven added inline comments. INLINE COMMENTS > actionlist.cpp:62 > > +if (!icon.isEmpty()) { > +map[QStringLiteral("icon")] = icon; Remove this if > recentcontactsmodel.cpp:93 > > -actionList << Kicker::createActionItem(i18n("Show

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

In data martedì 7 gennaio 2020 10:51:19 CET, David Edmundson ha scritto: > I propose that we completely drop the Qt4 builds from Breeze+Oxygen > after Plasma 5.18. From the openSUSE side: +1. We're trying to get rid of Qt4 applications / libs / whatever entirely and this is another nail in the

D26261: Rewrite GTK KCM

ngraham added a comment. I think in the VDG channel we decided to put the GTK config stuff on another page accessed by clicking on a button. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26261 To: gikari, apol, #vdg Cc: baberts, ngraham,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidedmundson added a comment. Sure REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

ngraham added a comment. In D26483#589401 , @broulik wrote: > Perhaps we could leverage some code from Task Manager to have a fake `preferred://wallpaperlocation` URL or something like that? That might be able to work. @davidedmundson,

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 57 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/57/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 07 Jan 2020 15:33:54 + Build duration: 56 min and counting

Plasma 5.17.5

Plasma 5.17.5 sources are out now for packaging and distributing https://kde.org/announcements/plasma-5.17.5.php

D26447: Dynamically show and hide based on whether or not any vaults are configured

This revision was automatically updated to reflect the committed changes. Closed by commit R845:f8c6924510ea: Dynamically show and hide based on whether or not any vaults are configured (authored by ngraham). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE

D26447: Dynamically show and hide based on whether or not any vaults are configured

ngraham added a comment. Thanks! REPOSITORY R845 Plasma Vault BRANCH dynamically-show-and-hide (branched from master) REVISION DETAIL https://phabricator.kde.org/D26447 To: ngraham, broulik, ivan, #plasma, #vdg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26149: Change krunner calculator to display significant digits

ngraham added a comment. Thanks very much for the patch! May it be the first of many. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26149 To: lukjp, broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26149: Change krunner calculator to display significant digits

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e374492d24f4: Change krunner calculator to display significant digits (authored by lukjp, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Re: New Emojier translations

On Mon, Dec 30, 2019 at 8:26 PM Luigi Toscano wrote: > > Yuri Chornoivan ha scritto: > > Hi, > > > > There is a report in Russian mailing list that the translations for the new > > emoji KCM [1] do not work. It is reported that the catalog name > > (plasma_applet_org.kde.kimpanel.po [2]) does not

D26037: feat(kded): add orientation sensor

davidedmundson added inline comments. INLINE COMMENTS > romangg wrote in orientation_sensor.cpp:29 > Yea, we need to start it in the beginning to see if a sensor is available. > But we could cache the result and then shut it off again in case auto > rotation or screen is off. Needs some more

D26499: remove an unused header

miklosm created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. miklosm requested review of this revision. REVISION SUMMARY It was imported from libksysguard, but I don't know why. REPOSITORY R120 Plasma Workspace REVISION DETAIL

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 86 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/86/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 07 Jan 2020 15:17:41 + Build duration: 39 min and counting JUnit Tests

D26310: feat: use Control and logical size APIs for replicas

romangg added a comment. I missed to update the test plan. So for reference: this is at it landed unrelated to Wayland and instead altering the behavior on X11. This should make the saving and loading of replications there more robust. REPOSITORY R104 KScreen REVISION DETAIL

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 239 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/239/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 15:13:10 + Build duration: 25 min and counting JUnit Tests Name:

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 56 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/56/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 07 Jan 2020 15:03:18 + Build duration: 30 min and counting CONSOLE OUTPUT

D25947: Add applet for controlling Night Color

This revision was automatically updated to reflect the committed changes. Closed by commit R114:a18bc820ca90: Add applet for controlling Night Color (authored by zzag). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=72987=72988 REVISION DETAIL

D25947: Add applet for controlling Night Color

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in main.qml:98 > Could you please explain why it needs to be in an else? I assumed it was trying to remove the action created here: plasmoid.setAction(..."configure"); I see now that "configure" on the setAction is the icon

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 72987. zzag added a comment. Add braces. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71537=72987 BRANCH arcpatch-D25947 REVISION DETAIL https://phabricator.kde.org/D25947 AFFECTED FILES

D25947: Add applet for controlling Night Color

zzag added a comment. > Does it make sense to dump the C++ classes in libcolorcorrect? I think it will be better to keep them here for now. Once somebody needs one of them, we can move them to libcolorcorrect (bad name). INLINE COMMENTS > davidedmundson wrote in main.qml:98 > Should >

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 93 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/93/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 15:14:40 + Build duration: 9 min 31 sec and counting JUnit Tests

D26481: feat(kcm): control scale

davidedmundson added a comment. I don't understand where you're going with this. Can you explain what backend doesn't have a scale that is still worth saving on the output? On wayland we do have scale transmitted, for X we don't currently support per-output scaling. REPOSITORY

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 85 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/85/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 07 Jan 2020 15:00:28 + Build duration: 17 min and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 92 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/92/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 15:03:18 + Build duration: 10 min and counting CONSOLE OUTPUT

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/47/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 15:03:02 + Build duration: 10 min and counting CONSOLE OUTPUT

D26354: Introduce ActionRow widget

ngraham added a comment. In D26354#589352 , @mart wrote: > also a component like that back then was chosen to not be added by purpose in part because gesture-wise conflicts with the navigate back of pagerow Personally I don't find

D26481: feat(kcm): control scale

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:a5c4e9906322: feat(kcm): control scale (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D26281: feat: add auto rotate and tablet mode information

This revision was automatically updated to reflect the committed changes. Closed by commit R110:50969ab6cbb7: feat: add auto rotate and tablet mode information (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26281?vs=72351=72981

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 238 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/238/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 15:00:28 + Build duration: 7 min 32 sec and counting CONSOLE OUTPUT

D26310: feat: use Control and logical size APIs for replicas

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:b3a8d590: feat: use Control and logical size APIs for replicas (authored by romangg). CHANGED PRIOR TO COMMIT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 48 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/48/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 14:57:55 + Build duration: 2 min 37 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/25/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 07 Jan 2020 14:57:55 + Build duration: 2 min 48 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/30/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 Jan 2020 14:58:26 + Build duration: 2 min 8 sec and counting CONSOLE OUTPUT

D26220: feat: control replication

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:19e6756fc1ae: feat: control replication (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D26309: feat: replace replication source with logical size API

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:6a5a180bbedf: feat: replace replication source with logical size API (authored by romangg). REPOSITORY R110 KScreen

D26447: Dynamically show and hide based on whether or not any vaults are configured

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. That is why I put the "or in addition to" part. Anyhow, I don't mind this to go in as is. REPOSITORY R845 Plasma Vault BRANCH dynamically-show-and-hide (branched from master)

D26494: Runner/Windows make the window finding more reliable

meven created this revision. meven added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Call gatherInfo immediately after prepareForMatchSession QTimer::singleShot could dispatched

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidedmundson added a comment. I don't think so, as we use a runtime evaluation of kcfg files within plasma. Code tags won't work there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre,

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidre added a comment. Couldn't we just use wrap the folders from the single image case in a code tag? `QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("wallpapers/"), QStandardPaths::LocateDirectory)` REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25947: Add applet for controlling Night Color

davidedmundson accepted this revision. davidedmundson added a comment. Does it make sense to dump the C++ classes in libcolorcorrect? It has an import for use client side usage for the KCM, his is just another client, especially inhibitor. INLINE COMMENTS > main.qml:96 > +

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

+1 On Tue, Jan 7, 2020 at 11:29 AM Harald Sitter wrote: > > +1 > > On Tue, Jan 7, 2020 at 10:51 AM David Edmundson > wrote: > > > > We're starting to see a lot of preparation for Qt6 porting API which > > we know will be deprecated. > > > > One place where this is problematic is Breeze + Oxygen

D25179: Don't move the drawer collapse button if there's no icon or image

apol abandoned this revision. apol added a comment. collapseButton isn't a thing anymore, at least as is. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25179 To: apol, #kirigami, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D26421: Only show full name in review dialog

jgrulich added a comment. I don't really remember, but I can see in the userHash() it's not used so this is probably safe. In the userHash() we directly use KUser(). REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26421 To: ngraham,

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72964. meven added a comment. Handle BlacklistedApplicationsModel properly, prevent a warning 'duplicate connection name' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72850=72964 BRANCH

D26489: Use qmlRegisterAnonymousType

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. needs a qt version `ifdef` REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26489 To: tcanabrava, broulik Cc: broulik, plasma-devel, LeGast00n,

D26183: Fix build with Qt 5.14

tcanabrava abandoned this revision. tcanabrava added a comment. since this is commited already I'm closing, and opened a follow up commit: https://phabricator.kde.org/D26489 REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26183 To: tcanabrava, davidedmundson,

D26489: Use qmlRegisterAnonymousType

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R112 Milou BRANCH useQmlRegisterAnonymousType REVISION DETAIL https://phabricator.kde.org/D26489 AFFECTED FILES

D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

fvogt added a comment. IMO it should still be considered if it's the only one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26330 To: broulik, #plasma Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

+1 On Tue, Jan 7, 2020 at 10:51 AM David Edmundson wrote: > > We're starting to see a lot of preparation for Qt6 porting API which > we know will be deprecated. > > One place where this is problematic is Breeze + Oxygen QStyles where > we currently provide Qt4 builds. I don't want this to hold

D26485: [Pager] Fix switching pages on

broulik closed this revision. broulik added a comment. f5d1675a0dc1a1a0098eb5b1c727b5fe197e9930 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26485 To: broulik, #plasma, hein, mart

D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d2d30a9667d2: [KRunner KCM] Mark KCM as dirty when plugin configuration changes (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26425: [Notifications KCM] Fixup current item syncing logic

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b639338291d4: [Notifications KCM] Fixup current item syncing logic (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26476: [kstyle] Remove shadows in Qt 4 style plugin

zzag added a comment. Do you suggest to move qt 4 style plugin to its own repo? I'm not sure that I follow you. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26476 To: zzag, #kwin, #plasma Cc: davidedmundson, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26476: [kstyle] Remove shadows in Qt 4 style plugin

davidedmundson added a comment. I don't think this is the right approach as it regresses the Qt4 style. We can achieve the same thing by having packagers just continue to build an existing old tarball. They keep the shadows, and we can fix Breeze not just for this but other Qt5 porting.

RFC: Dropping Breeze + Oxygen Qt4 builds after

We're starting to see a lot of preparation for Qt6 porting API which we know will be deprecated. One place where this is problematic is Breeze + Oxygen QStyles where we currently provide Qt4 builds. I don't want this to hold us back and be a problem later. It's also a problem for some shadow

D26416: Kicker/Documents optimization: Lazily build KFileItem

broulik added a comment. Would be lovely in the future to cache those items and make it a proper model with backing data rather than requesting everything on demand every time `data` is called. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26416 To:

D25984: Load translations

mart added a comment. ping, what's the current status of this? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D26475: [kstyle] Port to KWindowSystem shadows API

mart accepted this revision as: Plasma, mart. mart added a comment. This revision is now accepted and ready to land. on the breeze-style side, this looks good REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26475 To: zzag, #kwin, #plasma, mart Cc: mart, plasma-devel,

D26476: [kstyle] Remove shadows in Qt 4 style plugin

mart added a comment. not an huge loss for me, qt4 clients are becoming very rare anyways REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26476 To: zzag, #kwin, #plasma Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26456: KCM runners : fix reset and default behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9d200f06d6cd: KCM runners : fix reset and default behavior (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26456?vs=72861=72952

D26467: KCM runners: fix default button

This revision was automatically updated to reflect the committed changes. Closed by commit R119:be1eacc05b1f: KCM runners: fix default button (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26467?vs=72905=72953 REVISION DETAIL

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

broulik added a comment. Perhaps we could leverage some code from Task Manager to have a fake `preferred://wallpaperlocation` URL or something like that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis,

D25103: Simplify application load

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. I wanted to keep this as an example since while in here having 2 different main files doesn't change much , but for complex apps is really the way i would ask for it to be done in

D26485: [Pager] Fix switching pages on

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The code was clearly intending to use the index, as indicated by a comparison with

D26200: Add shortcut for closing pages

mart added a comment. hmm, not sure about it. it would probably be ok for most of the cases, but i'm pretty sure it may break some existing app. an app may want at least two pages always loaded for instance (if uses one for sidebar, one for main content) REPOSITORY R169 Kirigami

D26354: Introduce ActionRow widget

mart added a comment. my gripe is that is a lot of javascript which could be simply implemented with a swipedelegate, having less heavy javascript which is a serious problem when used in delegates. also a component like that back then was chosen to not be added by purpose in part

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. It's not ok for the reasons you identified. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg,

D26304: [PageRow] Disable swipe forwards/backwards gesture by default

mart added a comment. also, on plasma mobile, there is no global back button, and i don't want any back button anywhere in the app REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26304 To: cblack, #vdg, #kirigami, mart Cc: mart, ndavis, ouwerkerk, plasma-devel,

  1   2   >