D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:02c89d749475: [applets/digital-clock] Fix truncated Long Date display in a vertical panel (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26547: pk: Load the AppStream database on a separate thread

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:2ce5eb9dab5b: pk: Load the AppStream database on a separate thread (authored by apol). CHANGED PRIOR TO COMMIT

D26547: pk: Load the AppStream database on a separate thread

apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > broulik wrote in PackageKitBackend.cpp:502 > Why is this delayed now? It's a quirk of how ResultsStream works. We need the results to be emitted when something is listening to it. If you look at it closely, it

D26547: pk: Load the AppStream database on a separate thread

apol updated this revision to Diff 73173. apol marked an inline comment as done. apol added a comment. kai comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26547?vs=73139=73173 BRANCH arcpatch-D26547 REVISION DETAIL

D26552: [KCMs/Feedback] Adjust UI to be more user-friendly

ngraham marked an inline comment as done. ngraham added subscribers: broulik, mart. ngraham added inline comments. INLINE COMMENTS > apol wrote in main.qml:123 > Why less opacity? It looks like it's disabled. This is the header/subtitle style we have to use because @mart and @broulik veto bold

D26552: [KCMs/Feedback] Adjust UI to be more user-friendly

ngraham updated this revision to Diff 73167. ngraham removed subscribers: mart, broulik. ngraham added a comment. Adjust opening text to mention Plasma REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26552?vs=73151=73167 BRANCH

D26552: [KCMs/Feedback] Adjust UI to be more user-friendly

apol added inline comments. INLINE COMMENTS > main.qml:53 > wrapMode: Text.WordWrap > -text: xi18nc("@info", "You can read about our policy in the > following link:") > +text: xi18nc("@info", "You can help KDE improve this software by > contributing

D26547: pk: Load the AppStream database on a separate thread

broulik added inline comments. INLINE COMMENTS > PackageKitBackend.cpp:198 > } > +} else > +ret.components << component; Coding style .. > PackageKitBackend.cpp:502 > +} else { > +QTimer::singleShot(0, this, f); > +} Why is this

D24033: Add Meta+Space as a default shortcut to activate KRunner

ngraham added a comment. Yes, I reverted it in 469a7c1e33f83d6b73610997811fb131b5af80ca , which was released with Plasma 5.17.5. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26552: [KCMs/Feedback] Adjust UI to be more user-friendly

ngraham created this revision. ngraham added reviewers: VDG, Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Adjust to the string changes in D26551 and

D24033: Add Meta+Space as a default shortcut to activate KRunner

aalam added a comment. Hi @ngraham Have you got chance to revert it? As KDE multilingual user, I still not able to use ibus keyboard in KDE from last month even tried to reset keyboard shortcut. Help will be really appreciated. REPOSITORY R120 Plasma Workspace REVISION

D26037: feat(kded): add orientation sensor

romangg updated this revision to Diff 73148. romangg marked 2 inline comments as done. romangg added a comment. - Use connectedToBackend getter - Replace DeviceOrientation REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26037?vs=73146=73148 BRANCH

D26037: feat(kded): add orientation sensor

romangg updated this revision to Diff 73146. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26037?vs=72352=73146 BRANCH orientation-sensor REVISION DETAIL https://phabricator.kde.org/D26037 AFFECTED FILES

D25449: Start of the new Formats KCM

tcanabrava marked an inline comment as done. tcanabrava added a comment. > Imho a custom `ComboBox` with a search field in its popup or something like that would be a better control. I tried to use the combobox (but of course phabricator destroys my history so it's hard to even

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73145. tcanabrava added a comment. - Readd writeexports.h REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73135=73145 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 31 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/31/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 Jan 2020 17:41:46 + Build duration: 10 min and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 Jan 2020 17:41:42 + Build duration: 7 min 47 sec and counting JUnit Tests Name:

D26547: pk: Load the AppStream database on a separate thread

apol added a comment. In D26547#590948 , @ngraham wrote: > Very nice. Launching definitely feels faster now. This also fixes https://bugs.kde.org/show_bug.cgi?id=409262 for me. Does that make any sense? Yes, it makes sense. > One

D26548: [Applet]Fix empty space and give correct size

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R115 Plasma Audio Volume Applet BRANCH size (branched from master) REVISION DETAIL https://phabricator.kde.org/D26548 To: gvgeo, #vdg, #plasma, drosca, ngraham

D26547: pk: Load the AppStream database on a separate thread

ngraham added a comment. Very nice. Launching definitely feels faster now. This also fixes https://bugs.kde.org/show_bug.cgi?id=409262 for me. Does that make any sense? One thing I notice is that the increased speed results in the "you're not connected to a network" message erroneously

D26548: [Applet]Fix empty space and give correct size

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Make default size same with system tray. Inside area is bigger, without the system tray

D26547: pk: Load the AppStream database on a separate thread

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to block the backends load on PackageKit appstream usage. BUG: 409599 TEST PLAN Tested manually REPOSITORY R134

D26537: [startkde] Drop hack to manually set XDG_DATA_DIRS to the install root

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3c1a34a26dbd: [startkde] Drop hack to manually set XDG_DATA_DIRS to the install root (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25449: Start of the new Formats KCM

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcm.cpp:39 > +{ > +qmlRegisterAnonymousType("kcm.kde.org", 1); > +qmlRegisterAnonymousType("kcm.kde.org", 1); this is 5.14 only from which we can't

D22176: Rework system tray settings

nicolasfella added a comment. yes, feel free to take it over :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D25449: Start of the new Formats KCM

broulik added a comment. I'm not a huge fan of that language list selection mode, it's unlike anything we use anywhere else. Most importantly, it makes the KCM take *forever* to load as it creates the entire list at once. Instead, you want to use the `ListView` properly so only that part

D26271: [Applet]Update layout based on T10470

ngraham added a comment. Yeah, feel free to fix those bugs separately so we can get them in more quickly. Personally I don't think there's a major use case for manipulating the settings of a port when it's not actually being used. REPOSITORY R115 Plasma Audio Volume Applet REVISION

D22176: Rework system tray settings

ngraham added a comment. Maybe you can commandeer it if @nicolasfella lacks the time? The two of you can share credit. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham,

D25449: Start of the new Formats KCM

ngraham added reviewers: VDG, Plasma. ngraham added a comment. Doesn't build for me: [ 67%] Building CXX object kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/kcmspellchecking_autogen/mocs_compilation.cpp.o /home/nate/kde/src/plasma-desktop/kcms/formats/kcm.cpp: In constructor

D22176: Rework system tray settings

kmaterka added a comment. It looks abandoned, but rewrite of configuration is very needed, users are confused (and there are bug reports due to this). I have few more idea: - checkbox "Always show all entries" is misleading now. It won't enable all applets. When checked, it is no

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73135. tcanabrava added a comment. - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73130=73135 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449 AFFECTED FILES

D26271: [Applet]Update layout based on T10470

gvgeo added a comment. It makes possible to change volume/mute before plug something. But have no idea, if there is any real reason. --- About these 2 bugs https://bugs.kde.org/show_bug.cgi?id=393418, https://bugs.kde.org/show_bug.cgi?id=413448 . Should I separate the fixes from

D25449: Start of the new Formats KCM

mart added a comment. code-wise looks good now REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26392: Add option to easily configure and start a hotspot

jgrulich added a comment. In D26392#590884 , @ngraham wrote: > No, even with networkmanager-qt from git master, I still get the same build failure here. :( That's weird, because you can see here [1] that it's definitely there. [1] -

D26545: [SystemTray] Set maximum size to block tiling

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4a65dcefe494: [SystemTray] Set maximum size to block tiling (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26545?vs=73131=73134

D26271: [Applet]Update layout based on T10470

ngraham added a comment. > But this would made impossible to select an unavailable port from kcm too. Is there an actual use case for this? If not, option 2 might make the most sense. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26271 To:

D26392: Add option to easily configure and start a hotspot

ngraham added a comment. No, even with networkmanager-qt from git master, I still get the same build failure here. :( REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D26392 To: jgrulich, #plasma, ngraham, #vdg Cc: alexde, mthw, apol,

D26545: WIP: [SystemTray] Set maximum size to block tiling

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26545 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik,

D26545: WIP: [SystemTray] Set maximum size to block tiling

kmaterka added a comment. In D26545#590861 , @ngraham wrote: > FWIW it is possible to restore the original size by using the same tiling shortcut again. Oh, I tested this on multi-screen setup, but it is working indeed if: - I use

D26545: WIP: [SystemTray] Set maximum size to block tiling

ngraham added a comment. FWIW it is possible to restore the original size by using the same tiling shortcut again. Still a bug that should be fixed of course, and this is the way that Kicker and Kickoff and others prevent tiling. For now, it seems sane enough to do the same thing here

D26545: WIP: [SystemTray] Set maximum size to block tiling

kmaterka added a comment. There must be a better way to fix that. Layout.minimum = Layout.maximum has nice side affect that does what I want, but maybe better place is to change some (?) window flags in PlasmaCode.Dialog? INLINE COMMENTS > CalendarView.qml:36-37 >

D26545: WIP: [SystemTray] Set maximum size to block tiling

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY System tray dialog/popup can be tiled. This should not be allowed, in this case expanded

D25449: Start of the new Formats KCM

ngraham added a comment. Can you please rebase this on current master? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin Cc: ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73130. tcanabrava added a comment. - Change how we set locales - Set the locale - Add missing files - Typos - Set the correct size of the list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26354: Introduce ActionRow widget

ngraham added a comment. In D26354#590815 , @mart wrote: > SwipeListItem should just trigger when there is only one action, really (and that one doesn't conflict because the swipe is from the screen edge) Hey yeah, that could work.

D26544: [WIP] Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Change the colors KCM code to take data from a Qt Quick based GHNS dlg Switch the Colors KCM UI to using KNSQuick Only link

D26354: Introduce ActionRow widget

mart added a comment. In D26354#589642 , @ngraham wrote: > In D26354#589352 , @mart wrote: > > > also a component like that back then was chosen to not be added by purpose in part because

D26533: Add a logging category for the backend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:160f10328366: Add a logging category for the backend (authored by meven). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26533?vs=73119=73121

D26533: Add a logging category for the backend

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok now for me :) thanks REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc:

D26533: Add a logging category for the backend

meven marked an inline comment as done. meven added a comment. ping @mlaurent REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26533: Add a logging category for the backend

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:14 > Why adding it ? it's autogenerated so it's added by cmake directly The issue was that add_library takes directly a list of cpp directly, but

D26533: Add a logging category for the backend

meven updated this revision to Diff 73119. meven added a comment. Fix CMake( add _SRCS vars) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26533?vs=73096=73119 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26533

D26392: Add option to easily configure and start a hotspot

jgrulich added a comment. In D26392#588994 , @ngraham wrote: > This no longer compiles for me: > > /home/nate/kde/src/plasma-nm/libs/handler.cpp: In member function ‘void Handler::createHotspot()’: >

D26531: [Wallpaper] Show author as subtitle in configuration

broulik added a comment. > "By" can also be tricky to translate into other languages That's why we have context. Currently it also has " by " explanation. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: filipf,

D26271: [Applet]Update layout based on T10470

gvgeo planned changes to this revision. gvgeo added a comment. Found a bug. There is no update when a port that is not in use gets unavailable. Why is a problem in this patch: When using port 1, if port 2 becomes unavailable, is possible to switch to port that is unavailable. The

D26531: [Wallpaper] Show author as subtitle in configuration

broulik added a comment. > However I see a problem with the delegate cell size: That's unrelated and something I would have expected was tested when this feature was added. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma,