D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#602082 , @filipf wrote:
  
  > ^ I can't reproduce that, the patch works as intended for me.  (we should 
investigate this though)
  >
  > One thing to just comment is that this is tailor-made for Breeze (the 1px 
thing), but it looks fine with other themes and I don't really know of any 
other solution.
  
  
  Try changing the General Font size to see if you can reproduce it. On my 
system, I can reproduce it with `Noto 10`, but not with `Noto 11`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26896: Kill the KinfoCenter binary

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> CMakeLists.txt:85
> -configure_file(config-project-version.h.cmake 
> ${CMAKE_CURRENT_BINARY_DIR}/config-project-version.h)
> -configure_file(config-X11.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-X11.h)
>  include_directories(${CMAKE_CURRENT_BINARY_DIR})

Removing this file is breaking the compilation: 
https://build.kde.org/view/Failing/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/

  05:48:56  In file included from 
/usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 
FreeBSDQt5.13/Modules/base/os_current.cpp:24:
  05:48:56  /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 
FreeBSDQt5.13/Modules/pci/../base/os_base.h:35:10: fatal error: 'config-X11.h' 
file not found
  05:48:56  #include 
  05:48:56   ^~

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma, davidedmundson
Cc: jjazeix, ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Méven Car]

meven updated this revision to Diff 74541.
meven marked 7 inline comments as done.
meven added a comment.


  Code formatting, add qAsConst, only search for one directory 
kcm_componentchooser to find its components

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26797?vs=74304=74541

BRANCH
  arcpatch-D26797

REVISION DETAIL
  https://phabricator.kde.org/D26797

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browserconfig_ui.ui
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/componentconfig_ui.ui
  kcms/componentchooser/emailclientconfig_ui.ui
  kcms/componentchooser/filemanagerconfig_ui.ui
  kcms/componentchooser/kcm_componentchooser.cpp
  kcms/componentchooser/kcm_componentchooser.h
  kcms/componentchooser/terminalemulatorconfig_ui.ui

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 92 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/92/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 29 Jan 2020 04:45:28 +
 Build duration:
3 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 502 lines...][2020-01-29T04:48:53.397Z] [ 61%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/totalMemoryChart.cpp.o[2020-01-29T04:48:53.998Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/nics/nic.cpp:132:16: warning: unused function 'HWaddr2String' [-Wunused-function][2020-01-29T04:48:53.998Z] static QString HWaddr2String(const char *hwaddr) {[2020-01-29T04:48:53.998Z]^[2020-01-29T04:48:53.998Z] [ 62%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/info.cpp.o[2020-01-29T04:48:53.998Z] 1 warning generated.[2020-01-29T04:48:53.998Z] [ 64%] Linking CXX shared module ../../bin/kcm_nic.so[2020-01-29T04:48:54.277Z] [ 66%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/__/base/os_current.cpp.o[2020-01-29T04:48:54.277Z] [ 67%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/__/base/info_wayland.cpp.o[2020-01-29T04:48:54.277Z] [ 67%] Built target kcm_nic[2020-01-29T04:48:54.277Z] [ 69%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/kpci.cpp.o[2020-01-29T04:48:54.554Z] [ 70%] Building CXX object Modules/opengl/CMakeFiles/kcm_opengl.dir/opengl.cpp.o[2020-01-29T04:48:54.554Z] [ 72%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/physicalMemoryChart.cpp.o[2020-01-29T04:48:54.554Z] [ 74%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/infopanel.cpp.o[2020-01-29T04:48:54.554Z] [ 75%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/ksmbstatus.cpp.o[2020-01-29T04:48:54.554Z] [ 77%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/soldevicetypes.cpp.o[2020-01-29T04:48:54.821Z] [ 79%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcmsambaimports.cpp.o[2020-01-29T04:48:54.821Z] [ 80%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcmsambalog.cpp.o[2020-01-29T04:48:55.444Z] [ 82%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/swapMemoryChart.cpp.o[2020-01-29T04:48:56.033Z] [ 83%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/os_current.cpp.o[2020-01-29T04:48:56.033Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/os_current.cpp:24:[2020-01-29T04:48:56.033Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/pci/../base/os_base.h:35:10: fatal error: 'config-X11.h' file not found[2020-01-29T04:48:56.033Z] #include [2020-01-29T04:48:56.033Z]  ^~[2020-01-29T04:48:56.033Z] 1 error generated.[2020-01-29T04:48:56.033Z] gmake[2]: *** [Modules/pci/CMakeFiles/kcm_pci.dir/build.make:89: Modules/pci/CMakeFiles/kcm_pci.dir/__/base/os_current.cpp.o] Error 1[2020-01-29T04:48:56.033Z] gmake[2]: *** Waiting for unfinished jobs[2020-01-29T04:48:56.033Z] [ 85%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/qvlistlayout.cpp.o[2020-01-29T04:48:56.033Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:76:18: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-29T04:48:56.033Z] [this, interfacesItem] (const QByteArray , quint32 name, quint32 version) {[2020-01-29T04:48:56.033Z]  ^[2020-01-29T04:48:56.033Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:87:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-29T04:48:56.033Z] [this, seat, seatItem] {[2020-01-29T04:48:56.033Z]  ^[2020-01-29T04:48:56.033Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:92:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-29T04:48:56.033Z] [this, seat, seatItem] {[2020-01-29T04:48:56.033Z]  ^[2020-01-29T04:48:56.033Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:108:42: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-29T04:48:56.033Z] [this, k, e, r, d] {[2020-01-29T04:48:56.033Z]  ^[2020-01-29T04:48:56.033Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:118:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-29T04:48:56.033Z] [this, seat, seatItem] {[2020-01-29T04:48:56.033Z]  ^[2020-01-29T04:48:56.033Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 154 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/154/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 29 Jan 2020 04:45:28 +
 Build duration:
2 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 585 lines...][2020-01-29T04:47:43.034Z] Unknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to string[2020-01-29T04:47:43.034Z] Unknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to string[2020-01-29T04:47:43.034Z] Unknown property type for key "X-KDE-Keywords[sv]" -> falling back to string[2020-01-29T04:47:43.034Z] Unknown property type for key "X-KDE-Keywords[tr]" -> falling back to string[2020-01-29T04:47:43.034Z] Unknown property type for key "X-KDE-Keywords[uk]" -> falling back to string[2020-01-29T04:47:43.034Z] Unknown property type for key "X-KDE-Keywords[x-test]" -> falling back to string[2020-01-29T04:47:43.034Z] Unknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to string[2020-01-29T04:47:43.034Z] Unknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to string[2020-01-29T04:47:43.034Z] Unknown property type for key "Categories" -> falling back to string[2020-01-29T04:47:43.034Z] Generated  "/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/build/Modules/energy/kcm_energyinfo.json"[2020-01-29T04:47:43.034Z] [ 10%] Automatic MOC for target kcm_energyinfo[2020-01-29T04:47:43.621Z] [ 10%] Built target kcm_energyinfo_autogen[2020-01-29T04:47:43.621Z] Scanning dependencies of target kcm_fileindexermonitor-kcms-metadata-json[2020-01-29T04:47:43.621Z] [ 11%] Generating kcm_fileindexermonitor-kcms-metadata.json[2020-01-29T04:47:43.621Z] Warning: Unable to find service type for service "Plasma/GenericQml" listed in "/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/fileindexermonitor/package/metadata.desktop" (/home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5 SUSEQt5.12/kcoreaddons/src/lib/plugin/desktopfileparser.cpp:573, bool DesktopFileParser::convert(const QString&, const QStringList&, QJsonObject&, QString*))[2020-01-29T04:47:43.621Z] Unknown property type for key "Keywords" -> falling back to string[2020-01-29T04:47:43.621Z] Unknown property type for key "X-KDE-ParentApp" -> falling back to string[2020-01-29T04:47:43.621Z] Unknown property type for key "X-Plasma-API" -> falling back to string[2020-01-29T04:47:43.621Z] Unknown property type for key "X-Plasma-MainScript" -> falling back to string[2020-01-29T04:47:43.621Z] Generated  "/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/build/Modules/fileindexermonitor/kcm_fileindexermonitor-kcms-metadata.json"[2020-01-29T04:47:43.621Z] [ 11%] Built target kcm_fileindexermonitor-kcms-metadata-json[2020-01-29T04:47:43.891Z] Scanning dependencies of target kcm_fileindexermonitor_autogen[2020-01-29T04:47:43.891Z] [ 13%] Generating kcm_fileindexermonitor.json[2020-01-29T04:47:43.891Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/kcmodule.desktop"[2020-01-29T04:47:43.891Z] Found property definition "X-KDE-FactoryName" with type "QString"[2020-01-29T04:47:43.891Z] Found property definition "X-KDE-ParentComponents" with type "QStringList"[2020-01-29T04:47:43.891Z] Found property definition "X-KDE-CfgDlgHierarchy" with type "QString"[2020-01-29T04:47:43.891Z] Found property definition "X-KDE-System-Settings-Parent-Category" with type "QString"[2020-01-29T04:47:43.891Z] Found property definition "X-KDE-KInfoCenter-Category" with type "QString"[2020-01-29T04:47:43.891Z] Found property definition "X-KDE-Weight" with type "int"[2020-01-29T04:47:43.891Z] Found property definition "X-KDE-PluginKeyword" with type "QString"[2020-01-29T04:47:43.891Z] Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-ParentApp" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords[ar]" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords[ca]" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords[ca@valencia]" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords[da]" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords[de]" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords[el]" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type for key "X-KDE-Keywords[es]" -> falling back to string[2020-01-29T04:47:43.891Z] Unknown property type 

D26979: KWallet-PAM SELinux context transition support

[secureworkstation]

secureworkstation created this revision.
secureworkstation added projects: Frameworks, Plasma.
Herald added a subscriber: plasma-devel.
secureworkstation requested review of this revision.

REVISION SUMMARY
  This patch is a repurposed patch by Daniel Walsh for gnome-keyring:
  
  
https://github.com/GNOME/gnome-keyring/commit/2f6a7c049dfffed20e3f78e3f51a8cca8735f2d3
  
https://github.com/GNOME/gnome-keyring/commit/74fc065e3c3e04a5cd5dfa0e725f7664825a5b1e
  https://bugzilla.redhat.com/show_bug.cgi?id=684225
  
  In short, for most (if not all) existing users this patch should do nothing: 
for those without SELinux, for those with SELinux disabled and for those with 
SELinux enabled in default settings. One would need to construct a policy and 
no such policy currently exists (but I'm working on one for Fedora and it's not 
a trivial job).
  
  SELinux works on labels given to processes and objects like files. Without 
this patch, pam_selinux (the PAM module, not this patch) transitions to the 
default user label which is used to launch kwalletd5 process by pam_kwallet. 
For me it's suboptimal, because I want to give it a dedicated label to further 
confine the process for security purposes. KWallet launched by user (not PAM) 
transitions correctly, it is just the PAM launch that requires special code.
  
  Ideally that could be a start to sandbox a lot more of Plasma using SELinux.
  
  Tracking bug on fedora-selinux Github on more work on confining Plasma using 
SELinux: https://github.com/fedora-selinux/selinux-policy-contrib/issues/192

TEST PLAN
  1. Make sure it compiles on machines without SELinux [done]
  2. Make sure it doesn't break SELinux-disabled installations [help wanted]
  3. Make sure it doesn't break vanilla SELinux installations [pending]
  4. Make sure it transitions to the correct label if a correct policy is 
present [done]

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D26979

AFFECTED FILES
  CMakeLists.txt
  pam_kwallet.c
  pam_selinux.c
  pam_selinux.h

To: secureworkstation
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26977: Fix setting of initial passwords for new users

[Nathaniel Graham]

ngraham added a comment.


  Oh gosh, every time someone touches that KCM to fix a bug, it breaks 
something else. :/ It's so fragile.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26977

To: davidedmundson, #plasma, meven
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag added a comment.


  > monitors compositing manager selections
  
  Only if XFIXES is present; otherwise it will fallback to 
`xcb_get_selection_owner` as Breeze does now.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26978

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26977: Fix setting of initial passwords for new users

[David Edmundson]

davidedmundson added a comment.


  Aha, found what changed it:
  
  2471fa7d252de904b305dac77171fa300d66c05d 

  
  - if (!roles.contains(Username) || !roles.contains(RealName) || 
!roles.contains(Administrator)) {
  
  +if (!roles.contains(Username) || !roles.contains(RealName)) {
  
  because administrator is set last, it was previously effectively doing what 
this patch is doing
  
  *but* on closer inspection what this is doing should work regardless, any 
setData that wasn't needed for creating an account was buffered, any new stuff 
in theory is on the same row, that row now has an entry in m_users so it should 
make the call

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26977

To: davidedmundson, #plasma, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Every time Breeze needs to check whether given widget has an alpha
  channel, it makes a synchronous X call to figure out whether a
  compositing window manager is running on a particular screen. This
  is inefficient!
  
  Luckily for us, Qt XCB QPA monitors compositing manager selections
  and caches the ownership status of each one. That cached ownership
  data can be accessed via QX11Info::isCompositingManagerRunning().

REPOSITORY
  R31 Breeze

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezewindowmanager.cpp

To: zzag, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26977: Fix setting of initial passwords for new users

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This is somewhat a simple fix for 5.18.0, but this really needs
  revisiting.
  
  The probelm is that newUserSetData is called N times for various
  properties. From the POV of this method, there is no way to no we're on
  teh last property. It simply checks for username and realname.
  
  However, the order the N properties are inserted is effectively
  undefined.
  
  The two things together don't work.
  
  This patch also blocks for the password.
  Ideally it needs to be setData, setData, setData, then some new flush
  method.
  
  There's a technical regression that you can no longer create a user account
  with no password, but that's arguably a feature.
  
  CCBUG: 416801

TEST PLAN
  Created a new user
  Looked in /etc/shadow

REPOSITORY
  R128 User Manager

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D26977

AFFECTED FILES
  src/lib/accountmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:84182a554588: [applets/Task Manager] Refine tooltip 
highlight effect (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=74475=74532

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26972: Work around an issue with changing the wallpaper's filetype

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:8f4ea0a93ffb: Work around an issue with changing the 
wallpapers filetype (authored by ngraham).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26972?vs=74527=74530

REVISION DETAIL
  https://phabricator.kde.org/D26972

AFFECTED FILES
  wallpapers/Next/contents/images/1024x768.jpg
  wallpapers/Next/contents/images/1024x768.png
  wallpapers/Next/contents/images/1280x1024.jpg
  wallpapers/Next/contents/images/1280x1024.png
  wallpapers/Next/contents/images/1280x800.jpg
  wallpapers/Next/contents/images/1280x800.png
  wallpapers/Next/contents/images/1366x768.jpg
  wallpapers/Next/contents/images/1366x768.png
  wallpapers/Next/contents/images/1440x900.jpg
  wallpapers/Next/contents/images/1440x900.png
  wallpapers/Next/contents/images/1600x1200.jpg
  wallpapers/Next/contents/images/1600x1200.png
  wallpapers/Next/contents/images/1680x1050.jpg
  wallpapers/Next/contents/images/1680x1050.png
  wallpapers/Next/contents/images/1920x1080.jpg
  wallpapers/Next/contents/images/1920x1080.png
  wallpapers/Next/contents/images/1920x1200.jpg
  wallpapers/Next/contents/images/1920x1200.png
  wallpapers/Next/contents/images/2560x1440.jpg
  wallpapers/Next/contents/images/2560x1440.png
  wallpapers/Next/contents/images/2560x1600.jpg
  wallpapers/Next/contents/images/2560x1600.png
  wallpapers/Next/contents/images/3200x1800.jpg
  wallpapers/Next/contents/images/3200x1800.png
  wallpapers/Next/contents/images/3200x2000.jpg
  wallpapers/Next/contents/images/3200x2000.png
  wallpapers/Next/contents/images/3840x2160.jpg
  wallpapers/Next/contents/images/3840x2160.png
  wallpapers/Next/contents/images/5120x2880.jpg
  wallpapers/Next/contents/images/5120x2880.png
  wallpapers/Next/contents/images/README

To: ngraham, davidedmundson, #plasma, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26912: Use Qt5 signal syntax, format files, optimizations

[Alexander Lohnau]

alex updated this revision to Diff 74528.
alex added a comment.


  Remove unnecessary parentheses.
  
  I just forgot to remove these, sorry.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26912?vs=74355=74528

REVISION DETAIL
  https://phabricator.kde.org/D26912

AFFECTED FILES
  kcms/autostart/AUTHORS
  kcms/autostart/addscriptdialog.cpp
  kcms/autostart/addscriptdialog.h
  kcms/autostart/advanceddialog.cpp
  kcms/autostart/advanceddialog.h
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.h
  kcms/autostart/autostartitem.cpp
  kcms/autostart/autostartitem.h

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26972: Work around an issue with changing the wallpaper's filetype

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Because of the issue described in T12611 
, changing the filetype of the Next 
wallpaper is
  problematic and will cause a black screen on upgrade.
  
  This terrible horrible patch works around the issue by using the .png 
filename extension
  even though this is not accurate. That way, the file names are the same as 
the old
  versions of the Next wallpaper and will be loaded correctly. Using the wrong 
filename
  extension does not actually cause any problems, it's just inaccurate. a 
`README` file is
  placed next to the images to explain this.
  
  I'm sorry.
  
  Long-term, we should investigate T12611 .

TEST PLAN
  Have previous Next wallpaper (Ice Cold) installed
  Replace it on disk with Volna in original JPEG form
  restart plasmashell -> black screen
  
  Try the above again with this patch
  restart plasmashell -> new wallpaper visible

REPOSITORY
  R31 Breeze

BRANCH
  fix-wallpaper-type-changing (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26972

AFFECTED FILES
  wallpapers/Next/contents/images/1024x768.jpg
  wallpapers/Next/contents/images/1024x768.png
  wallpapers/Next/contents/images/1280x1024.jpg
  wallpapers/Next/contents/images/1280x1024.png
  wallpapers/Next/contents/images/1280x800.jpg
  wallpapers/Next/contents/images/1280x800.png
  wallpapers/Next/contents/images/1366x768.jpg
  wallpapers/Next/contents/images/1366x768.png
  wallpapers/Next/contents/images/1440x900.jpg
  wallpapers/Next/contents/images/1440x900.png
  wallpapers/Next/contents/images/1600x1200.jpg
  wallpapers/Next/contents/images/1600x1200.png
  wallpapers/Next/contents/images/1680x1050.jpg
  wallpapers/Next/contents/images/1680x1050.png
  wallpapers/Next/contents/images/1920x1080.jpg
  wallpapers/Next/contents/images/1920x1080.png
  wallpapers/Next/contents/images/1920x1200.jpg
  wallpapers/Next/contents/images/1920x1200.png
  wallpapers/Next/contents/images/2560x1440.jpg
  wallpapers/Next/contents/images/2560x1440.png
  wallpapers/Next/contents/images/2560x1600.jpg
  wallpapers/Next/contents/images/2560x1600.png
  wallpapers/Next/contents/images/3200x1800.jpg
  wallpapers/Next/contents/images/3200x1800.png
  wallpapers/Next/contents/images/3200x2000.jpg
  wallpapers/Next/contents/images/3200x2000.png
  wallpapers/Next/contents/images/3840x2160.jpg
  wallpapers/Next/contents/images/3840x2160.png
  wallpapers/Next/contents/images/5120x2880.jpg
  wallpapers/Next/contents/images/5120x2880.png
  wallpapers/Next/contents/images/README

To: ngraham, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26912: Use Qt5 signal syntax, format files, optimizations

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> autostart.cpp:64
> +connect(widget->btnProperties, ::clicked,
> +this, static_cast (Autostart::*)()>((::slotEditCMD)));
> +connect(widget->listCMD, ::itemDoubleClicked,

why double ( ?

> autostart.cpp:66
> +connect(widget->listCMD, ::itemDoubleClicked,
> +this, static_cast *)>((::slotEditCMD)));
>  

same

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  ^ I can't reproduce that, the patch works as intended for me.  (we should 
investigate this though)
  
  One thing to just comment is that this is tailor-made for Breeze (the 1px 
thing), but it looks fine with other themes and I don't really know of any 
other solution.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  tooltip-highlights-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26970: Remove use of deprecated KDialog, fix two warnings

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fb71ced98460: Remove use of deprecated KDialog, fix two 
warnings (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26970?vs=74516=74525

REVISION DETAIL
  https://phabricator.kde.org/D26970

AFFECTED FILES
  kcms/dateandtime/dtime.cpp
  kcms/dateandtime/main.cpp

To: meven, #plasma, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#601921 , @ngraham wrote:
  
  > In D26739#601762 , @trmdi wrote:
  >
  > > Not yet looked at the code carefully, but I feel the top margin and the 
bottom one of the thumbnail are not identical.
  >
  >
  > With the latest iteration of the patch, they should be. Feel free to try it 
out for yourself!
  
  
  Do you see this or just me?
  F7989597: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> componentchooser.cpp:62
> +// fill the form layout
> +const auto name = cg.readEntry("Name",i18n("Unknown"));
> +CfgPlugin *loadedConfigWidget = 
> loadConfigWidget(cfg.group(QByteArray()).readEntry("configurationType"));

Missing space after comma

> componentchooser.cpp:106
> +// check if another plugin has changed and default status
> +for (CfgPlugin * plugin: configWidgetMap) {
> +somethingChanged |= plugin->hasChanged();

No space after * and missing qAsConst

> componentchooser.cpp:137
>  void ComponentChooser::save() {
> - if( configWidget )
> - {
> - CfgPlugin* plugin = dynamic_cast( configWidget );
> - if( plugin )
> - {
> - KConfig cfg(latestEditedService, KConfig::SimpleConfig);
> +for (auto it = configWidgetMap.constBegin(); it != 
> configWidgetMap.constEnd(); ++it){
> +

Missing space before {

> componentchooser.cpp:142
> +
> +CfgPlugin *plugin = dynamic_cast( widget );
> +if (plugin) {

No space between parenthesis

> componentchooser.cpp:154
>  void ComponentChooser::restoreDefault() {
> -if (configWidget)
> -{
> -dynamic_cast(configWidget)->defaults();
> -emitChanged(true);
> +for (CfgPlugin* plugin : configWidgetMap) {
> +plugin->defaults();

Space before the * and not after. Also you could have used auto or auto * for 
all those loops (just that const auto & makes no sense in that context).

> ervin wrote in componentchooser.cpp:132
> No space after *, no space within parenthesis

No space within parenthesis

> broulik wrote in componentchooserbrowser.cpp:104
> As a future step I would like those default components not hardcoded in the 
> code

Yes, it screams for GUI / config separation (in another commit)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26797

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26954: Add Ice Cold wallpaper

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R131:7a69dcc37c93: Add Ice Cold wallpaper (authored by 
ngraham).

REPOSITORY
  R131 Plasma Wallpapers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26954?vs=74463=74521

REVISION DETAIL
  https://phabricator.kde.org/D26954

AFFECTED FILES
  CMakeLists.txt
  IceCold/contents/images/5120x2880.png
  IceCold/contents/screenshot.png
  IceCold/metadata.desktop

To: ngraham, #vdg, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26953: Replace Ice Cold with Volna for Plasma 5.18

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:e920200e29bb: Replace Ice Cold with Volna for Plasma 5.18 
(authored by ngraham).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26953?vs=74510=74520

REVISION DETAIL
  https://phabricator.kde.org/D26953

AFFECTED FILES
  wallpapers/Next/contents/images/1024x768.jpg
  wallpapers/Next/contents/images/1024x768.png
  wallpapers/Next/contents/images/1280x1024.jpg
  wallpapers/Next/contents/images/1280x1024.png
  wallpapers/Next/contents/images/1280x800.jpg
  wallpapers/Next/contents/images/1280x800.png
  wallpapers/Next/contents/images/1366x768.jpg
  wallpapers/Next/contents/images/1366x768.png
  wallpapers/Next/contents/images/1440x900.jpg
  wallpapers/Next/contents/images/1440x900.png
  wallpapers/Next/contents/images/1600x1200.jpg
  wallpapers/Next/contents/images/1600x1200.png
  wallpapers/Next/contents/images/1680x1050.jpg
  wallpapers/Next/contents/images/1680x1050.png
  wallpapers/Next/contents/images/1920x1080.jpg
  wallpapers/Next/contents/images/1920x1080.png
  wallpapers/Next/contents/images/1920x1200.jpg
  wallpapers/Next/contents/images/1920x1200.png
  wallpapers/Next/contents/images/2560x1440.jpg
  wallpapers/Next/contents/images/2560x1440.png
  wallpapers/Next/contents/images/2560x1600.jpg
  wallpapers/Next/contents/images/2560x1600.png
  wallpapers/Next/contents/images/3200x1800.jpg
  wallpapers/Next/contents/images/3200x1800.png
  wallpapers/Next/contents/images/3200x2000.jpg
  wallpapers/Next/contents/images/3200x2000.png
  wallpapers/Next/contents/images/3840x2160.jpg
  wallpapers/Next/contents/images/3840x2160.png
  wallpapers/Next/contents/images/5120x2880.jpg
  wallpapers/Next/contents/images/5120x2880.png
  wallpapers/Next/contents/screenshot.png
  wallpapers/Next/metadata.desktop

To: ngraham, #vdg, #plasma, davidedmundson
Cc: raveomelette, IlyaBizyaev, Luwx, ndavis, broulik, rikmills, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26953: Replace Ice Cold with Volna for Plasma 5.18

[Nathaniel Graham]

ngraham added a comment.


  VDG folks approved in the chatroom; landing it!

REPOSITORY
  R31 Breeze

BRANCH
  icecold-to-volna (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26953

To: ngraham, #vdg, #plasma, davidedmundson
Cc: raveomelette, IlyaBizyaev, Luwx, ndavis, broulik, rikmills, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26970: Remove use of deprecated KDialog, fix two warnings

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  No UI changes

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26970

AFFECTED FILES
  kcms/dateandtime/dtime.cpp
  kcms/dateandtime/main.cpp

To: meven, #plasma, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Nathaniel Graham]

ngraham added a comment.


  What I care about is that the margins are consistent and things are properly 
left-aligned by default. That is to say, nothing should have to override the 
default margins to have everything perfectly aligned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26937: Add a convenience property to retrieve the size of the decorated client

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R129:13e6459a3bae: Add a convenience property to retrieve the 
size of the decorated client (authored by zzag).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26937?vs=74418=74515#toc

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26937?vs=74418=74515

REVISION DETAIL
  https://phabricator.kde.org/D26937

AFFECTED FILES
  autotests/mockclient.cpp
  autotests/mockclient.h
  src/decoratedclient.cpp
  src/decoratedclient.h
  src/private/CMakeLists.txt
  src/private/decoratedclientprivate.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26956: Remove export header from static install

[Mason McParlane]

masonm added a comment.


  It appears all the sources which reference the export header have an 
appropriate guard on them:
  
  #ifndef KIRIGAMI_BUILD_TYPE_STATIC
  #include 
  #endif
  
  I found these in tabletmodewatcher.h, kirigamipluginfactory.h, platformtheme.h

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26956

To: masonm, #kirigami, mart, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26937: Add a convenience property to retrieve the size of the decorated client

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Please bump the SOVERSION

REPOSITORY
  R129 Window Decoration Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26937

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26953: Replace Ice Cold with Volna for Plasma 5.18

[Nathaniel Graham]

ngraham added a subscriber: IlyaBizyaev.
ngraham added a comment.


  @IlyaBizyaev suggested using the MozJPEG encoder at https://squoosh.app/ and 
the results are fantastic. I can detect no difference in appearance whatsoever 
from normal viewing distances (i.e. not zoomed in to 500%) and the total size 
is now down to 8 Mb. I used a 90% quality level to try to keep the visual 
fidelity as much as possible.

REPOSITORY
  R31 Breeze

BRANCH
  icecold-to-volna (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26953

To: ngraham, #vdg, #plasma, davidedmundson
Cc: IlyaBizyaev, Luwx, ndavis, broulik, rikmills, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26953: Replace Ice Cold with Volna for Plasma 5.18

[Nathaniel Graham]

ngraham updated this revision to Diff 74510.
ngraham added a comment.
This revision is now accepted and ready to land.


  Replace those lousy dithered PNGs with JPEGs created using the MozJPEG 
encoder at https://squoosh.app

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26953?vs=74466=74510

BRANCH
  icecold-to-volna (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26953

AFFECTED FILES
  wallpapers/Next/contents/images/1024x768.jpg
  wallpapers/Next/contents/images/1024x768.png
  wallpapers/Next/contents/images/1280x1024.jpg
  wallpapers/Next/contents/images/1280x1024.png
  wallpapers/Next/contents/images/1280x800.jpg
  wallpapers/Next/contents/images/1280x800.png
  wallpapers/Next/contents/images/1366x768.jpg
  wallpapers/Next/contents/images/1366x768.png
  wallpapers/Next/contents/images/1440x900.jpg
  wallpapers/Next/contents/images/1440x900.png
  wallpapers/Next/contents/images/1600x1200.jpg
  wallpapers/Next/contents/images/1600x1200.png
  wallpapers/Next/contents/images/1680x1050.jpg
  wallpapers/Next/contents/images/1680x1050.png
  wallpapers/Next/contents/images/1920x1080.jpg
  wallpapers/Next/contents/images/1920x1080.png
  wallpapers/Next/contents/images/1920x1200.jpg
  wallpapers/Next/contents/images/1920x1200.png
  wallpapers/Next/contents/images/2560x1440.jpg
  wallpapers/Next/contents/images/2560x1440.png
  wallpapers/Next/contents/images/2560x1600.jpg
  wallpapers/Next/contents/images/2560x1600.png
  wallpapers/Next/contents/images/3200x1800.jpg
  wallpapers/Next/contents/images/3200x1800.png
  wallpapers/Next/contents/images/3200x2000.jpg
  wallpapers/Next/contents/images/3200x2000.png
  wallpapers/Next/contents/images/3840x2160.jpg
  wallpapers/Next/contents/images/3840x2160.png
  wallpapers/Next/contents/images/5120x2880.jpg
  wallpapers/Next/contents/images/5120x2880.png
  wallpapers/Next/contents/screenshot.png
  wallpapers/Next/metadata.desktop

To: ngraham, #vdg, #plasma, davidedmundson
Cc: Luwx, ndavis, broulik, rikmills, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26893: Fix a building issue

[Méven Car]

meven added a comment.


  In D26893#601874 , @jriddell wrote:
  
  > Add this patch fixes compile on the KDE neon CI 
https://build.neon.kde.org/job/bionic_unstable_kde_user-manager/107/
  >
  > Curiously I can't recreate the failure on my local computer
  
  
  Me neither, or this build issue would not have been committed.
  Maybe because of the Qt version, I have 5.12.
  
  Can't wait for gitlab pre-merge branch test...

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26893

To: meven, #plasma, ngraham, rikmills, jriddell
Cc: jriddell, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26966: [kstyle] Unregister a shadow when it's destroyed

[Vlad Zahorodnii]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:cf12bf4a077d: [kstyle] Unregister a shadow when its 
destroyed (authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26966?vs=74506=74509

REVISION DETAIL
  https://phabricator.kde.org/D26966

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26967: [kstyle] Unregister a shadow when it's destroyed

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R113:120fb3e01f22: [kstyle] Unregister a shadow when its 
destroyed (authored by zzag).

REPOSITORY
  R113 Oxygen Theme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26967?vs=74503=74508

REVISION DETAIL
  https://phabricator.kde.org/D26967

AFFECTED FILES
  kstyle/oxygenshadowhelper.cpp

To: zzag, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26893: Fix a building issue

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:e1569e3341e7: Fix a building issue (authored by meven).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26893?vs=74303=74507

REVISION DETAIL
  https://phabricator.kde.org/D26893

AFFECTED FILES
  src/usermanager.cpp

To: meven, #plasma, ngraham, rikmills, jriddell
Cc: jriddell, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26966: [kstyle] Unregister a shadow when it's destroyed

[Vlad Zahorodnii]

zzag updated this revision to Diff 74506.
zzag edited the summary of this revision.
zzag added a comment.


  Edit summary.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26966?vs=74504=74506

BRANCH
  fix-crash

REVISION DETAIL
  https://phabricator.kde.org/D26966

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Nathaniel Graham]

ngraham added a comment.


  In D26665#601715 , @leinir wrote:
  
  > In D26665#601713 , @IlyaBizyaev 
wrote:
  >
  > > What about the "Get New Plugins" button in the same dialog? It still uses 
the old style.
  >
  >
  > The reason that wasn't changed in this step is simple - because it isn't 
simple ;) You'll notice that the change here was very much a trivial swap. 
Changing the other KNS integration points out for the new one will be 
considerably more effort, hence it isn't happening just yet.
  
  
  But now we have three different user interfaces for getting KNS content: 1. 
Discover 2. old dialog 3. new dialog. This is really kind of non-ideal. I was 
hoping we could swap out all the old dialogs for the new ones throughout System 
Settings and Plasma for 5.18. In the long term, I'd like to have //one// 
interface for all GHNS stuff, whether it be the new dialog or Discover, or 
something else. But three is now a regression in our quest for 
#goal_consistency . :/
  
  In D26665#601715 , @leinir wrote:
  
  > In D26665#601713 , @IlyaBizyaev 
wrote:
  >
  > > And also, looking at @victorr's screenshot, I see that the "Close" button 
has no label on it. I got same problem here as well.
  >
  >
  > That really is a very strange error. Not sure why such a thing would fail. 
The code in question can be seen here: 
https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98
 - However, the whole thing is also being discussed elsewhere, making this the 
wrong place. Would be good to get more eyes on the situation :) 
https://bugs.kde.org/show_bug.cgi?id=413434
  
  
  Just delete it :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26665

To: leinir, mart, #plasma, ngraham
Cc: IlyaBizyaev, victorr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26966: [kstyle] Unregister a shadow when it's destroyed

[Kai Uwe Broulik]

broulik added a comment.


  +1
  Can confirm that the `QWindow` belonging to `KlipperPopup` that caused the 
crash before is destroyed before the destructor, fixing the crash.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26966

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26966: [kstyle] Unregister a shadow when it's destroyed

[Vlad Zahorodnii]

zzag updated this revision to Diff 74504.
zzag retitled this revision from "[kstyle] Use guarded pointers to store 
shadows" to "[kstyle] Unregister a shadow when it's destroyed".
zzag edited the summary of this revision.
zzag added a comment.


  Re-title and edit summary.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26966?vs=74502=74504

BRANCH
  fix-crash

REVISION DETAIL
  https://phabricator.kde.org/D26966

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26965: [Emojier] Copy Emoji also into selection clipboard

[Nathaniel Graham]

ngraham added a comment.


  Now could we just blindly send a middle-click event after you select an emoji 
to have it paste the emoji into the focused text field, if any? >:D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26965

To: broulik, #plasma, apol
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  In D26739#601762 , @trmdi wrote:
  
  > Not yet looked at the code carefully, but I feel the top margin and the 
bottom one of the thumbnail are not identical.
  
  
  With the latest iteration of the patch, they should be. Feel free to try it 
out for yourself!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26966: [kstyle] Use guarded pointers to store shadows

[Aleix Pol Gonzalez]

apol added a comment.


  +1

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26966

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove added a comment.


  I thought about this; so, I should remove margins from everywhere, and we add 
them to the desktop theme? I can make that patch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26967: [kstyle] Use guarded pointers to store shadows

[Vlad Zahorodnii]

zzag updated this revision to Diff 74503.
zzag added a comment.


  Clean up _shadows upon a shadow emitting QObject::destroyed()

REPOSITORY
  R113 Oxygen Theme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26967?vs=74498=74503

BRANCH
  fix-crash

REVISION DETAIL
  https://phabricator.kde.org/D26967

AFFECTED FILES
  kstyle/oxygenshadowhelper.cpp

To: zzag, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26966: [kstyle] Use guarded pointers to store shadows

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> apol wrote in breezeshadowhelper.h:157
> if this is a thing, maybe it would make sense to actually try and remove the 
> KWindowShadows upon destruction?
> Something like `connect(newshadow, ::destroyed,  this, [this, widget] 
> { _shadows.remove(widget); });`

> if this is a thing, maybe it would make sense to actually try and remove the 
> KWindowShadows upon destruction?

Yes, that's a better idea.

> broulik wrote in breezeshadowhelper.h:157
> We have a connection to `destroyed` for the `widget` which isn't reached when 
> a window is destroyed on `QApplication` teardown, so I think the same might 
> be true for the window, I would still prefer this over a `QPointer`.

> so I think the same might be true for the window

No, it works fine.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26966

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26966: [kstyle] Use guarded pointers to store shadows

[Vlad Zahorodnii]

zzag updated this revision to Diff 74502.
zzag added a comment.


  Connect to QObject::destroyed

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26966?vs=74497=74502

BRANCH
  fix-crash

REVISION DETAIL
  https://phabricator.kde.org/D26966

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26966: [kstyle] Use guarded pointers to store shadows

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> apol wrote in breezeshadowhelper.h:157
> if this is a thing, maybe it would make sense to actually try and remove the 
> KWindowShadows upon destruction?
> Something like `connect(newshadow, ::destroyed,  this, [this, widget] 
> { _shadows.remove(widget); });`

We have a connection to `destroyed` for the `widget` which isn't reached when a 
window is destroyed on `QApplication` teardown, so I think the same might be 
true for the window, I would still prefer this over a `QPointer`.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26966

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26966: [kstyle] Use guarded pointers to store shadows

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> breezeshadowhelper.h:157
>  //* managed shadows
> -QMap _shadows;
>  

if this is a thing, maybe it would make sense to actually try and remove the 
KWindowShadows upon destruction?
Something like `connect(newshadow, ::destroyed,  this, [this, widget] { 
_shadows.remove(widget); });`

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26966

To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26965: [Emojier] Copy Emoji also into selection clipboard

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Right, didn't think of this since we don't have selection clipboard on 
wayland. 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26965

To: broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26967: [kstyle] Use guarded pointers to store shadows

[Vlad Zahorodnii]

zzag created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Since a KWindowShadow is a child of QWindow, we need to use a guarded
  pointer to store the shadow in order to prevent accessing or deleting
  dangling pointers in ShadowHelper::_shadows. It's quite possible that
  one could destroy the associated widget and with it the QWindow.

REPOSITORY
  R113 Oxygen Theme

BRANCH
  fix-crash

REVISION DETAIL
  https://phabricator.kde.org/D26967

AFFECTED FILES
  kstyle/oxygenshadowhelper.cpp
  kstyle/oxygenshadowhelper.h

To: zzag
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26966: [kstyle] Use guarded pointers to store shadows

[Vlad Zahorodnii]

zzag created this revision.
zzag added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Since a KWindowShadow is a child of QWindow, we need to use a guarded
  pointer to store the shadow in order to prevent accessing or deleting
  dangling pointers in ShadowHelper::_shadows. It's quite possible that
  one could destroy the associated widget and with it the QWindow.

TEST PLAN
  plasmashell no longer crashes.

REPOSITORY
  R31 Breeze

BRANCH
  fix-crash

REVISION DETAIL
  https://phabricator.kde.org/D26966

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26893: Fix a building issue

[Jonathan Riddell]

jriddell accepted this revision as: jriddell.
jriddell added a comment.
This revision is now accepted and ready to land.


  Add this patch fixes compile on the KDE neon CI 
https://build.neon.kde.org/job/bionic_unstable_kde_user-manager/107/
  
  Curiously I can't recreate the failure on my local computer

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26893

To: meven, #plasma, ngraham, rikmills, jriddell
Cc: jriddell, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26965: [Emojier] Copy Emoji also into selection clipboard

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Surprisingly, the Emojier does not insert an Emoji into a text field ... to 
make it a bit easier to use, also set the emoji to the selection clipboard. 
This way I can select an Emoji and then middle-click the text field I want to 
add it to.

TEST PLAN
  5.18 please
  郎
  works.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26965

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 153 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/153/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 28 Jan 2020 13:16:40 +
 Build duration:
1 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 670 lines...][2020-01-28T13:17:45.110Z] [ 22%] Built target kcm_devinfo_autogen[2020-01-28T13:17:45.110Z] [ 22%] Built target kcm_samba_autogen[2020-01-28T13:17:45.110Z] Scanning dependencies of target kcm_nic[2020-01-28T13:17:45.110Z] [ 22%] Built target kcm_pci_autogen[2020-01-28T13:17:45.110Z] Scanning dependencies of target kcm_usb[2020-01-28T13:17:45.110Z] [ 23%] Building CXX object Modules/nics/CMakeFiles/kcm_nic.dir/kcm_nic_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:45.110Z] [ 25%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/kcm_usb_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:45.110Z] Scanning dependencies of target kcm_memory[2020-01-28T13:17:45.110Z] Scanning dependencies of target kcm_about_distro[2020-01-28T13:17:45.110Z] Scanning dependencies of target kcm_info[2020-01-28T13:17:45.110Z] [ 25%] Built target kcm_energyinfo_autogen[2020-01-28T13:17:45.110Z] [ 26%] Building CXX object Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/kcm_about_distro_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:45.110Z] [ 27%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/kcm_memory_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:45.110Z] Scanning dependencies of target kcm_pci[2020-01-28T13:17:45.110Z] [ 28%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/kcm_info_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:45.110Z] [ 30%] Building CXX object Modules/nics/CMakeFiles/kcm_nic.dir/nic.cpp.o[2020-01-28T13:17:45.110Z] Scanning dependencies of target kcm_samba[2020-01-28T13:17:45.110Z] [ 30%] Built target kcm_opengl_autogen[2020-01-28T13:17:45.110Z] [ 31%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/kcm_pci_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:45.110Z] Scanning dependencies of target kcm_devinfo[2020-01-28T13:17:45.110Z] [ 32%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcm_samba_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:45.110Z] [ 34%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/main.cpp.o[2020-01-28T13:17:45.110Z] [ 35%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/kcm_devinfo_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:45.110Z] [ 35%] Built target kcm_fileindexermonitor_autogen[2020-01-28T13:17:45.110Z] [ 36%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/info.cpp.o[2020-01-28T13:17:45.713Z] [ 38%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/soldevice.cpp.o[2020-01-28T13:17:45.970Z] [ 39%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/kcmusb.cpp.o[2020-01-28T13:17:45.970Z] [ 39%] Built target doc-index-cache-bz2[2020-01-28T13:17:45.970Z] [ 40%] Building CXX object Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/main.cpp.o[2020-01-28T13:17:45.970Z] [ 42%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/kcm_pci.cpp.o[2020-01-28T13:17:45.970Z] [ 43%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/__/base/os_current.cpp.o[2020-01-28T13:17:45.970Z] Scanning dependencies of target kcm_energyinfo[2020-01-28T13:17:45.970Z] [ 44%] Building CXX object Modules/energy/CMakeFiles/kcm_energyinfo.dir/kcm_energyinfo_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:46.227Z] [ 46%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/memory.cpp.o[2020-01-28T13:17:46.227Z] In file included from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/base/os_current.cpp:24:[2020-01-28T13:17:46.227Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/base/os_base.h:35:10: fatal error: config-X11.h: No such file or directory[2020-01-28T13:17:46.227Z]35 | #include [2020-01-28T13:17:46.227Z]   |  ^~[2020-01-28T13:17:46.227Z] compilation terminated.[2020-01-28T13:17:46.227Z] make[2]: *** [Modules/pci/CMakeFiles/kcm_pci.dir/build.make:89: Modules/pci/CMakeFiles/kcm_pci.dir/__/base/os_current.cpp.o] Error 1[2020-01-28T13:17:46.227Z] make[2]: *** Waiting for unfinished jobs[2020-01-28T13:17:46.227Z] [ 47%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/chartWidget.cpp.o[2020-01-28T13:17:46.551Z] [ 48%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/totalMemoryChart.cpp.o[2020-01-28T13:17:46.551Z] [ 50%] Linking CXX shared module ../../bin/kcm_nic.so[2020-01-28T13:17:46.551Z] [ 51%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/main.cpp.o[2020-01-28T13:17:46.551Z] [ 52%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/ksmbstatus.cpp.o[2020-01-28T13:17:46.551Z] [ 53%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/os_current.cpp.o[2020-01-28T13:17:46.809Z] In file included from 

D26896: Kill the KinfoCenter binary

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:24f4c6f97875: Kill the KinfoCenter binary (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26896?vs=74434=74493#toc

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26896?vs=74434=74493

REVISION DETAIL
  https://phabricator.kde.org/D26896

AFFECTED FILES
  CMakeLists.txt
  Categories/CMakeLists.txt
  Categories/basicinformation.desktop
  Categories/detailedinformation.desktop
  Categories/deviceinfocategory.desktop
  Categories/graphicalinfocategory.desktop
  Categories/kinfocentercategory.desktop
  Categories/networkinfocategory.desktop
  Modules/about-distro/src/about-distro.desktop
  Modules/energy/kcm_energyinfo.desktop
  Modules/fileindexermonitor/kcm_fileindexermonitor.desktop
  Modules/memory/kcm_memory.desktop
  ToolTips/tooltipmanager.cpp
  ToolTips/tooltipmanager.h
  config-X11.h.cmake
  config-project-version.h.cmake
  infocenter.cpp
  infocenter.h
  infokcmmodel.cpp
  infokcmmodel.h
  infokcmproxymodel.cpp
  infokcmproxymodel.h
  kcmcategoryitem.cpp
  kcmcategoryitem.h
  kcmcontainer.cpp
  kcmcontainer.h
  kcmtreeitem.cpp
  kcmtreeitem.h
  kinfocenterui.rc
  main.cpp
  main.h
  sidepanel.cpp
  sidepanel.h

To: mart, #plasma, davidedmundson
Cc: ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 91 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/91/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 28 Jan 2020 13:16:39 +
 Build duration:
52 sec and counting
   CONSOLE OUTPUT
  [...truncated 481 lines...][2020-01-28T13:17:28.220Z]  ^[2020-01-28T13:17:28.220Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:87:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-28T13:17:28.220Z] [this, seat, seatItem] {[2020-01-28T13:17:28.220Z]  ^[2020-01-28T13:17:28.220Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:92:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-28T13:17:28.220Z] [this, seat, seatItem] {[2020-01-28T13:17:28.220Z]  ^[2020-01-28T13:17:28.220Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:108:42: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-28T13:17:28.220Z] [this, k, e, r, d] {[2020-01-28T13:17:28.220Z]  ^[2020-01-28T13:17:28.220Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:118:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-28T13:17:28.220Z] [this, seat, seatItem] {[2020-01-28T13:17:28.220Z]  ^[2020-01-28T13:17:28.220Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:132:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-28T13:17:28.220Z] [this, output, outputItem] {[2020-01-28T13:17:28.220Z]  ^[2020-01-28T13:17:28.220Z] [ 45%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/usbdb.cpp.o[2020-01-28T13:17:28.483Z] [ 46%] Building CXX object Modules/nics/CMakeFiles/kcm_nic.dir/nic.cpp.o[2020-01-28T13:17:28.483Z] [ 48%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/chartWidget.cpp.o[2020-01-28T13:17:28.483Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/kcmusb.cpp:26:[2020-01-28T13:17:28.483Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.h:24:4: warning: "The USB subsystem has changed in 8.0. Disabling." [-W#warnings][2020-01-28T13:17:28.483Z] #  warning "The USB subsystem has changed in 8.0. Disabling."[2020-01-28T13:17:28.483Z]^[2020-01-28T13:17:28.483Z] Scanning dependencies of target kcm_devinfo[2020-01-28T13:17:28.483Z] [ 50%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/totalMemoryChart.cpp.o[2020-01-28T13:17:28.483Z] [ 51%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/kcm_devinfo_autogen/mocs_compilation.cpp.o[2020-01-28T13:17:28.483Z] [ 53%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/physicalMemoryChart.cpp.o[2020-01-28T13:17:28.483Z] 6 warnings generated.[2020-01-28T13:17:28.483Z] gmake[1]: *** [CMakeFiles/Makefile2:699: Modules/info/CMakeFiles/kcm_info.dir/all] Error 2[2020-01-28T13:17:28.483Z] gmake[1]: *** Waiting for unfinished jobs[2020-01-28T13:17:28.746Z] [ 54%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/__/base/info_wayland.cpp.o[2020-01-28T13:17:29.009Z] 1 warning generated.[2020-01-28T13:17:29.009Z] [ 56%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/swapMemoryChart.cpp.o[2020-01-28T13:17:29.009Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.cpp:11:[2020-01-28T13:17:29.010Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.h:24:4: warning: "The USB subsystem has changed in 8.0. Disabling." [-W#warnings][2020-01-28T13:17:29.010Z] #  warning "The USB subsystem has changed in 8.0. Disabling."[2020-01-28T13:17:29.010Z]^[2020-01-28T13:17:29.281Z] [ 58%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/kpci.cpp.o[2020-01-28T13:17:29.281Z] [ 59%] Building CXX object Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/Module.cpp.o[2020-01-28T13:17:29.281Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/os_current.cpp:24:[2020-01-28T13:17:29.281Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/pci/../base/os_base.h:35:10: fatal error: 'config-X11.h' file not found[2020-01-28T13:17:29.281Z] #include [2020-01-28T13:17:29.281Z]  ^~[2020-01-28T13:17:29.281Z] 1 error generated.[2020-01-28T13:17:29.281Z] [ 61%] 

D26895: Introduce an Info Center mode

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:ca28b62000ff: Introduce an Info Center mode (authored by 
mart).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26895?vs=74491=74492

REVISION DETAIL
  https://phabricator.kde.org/D26895

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  app/main.cpp
  core/BaseData.cpp
  core/BaseData.h
  core/BaseMode.cpp
  core/BaseMode.h
  core/MenuItem.cpp
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  icons/IconMode.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h

To: mart, #plasma, davidedmundson
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:106
> +
> +ADD_CUSTOM_TARGET(kinfocenter_link ALL
> +  COMMAND ${CMAKE_COMMAND} -E create_symlink 
> ${KDE_INSTALL_FULL_BINDIR}/systemsettings5 
> ${CMAKE_CURRENT_BINARY_DIR}/kinfocenter)

comments for future devs explaining the situation would be useful

REPOSITORY
  R102 KInfoCenter

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma, davidedmundson
Cc: ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26895: Introduce an Info Center mode

[Marco Martin]

mart updated this revision to Diff 74491.
mart added a comment.


  - better todo message

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26895?vs=74487=74491

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26895

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  app/main.cpp
  core/BaseData.cpp
  core/BaseData.h
  core/BaseMode.cpp
  core/BaseMode.h
  core/MenuItem.cpp
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  icons/IconMode.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h

To: mart, #plasma, davidedmundson
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26895: Introduce an Info Center mode

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> SidebarMode.cpp:589
>  
> -if (introPageVisible) {
> -d->activeCategoryRow = -1;
> -emit activeCategoryRowChanged();
> -d->activeSubCategoryRow = -1;
> -emit activeSubCategoryRowChanged();
> -d->placeHolderWidget->show();
> -d->moduleView->hide();
> -} else {
> +// TODO: eventually make the intro page of SystemSettings a KCM as well?
> +if (homeItem()) {

Yes! that would be a nicer design

REPOSITORY
  R124 System Settings

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma, davidedmundson
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26895: Introduce an Info Center mode

[Marco Martin]

mart updated this revision to Diff 74487.
mart added a comment.


  - use mode

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26895?vs=74481=74487

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26895

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  app/main.cpp
  core/BaseData.cpp
  core/BaseData.h
  core/BaseMode.cpp
  core/BaseMode.h
  core/MenuItem.cpp
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  icons/IconMode.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h

To: mart, #plasma
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  Not yet looked at the code carefully, but I feel the top margin and the 
bottom one of the thumbnail are not identical.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26895: Introduce an Info Center mode

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> main.cpp:81
>  
> -SettingsBase *mainWindow = new SettingsBase();
> +if (binaryName == QStringLiteral("kinfocenter")) {
> +aboutData.setDesktopFileName(QStringLiteral("org.kde.kinfocenter"));

You can use mode here

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26958: [Kickoff] Don't enable OpacityMask layer.effect in software mode

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7a727fde4cb9: [Kickoff] Dont enable OpacityMask 
layer.effect in software mode (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26958?vs=74482=74483

REVISION DETAIL
  https://phabricator.kde.org/D26958

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26958: [Kickoff] Don't enable OpacityMask layer.effect in software mode

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It won't render otherwise. The code tried to check but only disabled the 
outline, not the actual effect.

TEST PLAN
  5.18
  
  - Ran `QT_QUICK_BACKEND=software plasmashell` and got my user shown in 
kickoff. In a square rather than a circle but better than not rendering the 
avatar at all

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26958

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26895: Introduce an Info Center mode

[Marco Martin]

mart updated this revision to Diff 74481.
mart added a comment.


  - remove usekless qdebug

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26895?vs=74422=74481

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26895

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  app/main.cpp
  core/BaseData.cpp
  core/BaseData.h
  core/BaseMode.cpp
  core/BaseMode.h
  core/MenuItem.cpp
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  icons/IconMode.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h

To: mart, #plasma
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ec387280ad9d: Switch to the old-style button text for the 
KNSQuick buttons (authored by leinir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26892?vs=74301=74480

REVISION DETAIL
  https://phabricator.kde.org/D26892

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir, #plasma, davidedmundson
Cc: aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26665#601713 , @IlyaBizyaev 
wrote:
  
  > What about the "Get New Plugins" button in the same dialog? It still uses 
the old style.
  >  Probably unrelated, but for me, both of these buttons fail to actually 
load anything, stuck connecting forever. I would blame all of my internet 
connections that I tried it with, but it does not happen in System Settings, so 
maybe there's some bug here.
  
  
  
  
The reason that wasn't changed in this step is simple - because it isn't 
simple ;) You'll notice that the change here was very much a trivial swap. 
Changing the other KNS integration points out for the new one will be 
considerably more effort, hence it isn't happening just yet.
  
  > And also, looking at @victorr's screenshot, I see that the "Close" button 
has no label on it. I got same problem here as well.
  
  That really is a very strange error. Not sure why such a thing would fail. 
The code in question can be seen here: 
https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98
 - However, the whole thing is also being discussed elsewhere, making this the 
wrong place. Would be good to get more eyes on the situation :) 
https://bugs.kde.org/show_bug.cgi?id=413434

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26665

To: leinir, mart, #plasma, ngraham
Cc: IlyaBizyaev, victorr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  What about the "Get New Plugins" button in the same dialog? It still uses the 
old style.
  Probably unrelated, but for me, both of these buttons fail to actually load 
anything, stuck connecting forever. I would blame all of my internet 
connections that I tried it with, but it does not happen in System Settings, so 
maybe there's some bug here.
  
  And also, looking at @victorr's screenshot, I see that the "Close" button has 
no label on it. I got same problem here as well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26665

To: leinir, mart, #plasma, ngraham
Cc: IlyaBizyaev, victorr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26892#600510 , @aacid wrote:
  
  > stable branch please :)
  
  
  Ah! Missed this somehow - landing on the 5.18 branch momentarily! :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  restore-old-style-kns-button-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart