D27096: Refactoring, improve validation in kcm, optimize

2020-02-01 Thread Alexander Lohnau
alex created this revision.
alex added reviewers: davidedmundson, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The config keys are now in a separate file, instead of having them at two 
places.
  Runner
  The duplicate call to reloadConfiguration has been removed and aliases/codes 
get validated.
  Additionally the match method has been simplified and the character is now 
copied to the clipboard when selected.
  KCM
  Validation of the add/delete buttons, error message now in GUI and deprecated 
methods removed.

TEST PLAN
  Compile, test runner and test editing entries.
  Manually add alias(and no hex value) to ~/.config/krunnerrc and reload the 
kcm, error message should be shown.
  
  Before:
  https://phabricator.kde.org/F8075415
  https://phabricator.kde.org/F8075416
  
  After:
  https://phabricator.kde.org/F8075419
  https://phabricator.kde.org/F8075420
  https://phabricator.kde.org/F8075422

REPOSITORY
  R114 Plasma Addons

BRANCH
  charrunner_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27096

AFFECTED FILES
  runners/characters/charrunner.cpp
  runners/characters/charrunner.h
  runners/characters/charrunner_config.cpp
  runners/characters/charrunner_config.h
  runners/characters/charrunner_config.ui
  runners/characters/config_keys.h

To: alex, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

2020-02-01 Thread Alexander Lohnau
alex updated this revision to Diff 74848.
alex added a comment.


  Undo changes that were supposed to be in new diff

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=74847=74848

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

2020-02-01 Thread Alexander Lohnau
alex updated this revision to Diff 74847.
alex added a comment.


  Refactoring, improve validation in kcm, optimize

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=74830=74847

BRANCH
  charrunner_fix

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/characters/charrunner.cpp
  runners/characters/charrunner.h
  runners/characters/charrunner_config.cpp
  runners/characters/charrunner_config.h
  runners/characters/charrunner_config.ui
  runners/characters/config_keys.h
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread David Edmundson
davidedmundson added a comment.


  > But the timeout isn't used to give apps more time needed to clean up before 
they confirm the session can be closed? If I understand it correctly, there 
should be two timeouts?
  
  That's different
  
  Order is
  
  action invoked
  This confirmation / timeout
  ask all apps if they're ok with quitting
  ask all apps to quit
  if they don't reply then there's a different timeout
  then we kill them

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: rikmills, broulik, cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27086: [Applet]Supplementary add port check

2020-02-01 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:ccdeb9327f17: [Applet]Supplementary add port check 
(authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27086?vs=74833=74846

REVISION DETAIL
  https://phabricator.kde.org/D27086

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: gvgeo, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27093: Provide better name for GTK Settings Sync service

2020-02-01 Thread Nathaniel Graham
ngraham added inline comments.

INLINE COMMENTS

> gtkconfig.json:3
>  "KPlugin": {
> -"Description": "GTK config management",
> +"Description": "Automatically applies KDE/Qt appearance settings to 
> Gnome/GTK applications",
>  "Description[ca]": "Gestió de la configuració del GTK",

`GNOME/GTK`

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27093

To: gikari, #vdg
Cc: ngraham, nicolasfella, davidre, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D27093: Provide better name for GTK Settings Sync service

2020-02-01 Thread Nicolas Fella
nicolasfella added a comment.


  +1 (speaking as the one who introduced the name IIRC)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27093

To: gikari, #vdg
Cc: nicolasfella, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27093: Provide better name for GTK Settings Sync service

2020-02-01 Thread David Redondo
davidre added a comment.


  I would drop the KDE/Qt Part because the settings are not specific to them 
but general settings and this service is needed to apply those settings to some 
applications. So "Applies Settings to Gnome/GTK applications'

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27093

To: gikari, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27093: Provide better name for GTK Settings Sync service

2020-02-01 Thread Mikhail Zolotukhin
gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  good-service-name

REVISION DETAIL
  https://phabricator.kde.org/D27093

AFFECTED FILES
  kded/gtkconfig.json

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Re: Long press global shortcuts

2020-02-01 Thread Luca Weiss
On Freitag, 24. Jänner 2020 19:07:25 CET Aleix Pol wrote:
> On Sun, Jan 12, 2020 at 6:11 PM Aleix Pol  wrote:
> > Hi,
> > In a discussion some weeks ago, we came to the conclusion that it
> > would make sense to support long press global shortcuts.
> > 
> > The use-case we discussed back then was the power button on the Plasma
> > phone. We need to have 2 actions upon press. Short press would lock
> > and dim the screen, long press would show the shutdown button.
> > Thinking about it further makes me think it's something we probably
> > want for the desktop use-case as well.
> > 
> > The problem is two-fold:
> > - We need to support long-press on kglobal accel (or even QShortcut?)
> > - When do we trigger the action? Because now it happens on pressed.
> > 
> > The second part of this is why I'm sending this e-mail. We're
> > responding to global shortcuts on press rather than on release, which
> > makes it impossible to handle the long press. Would it make sense to
> > change it to on release? Maybe only in the cases where there's a long
> > press counterpart?
> > 
> > Aleix
> 
> Hi,
> So I've been looking into it further and it turns out that the power
> button is special in libinput in that Press and Release are always
> emitted together upon press on my laptops (kde slimbook 1, dell xps
> 13, ms surface go). Good news is that on my nexus 5x it does the right
> thing. I wonder how reliable that is though.
> 
> I have no idea why that is, it could make sense to reach out to
> libinput upstream and they know what's going on.
> You can test it in your computer by using "sudo libinput debug-events".
> 
> https://phabricator.kde.org/D26899
> Here's a patch that should work, consequently we should implement
> Qt::Key_PowerDown on powerdevil and start removing the ad-hoc dpms
> management we do at the moment on hwcomposer.
> 
> Alternatively, we could also consider implementing it for double-press.
> 
> Aleix

Hi Aleix,

(first of all, I hope the email gets sent with the correct headers & recipients 
because I only got the email as digest and the import of mailman .gz archives 
doesn't work well)

Just to confirm, the PinePhone emits separate press and release events as well

 event0   KEYBOARD_KEY +0.000s  KEY_POWER (116) pressed
 event0   KEYBOARD_KEY +0.441s  KEY_POWER (116) released
 event0   KEYBOARD_KEY +2.094s  KEY_POWER (116) pressed
 event0   KEYBOARD_KEY +2.639s  KEY_POWER (116) released

I could test the KWin patch as well on the Pinephone but I'm not sure *how* to 
test it.

Cheers,
Luca




D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Nathaniel Graham
ngraham added a comment.


  In D27077#604505 , @broulik wrote:
  
  > Having Kickoff confirm shutdown could be superfluous as you already had to 
go through the trouble of opening it, going to "Leave", but for e.g. the lock 
logout entry or generic " Leave" in the desktop context menu I'd still want a 
confirmation.
  
  
  Yes, I agree.
  
  Essentially, whenever you choose a specific action, confirmation is annoying, 
but whenever you don't (pushing the power button, clicking the generic "leave" 
item, etc) it's critically important.
  
  If we did this, we could probably remove the "Confirm logout" and "Offer 
shutdown options" checkboxed in the Desktop Session KCM since the logout screen 
would always be shown only when actually needed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: rikmills, broulik, cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27090: Replace config.h with target_compile_definitions

2020-02-01 Thread Mikhail Zolotukhin
gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  One line in CMakeLists.txt is simpler, than the whole generated file.

TEST PLAN
  Relaunch `kded5`, open GTK Settings in Application style KCM and check if the 
previews are working.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  configh-to-compile-def

REVISION DETAIL
  https://phabricator.kde.org/D27090

AFFECTED FILES
  CMakeLists.txt
  config.h.cmake
  kded/CMakeLists.txt
  kded/themepreviewer.cpp

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Rik Mills
rikmills added a comment.


  In D27077#604505 , @broulik wrote:
  
  > Having Kickoff confirm shutdown could be superfluous as you already had to 
go through the trouble of opening it, going to "Leave", but for e.g. the lock 
logout entry or generic " Leave" in the desktop context menu I'd still want a 
confirmation.
  
  
  Also the lock/logout applet if someone has added it to a panel. One 
accidental click can invoke the leave/timeout screen.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: rikmills, broulik, cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Kai Uwe Broulik
broulik added a comment.


  Having Kickoff confirm shutdown could be superfluous as you already had to go 
through the trouble of opening it, going to "Leave", but for e.g. the lock 
logout entry or generic " Leave" in the desktop context menu I'd still want a 
confirmation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: broulik, cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D26891: Upgrade theme to Breeze GTK on startup

2020-02-01 Thread Mikhail Zolotukhin
gikari added a comment.


  The differences between `gtkrc` and `gtkrc-2.0` at least is that the first 
one was used for `GTK1` and the second for `GTK2`.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: ngraham, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26992: [SystemTray] Use unified data model everywhere

2020-02-01 Thread Konrad Materka
kmaterka added a comment.


  ... and second one: D27088 . It contains 
model refactoring and sorting.
  
  After that two are accepped I will rebase this one.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27088: [SystemTray] Implement sorting in the model

2020-02-01 Thread Konrad Materka
kmaterka added a comment.


  Extracted from D26992  to make review 
easier

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27088

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27088: [SystemTray] Implement sorting in the model

2020-02-01 Thread Konrad Materka
kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  Replace two wrapping PlasmaCore.SortFilterModel with custom sorting on model 
side.
  Extract common code to base class.

TEST PLAN
  Everything should work as before.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27088

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Nathaniel Graham
ngraham added a comment.


  In D27077#604428 , @cfeck wrote:
  
  > But the timeout isn't used to give apps more time needed to clean up before 
they confirm the session can be closed? If I understand it correctly, there 
should be two timeouts?
  
  
  I don't think so. It doesn't look like apps get the signal to quit until 
after you actually choose an option in the dialog, or the timeout runs out.
  
  Conceptually speaking, having any kind of timeout on a dialog meant to 
confirm destructive actions is a bad idea. You want the default to be to do 
nothing, not "do the destructive thing in n seconds". So maybe this isn't 
actually a destructive action at all. After all, an app with unsaved changes or 
active processed will block the logout/shutdown absent user interaction.
  
  Windows no longer even uses a "confirm logout" dialog anymore AFAIK. However 
macOS does, with a 60-second timeout.
  
  If I think about it a bit more, what makes sense to me is to never show the 
logout screen in response to a user-initiated action to choose a specific 
action (e.g. choose log out, shut down, etc from Kickoff). In this case, the 
user already knows what they want to happen and asking them to confirm is just 
annoying. However, when pressing the power button, the multi-option screen 
should be shown by default, with no timeout at all so you need to deliberately 
choose an option.
  
  Does that make sense to anyone else?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27086: [Applet]Supplementary add port check

2020-02-01 Thread George Vogiatzis
gvgeo added a comment.


  previous commit is 8f0847af1d17 
.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27086

To: gvgeo, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27086: [Applet]Supplementary add port check

2020-02-01 Thread George Vogiatzis
gvgeo created this revision.
gvgeo added reviewers: drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Supplementary to the previous commit
  2 More ports needs check. The issue is the same, maybe crash or
  display warning, if the port does not exit when try to read description.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  fixes2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27086

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: gvgeo, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26992: [SystemTray] Use unified data model everywhere

2020-02-01 Thread Konrad Materka
kmaterka added a comment.


  First revision: D27085 . In contains some 
random improvements

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27085: [SystemTray] Bunch of fixes and improvements in QML

2020-02-01 Thread Konrad Materka
kmaterka added a comment.


  Unrelated changes extracted from D26992  
to make review easier

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27085

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27085: [SystemTray] Bunch of fixes and improvements in QML

2020-02-01 Thread Konrad Materka
kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  Few unrelated fixes, bunched togheter:
  
  - move some code from main.qml to PlasmoidItem where it belongs
  - easier to understand item size calculation
  - where possible, replace parent.parent comparitions with property
  - get rid of marginHints
  - Qt 5.14 compatibility fix in configuration
  - formatting etc

TEST PLAN
  Everything should work as before, this is just refactoring.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27085

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Christoph Feck
cfeck added a comment.


  But the timeout isn't used to give apps more time needed to clean up before 
they confirm the session can be closed? If I understand it correctly, there 
should be two timeouts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread David Edmundson
davidedmundson added a comment.


  The (broken) rationale is you can just bash the power button and walk away. 
Useful if you have a large lab of machines or something.
  
  In practice apps can then block logout afterwards.
  
  (And probably it's there because windows at the time worked like this..)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Christoph Feck
cfeck added a comment.


  Why is there a timeout at all?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

2020-02-01 Thread Alexander Lohnau
alex marked an inline comment as done.
alex added a comment.


  Hello,
  thanks for the response.
  
  I addition to your requested change  I have made some smaller improvements.
  
  But I have a question about the concept of this runner: Why is the data for 
every match session newly created ? I understand that it saves a bit of memory 
to delete them, but this way the spellers are for every match session created
  (and the prepare/teardown slots are called in the main thread).
  
  What do you think about loading the data in the reloadConfiguration method 
and then reusing it ?
  This way the spellers for new languages can be also reused for multiple match 
sessions (they are in the match method created).
  
  PS: When I tested this plugin I found out that the "task-attention" icon for 
the error message (line 252 in the runner) is no longer available, but I don't 
know which icon would be a good replacement.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

2020-02-01 Thread Alexander Lohnau
alex updated this revision to Diff 74830.
alex added a comment.


  Simplify and optimize

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=74795=74830

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27084: Don't delay ksplash until the entire lideshow is loaded

2020-02-01 Thread David Redondo
davidre created this revision.
davidre added reviewers: davidedmundson, broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Instead of loading the model and then showing the last shown image, we can 
show
  it early so that we signal "wallpaper.loading = false" earlier.

TEST PLAN
  Have massive slideshow, login

REPOSITORY
  R120 Plasma Workspace

BRANCH
  slideshowsplash (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27084

AFFECTED FILES
  wallpapers/image/image.cpp

To: davidre, davidedmundson, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26992: [SystemTray] Use unified data model everywhere

2020-02-01 Thread David Edmundson
davidedmundson added a comment.


  The patch is big, but it's manageable.
  
  Splitting is up to you, don't feel you have to.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart