KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 54 - Still Failing!

2020-02-06 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/54/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 07 Feb 2020 07:38:14 +
 Build duration:
2 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-02-07T07:40:10.052Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-07T07:40:10.052Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-02-07T07:40:10.052Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/54/display/redirect'[2020-02-07T07:40:10.052Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-02-07T07:40:10.052Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-07T07:40:10.052Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-07T07:40:10.052Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-02-07T07:40:10.052Z] NODE_NAME = 'Docker Swarm-cf052f0d2ff7'[2020-02-07T07:40:10.052Z] HOST  = 'cf052f0d2ff7'[2020-02-07T07:40:10.052Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-07T07:40:10.052Z] USER  = 'jenkins'[2020-02-07T07:40:10.052Z] MORE  = '-sl'[2020-02-07T07:40:10.052Z] CSHEDIT   = 'emacs'[2020-02-07T07:40:10.052Z] SHLVL = '2'[2020-02-07T07:40:10.052Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-54'[2020-02-07T07:40:10.052Z] WINDOWMANAGER = 'xterm'[2020-02-07T07:40:10.052Z] PAGER = 'less'[2020-02-07T07:40:10.052Z] EXECUTOR_NUMBER   = '0'[2020-02-07T07:40:10.052Z] CVS_RSH   = 'ssh'[2020-02-07T07:40:10.052Z] LIBGL_DEBUG   = 'quiet'[2020-02-07T07:40:10.052Z] STAGE_NAME= 'Configuring Build'[2020-02-07T07:40:10.052Z] NODE_LABELS   = 'Docker Swarm-cf052f0d2ff7 SUSEQt5.12'[2020-02-07T07:40:10.052Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-07T07:40:10.052Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-07T07:40:10.052Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-07T07:40:10.052Z] PROFILEREAD   = 'true'[2020-02-07T07:40:10.052Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-07T07:40:10.052Z] HOSTTYPE  = 'x86_64'[2020-02-07T07:40:10.052Z] BUILD_ID  = '54'[2020-02-07T07:40:10.052Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-07T07:40:10.052Z] OLDPWD= '/home/jenkins'[2020-02-07T07:40:10.052Z] LC_CTYPE  = 'C.UTF-8'[2020-02-07T07:40:10.052Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-07T07:40:10.052Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-07T07:40:10.052Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-07T07:40:10.052Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-07T07:40:10.052Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-07T07:40:10.052Z] QT_SELECT = 'qt5'[2020-02-07T07:40:10.052Z] LANG  = 'en_US.UTF-8'[2020-02-07T07:40:10.052Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-07T07:40:10.052Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-07T07:40:10.052Z] [2020-02-07T07:40:10.052Z] [2020-02-07T07:40:10.052Z] == Commencing Configuration:[2020-02-07T07:40:10.052Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2020-02-07T07:40:12.594Z] -- The C compiler identification is GNU 9.2.1[2020-02-07T07:40:12.856Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-07T07:40:12.856Z] -- Check for working C compiler: /usr/bin/cc[2020-02-07T07:40:12.856Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-07T07:40:12.856Z] -- Detecting C compiler ABI info[2020-02-07T07:40:13.113Z] -- Detecting C compiler ABI info - done[2020-02-07T07:40:13.113Z] -- Detecting C compile features[2020-02-07T07:40:13.113Z] -- Detecting C compile features - done[2020-02-07T07:40:13.113Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-07T07:40:13.113Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-07T07:40:13.113Z] -- 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Failing!

2020-02-06 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/31/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 07 Feb 2020 07:38:15 +
 Build duration:
2 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 196 lines...][2020-02-07T07:40:46.085Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-02-07T07:40:46.085Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2020-02-07T07:40:46.085Z] EDITOR= 'vi'[2020-02-07T07:40:46.085Z] ENV   = '/home/jenkins/.shrc'[2020-02-07T07:40:46.085Z] HUDSON_HOME   = '/home/production/data'[2020-02-07T07:40:46.085Z] BUILD_ID  = '31'[2020-02-07T07:40:46.085Z] OLDPWD= '/usr/home/jenkins'[2020-02-07T07:40:46.085Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-07T07:40:46.085Z] _ = '/usr/local/bin/java'[2020-02-07T07:40:46.085Z] TERM  = 'su'[2020-02-07T07:40:46.085Z] NODE_LABELS   = 'FreeBSD Builder Theta FreeBSDQt5.13'[2020-02-07T07:40:46.085Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-31'[2020-02-07T07:40:46.085Z] BUILD_DISPLAY_NAME= '#31'[2020-02-07T07:40:46.085Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/31/display/redirect'[2020-02-07T07:40:46.085Z] USER  = 'jenkins'[2020-02-07T07:40:46.085Z] HOME  = '/home/jenkins'[2020-02-07T07:40:46.085Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/31/'[2020-02-07T07:40:46.085Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-02-07T07:40:46.085Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-07T07:40:46.085Z] SHELL = '/bin/sh'[2020-02-07T07:40:46.085Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-07T07:40:46.085Z] STAGE_NAME= 'Configuring Build'[2020-02-07T07:40:46.085Z] NODE_NAME = 'FreeBSD Builder Theta'[2020-02-07T07:40:46.085Z] BLOCKSIZE = 'K'[2020-02-07T07:40:46.085Z] EXECUTOR_NUMBER   = '0'[2020-02-07T07:40:46.085Z] SHLVL = '0'[2020-02-07T07:40:46.085Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-07T07:40:46.085Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-02-07T07:40:46.085Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-07T07:40:46.085Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-02-07T07:40:46.085Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-02-07T07:40:46.085Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-07T07:40:46.085Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-02-07T07:40:46.085Z] QT_SELECT = 'qt5'[2020-02-07T07:40:46.085Z] LANG  = 'en_US.UTF-8'[2020-02-07T07:40:46.085Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-07T07:40:46.085Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-07T07:40:46.085Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-07T07:40:46.085Z] [2020-02-07T07:40:46.085Z] [2020-02-07T07:40:46.085Z] == Commencing Configuration:[2020-02-07T07:40:46.085Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2020-02-07T07:40:46.352Z] -- The C compiler identification is Clang 8.0.1[2020-02-07T07:40:46.353Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-07T07:40:46.353Z] -- Check for working C compiler: /usr/bin/cc[2020-02-07T07:40:46.353Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-07T07:40:46.353Z] -- Detecting C compiler ABI info[2020-02-07T07:40:46.353Z] -- Detecting C compiler ABI info - done[2020-02-07T07:40:46.353Z] -- Detecting C compile features[2020-02-07T07:40:46.353Z] -- Detecting C compile features - done[2020-02-07T07:40:46.353Z] -- Check for working CXX compiler: 

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  @broulik ping. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27079: Don't escape search text in search page title

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  @apol ping. :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27203: Don't try to open files we can't figure out where they are

2020-02-06 Thread Aleix Pol Gonzalez
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  Been using it for a few days, no regressions.
  Opening sftp:///localhost/.../somefile.text twice, doesn't try to open 
sftp:///localhost/.../somefile.text/

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27203

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75144.
cblack added a comment.


  Swap in gridUnit instead of largeSpacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75143=75144

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/configView.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75143.
cblack added a comment.


  Remove extraneous print

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75142=75143

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/configView.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75142.
cblack added a comment.


  Add license headers to two new QML files

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75141=75142

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/configView.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75141.
cblack added a comment.


  Move source selector to bottom of column, hide by default

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75140=75141

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/configView.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75140.
cblack marked 7 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75138=75140

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack marked an inline comment as done.
cblack added inline comments.

INLINE COMMENTS

> broulik wrote in ExpandedRepresentation.qml:145-148
> Do you have a source for this claim? From what I know blur merely blurs the 
> actual item texture which is rendered, no the raw image source?

https://github.com/qt/qtdeclarative/blob/9893e71cea5de10193376c1733db627ef0783614/src/quick/items/qquickimage.cpp#L600-L603

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75138.
cblack added a comment.


  Cache data from the MPRIS sources

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75077=75138

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Manuel Jesús de la Fuente
manueljlin added a comment.


  I think 1.4 looks too small

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: alexde, ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein


D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Alex Debus
alexde added a comment.


  In D27198#607110 , @ngraham wrote:
  
  > I tried 1.4 but it looked a bit too small to me, and not sufficiently 
differentiated from the level 2 and 3 headings in content areas:
  
  
  When looking at the screenshots, 1.4 looks fine to me, but go with whatever 
you guys think looks better.  :)

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: alexde, ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein


D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  I tried 1.4 but it looked a bit too small to me, and not sufficiently 
differentiated from the level 2 and 3 headings in content areas:
  
  F8088947: Screenshot_20200206_133946.png 

  
  F8088944: Screenshot_20200206_133906.png 


REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: alexde, ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein


KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 40 - Still unstable!

2020-02-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/40/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 06 Feb 2020 20:21:36 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/16)0%
(0/16)0%
(0/773)0%
(0/339)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalscontainments.homescreen0%
(0/5)0%
(0/5)0%
(0/233)0%
(0/164)containments.panel0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/20)containments.taskpanel0%
(0/2)0%
(0/2)0%
(0/92)0%
(0/40)dialer.src0%
(0/7)0%
(0/7)0%
(0/388)0%
(0/115)

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Fixed!

2020-02-06 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/41/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 06 Feb 2020 20:21:36 +
 Build duration:
1 min 0 sec and counting

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 39 - Failure!

2020-02-06 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/39/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 06 Feb 2020 20:10:19 +
 Build duration:
1 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 593 lines...][2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-Provides" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-PreloadWeight" with type "int"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-StandAloneApp" with type "bool"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "NoDisplay" with type "bool"[2020-02-06T20:11:23.491Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-containment.desktop"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2020-02-06T20:11:23.491Z] Unknown property type for key "Keywords" -> falling back to string[2020-02-06T20:11:23.491Z] Generated  "/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/containments/homescreen/org.kde.phone.homescreen-plasmoids-metadata.json"[2020-02-06T20:11:23.491Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-API" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-RootPath" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-MainScript" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-NotificationArea" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-DBusActivationService" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-KDE-ParentApp" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-Provides" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-PreloadWeight" with type "int"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-StandAloneApp" with type "bool"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "NoDisplay" with type "bool"[2020-02-06T20:11:23.491Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-containment.desktop"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2020-02-06T20:11:23.491Z] Unknown property type for key "Keywords" -> falling back to string[2020-02-06T20:11:23.491Z] Generated  "/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 SUSEQt5.12/build/containments/taskpanel/org.kde.phone.taskpanel-plasmoids-metadata.json"[2020-02-06T20:11:23.491Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-API" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-RootPath" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-MainScript" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-NotificationArea" with type "QString"[2020-02-06T20:11:23.491Z] Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"[2020-02-06T20:11:23.493Z] Found property definition "X-Plasma-DBusActivationService" with type "QString"[2020-02-06T20:11:23.493Z] Found property definition "X-KDE-ParentApp" with type "QString"[2020-02-06T20:11:23.493Z] Found property definition "X-Plasma-Provides" with type "QStringList"[2020-02-06T20:11:23.493Z] Found property definition "X-Plasma-PreloadWeight" with type "int"[2020-02-06T20:11:23.493Z] Found property definition "X-Plasma-ConfigPlugins" 

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Failure!

2020-02-06 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/40/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 06 Feb 2020 20:10:22 +
 Build duration:
44 sec and counting
   CONSOLE OUTPUT
  [...truncated 553 lines...][2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[pt_BR]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[ru]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[sk]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[sv]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[tr]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[uk]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[x-test]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[zh_CN]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords[zh_TW]" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "X-KDE-ParentApp" -> falling back to string[2020-02-06T20:11:03.758Z] Unknown property type for key "X-Plasma-MainScript" -> falling back to string[2020-02-06T20:11:03.758Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/org.kde.plasma.phone-look-and-feel-metadata.json"[2020-02-06T20:11:03.758Z] About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-API" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-RootPath" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-MainScript" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-NotificationArea" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-DBusActivationService" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-KDE-ParentApp" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-Provides" with type "QStringList"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-PreloadWeight" with type "int"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-StandAloneApp" with type "bool"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"[2020-02-06T20:11:03.758Z] Found property definition "NoDisplay" with type "bool"[2020-02-06T20:11:03.758Z] About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-containment.desktop"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2020-02-06T20:11:03.758Z] Unknown property type for key "Keywords" -> falling back to string[2020-02-06T20:11:03.758Z] Generated  "/usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/containments/homescreen/org.kde.phone.homescreen-plasmoids-metadata.json"[2020-02-06T20:11:03.758Z] About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-API" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-RootPath" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-MainScript" with type "QString"[2020-02-06T20:11:03.758Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2020-02-06T20:11:03.759Z] Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"[2020-02-06T20:11:03.759Z] Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"[2020-02-06T20:11:03.759Z] Found property definition "X-Plasma-NotificationArea" with type "QString"[2020-02-06T20:11:03.759Z] Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"[2020-02-06T20:11:03.759Z] Found property definition "X-Plasma-DBusActivationService" with type "QString"[2020-02-06T20:11:03.759Z] Found property definition "X-KDE-ParentApp" with type "QString"[2020-02-06T20:11:03.759Z] Found property definition "X-Plasma-Provides" 

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Alex Debus
alexde added a comment.


  Looks way better, thanks Nate!
  
  Since case 1 to 3 are steps of 0.1 and from case 3 to 4 is a step of 0.2, how 
would it looke like with 1.40 instead of 1.50?
  Would it be too small? Would you like attach another screenshot please? :-)

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: alexde, ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein


D26992: [SystemTray] Use unified data model everywhere

2020-02-06 Thread Konrad Materka
kmaterka updated this revision to Diff 75134.
kmaterka added a comment.


  Rebase, only D27088  left

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26992?vs=74805=75134

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26992

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27199: [WIP][Applet]Update layout based on T10470

2020-02-06 Thread George Vogiatzis
gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, jgrulich, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
gvgeo requested review of this revision.

REVISION SUMMARY
  Need help/ideas:
  
  Have a problem to disable highlight of List Item when holding the mouse 
button.
  The way to display the line above the available connections is bad. Just 
hiding active connections section, haven't a better way.
  I've added 3 lines with a `// TODO Fix bind loop messages for width.` for 2 
pre-existing issues. I tried to solve them, but failed. Note sure if they have 
place in code.
  Thoughts on the layout.
  
  Note: I cannot build. So... I test only the qml changes.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/main.qml
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 75127.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use `gridUnit` to match the page margins correctly (it's the same width 
anyway)

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27198?vs=75126=75127

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

AFFECTED FILES
  src/controls/Heading.qml
  src/controls/private/globaltoolbar/TitlesPageHeader.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, davidedmundson, mart, hein


D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Arjen Hiemstra
ahiemstra added inline comments.

INLINE COMMENTS

> TitlesPageHeader.qml:37
>  right: parent.right
> -leftMargin: Units.largeSpacing
> +leftMargin: Units.largeSpacing * 2
>  }

Shouldn't this be Units.gridUnit if you actually want to match the default Page 
margins?

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, davidedmundson, mart, hein


D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Manuel Jesús de la Fuente
manueljlin accepted this revision.
manueljlin added a comment.
This revision is now accepted and ready to land.


  Looks significantly better in my opinion

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Kirigami, manueljlin.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Level 1 headings are humongous. The degree of humongousness is maybe a bit 
excessive,
  especially on page titles with toolbars, where it looks like it's positively 
trying
  to burst from its bounds! Also, the left padding could stand to be increased, 
which
  would make the titles align with the content for most views. This was brought 
up in
  T12631 .
  
  If this patch is approved, I will submit companion patches to make the same 
changes in
  the PlasmaExtras Heading and KTitleWidget.

TEST PLAN
  Discover, before: F8088774: Discover, before.png 

  
  Discover, after: F8088773: Discover, after.png 

  
  Kirigami Gallery, after: F8088775: In Kirigami Gallery.webm 


REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

AFFECTED FILES
  src/controls/Heading.qml
  src/controls/private/globaltoolbar/TitlesPageHeader.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: ngraham, #vdg, #kirigami, manueljlin
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  In D27189#606970 , @niccolove 
wrote:
  
  > > The reason why the text is now pushed over is because you added the new 
`PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. 
If anything the reverse should be true; the `RowLayout` should be inside the 
new header SVG.
  >
  > That can't be done as far as I know - elements are not displayed correctly 
when inside. Or maybe it's because I should use Layouts better?
  
  
  I think it should work if you make the `FrameSvgItem` an item inside the 
top-level `ColumnLayout`, make it fill the width, and make the `RowLayout` a 
chilt item of the svg with `anchors.fill: parent`.
  
  > 
  > 
  >> Also you can't set anchors on an item inside a Layout; it causes binding 
loops. Anchors are only for positioning items that are outside of Layouts. 
Items inside Layouts get positioned using properties like `Layout.fillWidth, 
`Layout.Alignment`, `Layout.maximumWidth`, and so on.
  > 
  > I'd do that, but as far as I know Layout does not support the negative 
margin I need to expand the area to the borders :-/
  
  Then you can set the negative margins on the top-level layout, and re-add 
them as needed for the child items that are below the header. Not ideal though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27183: Port Application Page's form layout to Kirigami FormLayout

2020-02-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:40742348cf05: Port Application Pages form layout to 
Kirigami FormLayout (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27183?vs=75079=75120

REVISION DETAIL
  https://phabricator.kde.org/D27183

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #vdg, #discover_software_store, apol, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27183: Port Application Page's form layout to Kirigami FormLayout

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  Looks like the elision issue could be an issue in FormLayout itself. I'll 
follow up.

REPOSITORY
  R134 Discover Software Store

BRANCH
  port-to-formlayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27183

To: ngraham, #vdg, #discover_software_store, apol, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27184: Use real Kirigami Separators instead of blue rectangles

2020-02-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:3978c1de9b47: Use real Kirigami Separators instead of 
blue rectangles (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27184?vs=75080=75115

REVISION DETAIL
  https://phabricator.kde.org/D27184

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #vdg, #discover_software_store, apol, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment.


  In D27189#606914 , @ngraham wrote:
  
  > Yeah, so you'll want to submit a plasma-frameworks patch which includes the 
new SVG and mark this as depending on it.
  
  
  Okay
  
  > The reason why the text is now pushed over is because you added the new 
`PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. 
If anything the reverse should be true; the `RowLayout` should be inside the 
new header SVG.
  
  That can't be done as far as I know - elements are not displayed correctly 
when inside. Or maybe it's because I should use Layouts better?
  
  > Also you can't set anchors on an item inside a Layout; it causes binding 
loops. Anchors are only for positioning items that are outside of Layouts. 
Items inside Layouts get positioned using properties like `Layout.fillWidth, 
`Layout.Alignment`, `Layout.maximumWidth`, and so on.
  
  I'd do that, but as far as I know Layout does not support the negative margin 
I need to expand the area to the borders :-/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  @trmdi I don't really agree with your idea of always using a fixed size 
rectangle, sorry. :)

INLINE COMMENTS

> trmdi wrote in ToolTipInstance.qml:100
> Could it be zero here? Because `Text` lines already has its own padding, 
> isn't it?

Depends on the font; you can't necessarily count on that.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-06 Thread Tranter Madi
trmdi added a comment.


  Any other objection?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

To: trmdi, #plasma, #vdg, ndavis
Cc: broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Tranter Madi
trmdi added inline comments.

INLINE COMMENTS

> ngraham wrote in ToolTipInstance.qml:79
> If we do that, then the size of the preview/album art area can get very 
> short, which I don't think is desirable.

I think it still looks acceptable, not tool short. This is the worst case:
F8088588: image.png 

The better case without the "Activities..." line, the albumArt will be bigger.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27088: [SystemTray] Implement sorting in the model

2020-02-06 Thread Konrad Materka
kmaterka updated this revision to Diff 75112.
kmaterka added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27088?vs=74837=75112

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27088

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27085: [SystemTray] Bunch of fixes and improvements in QML

2020-02-06 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a79f80ed79ae: [SystemTray] Bunch of fixes and 
improvements in QML (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27085?vs=74832=75111

REVISION DETAIL
  https://phabricator.kde.org/D27085

AFFECTED FILES
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27085: [SystemTray] Bunch of fixes and improvements in QML

2020-02-06 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks sane to me.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27085

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Tranter Madi
trmdi added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:100
> +ColumnLayout {
> +spacing: units.smallSpacing
> +

Could it be zero here? Because `Text` lines already has its own padding, isn't 
it?

> ngraham wrote in ToolTipInstance.qml:79
> If we do that, then the size of the preview/album art area can get very 
> short, which I don't think is desirable.

Could we have a fixed size rectangle with some ratio?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27138: [Applet] Display device name when there is than one device

2020-02-06 Thread Noah Davis
ndavis added a comment.


  no objections :)

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  devicesCount (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27138

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ndavis, cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D27138: [Applet] Display device name when there is than one device

2020-02-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:1b737cfe6613: [Applet] Display device name when there is 
than one device (authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27138?vs=75016=75110

REVISION DETAIL
  https://phabricator.kde.org/D27138

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ndavis, cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Yeah, so you'll want to submit a plasma-frameworks patch which includes the 
new SVG and mark this as depending on it.
  
  The reason why the text is now pushed over is because you added the new 
`PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. 
If anything the reverse should be true; the `RowLayout` should be inside the 
new header SVG.
  
  Also you can't set anchors on an item inside a Layout; it causes binding 
loops. Anchors are only for positioning items that are outside of Layouts. 
Items inside Layouts get positioned using properties like `Layout.fillWidth, 
`Layout.Alignment`, `Layout.maximumWidth`, and so on.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham added inline comments.

INLINE COMMENTS

> trmdi wrote in ToolTipInstance.qml:79
> Should we make the height `const` like this too? e.g. make it a golden 
> rectangle?
> F8088397: image.png 
> 
> Otherwise, the size of the tooltip may be not consistent in all cases, e.g. a 
> normal window vs a window which is available on all activities.

If we do that, then the size of the preview/album art area can get very short, 
which I don't think is desirable.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 75109.
ngraham marked 7 inline comments as done.
ngraham added a comment.


  Re-add spacing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27182?vs=75078=75109

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  Actually it looks like there's nothing to fix in PC3. `smallMedium` is 
already the default size, and all the overrides in this patch are because we 
want to use non-default sizes in certain contexts.

INLINE COMMENTS

> trmdi wrote in ToolTipInstance.qml:79
> How do you choose the number 17? On small screens, the tooltip is a bit too 
> big.
> Could it be smaller? e.g. 14-15 looks better on my small screen.

the number was chosen to make the tooltip exactly the same size as the current 
one.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Tranter Madi
trmdi added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:79
> +// This number controls the overall size of the window tooltips
> +Layout.maximumWidth: units.gridUnit * 17
> +Layout.minimumWidth: isWin ? Layout.maximumWidth : 0

How do you choose the number 17? On small screens, the tooltip is a bit too big.
Could it be smaller? e.g. 14-15 looks better on my small screen.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


Re: Dropping KRDB

2020-02-06 Thread David Edmundson
As an end goal +++. It's difficult to read currently. Also it's invoked on
startup in kcminit 0 which allows everything down.

I would like to see this done by moving pieces out gradually until there's
nothing left rather than dropping it as a single action and then trying to
recover what's broken.

> GTK 1
Kill it

> GTK 2
The breeze GTK sync seems like a logical place. ++

> Qt/KDE4

When we said we would drop BreezeQt5 it was with the reasoning that
packagers could continue to build the 5.18 tarball with Qt4, not
/necessarily/ that they are forced to not ship it.
So it's not /quite/ the same. Though I don't disagree with dropping it.

>XFT

Still super relevant, but yeah it could move.

> So your xcalc looks nice? Possibly also read by toolkits other than
Qt/GTK?

That's something we should check if it actually works before doing much
else.


D27194: Remove human avatars

2020-02-06 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R128:80ac93fa2b48: Remove human avatars (authored by ndavis).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27194?vs=75105=75108

REVISION DETAIL
  https://phabricator.kde.org/D27194

AFFECTED FILES
  src/pics/circles/Female.png
  src/pics/circles/Male.png
  src/pics_sources/avatar.svg

To: ndavis, #vdg
Cc: davidedmundson, leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Noah Davis
ndavis added a comment.


  In D27194#606893 , @ngraham wrote:
  
  > In D27194#606892 , @ndavis wrote:
  >
  > > Alright fine, we should add more, but that shouldn't be a blocker for 
this patch. I simply can't get a replacement avatar right now and replacements 
could be added at any time.
  >
  >
  > Sure, but the last time we said that, we removed a bunch of old crappy ones 
and didn't later add any new ones. :) I don't want it to become a pattern.
  
  
  Alright, new rule: no more removing avatars until we start adding some, after 
this patch.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: davidedmundson, leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  No problem, I can fix it in PC3.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread David Edmundson
davidedmundson added a comment.


  From a technical POV, pics get copied when selected, so you can do whatever 
without any user breakage.
  
  I don't have opinions on the actual change.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: davidedmundson, leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> ndavis wrote in ToolTipInstance.qml:151
> I suppose it depends on whether or not you think PC3 toolbuttons should 
> reflect the look and size of Qt Widget toolbar buttons by default. Toolbar 
> buttons in Qt widgets use 22px icons (equivalent to 
> units.iconSizes.smallMedium).

I'm merely stating that this is a behavioral change from PC2 to PC3 and 
realistically everyone using PC3 so far has manually hardcoded the icon sizes 
to some value.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  In D27194#606892 , @ndavis wrote:
  
  > Alright fine, we should add more, but that shouldn't be a blocker for this 
patch. I simply can't get a replacement avatar right now and replacements could 
be added at any time.
  
  
  Sure, but the last time we said that, we removed a bunch of old crappy ones 
and didn't later add any new ones. :) I don't want it to become a pattern.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Noah Davis
ndavis added a comment.


  Alright fine, we should add more, but that shouldn't be a blocker for this 
patch. I simply can't get a replacement avatar right now and replacements could 
be added at any time.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Tranter Madi
trmdi added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:39
>  
> -spacing: units.smallSpacing
> -

Why do you remove all `spacing`? This increases lots of wasted space which is 
not good at least on small screens like 1366x768.

> ToolTipInstance.qml:79
> +// This number controls the overall size of the window tooltips
> +Layout.maximumWidth: units.gridUnit * 17
> +Layout.minimumWidth: isWin ? Layout.maximumWidth : 0

Should we make the height `const` like this too? e.g. make it a golden 
rectangle?
F8088397: image.png 

Otherwise, the size of the tooltip may be not consistent in all cases, e.g. a 
normal window vs a window which is available on all activities.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  See also my comment in T9910: Revisit user avatar gallery images 
:
  
  > In particular, we should add more nature, animal, abstract, technology, 
vehicular, and sports imagery. Normal people love this stuff--two of the most 
popular user avatars on macOS are an owl and a basketball. They should look 
good.
  
  Normies like normal things. The first time my wife saw Konqi in an "About 
this app" dialog, she had a negative reaction, exclaiming, "why are there 
Pokemon here!?" This is not to say that the Konqis are bad, just that they 
don't appeal to everyone.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  In D27194#606882 , @ndavis wrote:
  
  > In D27194#606877 , @ngraham 
wrote:
  >
  > > Wouldn't it be better to get better ones? We already removed a ton last 
year. If we keep on removing stuff, we'll eventually end up with nothing but 
Konqis.
  >
  >
  > Sure, but we don't need them soon. I don't have much experience doing 
digital drawing (icon work is not the same) and while I could learn how to do 
it, it would be a big time investment. TBH, I wouldn't really be against having 
only variants of Konqi and Katie by default.
  
  
  I would. While those are nice, they only appeal to a fraction of our users. 
This is why other OSs ship with a diverse assortment of avatars that also show 
imagery related to nature,animals (real animals, not made-up cartoon animals)  
automotive, sports, technology, etc.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Dan Leinir Turthra Jensen
leinir added a comment.


  In D27194#606877 , @ngraham wrote:
  
  > Wouldn't it be better to get better ones? We already removed a ton last 
year. If we keep on removing stuff, we'll eventually end up with nothing but 
Konqis.
  
  
  As a counterpoint to that, though, if we keep removing avatars, we'll end up 
only with Konqis... ;) (seriously, though, i'm not really sure why that would 
inherently be a bad thing, except i guess for those who will feel terribly hurt 
in their professionalism... which could perhaps be solved by offering a 
separate selection of super-boring avatars for those situations that require 
such a thing?)

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: leinir, ngraham, niccolove, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Noah Davis
ndavis added a comment.


  In D27194#606877 , @ngraham wrote:
  
  > Wouldn't it be better to get better ones? We already removed a ton last 
year. If we keep on removing stuff, we'll eventually end up with nothing but 
Konqis.
  
  
  Sure, but we don't need them soon. I don't have much experience doing digital 
drawing and while I could learn how to do it, it would be a big time 
investment. TBH, I wouldn't really be against having only variants of Konqi and 
Katie by default.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:57ba878cdd61: Improve the behaviour of the power button 
on mobile (authored by apol).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27193?vs=75106=75107

REVISION DETAIL
  https://phabricator.kde.org/D27193

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/handlebuttonevents.h
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilprofilegenerator.cpp

To: apol, #plasma, bshah, broulik
Cc: z3ntu, broulik, PureTryOut, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 75106.
apol added a comment.


  address documentation, connect

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27193?vs=75102=75106

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27193

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/handlebuttonevents.h
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilprofilegenerator.cpp

To: apol, #plasma, bshah, broulik
Cc: z3ntu, broulik, PureTryOut, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Nathaniel Graham
ngraham added a comment.


  Wouldn't it be better to get better ones? We already removed a ton last year. 
If we keep on removing stuff, we'll eventually end up with nothing but Konqis.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment.


  +1

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27194: Remove human avatars

2020-02-06 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  There were some complaints about the female avatar and during a discussion in 
the VDG channel, someone mentioned that the male avatar was rather ugly too.

REPOSITORY
  R128 User Manager

BRANCH
  destroy-humans (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27194

AFFECTED FILES
  src/pics/circles/Female.png
  src/pics/circles/Male.png
  src/pics_sources/avatar.svg

To: ndavis, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Plasma 5.18 LTS tars ready to package

2020-02-06 Thread Jonathan Riddell
Tars are ready for packaging.  To be released on Tuesday.


D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Bhushan Shah
bshah added a comment.


  > he said he'll figure it out.
  
  (I have plan on how to handle that).

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27193

To: apol, #plasma, bshah, broulik
Cc: z3ntu, broulik, PureTryOut, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Aleix Pol Gonzalez
apol added a comment.


  > Regarding this behavior, it will not always be desirable to do that, 
especially if user interaction is still happening, e.g. listening to music, 
having an active USB connection (because it'll close) for copying files or 
doing something over ssh, etc.
  
  I mentioned something along the lines to @bshah, he said he'll figure it out.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27193

To: apol, #plasma, bshah, broulik
Cc: z3ntu, broulik, PureTryOut, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D27191: [KSplash KCM] Fix ghns button label

2020-02-06 Thread Yuri Chornoivan
yurchor accepted this revision.
yurchor added a comment.
This revision is now accepted and ready to land.


  No objections for porting to Plasma stable branch from the Ukrainian team.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27191

To: broulik, #plasma, yurchor, kde-i18n-doc
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Luca Weiss
z3ntu added a comment.


  > On Mobile, if the power button is pressed for short time, suspend to Ram as 
requested by Bhushan.
  
  Regarding this behavior, it will not always be desirable to do that, 
especially if user interaction is still happening, e.g. listening to music, 
having an active USB connection (because it'll close) for copying files or 
doing something over ssh, etc.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27193

To: apol, #plasma, bshah, broulik
Cc: z3ntu, broulik, PureTryOut, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Failing!

2020-02-06 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.13/2/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 06 Feb 2020 12:57:26 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 218 lines...][2020-02-06T13:10:17.590Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-06T13:10:17.590Z] STAGE_NAME= 'Configuring Build'[2020-02-06T13:10:17.590Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-02-06T13:10:17.590Z] BLOCKSIZE = 'K'[2020-02-06T13:10:17.590Z] EXECUTOR_NUMBER   = '0'[2020-02-06T13:10:17.590Z] SHLVL = '0'[2020-02-06T13:10:17.590Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-06T13:10:17.590Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-02-06T13:10:17.590Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-06T13:10:17.590Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-02-06T13:10:17.590Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-02-06T13:10:17.590Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-06T13:10:17.590Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-02-06T13:10:17.590Z] QT_SELECT = 'qt5'[2020-02-06T13:10:17.590Z] LANG  = 'en_US.UTF-8'[2020-02-06T13:10:17.590Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-06T13:10:17.590Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-06T13:10:17.590Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-06T13:10:17.590Z] [2020-02-06T13:10:17.590Z] [2020-02-06T13:10:17.590Z] == Commencing Configuration:[2020-02-06T13:10:17.590Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.13"[2020-02-06T13:10:17.590Z] -- The C compiler identification is Clang 8.0.1[2020-02-06T13:10:17.855Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-06T13:10:17.855Z] -- Check for working C compiler: /usr/bin/cc[2020-02-06T13:10:17.855Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-06T13:10:17.855Z] -- Detecting C compiler ABI info[2020-02-06T13:10:17.855Z] -- Detecting C compiler ABI info - done[2020-02-06T13:10:17.855Z] -- Detecting C compile features[2020-02-06T13:10:17.855Z] -- Detecting C compile features - done[2020-02-06T13:10:17.855Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-06T13:10:18.113Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-06T13:10:18.113Z] -- Detecting CXX compiler ABI info[2020-02-06T13:10:18.113Z] -- Detecting CXX compiler ABI info - done[2020-02-06T13:10:18.113Z] -- Detecting CXX compile features[2020-02-06T13:10:18.113Z] -- Detecting CXX compile features - done[2020-02-06T13:10:18.113Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for PowerDevil.[2020-02-06T13:10:18.113Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-06T13:10:18.113Z] -- Looking for __GLIBC__[2020-02-06T13:10:18.113Z] -- Looking for __GLIBC__ - not found[2020-02-06T13:10:18.113Z] -- Performing Test _OFFT_IS_64BIT[2020-02-06T13:10:18.113Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-06T13:10:18.113Z] -- Performing Test HAVE_DATE_TIME[2020-02-06T13:10:18.451Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-06T13:10:18.451Z] -- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.67.0") [2020-02-06T13:10:18.451Z] -- Found KF5Auth: /usr/home/jenkins/install-prefix/lib/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.67.0") [2020-02-06T13:10:18.451Z] -- Found KF5IdleTime: /usr/home/jenkins/install-prefix/lib/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.67.0") [2020-02-06T13:10:18.451Z] -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.67.0") [2020-02-06T13:10:18.451Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.67.0") [2020-02-06T13:10:18.451Z] -- Found KF5Solid: /usr/home/jenkins/install-prefix/lib/cmake/KF5Solid/KF5SolidConfig.cmake 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 30 - Failure!

2020-02-06 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/30/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 06 Feb 2020 12:50:50 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 198 lines...][2020-02-06T13:01:22.172Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-02-06T13:01:22.172Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2020-02-06T13:01:22.172Z] EDITOR= 'vi'[2020-02-06T13:01:22.172Z] ENV   = '/home/jenkins/.shrc'[2020-02-06T13:01:22.172Z] HUDSON_HOME   = '/home/production/data'[2020-02-06T13:01:22.172Z] BUILD_ID  = '30'[2020-02-06T13:01:22.172Z] OLDPWD= '/usr/home/jenkins'[2020-02-06T13:01:22.172Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-06T13:01:22.172Z] _ = '/usr/local/bin/java'[2020-02-06T13:01:22.172Z] TERM  = 'su'[2020-02-06T13:01:22.172Z] NODE_LABELS   = 'FreeBSD Builder Kappa FreeBSDQt5.13'[2020-02-06T13:01:22.172Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-30'[2020-02-06T13:01:22.172Z] BUILD_DISPLAY_NAME= '#30'[2020-02-06T13:01:22.172Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/30/display/redirect'[2020-02-06T13:01:22.172Z] USER  = 'jenkins'[2020-02-06T13:01:22.172Z] HOME  = '/home/jenkins'[2020-02-06T13:01:22.172Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/30/'[2020-02-06T13:01:22.172Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-02-06T13:01:22.172Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-06T13:01:22.172Z] SHELL = '/bin/sh'[2020-02-06T13:01:22.172Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-06T13:01:22.172Z] STAGE_NAME= 'Configuring Build'[2020-02-06T13:01:22.172Z] NODE_NAME = 'FreeBSD Builder Kappa'[2020-02-06T13:01:22.172Z] BLOCKSIZE = 'K'[2020-02-06T13:01:22.172Z] EXECUTOR_NUMBER   = '0'[2020-02-06T13:01:22.172Z] SHLVL = '0'[2020-02-06T13:01:22.172Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-06T13:01:22.172Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-02-06T13:01:22.172Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-06T13:01:22.172Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-02-06T13:01:22.172Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-02-06T13:01:22.172Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-06T13:01:22.172Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-02-06T13:01:22.172Z] QT_SELECT = 'qt5'[2020-02-06T13:01:22.172Z] LANG  = 'en_US.UTF-8'[2020-02-06T13:01:22.172Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-06T13:01:22.172Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-06T13:01:22.172Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-06T13:01:22.172Z] [2020-02-06T13:01:22.172Z] [2020-02-06T13:01:22.172Z] == Commencing Configuration:[2020-02-06T13:01:22.172Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2020-02-06T13:01:22.172Z] -- The C compiler identification is Clang 8.0.1[2020-02-06T13:01:22.436Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-06T13:01:22.436Z] -- Check for working C compiler: /usr/bin/cc[2020-02-06T13:01:22.436Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-06T13:01:22.436Z] -- Detecting C compiler ABI info[2020-02-06T13:01:22.699Z] -- Detecting C compiler ABI info - done[2020-02-06T13:01:22.699Z] -- Detecting C compile features[2020-02-06T13:01:22.699Z] -- Detecting C compile features - done[2020-02-06T13:01:22.699Z] -- Check for working CXX compiler: 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 53 - Failure!

2020-02-06 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/53/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 06 Feb 2020 12:50:53 +
 Build duration:
7 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-02-06T12:58:14.998Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-06T12:58:14.998Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-02-06T12:58:14.998Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/53/display/redirect'[2020-02-06T12:58:14.998Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-02-06T12:58:14.998Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-06T12:58:14.998Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-06T12:58:14.998Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-02-06T12:58:14.998Z] NODE_NAME = 'Docker Swarm-667dc1c65d0f'[2020-02-06T12:58:14.998Z] HOST  = '667dc1c65d0f'[2020-02-06T12:58:14.998Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-06T12:58:14.998Z] USER  = 'jenkins'[2020-02-06T12:58:14.998Z] MORE  = '-sl'[2020-02-06T12:58:14.998Z] CSHEDIT   = 'emacs'[2020-02-06T12:58:14.998Z] SHLVL = '2'[2020-02-06T12:58:14.998Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-53'[2020-02-06T12:58:14.998Z] WINDOWMANAGER = 'xterm'[2020-02-06T12:58:14.998Z] PAGER = 'less'[2020-02-06T12:58:14.998Z] EXECUTOR_NUMBER   = '0'[2020-02-06T12:58:14.998Z] CVS_RSH   = 'ssh'[2020-02-06T12:58:14.998Z] LIBGL_DEBUG   = 'quiet'[2020-02-06T12:58:14.998Z] STAGE_NAME= 'Configuring Build'[2020-02-06T12:58:14.998Z] NODE_LABELS   = 'Docker Swarm-667dc1c65d0f SUSEQt5.12'[2020-02-06T12:58:14.998Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-06T12:58:14.998Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-06T12:58:14.998Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-06T12:58:14.998Z] PROFILEREAD   = 'true'[2020-02-06T12:58:14.998Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-06T12:58:14.998Z] HOSTTYPE  = 'x86_64'[2020-02-06T12:58:14.998Z] BUILD_ID  = '53'[2020-02-06T12:58:14.998Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-06T12:58:14.998Z] OLDPWD= '/home/jenkins'[2020-02-06T12:58:14.998Z] LC_CTYPE  = 'C.UTF-8'[2020-02-06T12:58:14.998Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-06T12:58:14.998Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-06T12:58:14.998Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-06T12:58:14.998Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-06T12:58:14.998Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-06T12:58:14.998Z] QT_SELECT = 'qt5'[2020-02-06T12:58:14.998Z] LANG  = 'en_US.UTF-8'[2020-02-06T12:58:14.998Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-06T12:58:14.998Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-06T12:58:14.998Z] [2020-02-06T12:58:14.998Z] [2020-02-06T12:58:14.998Z] == Commencing Configuration:[2020-02-06T12:58:14.998Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2020-02-06T12:58:14.998Z] -- The C compiler identification is GNU 9.2.1[2020-02-06T12:58:14.998Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-06T12:58:15.264Z] -- Check for working C compiler: /usr/bin/cc[2020-02-06T12:58:15.265Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-06T12:58:15.265Z] -- Detecting C compiler ABI info[2020-02-06T12:58:15.265Z] -- Detecting C compiler ABI info - done[2020-02-06T12:58:15.265Z] -- Detecting C compile features[2020-02-06T12:58:15.265Z] -- Detecting C compile features - done[2020-02-06T12:58:15.265Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-06T12:58:15.523Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-06T12:58:15.523Z] -- 

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 3 - Still Failing!

2020-02-06 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/3/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 06 Feb 2020 12:50:43 +
 Build duration:
4 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 388 lines...][2020-02-06T12:54:38.407Z] [5/149] Automatic MOC for target qbugzilla[2020-02-06T12:54:38.976Z] [6/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserlldb.cpp.obj[2020-02-06T12:54:39.241Z] [7/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsercdb.cpp.obj[2020-02-06T12:54:39.241Z] [8/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_backtrace_parser_autogen\mocs_compilation.cpp.obj[2020-02-06T12:54:39.241Z] [9/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsernull.cpp.obj[2020-02-06T12:54:39.241Z] [10/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserkdbgwin.cpp.obj[2020-02-06T12:54:39.241Z] [11/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_parser_debug.cpp.obj[2020-02-06T12:54:39.241Z] [12/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsergdb.cpp.obj[2020-02-06T12:54:39.501Z] [13/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparser.cpp.obj[2020-02-06T12:54:39.501Z] [14/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\apijob.cpp.obj[2020-02-06T12:54:39.501Z] [15/149] Building CXX object src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest.cpp.obj[2020-02-06T12:54:39.763Z] [16/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_process.cpp.obj[2020-02-06T12:54:39.763Z] [17/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\abstract_generator.cpp.obj[2020-02-06T12:54:40.025Z] [18/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla.cpp.obj[2020-02-06T12:54:40.025Z] [19/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugsearch.cpp.obj[2020-02-06T12:54:40.025Z] [20/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newattachment.cpp.obj[2020-02-06T12:54:40.284Z] [21/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugupdate.cpp.obj[2020-02-06T12:54:40.284Z] [22/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\connection.cpp.obj[2020-02-06T12:54:40.284Z] [23/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\jsoncommand.cpp.obj[2020-02-06T12:54:40.284Z] [24/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\productclient.cpp.obj[2020-02-06T12:54:40.284Z] [25/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commentclient.cpp.obj[2020-02-06T12:54:40.542Z] [26/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\attachmentclient.cpp.obj[2020-02-06T12:54:40.542Z] [27/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\exceptions.cpp.obj[2020-02-06T12:54:40.802Z] [28/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugfieldclient.cpp.obj[2020-02-06T12:54:40.802Z] [29/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugclient.cpp.obj[2020-02-06T12:54:41.065Z] [30/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\clientbase.cpp.obj[2020-02-06T12:54:41.065Z] [31/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newbug.cpp.obj[2020-02-06T12:54:41.065Z] [32/149] Linking CXX static library lib\drkonqi_backtrace_parser.lib[2020-02-06T12:54:41.065Z] [33/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\querycommand.cpp.obj[2020-02-06T12:54:41.329Z] [34/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bugfield.cpp.obj[2020-02-06T12:54:41.329Z] [35/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\logindetails.cpp.obj[2020-02-06T12:54:41.329Z] [36/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\comment.cpp.obj[2020-02-06T12:54:41.329Z] [37/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bug.cpp.obj[2020-02-06T12:54:41.591Z] [38/149] Automatic MOC for target gdbbacktracelinetest[2020-02-06T12:54:41.591Z] [39/149] Building CXX object 

D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> handlebuttonevents.cpp:79
> +accel->setGlobalShortcut(globalAction, Qt::Key_PowerDown);
> +connect(globalAction, SIGNAL(triggered(bool)), 
> SLOT(powerDownButtonTriggered()));
> +

Use new connect syntax in new code please

> powerdevilbackendinterface.h:69
>   * - PowerButton: A power button pressed event, generally used to turn 
> on or off the system
>   * - SleepButton: A sleep button pressed event, generally used to make 
> the system asleep
>   * - LidOpen: A laptop lid open event

Please document what `PowerDownButton` is, especially that it has this magic 
behavior in kglobalaccel

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27193

To: apol, #plasma, bshah, broulik
Cc: broulik, PureTryOut, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Aleix Pol Gonzalez
apol created this revision.
apol added reviewers: Plasma, bshah.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  On Mobile, if the power button is pressed for short time, suspend to Ram as
  requested by Bhushan. If the power button is pressed for over a second show a
  menu asking whether to reboot, shut down and others like we show on the
  desktop.
  
  Albeit pretty cool and useful, this can't be translated into the desktop
  because there press time is always 0ms for some reason.
  
  See https://phabricator.kde.org/D26899

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27193

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/handlebuttonevents.h
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilprofilegenerator.cpp

To: apol, #plasma, bshah
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Noah Davis
ndavis added a comment.


  In D27189#606790 , @niccolove 
wrote:
  
  > ... The svg should be created (in a different patch, I thought?)
  
  
  I just realized this is plasma-workspace, not plasma-framework. My bad.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27191: [KSplash KCM] Fix ghns button label

2020-02-06 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, yurchor, kde-i18n-doc.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 417224
  FIXED-IN: 5.18.0

TEST PLAN
  I want this in 5.18, can I have translator's exception, please?
  This is the exact string that was used in Plasma/5.17 branch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27191

AFFECTED FILES
  kcms/ksplash/package/contents/ui/main.qml

To: broulik, #plasma, yurchor, kde-i18n-doc
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment.


  In D27189#606788 , @ndavis wrote:
  
  > .+1 to this idea. I noticed that the separator on the left is less dark. 
I'm not necessarily opposed to that, but is it intentional? Also, where is 
toparea.svg? I don't see it in `breeze/widgets/`
  
  
  The line color is accidental, I should fix that. The svg should be created 
(in a different patch, I thought?)
  The one I'm currently using is:
  F8088084: test.svg 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Noah Davis
ndavis added a comment.


  .+1 to this idea. I noticed that the separator on the left is less dark. I'm 
not necessarily opposed to that, but is it intentional? Also, where is 
toparea.svg? I don't see it in `breeze/widgets/`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

2020-02-06 Thread Cyril Rossi
crossi created this revision.
crossi added reviewers: Plasma, ervin, broulik, bport, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  App-specific notifications' behavior are now managed with KConfigXT. The 
default values are set in plasmanotifyrc shipped with the 
libnotificationmanager and can be override.
  Immutability can be set at applicatioin level in plasmanotifyrc.
  Reinitialize button reset all modifications not applied. Default button does 
not reset to default applications' behavior (same as before).
  
  Require D27059  D27133 
 D27155 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27155: libnotificationmanager : add app-specific kconfig settings

2020-02-06 Thread Cyril Rossi
crossi updated this revision to Diff 75090.
crossi added a comment.


  Remove specific default values, will rely on shipped settings. Fix comment at 
EOL that makes the entry not read.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27155?vs=74997=75090

REVISION DETAIL
  https://phabricator.kde.org/D27155

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/behaviorsettings.kcfg
  libnotificationmanager/kcfg/behaviorsettings.kcfgc
  libnotificationmanager/plasmanotifyrc

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Noah Davis
ndavis added inline comments.

INLINE COMMENTS

> broulik wrote in ToolTipInstance.qml:151
> Can we please get this fixed in `PlasmaComponents3` - this is being set all 
> over the place, so clearly a bug in the component itself.

I suppose it depends on whether or not you think PC3 toolbuttons should reflect 
the look and size of Qt Widget toolbar buttons by default. Toolbar buttons in 
Qt widgets use 22px icons (equivalent to units.iconSizes.smallMedium).

> broulik wrote in ToolTipInstance.qml:151
> Can we please get this fixed in `PlasmaComponents3` - this is being set all 
> over the place, so clearly a bug in the component itself.

Another thing to consider is that `window-close` mimics the look of the 
titlebar close button with the margins of a normal breeze-icons monochrome 
icon, but the titlebar close button with the circle is larger than the other 
symbols until you hover over them. This leads to units.iconSizes.smallMedium 
being used for close buttons in some cases while other icons use 
units.iconSizes.small to get the same proportions. Should the margins be 
removed from `window-close` so that we can use the same icon size in the code 
everywhere to get the same kind of proportions?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart