D27345: Don't emit palette changes if the palette didn't change

2020-02-19 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 76036.
apol added a comment.


  unrelated changes. Hating arc right now...

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27345?vs=76033=76036

BRANCH
  arcpatch-D27345

REVISION DETAIL
  https://phabricator.kde.org/D27345

AFFECTED FILES
  src/libkirigami/platformtheme.cpp

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27515: Icon: fix rendering of image: urls on High DPI

2020-02-19 Thread Aleix Pol Gonzalez
apol created this revision.
apol added reviewers: Plasma, Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  QQuickImageProvider wants the requestedSize to be accounting for the dpi
  scaling. We have no information about about the DPI from the implementation
  anyway.
  This is also how it's explained in the qtdeclarative/manual/highdpi/ test in 
Qt.
  
  BUG: 417647

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27515

AFFECTED FILES
  src/icon.cpp

To: apol, #plasma, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27345: Don't emit palette changes if the palette didn't change

2020-02-19 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 76033.
apol added a comment.


  Icon: fix rendering of image: urls on High DPI
  
  QQuickImageProvider wants the requestedSize to be accounting for the dpi
  scaling. We have no information about about the DPI from the implementation
  anyway.
  This is also how it's explained in the qtdeclarative/manual/highdpi/ test in 
Qt.
  
  BUG: 417647

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27345?vs=75548=76033

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27345

AFFECTED FILES
  src/icon.cpp
  src/libkirigami/platformtheme.cpp

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27426: [KRDB] Rename GTK colours to be exported

2020-02-19 Thread Ongun Kanat
ongunkanat added a comment.


  Hi,
  
  I am the reporter of this bug. I saw the e-mail but never had time to comment 
on the issue. It seems it has been approved quite fast. I am glad that it is at 
least possible to modify the style and GTK accepts those changes without hassle.
  
  However I have a suggestion to make it more clear for 3rd party developers. 
The suffix `_breeze` seems like only Breeze-GTK can follow those colors but if 
it works on Breeze-GTK probably other themes can also implement same color 
class names with the `_breeze`. So from a 3rd party GTK theme developer's point 
of view it looks like a Breeze specific feature although they probably can 
implement Plasma compatibility for their own theme too if they want to follow 
KDE's API.
  
  So in my humble opinion using `_plasma` or `_kde_plasma` suffix would be a 
clearer and better indicator for this feature.
  
  Thanks for the effort!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  krdb-rename-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27426

To: cblack, #plasma, ngraham
Cc: ongunkanat, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27514: Fix incorrect use of case statements in accountmodel.cpp

2020-02-19 Thread Bernhard Rosenkraenzer
bero added a comment.


  Another option would be switching the code to use if instead of switch/case 
so the || operator would actually do what the code expected (and x || x, unlike 
duplicate case values, isn't an error)

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27514

To: bero, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27514: Fix incorrect use of case statements in accountmodel.cpp

2020-02-19 Thread Bernhard Rosenkraenzer
bero updated this revision to Diff 76032.
bero added a comment.


  Probably best to just add a comment explaining what needs to be done if 
AccountModel::* roles ever diverge from DisplayRole/DecorationRole...
  
  Leaving the code the way it is now will result in a harder to trace error if 
Qt ever changes the values of DisplayRole or DecorationRole (and may give 
people looking at the code bad ideas), revising it the way I proposed earlier 
causes duplicate case values.

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27514?vs=76031=76032

REVISION DETAIL
  https://phabricator.kde.org/D27514

AFFECTED FILES
  src/lib/accountmodel.cpp

To: bero, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27514: Fix incorrect use of case statements in accountmodel.cpp

2020-02-19 Thread Bernhard Rosenkraenzer
bero added a comment.


  Actually the obvious fix doesn't work (thought it was so obvious that I 
submitted it before testing, sorry) because Qt::DisplayRole and 
AccountModel::FriendlyName are both 0 (-> duplicate case value) and 
Qt::DecorationRole and AccountModel::Face are both 1 (-> duplicate case value). 
Also explains why the bogus variant before "worked" - (Qt::DisplayRole || 
AccountModel::FriendlyName) = 0 || 0 = 0 = Qt::DisplayRole = 
AccountModel::FriendlyName and (Qt::DecorationRole || AccountModel::Face) = 1 
|| 1 = 1 = Qt::DecorationRole = AccountModel::Face
  
  Revising the patch...

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27514

To: bero, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27514: Fix incorrect use of case statements in accountmodel.cpp

2020-02-19 Thread Bernhard Rosenkraenzer
bero created this revision.
bero added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bero requested review of this revision.

REVISION SUMMARY
  Building user-manager 5.18.1 with clang++ 10.0 resulted in 2 compiler 
warnings - a quick look at the code shows they're real bugs.
  "case Qt::DisplayRole || AccountModel::FriendlyName:" isn't quite the same as 
"if(role==Qt::DisplayRole || role==AccountModel::FriendlyName)" -- but that's 
clearly what is meant here.

TEST PLAN
  Check the output of AccountModel::data() with various role types, including 
Qt::DisplayRole, AccountModel::FriendlyName, Qt::DecorationRole and 
AccountModel::Face before and after applying the patch.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27514

AFFECTED FILES
  src/lib/accountmodel.cpp

To: bero, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26946: Changed leftMargins to smallSpacing to be consistent

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  So, with a left panel, I see the following:
  
  F8113684: Screenshot_20200219_153618.png 

  
  Things are improved, but the vertical alignment is still not perfect. :(

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26945: Added smallSpacing to leftMargin

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  Since this patch is for KScreen, you need to follow the commit message 
guidelines: https://cgit.kde.org/kscreen.git/tree/CONTRIBUTING.md#n22

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26945

To: niccolove, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26992: [SystemTray] Use unified data model everywhere

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  UI looks good except for one thing: the changes to show a highlight effect on 
hover in the popup are unrelated and should be done in a separate patch 
(preferably in coordination with #VDG  
folks since we're moving towards the idea of using this in other places too).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26992: [SystemTray] Use unified data model everywhere

2020-02-19 Thread Konrad Materka
kmaterka updated this revision to Diff 76028.
kmaterka added a comment.


  Second (and last) change extracted from this one is in master. Rebased, ready 
for review.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26992?vs=75134=76028

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26992

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27088: [applets/SystemTray] Implement sorting in the model

2020-02-19 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6d86c690d133: [applets/SystemTray] Implement sorting in 
the model (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27088?vs=76026=76027

REVISION DETAIL
  https://phabricator.kde.org/D27088

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D27088: [applets/SystemTray] Implement sorting in the model

2020-02-19 Thread Konrad Materka
kmaterka updated this revision to Diff 76026.
kmaterka added a comment.


  Review fixes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27088?vs=75112=76026

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27088

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D26945: Added smallSpacing to leftMargin

2020-02-19 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76025.
niccolove added a comment.


  - Merge branch 'master' of https://anongit.kde.org/kscreen

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26945?vs=74438=76025

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26945

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml

To: niccolove, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26946: Changed leftMargins to smallSpacing to be consistent

2020-02-19 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76024.
niccolove added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26946?vs=74443=76024

BRANCH
  smallspacingmargin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26946

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27513: Kill Runner: Remove duplicate function calls and refactor

2020-02-19 Thread Alexander Lohnau
alex updated this revision to Diff 76023.
alex added a comment.


  Remove QDebug include, add license

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27513?vs=76022=76023

BRANCH
  killrunner_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27513: Kill Runner: Remove duplicate function calls and refactor

2020-02-19 Thread Alexander Lohnau
alex created this revision.
alex added reviewers: davidedmundson, ngraham, broulik, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Duplicate function calls to load the config in the runner/config have been 
removed.
  Additionally the config keys/sorting enum have been moved to a new file, 
before this the runner included the header of the config class.
  The actions of the runner are also refactored, similar to 
https://phabricator.kde.org/D3688.
  Also the user (owner of process) has been removed from the subtext, because 
the second line is not shown and adding the user info to the same line would be 
too long.

TEST PLAN
  Should compile and kill processes as before.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  killrunner_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26946: Changed leftMargins to smallSpacing to be consistent

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  All right, feel free to re-open it and re-base on current master (there has 
been a lot of work to these applets lately).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27346: emojier: Improve resizing performance

2020-02-19 Thread Aleix Pol Gonzalez
apol abandoned this revision.
apol added a comment.


  Solved as 
https://commits.kde.org/plasma-desktop/91c446e0c4430289369963bf44e64228add67d18

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27346

To: apol, #plasma
Cc: ngraham, Zren, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26946: Changed leftMargins to smallSpacing to be consistent

2020-02-19 Thread Niccolò Venerandi
niccolove added a comment.


  In D26946#602022 , @ngraham wrote:
  
  > What I care about is that the margins are consistent and things are 
properly left-aligned by default. That is to say, nothing should have to 
override the default margins to have everything perfectly aligned.
  
  
  After trying a different solution, I'd suggest to go with these patches as a 
short term solution. I generally want to revise margins for desktop theme - so 
panels as well - but I'd like to see this fixed before that. Keep in mind that 
this is not overriding the margins, but just adding up to them, something that 
most of our applet do.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27422: [KCM]Update Device item layout based on applet

2020-02-19 Thread George Vogiatzis
gvgeo added a comment.


  > I'm seeing some weird jagginess on radio buttons, slider handles, and 
combobox shadows:
  
  I cannot replicate this. And I cannot see how I could have created this. Or 
where to start.
  
  Here's my short list of problems.
  F8113183: problems.png 
  
  I believe these 6 are known.
  1.Default size too small, content disappears.
  2.Content goes up.
  5.Content under the scrollbars.
  7.ComboBox text cut when scaled.
  8.ComboBox change  sizes.
  9.Controls have incorrect scaling.
  
  3. Slider too big. Preferred width, which was removed in last patch update is 
needed. To replicate click applications and go back to devices.
  4. Number is lower from the slider's center line. Maybe the problem is with 
slider.
  5. Mute top margin is just random.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27505: Do not crash when icon's width or height is 0

2020-02-19 Thread Arjen Hiemstra
ahiemstra added a comment.


  In D27505#614240 , @davidedmundson 
wrote:
  
  > Would be good to dump this test qml somewhere in the repo. A folder full of 
tests which just have one component in a bunch of configurations.
  >  I've been pushing for that in p-f, and it catches so many things.
  
  
  Actually, it should be possible to test this as part of the autotests. 
However, I just found out that the Kirigami autotests are broken and have not 
run for a pretty long time. So I will make a separate patch for that.

REPOSITORY
  R169 Kirigami

BRANCH
  icon_crash

REVISION DETAIL
  https://phabricator.kde.org/D27505

To: ahiemstra, #kirigami, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, mart, hein


D27088: [applets/SystemTray] Implement sorting in the model

2020-02-19 Thread Konrad Materka
kmaterka added inline comments.

INLINE COMMENTS

> davidedmundson wrote in sortedsystemtraymodel.cpp:47
> I think calling QSortFilterProxyModel::lessThan(left, right); would do the 
> same
> 
> then you don't need compareDisplayAlphabetically
> 
> your implementation looks fine though, so do whichever

The question of being implicit or explicit. I like your idea more, will change 
that.

> davidedmundson wrote in sortedsystemtraymodel.h:35
> We tend not to write virtual at the start now we have the clearer override 
> keyword

Another embarrassing lack of C++ knowledge... Especially this "new" (hehe, 
C++11) feature :)

> davidedmundson wrote in systemtraymodel.cpp:115
> The applet is still alive after removeApplet is called. "this" is still alive
> 
> dataItem is not.
> 
> If an applet is added, removed   and then (potentially during applet 
> teardown) it changes its title, this would crash.
> 
> I don't know if that's a realistic scenario or not,  but I would still maybe 
> disconnect all signals from applet -> this on removeApplet?

During lifetime of the SystemTray, dataItems are never removed, they are just 
marked as not "renderable". Item is still alive, it is needed in configuration 
page (you can enable applet again in the configuration).

Anyway, it is a good idea to disconnect signals, for the sake of consisteny. In 
addition, dataItems are deleted eventually which may (?) lead to a crash on 
shutdown.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27088

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D27509: Introduce ProcessDataModel

2020-02-19 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Last release a plugin system was introduced that allowed plugins to
  provide columns of process data in a way that included enough metadata
  to allow displaying of said data appropriately without the client
  needing to be aware of the semantics of what that column represents.
  
  This patch provides all process information in that new format. This is
  then exposed as new, much simler, model.
  
  This new model is designed to be consumable from a QML API for any
  potential process data viewer.
  
  Existing models are unchanged for maximum compatibility.

TEST PLAN
  Used in another project

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27509

AFFECTED FILES
  CMakeLists.txt
  processcore/CMakeLists.txt
  processcore/extended_process_list.cpp
  processcore/extended_process_list.h
  processcore/process_attribute.cpp
  processcore/process_attribute.h
  processcore/process_attribute_model.cpp
  processcore/process_attribute_model.h
  processcore/process_data_model.cpp
  processcore/process_data_model.h
  processui/ProcessModel.cpp

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27495: Remove unnecessary code and function calls

2020-02-19 Thread Alexander Lohnau
alex updated this revision to Diff 76009.
alex added a comment.


  Remove unnecessary Q_UNUSED macro

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27495?vs=75963=76009

BRANCH
  shellrunner_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D27495

AFFECTED FILES
  runners/shell/CMakeLists.txt
  runners/shell/shellOptions.ui
  runners/shell/shell_config.cpp
  runners/shell/shell_config.h
  runners/shell/shellrunner.cpp
  runners/shell/shellrunner.h

To: alex, davidedmundson, ngraham, broulik
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27505: Do not crash when icon's width or height is 0

2020-02-19 Thread Arjen Hiemstra
ahiemstra added a comment.


  It most likely does, since Icon also has no implicit width/height it will 
default to 0 and crash when there's no special layout properties specified.

REPOSITORY
  R169 Kirigami

BRANCH
  icon_crash

REVISION DETAIL
  https://phabricator.kde.org/D27505

To: ahiemstra, #kirigami, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, mart, hein


D27316: [Folder view]Make shadow scale aware

2020-02-19 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4056e24b353d: [Folder view]Make shadow scale aware 
(authored by gvgeo, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27316?vs=75476=76007

REVISION DETAIL
  https://phabricator.kde.org/D27316

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson
Cc: broulik, davidedmundson, apol, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart


D27316: [Folder view]Make shadow scale aware

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  You've got so many landed patches under your belt now that I think it's time 
to apply for a developer account. :)
  
  https://community.kde.org/Infrastructure/Get_a_Developer_Account

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson
Cc: broulik, davidedmundson, apol, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart


D27505: Do not crash when icon's width or height is 0

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  Does this fix https://bugs.kde.org/show_bug.cgi?id=417844?

REPOSITORY
  R169 Kirigami

BRANCH
  icon_crash

REVISION DETAIL
  https://phabricator.kde.org/D27505

To: ahiemstra, #kirigami, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, mart, hein


D27481: Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart added a comment.


  In D27481#614250 , @davidre wrote:
  
  > In D27481#614167 , @davidre 
wrote:
  >
  > > I think the deisgn og the spacer could be better in edit mode to clearly 
mark it as a spacer but that can be done in the future if desired.
  >
  >
  > An idea could be to display something similiar to the icon on the "Add 
spacer" button on then or an arrow on each side
  
  
  any further change in design of the edit more graphics should be in a 
separate patch, it's besides the point here

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

2020-02-19 Thread Cyril Rossi
crossi updated this revision to Diff 76004.
crossi marked 6 inline comments as done.
crossi added a comment.


  Consider Kevin's comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=75360=76004

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27316: [Folder view]Make shadow scale aware

2020-02-19 Thread David Edmundson
davidedmundson added a comment.


  we would not need to remove it

REPOSITORY
  R119 Plasma Desktop

BRANCH
  shadow2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson
Cc: broulik, davidedmundson, apol, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart


D27481: Panel spacer that can center things

2020-02-19 Thread David Redondo
davidre added a comment.


  In D27481#614167 , @davidre wrote:
  
  > I think the deisgn og the spacer could be better in edit mode to clearly 
mark it as a spacer but that can be done in the future if desired.
  
  
  An idea could be to display something similiar to the icon on the "Add 
spacer" button on then or an arrow on each side

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27505: Do not crash when icon's width or height is 0

2020-02-19 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Weird. plasma-framework's version of icon (which this is copied from) has had 
that check for years.
  
  Would be good to dump this test qml somewhere in the repo. A folder full of 
tests which just have one component in a bunch of configurations.
  I've been pushing for that in p-f, and it catches so many things.

REPOSITORY
  R169 Kirigami

BRANCH
  icon_crash

REVISION DETAIL
  https://phabricator.kde.org/D27505

To: ahiemstra, #kirigami, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein


D27481: Panel spacer that can center things

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  Yeah it would be nice to call this an "Expanding spacer" or something like 
that. That's the term that we use for the rough equivalent for KXMLGui toolbars.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27422: [KCM]Update Device item layout based on applet

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  I'm seeing some weird jagginess on radio buttons, slider handles, and 
combobox shadows:
  
  F8112849: Screenshot_20200219_075319.png 

  
  This is just 1x scaling with no weird font DPI fiddling.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27505: Do not crash when icon's width or height is 0

2020-02-19 Thread Arjen Hiemstra
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  When Icon's width or height is 0, I get a crash with the following backtrace:
  
#0  0x77b9cd30 in QSGTexture::setFiltering(QSGTexture::Filtering) 
() from /usr/lib/libQt5Quick.so.5
#1  0x77bd439c in 
QSGOpaqueTextureMaterialShader::updateState(QSGMaterialShader::RenderState 
const&, QSGMaterial*, QSGMaterial*) () from /usr/lib/libQt5Quick.so.5
#2  0x77bb7857 in 
QSGBatchRenderer::Renderer::renderMergedBatch(QSGBatchRenderer::Batch const*) 
() from /usr/lib/libQt5Quick.so.5
#3  0x77bbd5b6 in QSGBatchRenderer::Renderer::renderBatches() () 
from /usr/lib/libQt5Quick.so.5
#4  0x77bbdcc5 in QSGBatchRenderer::Renderer::render() () from 
/usr/lib/libQt5Quick.so.5
#5  0x77ba1832 in QSGRenderer::renderScene(QSGBindable const&) () 
from /usr/lib/libQt5Quick.so.5
#6  0x77ba1d14 in QSGRenderer::renderScene(unsigned int) () from 
/usr/lib/libQt5Quick.so.5
#7  0x77c10713 in 
QSGDefaultRenderContext::renderNextFrame(QSGRenderer*, unsigned int) () from 
/usr/lib/libQt5Quick.so.5
#8  0x77c7b3a1 in QQuickWindowPrivate::renderSceneGraph(QSize 
const&, QSize const&) () from /usr/lib/libQt5Quick.so.5 
  
  This patch prevents Icon from doing anything when width or height is 0, 
avoiding the crash.

TEST PLAN
  The following QML code, when ran through qmlscene, no longer crashes:
  
import QtQuick 2.12
import org.kde.kirigami 2.11 as Kirigami
Item { 
Kirigami.Icon { source: "document-new" }
}

REPOSITORY
  R169 Kirigami

BRANCH
  icon_crash

REVISION DETAIL
  https://phabricator.kde.org/D27505

AFFECTED FILES
  src/icon.cpp

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27495: Remove unnecessary code and function calls

2020-02-19 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> shellrunner.cpp:68
>  {
>  Q_UNUSED(match);
>  

you can remove this line

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27495

To: alex, davidedmundson, ngraham, broulik
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27316: [Folder view]Make shadow scale aware

2020-02-19 Thread Nathaniel Graham
ngraham added a comment.


  So will we need to remove this multiplying by `units.devicePixelRatio` bit if 
and when we finally make plasmashell respect Qt scaling and fix 
https://bugs.kde.org/show_bug.cgi?id=356446?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  shadow2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson
Cc: broulik, davidedmundson, apol, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart


D27503: [KCM Spellchecking] port to KPropertySkeletonItem

2020-02-19 Thread Benjamin Port
bport created this revision.
bport added reviewers: Plasma, meven, crossi, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingskeleton.cpp
  kcms/spellchecking/spellcheckingskeleton.h

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27481: Panel spacer that can center things

2020-02-19 Thread David Redondo
davidre added a comment.


  I think the deisgn og the spacer could be better in edit mode to clearly mark 
it as a spacer but that can be done in the future if desired.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27481: Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart updated this revision to Diff 75990.
mart added a comment.


  - bigger in edit mode

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27481?vs=75988=75990

BRANCH
  mart/panelSpacer

REVISION DETAIL
  https://phabricator.kde.org/D27481

AFFECTED FILES
  applets/CMakeLists.txt
  applets/panelspacer/CMakeLists.txt
  applets/panelspacer/Messages.sh
  applets/panelspacer/contents/config/main.xml
  applets/panelspacer/contents/ui/main.qml
  applets/panelspacer/metadata.desktop
  applets/panelspacer/package/contents/config/main.xml
  applets/panelspacer/package/contents/ui/main.qml
  applets/panelspacer/package/metadata.desktop
  applets/panelspacer/plugin/CMakeLists.txt
  applets/panelspacer/plugin/panelspacer.cpp
  applets/panelspacer/plugin/panelspacer.h
  shell/panelconfigview.cpp

To: mart, #plasma, #vdg
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart added a comment.


  demo of adding 2 spacers and centering mode
  F8112648: vokoscreen-2020-02-19_13-43-02.mp4 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart updated this revision to Diff 75988.
mart added a comment.


  - put the second spacer at the beginning

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27481?vs=75980=75988

BRANCH
  mart/panelSpacer

REVISION DETAIL
  https://phabricator.kde.org/D27481

AFFECTED FILES
  applets/CMakeLists.txt
  applets/panelspacer/CMakeLists.txt
  applets/panelspacer/Messages.sh
  applets/panelspacer/contents/config/main.xml
  applets/panelspacer/contents/ui/main.qml
  applets/panelspacer/metadata.desktop
  applets/panelspacer/package/contents/config/main.xml
  applets/panelspacer/package/contents/ui/main.qml
  applets/panelspacer/package/metadata.desktop
  applets/panelspacer/plugin/CMakeLists.txt
  applets/panelspacer/plugin/panelspacer.cpp
  applets/panelspacer/plugin/panelspacer.h
  shell/panelconfigview.cpp

To: mart, #plasma, #vdg
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27316: [Folder view]Make shadow scale aware

2020-02-19 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Oh, of course

REPOSITORY
  R119 Plasma Desktop

BRANCH
  shadow2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson
Cc: broulik, davidedmundson, apol, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart


D27316: [Folder view]Make shadow scale aware

2020-02-19 Thread Kai Uwe Broulik
broulik added a comment.


  plasmashell doesn't use Qt scaling, so using `units.devicePixelRatio` is 
correct. It will be 2 when not used, and then divide by Qt scaling so Qt scales 
back up resulting in the same effect.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson
Cc: broulik, davidedmundson, apol, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart


D27316: [Folder view]Make shadow scale aware

2020-02-19 Thread George Vogiatzis
gvgeo added a comment.


  In D27316#613771 , @davidedmundson 
wrote:
  
  > I don't know
  >
  > You can find
  >
  > ./qml/QtGraphicalEffects/private/DropShadowBase.qml
  >
  > somewhere in /usr on your local system,
  >
  > add in some
  >  console.log lines and see what's happening.
  
  
  `Screen.devicePixelRatio` is always 1, while `units.devicePixelRatio` is 
correct.
  
  Checked in ./qml/QtGraphicalEffects/DropShadow.qml and other qml in ./qml/ 
including PC3 files.
  
  I have the same problem with the distro's build. So I guess this is a problem.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27316

To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson
Cc: davidedmundson, apol, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart


D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart updated this revision to Diff 75980.
mart marked 3 inline comments as done.
mart added a comment.


  - use a binding
  - use twinlayouts only when both are expanding

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27481?vs=75925=75980

BRANCH
  mart/panelSpacer

REVISION DETAIL
  https://phabricator.kde.org/D27481

AFFECTED FILES
  applets/CMakeLists.txt
  applets/panelspacer/CMakeLists.txt
  applets/panelspacer/Messages.sh
  applets/panelspacer/contents/config/main.xml
  applets/panelspacer/contents/ui/main.qml
  applets/panelspacer/metadata.desktop
  applets/panelspacer/package/contents/config/main.xml
  applets/panelspacer/package/contents/ui/main.qml
  applets/panelspacer/package/metadata.desktop
  applets/panelspacer/plugin/CMakeLists.txt
  applets/panelspacer/plugin/panelspacer.cpp
  applets/panelspacer/plugin/panelspacer.h

To: mart, #plasma, #vdg
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:30
> Why that?

no idea, is from the old applet and appears useless (also phab gets confused 
and doesn't understand the move of main.qml to a subfolder)

> broulik wrote in main.qml:77
> Does `Qt.callLater(foo)` work? It also compresses subsequent calls to the 
> same method (i.e. doesn't work with a closure)

yep, works

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

2020-02-19 Thread Jakob Kummerow
jakobkummerow added a comment.


  Thank you!

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D27362

To: jakobkummerow, davidedmundson, ahiemstra
Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D27407: Breeze widgetStyle value is Breeze

2020-02-19 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> defaults:8
>  [kdeglobals][Icons]
>  Theme=breeze
>  

?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

2020-02-19 Thread Arjen Hiemstra
ahiemstra added a comment.


  Now pushed with correct author information. :) Thanks!

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D27362

To: jakobkummerow, davidedmundson, ahiemstra
Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

2020-02-19 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:7a103a45e349: Linux/cpuinfo.c: grow buffer size as needed 
for 12+ core CPUs (authored by jakobkummerow, committed by ahiemstra).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27362?vs=75814=75975

REVISION DETAIL
  https://phabricator.kde.org/D27362

AFFECTED FILES
  ksysguardd/Linux/cpuinfo.c

To: jakobkummerow, davidedmundson, ahiemstra
Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D27481: [WIP]Panel spacer that can center things

2020-02-19 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> main.xml:15
>  length in pixels of the spacer. Configuration effective only 
> if expanding is set to false.
> +-1
>  

Please mention in the label what `-1` means

> main.qml:30
> +
> +z: 
> +property bool horizontal: plasmoid.formFactor !== 
> PlasmaCore.Types.Vertical

Why that?

> main.qml:68
> +action.checkable = true;
> +action.checked = plasmoid.configuration.expanding;
> +

Could be a `Qt.binding`?

> main.qml:77
> +// Every time this binding gets reevaluated we want to queue a 
> recomputation of the size hints
> +relayoutTimer.restart();
> +if (!twinSpacer || !panelLayout || !leftTwin || !rightTwin) {

Does `Qt.callLater(foo)` work? It also compresses subsequent calls to the same 
method (i.e. doesn't work with a closure)

> main.qml:95
> +for (var i in panelLayout.children) {
> +if (!panelLayout.children[i].visible) {
> +continue;

Please cache `panelLayout.children[i]` in a variable to make the code below 
somewhat more readable

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27482: Update kdeglobals config file for Breeze widgetStyle

2020-02-19 Thread Cyril Rossi
crossi added a comment.


  In D27482#614006 , @meven wrote:
  
  > Works : replace widgetStyle in group KDE and selects the application style 
in systemsettings; Does not edit widgetStyle in group General
  
  
  Thanks for the confirmation.
  
  > +1 on fixing whatever lowercased the value in the first place. Comment by 
@bport
  
  Fixed by D27407 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27482: Update kdeglobals config file for Breeze widgetStyle

2020-02-19 Thread Méven Car
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Works : replace widgetStyle in group KDE and selects the application style in 
systemsettings; Does not edit widgetStyle in group General
  
  +1 on fixing whatever lowercased the value in the first place. Comment by 
@bport

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27482: Update kdeglobals config file for Breeze widgetStyle

2020-02-19 Thread Benjamin Port
bport added inline comments.

INLINE COMMENTS

> style_widgetstyle_default_breeze.pl:8
> +chomp;
> +s/widgetStyle=breeze/widgetStyle=Breeze/;
> +print "$_\n";

This will fix only for Breeze theme
This will fix existing case but we also need to fix the root cause (i.e. how we 
end up with a lowercase name).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27422: [KCM]Update Device item layout based on applet

2020-02-19 Thread George Vogiatzis
gvgeo updated this revision to Diff 75971.
gvgeo added a comment.


  Kirigami units.
  Remove unnecessary preferred width.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27422?vs=75935=75971

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27482: Update kdeglobals config file for Breeze widgetStyle

2020-02-19 Thread Cyril Rossi
crossi added a comment.


  Weird, I've tested again, and works like expected on my machine.
  
  Is it the `widgetStyle` entry from `KDE` group ?
  
  I have also an entry named `widgetStyle` in group `General` but we are not 
interested in that one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27495: Remove unnecessary code and function calls

2020-02-19 Thread Alexander Lohnau
alex created this revision.
alex added reviewers: davidedmundson, ngraham, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The ShellConfig class has been deleted. This config class was in KDE4 for the 
runOptions widget used and the class/the settings are not used anymore.
  Additionally the context type check has been removed, because this is already 
solved using the ignore types.
  Futhermore the match icon and the list of actions can be reused.

TEST PLAN
  Should compile and execute shell commands as before.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shellrunner_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D27495

AFFECTED FILES
  runners/shell/CMakeLists.txt
  runners/shell/shellOptions.ui
  runners/shell/shell_config.cpp
  runners/shell/shell_config.h
  runners/shell/shellrunner.cpp
  runners/shell/shellrunner.h

To: alex, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart