[kio-extras] [Bug 354004] smb kioslave timeouts looking for kerberos authentication

https://bugs.kde.org/show_bug.cgi?id=354004 --- Comment #3 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76436. cblack added a comment. Recolour text with titlebar colour REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76435=76436 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Could we draw the line in the window decoration theme then? Could it communicate in some way with the widgets theme to know what's beneath it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze Cc: ngraham,

D27669: WIP: [kstyle] Tools area

cblack added a comment. In D27669#618083 , @ngraham wrote: > In terms of the appearance for windows without a menubar or toolbar (e.g. system settings) I think the latest mockups has a horizontal line below the titlebar itself, so that should

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Nice! Obviously this needs to be paired with appropriate changes to the default Breeze color scheme to replicate the desired look in T10201 :) Here's a quick-and-dirty version of the Breeze Evolved color scheme: {F8132321

D27667: Align wallpaper dialog to bottom

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH anchor-thumbnail-to-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D27667 To:

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76435. cblack added a comment. Relocate painter restore REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76434=76435 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27669: WIP: [kstyle] Tools area

cblack created this revision. cblack added reviewers: Plasma, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY There is now a tools area. REPOSITORY R31 Breeze BRANCH cblack/toolsarea REVISION

Plasma 5.18.2

Plasma 5.18.2 is now released https://www.kde.org/announcements/plasma-5.18.2.php

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

nicolasfella added inline comments. INLINE COMMENTS > kdeplatformdependent.cpp:165 > +// directly requests the accounts kcm to start adding a new account if > it's not there, maybe even pre-fills the fields...) > +KService::List services = >

D27636: Remove redundant match for mountpoints

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0acbfba3b0e4: Remove redundant match for mountpoints (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27636?vs=76333=76432 REVISION

D27667: Align wallpaper dialog to bottom

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Align wallpaper dialog to bottom instead of vertically centering it between the theme info and the bottom of the frame. BUG:

D27666: Support WPA3-SAE in the applet popup

hexchain updated this revision to Diff 76430. hexchain added a comment. Remove accidental new empty line REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27666?vs=76429=76430 BRANCH plasma-nm-support-sae (branched from master)

D27666: Support WPA3-SAE in the applet popup

hexchain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. hexchain requested review of this revision. REVISION SUMMARY Add support for WPA3-SAE in the applet popup: - The "Security type" field in the

D27664: Improve layout and appearance of app details view

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY After porting to FormLayout in D27183

D27663: Show tooltip with full URL for URL button with overridden text

ngraham created this revision. ngraham added reviewers: VDG, Kirigami, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Normally the `URLButton` shows the full URL in its text. However if this text

D27643: FileChooser: download remote files to a cache location to open them through the portal

feverfew added a comment. With a brief look the ideal scenario is to be able to use `DesktopExecParser::resultingArguments`, or a class that calls it `KRun`. That should do the conversion. I'm just not sure if you have the information required to use it. See D23384

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. You're right, it does work for GTK2 apps on my system, but not GTK3 apps. :/ BAH I say! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven, davidedmundson Cc: chauvin,

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

chauvin added a comment. In D27380#617927 , @ngraham wrote: > All fonts tested. :( Thunderbird is a gtk3 application ? If I manually change .gtkrc-2.0 with this line: gtk-font-name="Ubuntu, Italic 9" Gimp and Inskape

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. BAH! So what kind of font styles do work? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven, davidedmundson Cc: chauvin, davidre, davidedmundson, cfeck, ngraham,

D27661: wireguard: Trim IP list before submitting to NM

hexchain updated this revision to Diff 76418. hexchain edited the summary of this revision. hexchain edited the test plan for this revision. hexchain added a comment. Edited summary according to guidelines REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari added a comment. In D27380#617927 , @ngraham wrote: > All fonts tested. :( Hm, I can't get it work too. On GNOME via tweaks Italic fonts also do not work, so I guess it is a GTK bug. REPOSITORY R99 KDE Gtk Configuration Tool

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. All fonts tested. :( REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven, davidedmundson Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage,

D27661: wireguard: Trim IP list before submitting to NM

hexchain updated this revision to Diff 76417. hexchain added a comment. Updated according to comments. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27661?vs=76414=76417 REVISION DETAIL https://phabricator.kde.org/D27661

D27661: wireguard: Trim IP list before submitting to NM

usta added inline comments. INLINE COMMENTS > wireguardpeerwidget.cpp:197 > + > +for (QString : rawIPList) { > +ipList.append(ip.trimmed()); const REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27661 To: hexchain, jgrulich Cc:

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari added a comment. In D27380#617774 , @ngraham wrote: > Thanks. > > So if I set the general font to 9pt Ubuntu Italic, then in the config file I see `gtk-font-name=Ubuntu, Italic 9` and Thunderbird respects the font, and the size, but

D27661: wireguard: Trim IP list before submitting to NM

hexchain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. hexchain requested review of this revision. REVISION SUMMARY The `SimpleIpListValidator` validates each trimmed item in a comma-separated list, but

D27420: [Applet]Improvements for unavailable port.

gvgeo added a comment. Don't see anyone objecting, will commit later. REPOSITORY R115 Plasma Audio Volume Applet BRANCH FreeThePort3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27420 To: gvgeo, #plasma, drosca, ngraham Cc: pino, plasma-devel, Orage, LeGast00n,

Re: breeze-gtk now in invent

On Wed, 26 Feb 2020, 1:50 AM Jonathan Riddell, wrote: > breeze-gtk seems to have moved to invent for development. > > Looking through the list on invent I don't see any other Plasma projects > there. > > That's cool but it's useful to know when and why moves like this happens > as it needs

D26934: KCM/Autostart Add a model to separate logic from UI

ervin added inline comments. INLINE COMMENTS > autostart.cpp:87 > > +setMinimumHeight(300); > +setMinimumWidth(400); Unrelated right? Where do this come from? > autostart.cpp:112 > > -void Autostart::addItem( DesktopStartItem* item, const QString& name, const > QString& run, const

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

apol added a comment. In D27518#617439 , @ahmadsamir wrote: > In D27518#617038 , @apol wrote: > > > Makes sense. Have you tested that this works? You should probably pass KF5::GuiAddons to the

D27643: FileChooser: download remote files to a cache location to open them through the portal

ngraham added a comment. In D27643#617800 , @apol wrote: > This really isn't ideal. It means we can't deal with any biggish files without having to cache them first. > Also saving back (e.g. in kate) won't work, right? > > Maybe we can

D27643: FileChooser: download remote files to a cache location to open them through the portal

apol added a comment. This really isn't ideal. It means we can't deal with any biggish files without having to cache them first. Also saving back (e.g. in kate) won't work, right? Maybe we can come up with a solution with fuse? REPOSITORY R838 Flatpak Support: KDE Portal for XDG

D27638: allow to take qqc2 actions and fix issues with it not having the visible prop

apol added inline comments. INLINE COMMENTS > ActionToolBar.qml:211 > id: button > +visible: true > flat: root.flat && !kirigamiAction.icon.color.a Isn't visible true by default? > ActionToolBarLayoutDetails.qml:138 > PrivateActionToolButton { > +

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. Thanks. So if I set the general font to 9pt Ubuntu Italic, then in the config file I see `gtk-font-name=Ubuntu, Italic 9` and Thunderbird respects the font, and the size, but not the style; it's not italic. :( Or is that a separate issue? REPOSITORY R99

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

camiloh added a comment. works okay for me with qqc2 actions REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27653 To: ahiemstra, #kirigami Cc: camiloh, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart,

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > spellchecking.cpp:55 > + > +auto referenceValue = m_settings->currentIgnoreList(); > +auto currentValue = m_configWidget->ignoreList(); What about

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea08681efe5e: libnotificationmanager : deprecate Settings ctor that takes a config (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27651: Fixes for applet configuration layout.

gvgeo abandoned this revision. gvgeo added a comment. Accidental patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27651 To: gvgeo, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27116: KCM/Component email: simplify code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3d2dfabe5509: KCM/Component email: simplify code (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27116?vs=75846=76393 REVISION DETAIL

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca02af6584c6: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27100: [GTK Config] Parameterise GTK config editing

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. There's a lot of string concatenation going on. I would replace a lot of the instances where you concat more than 2 strings with QString's arg function for readability purposes.

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari added a comment. In D27380#617677 , @ngraham wrote: > Do you need to reload any daemon to get this to work? Yes REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari,

D27608: Fixes for applet configuration layout.

ngraham added a comment. Visually +1. I'm starting to agree that this is the wrong place to add the titlebar separator. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf Cc: ngraham, filipf, plasma-devel, Orage,

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. Do you need to reload any daemon to get this to work? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven, davidedmundson Cc: chauvin, davidre, davidedmundson, cfeck, ngraham,

D27648: [KCM]Set implicitWidth for main page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch please! REPOSITORY R115 Plasma Audio Volume Applet BRANCH init (branched from master) REVISION DETAIL https://phabricator.kde.org/D27648 To: gvgeo, #plasma, #vdg,

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport updated this revision to Diff 76385. bport added a comment. Take change from sonnet patch in consideration and other ervin feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27503?vs=75998=76385 REVISION DETAIL

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

ognarb added inline comments. INLINE COMMENTS > ActionToolBarLayoutDetails.qml:126 > + > +if (modelData.hasOwnProperty("displayHint") && > + > modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide)) { I think this can be simplified to

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi updated this revision to Diff 76380. crossi added a comment. constexpr REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26834?vs=76379=76380 REVISION DETAIL https://phabricator.kde.org/D26834 AFFECTED FILES

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi updated this revision to Diff 76379. crossi added a comment. constexpr instead of static REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26834?vs=74116=76379 REVISION DETAIL https://phabricator.kde.org/D26834 AFFECTED FILES

D27100: Parameterise GTK config editing

gikari added a comment. Ping REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27100 To: gikari Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D27626: refactor: fix various compiler warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R104:51fd586686a8: refactor: fix various compiler warnings (authored by dvratil). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27626?vs=76302=76377 REVISION DETAIL

D27626: refactor: fix various compiler warnings

dvratil added a comment. Also note that `noexcept` is not a compile-time check, it's a hint to enable some optimizations. It makes a difference when using standard library containers, e.g. `std::vector` will perform a copy if `T`'s move constructor is not `noexcept` in order to guarantee

D27626: refactor: fix various compiler warnings

dvratil added a comment. A good rule of a thumb is that your move constructor and assignment operator should always be `noexcept` unless you have a very good reason for them not to be. Qt has most move constructors marked as noexcept - I found a few that are not marked but that looks more

D27189: Created a top area based on widgets/toparea.svg

niccolove added inline comments. INLINE COMMENTS > mart wrote in ExpandedRepresentation.qml:48 > not in all places you will have access to a dialog. the magic correct values > should come from the toparea margins itself done to go well with the > correspoding background svg. > > in the end, i

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 76374. niccolove added a comment. Used toparea margins rather than systray dialog.margins REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=75095=76374 BRANCH topbar (branched from master) REVISION

D27481: Panel spacer that can center things

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7b3b06a48576: Panel spacer that can center things (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=76369=76372 REVISION DETAIL

D27643: FileChooser: download remote files to a cache location to open them through the portal

fvogt added a comment. In D27643#617558 , @ngraham wrote: > Shouldn't KIO take care of this stuff automatically? I wouldn't want to lose streaming support for Flatpak apps. It should, but there's no API for that yet. At some point

D27481: Panel spacer that can center things

mart marked 7 inline comments as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in panelconfigview.cpp:115 > Seems like Panel could benefit from some sort of...ContinamentLayoutManager? > > Effectively we're evaluating what RowLayout evaluates by hand here anyway, it

D27481: Panel spacer that can center things

mart updated this revision to Diff 76369. mart added a comment. - take maximum size into account - document -1 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75990=76369 BRANCH mart/panelSpacer REVISION DETAIL

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This applies a few fixes to ActionToolBar and PrivateActionToolButton when used in

D27643: FileChooser: download remote files to a cache location to open them through the portal

ngraham added reviewers: feverfew, fvogt. ngraham added a comment. Shouldn't KIO take care of this stuff automatically? I wouldn't want to lose streaming support for Flatpak apps. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL

D27626: refactor: fix various compiler warnings

romangg added inline comments. INLINE COMMENTS > dvratil wrote in output_model.h:90 > Because in `output_model.cpp:224` we do `m_outputs.insert(i, Output(output, > pos))`, which can make use of move semantics. > > Making move operations `noexcept` is part of Cpp Core Guidelines >

D27650: Don't use guarded pointers for AppletsLayout

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > This function takes a plain pointer and wraps it into weak shared pointer. That's QWeakPointer. QPointer is something else that doesn't have an

D27481: Panel spacer that can center things

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in main.xml:15 > Please mention in the label what `-1` means this needs doing > main.qml:109 > +if (root.horizontal) { > +middleItemsHint += Math.max(child.Layout.minimumWidth, >

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ervin added a comment. LGTM, now requires swift testing to not miss the next bugfix release REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven, davidedmundson Cc: chauvin, davidre, davidedmundson, cfeck,

D27651: Fixes for applet configuration layout.

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Fix applet configuration overlap with top line. Change the margins to move scrollbar so that it

D27650: Don't use guarded pointers for AppletsLayout

alnikiforov created this revision. alnikiforov added reviewers: ngraham, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REVISION SUMMARY Using these pointer types incorrectly leads to premature

D27625: fix: handle when backend fails to load/initialize

This revision was automatically updated to reflect the committed changes. Closed by commit R110:ff98585ea554: fix: handle when backend fails to load/initialize (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27625?vs=76295=76359

D27626: refactor: fix various compiler warnings

dvratil added inline comments. INLINE COMMENTS > romangg wrote in output_model.h:90 > Why to add and why noexcept? Because in `output_model.cpp:224` we do `m_outputs.insert(i, Output(output, pos))`, which can make use of move semantics. Making move operations `noexcept` is part of Cpp Core

D27648: [KCM]Set implicitWidth for main page

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Set implicitWidth in the main page for the initial size when opening audio

Re: breeze-gtk now in invent

On 02/25/20 13:50, Jonathan Riddell wrote: breeze-gtk seems to have moved to invent for development. Looking through the list on invent I don't see any other Plasma projects there. That's cool but it's useful to know when and why moves like this happens as it needs changes to my release scrips

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 125 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/125/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 25 Feb 2020 12:35:45 + Build duration: 32 min and counting CONSOLE OUTPUT

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 56 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/56/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Feb 2020 12:48:45 + Build duration: 9 min 20 sec and counting CONSOLE OUTPUT

breeze-gtk now in invent

breeze-gtk seems to have moved to invent for development. Looking through the list on invent I don't see any other Plasma projects there. That's cool but it's useful to know when and why moves like this happens as it needs changes to my release scrips and others will get a surprise when they

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 279 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/279/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Feb 2020 12:35:44 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 37 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/37/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 25 Feb 2020 12:33:05 + Build duration: 8 min 12 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 61 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/61/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Feb 2020 12:33:05 + Build duration: 3 min 3 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/5/ Project: stable-kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 25 Feb 2020 12:32:55 + Build duration: 2 min 26 sec and counting CONSOLE

D27608: Fixes for applet configuration layout.

gvgeo added a comment. Can't have everything. now will cat line again. F8130965: Screenshot_20200225_140134.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf Cc: ngraham,

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76356. gvgeo added a comment. Categories touch top and bottom. Removed 1 unnecessary line. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76320=76356 BRANCH configscollcat (branched from master)

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76355. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. target_link_libraries() KGuiAddons REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76266=76355 BRANCH l-khelp

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir added a comment. In D27518#617038 , @apol wrote: > Makes sense. Have you tested that this works? You should probably pass KF5::GuiAddons to the target_link_libraries as well. I tested a good number of the KCMs, and it seems to

D27645: [KCM]Align volume controls row

gvgeo added inline comments. INLINE COMMENTS > VolumeSlider.qml:43 > +// Workaround: Slider has 2 extra pixels at the bottom, used for the > tickmarks, which move it off-center. > +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11) > + I tried to change

D27645: [KCM]Align volume controls row

broulik added inline comments. INLINE COMMENTS > VolumeSlider.qml:43 > +// Workaround: Slider has 2 extra pixels at the bottom, used for the > tickmarks, which move it off-center. > +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11) > + Eww. Can we fix the slider

D27645: [KCM]Align volume controls row

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Align mute button, slider and percent text. Set proper margin for mute. Cut

D27166: Refactor converter runner

alex added a comment. In D27166#617379 , @sitter wrote: > Yeah, I don't think I understand. I am sure a unit test would make things clearer ;) ;) Yes, I will add one :-). And in the last commit I just used a regex feature which matches

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi added a comment. @broulik any thoughts on this ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26834 To: crossi, ervin, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D27643: FileChooser: download remote files to a cache location to open them through the portalBUG: 418155

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27643 AFFECTED

D27096: Refactoring, improve validation in kcm, optimize

alex updated this revision to Diff 76350. alex added a comment. - Implement suggestion REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27096?vs=75358=76350 BRANCH charrunner_improvements (branched from master) REVISION DETAIL

D27166: Refactor converter runner

sitter added a comment. Yeah, I don't think I understand. I am sure a unit test would make things clearer ;) ;) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage, LeGast00n,

D27096: Refactoring, improve validation in kcm, optimize

sitter added a subscriber: davidre. sitter added a comment. Huh, guess kconfig never goes to QString after all. @davidre had a similar suggestion of using auto instead and let the compiler do its work IIRC dvratil's comment still applies to DEFAULT_TRIGGERWORD though. Generally

D27166: Refactor converter runner

alex updated this revision to Diff 76347. alex added a comment. Use character types for currency symbols in regex REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=76324=76347 BRANCH converter_runner_refactoring (branched from master)

D27166: Refactor converter runner

sitter added a comment. 12? Why 12? Or I guess the more pertinent question: where is that limit set? INLINE COMMENTS > converterrunner.cpp:86 > +matchRegex.optimize(); > +//qInfo() << matchRegex.pattern(); > } left over debug REPOSITORY R114 Plasma Addons REVISION DETAIL

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added inline comments. INLINE COMMENTS > bport wrote in style_widgetstyle_default_breeze.pl:8 > This will fix only for Breeze theme > This will fix existing case but we also need to fix the root cause (i.e. how > we end up with a lowercase name). Root cause was fixed by D27407

Re: Plasma Sprint 2020 in Augsburg, Germany

Hi, My plan is to commute from Munich daily, so for the purpose of the sprint you can consider I have a place to stay :) Ah, okay, yeah, sure, come hang out with us ;) Cheers Kai Uwe

D27608: Fixes for applet configuration layout.

filipf added a comment. Looks good to me and solves 3 of the 4 binding loops, although this one still remains: `file:///usr/share/plasma/shells/org.kde.plasma.desktop/contents/configuration/AppletConfiguration.qml:296:25: QML StackView: Binding loop detected for property "height"`

Re: Feature requests re: 5.18 changes

Hi Derek, First, I liked the old notification style with the linear countdown meter; I don't know what about the new style rubs me the wrong way, but I think it would be neat to have a toggle in notification settings to switch between countdown meter styles. Is it misaligned for you?